[jira] [Resolved] (WW-5145) Checkbox with multiple values do not default correctly
[
https://issues.apache.org/jira/browse/WW-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-5145.
---
Resolution: Not A Problem
> Checkbox with multiple values do not default correctly
> --
>
> Key: WW-5145
> URL: https://issues.apache.org/jira/browse/WW-5145
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.25
>Reporter: nikos dimitrakas
>Priority: Minor
> Labels: checkbox
> Fix For: 6.1.0
>
>
> Using multiple s:checkbox (with the same name) together with a List (of
> Integer or String, etc) does not preselect the right checkboxes. This
> behaviour is inconsistent with all the other form components that get the
> default values based on their name. I have constructed a simple example for
> illustrating and testing. My actual case is more complex with dynamic data.
> Action class:
> {code:java}
> public class TestAction extends ActionSupport {
> private List number;
>
> public List getNumber() {
>return number;
> }
>
> public void setNumber(List number) {
>this.number = number;
> }
> public String execute() {
>//Try with some default, empty list, null
>if (number == null) number = Collections.singletonList(2);
>return SUCCESS;
> }
> }
> {code}
> JSP:
> {code:html}
> <%@ taglib prefix="s" uri="/struts-tags_rt" %>
>
>
>
> 1
> 2
> 3
> 4
> Push
>
>
>
> {code}
> Action configuration:
> {code:xml}
>
> test.jsp
>
> {code}
> One would expect that the checkboxes should be checked if the corresponding
> value is in the list. But instead all checkboxes get checked if the list is
> not null (independent of its content). And all checkboxes are unchecked if
> the list is null. Submitting the form after selecting some checkboxes does
> send the values correctly to the action, but once again when rendering the
> checkboxes, they all get checked if the list is not null.
> I can simply fix this by adding the value attribute with an expression to
> each checkbox, but it feels like this should be the default behaviour:
> {code}
> 1
> 2
> 3
> 4
> {code}
> Another workaround is to use a Map and in that case all
> checkboxes are checked and unchecked correctly, but it feels unnecessary
> since every entry will always have value true and the only interesting part
> of the map will be the keySet (which is essentially the list). But it is
> interesting that the checkboxes behave as expected when using a Map, but not
> when using a List.
> I am not really sure if this relates to WW-4865
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute
[
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart closed WW-5247.
-
Resolution: Not A Problem
Upgrade to Struts 6.0.3 or newer
> Related to: [WW-5117] - %{id} evaluates different for data-* and value
> attribute
>
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
> id="currentObj" name="${roleEntry.value}" >
>
> property="name" />
> style="width:1%">
> theme="simple" action="getRoleAuthRolesPerms" >
> value="%\{#attr.currentObj.roleid}" />
> indicator="roleIndicator" cssClass="tooltipBorderless" title="View Role"
> type="image" src="../img/view.gif" />
>
>
>
>
> Generates:
> action="/apps/epar/getRoleAuthRolesPerms.action" method="post"
> class="formstyle">
> value="159" id="getRole159_authorityRole_roleid">
> id="submit_213350257" value="Submit" class="tooltipBorderless" title="View
> Role">
>
> jQuery(document).ready(function () {
> var options_submit_213350257 = {};
> options_submit_213350257.jqueryaction = "button";
> options_submit_213350257.id = "submit_213350257";
> options_submit_213350257.targets = "roleAjaxDiv";
> options_submit_213350257.href = "#";
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> options_submit_213350257.indicatorid = "roleIndicator";
> options_submit_213350257.effect = "highlight";
> options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
> });
>
>
> The JS that it generates does NOT translate:
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30.
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to:
> * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5137) Remove class attribute
[
https://issues.apache.org/jira/browse/WW-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623043#comment-17623043
]
ASF subversion and git services commented on WW-5137:
-
Commit 9e7e0b395dbe743741bcc47fb9a276e5107f3efb in struts's branch
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=9e7e0b395 ]
Merge pull request #624 from apache/WW-5137-class
[WW-5137] Removes deprecated class attribute
> Remove class attribute
> --
>
> Key: WW-5137
> URL: https://issues.apache.org/jira/browse/WW-5137
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Results
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove deprecated {{class}} attribute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (WW-5137) Remove class attribute
[
https://issues.apache.org/jira/browse/WW-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-5137.
---
Resolution: Fixed
> Remove class attribute
> --
>
> Key: WW-5137
> URL: https://issues.apache.org/jira/browse/WW-5137
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Results
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove deprecated {{class}} attribute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5137) Remove class attribute
[
https://issues.apache.org/jira/browse/WW-5137?focusedWorklogId=819532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819532
]
ASF GitHub Bot logged work on WW-5137:
--
Author: ASF GitHub Bot
Created on: 24/Oct/22 08:24
Start Date: 24/Oct/22 08:24
Worklog Time Spent: 10m
Work Description: lukaszlenart merged PR #624:
URL: https://github.com/apache/struts/pull/624
Issue Time Tracking
---
Worklog Id: (was: 819532)
Time Spent: 0.5h (was: 20m)
> Remove class attribute
> --
>
> Key: WW-5137
> URL: https://issues.apache.org/jira/browse/WW-5137
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Results
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove deprecated {{class}} attribute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5137) Remove class attribute
[
https://issues.apache.org/jira/browse/WW-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623042#comment-17623042
]
ASF subversion and git services commented on WW-5137:
-
Commit 3e30d0c375b17b817abfa329c2f88976e8ddbba1 in struts's branch
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3e30d0c37 ]
WW-5137 Removes deprecated class attribute
> Remove class attribute
> --
>
> Key: WW-5137
> URL: https://issues.apache.org/jira/browse/WW-5137
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Results
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Remove deprecated {{class}} attribute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-3725) Remove unused tag templates from core/src/main/resources/template/archive
[ https://issues.apache.org/jira/browse/WW-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623037#comment-17623037 ] ASF subversion and git services commented on WW-3725: - Commit 784293e46f173d18bbd1be89f1b3afd04f3c2172 in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=784293e46 ] Merge pull request #623 from apache/WW-3725-remove [WW-3725] Removes unused template > Remove unused tag templates from core/src/main/resources/template/archive > - > > Key: WW-3725 > URL: https://issues.apache.org/jira/browse/WW-3725 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Remove the tags templates that are not used anymore -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-3725) Remove unused tag templates from core/src/main/resources/template/archive
[ https://issues.apache.org/jira/browse/WW-3725?focusedWorklogId=819526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819526 ] ASF GitHub Bot logged work on WW-3725: -- Author: ASF GitHub Bot Created on: 24/Oct/22 08:13 Start Date: 24/Oct/22 08:13 Worklog Time Spent: 10m Work Description: lukaszlenart merged PR #623: URL: https://github.com/apache/struts/pull/623 Issue Time Tracking --- Worklog Id: (was: 819526) Time Spent: 0.5h (was: 20m) > Remove unused tag templates from core/src/main/resources/template/archive > - > > Key: WW-3725 > URL: https://issues.apache.org/jira/browse/WW-3725 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Remove the tags templates that are not used anymore -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-3725) Remove unused tag templates from core/src/main/resources/template/archive
[ https://issues.apache.org/jira/browse/WW-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-3725. --- Resolution: Fixed > Remove unused tag templates from core/src/main/resources/template/archive > - > > Key: WW-3725 > URL: https://issues.apache.org/jira/browse/WW-3725 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Remove the tags templates that are not used anymore -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-3725) Remove unused tag templates from core/src/main/resources/template/archive
[ https://issues.apache.org/jira/browse/WW-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623036#comment-17623036 ] ASF subversion and git services commented on WW-3725: - Commit 956700133a2ba114a3a749fe1a5b22214a7c in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=95670 ] WW-3725 Removes unused template > Remove unused tag templates from core/src/main/resources/template/archive > - > > Key: WW-3725 > URL: https://issues.apache.org/jira/browse/WW-3725 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Remove the tags templates that are not used anymore -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5133) Remove deprecated labelposition
[ https://issues.apache.org/jira/browse/WW-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623035#comment-17623035 ] ASF subversion and git services commented on WW-5133: - Commit 58dcc830ea5acb3dff158e7bbb3645558d52cff7 in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=58dcc830e ] Merge pull request #622 from apache/WW-5133-labelposition [WW-5133] Drops labelposition attribute > Remove deprecated labelposition > --- > > Key: WW-5133 > URL: https://issues.apache.org/jira/browse/WW-5133 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > See WW-5132 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5133) Remove deprecated labelposition
[ https://issues.apache.org/jira/browse/WW-5133?focusedWorklogId=819525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819525 ] ASF GitHub Bot logged work on WW-5133: -- Author: ASF GitHub Bot Created on: 24/Oct/22 08:12 Start Date: 24/Oct/22 08:12 Worklog Time Spent: 10m Work Description: lukaszlenart merged PR #622: URL: https://github.com/apache/struts/pull/622 Issue Time Tracking --- Worklog Id: (was: 819525) Time Spent: 0.5h (was: 20m) > Remove deprecated labelposition > --- > > Key: WW-5133 > URL: https://issues.apache.org/jira/browse/WW-5133 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > See WW-5132 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5133) Remove deprecated labelposition
[ https://issues.apache.org/jira/browse/WW-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5133. --- Resolution: Fixed > Remove deprecated labelposition > --- > > Key: WW-5133 > URL: https://issues.apache.org/jira/browse/WW-5133 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > See WW-5132 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5133) Remove deprecated labelposition
[ https://issues.apache.org/jira/browse/WW-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623034#comment-17623034 ] ASF subversion and git services commented on WW-5133: - Commit 943cb6295393a784719e00dc4a9d0465e3d150ca in struts's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=943cb6295 ] WW-5133 Drops labelposition attribute > Remove deprecated labelposition > --- > > Key: WW-5133 > URL: https://issues.apache.org/jira/browse/WW-5133 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > See WW-5132 -- This message was sent by Atlassian Jira (v8.20.10#820010)
