[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311789541 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=635) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311407935 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=635) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![90.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png '90.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [90.0% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?focusedWorklogId=825199=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825199 ] ASF GitHub Bot logged work on WW-5260: -- Author: ASF GitHub Bot Created on: 11/Nov/22 08:38 Start Date: 11/Nov/22 08:38 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311394775 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=636) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![91.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png '91.7%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [91.7% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) Issue Time Tracking --- Worklog Id: (was: 825199) Time Spent: 0.5h (was: 20m) > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #636: [WW-5260] Introduces a constant to set submitUnchecked attribute of checkbox tag globally
sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311394775 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=636) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![91.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png '91.7%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [91.7% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632161#comment-17632161 ] ASF subversion and git services commented on WW-5260: - Commit 65ae2b7e4fab783d818bd9cfaec5efb3cbf85053 in struts's branch refs/heads/WW-5260-global-submit-unchecked from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=65ae2b7e4 ] WW-5260 Introduces a constant to set submitUnchecked attribute of checkbox tag globally > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.1 > > Time Spent: 20m > Remaining Estimate: 0h > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #635: [WW-4173] Introduces a dedicated interface to allow conditionally disabling a given interceptor
sonarcloud[bot] commented on PR #635: URL: https://github.com/apache/struts/pull/635#issuecomment-1311388368 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=635) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=635=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=635=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=635=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts=635=false=CODE_SMELL) [![90.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/90-16px.png '90.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [90.0% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=635=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=635=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?focusedWorklogId=825194=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825194 ] ASF GitHub Bot logged work on WW-5260: -- Author: ASF GitHub Bot Created on: 11/Nov/22 08:27 Start Date: 11/Nov/22 08:27 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311383764 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=636) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) Issue Time Tracking --- Worklog Id: (was: 825194) Time Spent: 20m (was: 10m) > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.1 > > Time Spent: 20m > Remaining Estimate: 0h > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #636: [WW-5260] Introduces a constant to set submitUnchecked attribute of checkbox tag globally
sonarcloud[bot] commented on PR #636: URL: https://github.com/apache/struts/pull/636#issuecomment-1311383764 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_struts=636) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts=636=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts=636=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=636=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts=636=false=CODE_SMELL) [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_struts=636=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts=636=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (WW-5257) output is followed by a newline in simple theme (diff to Struts 2)
[ https://issues.apache.org/jira/browse/WW-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart reopened WW-5257: --- [~pduroux] take a look on WW-5260, after review I reverted to previous behaviour and the new line is gone :) > output is followed by a newline in simple theme (diff to Struts > 2) > --- > > Key: WW-5257 > URL: https://issues.apache.org/jira/browse/WW-5257 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Patrice DUROUX >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Hi, > I notice a small difference comparing HTML outputs between the Struts 2.x and > Struts 6.x for code like this > {noformat} > > {noformat} > for instance and where the output is now like: > {noformat} > > > {noformat} > and no more like: > {noformat} > {noformat} > Is this expected? > > Regards, > Patrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632155#comment-17632155 ] Lukasz Lenart commented on WW-5260: --- [~Britta] could you review the linked PR? I added a constant `struts.ui.checkbox.submitUnchecked` to define this attribute globally. > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?focusedWorklogId=825191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825191 ] ASF GitHub Bot logged work on WW-5260: -- Author: ASF GitHub Bot Created on: 11/Nov/22 08:20 Start Date: 11/Nov/22 08:20 Worklog Time Spent: 10m Work Description: lukaszlenart opened a new pull request, #636: URL: https://github.com/apache/struts/pull/636 Closes [WW-5260](https://issues.apache.org/jira/browse/WW-5260) Issue Time Tracking --- Worklog Id: (was: 825191) Remaining Estimate: 0h Time Spent: 10m > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5260) Checkbox tag default value for attribute submitUnchecked
[ https://issues.apache.org/jira/browse/WW-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632153#comment-17632153 ] ASF subversion and git services commented on WW-5260: - Commit 279cef1db5070d844b3b812f62f180c6cce732e6 in struts's branch refs/heads/WW-5260-global-submit-unchecked from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=279cef1db ] WW-5260 Introduces a constant to set submitUnchecked attribute of checkbox tag globally > Checkbox tag default value for attribute submitUnchecked > > > Key: WW-5260 > URL: https://issues.apache.org/jira/browse/WW-5260 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 6.0.3 >Reporter: Britta Katzenbach >Priority: Minor > Fix For: 6.1.0 > > > With version 6 the attribute submitUnchecked is added to the checkbox tag. > The default value is {*}false{*}, this is not backward compatible. It is > reasonable to choose false as the default value, as it is the standard html > behaviour. For backward compatiblity it would be nice to be able to change > the default to true via configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)