[jira] [Work logged] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?focusedWorklogId=846302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846302 ] ASF GitHub Bot logged work on WW-5283: -- Author: ASF GitHub Bot Created on: 18/Feb/23 15:44 Start Date: 18/Feb/23 15:44 Worklog Time Spent: 10m Work Description: lukaszlenart opened a new pull request, #17: URL: https://github.com/apache/struts-archetypes/pull/17 Refs [WW-5283])(https://issues.apache.org/jira/browse/WW-5283) Issue Time Tracking --- Worklog Id: (was: 846302) Remaining Estimate: 0h Time Spent: 10m > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690776#comment-17690776 ] ASF subversion and git services commented on WW-5283: - Commit f81a070f39ebca757a8d3104301c548e5e4eddf0 in struts-archetypes's branch refs/heads/WW-5283-update-test from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=f81a070 ] WW-5283 Adjusts tests to use proper new based test case class > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690772#comment-17690772 ] ASF subversion and git services commented on WW-5283: - Commit 9e385a3bb3705fcc84969bbb5922e989038820c6 in struts-archetypes's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=9e385a3 ] Merge pull request #8 from apache/WW-5283-update [WW-5283] Upgrade Struts archetypes to use the latest Struts version > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5283. --- Resolution: Fixed > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690771#comment-17690771 ] ASF subversion and git services commented on WW-5283: - Commit 06e19c0e31c1303a8cd1afdbae2d1def48b5feef in struts-archetypes's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=06e19c0 ] WW-5283 Extracts Jetty version into property > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690770#comment-17690770 ] ASF subversion and git services commented on WW-5283: - Commit c25cb386ff56ecd17d34214f39cb55e76a2d60e8 in struts-archetypes's branch refs/heads/master from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=c25cb38 ] WW-5283 Upgrade Struts archetypes to use the latest Struts version > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5284) Further clean up ActionValidatorManager implementations
[
https://issues.apache.org/jira/browse/WW-5284?focusedWorklogId=846301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846301
]
ASF GitHub Bot logged work on WW-5284:
--
Author: ASF GitHub Bot
Created on: 18/Feb/23 15:19
Start Date: 18/Feb/23 15:19
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #659:
URL: https://github.com/apache/struts/pull/659#discussion_r048936
##
core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java:
##
@@ -120,10 +66,20 @@ protected String buildValidatorKey(Class clazz, String
context) {
} else {
sb.append(context);
}
-
return sb.toString();
}
+@Override
+protected Validator getValidatorFromValidatorConfig(ValidatorConfig
config, ValueStack stack) {
+Validator validator = validatorFactory.getValidator(
+new ValidatorConfig.Builder(config)
+.removeParam("methodName")
Review Comment:
Looks like it does nothing right now, you can try to remove it.
Issue Time Tracking
---
Worklog Id: (was: 846301)
Time Spent: 1h (was: 50m)
> Further clean up ActionValidatorManager implementations
> ---
>
> Key: WW-5284
> URL: https://issues.apache.org/jira/browse/WW-5284
> Project: Struts 2
> Issue Type: Task
> Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5283) Update Struts Archetypes
[ https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690769#comment-17690769 ] ASF GitHub Bot commented on WW-5283: lukaszlenart merged PR #8: URL: https://github.com/apache/struts-archetypes/pull/8 > Update Struts Archetypes > > > Key: WW-5283 > URL: https://issues.apache.org/jira/browse/WW-5283 > Project: Struts 2 > Issue Type: Improvement > Components: Maven Archetypes >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 6.2.0 > > > Upgrade Struts version used by all the archetypes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] lukaszlenart commented on a diff in pull request #659: WW-5284 Refactor ActionValidatorManager implementations
lukaszlenart commented on code in PR #659:
URL: https://github.com/apache/struts/pull/659#discussion_r048936
##
core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java:
##
@@ -120,10 +66,20 @@ protected String buildValidatorKey(Class clazz, String
context) {
} else {
sb.append(context);
}
-
return sb.toString();
}
+@Override
+protected Validator getValidatorFromValidatorConfig(ValidatorConfig
config, ValueStack stack) {
+Validator validator = validatorFactory.getValidator(
+new ValidatorConfig.Builder(config)
+.removeParam("methodName")
Review Comment:
Looks like it does nothing right now, you can try to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy
[
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690767#comment-17690767
]
ASF subversion and git services commented on WW-5275:
-
Commit 31a24ee70972f54b9c32094d3a5250e5f6035f87 in struts's branch
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=31a24ee70 ]
Merge pull request #658 from apache/WW-5275-custom-csp
[WW-5275] Allows to provide a custom CspSettings per action
> Allow to configure more flexible Content-Security-Policy
>
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or
> {{object-src}} or any other values - it should be possible to customise these
> to allow users adopt the policy to their specific needs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (WW-5275) Allow to configure more flexible Content-Security-Policy
[
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-5275.
---
Resolution: Fixed
> Allow to configure more flexible Content-Security-Policy
>
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or
> {{object-src}} or any other values - it should be possible to customise these
> to allow users adopt the policy to their specific needs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy
[
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690766#comment-17690766
]
ASF subversion and git services commented on WW-5275:
-
Commit 68a401aacfbde7ab0210cbc2503b466e08ab6264 in struts's branch
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=68a401aac ]
WW-5275 Allows to provide a custom CspSettings per action
> Allow to configure more flexible Content-Security-Policy
>
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or
> {{object-src}} or any other values - it should be possible to customise these
> to allow users adopt the policy to their specific needs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5275) Allow to configure more flexible Content-Security-Policy
[
https://issues.apache.org/jira/browse/WW-5275?focusedWorklogId=846300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-846300
]
ASF GitHub Bot logged work on WW-5275:
--
Author: ASF GitHub Bot
Created on: 18/Feb/23 15:14
Start Date: 18/Feb/23 15:14
Worklog Time Spent: 10m
Work Description: lukaszlenart merged PR #658:
URL: https://github.com/apache/struts/pull/658
Issue Time Tracking
---
Worklog Id: (was: 846300)
Time Spent: 0.5h (was: 20m)
> Allow to configure more flexible Content-Security-Policy
>
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or
> {{object-src}} or any other values - it should be possible to customise these
> to allow users adopt the policy to their specific needs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
