[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files
[ https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693590#comment-17693590 ] Kusal Kithul-Godage commented on WW-5285: - Given max file size is enforced via an interceptor, would it make more sense to enforce this option within the same interceptor as they are strongly related and will likely be configured together? I feel it would be more consistent. Or maybe reconsider making the max file size a global option? (WW-5266) > Upgrade commons-fileupload to ver 1.5 and add option to limit number of > accepted files > -- > > Key: WW-5285 > URL: https://issues.apache.org/jira/browse/WW-5285 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 6.2.0 > > Time Spent: 20m > Remaining Estimate: 0h > > With a new version of commons-fileupload a new option has been added to limit > number of uploaded files (not size, but number). It would be good to support > this in Struts as well by adding a new constant "struts.multipart.maxFiles" > [https://github.com/apache/commons-fileupload/pull/185] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693461#comment-17693461 ] Rsorrt commented on WW-5141: Hello, I hope this problem will be fixed soon, it's been preventing from switching to Tomcat 10, and now there's Tomcat 11 too... Next Struts2 version need to fix it. > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files
[ https://issues.apache.org/jira/browse/WW-5285?focusedWorklogId=847613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847613 ] ASF GitHub Bot logged work on WW-5285: -- Author: ASF GitHub Bot Created on: 25/Feb/23 09:48 Start Date: 25/Feb/23 09:48 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #662: URL: https://github.com/apache/struts/pull/662#issuecomment-1445043336 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=662) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_coverage&view=list) [70.6% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_duplicated_lines_density&view=list) Issue Time Tracking --- Worklog Id: (was: 847613) Time Spent: 20m (was: 10m) > Upgrade commons-fileupload to ver 1.5 and add option to limit number of > accepted files > -- > > Key: WW-5285 > URL: https://issues.apache.org/jira/browse/WW-5285 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 6.2.0 > > Time Spent: 20m > Remaining Estimate: 0h > > With a new version of commons-fileupload a new option has been added to limit > number of uploaded files (not size, but number). It would be good to support > this in Struts as well by adding a new constant "struts.multipart.maxFiles" > [https://github.com/apache/commons-fileupload/pull/185] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [struts] sonarcloud[bot] commented on pull request #662: [WW-5285] Limits max number of files to upload at once
sonarcloud[bot] commented on PR #662: URL: https://github.com/apache/struts/pull/662#issuecomment-1445043336 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=662) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=662&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=662&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_coverage&view=list) [70.6% Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=662&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files
[ https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693452#comment-17693452 ] ASF subversion and git services commented on WW-5285: - Commit ca637ef70ccecfc22b6549d8faf78110be17e51e in struts's branch refs/heads/WW-5285-max-files from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=ca637ef70 ] WW-5285 Limits max number of files to upload at once Upgrades commons-fileupload to ver. 1.5 and sets default limit to 256 files > Upgrade commons-fileupload to ver 1.5 and add option to limit number of > accepted files > -- > > Key: WW-5285 > URL: https://issues.apache.org/jira/browse/WW-5285 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 6.2.0 > > > With a new version of commons-fileupload a new option has been added to limit > number of uploaded files (not size, but number). It would be good to support > this in Struts as well by adding a new constant "struts.multipart.maxFiles" > [https://github.com/apache/commons-fileupload/pull/185] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files
[ https://issues.apache.org/jira/browse/WW-5285?focusedWorklogId=847612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847612 ] ASF GitHub Bot logged work on WW-5285: -- Author: ASF GitHub Bot Created on: 25/Feb/23 09:42 Start Date: 25/Feb/23 09:42 Worklog Time Spent: 10m Work Description: lukaszlenart opened a new pull request, #662: URL: https://github.com/apache/struts/pull/662 Upgrades commons-fileupload to ver. 1.5 and sets default limit to 256 files Closes [WW-5285](https://issues.apache.org/jira/browse/WW-5285) Issue Time Tracking --- Worklog Id: (was: 847612) Remaining Estimate: 0h Time Spent: 10m > Upgrade commons-fileupload to ver 1.5 and add option to limit number of > accepted files > -- > > Key: WW-5285 > URL: https://issues.apache.org/jira/browse/WW-5285 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 6.2.0 > > Time Spent: 10m > Remaining Estimate: 0h > > With a new version of commons-fileupload a new option has been added to limit > number of uploaded files (not size, but number). It would be good to support > this in Struts as well by adding a new constant "struts.multipart.maxFiles" > [https://github.com/apache/commons-fileupload/pull/185] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files
[ https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart reassigned WW-5285: - Assignee: Lukasz Lenart > Upgrade commons-fileupload to ver 1.5 and add option to limit number of > accepted files > -- > > Key: WW-5285 > URL: https://issues.apache.org/jira/browse/WW-5285 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 6.2.0 > > > With a new version of commons-fileupload a new option has been added to limit > number of uploaded files (not size, but number). It would be good to support > this in Struts as well by adding a new constant "struts.multipart.maxFiles" > [https://github.com/apache/commons-fileupload/pull/185] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-4291) Can't use Spring bean name for type convertor
[
https://issues.apache.org/jira/browse/WW-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4291:
--
Affects Version/s: 6.1.1
> Can't use Spring bean name for type convertor
> -
>
> Key: WW-4291
> URL: https://issues.apache.org/jira/browse/WW-4291
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Spring
>Affects Versions: 6.1.1
>Reporter: Jasper Rosenberg
>Priority: Minor
> Fix For: 6.2.0
>
>
> If in your xwork.conversion.properties file you try to use a Spring bean name
> instead of a class name, it blows up.
> This is because DefaultConfiguration.createBootstrapContainer() ends up using
> DefaultTypeConverterCreator which has the generic ObjectFactory at that point
> because it happens before the struts.properties file is ever loaded (where in
> my case the SpringObjectFactory is defined.)
> {noformat}
> 10:20:06,910 ERROR [DefaultConversionPropertiesProcessor] Conversion
> registration error
> java.lang.ClassNotFoundException: entityObjectTypeConvertor
> at
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1680)
> at
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1526)
> at
> com.opensymphony.xwork2.util.ClassLoaderUtil.loadClass(ClassLoaderUtil.java:152)
> at
> com.opensymphony.xwork2.ObjectFactory.getClassInstance(ObjectFactory.java:108)
> at
> com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:161)
> at
> com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:151)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultTypeConverterCreator.createTypeConverter(DefaultTypeConverterCreator.java:23)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultConversionPropertiesProcessor.loadConversionProperties(DefaultConversionPropertiesProcessor.java:64)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultConversionPropertiesProcessor.process(DefaultConversionPropertiesProcessor.java:40)
> at
> com.opensymphony.xwork2.conversion.impl.XWorkConverter.setConversionPropertiesProcessor(XWorkConverter.java:179)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.opensymphony.xwork2.inject.ContainerImpl$MethodInjector.inject(ContainerImpl.java:299)
> at
> com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector.construct(ContainerImpl.java:438)
> at
> com.opensymphony.xwork2.inject.ContainerBuilder$5.create(ContainerBuilder.java:207)
> ...
> at
> com.opensymphony.xwork2.inject.ContainerBuilder$7.call(ContainerBuilder.java:484)
> at
> com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:584)
> at
> com.opensymphony.xwork2.inject.ContainerBuilder.create(ContainerBuilder.java:484)
> at
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.createBootstrapContainer(DefaultConfiguration.java:324)
> at
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:221)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:67)
> at
> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:446)
> at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:490)
> at
> org.apache.struts2.dispatcher.ng.InitOperations.initDispatcher(InitOperations.java:74)
> at
> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:57)
> at
> org.springframework.web.filter.DelegatingFilterProxy.initDelegate(DelegatingFilterProxy.java:325)
> at
> org.springframework.web.filter.DelegatingFilterProxy.initFilterBean(DelegatingFilterProxy.java:235)
> at
> org.springframework.web.filter.GenericFilterBean.init(GenericFilterBean.java:194)
> at
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:295)
> at
> org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFilterConfig.java:422)
> at
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:115)
> at
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4072)
> at
> org.apache.catalina.core.StandardContext.start(StandardContext.java:4726)
> at
> org.apache.catalina.core.Contain
[jira] [Updated] (WW-4291) Can't use Spring bean name for type convertor
[
https://issues.apache.org/jira/browse/WW-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-4291:
--
Fix Version/s: 6.2.0
(was: 7.0.0)
> Can't use Spring bean name for type convertor
> -
>
> Key: WW-4291
> URL: https://issues.apache.org/jira/browse/WW-4291
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Spring
>Reporter: Jasper Rosenberg
>Priority: Minor
> Fix For: 6.2.0
>
>
> If in your xwork.conversion.properties file you try to use a Spring bean name
> instead of a class name, it blows up.
> This is because DefaultConfiguration.createBootstrapContainer() ends up using
> DefaultTypeConverterCreator which has the generic ObjectFactory at that point
> because it happens before the struts.properties file is ever loaded (where in
> my case the SpringObjectFactory is defined.)
> {noformat}
> 10:20:06,910 ERROR [DefaultConversionPropertiesProcessor] Conversion
> registration error
> java.lang.ClassNotFoundException: entityObjectTypeConvertor
> at
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1680)
> at
> org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1526)
> at
> com.opensymphony.xwork2.util.ClassLoaderUtil.loadClass(ClassLoaderUtil.java:152)
> at
> com.opensymphony.xwork2.ObjectFactory.getClassInstance(ObjectFactory.java:108)
> at
> com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:161)
> at
> com.opensymphony.xwork2.ObjectFactory.buildBean(ObjectFactory.java:151)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultTypeConverterCreator.createTypeConverter(DefaultTypeConverterCreator.java:23)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultConversionPropertiesProcessor.loadConversionProperties(DefaultConversionPropertiesProcessor.java:64)
> at
> com.opensymphony.xwork2.conversion.impl.DefaultConversionPropertiesProcessor.process(DefaultConversionPropertiesProcessor.java:40)
> at
> com.opensymphony.xwork2.conversion.impl.XWorkConverter.setConversionPropertiesProcessor(XWorkConverter.java:179)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.opensymphony.xwork2.inject.ContainerImpl$MethodInjector.inject(ContainerImpl.java:299)
> at
> com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector.construct(ContainerImpl.java:438)
> at
> com.opensymphony.xwork2.inject.ContainerBuilder$5.create(ContainerBuilder.java:207)
> ...
> at
> com.opensymphony.xwork2.inject.ContainerBuilder$7.call(ContainerBuilder.java:484)
> at
> com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:584)
> at
> com.opensymphony.xwork2.inject.ContainerBuilder.create(ContainerBuilder.java:484)
> at
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.createBootstrapContainer(DefaultConfiguration.java:324)
> at
> com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:221)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:67)
> at
> org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:446)
> at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:490)
> at
> org.apache.struts2.dispatcher.ng.InitOperations.initDispatcher(InitOperations.java:74)
> at
> org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:57)
> at
> org.springframework.web.filter.DelegatingFilterProxy.initDelegate(DelegatingFilterProxy.java:325)
> at
> org.springframework.web.filter.DelegatingFilterProxy.initFilterBean(DelegatingFilterProxy.java:235)
> at
> org.springframework.web.filter.GenericFilterBean.init(GenericFilterBean.java:194)
> at
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:295)
> at
> org.apache.catalina.core.ApplicationFilterConfig.setFilterDef(ApplicationFilterConfig.java:422)
> at
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:115)
> at
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4072)
> at
> org.apache.catalina.core.StandardContext.start(StandardContext.java:4726)
> at
> org.apache.catalina.core.Cont
