[jira] [Commented] (WW-3691) BackgroundProcess should use a java.util.concurrent.Executor alternatively to spawning a new thread

2023-03-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-3691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695798#comment-17695798
 ] 

ASF subversion and git services commented on WW-3691:
-

Commit d1f95c6bf03e3a1f67506bade403c393af9fd410 in struts-site's branch 
refs/heads/WW-3691-executor from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-site.git;h=d1f95c6bf ]

WW-3691 Documents how to use ExecutorProvider


> BackgroundProcess should use a java.util.concurrent.Executor alternatively to 
> spawning a new thread
> ---
>
> Key: WW-3691
> URL: https://issues.apache.org/jira/browse/WW-3691
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.2.3.1
>Reporter: Falko Modler
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.1.1
>
> Attachments: WW-3691.patch, WW-3691_core.txt, WW-3691_showcase.txt
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Every new instance of org.apache.struts2.interceptor.BackgroundProcess spawns 
> a new Thread (see constructor), no thread pooling is used.
> Besides problems in environments where some container might need to manage 
> the creation of threads, this issue also prevents certain 
> performance/efficiency optimizations via ThreadLocal from taking full effect. 
> E.g.: We use ThreadLocals for Random and SimpleDateFormat and those thread 
> local instances "are lost" when a new Thread is created.
> Therefore BackgroundProcess should be given a new constructor that takes a 
> java.util.concurrent.Executor instance that is used to execute the Runnable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-03-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695508#comment-17695508
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit 56d22bf1ad03a57d9ae835ffb391038026f0fe00 in struts-site's branch 
refs/heads/WW-5285-max-files from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-site.git;h=56d22bf1a ]

WW-5285 Documents struts.multipart.maxFiles option


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-03-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695496#comment-17695496
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit 1a2aba89fb2b870fe2d0bc7864da152b16d5ce28 in struts-site's branch 
refs/heads/WW-5285-max-files from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-site.git;h=1a2aba89f ]

WW-5285 Documents struts.multipart.maxFiles option


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-03-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695241#comment-17695241
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit ab03231484bd88fabb899aa4b5b41c66da1038b5 in struts's branch 
refs/heads/master from Yasser Zamani
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=ab0323148 ]

Merge pull request #662 from apache/WW-5285-max-files

[WW-5285] Limits max number of files to upload at once

> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-03-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695239#comment-17695239
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit ca637ef70ccecfc22b6549d8faf78110be17e51e in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=ca637ef70 ]

WW-5285 Limits max number of files to upload at once
Upgrades commons-fileupload to ver. 1.5 and sets default limit to 256 files


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-03-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695240#comment-17695240
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit 13c93aaa75bea84ee8f597af02975bbcc655cd03 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=13c93aaa7 ]

WW-5285 Uses Long and null to check if option has been defined


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5268) Add configuration option to exempt classes from OGNL package exclusions

2023-02-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694538#comment-17694538
 ] 

ASF subversion and git services commented on WW-5268:
-

Commit 5827a23368079cb747d9938bcace642a5b2eecc8 in struts-site's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-site.git;h=5827a2336 ]

Merge pull request #184 from atlassian-forks/WW-5268-excluded-package-exemptions

WW-5268 Update documentation with struts.excludedPackageExemptClasses…

> Add configuration option to exempt classes from OGNL package exclusions
> ---
>
> Key: WW-5268
> URL: https://issues.apache.org/jira/browse/WW-5268
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It is currently possible to exclude packages from OGNL evaluation using 
> `struts.excludedPackageNamePatterns` and `struts.excludedPackageNames`.
> There may exist a scenario where you wish to have certain packages 
> excluded/blocklisted by default, but exempt specific classes from these 
> packages that have been assessed to be safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5268) Add configuration option to exempt classes from OGNL package exclusions

2023-02-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694537#comment-17694537
 ] 

ASF subversion and git services commented on WW-5268:
-

Commit 3de91d655c10b5496d4d923a7a4f5fdffdf7cf60 in struts-site's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts-site.git;h=3de91d655 ]

WW-5268 Update documentation with struts.excludedPackageExemptClasses option


> Add configuration option to exempt classes from OGNL package exclusions
> ---
>
> Key: WW-5268
> URL: https://issues.apache.org/jira/browse/WW-5268
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It is currently possible to exclude packages from OGNL evaluation using 
> `struts.excludedPackageNamePatterns` and `struts.excludedPackageNames`.
> There may exist a scenario where you wish to have certain packages 
> excluded/blocklisted by default, but exempt specific classes from these 
> packages that have been assessed to be safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5268) Add configuration option to exempt classes from OGNL package exclusions

2023-02-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694375#comment-17694375
 ] 

ASF subversion and git services commented on WW-5268:
-

Commit 6a27f460c0b3121101d93b39e6109eee09ffcdfa in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6a27f460c ]

Merge pull request #660 from atlassian/WW-5268-excluded-package-exemptions

WW-5268 Ability to exempt classes from package exclusions

> Add configuration option to exempt classes from OGNL package exclusions
> ---
>
> Key: WW-5268
> URL: https://issues.apache.org/jira/browse/WW-5268
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It is currently possible to exclude packages from OGNL evaluation using 
> `struts.excludedPackageNamePatterns` and `struts.excludedPackageNames`.
> There may exist a scenario where you wish to have certain packages 
> excluded/blocklisted by default, but exempt specific classes from these 
> packages that have been assessed to be safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5268) Add configuration option to exempt classes from OGNL package exclusions

2023-02-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694374#comment-17694374
 ] 

ASF subversion and git services commented on WW-5268:
-

Commit 5fcee890d593d6eb5034e836bb3cf9e565d7061d in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=5fcee890d ]

WW-5268 Implement ability to specify exempt classes for package exclusions


> Add configuration option to exempt classes from OGNL package exclusions
> ---
>
> Key: WW-5268
> URL: https://issues.apache.org/jira/browse/WW-5268
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It is currently possible to exclude packages from OGNL evaluation using 
> `struts.excludedPackageNamePatterns` and `struts.excludedPackageNames`.
> There may exist a scenario where you wish to have certain packages 
> excluded/blocklisted by default, but exempt specific classes from these 
> packages that have been assessed to be safe.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-02-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694358#comment-17694358
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit 13c93aaa75bea84ee8f597af02975bbcc655cd03 in struts's branch 
refs/heads/WW-5285-max-files from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=13c93aaa7 ]

WW-5285 Uses Long and null to check if option has been defined


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-02-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694335#comment-17694335
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit 253cd9f5301c8a4920ccca28e8f8c318b3102352 in struts's branch 
refs/heads/WW-5285-max-files from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=253cd9f53 ]

WW-5285 Uses Long and null to check if option has been defined


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5285) Upgrade commons-fileupload to ver 1.5 and add option to limit number of accepted files

2023-02-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693452#comment-17693452
 ] 

ASF subversion and git services commented on WW-5285:
-

Commit ca637ef70ccecfc22b6549d8faf78110be17e51e in struts's branch 
refs/heads/WW-5285-max-files from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=ca637ef70 ]

WW-5285 Limits max number of files to upload at once
Upgrades commons-fileupload to ver. 1.5 and sets default limit to 256 files


> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --
>
> Key: WW-5285
> URL: https://issues.apache.org/jira/browse/WW-5285
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693052#comment-17693052
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit 310cfea5a127e1036e616a031d2973a2ca52822e in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=310cfea ]

WW-5283 Fixes outstanding imports


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693043#comment-17693043
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit 511e4aee5803af1d904bc8ae923739e6725dd002 in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=511e4ae ]

Merge pull request #17 from apache/WW-5283-update-test

[WW-5283] Adjusts tests to use proper new based test case class

> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693042#comment-17693042
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit f81a070f39ebca757a8d3104301c548e5e4eddf0 in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=f81a070 ]

WW-5283 Adjusts tests to use proper new based test case class


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5284) Further clean up ActionValidatorManager implementations

2023-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691029#comment-17691029
 ] 

ASF subversion and git services commented on WW-5284:
-

Commit f67e5f1aceb4e536d31d2c75d1e8295b3023 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=f67e5f1ac ]

Merge pull request #659 from atlassian/WW-5284-clean-up-validator

WW-5284 Refactor ActionValidatorManager implementations

> Further clean up ActionValidatorManager implementations
> ---
>
> Key: WW-5284
> URL: https://issues.apache.org/jira/browse/WW-5284
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5284) Further clean up ActionValidatorManager implementations

2023-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691028#comment-17691028
 ] 

ASF subversion and git services commented on WW-5284:
-

Commit d30870ac63af4555878c05d6984415e2ae5dd211 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d30870ac6 ]

WW-5284 Delete unnecessary override


> Further clean up ActionValidatorManager implementations
> ---
>
> Key: WW-5284
> URL: https://issues.apache.org/jira/browse/WW-5284
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5284) Further clean up ActionValidatorManager implementations

2023-02-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691027#comment-17691027
 ] 

ASF subversion and git services commented on WW-5284:
-

Commit 816e606ffed37fa38a0007964fad94b08a9b5a98 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=816e606ff ]

WW-5284 Refactor ActionValidatorManager implementations


> Further clean up ActionValidatorManager implementations
> ---
>
> Key: WW-5284
> URL: https://issues.apache.org/jira/browse/WW-5284
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690776#comment-17690776
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit f81a070f39ebca757a8d3104301c548e5e4eddf0 in struts-archetypes's branch 
refs/heads/WW-5283-update-test from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=f81a070 ]

WW-5283 Adjusts tests to use proper new based test case class


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690772#comment-17690772
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit 9e385a3bb3705fcc84969bbb5922e989038820c6 in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=9e385a3 ]

Merge pull request #8 from apache/WW-5283-update

[WW-5283] Upgrade Struts archetypes to use the latest Struts version

> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690771#comment-17690771
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit 06e19c0e31c1303a8cd1afdbae2d1def48b5feef in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=06e19c0 ]

WW-5283 Extracts Jetty version into property


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690770#comment-17690770
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit c25cb386ff56ecd17d34214f39cb55e76a2d60e8 in struts-archetypes's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=c25cb38 ]

WW-5283 Upgrade Struts archetypes to use the latest Struts version


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690767#comment-17690767
 ] 

ASF subversion and git services commented on WW-5275:
-

Commit 31a24ee70972f54b9c32094d3a5250e5f6035f87 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=31a24ee70 ]

Merge pull request #658 from apache/WW-5275-custom-csp

[WW-5275] Allows to provide a custom CspSettings per action

> Allow to configure more flexible Content-Security-Policy
> 
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
>  Issue Type: New Feature
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or 
> {{object-src}} or any other values - it should be possible to customise these 
> to allow users adopt the policy to their specific needs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy

2023-02-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690766#comment-17690766
 ] 

ASF subversion and git services commented on WW-5275:
-

Commit 68a401aacfbde7ab0210cbc2503b466e08ab6264 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=68a401aac ]

WW-5275 Allows to provide a custom CspSettings per action


> Allow to configure more flexible Content-Security-Policy
> 
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
>  Issue Type: New Feature
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or 
> {{object-src}} or any other values - it should be possible to customise these 
> to allow users adopt the policy to their specific needs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688335#comment-17688335
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit 06e19c0e31c1303a8cd1afdbae2d1def48b5feef in struts-archetypes's branch 
refs/heads/WW-5283-update from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=06e19c0 ]

WW-5283 Extracts Jetty version into property


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5283) Update Struts Archetypes

2023-02-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688332#comment-17688332
 ] 

ASF subversion and git services commented on WW-5283:
-

Commit c25cb386ff56ecd17d34214f39cb55e76a2d60e8 in struts-archetypes's branch 
refs/heads/WW-5283-update from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts-archetypes.git;h=c25cb38 ]

WW-5283 Upgrade Struts archetypes to use the latest Struts version


> Update Struts Archetypes
> 
>
> Key: WW-5283
> URL: https://issues.apache.org/jira/browse/WW-5283
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Maven Archetypes
>Reporter: Lukasz Lenart
>Assignee: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Upgrade Struts version used by all the archetypes



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy

2023-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687594#comment-17687594
 ] 

ASF subversion and git services commented on WW-5275:
-

Commit 68a401aacfbde7ab0210cbc2503b466e08ab6264 in struts's branch 
refs/heads/WW-5275-custom-csp from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=68a401aac ]

WW-5275 Allows to provide a custom CspSettings per action


> Allow to configure more flexible Content-Security-Policy
> 
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
>  Issue Type: New Feature
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or 
> {{object-src}} or any other values - it should be possible to customise these 
> to allow users adopt the policy to their specific needs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5275) Allow to configure more flexible Content-Security-Policy

2023-02-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687587#comment-17687587
 ] 

ASF subversion and git services commented on WW-5275:
-

Commit 6d6a5a14255982812f5f6cc645b1430f7cd512c4 in struts's branch 
refs/heads/WW-5275-custom-csp from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6d6a5a142 ]

WW-5275 Allows to provide a custom CspSettings per action


> Allow to configure more flexible Content-Security-Policy
> 
>
> Key: WW-5275
> URL: https://issues.apache.org/jira/browse/WW-5275
> Project: Struts 2
>  Issue Type: New Feature
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Currently CSP interceptor doesn't allow to change {{script-src}} or 
> {{object-src}} or any other values - it should be possible to customise these 
> to allow users adopt the policy to their specific needs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5279) Improve readability of XmlConfigurationProvider class

2023-01-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682869#comment-17682869
 ] 

ASF subversion and git services commented on WW-5279:
-

Commit 2f7a50935bab9384df5da6d6270838646e70d635 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=2f7a50935 ]

WW-5279 Improve readability of XmlConfigurationProvider class


> Improve readability of XmlConfigurationProvider class
> -
>
> Key: WW-5279
> URL: https://issues.apache.org/jira/browse/WW-5279
> Project: Struts 2
>  Issue Type: Task
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5279) Improve readability of XmlConfigurationProvider class

2023-01-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682870#comment-17682870
 ] 

ASF subversion and git services commented on WW-5279:
-

Commit 930c6de8076d6ed6037c8d791a5ad7eae69765d5 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=930c6de80 ]

Merge pull request #657 from atlassian/WW-5279-xml-config-provider

WW-5279 Improve readability of XmlConfigurationProvider class

> Improve readability of XmlConfigurationProvider class
> -
>
> Key: WW-5279
> URL: https://issues.apache.org/jira/browse/WW-5279
> Project: Struts 2
>  Issue Type: Task
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682072#comment-17682072
 ] 

ASF subversion and git services commented on WW-5278:
-

Commit 89e2d4fb146a3d3d84522041698362ae2825af7b in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=89e2d4fb1 ]

WW-5278 Collect common code into AbstractActionValidatorManager


> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682074#comment-17682074
 ] 

ASF subversion and git services commented on WW-5278:
-

Commit 533d7e3319f7ba47999f8807e7562ca071266553 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=533d7e331 ]

Merge pull request #656 from atlassian/WW-5278-clean-up-action-validators

WW-5278 Collect duplicated code into AbstractActionValidatorManager

> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5278) Clean up duplicated code across ActionValidationManagers

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682073#comment-17682073
 ] 

ASF subversion and git services commented on WW-5278:
-

Commit 9d71ed6663d8f5e92338f94520e713ae56d60678 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=9d71ed666 ]

WW-5278 Fix incorrect logging statement


> Clean up duplicated code across ActionValidationManagers
> 
>
> Key: WW-5278
> URL: https://issues.apache.org/jira/browse/WW-5278
> Project: Struts 2
>  Issue Type: Task
>  Components: Core Interceptors
>Reporter: Kusal Kithul-Godage
>Priority: Trivial
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5270) Forwarding from a Struts excluded URL to an Action not working

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682066#comment-17682066
 ] 

ASF subversion and git services commented on WW-5270:
-

Commit 0ce254dc48fe7d60451b60a7784bb93b858cb434 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0ce254dc4 ]

WW-5270 Rework and fix Struts filter cleanup


> Forwarding from a Struts excluded URL to an Action not working
> --
>
> Key: WW-5270
> URL: https://issues.apache.org/jira/browse/WW-5270
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Since the fix implemented in WW-5199 - I noticed forwards still did not 
> function when it originated from a Struts excluded URL. This is because the 
> exclusion flag is being maintained when forwarded. There is also an 
> additional issue of the ActionContext being cleaned up too soon - prior to 
> the SiteMesh filter being able to access it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5270) Forwarding from a Struts excluded URL to an Action not working

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682064#comment-17682064
 ] 

ASF subversion and git services commented on WW-5270:
-

Commit 6ea67a6d640817b0feeb9ce7e6cbc6267a6a3e01 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6ea67a6d6 ]

WW-5270 Test for forwarding from Struts excluded URL to Struts Action


> Forwarding from a Struts excluded URL to an Action not working
> --
>
> Key: WW-5270
> URL: https://issues.apache.org/jira/browse/WW-5270
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Since the fix implemented in WW-5199 - I noticed forwards still did not 
> function when it originated from a Struts excluded URL. This is because the 
> exclusion flag is being maintained when forwarded. There is also an 
> additional issue of the ActionContext being cleaned up too soon - prior to 
> the SiteMesh filter being able to access it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5270) Forwarding from a Struts excluded URL to an Action not working

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682065#comment-17682065
 ] 

ASF subversion and git services commented on WW-5270:
-

Commit 92c0103b38ffca4652bdf7c8e04b78c2f244bb78 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=92c0103b3 ]

WW-5270 Struts exclusion flag fix when forwarding


> Forwarding from a Struts excluded URL to an Action not working
> --
>
> Key: WW-5270
> URL: https://issues.apache.org/jira/browse/WW-5270
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Since the fix implemented in WW-5199 - I noticed forwards still did not 
> function when it originated from a Struts excluded URL. This is because the 
> exclusion flag is being maintained when forwarded. There is also an 
> additional issue of the ActionContext being cleaned up too soon - prior to 
> the SiteMesh filter being able to access it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5270) Forwarding from a Struts excluded URL to an Action not working

2023-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682067#comment-17682067
 ] 

ASF subversion and git services commented on WW-5270:
-

Commit 7d40a81a4056c4d3bca9289c9f5654a201a2c21f in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=7d40a81a4 ]

Merge pull request #648 from atlassian/WW-5270-forwarding-from-excluded-url

WW-5270 Fix forwarding from Struts excluded URL

> Forwarding from a Struts excluded URL to an Action not working
> --
>
> Key: WW-5270
> URL: https://issues.apache.org/jira/browse/WW-5270
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.2.0
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Since the fix implemented in WW-5199 - I noticed forwards still did not 
> function when it originated from a Struts excluded URL. This is because the 
> exclusion flag is being maintained when forwarded. There is also an 
> additional issue of the ActionContext being cleaned up too soon - prior to 
> the SiteMesh filter being able to access it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680975#comment-17680975
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 3b2c6057e7d8215b42c5639ec7062df44ee17ff7 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3b2c6057e ]

WW-4404 Implements HttpInterceptor


> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680976#comment-17680976
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 2a85d0fbc4dcc8e59b4e48d1c8289252ade042af in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=2a85d0fbc ]

Merge pull request #655 from apache/http-interceptor

[WW-4404] Http interceptor

> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5276) Cleanup method of request is not called

2023-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680974#comment-17680974
 ] 

ASF subversion and git services commented on WW-5276:
-

Commit c5130477ba17477bc50bb0a2b6af55938f2d30f0 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=c5130477b ]

Merge pull request #654 from apache/WW-5276-cleanup

[WW-5276] Cleans up also wrapper request to avoid resource leak and potential 
DoS attack

> Cleanup method of request is not called
> ---
>
> Key: WW-5276
> URL: https://issues.apache.org/jira/browse/WW-5276
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.1.1
>Reporter: Mirek Hankus
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> After upgrading to 6.1.1  we have noticed that cleanup method of custom 
> MultiPartRequest is not called by struts. 
>  
>  
> It may be related to 
> [https://github.com/apache/struts/commit/69102e907551a87335231656320c8484072bdecb]
>  
> as before variable "request" was overwritten with wrapped request and cleanup 
> was called in finally section
>  
> After this commit new variable is created called "wrappedRequest", but 
> cleanup is called only on original request, and new wrappedRequest is not 
> cleaned up at all.
>  
> Below is respective code fragment
> {code:java}
> HttpServletRequest wrappedRequest = prepare.wrapRequest(request);
>                     ActionMapping mapping = 
> prepare.findActionMapping(wrappedRequest, response, true);
>                     if (mapping == null) {
>                         LOG.trace("Cannot find mapping for {}, passing to 
> other filters", uri);
>                         chain.doFilter(request, response);
>                     } else {
>                         LOG.trace("Found mapping {} for {}", mapping, uri);
>                         execute.executeAction(wrappedRequest, response, 
> mapping);
>                     }
>                 }
>             }
>         } finally {
>             prepare.cleanupRequest(request);
>         }{code}
>  
> This bug causes a lot of resource problems, and can result in denial of 
> service condition for application  (or making application not compliant - as 
> sensitive information is not properly discarded).
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5276) Cleanup method of request is not called

2023-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680973#comment-17680973
 ] 

ASF subversion and git services commented on WW-5276:
-

Commit 05d7196e6cf451426eb301effc0416b2554b20f3 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=05d7196e6 ]

WW-5276 Cleans up also wrapper request to avoid resource leak and potential DoS 
attack


> Cleanup method of request is not called
> ---
>
> Key: WW-5276
> URL: https://issues.apache.org/jira/browse/WW-5276
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.1.1
>Reporter: Mirek Hankus
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> After upgrading to 6.1.1  we have noticed that cleanup method of custom 
> MultiPartRequest is not called by struts. 
>  
>  
> It may be related to 
> [https://github.com/apache/struts/commit/69102e907551a87335231656320c8484072bdecb]
>  
> as before variable "request" was overwritten with wrapped request and cleanup 
> was called in finally section
>  
> After this commit new variable is created called "wrappedRequest", but 
> cleanup is called only on original request, and new wrappedRequest is not 
> cleaned up at all.
>  
> Below is respective code fragment
> {code:java}
> HttpServletRequest wrappedRequest = prepare.wrapRequest(request);
>                     ActionMapping mapping = 
> prepare.findActionMapping(wrappedRequest, response, true);
>                     if (mapping == null) {
>                         LOG.trace("Cannot find mapping for {}, passing to 
> other filters", uri);
>                         chain.doFilter(request, response);
>                     } else {
>                         LOG.trace("Found mapping {} for {}", mapping, uri);
>                         execute.executeAction(wrappedRequest, response, 
> mapping);
>                     }
>                 }
>             }
>         } finally {
>             prepare.cleanupRequest(request);
>         }{code}
>  
> This bug causes a lot of resource problems, and can result in denial of 
> service condition for application  (or making application not compliant - as 
> sensitive information is not properly discarded).
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5274) Mark Pell Multipart plugin as deprecated

2023-01-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680473#comment-17680473
 ] 

ASF subversion and git services commented on WW-5274:
-

Commit faa1867d633ab884354d80d1c939b629423f6d18 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=faa1867d6 ]

Merge pull request #653 from apache/WW-5274-pell

[WW-5274] Marks the Pell multipart plugin as deprecated

> Mark Pell Multipart plugin as deprecated
> 
>
> Key: WW-5274
> URL: https://issues.apache.org/jira/browse/WW-5274
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Plugin - Pell
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This plugin is using library which isn't support nor actively developed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5274) Mark Pell Multipart plugin as deprecated

2023-01-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680472#comment-17680472
 ] 

ASF subversion and git services commented on WW-5274:
-

Commit 474a340553189dec4af293d80def60d9728ebd1b in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=474a34055 ]

WW-5274 Marks the Pell multipart plugin as deprecated


> Mark Pell Multipart plugin as deprecated
> 
>
> Key: WW-5274
> URL: https://issues.apache.org/jira/browse/WW-5274
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Plugin - Pell
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This plugin is using library which isn't support nor actively developed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679910#comment-17679910
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit d11cf771b64bd1350d1e181a917b6beb106d0f6b in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d11cf771b ]

WW-5264 Uses proper parent package when testing XSLT result


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5269) Upgrade Jackson to version 2.14.1

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679916#comment-17679916
 ] 

ASF subversion and git services commented on WW-5269:
-

Commit bcf2e11518739ceab87631e57cb22fdf74a7cfc0 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=bcf2e1151 ]

Merge pull request #647 from apache/WW-5269-jackson

[WW-5269] Upgrades Jackson to version 2.14.1

> Upgrade Jackson to version 2.14.1
> -
>
> Key: WW-5269
> URL: https://issues.apache.org/jira/browse/WW-5269
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core, Plugin - REST
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679913#comment-17679913
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit 45aa17238604d13a83420e9c538f3a8c00ec46bf in struts's branch 
refs/heads/WW-5233-tiles from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=45aa17238 ]

WW-5265 Allow removal of a single/specific container provider from Struts 
configuration


> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679911#comment-17679911
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 0d81cdd85db79fcc8515bb6735814daec3a84ca6 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0d81cdd85 ]

Merge pull request #646 from apache/WW-5264-xslt-cleanup

[WW-5264] Removes XSLTResult from struts-default.xml as it was moved in to 
plugin

> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679912#comment-17679912
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit b795a920a8aecb49980983b271c04555a5770eaf in struts's branch 
refs/heads/WW-5233-tiles from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=b795a920a ]

WW-5265 Formatting fixes


> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5263) CSP related interceptors have wrong short names

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679901#comment-17679901
 ] 

ASF subversion and git services commented on WW-5263:
-

Commit ea15306aa5172e98617f3d7705644d8968e22083 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=ea15306aa ]

WW-5263 Uses porper names for CSP, COOP and COEP interceptors


> CSP related interceptors have wrong short names
> ---
>
> Key: WW-5263
> URL: https://issues.apache.org/jira/browse/WW-5263
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> CoepInterceptor is using {{coepInterceptor}} instead of {{coep}}
> CoopInterceptor is using {{coopInterceptor}} instead of {{coop}}
> CspInterceptor is using {{cspInterceptor}} instead of {{csp}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679918#comment-17679918
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit d90bee49b5d521c591084111a4cba76aef3b7ea3 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d90bee49b ]

Merge pull request #649 from apache/WW-5272-time

[WW-5272] Extends  to support java.sql.Time

> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679914#comment-17679914
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit 266d2d4ed526edbb8e8035df94e94a1007d7c360 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=266d2d4ed ]

Merge pull request #645 from atlassian/WW-5265-remove-container-provider

WW-5265 Allow removal of a single/specific container provider

> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5277) Upgrade Freemarker to version 3.2.32

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679920#comment-17679920
 ] 

ASF subversion and git services commented on WW-5277:
-

Commit 46738c970ef20c64d997122c6f15caf2b76f0653 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=46738c970 ]

Merge pull request #651 from apache/WW-5277-freemarker

[WW-5277] Upgrades Freemarker to version 2.3.32

> Upgrade Freemarker to version 3.2.32
> 
>
> Key: WW-5277
> URL: https://issues.apache.org/jira/browse/WW-5277
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Apache FreeMarker community is pleased to announce the release of
> Apache FreeMarker 2.3.32.
> https://freemarker.apache.org/docs/versions_2_3_32.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5277) Upgrade Freemarker to version 3.2.32

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679919#comment-17679919
 ] 

ASF subversion and git services commented on WW-5277:
-

Commit cde1753341557e0c767e8acf45adb3ac2bf51503 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=cde175334 ]

WW-5277 Upgrades Freemarker to version 2.3.32


> Upgrade Freemarker to version 3.2.32
> 
>
> Key: WW-5277
> URL: https://issues.apache.org/jira/browse/WW-5277
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Apache FreeMarker community is pleased to announce the release of
> Apache FreeMarker 2.3.32.
> https://freemarker.apache.org/docs/versions_2_3_32.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5269) Upgrade Jackson to version 2.14.1

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679915#comment-17679915
 ] 

ASF subversion and git services commented on WW-5269:
-

Commit 3bad2d0cecab1e364d35a6ab16b1f8b4df1b75af in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3bad2d0ce ]

WW-5269 Upgrades Jackson to version 2.14.1


> Upgrade Jackson to version 2.14.1
> -
>
> Key: WW-5269
> URL: https://issues.apache.org/jira/browse/WW-5269
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core, Plugin - REST
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5233) Include Apache Tiles code base in the Tiles plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679921#comment-17679921
 ] 

ASF subversion and git services commented on WW-5233:
-

Commit 9bb0c9ad374d0e4a3ef8ddb92fc276e5d4a21400 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=9bb0c9ad3 ]

WW-5233 Introduces Tiles base code into the Tiles plugin

WW-5233 Copies a based set of Tiles classes used by Struts

WW-5233 Copies Portlet related Tiles code base

WW-5233 Copies Tiles API related tests

WW-5233 Copies Tiles Core related tests

WW-5233 Copies Tiles EL related tests

WW-5233 Copies Tiles OGNL related tests

WW-5233 Copies Tiles Template related tests

WW-5233 Copies Tiles Servlet related tests

WW-5233 Upgrades Easymock to version 4.3 to support Java 17

WW-5233 Copies Tiles Request related tests

WW-5233 Copies Tiles Autotag related tests

WW-5233 Drops useless @version tag and addresses some potential RegEx 
vulnerabilities

WW-5233 Addresses bugs reported by Sonar

WW-5233 Addresses a few code smells

WW-5233 Copies Tiles Portal related tests

WW-5233 Fixes broken test

WW-5233 Adds Tiles DTD definition

Add missing classes and tld definition.

Add generating of Autotags and tests.

Make plugin standalone with all generated resources.

Make plugin standalone with all generated resources for velocity.

Make plugin standalone with all generated resources for velocity.

WW-5233 Marks Velocity dependencies as optional


> Include Apache Tiles code base in the Tiles plugin
> --
>
> Key: WW-5233
> URL: https://issues.apache.org/jira/browse/WW-5233
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Plugin - Tiles
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Apache Tiles has retired and it isn't maintained anymore. There are some 
> outstanding security issues that can be addressed right now. It will be 
> easier to maintain the code base as a part of the Tiles plugin instead of 
> taking the project back from attick.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679917#comment-17679917
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit 08de24588ad5b88ec3554b476c9d3cf0fb47b32c in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=08de24588 ]

WW-5272 Extends  to support java.sql.Time


> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5199) StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to another action

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679905#comment-17679905
 ] 

ASF subversion and git services commented on WW-5199:
-

Commit afd04ea5af64768ba61b941a4fdd277674196820 in struts's branch 
refs/heads/WW-5233-tiles from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=afd04ea5a ]

WW-5199 Allow forwarding from/to actions


> StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to 
> another action
> ---
>
> Key: WW-5199
> URL: https://issues.apache.org/jira/browse/WW-5199
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.0.0
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Ween using {{StrutsPrepareFilter}}/{{StrutsExecuteFilter}} combination it 
> isn't possible to use {{DispatcherResult}} with forwarding to another actions 
> - it's do to the cleanup counter implemented in those filters.
> The same application using {{StrutsPrepareAndExecuteFilter}} works perfectly 
> fine, this is covered by 
> {{apps/showcase/src/test/java/it/org/apache/struts2/showcase/DispatcherResultTest.java}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5262) Extract excluded classes and beans out of struts-default.xml

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679904#comment-17679904
 ] 

ASF subversion and git services commented on WW-5262:
-

Commit 97691a106d1f63d5173a2397b155527535b85764 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=97691a106 ]

Merge pull request #640 from apache/WW-5262-beans

[WW-5262] Extracts excluded classes and beans into dedicated XML config files

> Extract excluded classes and beans out of struts-default.xml
> 
>
> Key: WW-5262
> URL: https://issues.apache.org/jira/browse/WW-5262
> Project: Struts 2
>  Issue Type: Improvement
>  Components: XML Configuration
>Reporter: Lukasz Lenart
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> To increase readability it would be good to extract excluded classes and 
> beans into dedicated xml config files and included them back in 
> {{struts-default.xml}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5262) Extract excluded classes and beans out of struts-default.xml

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679903#comment-17679903
 ] 

ASF subversion and git services commented on WW-5262:
-

Commit b9b9aaf71035697e7df113986148e2f1bc037086 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=b9b9aaf71 ]

WW-5262 Extracts excluded classes and beans into dedicated XML config files


> Extract excluded classes and beans out of struts-default.xml
> 
>
> Key: WW-5262
> URL: https://issues.apache.org/jira/browse/WW-5262
> Project: Struts 2
>  Issue Type: Improvement
>  Components: XML Configuration
>Reporter: Lukasz Lenart
>Priority: Trivial
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> To increase readability it would be good to extract excluded classes and 
> beans into dedicated xml config files and included them back in 
> {{struts-default.xml}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679909#comment-17679909
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 63dd9536cab7c1d10baea11c2b35ce9ea3ca06f0 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=63dd9536c ]

WW-5264 Removes XSLTResult from struts-default.xml as it was moved into plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679907#comment-17679907
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 15dd2f2234e70dd95ed83900f2e255d7daddbca2 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=15dd2f223 ]

WW-5264 Moves XSLT result into a dedicated plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5199) StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to another action

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679906#comment-17679906
 ] 

ASF subversion and git services commented on WW-5199:
-

Commit 579796de5a2a1a638769b29ca412bf740eafe13e in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=579796de5 ]

Merge pull request #642 from atlassian/WW-5199-forward-action

WW-5199 Allow forwarding from/to actions

> StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to 
> another action
> ---
>
> Key: WW-5199
> URL: https://issues.apache.org/jira/browse/WW-5199
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.0.0
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Ween using {{StrutsPrepareFilter}}/{{StrutsExecuteFilter}} combination it 
> isn't possible to use {{DispatcherResult}} with forwarding to another actions 
> - it's do to the cleanup counter implemented in those filters.
> The same application using {{StrutsPrepareAndExecuteFilter}} works perfectly 
> fine, this is covered by 
> {{apps/showcase/src/test/java/it/org/apache/struts2/showcase/DispatcherResultTest.java}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679908#comment-17679908
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 0e62b4b53456e3158393a050d30475896ce6d549 in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0e62b4b53 ]

Merge pull request #641 from apache/WW-5264-xslt

[WW-5264] Moves XSLT result into a dedicated plugin

> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5263) CSP related interceptors have wrong short names

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679902#comment-17679902
 ] 

ASF subversion and git services commented on WW-5263:
-

Commit 79eebf37176c29fae528eff8d0e1b1304684c50e in struts's branch 
refs/heads/WW-5233-tiles from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=79eebf371 ]

Merge pull request #639 from apache/WW-5263-csp-naming

[WW-5263] Uses proper names for CSP, COOP and COEP interceptors

> CSP related interceptors have wrong short names
> ---
>
> Key: WW-5263
> URL: https://issues.apache.org/jira/browse/WW-5263
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core Interceptors
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> CoepInterceptor is using {{coepInterceptor}} instead of {{coep}}
> CoopInterceptor is using {{coopInterceptor}} instead of {{coop}}
> CspInterceptor is using {{cspInterceptor}} instead of {{csp}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679723#comment-17679723
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 3b2c6057e7d8215b42c5639ec7062df44ee17ff7 in struts's branch 
refs/heads/http-interceptor from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3b2c6057e ]

WW-4404 Implements HttpInterceptor


> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679608#comment-17679608
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 5b4987a706fde45ca0096cc62047d9971f0cf1b0 in struts's branch 
refs/heads/http-interceptor from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=5b4987a70 ]

WW-4404 Implements HttpInterceptor


> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679600#comment-17679600
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 6bc5b3f4ab2bfa4db9c3b3d8c48d1a54e64d2fae in struts's branch 
refs/heads/http-interceptor from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6bc5b3f4a ]

WW-4404 Implements HttpInterceptor


> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-4404) Implement HttpInterceptor

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679543#comment-17679543
 ] 

ASF subversion and git services commented on WW-4404:
-

Commit 6159a2e642e625d904e2b7fa77b7323178e3986d in struts's branch 
refs/heads/http-interceptor from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6159a2e64 ]

WW-4404 Implements HttpInterceptor


> Implement HttpInterceptor
> -
>
> Key: WW-4404
> URL: https://issues.apache.org/jira/browse/WW-4404
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Interceptors
>Affects Versions: 2.3.20
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> Allows limit access to actions based on used Http method type
> https://github.com/apache/struts/pull/25



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5276) Cleanup method of request is not called

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679536#comment-17679536
 ] 

ASF subversion and git services commented on WW-5276:
-

Commit 05d7196e6cf451426eb301effc0416b2554b20f3 in struts's branch 
refs/heads/WW-5276-cleanup from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=05d7196e6 ]

WW-5276 Cleans up also wrapper request to avoid resource leak and potential DoS 
attack


> Cleanup method of request is not called
> ---
>
> Key: WW-5276
> URL: https://issues.apache.org/jira/browse/WW-5276
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.1.1
>Reporter: Mirek Hankus
>Priority: Major
> Fix For: 6.2.0
>
>
> After upgrading to 6.1.1  we have noticed that cleanup method of custom 
> MultiPartRequest is not called by struts. 
>  
>  
> It may be related to 
> [https://github.com/apache/struts/commit/69102e907551a87335231656320c8484072bdecb]
>  
> as before variable "request" was overwritten with wrapped request and cleanup 
> was called in finally section
>  
> After this commit new variable is created called "wrappedRequest", but 
> cleanup is called only on original request, and new wrappedRequest is not 
> cleaned up at all.
>  
> Below is respective code fragment
> {code:java}
> HttpServletRequest wrappedRequest = prepare.wrapRequest(request);
>                     ActionMapping mapping = 
> prepare.findActionMapping(wrappedRequest, response, true);
>                     if (mapping == null) {
>                         LOG.trace("Cannot find mapping for {}, passing to 
> other filters", uri);
>                         chain.doFilter(request, response);
>                     } else {
>                         LOG.trace("Found mapping {} for {}", mapping, uri);
>                         execute.executeAction(wrappedRequest, response, 
> mapping);
>                     }
>                 }
>             }
>         } finally {
>             prepare.cleanupRequest(request);
>         }{code}
>  
> This bug causes a lot of resource problems, and can result in denial of 
> service condition for application  (or making application not compliant - as 
> sensitive information is not properly discarded).
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5274) Mark Pell Multipart plugin as deprecated

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679534#comment-17679534
 ] 

ASF subversion and git services commented on WW-5274:
-

Commit 474a340553189dec4af293d80def60d9728ebd1b in struts's branch 
refs/heads/WW-5274-pell from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=474a34055 ]

WW-5274 Marks the Pell multipart plugin as deprecated


> Mark Pell Multipart plugin as deprecated
> 
>
> Key: WW-5274
> URL: https://issues.apache.org/jira/browse/WW-5274
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Plugin - Pell
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>
> This plugin is using library which isn't support nor actively developed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5277) Upgrade Freemarker to version 3.2.32

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679530#comment-17679530
 ] 

ASF subversion and git services commented on WW-5277:
-

Commit cde1753341557e0c767e8acf45adb3ac2bf51503 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=cde175334 ]

WW-5277 Upgrades Freemarker to version 2.3.32


> Upgrade Freemarker to version 3.2.32
> 
>
> Key: WW-5277
> URL: https://issues.apache.org/jira/browse/WW-5277
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Apache FreeMarker community is pleased to announce the release of
> Apache FreeMarker 2.3.32.
> https://freemarker.apache.org/docs/versions_2_3_32.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5277) Upgrade Freemarker to version 3.2.32

2023-01-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679531#comment-17679531
 ] 

ASF subversion and git services commented on WW-5277:
-

Commit 46738c970ef20c64d997122c6f15caf2b76f0653 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=46738c970 ]

Merge pull request #651 from apache/WW-5277-freemarker

[WW-5277] Upgrades Freemarker to version 2.3.32

> Upgrade Freemarker to version 3.2.32
> 
>
> Key: WW-5277
> URL: https://issues.apache.org/jira/browse/WW-5277
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Apache FreeMarker community is pleased to announce the release of
> Apache FreeMarker 2.3.32.
> https://freemarker.apache.org/docs/versions_2_3_32.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5277) Upgrade Freemarker to version 3.2.32

2023-01-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677183#comment-17677183
 ] 

ASF subversion and git services commented on WW-5277:
-

Commit cde1753341557e0c767e8acf45adb3ac2bf51503 in struts's branch 
refs/heads/WW-5277-freemarker from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=cde175334 ]

WW-5277 Upgrades Freemarker to version 2.3.32


> Upgrade Freemarker to version 3.2.32
> 
>
> Key: WW-5277
> URL: https://issues.apache.org/jira/browse/WW-5277
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>
> The Apache FreeMarker community is pleased to announce the release of
> Apache FreeMarker 2.3.32.
> https://freemarker.apache.org/docs/versions_2_3_32.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2023-01-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654538#comment-17654538
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit d90bee49b5d521c591084111a4cba76aef3b7ea3 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d90bee49b ]

Merge pull request #649 from apache/WW-5272-time

[WW-5272] Extends  to support java.sql.Time

> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2023-01-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17654537#comment-17654537
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit 08de24588ad5b88ec3554b476c9d3cf0fb47b32c in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=08de24588 ]

WW-5272 Extends  to support java.sql.Time


> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5273) Support fileupload using native Servlet API 3.1 logic

2022-12-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653147#comment-17653147
 ] 

ASF subversion and git services commented on WW-5273:
-

Commit a75934a9ff3e589ee382a624a5432981f772cb51 in struts's branch 
refs/heads/WW-5273-servlet-upload from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=a75934a9f ]

WW-5273 Supports file upload using Servlet API 3.1


> Support fileupload using native Servlet API 3.1 logic
> -
>
> Key: WW-5273
> URL: https://issues.apache.org/jira/browse/WW-5273
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Since Servlet API 3.1 there is no need in using Commons Fileupload as the 
> servlets support it.
> https://stackoverflow.com/questions/68820707/jetty-11-and-commons-fileupload



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5273) Support fileupload using native Servlet API 3.1 logic

2022-12-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653083#comment-17653083
 ] 

ASF subversion and git services commented on WW-5273:
-

Commit bfa4c090a97f4ad644a4d125e0178dd77fc85d28 in struts's branch 
refs/heads/WW-5273-servlet-upload from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=bfa4c090a ]

WW-5273 Supports file upload using Servlet API 3.1


> Support fileupload using native Servlet API 3.1 logic
> -
>
> Key: WW-5273
> URL: https://issues.apache.org/jira/browse/WW-5273
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Since Servlet API 3.1 there is no need in using Commons Fileupload as the 
> servlets support it.
> https://stackoverflow.com/questions/68820707/jetty-11-and-commons-fileupload



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2022-12-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652791#comment-17652791
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit 08de24588ad5b88ec3554b476c9d3cf0fb47b32c in struts's branch 
refs/heads/WW-5272-time from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=08de24588 ]

WW-5272 Extends  to support java.sql.Time


> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5273) Support fileupload using native Servlet API 3.1 logic

2022-12-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652789#comment-17652789
 ] 

ASF subversion and git services commented on WW-5273:
-

Commit 99e3992ed27bdbb82a902537ae9df07e7d65a9c1 in struts's branch 
refs/heads/WW-5273-servlet-upload from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=99e3992ed ]

WW-5273 Supports file upload using Servlet API 3.1


> Support fileupload using native Servlet API 3.1 logic
> -
>
> Key: WW-5273
> URL: https://issues.apache.org/jira/browse/WW-5273
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Since Servlet API 3.1 there is no need in using Commons Fileupload as the 
> servlets support it.
> https://stackoverflow.com/questions/68820707/jetty-11-and-commons-fileupload



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5273) Migrate Commons Fileupload to native Servlet-based multipart file upload

2022-12-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652784#comment-17652784
 ] 

ASF subversion and git services commented on WW-5273:
-

Commit f92e3b945dd69d18034c6aa09ad6dcbec128f1fc in struts's branch 
refs/heads/WW-5273-servlet-upload from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=f92e3b945 ]

WW-5273 Supports file upload using Servlet API 3.1


> Migrate Commons Fileupload to native Servlet-based multipart file upload
> 
>
> Key: WW-5273
> URL: https://issues.apache.org/jira/browse/WW-5273
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>
> Since Servlet API 3.1 there is no need in using Commons Fileupload as the 
> servlets support it.
> https://stackoverflow.com/questions/68820707/jetty-11-and-commons-fileupload



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5269) Upgrade Jackson to version 2.14.1

2022-12-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652491#comment-17652491
 ] 

ASF subversion and git services commented on WW-5269:
-

Commit bcf2e11518739ceab87631e57cb22fdf74a7cfc0 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=bcf2e1151 ]

Merge pull request #647 from apache/WW-5269-jackson

[WW-5269] Upgrades Jackson to version 2.14.1

> Upgrade Jackson to version 2.14.1
> -
>
> Key: WW-5269
> URL: https://issues.apache.org/jira/browse/WW-5269
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core, Plugin - REST
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5269) Upgrade Jackson to version 2.14.1

2022-12-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652490#comment-17652490
 ] 

ASF subversion and git services commented on WW-5269:
-

Commit 3bad2d0cecab1e364d35a6ab16b1f8b4df1b75af in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3bad2d0ce ]

WW-5269 Upgrades Jackson to version 2.14.1


> Upgrade Jackson to version 2.14.1
> -
>
> Key: WW-5269
> URL: https://issues.apache.org/jira/browse/WW-5269
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core, Plugin - REST
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5272) java.lang.UnsupportedOperationException in the Time component

2022-12-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652436#comment-17652436
 ] 

ASF subversion and git services commented on WW-5272:
-

Commit df110596c57318935a10665529eaf6b3f215b4fa in struts's branch 
refs/heads/WW-5272-time from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=df110596c ]

WW-5272 Extends  to support java.sql.Time


> java.lang.UnsupportedOperationException in the Time component
> -
>
> Key: WW-5272
> URL: https://issues.apache.org/jira/browse/WW-5272
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 6.0.3
>Reporter: Massimiliano Del Matto
>Priority: Major
> Fix For: 6.2.0
>
>
> We are facing a java.lang.UnsupportedOperationException on some java.sql.Time 
> fields in our frontend after migrating from 2.5.26 to 6.0.3.
> Error 12/22/2022 09:52:20:122 Caused by: 
> java.lang.UnsupportedOperationException
> Error 12/22/2022 09:52:20:122 at java.sql.Time.toInstant(Time.java:291)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.components.Date.end(Date.java:299)
> Error 12/22/2022 09:52:20:122 at 
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:40)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_date_2(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:408)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspx_method_s_form_0(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:1950)
> Error 12/22/2022 09:52:20:122 at 
> JEE_jsp_pages_ReadTicketGoing_1671640129851._jspService(JEE_jsp_pages_ReadTicketGoing_1671640129851.java:60)
> ...
>  
> At line 299 in Date.java there is no code related to java.sql.Time
> [https://github.com/apache/struts/blob/STRUTS_6_0_3/core/src/main/java/org/apache/struts2/components/Date.java#L299]
>  
> java.sql.Time extends java.util.Date so when dateObject is java.sql.Time is 
> treated like an instanceof java.util.Date and toInstant() throws the 
> UnsupportedOperationException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5269) Upgrade Jackson to version 2.14.1

2022-12-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648975#comment-17648975
 ] 

ASF subversion and git services commented on WW-5269:
-

Commit 3bad2d0cecab1e364d35a6ab16b1f8b4df1b75af in struts's branch 
refs/heads/WW-5269-jackson from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3bad2d0ce ]

WW-5269 Upgrades Jackson to version 2.14.1


> Upgrade Jackson to version 2.14.1
> -
>
> Key: WW-5269
> URL: https://issues.apache.org/jira/browse/WW-5269
> Project: Struts 2
>  Issue Type: Dependency
>  Components: Core, Plugin - REST
>Reporter: Lukasz Lenart
>Priority: Minor
> Fix For: 6.2.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2022-12-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646949#comment-17646949
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit 266d2d4ed526edbb8e8035df94e94a1007d7c360 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=266d2d4ed ]

Merge pull request #645 from atlassian/WW-5265-remove-container-provider

WW-5265 Allow removal of a single/specific container provider

> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2022-12-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646948#comment-17646948
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit 45aa17238604d13a83420e9c538f3a8c00ec46bf in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=45aa17238 ]

WW-5265 Allow removal of a single/specific container provider from Struts 
configuration


> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5265) Allow removal of a single/specific container provider

2022-12-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646947#comment-17646947
 ] 

ASF subversion and git services commented on WW-5265:
-

Commit b795a920a8aecb49980983b271c04555a5770eaf in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=b795a920a ]

WW-5265 Formatting fixes


> Allow removal of a single/specific container provider 
> --
>
> Key: WW-5265
> URL: https://issues.apache.org/jira/browse/WW-5265
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> As per title, this functionality would allow for adding container providers 
> that may be short-lived, or in modular/plugin-based system.
> Given that `ConfigurationManager#getContainerProviders`, 
> `ConfigurationManager#clearContainerProviders` and 
> `ConfigurationManager#addContainerProvider(ContainerProvider)` exist, this is 
> already possible, but the existence of an explicit method would make it more 
> performant.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646467#comment-17646467
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 0d81cdd85db79fcc8515bb6735814daec3a84ca6 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0d81cdd85 ]

Merge pull request #646 from apache/WW-5264-xslt-cleanup

[WW-5264] Removes XSLTResult from struts-default.xml as it was moved in to 
plugin

> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646466#comment-17646466
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit d11cf771b64bd1350d1e181a917b6beb106d0f6b in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d11cf771b ]

WW-5264 Uses proper parent package when testing XSLT result


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646465#comment-17646465
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 63dd9536cab7c1d10baea11c2b35ce9ea3ca06f0 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=63dd9536c ]

WW-5264 Removes XSLTResult from struts-default.xml as it was moved into plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646457#comment-17646457
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit d11cf771b64bd1350d1e181a917b6beb106d0f6b in struts's branch 
refs/heads/WW-5264-xslt-cleanup from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=d11cf771b ]

WW-5264 Uses proper parent package when testing XSLT result


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646456#comment-17646456
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 63dd9536cab7c1d10baea11c2b35ce9ea3ca06f0 in struts's branch 
refs/heads/WW-5264-xslt-cleanup from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=63dd9536c ]

WW-5264 Removes XSLTResult from struts-default.xml as it was moved into plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645196#comment-17645196
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 0e62b4b53456e3158393a050d30475896ce6d549 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0e62b4b53 ]

Merge pull request #641 from apache/WW-5264-xslt

[WW-5264] Moves XSLT result into a dedicated plugin

> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645195#comment-17645195
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 15dd2f2234e70dd95ed83900f2e255d7daddbca2 in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=15dd2f223 ]

WW-5264 Moves XSLT result into a dedicated plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645174#comment-17645174
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 15dd2f2234e70dd95ed83900f2e255d7daddbca2 in struts's branch 
refs/heads/WW-5264-xslt from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=15dd2f223 ]

WW-5264 Moves XSLT result into a dedicated plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645159#comment-17645159
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 3dc7598fa34f28a135b44ed82d32ac9155258ed8 in struts's branch 
refs/heads/WW-5264-xslt from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3dc7598fa ]

WW-5264 Moves XSLT result into a dedicated plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5199) StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to another action

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645150#comment-17645150
 ] 

ASF subversion and git services commented on WW-5199:
-

Commit 579796de5a2a1a638769b29ca412bf740eafe13e in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=579796de5 ]

Merge pull request #642 from atlassian/WW-5199-forward-action

WW-5199 Allow forwarding from/to actions

> StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to 
> another action
> ---
>
> Key: WW-5199
> URL: https://issues.apache.org/jira/browse/WW-5199
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.0.0
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Ween using {{StrutsPrepareFilter}}/{{StrutsExecuteFilter}} combination it 
> isn't possible to use {{DispatcherResult}} with forwarding to another actions 
> - it's do to the cleanup counter implemented in those filters.
> The same application using {{StrutsPrepareAndExecuteFilter}} works perfectly 
> fine, this is covered by 
> {{apps/showcase/src/test/java/it/org/apache/struts2/showcase/DispatcherResultTest.java}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5199) StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to another action

2022-12-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645149#comment-17645149
 ] 

ASF subversion and git services commented on WW-5199:
-

Commit afd04ea5af64768ba61b941a4fdd277674196820 in struts's branch 
refs/heads/master from Kusal Kithul-Godage
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=afd04ea5a ]

WW-5199 Allow forwarding from/to actions


> StrutsPrepareFilter and StrutsExecuteFilter do not support forwarding to 
> another action
> ---
>
> Key: WW-5199
> URL: https://issues.apache.org/jira/browse/WW-5199
> Project: Struts 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.0.0
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Ween using {{StrutsPrepareFilter}}/{{StrutsExecuteFilter}} combination it 
> isn't possible to use {{DispatcherResult}} with forwarding to another actions 
> - it's do to the cleanup counter implemented in those filters.
> The same application using {{StrutsPrepareAndExecuteFilter}} works perfectly 
> fine, this is covered by 
> {{apps/showcase/src/test/java/it/org/apache/struts2/showcase/DispatcherResultTest.java}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5264) Extract XSLT result into a dedicated plugin

2022-12-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643048#comment-17643048
 ] 

ASF subversion and git services commented on WW-5264:
-

Commit 9b11842bf2e2a12b6194a54642641a23714bcac1 in struts's branch 
refs/heads/WW-5264-xslt from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=9b11842bf ]

WW-5264 Moves XSLT result into a dedicated plugin


> Extract XSLT result into a dedicated plugin
> ---
>
> Key: WW-5264
> URL: https://issues.apache.org/jira/browse/WW-5264
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Core Results, Plugin - XSLT
>Reporter: Lukasz Lenart
>Priority: Major
> Fix For: 6.2.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> XSLT result can be easily extracted into a dedicated plugin - this will allow 
> users to include it when needed



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   3   4   5   6   7   8   9   10   >