[jira] [Created] (WW-5394) Use request encoding in rest plugin
Aleksandr Mashchenko created WW-5394: Summary: Use request encoding in rest plugin Key: WW-5394 URL: https://issues.apache.org/jira/browse/WW-5394 Project: Struts 2 Issue Type: Task Components: Plugin - REST Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5214) When value for SELECT element is greater than 2147483647, the value does not pre-select
[ https://issues.apache.org/jira/browse/WW-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585322#comment-17585322 ] Aleksandr Mashchenko commented on WW-5214: -- It is OGNL expression for creating a map. > When value for SELECT element is greater than 2147483647, the value does not > pre-select > --- > > Key: WW-5214 > URL: https://issues.apache.org/jira/browse/WW-5214 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.28, 2.5.30 >Reporter: Mike Livingston >Priority: Minor > Fix For: 6.1.0 > > Attachments: STRUTS_2_5_30.diff > > > If select tag is created with value greater than 2147483647 no option is > pre-selected. Attached diff was used to show the behavior in the SelectTest > unit test -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5214) When value for SELECT element is greater than 2147483647, the value does not pre-select
[
https://issues.apache.org/jira/browse/WW-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583447#comment-17583447
]
Aleksandr Mashchenko commented on WW-5214:
--
I think you need to explicitly set it to long or use strings.
{code:java}
"#{1:'Cat',2147483647L:'Dog'}" {code}
{code:java}
"#{'1':'Cat','2147483647':'Dog'}"
{code}
> When value for SELECT element is greater than 2147483647, the value does not
> pre-select
> ---
>
> Key: WW-5214
> URL: https://issues.apache.org/jira/browse/WW-5214
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.28, 2.5.30
>Reporter: Mike Livingston
>Priority: Minor
> Fix For: 6.1.0
>
> Attachments: STRUTS_2_5_30.diff
>
>
> If select tag is created with value greater than 2147483647 no option is
> pre-selected. Attached diff was used to show the behavior in the SelectTest
> unit test
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5128) Invalid HTTP status code - 14
[ https://issues.apache.org/jira/browse/WW-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343577#comment-17343577 ] Aleksandr Mashchenko commented on WW-5128: -- Show your code/configuration. Where do you use HttpHeaderResult? It is better to ask such questions in the mailing list. > Invalid HTTP status code - 14 > - > > Key: WW-5128 > URL: https://issues.apache.org/jira/browse/WW-5128 > Project: Struts 2 > Issue Type: Bug > Environment: RHEL 7.9, JBoss EAP 7.1.6, Open JDK 1.8.0.201 >Reporter: Joe Schmidt >Priority: Major > Fix For: 2.5.22 > > Attachments: http14.log > > > I have an application that is returning an HTTP status code of 14 instead of > 200 in some cases. It happens for one specific URL in the application. It > is not consistent between servers. The same ear file and even the same app > server can be copied to a different host and work correctly. > So far using Byteman I'm seeing that: > # 14 is passed to the org.apache.struts2.result.HttpHeaderResult construtor. > # When com.opensymphony.xwork2.DefaultActionInvocation.createResult() is > entered the value of DefaultActionInvocation.getResultCode() is "success", > which I beleive is correct. > Attached is a partial stack trace at that point. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5126) inconsistancy between Model Driven and Model Driven Interceptor documentations
[
https://issues.apache.org/jira/browse/WW-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334515#comment-17334515
]
Aleksandr Mashchenko commented on WW-5126:
--
Also I'm not sure what inconsistency you are refereeing to. Can you be more
specific.
> inconsistancy between Model Driven and Model Driven Interceptor documentations
> --
>
> Key: WW-5126
> URL: https://issues.apache.org/jira/browse/WW-5126
> Project: Struts 2
> Issue Type: Improvement
>Reporter: Patrice DUROUX
>Assignee: Yasser Zamani
>Priority: Minor
> Fix For: 2.5.27, 2.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Hi,
>
> The Model Driven documentation says:
> If an action class implements the interface
> {{com.opensymphony.xwork2.ModelDriven}} then it needs to return an object
> from the {{getModel()}} method. Struts will then populate the fields of this
> object with the request parameters, and *this object will be placed on top of
> the stack once the action is executed*. Validation will also be performed on
> this model object, instead of the action. Please read about
> [VisitorFieldValidator
> Annotation|https://github.com/apache/struts-site/blob/master/source/core-developers/visitor-field-validator-annotation.html]
> which can help you validate model's fields.
> where as the Model Driven Interceptor documentation says:
> h2. Parameters
> * {{refreshModelBeforeResult}} - *set to true if you want the model to be
> refreshed on the value stack after action execution and before result
> execution*. The setting is useful if you want to change the model instance
> during the action execution phase, like when loading it from the data layer.
> This will result in {{getModel()}} being called at least twice.
>
> Looking into the code shows that the default parameter value is false.
> Moreover the interceptor refresh process is based on call to the {{equals}}
> method and this method may have been redefined, in a JPA context for
> instance. The replacement is then not systematic and may not be done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-5126) inconsistancy between Model Driven and Model Driven Interceptor documentations
[
https://issues.apache.org/jira/browse/WW-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334513#comment-17334513
]
Aleksandr Mashchenko commented on WW-5126:
--
What is the issue with comparing by using equals?
> inconsistancy between Model Driven and Model Driven Interceptor documentations
> --
>
> Key: WW-5126
> URL: https://issues.apache.org/jira/browse/WW-5126
> Project: Struts 2
> Issue Type: Improvement
>Reporter: Patrice DUROUX
>Assignee: Yasser Zamani
>Priority: Minor
> Fix For: 2.5.27, 2.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Hi,
>
> The Model Driven documentation says:
> If an action class implements the interface
> {{com.opensymphony.xwork2.ModelDriven}} then it needs to return an object
> from the {{getModel()}} method. Struts will then populate the fields of this
> object with the request parameters, and *this object will be placed on top of
> the stack once the action is executed*. Validation will also be performed on
> this model object, instead of the action. Please read about
> [VisitorFieldValidator
> Annotation|https://github.com/apache/struts-site/blob/master/source/core-developers/visitor-field-validator-annotation.html]
> which can help you validate model's fields.
> where as the Model Driven Interceptor documentation says:
> h2. Parameters
> * {{refreshModelBeforeResult}} - *set to true if you want the model to be
> refreshed on the value stack after action execution and before result
> execution*. The setting is useful if you want to change the model instance
> during the action execution phase, like when loading it from the data layer.
> This will result in {{getModel()}} being called at least twice.
>
> Looking into the code shows that the default parameter value is false.
> Moreover the interceptor refresh process is based on call to the {{equals}}
> method and this method may have been redefined, in a JPA context for
> instance. The replacement is then not systematic and may not be done.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-5118) OGNL long conversion
[ https://issues.apache.org/jira/browse/WW-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297699#comment-17297699 ] Aleksandr Mashchenko commented on WW-5118: -- Think I've found a culprit here - https://github.com/jkuhnert/ognl/blob/703059882a3d6e55ffd36dd9d1722496d6cd853c/src/main/java/ognl/OgnlOps.java#L816 [~lukaszlenart] Maybe [isEqual|https://github.com/jkuhnert/ognl/blob/703059882a3d6e55ffd36dd9d1722496d6cd853c/src/main/java/ognl/OgnlOps.java#L129] can be used directly in here too? > OGNL long conversion > > > Key: WW-5118 > URL: https://issues.apache.org/jira/browse/WW-5118 > Project: Struts 2 > Issue Type: Task >Reporter: Aleksandr Mashchenko >Priority: Major > > Found on StackOverflow - > https://stackoverflow.com/questions/66138007/struts-ognl-long-overflow. > Long in action 403184100337478L and 403184100337292L, are equal when > comparing them in JSP. > Guess, there is some issue converting long to double. > Can we do something about this? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (WW-4917) Clarification on security status and support for Struts 2.3
[ https://issues.apache.org/jira/browse/WW-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko closed WW-4917. Resolution: Done 2.3 is EOL. > Clarification on security status and support for Struts 2.3 > --- > > Key: WW-4917 > URL: https://issues.apache.org/jira/browse/WW-4917 > Project: Struts 2 > Issue Type: Task > Components: Documentation >Affects Versions: 2.3.34 >Reporter: Richard Taylor >Priority: Minor > Labels: security > Fix For: 2.5.x > > > Hi > > Can you kindly provide clarity as to the exact status of the 2.3 series in > terms of ongoing support and security status. > > > On the Struts web page [https://struts.apache.org/] > > I found the statement: > > "It's the latest release of Struts 2.3.x which contains the latest security > fixes, read more in > [Announcement|https://struts.apache.org/announce.html#a20170907] or in > [Version notes|https://struts.apache.org/docs/version-notes-2334.html]"; > > Yet, on the page at [https://struts.apache.org/releases.html] it is stated > that : > > h2. "Prior Releases > As a courtesy, we retain archival copies of the website for releases that > initially were considered "General Availability" but which has been > reclassified as "Not recommended" since they contain security issues > " > And version 2.3.34 is listed here. > > > Lastly - I find no EOL announcement for 2.3.x > > So in summary the question is: > > *1 Is the 2.3 series EOL?* > *2 Does 2.3.34 contain any known security bugs?* > > > Thanking you in advance > > Richard -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (WW-2411) Add a maxlength attribute to the textarea tag
[ https://issues.apache.org/jira/browse/WW-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-2411. -- Resolution: Fixed > Add a maxlength attribute to the textarea tag > - > > Key: WW-2411 > URL: https://issues.apache.org/jira/browse/WW-2411 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Tags >Affects Versions: 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, > 2.0.8, 2.0.9, 2.0.10, 2.0.11 >Reporter: Mark Lewis >Priority: Minor > Fix For: 2.6 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > This is an easy one. The maxlength attribute already exists for the > s:textfield tag (which directly corresponds to the maxlength attribute of the > HTML input tag). A bit of javascript can easily place a character limit on > an HTML textarea element, and this could be controlled by adding an attribute > to the s:textarea tag. > Certain themes could also display the number of characters remaining in a > separate element or tooltip. > Probably affects versions beyond those listed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (WW-5118) OGNL long conversion
Aleksandr Mashchenko created WW-5118: Summary: OGNL long conversion Key: WW-5118 URL: https://issues.apache.org/jira/browse/WW-5118 Project: Struts 2 Issue Type: Task Reporter: Aleksandr Mashchenko Found on StackOverflow - https://stackoverflow.com/questions/66138007/struts-ognl-long-overflow. Long in action 403184100337478L and 403184100337292L, are equal when comparing them in JSP. Guess, there is some issue converting long to double. Can we do something about this? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (WW-5093) inconsistent scope for variables created with s:set and s:url
[ https://issues.apache.org/jira/browse/WW-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210664#comment-17210664 ] Aleksandr Mashchenko edited comment on WW-5093 at 10/9/20, 6:59 AM: AFAIR the scope is the same. Can you back up your claim with example? Usually there is a little value in setting s:url or s:text to different scope, and if really needed it can be achieved with the s:set tag. Var in s:property doesn't make sense at all. Overall, these are different tags for different purposes. was (Author: aleksandr-m): AFAIR the scope is the same. Can you back up your claim with example? Usually there is a little value in setting s:url or s:text to different scope, and if really needed it can be achieved with the s:set tag. And var in s:property doesn't make sens at all. Overall, these are different tags for different purposes. > inconsistent scope for variables created with s:set and s:url > - > > Key: WW-5093 > URL: https://issues.apache.org/jira/browse/WW-5093 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.22 >Reporter: nikos dimitrakas >Priority: Major > Labels: scope, tag, var > Fix For: 2.6 > > > The implementation of s:set and s:url and s:text is not consistent and not > well documented. > Creating a variable with s:set puts the variable in a different default scope > than creating a variable with s:url or s:text (with the attribute var). It is > also not documented what the default scope is. After testing I could conclude > that the scope for a variable created by s:url is request, while the default > of s:set is not. Furthermore, s:set offers a possibility to specify the scope > with an attribute, But s:url and s:text do not. > Possible options would be offering the possibility to specify the scope > attribute in s:url and s:text, or dropping support for the var attribute for > s:url and s:text and only allow s:set to create variables (thus being forced > to nest s:url and s:text inside an s:set). That would be symmetric with how > s:property does not offer the var attribute. At minimum all three tags should > have the same default and their default should be explicitly specified in the > documentation (in the tld and the online manual / tag reference) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5093) inconsistent scope for variables created with s:set and s:url
[ https://issues.apache.org/jira/browse/WW-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210664#comment-17210664 ] Aleksandr Mashchenko commented on WW-5093: -- AFAIR the scope is the same. Can you back up your claim with example? Usually there is a little value in setting s:url or s:text to different scope, and if really needed it can be achieved with the s:set tag. And var in s:property doesn't make sens at all. Overall, these are different tags for different purposes. > inconsistent scope for variables created with s:set and s:url > - > > Key: WW-5093 > URL: https://issues.apache.org/jira/browse/WW-5093 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.22 >Reporter: nikos dimitrakas >Priority: Major > Labels: scope, tag, var > Fix For: 2.6 > > > The implementation of s:set and s:url and s:text is not consistent and not > well documented. > Creating a variable with s:set puts the variable in a different default scope > than creating a variable with s:url or s:text (with the attribute var). It is > also not documented what the default scope is. After testing I could conclude > that the scope for a variable created by s:url is request, while the default > of s:set is not. Furthermore, s:set offers a possibility to specify the scope > with an attribute, But s:url and s:text do not. > Possible options would be offering the possibility to specify the scope > attribute in s:url and s:text, or dropping support for the var attribute for > s:url and s:text and only allow s:set to create variables (thus being forced > to nest s:url and s:text inside an s:set). That would be symmetric with how > s:property does not offer the var attribute. At minimum all three tags should > have the same default and their default should be explicitly specified in the > documentation (in the tld and the online manual / tag reference) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5089) @PreDestroy callbacks not invoked on injected beans
[
https://issues.apache.org/jira/browse/WW-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197384#comment-17197384
]
Aleksandr Mashchenko commented on WW-5089:
--
I'm no 100% sure about this, but I think the cdi plugin by default doesn't
create a full-blown bean out of actions. It allows injections to actions, but
that's it. Annotations and @PreDestroy are not going to work on actions unless
you create a proper bean out of it by yourself.
[~bartlomiej-kfn]
Try to create a bean from action with @RequestScoped and *use* it, then
@PreDestroy on your CDIBean should work.
> @PreDestroy callbacks not invoked on injected beans
> ---
>
> Key: WW-5089
> URL: https://issues.apache.org/jira/browse/WW-5089
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - CDI
>Affects Versions: 2.5.22
> Environment: Apache Tomcat 9.0.31, Open JDK 13.0.2
>Reporter: Bartłomiej N
>Priority: Major
>
> I have web app deployed on tomcat with:
> {code:xml}
>
> org.apache.struts
> struts2-core
> 2.5.22
>
>
> org.apache.struts
> struts2-cdi-plugin
> 2.5.22
>
>
> org.jboss.weld.servlet
> weld-servlet-core
> 3.1.5.Final
>
> {code}
> and:
> {code:xml}
>
> org.jboss.weld.environment.servlet.Listener
>
>
> BeanManager
>
> javax.enterprise.inject.spi.BeanManager
>
>
> {code}
>
> as CDI bootstrap in web.xml and empty beans.xml in META-INF directory. There
> is also context.xml for Tomcat in webapp/META-INF:
> {code:xml}
>
>
>auth="Container"
> type="javax.enterprise.inject.spi.BeanManager"
> factory="org.jboss.weld.resources.ManagerObjectFactory"/>
>
> {code}
> In app there is a simple CDI bean:
> {code:java}
> public class CDIBean {
> @PostConstruct
> private void postConstruct() {
>//some code
> }
> @PreDestroy
> private void preDestroy() {
> //some code
> }
> }
> {code}
> when is use it in Struts action:
> {code:java}
> class MyAction extends ActionSupport implements SessionAware {
> @Inject
> private CDIBean bean;
> Strign execute() {
>//some code
> }
> }
> {code}
> @postConstruct callback is invoked and bean is injected correctly, but after
> request completion @preDestroy is not invoked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-5076) struts2 redirecting to https to http
[
https://issues.apache.org/jira/browse/WW-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112074#comment-17112074
]
Aleksandr Mashchenko commented on WW-5076:
--
Use {{redirectAction}} result type to redirect to actions.
> struts2 redirecting to https to http
>
>
> Key: WW-5076
> URL: https://issues.apache.org/jira/browse/WW-5076
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.3.32
>Reporter: Manikanta Maddukuri
>Priority: Major
> Fix For: 2.6
>
>
> I deployed struts2 application and mapped a domain name,ssl . I am sending
> https request and wherever i used struts2 redirection mapping, strut2 is
> sending http redirect url instead of https redirect url.
>
> In result chrome is cancelling the http request.
>
> Error from chrome console:
> Mixed Content: The page at 'https://.' was loaded over HTTPS, but
> requested an insecure form action 'http://...'. This request has been
> blocked; the content must be served over HTTPS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (WW-5076) struts2 redirecting to https to http
[ https://issues.apache.org/jira/browse/WW-5076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko updated WW-5076: - Priority: Major (was: Blocker) > struts2 redirecting to https to http > > > Key: WW-5076 > URL: https://issues.apache.org/jira/browse/WW-5076 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.3.32 >Reporter: Manikanta Maddukuri >Priority: Major > Fix For: 2.6 > > > I deployed struts2 application and mapped a domain name,ssl . I am sending > https request and wherever i used struts2 redirection mapping, strut2 is > sending http redirect url instead of https redirect url. > > In result chrome is cancelling the http request. > > Error from chrome console: > Mixed Content: The page at 'https://.' was loaded over HTTPS, but > requested an insecure form action 'http://...'. This request has been > blocked; the content must be served over HTTPS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters
[
https://issues.apache.org/jira/browse/WW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075753#comment-17075753
]
Aleksandr Mashchenko edited comment on WW-5065 at 4/5/20, 8:49 AM:
---
Haven't looked at the code, but isn't this needed for wildcard mappings in
result?
E.g.
{code:java}
/{1}.jsp
{code}
was (Author: aleksandr-m):
Haven't looked at the code, but isn't this needed for wildcard mappings in
result?
E.g. /{1}.jsp
> AbstractMatcher adds values to the map passed into replaceParameters
>
>
> Key: WW-5065
> URL: https://issues.apache.org/jira/browse/WW-5065
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.22
>Reporter: Alex Kaiser
>Priority: Minor
> Fix For: 2.6
>
>
> There is a bug with the AbstractMatcher#replaceParameters method in
> struts/core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
> (currently lines 153-170). As the function currently works it will return a
> map that has more keys than the "orig" map that is passed into it. For
> example, assume that I have the following config defined in my struts.xml
> file:
> {code:java}
>
>method="execute">
>
> random
>
>
> {code}
> If you send a request to "/test/uno/dos", this will trigger code in
> ActionConfigMatcher (lines 95-103) that will construct the ResultConfig
> objects to be used later on. At one point you are going to be making a call
> to AbstractMatcher#replaceParameters with something that looks like the
> following:
> orig:
> "inputName" -> "random"
> vars:
> "0" -> "uno/dos"
> "paramOne" -> "uno"
> "1" -> "uno"
> "paramTwo" -> "dos"
> "2" -> "dos"
> The result of this will be a map that looks like:
> "inputName" -> "random"
> "paramOne" -> "uno"
> "paramTwo" -> "dos"
> The bug is that "paramOne" and "paramTwo" should not be in the return map.
> For the most part this but won't cause any problems but it will cause some
> performance problems in certain situations when trying to set these
> parameters on the results objects that aren't expecting them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-5065) AbstractMatcher adds values to the map passed into replaceParameters
[
https://issues.apache.org/jira/browse/WW-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075753#comment-17075753
]
Aleksandr Mashchenko commented on WW-5065:
--
Haven't looked at the code, but isn't this needed for wildcard mappings in
result?
E.g. /{1}.jsp
> AbstractMatcher adds values to the map passed into replaceParameters
>
>
> Key: WW-5065
> URL: https://issues.apache.org/jira/browse/WW-5065
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.22
>Reporter: Alex Kaiser
>Priority: Minor
> Fix For: 2.6
>
>
> There is a bug with the AbstractMatcher#replaceParameters method in
> struts/core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
> (currently lines 153-170). As the function currently works it will return a
> map that has more keys than the "orig" map that is passed into it. For
> example, assume that I have the following config defined in my struts.xml
> file:
> {code:java}
>
>method="execute">
>
> random
>
>
> {code}
> If you send a request to "/test/uno/dos", this will trigger code in
> ActionConfigMatcher (lines 95-103) that will construct the ResultConfig
> objects to be used later on. At one point you are going to be making a call
> to AbstractMatcher#replaceParameters with something that looks like the
> following:
> orig:
> "inputName" -> "random"
> vars:
> "0" -> "uno/dos"
> "paramOne" -> "uno"
> "1" -> "uno"
> "paramTwo" -> "dos"
> "2" -> "dos"
> The result of this will be a map that looks like:
> "inputName" -> "random"
> "paramOne" -> "uno"
> "paramTwo" -> "dos"
> The bug is that "paramOne" and "paramTwo" should not be in the return map.
> For the most part this but won't cause any problems but it will cause some
> performance problems in certain situations when trying to set these
> parameters on the results objects that aren't expecting them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WW-5021) Serve static resources from different namespace
[ https://issues.apache.org/jira/browse/WW-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774992#comment-16774992 ] Aleksandr Mashchenko commented on WW-5021: -- [~k918912] I agree with Yasser. Namespaces are ok, but you cannot have multiple apps in root. Out of curiosity: I wonder, how do you found out of this if everything is working? :) > Serve static resources from different namespace > --- > > Key: WW-5021 > URL: https://issues.apache.org/jira/browse/WW-5021 > Project: Struts 2 > Issue Type: Task >Affects Versions: 2.5.20 >Reporter: k918912 >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > Is it somehow possible to serve the static Struts files from a different path? > Currently domTT.js is loaded via /struts, but in my environment I would like > to serve it via /test/struts for example. Is there any configuration I'm > missing or is this currently not possible? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5021) Serve static resources from different namespace
[
https://issues.apache.org/jira/browse/WW-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771339#comment-16771339
]
Aleksandr Mashchenko commented on WW-5021:
--
[~k918912] But others apps are not under root, so the have context path, right?
Also does it matter which app will serve inner static resource? They should be
the same. :)
{quote}Now I can easily configure this behind my load balancer, to redirect to
the correct Tomcat (because there are several Struts applications under the
same domain).{quote}
Based on what you choose correct tomcat / app? Why can't you use it for static
resources?
> Serve static resources from different namespace
> ---
>
> Key: WW-5021
> URL: https://issues.apache.org/jira/browse/WW-5021
> Project: Struts 2
> Issue Type: Task
>Affects Versions: 2.5.20
>Reporter: k918912
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 2.6
>
>
> Is it somehow possible to serve the static Struts files from a different path?
> Currently domTT.js is loaded via /struts, but in my environment I would like
> to serve it via /test/struts for example. Is there any configuration I'm
> missing or is this currently not possible?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5021) Serve static resources from different namespace
[ https://issues.apache.org/jira/browse/WW-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769643#comment-16769643 ] Aleksandr Mashchenko commented on WW-5021: -- [~k918912] What exactly you are trying to achieve? Why does it matter which url is used for loading internal static resources? Also have you seen this: [Serve static files (JavaScript) with Struts 2|https://stackoverflow.com/q/4046204/1700321] > Serve static resources from different namespace > --- > > Key: WW-5021 > URL: https://issues.apache.org/jira/browse/WW-5021 > Project: Struts 2 > Issue Type: Task >Affects Versions: 2.5.20 >Reporter: k918912 >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > Is it somehow possible to serve the static Struts files from a different path? > Currently domTT.js is loaded via /struts, but in my environment I would like > to serve it via /test/struts for example. Is there any configuration I'm > missing or is this currently not possible? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-5016) Support java8 date/time in date tag
Aleksandr Mashchenko created WW-5016: Summary: Support java8 date/time in date tag Key: WW-5016 URL: https://issues.apache.org/jira/browse/WW-5016 Project: Struts 2 Issue Type: Task Components: Core Tags Affects Versions: 2.6 Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko Fix For: 2.6 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-4991) Not existing property in listValueKey throws exception
[
https://issues.apache.org/jira/browse/WW-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko resolved WW-4991.
--
Resolution: Fixed
> Not existing property in listValueKey throws exception
> --
>
> Key: WW-4991
> URL: https://issues.apache.org/jira/browse/WW-4991
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.5.x, 2.6
>Reporter: Aleksandr Mashchenko
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> {\{}} and \{{}} tags are affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-5008) Upgrade to OGNL version 3.1.22
[ https://issues.apache.org/jira/browse/WW-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-5008. -- Resolution: Fixed > Upgrade to OGNL version 3.1.22 > -- > > Key: WW-5008 > URL: https://issues.apache.org/jira/browse/WW-5008 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Affects Versions: 2.5.20 >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.5.21 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (WW-5010) Switch to Java 8
[ https://issues.apache.org/jira/browse/WW-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko reassigned WW-5010: Assignee: Aleksandr Mashchenko > Switch to Java 8 > > > Key: WW-5010 > URL: https://issues.apache.org/jira/browse/WW-5010 > Project: Struts 2 > Issue Type: Task >Affects Versions: 2.6 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-5010) Switch to Java 8
[ https://issues.apache.org/jira/browse/WW-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-5010. -- Resolution: Fixed > Switch to Java 8 > > > Key: WW-5010 > URL: https://issues.apache.org/jira/browse/WW-5010 > Project: Struts 2 > Issue Type: Task >Affects Versions: 2.6 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-5010) Switch to Java 8
Aleksandr Mashchenko created WW-5010: Summary: Switch to Java 8 Key: WW-5010 URL: https://issues.apache.org/jira/browse/WW-5010 Project: Struts 2 Issue Type: Task Affects Versions: 2.6 Reporter: Aleksandr Mashchenko Fix For: 2.6 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-4991) Not existing property in listValueKey throws exception
[
https://issues.apache.org/jira/browse/WW-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko updated WW-4991:
-
Fix Version/s: 2.5.21
> Not existing property in listValueKey throws exception
> --
>
> Key: WW-4991
> URL: https://issues.apache.org/jira/browse/WW-4991
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tags
>Affects Versions: 2.5.x, 2.6
>Reporter: Aleksandr Mashchenko
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> {\{}} and \{{}} tags are affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745521#comment-16745521
]
Aleksandr Mashchenko commented on WW-5004:
--
[~lukaszlenart] Do you have some example why it should be restricted at all?
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745517#comment-16745517
]
Aleksandr Mashchenko edited comment on WW-5004 at 1/17/19 9:21 PM:
---
[~lukaszlenart] {{disallowProxyMemberAccess}} will be true if spring plugin is
used and allowStaticMethodAccess should be set. Still, why MemberAccess should
be called for fields?
was (Author: aleksandr-m):
[~lukaszlenart] {{disallowProxyMemberAccess}} will be true if spring plugin is
used. Still, why MemberAccess should be called for fields?
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745517#comment-16745517
]
Aleksandr Mashchenko commented on WW-5004:
--
[~lukaszlenart] {{disallowProxyMemberAccess}} will be true if spring plugin is
used. Still, why MemberAccess should be called for fields?
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745498#comment-16745498
]
Aleksandr Mashchenko commented on WW-5004:
--
{\{allowStaticMethodAccess}} will work only if \{{disallowProxyMemberAccess}}
is \{{false}} and \{{ProxyUtil.isProxyMember}} is not called. But it is still
wrong to use \{{allowStaticMethodAccess}} for fields.
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745513#comment-16745513
]
Aleksandr Mashchenko commented on WW-5004:
--
It is kind of working in 2.6 with caveat that \{{allowStaticMethodAccess}} is
used for fields which is wrong.
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745465#comment-16745465
]
Aleksandr Mashchenko commented on WW-5004:
--
[~DenizR] As a workaround you can downgrade OGNL to 3.1.18.
{code:java}
ognl
ognl
3.1.18
{code}
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745398#comment-16745398
]
Aleksandr Mashchenko commented on WW-5004:
--
We've discovered same bug today. It is broken by this commit
[https://github.com/jkuhnert/ognl/commit/4da6759b2f8e746cd1b8fbfabde5d067e3ea0baa]
in OGNL.
NPE is thrown somewhere in {{ProxyUtil}} and even if it is fixed then
displaying static field still doesn't work.
I wonder why do we need to call MemberAccess in case of static fields at all?
Also why do OGNL allows to access private static fields? It doesn't seem
reasonable.
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[
https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko updated WW-5004:
-
Priority: Critical (was: Major)
> No more calling of a static variable in Struts 2.8.20 available
> ---
>
> Key: WW-5004
> URL: https://issues.apache.org/jira/browse/WW-5004
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.20
> Environment: Java 7.1 and JSP Websites
>Reporter: Deniz Renkligül
>Priority: Critical
> Labels: build, features, patch, usability
> Fix For: 2.5.21, 2.6
>
>
> After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call
> a java static variable in JSP like
> {code:java}
>
> {code}
> Please see for more details the release notes of 2.5.20
> [link
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20]
> and I tried without success the following description assigned above in the
> release version notes 2.5.20 with :
> {code:java}
>
>
> {code}
> https://issues.apache.org/jira/browse/WW-4984
>
> Thanks in advance for your support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4998) I18nInterceptor's default storage should store locale
[
https://issues.apache.org/jira/browse/WW-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko resolved WW-4998.
--
Resolution: Fixed
Fix Version/s: 2.5.20
2.6
> I18nInterceptor's default storage should store locale
> -
>
> Key: WW-4998
> URL: https://issues.apache.org/jira/browse/WW-4998
> Project: Struts 2
> Issue Type: Task
> Components: Core Interceptors
>Affects Versions: 2.5.18, 2.6
>Reporter: Aleksandr Mashchenko
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.20
>
>
> First request to application with \{{request_locale}} parameter doesn't save
> locale if session was not created yet.
> [Discussion|https://lists.apache.org/thread.html/0a3168cb80ddfe0e3a920f010bffc719707b4626478aee26fe78b8de@%3Cdev.struts.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (WW-4998) I18nInterceptor's default storage should store locale
Aleksandr Mashchenko created WW-4998:
Summary: I18nInterceptor's default storage should store locale
Key: WW-4998
URL: https://issues.apache.org/jira/browse/WW-4998
Project: Struts 2
Issue Type: Task
Components: Core Interceptors
Affects Versions: 2.5.18, 2.6
Reporter: Aleksandr Mashchenko
Assignee: Aleksandr Mashchenko
First request to application with \{{request_locale}} parameter doesn't save
locale if session was not created yet.
[Discussion|https://lists.apache.org/thread.html/0a3168cb80ddfe0e3a920f010bffc719707b4626478aee26fe78b8de@%3Cdev.struts.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4741) Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value.
[
https://issues.apache.org/jira/browse/WW-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733461#comment-16733461
]
Aleksandr Mashchenko commented on WW-4741:
--
[~agreenfield] I know this is old issue, but what problem you had with
I18nInterceptor creating session? If storage is Storage.SESSION then session
should be there.
> Http Sessions forcefully created for all requests using I18nInterceptor with
> default Storage value.
> ---
>
> Key: WW-4741
> URL: https://issues.apache.org/jira/browse/WW-4741
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.10
>Reporter: Adam Greenfield
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 2.5.16
>
>
> Changes made in WW-4730 for store and read functions cause an httpSession to
> be created for every request that uses I18nInterceptor when storage =
> Storage.SESSION.
> Current code checks for
> {noformat}Map session =
> invocation.getInvocationContext().getSession(){noformat}
> to be null and then calls
> {noformat}ServletActionContext.getRequest().getSession(){noformat}
> (notice how the second one references the HttpServletRequest. The
> HttpServletRequest Session and and the InvocationContext session are
> different. The request's session can be null, even if the
> InvocationContext's session is not).
> Calling .getSession() in this manner forcefully creates a session.
> An appropriate check here might be
> {noformat}HttpSession httpSession =
> ServletActionContext.getRequest().getSession(false);
> if(httpSession != null) {
> ... // get sessionId and synchronize on it
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko resolved WW-4987.
--
Resolution: Fixed
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
> Attachments: optgroup.ftl, select.ftl, struts.log
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720594#comment-16720594
]
Aleksandr Mashchenko commented on WW-4987:
--
[~mfsalmani678] Yes.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
> Attachments: optgroup.ftl, select.ftl, struts.log
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4964) Missing javascript in form-validate.ftl
[ https://issues.apache.org/jira/browse/WW-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-4964. -- Resolution: Fixed > Missing javascript in form-validate.ftl > --- > > Key: WW-4964 > URL: https://issues.apache.org/jira/browse/WW-4964 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.17 >Reporter: nikos dimitrakas >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > There are two versions of form-validate.ftl, one in xhtml theme and one in > css_xhtml theme. The one in css_xhtml is missing the script tag for utils.js > (and also some special character cleaning). This causes the following error > on the client: > Uncaught ReferenceError: StrutsUtils is not defined > at validation.js:161 > (anonymous) @ validation.js:161 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-4991) Not existing property in listValueKey throws exception
Aleksandr Mashchenko created WW-4991:
Summary: Not existing property in listValueKey throws exception
Key: WW-4991
URL: https://issues.apache.org/jira/browse/WW-4991
Project: Struts 2
Issue Type: Bug
Components: Plugin - Tags
Affects Versions: 2.5.x, 2.6
Reporter: Aleksandr Mashchenko
Assignee: Aleksandr Mashchenko
Fix For: 2.6
{\{}} and \{{}} tags are affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707421#comment-16707421
]
Aleksandr Mashchenko edited comment on WW-4987 at 12/3/18 4:04 PM:
---
[~mfsalmani678] I'll add {{list*}} attributes to {{}} in 2.6.
Meanwhile you can use plain html.
{code:java}
{code}
was (Author: aleksandr-m):
[~mfsalmani678] I'll add \{{list*}} attributes to \{{}} in 2.6.
Meanwhile you can use plain html.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
> Attachments: struts.log
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707421#comment-16707421
]
Aleksandr Mashchenko edited comment on WW-4987 at 12/3/18 4:04 PM:
---
[~mfsalmani678] I'll add {{list*}} attributes to {{}} in 2.6.
Meanwhile you can use plain html.
{code:java}
{code}
was (Author: aleksandr-m):
[~mfsalmani678] I'll add {{list*}} attributes to {{}} in 2.6.
Meanwhile you can use plain html.
{code:java}
{code}
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
> Attachments: struts.log
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707421#comment-16707421
]
Aleksandr Mashchenko commented on WW-4987:
--
[~mfsalmani678] I'll add \{{list*}} attributes to \{{}} in 2.6.
Meanwhile you can use plain html.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
> Attachments: struts.log
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702388#comment-16702388
]
Aleksandr Mashchenko commented on WW-4987:
--
Put {{}} with {{}} instead of {{}}.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko reassigned WW-4987:
Assignee: Aleksandr Mashchenko
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Assignee: Aleksandr Mashchenko
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700989#comment-16700989
]
Aleksandr Mashchenko edited comment on WW-4987 at 11/27/18 8:44 PM:
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this:
{code:java}
{code}
will be translated into options with {{class="one"}} and {{class="two"}}
respectively.
Or even
{code:java}
{code}
->
{{class="thisinone"}} and {{class="thisistwo"}}.
We can change optgroup template to apply the {{listCssClass}} from select to
optgroups in it, but it won't work for every case. For example if select's
{{list}} is a map and optgroup's {{list}} is a list.
was (Author: aleksandr-m):
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this:
{code:java}
{code}
will be translated into options with {{class="one"}} and {{class="two"}}
respectively.
Or even
{code:java}
{code}
->
{{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700989#comment-16700989
]
Aleksandr Mashchenko edited comment on WW-4987 at 11/27/18 8:43 PM:
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this:
{code:java}
{code}
will be translated into options with {{class="one"}} and {{class="two"}}
respectively.
Or even
{code:java}
{code}
->
{{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
was (Author: aleksandr-m):
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this:
{code:java}
{code}
will be translated into options with {{class="one"}} and {{class="two"}}
respectively. Or even
{code:java}
{code}
->
{{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700989#comment-16700989
]
Aleksandr Mashchenko edited comment on WW-4987 at 11/27/18 8:42 PM:
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this:
{code:java}
{code}
will be translated into options with {{class="one"}} and {{class="two"}}
respectively. Or even
{code:java}
{code}
->
{{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
was (Author: aleksandr-m):
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this: {{}} will be translated into options with {{class="one"}} and
{{class="two"}} respectively. Or even {{ }} -> {{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700989#comment-16700989
]
Aleksandr Mashchenko commented on WW-4987:
--
Use plain html optgroup with {{}}.
The real power of {{listCssClass}} comes from evaluating expression against
value stack, so something like this: {{}} will be translated into options with {{class="one"}} and
{{class="two"}} respectively. Or even {{ }} -> {{class="thisinone"}} and {{class="thisistwo"}}.
The {{listCssClass}} from select can be applied to optgroups in it, but it
won't work for every case. For example if select's {{list}} is a map and
optgroup's {{list}} is a list.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko updated WW-4987:
-
Priority: Major (was: Blocker)
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Major
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699542#comment-16699542
]
Aleksandr Mashchenko edited comment on WW-4987 at 11/26/18 8:30 PM:
[~mfsalmani678] What exactly is {{templateType}}? You're using it in two
different attributes in {{cssClass}} it would be just css class for select tag
(), in {{listCssClass}} it would be evaluated
against value stack to get css class for options in select ONLY, NOT in
optgroup. AFAIK {{listCssClass}} never worked for optgroup.
was (Author: aleksandr-m):
[~mfsalmani678] What exactly is {{templateType}}? You're using it in two
different attributes in {{cssClass}} it would be just css class for select tag
(), in {{listCssClass}} it would be evaluated
against value stack to get css class for options in select only NOT in
optgroup. AFAIK {{listCssClass}} never worked for optgroup.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Blocker
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[
https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699542#comment-16699542
]
Aleksandr Mashchenko commented on WW-4987:
--
[~mfsalmani678] What exactly is {{templateType}}? You're using it in two
different attributes in {{cssClass}} it would be just css class for select tag
(), in {{listCssClass}} it would be evaluated
against value stack to get css class for options in select only NOT in
optgroup. AFAIK {{listCssClass}} never worked for optgroup.
> Setting Struts2 options Css Class
>
>
> Key: WW-4987
> URL: https://issues.apache.org/jira/browse/WW-4987
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.17
>Reporter: Muhammad Salman
>Priority: Blocker
> Fix For: 2.6, 2.5.19
>
>
> Hi
> I am working on an application that is built on struts 2.5.17. I have
> {{}} tag with and . I am trying to add cssClass
> to under . I am trying to add css class to using
> listCssClass attribute of {{}} but it is not adding class to the
> . Any help would be much appreciated.
> Here is code from my JSP:
> {code:xml}
> cssStyle="width:250px;" title="templateDesc" cssClass="templateType"
> onchange="adjustReportText()" name="templateID" listCssClass="templateType">
> status="stat">
> listValue="templateName" >
>
>
> {code}
> Initially we were working on struts 2.2.3 version and in that version,
> cssClass attribute populates the CSS Class for , but in 2.5.17
> neither cssClass is populated class to nor listCssClass.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4964) Missing javascript in form-validate.ftl
[ https://issues.apache.org/jira/browse/WW-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672136#comment-16672136 ] Aleksandr Mashchenko commented on WW-4964: -- Can we move both js files to head to avoid multiple imports of the same js file. > Missing javascript in form-validate.ftl > --- > > Key: WW-4964 > URL: https://issues.apache.org/jira/browse/WW-4964 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.17 >Reporter: nikos dimitrakas >Priority: Major > Fix For: 2.6 > > > There are two versions of form-validate.ftl, one in xhtml theme and one in > css_xhtml theme. The one in css_xhtml is missing the script tag for utils.js > (and also some special character cleaning). This causes the following error > on the client: > Uncaught ReferenceError: StrutsUtils is not defined > at validation.js:161 > (anonymous) @ validation.js:161 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-4971) s:include tag fails with truncated content in certain circumstances
[ https://issues.apache.org/jira/browse/WW-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-4971. -- Resolution: Fixed > s:include tag fails with truncated content in certain circumstances > --- > > Key: WW-4971 > URL: https://issues.apache.org/jira/browse/WW-4971 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.3.36, 2.5.18 > Environment: Windows 10, Java 7/8 (but issue isn't environment > specific) >Reporter: James Chaplin >Priority: Major > Fix For: 2.6, 2.5.19 > > Attachments: WW4791_Reproducer.war > > > Hello Apache Struts Team. > There is an issue with the Struts include tag (s:include) when processing > includes on a page that isn't using UTF-8 encoding (e.g. ISO-8859-1 or > Windows-1252 page encoding). > In some circumstances the s:include tag results in truncated content from the > child page (i.e. the parent page including the child page via s:include > experiences incomplete rendering of the included content). This happens when > the included page contains certain characters (e.g. 'ç') in a non-UTF8 > encoding (whether directly or from a resource bundle). > There are no warnings produced in the logs (even in debug mode), so the issue > can only be detected visually when things fail. > Changing all the content to UTF-8 is a workaround, but that is not feasible > in all circumstances. Given the preceding and the lack of warnings I'm > initially submitting it as a major priority. > I will attempt to submit a bugfix for consideration shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4969) Need to upgrade application from struts 1 to struts2
[ https://issues.apache.org/jira/browse/WW-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648349#comment-16648349 ] Aleksandr Mashchenko commented on WW-4969: -- Please ask such questions on mail list or on stackoverflow. S1 and S2 are different frameworks. There is no magic steps to migrate. > Need to upgrade application from struts 1 to struts2 > > > Key: WW-4969 > URL: https://issues.apache.org/jira/browse/WW-4969 > Project: Struts 2 > Issue Type: Improvement >Reporter: Mazaharul Haque >Priority: Major > > I have some struts application which used struts 1.3.8. IN a bulnerability > scan we found that we need to upgrade to struts 2.5.17. What is the process > or steps taken to upgrade to struts 2. I tried using > struts2_struts1_plugin.jar but it uses struts_core_1.3.10.jar as dependency > jar. And as long as struts1 core jar is their, scan will fail. Please advise -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WW-4968) combining s:set and s:property where the property retrieved is null has unexpected results
[
https://issues.apache.org/jira/browse/WW-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648345#comment-16648345
]
Aleksandr Mashchenko edited comment on WW-4968 at 10/12/18 7:27 PM:
Read [this|https://stackoverflow.com/q/25551470/1700321].
was (Author: aleksandr-m):
Read [this | https://stackoverflow.com/q/25551470/1700321].
> combining s:set and s:property where the property retrieved is null has
> unexpected results
> --
>
> Key: WW-4968
> URL: https://issues.apache.org/jira/browse/WW-4968
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.14.1
>Reporter: Nate
>Priority: Major
>
> I have the following s:set definition:
> value="buildEnvironmentSearchView.name" scope="request">
> which I further on use as such in a Dojo input:
> data-dojo-props="store:nameIdentificationStore, searchAttr:'name',
> value:'${name}'"
> name="buildEnvironmentSearchView.name"
> id="buildEnvironmentSearchView.name" />
> I needed to escape the value this generated for Javascript so single quotes
> didn't corrupt the dojo-props, so I replaced it with
>
>
>
> This worked if buildEnvironmentSearchView.name is not null, but when it is
> evaluated to be null, instead of name being set to null, it was evaluated to
> the toString value of the top element on my valueStack:
> be.companyname.productname.client.struts2.layout.FieldFormatter@19b82032
> I'm not sure why this happens. In the end, I managed to resolve it by putting
> the s:property directly into the data-dojo-props object, but I don't really
> get why this happened. Is it intended that if you do an s:set with a null
> value, it returns the top value of the stack? This doesn't seem to be
> documented anywhere.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (WW-4969) Need to upgrade application from struts 1 to struts2
[ https://issues.apache.org/jira/browse/WW-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko closed WW-4969. Resolution: Not A Problem > Need to upgrade application from struts 1 to struts2 > > > Key: WW-4969 > URL: https://issues.apache.org/jira/browse/WW-4969 > Project: Struts 2 > Issue Type: Improvement >Reporter: Mazaharul Haque >Priority: Major > > I have some struts application which used struts 1.3.8. IN a bulnerability > scan we found that we need to upgrade to struts 2.5.17. What is the process > or steps taken to upgrade to struts 2. I tried using > struts2_struts1_plugin.jar but it uses struts_core_1.3.10.jar as dependency > jar. And as long as struts1 core jar is their, scan will fail. Please advise -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4968) combining s:set and s:property where the property retrieved is null has unexpected results
[
https://issues.apache.org/jira/browse/WW-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648345#comment-16648345
]
Aleksandr Mashchenko commented on WW-4968:
--
Read [this | https://stackoverflow.com/q/25551470/1700321].
> combining s:set and s:property where the property retrieved is null has
> unexpected results
> --
>
> Key: WW-4968
> URL: https://issues.apache.org/jira/browse/WW-4968
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.14.1
>Reporter: Nate
>Priority: Major
>
> I have the following s:set definition:
> value="buildEnvironmentSearchView.name" scope="request">
> which I further on use as such in a Dojo input:
> data-dojo-props="store:nameIdentificationStore, searchAttr:'name',
> value:'${name}'"
> name="buildEnvironmentSearchView.name"
> id="buildEnvironmentSearchView.name" />
> I needed to escape the value this generated for Javascript so single quotes
> didn't corrupt the dojo-props, so I replaced it with
>
>
>
> This worked if buildEnvironmentSearchView.name is not null, but when it is
> evaluated to be null, instead of name being set to null, it was evaluated to
> the toString value of the top element on my valueStack:
> be.companyname.productname.client.struts2.layout.FieldFormatter@19b82032
> I'm not sure why this happens. In the end, I managed to resolve it by putting
> the s:property directly into the data-dojo-props object, but I don't really
> get why this happened. Is it intended that if you do an s:set with a null
> value, it returns the top value of the stack? This doesn't seem to be
> documented anywhere.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WW-4956) Upgrade to Log4j2 2.11.1
[ https://issues.apache.org/jira/browse/WW-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-4956. -- Resolution: Fixed > Upgrade to Log4j2 2.11.1 > > > Key: WW-4956 > URL: https://issues.apache.org/jira/browse/WW-4956 > Project: Struts 2 > Issue Type: Dependency >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-4956) Upgrade to Log4j2 2.11.1
Aleksandr Mashchenko created WW-4956: Summary: Upgrade to Log4j2 2.11.1 Key: WW-4956 URL: https://issues.apache.org/jira/browse/WW-4956 Project: Struts 2 Issue Type: Dependency Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4929) Fallback i18n Locale
[ https://issues.apache.org/jira/browse/WW-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425888#comment-16425888 ] Aleksandr Mashchenko commented on WW-4929: -- I don't think Struts uses "Accept-language" right now. You can create custom interceptor for that. > Fallback i18n Locale > > > Key: WW-4929 > URL: https://issues.apache.org/jira/browse/WW-4929 > Project: Struts 2 > Issue Type: Improvement > Components: Core Interceptors >Affects Versions: 2.5.14.1 >Reporter: Kai Denzel >Priority: Major > Fix For: 2.6 > > > What i noticed is, when i set the perfered languages in my browser for > example in this order: > fr - francais > de - german > en - english > The framework will set the ActionContext.getLocale() to fr. Then the > framework will look for resources for francais, and if this locale resources > do not exist, the framework will look for the system locale. If the system > locale in this example is en, the german resources will be overlooked. > I mean the HTTP-Header "Accept-language" has an Array of locales. So why not > fallback to the next selected if the first Locale does not exist? > Is it possible, to make the framework ready for fallback? > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WW-4929) Fallback i18n Locale
[ https://issues.apache.org/jira/browse/WW-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko updated WW-4929: - Priority: Major (was: Critical) > Fallback i18n Locale > > > Key: WW-4929 > URL: https://issues.apache.org/jira/browse/WW-4929 > Project: Struts 2 > Issue Type: Improvement > Components: Core Interceptors >Affects Versions: 2.5.14.1 >Reporter: Kai Denzel >Priority: Major > Fix For: 2.6 > > > What i noticed is, when i set the perfered languages in my browser for > example in this order: > fr - francais > de - german > en - english > The framework will set the ActionContext.getLocale() to fr. Then the > framework will look for resources for francais, and if this locale resources > do not exist, the framework will look for the system locale. If the system > locale in this example is en, the german resources will be overlooked. > I mean the HTTP-Header "Accept-language" has an Array of locales. So why not > fallback to the next selected if the first Locale does not exist? > Is it possible, to make the framework ready for fallback? > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-4865) Struts s:checkbox conversion fails to List
[
https://issues.apache.org/jira/browse/WW-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko resolved WW-4865.
--
Resolution: Fixed
> Struts s:checkbox conversion fails to List
> ---
>
> Key: WW-4865
> URL: https://issues.apache.org/jira/browse/WW-4865
> Project: Struts 2
> Issue Type: Bug
> Components: Core, Core Tags
>Affects Versions: 2.5.13
>Reporter: Burton Rhodes
>Priority: Minor
> Fix For: 2.6
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Struts is not converted correctly to List when only one
> checkbox element is present and checkbox is not checked.
> [Given]
> 1) Mapping s:checkbox to a List
> 2) there is only one checkbox in the list
> 3) the checkbox is not checked when the form is submitted.
> [Result]
> Input invalid
> The issue is caused by the checkbox tag using the "submit unchecked values"
> design pattern. As a result, the code base tries to convert the value of the
> single unchecked element to false (rather than not setting any value of the
> List).
> Fix: Allow the developer to choose if the "submit unchecked values" is to be
> implemented. Add a new parameter to the s:checkbox tag ("requiredValue").
> Default of requiredValue=true for backwards compatibility. When set to
> false, no hidden input values will be displayed in the view. This
> flexibility might be needed in other scenarios as well.
> Pull Request: https://github.com/apache/struts/pull/169
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (WW-4928) Setting struts.devMode from system property not working as described
[
https://issues.apache.org/jira/browse/WW-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko reassigned WW-4928:
Assignee: Aleksandr Mashchenko
> Setting struts.devMode from system property not working as described
>
>
> Key: WW-4928
> URL: https://issues.apache.org/jira/browse/WW-4928
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.14.1
> Environment: **Windows, Linux, Solaris
>Reporter: Peter J Ford
>Assignee: Aleksandr Mashchenko
>Priority: Minor
> Labels: documentation, easyfix
> Fix For: 2.6
>
>
> According to
> [http://struts.apache.org/core-developers/constant-configuration.html] the
> struts.devMode setting can be read from environment strings or system
> properties. This works correctly when setting from an environment string -
> for example:
> {{}}
> However it does not work for system properties, such as setting
> "-DstrutsDevMode=true" as a system property and this in struts.xml:
> {{}}
> Having dug through the source I found that this is to do with the way the
> value substitutor is configured, and that using ":-" instead of ":" as the
> separator string when using system properties will work:
> {{}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (WW-685) Generic error message - Type Conversion Error Handling
[ https://issues.apache.org/jira/browse/WW-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko updated WW-685: Fix Version/s: (was: 3.0) 2.6 > Generic error message - Type Conversion Error Handling > -- > > Key: WW-685 > URL: https://issues.apache.org/jira/browse/WW-685 > Project: Struts 2 > Issue Type: Improvement >Reporter: Ricardo Lecheta >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > To change the default message "invalid field value for field "xxx"", > you can put this line in the Action.properties > > invalid.fieldvalue.[propertyName] > But will be useful if there is a way to do a generic custom message to any > type? For example a custom message for Dates, double, boolean, etc: > > invalid.fieldvalue.For_All_Dates=This is not a valid date. > I don´t know how to implement it, but could be like this: > > invalid.fieldvalue.java.lang.Integer=This is not a valid Number. > > invalid.fieldvalue.java.util.Date=This is not a valid Date. > - > I tried the following examples, but them doesn´t work: > invalid.fieldvalue.*=Invalid Date. > and > invalid.fieldvalue.[*]=Invalid Date. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (WW-685) Generic error message - Type Conversion Error Handling
[ https://issues.apache.org/jira/browse/WW-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko reassigned WW-685: --- Assignee: Aleksandr Mashchenko (was: Rainer Hermanns) > Generic error message - Type Conversion Error Handling > -- > > Key: WW-685 > URL: https://issues.apache.org/jira/browse/WW-685 > Project: Struts 2 > Issue Type: Improvement >Reporter: Ricardo Lecheta >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > To change the default message "invalid field value for field "xxx"", > you can put this line in the Action.properties > > invalid.fieldvalue.[propertyName] > But will be useful if there is a way to do a generic custom message to any > type? For example a custom message for Dates, double, boolean, etc: > > invalid.fieldvalue.For_All_Dates=This is not a valid date. > I don´t know how to implement it, but could be like this: > > invalid.fieldvalue.java.lang.Integer=This is not a valid Number. > > invalid.fieldvalue.java.util.Date=This is not a valid Date. > - > I tried the following examples, but them doesn´t work: > invalid.fieldvalue.*=Invalid Date. > and > invalid.fieldvalue.[*]=Invalid Date. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4921) NPE in I18nInterceptor$SessionLocaleHandler.read
[
https://issues.apache.org/jira/browse/WW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371900#comment-16371900
]
Aleksandr Mashchenko commented on WW-4921:
--
With the {{request.getSession(true);}} you're creating mock session which is
not set in the invocation context. Remove {{request.getSession(true);}} or set
new hashmap into invocation context.
> NPE in I18nInterceptor$SessionLocaleHandler.read
>
>
> Key: WW-4921
> URL: https://issues.apache.org/jira/browse/WW-4921
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
>Reporter: Michael Hintenaus
>Priority: Major
> Labels: test
> Fix For: 2.5.16
>
>
> Calling
> {code:java}
> getActionProxy("/index.action").getInvocation().invoke(){code}
> in a TestCase which extends from StrutsJUnit4TestCase will lead to a
> NullPointerException.
> Overriding getActionProxy like this will help:
> {code:java}
> @Override
> protected ActionProxy getActionProxy(final String uri) {
> final ActionProxy proxy = super.getActionProxy(uri);
> final ActionContext context =
> proxy.getInvocation().getInvocationContext();
> if (context.getSession() == null) {
> context.setSession(new SessionMap<>(request));
> }
> return proxy;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4921) NPE in I18nInterceptor$SessionLocaleHandler.read
[
https://issues.apache.org/jira/browse/WW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370386#comment-16370386
]
Aleksandr Mashchenko commented on WW-4921:
--
[~Michael Hintenaus]
Please add which Struts version you are using along with the whole error
stacktrace and your test code.
Simple test is working fine for me.
> NPE in I18nInterceptor$SessionLocaleHandler.read
>
>
> Key: WW-4921
> URL: https://issues.apache.org/jira/browse/WW-4921
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
>Reporter: Michael Hintenaus
>Priority: Major
> Labels: test
> Fix For: 2.5.16
>
>
> Calling
> {code:java}
> getActionProxy("/index.action").getInvocation().invoke(){code}
> in a TestCase which extends from StrutsJUnit4TestCase will lead to a
> NullPointerException.
> Overriding getActionProxy like this will help:
> {code:java}
> @Override
> protected ActionProxy getActionProxy(final String uri) {
> final ActionProxy proxy = super.getActionProxy(uri);
> final ActionContext context =
> proxy.getInvocation().getInvocationContext();
> if (context.getSession() == null) {
> context.setSession(new SessionMap<>(request));
> }
> return proxy;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4921) NPE in I18nInterceptor$SessionLocaleHandler.read
[
https://issues.apache.org/jira/browse/WW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369447#comment-16369447
]
Aleksandr Mashchenko commented on WW-4921:
--
[~Michael Hintenaus]
Can you show more code of your test.
Any reason why do you use {{invoke()}}? There is {{execute()}} in
{{ActionProxy}} and {{executeAction}} in test case.
> NPE in I18nInterceptor$SessionLocaleHandler.read
>
>
> Key: WW-4921
> URL: https://issues.apache.org/jira/browse/WW-4921
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
>Reporter: Michael Hintenaus
>Priority: Major
> Labels: test
> Fix For: 2.5.16
>
>
> Calling
> {code:java}
> getActionProxy("/index.action").getInvocation().invoke(){code}
> in a TestCase which extends from StrutsJUnit4TestCase will lead to a
> NullPointerException.
> Overriding getActionProxy like this will help:
> {code:java}
> @Override
> protected ActionProxy getActionProxy(final String uri) {
> final ActionProxy proxy = super.getActionProxy(uri);
> final ActionContext context =
> proxy.getInvocation().getInvocationContext();
> if (context.getSession() == null) {
> context.setSession(new SessionMap<>(request));
> }
> return proxy;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366155#comment-16366155
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:28 PM:
---
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties files _message.properties_ and _message_ru.properties._
Where _ru_ has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
was (Author: aleksandr-m):
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru_ has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366155#comment-16366155
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:28 PM:
---
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru_ has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
was (Author: aleksandr-m):
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru_ has malformed encoding. Requesting ru locale you get value from
__message.properties__ file w/o any warning in logs, because java silently
fallbacks to default property.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366155#comment-16366155
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:28 PM:
---
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru_ has malformed encoding. Requesting ru locale you get value from
__message.properties__ file w/o any warning in logs, because java silently
fallbacks to default property.
was (Author: aleksandr-m):
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366155#comment-16366155
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:27 PM:
---
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{code:java}
WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value
expression 'some' was evaluated and did not match a property. The literal value
'some' will be used.{code}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
was (Author: aleksandr-m):
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{{WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value expression
'some' was evaluated and did not match a property. The literal value 'some'
will be used.}}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366155#comment-16366155
]
Aleksandr Mashchenko commented on WW-4919:
--
Case 1:
You have 1 properties file _message_ru.properties_ with malformed encoding.
Requesting ru locale you get
{{WARN org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (com.opensymphony.xwork2.ActionSupport) could not locate the
message resource with key 'some'
WARN org.apache.struts2.util.TextProviderHelper - The default value expression
'some' was evaluated and did not match a property. The literal value 'some'
will be used.}}
This warning can be improved but at least it is something in the logs.
Case 2:
You have 2 properties file _message.properties_ and _message_ru.properties._
Where _ru has malformed encoding. Requesting ru locale you get value from
_message.properties_ file w/o any warning in logs, because java silently
fallbacks to default property.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366105#comment-16366105
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:01 PM:
---
Just found out there is a catch. {{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
And it is _caused by_ not an original exception, that is why it is ignored in
Struts.
was (Author: aleksandr-m):
Just found out there is a catch. {{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
And it is _caused by_ not a original exception, that is why it is ignored in
Struts.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366105#comment-16366105
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 7:01 PM:
---
Just found out there is a catch. {{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
And it is _caused by_ not a original exception, that is why it is ignored in
Struts.
was (Author: aleksandr-m):
Just found out there is a catch. {{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
And it id caused by not a original exception, that is why it is ignored in
Struts.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366105#comment-16366105
]
Aleksandr Mashchenko edited comment on WW-4919 at 2/15/18 6:57 PM:
---
Just found out there is a catch. {{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
And it id caused by not a original exception, that is why it is ignored in
Struts.
was (Author: aleksandr-m):
Just found out there is a catch. \{{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[
https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366105#comment-16366105
]
Aleksandr Mashchenko commented on WW-4919:
--
Just found out there is a catch. \{{java.lang.IllegalArgumentException:
Malformed \u encoding}} will be thrown only if there is no fallback /
default properties file w/o malformed encoding.
> The load of properties file doesnt show the Exception obtained if exist a
> problem with Unicode character
>
>
> Key: WW-4919
> URL: https://issues.apache.org/jira/browse/WW-4919
> Project: Struts 2
> Issue Type: Improvement
> Environment: When loading Struts2 in the Web Application
>Reporter: Manuel Villalobos
>Priority: Minor
> Fix For: 2.6
>
>
> When loading a properties file for use with the Text tag or with getText
> inside the Action, if a Unicode character has a problem the total content of
> the file is not loaded and they are not available for use. The problem is
> that the error found in the load is nowhere seen.
> Please help her in situations like that show up in the load the error you get.
> When trying to load manually the properties Java file throws the message
> "java.lang.IllegalArgumentException: Malformed \ u encoding"
> Please help you so that when there are problems loading the properties file,
> messages will be generated in the log
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[ https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366070#comment-16366070 ] Aleksandr Mashchenko commented on WW-4919: -- We had the same issue couple month ago, it is a java thing. [~wolfiepop] Show your code. Resource bundle is not the same thing as properties. > The load of properties file doesnt show the Exception obtained if exist a > problem with Unicode character > > > Key: WW-4919 > URL: https://issues.apache.org/jira/browse/WW-4919 > Project: Struts 2 > Issue Type: Improvement > Environment: When loading Struts2 in the Web Application >Reporter: Manuel Villalobos >Priority: Minor > Fix For: 2.6 > > > When loading a properties file for use with the Text tag or with getText > inside the Action, if a Unicode character has a problem the total content of > the file is not loaded and they are not available for use. The problem is > that the error found in the load is nowhere seen. > Please help her in situations like that show up in the load the error you get. > When trying to load manually the properties Java file throws the message > "java.lang.IllegalArgumentException: Malformed \ u encoding" > Please help you so that when there are problems loading the properties file, > messages will be generated in the log -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-4916) Cannot find com.opensymphony.xwork2.util.LocalizedTextUtil
[ https://issues.apache.org/jira/browse/WW-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-4916. -- Resolution: Invalid > Cannot find com.opensymphony.xwork2.util.LocalizedTextUtil > -- > > Key: WW-4916 > URL: https://issues.apache.org/jira/browse/WW-4916 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.14.1 >Reporter: nick >Priority: Blocker > Labels: build > Fix For: 2.5.13 > > > When removing xwork-core.jar in Struts-2.5.14.1, the json-plugin-2.5.14 does > not work. It cannot find com.opensymphony.xwork2.util.LocalizedTextUtil. > Refer to WW-4911 for background information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4919) The load of properties file doesnt show the Exception obtained if exist a problem with Unicode character
[ https://issues.apache.org/jira/browse/WW-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365461#comment-16365461 ] Aleksandr Mashchenko commented on WW-4919: -- AFAIR java silently ignores errors when loading resource bundles. _> When trying to load manually the properties Java file throws the message "java.lang.IllegalArgumentException: Malformed \ u encoding"_ How do you load it manually? > The load of properties file doesnt show the Exception obtained if exist a > problem with Unicode character > > > Key: WW-4919 > URL: https://issues.apache.org/jira/browse/WW-4919 > Project: Struts 2 > Issue Type: Improvement > Environment: When loading Struts2 in the Web Application >Reporter: Manuel Villalobos >Priority: Minor > > When loading a properties file for use with the Text tag or with getText > inside the Action, if a Unicode character has a problem the total content of > the file is not loaded and they are not available for use. The problem is > that the error found in the load is nowhere seen. > Please help her in situations like that show up in the load the error you get. > When trying to load manually the properties Java file throws the message > "java.lang.IllegalArgumentException: Malformed \ u encoding" > Please help you so that when there are problems loading the properties file, > messages will be generated in the log -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-4915) Replace deprecated commons-lang3 classes
Aleksandr Mashchenko created WW-4915: Summary: Replace deprecated commons-lang3 classes Key: WW-4915 URL: https://issues.apache.org/jira/browse/WW-4915 Project: Struts 2 Issue Type: Improvement Affects Versions: 2.5.14.1 Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko The Apache Commons Community has recently set up the Commons Text component as a home for algorithms working on strings. For this reason most of the string focused functionality in Commons Lang has been deprecated and moved to Commons Text. This includes: * All classes in the org.apache.commons.lang3.text and the org.apache.commons.lang3.text.translate packages * org.apache.commons.lang3.StringEscapeUtils * org.apache.commons.lang3.RandomStringUtils * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance and org.apache.commons.lang3.StringUtils.getLevenshteinDistance For more information see the Commons Text website: http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WW-4914) Update Log4j2 to 2.10.0
[ https://issues.apache.org/jira/browse/WW-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Mashchenko resolved WW-4914. -- Resolution: Fixed > Update Log4j2 to 2.10.0 > --- > > Key: WW-4914 > URL: https://issues.apache.org/jira/browse/WW-4914 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Minor > Fix For: 2.5.15 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WW-4914) Update Log4j2 to 2.10.0
Aleksandr Mashchenko created WW-4914: Summary: Update Log4j2 to 2.10.0 Key: WW-4914 URL: https://issues.apache.org/jira/browse/WW-4914 Project: Struts 2 Issue Type: Improvement Affects Versions: 2.5.14.1 Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko Fix For: 2.5.15 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4895) s:select tags performance issue after upgrading to 2.5.1.3
[
https://issues.apache.org/jira/browse/WW-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263321#comment-16263321
]
Aleksandr Mashchenko commented on WW-4895:
--
Create select with {{c:forEach}} not just div with text.
Fetch all entities in the action method prior displaying it in JSP and make
sure that {{value}} and {{label}} is there (iterate list in the java code and
print it in console).
Which browser you are using? Firefox recently had some issues displaying
selects.
> s:select tags performance issue after upgrading to 2.5.1.3
> --
>
> Key: WW-4895
> URL: https://issues.apache.org/jira/browse/WW-4895
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 2.5.13
> Environment: IBM Websphere 8.5 , apache 2.x
>Reporter: Harsh Choudhary
>Priority: Critical
> Labels: performance
> Fix For: 2.5.x
>
>
> We recently upgraded from Struts 2.1(don't ask) to Struts 2.5.13 , while the
> upgrade process was smooth, we are facing some performance issue while JSP is
> rendering at runtime. This JSP used to load in less then 2 secs before and
> now it's taking around 40 secs to load. It's a very simple JSP with some text
> fields and a few select fields. I am just posting a simple select that is
> taking around 20 secs, I cannot post the whole code because of obvious
> reasons. The time difference between the two-time statements below is around
> 20 secs.
> I have tried to remove styles, javascript function but still it's taking a
> long time. Any suggestions in this regard will be helpful. This is happening
> most of the select boxes.
> {code:html}
> System.out.println("logging started");
> java.util.Date date49 = new java.util.Date();
> %>
> The time is now <%= date49 %>
> cssStyle="width:100%; height:100%" name="showDoc" id="showDoc"
> multiple="true" size="5"
> headerKey="-1"
> list="doclist"
> listKey="id"
>
> listValue="Description"
>
> onchange="disableErrormsg('VarLibAssetErrorDiv');"
> />
>
>
> <%
> System.out.println("logging started");
> java.util.Date date5 = new java.util.Date();
> %>
> The time is now <%= date5 %>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WW-4869) Struts2.5.13 can't run in java9 win10
[
https://issues.apache.org/jira/browse/WW-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236385#comment-16236385
]
Aleksandr Mashchenko commented on WW-4869:
--
[~lukaszlenart] It would be great to fix this in {{2.5.14}}. More and more
users start to use jdk9 and S2 fails because of that thing. I think we can do
whatever is simpler for now: remove this stuff or merge [this
PR|https://github.com/apache/struts/pull/172]. We can refactor it in later
version.
BTW we should start using squash on merging PR-s, ~10 commits to fix one thing
is ridiculous.
> Struts2.5.13 can't run in java9 win10
> -
>
> Key: WW-4869
> URL: https://issues.apache.org/jira/browse/WW-4869
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
>Affects Versions: 2.5.13
> Environment: windows 10-jdk9-maven3.5
>Reporter: Smith Cruise
>Assignee: Lukasz Lenart
>Priority: Major
> Labels: java9
> Fix For: 2.6
>
> Attachments: screenshot-1.png
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> I followed the official
> tutorial,http://struts.apache.org/getting-started/how-to-create-a-struts2-web-application.html.
> But always throw exception when i run webapp.i tried many times but I really
> don't know how to reslove it.
> Here is Exception
> {noformat}
> java.nio.file.InvalidPathException: Illegal char <:> at index 3:
> jar:file:\D:\.m2\repository\org\apache\struts\struts2-core\2.5.13\struts2-core-2.5.13.jar
> at
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at
> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
> at java.base/java.io.File.toPath(File.java:2300)
> at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:951)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:216)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:148)
> at java.base/java.util.jar.JarFile.(JarFile.java:324)
> at java.base/java.util.jar.JarFile.(JarFile.java:295)
> at java.base/java.util.jar.JarFile.(JarFile.java:234)
> at
> com.opensymphony.xwork2.util.fs.JarEntryRevision.needsReloading(JarEntryRevision.java:73)
> at
> com.opensymphony.xwork2.util.fs.DefaultFileManager.fileNeedsReloading(DefaultFileManager.java:62)
> at
> com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.needsReload(XmlConfigurationProvider.java:425)
> at
> org.apache.struts2.config.StrutsXmlConfigurationProvider.needsReload(StrutsXmlConfigurationProvider.java:163)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.needReloadContainerProviders(ConfigurationManager.java:208)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.conditionalReload(ConfigurationManager.java:174)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:69)
> at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960)
> at
> org.apache.struts2.dispatcher.ExecuteOperations.executeStaticResourceRequest(ExecuteOperations.java:59)
> at
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:130)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1476)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:370)
> at
> org.eclipse.jetty
[jira] [Commented] (WW-4876) NullPointerException in com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile
[
https://issues.apache.org/jira/browse/WW-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212928#comment-16212928
]
Aleksandr Mashchenko commented on WW-4876:
--
What is null exactly?
> NullPointerException in
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile
> ---
>
> Key: WW-4876
> URL: https://issues.apache.org/jira/browse/WW-4876
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.3.32
>Reporter: Zac Zhang
>
> hi Lukasz Lenart, my project sometimes casue such error, i don't know why,
> please help , thanks
> {noformat}
> java.lang.NullPointerException
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile(AnnotationActionValidatorManager.java:390)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildClassValidatorConfigs(AnnotationActionValidatorManager.java:282)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:374)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.getValidators(AnnotationActionValidatorManager.java:98)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:140)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:132)
> at
> com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:127)
> at
> com.opensymphony.xwork2.validator.ValidationInterceptor.doBeforeInvocation(ValidationInterceptor.java:222)
> at
> com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:263)
> at
> org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:76)
> at
> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:229)
> at
> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:229)
> at
> com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> org.apache.struts2.interceptor.MultiselectInterceptor.intercept(MultiselectInterceptor.java:73)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> org.apache.struts2.interceptor.DateTextFieldInterceptor.intercept(DateTextFieldInterceptor.java:125)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> org.apache.struts2.interceptor.CheckboxInterceptor.intercept(CheckboxInterceptor.java:91)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> org.apache.struts2.interceptor.FileUploadInterceptor.intercept(FileUploadInterceptor.java:253)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245)
> at
> com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor.intercept(ModelDrivenInterceptor.java:100)
> at
> com.opensymphony.xwork2.Defau
[jira] [Commented] (WW-4864) Upgrade to the latest Jetty plugin in all examples
[ https://issues.apache.org/jira/browse/WW-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212921#comment-16212921 ] Aleksandr Mashchenko commented on WW-4864: -- Just found out that starting from 9.3 jetty needs java 8 to run - https://www.eclipse.org/jetty/documentation/9.4.7.v20170914/what-jetty-version.html. > Upgrade to the latest Jetty plugin in all examples > -- > > Key: WW-4864 > URL: https://issues.apache.org/jira/browse/WW-4864 > Project: Struts 2 > Issue Type: Improvement > Components: Example Applications, Maven Archetypes >Affects Versions: 2.5.13 >Reporter: Lukasz Lenart >Priority: Trivial > Fix For: 2.5.14 > > > As mentioned > [here|https://issues.apache.org/jira/browse/WW-4851?focusedCommentId=16187531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16187531] > the Jetty plugin used in example apps is a bit outdated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WW-4875) Java configuration
Aleksandr Mashchenko created WW-4875: Summary: Java configuration Key: WW-4875 URL: https://issues.apache.org/jira/browse/WW-4875 Project: Struts 2 Issue Type: Improvement Affects Versions: 2.5.13 Reporter: Aleksandr Mashchenko Assignee: Aleksandr Mashchenko Fix For: 2.5.x Some people are allergic to XML and even with convention plugin currently there is no way to define properties w/o struts.xml or properties file. It would be great to add the ability to configure app via java configuration. We can start with adding support for constant, bean and unknown-handler-stack and see how it goes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4864) Upgrade to the latest Jetty plugin in all examples
[
https://issues.apache.org/jira/browse/WW-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211264#comment-16211264
]
Aleksandr Mashchenko commented on WW-4864:
--
{quote} the last release this plugin had was in 2013 and there's no plugin for
tomcat 8 version yet for example.{quote}
Exactly. If we add it then we should make sure it is working, which is doubtful
especially with jdk9. So no.
> Upgrade to the latest Jetty plugin in all examples
> --
>
> Key: WW-4864
> URL: https://issues.apache.org/jira/browse/WW-4864
> Project: Struts 2
> Issue Type: Improvement
> Components: Example Applications, Maven Archetypes
>Affects Versions: 2.5.13
>Reporter: Lukasz Lenart
>Priority: Trivial
> Fix For: 2.5.14
>
>
> As mentioned
> [here|https://issues.apache.org/jira/browse/WW-4851?focusedCommentId=16187531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16187531]
> the Jetty plugin used in example apps is a bit outdated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WW-4873) NotSerializableException - org.apache.struts2.dispatcher.StrutsRequestWrapper
[
https://issues.apache.org/jira/browse/WW-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211252#comment-16211252
]
Aleksandr Mashchenko commented on WW-4873:
--
{{HttpServletRequest}} in {{ActionContext}}? Can you show where?
> NotSerializableException - org.apache.struts2.dispatcher.StrutsRequestWrapper
> -
>
> Key: WW-4873
> URL: https://issues.apache.org/jira/browse/WW-4873
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 2.5.13
>Reporter: Michael Hum
> Fix For: 2.5.14
>
>
> We are attempting to test session replication on our websphere servers but
> run into the given error when websphere tries to serialize the session.
> {code}
> [10/18/17 10:33:38:094 EDT] 0335 WASSessionE MTMBuffWrapper getBytes
> write object exception. e= java.io.NotSerializableException:
> org.apache.struts2.dispatcher.StrutsRequestWrapper
> {code}
> It appears the ActionInvocation stores the ActionContext which stores the
> offending property: com.opensymphony.xwork2.dispatcher.HttpServletRequest -->
> StrutsRequestWrapper
> After a little digging we narrowed it down to our use of the
> TokenSessionStoreInterceptor which stores the value in the session and uses
> it to redirect the failed request to the original one. Is this
> intended/expected? Or is there no requirement that the contents in the
> session be serializable - in which case we would have to look to our own
> solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WW-4869) Struts2.5.13 can't run in java9 win10
[
https://issues.apache.org/jira/browse/WW-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200819#comment-16200819
]
Aleksandr Mashchenko commented on WW-4869:
--
[~sdutry] Great. I can confirm that it is working for me on ubuntu.
> Struts2.5.13 can't run in java9 win10
> -
>
> Key: WW-4869
> URL: https://issues.apache.org/jira/browse/WW-4869
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
>Affects Versions: 2.5.13
> Environment: windows 10-jdk9-maven3.5
>Reporter: Smith Cruise
>Assignee: Lukasz Lenart
> Labels: java9
> Fix For: 2.6
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> I followed the official
> tutorial,http://struts.apache.org/getting-started/how-to-create-a-struts2-web-application.html.
> But always throw exception when i run webapp.i tried many times but I really
> don't know how to reslove it.
> Here is Exception
> {noformat}
> java.nio.file.InvalidPathException: Illegal char <:> at index 3:
> jar:file:\D:\.m2\repository\org\apache\struts\struts2-core\2.5.13\struts2-core-2.5.13.jar
> at
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at
> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
> at java.base/java.io.File.toPath(File.java:2300)
> at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:951)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:216)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:148)
> at java.base/java.util.jar.JarFile.(JarFile.java:324)
> at java.base/java.util.jar.JarFile.(JarFile.java:295)
> at java.base/java.util.jar.JarFile.(JarFile.java:234)
> at
> com.opensymphony.xwork2.util.fs.JarEntryRevision.needsReloading(JarEntryRevision.java:73)
> at
> com.opensymphony.xwork2.util.fs.DefaultFileManager.fileNeedsReloading(DefaultFileManager.java:62)
> at
> com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.needsReload(XmlConfigurationProvider.java:425)
> at
> org.apache.struts2.config.StrutsXmlConfigurationProvider.needsReload(StrutsXmlConfigurationProvider.java:163)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.needReloadContainerProviders(ConfigurationManager.java:208)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.conditionalReload(ConfigurationManager.java:174)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:69)
> at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960)
> at
> org.apache.struts2.dispatcher.ExecuteOperations.executeStaticResourceRequest(ExecuteOperations.java:59)
> at
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:130)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1476)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:370)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)
> at
> org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1033)
> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)
> at org.eclip
[jira] [Commented] (WW-4868) createInstance method signature change of TextProviderFactory from merged xwork-core code inside struts2-core-2.5.13.jar which was present with xwork-core jar
[
https://issues.apache.org/jira/browse/WW-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200698#comment-16200698
]
Aleksandr Mashchenko commented on WW-4868:
--
[~anbera] Stop reopening this issue. That kind of questions belong to user
mailing list - http://struts.apache.org/mail.html.
> createInstance method signature change of TextProviderFactory from merged
> xwork-core code inside struts2-core-2.5.13.jar which was present with
> xwork-core jar
>
>
> Key: WW-4868
> URL: https://issues.apache.org/jira/browse/WW-4868
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.12, 2.5.13
>Reporter: Ananga Mohan Bera
>Assignee: Lukasz Lenart
> Fix For: 2.5.14
>
> Attachments: s1.png, s2.png, s3.png, s4.png
>
>
> xwork-core-2.3.32 had these createInstance methods.
> {code:java}
> public TextProvider createInstance(Class clazz, LocaleProvider provider) {
> TextProvider instance = getTextProvider(clazz, provider);
> if (instance instanceof ResourceBundleTextProvider) {
> ((ResourceBundleTextProvider)instance).setClazz(clazz);
> ((ResourceBundleTextProvider)instance).setLocaleProvider(provider);
> }
> return instance;
> }
> public TextProvider createInstance(ResourceBundle bundle, LocaleProvider
> provider) {
> TextProvider instance = getTextProvider(bundle, provider);
> if (instance instanceof ResourceBundleTextProvider) {
> ((ResourceBundleTextProvider)instance).setBundle(bundle);
> ((ResourceBundleTextProvider)instance).setLocaleProvider(provider);
> }
> return instance;
> }
> {code}
> struts2-core-2.5.13.jar has merged the xwork-core code and there only these
> methods are available:
> {code:java}
> public abstract TextProvider createInstance(Class paramClass);
> public abstract TextProvider createInstance(ResourceBundle
> paramResourceBundle);
> {code}
> As We have called the createInstance method from many places of Our
> Application, So migration to struts-2.5.13 is creating a problem. We are
> having code like:
> {code:java}
> private final transient TextProvider textProvider = new
> TextProviderFactory().createInstance(getClass(), this);
> {code}
> method signature should not be changed which has huge effect rather there
> should be overloaded method with merged xwork-core code inside
> struts2-core-2.5.13.jar.
> We are getting such error:
> {noformat}
> 2017-10-06|16:53:23,965|ERROR||[ACTIVE] ExecuteThread: '0' for queue:
> 'weblogic.kernel.Default
> (self-tuning)'|com.tcs.bancs.filter.BancsServletFilter:210|:G:dl3xbKkVBfwQOly9zGyiU1g_MDVUFEoaUV5nTc3nKJP-btoWLMoK!183988368!1507288983829:0:0:0:0:0:0:0:1:
> |Validation exception |
> javax.servlet.ServletException: java.lang.InstantiationError:
> com.opensymphony.xwork2.TextProviderFactory
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:387)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.onAddToMapException(ServletStubImpl.java:483)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:372)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:243)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.RequestDispatcherImpl.invokeServlet(RequestDispatcherImpl.java:587)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.RequestDispatcherImpl.include(RequestDispatcherImpl.java:481)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> org.springframework.security.web.firewall.RequestWrapper$FirewalledRequestAwareRequestDispatcher.include(RequestWrapper.java:136)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> com.tcs.bfsarch.security.action.AuthSuccessHandler.onAuthenticationSuccess(AuthSuccessHandler.java:211)
> ~[coreweb.jar:?]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.successfulAuthentication(AbstractAuthenticationProcessingFilter.java:331)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.successfulAuthentication(AbstractAuthenticationProcessingFilter.java:298)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:235)
> ~[spring-security-web-3.
[jira] [Resolved] (WW-4868) createInstance method signature change of TextProviderFactory from merged xwork-core code inside struts2-core-2.5.13.jar which was present with xwork-core jar
[
https://issues.apache.org/jira/browse/WW-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Mashchenko resolved WW-4868.
--
Resolution: Not A Problem
> createInstance method signature change of TextProviderFactory from merged
> xwork-core code inside struts2-core-2.5.13.jar which was present with
> xwork-core jar
>
>
> Key: WW-4868
> URL: https://issues.apache.org/jira/browse/WW-4868
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.12, 2.5.13
>Reporter: Ananga Mohan Bera
>Assignee: Lukasz Lenart
> Fix For: 2.5.14
>
> Attachments: s1.png, s2.png, s3.png, s4.png
>
>
> xwork-core-2.3.32 had these createInstance methods.
> {code:java}
> public TextProvider createInstance(Class clazz, LocaleProvider provider) {
> TextProvider instance = getTextProvider(clazz, provider);
> if (instance instanceof ResourceBundleTextProvider) {
> ((ResourceBundleTextProvider)instance).setClazz(clazz);
> ((ResourceBundleTextProvider)instance).setLocaleProvider(provider);
> }
> return instance;
> }
> public TextProvider createInstance(ResourceBundle bundle, LocaleProvider
> provider) {
> TextProvider instance = getTextProvider(bundle, provider);
> if (instance instanceof ResourceBundleTextProvider) {
> ((ResourceBundleTextProvider)instance).setBundle(bundle);
> ((ResourceBundleTextProvider)instance).setLocaleProvider(provider);
> }
> return instance;
> }
> {code}
> struts2-core-2.5.13.jar has merged the xwork-core code and there only these
> methods are available:
> {code:java}
> public abstract TextProvider createInstance(Class paramClass);
> public abstract TextProvider createInstance(ResourceBundle
> paramResourceBundle);
> {code}
> As We have called the createInstance method from many places of Our
> Application, So migration to struts-2.5.13 is creating a problem. We are
> having code like:
> {code:java}
> private final transient TextProvider textProvider = new
> TextProviderFactory().createInstance(getClass(), this);
> {code}
> method signature should not be changed which has huge effect rather there
> should be overloaded method with merged xwork-core code inside
> struts2-core-2.5.13.jar.
> We are getting such error:
> {noformat}
> 2017-10-06|16:53:23,965|ERROR||[ACTIVE] ExecuteThread: '0' for queue:
> 'weblogic.kernel.Default
> (self-tuning)'|com.tcs.bancs.filter.BancsServletFilter:210|:G:dl3xbKkVBfwQOly9zGyiU1g_MDVUFEoaUV5nTc3nKJP-btoWLMoK!183988368!1507288983829:0:0:0:0:0:0:0:1:
> |Validation exception |
> javax.servlet.ServletException: java.lang.InstantiationError:
> com.opensymphony.xwork2.TextProviderFactory
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:387)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.onAddToMapException(ServletStubImpl.java:483)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:372)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:243)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.RequestDispatcherImpl.invokeServlet(RequestDispatcherImpl.java:587)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> weblogic.servlet.internal.RequestDispatcherImpl.include(RequestDispatcherImpl.java:481)
> ~[weblogic.server.merged.jar:12.1.3.0.0]
> at
> org.springframework.security.web.firewall.RequestWrapper$FirewalledRequestAwareRequestDispatcher.include(RequestWrapper.java:136)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> com.tcs.bfsarch.security.action.AuthSuccessHandler.onAuthenticationSuccess(AuthSuccessHandler.java:211)
> ~[coreweb.jar:?]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.successfulAuthentication(AbstractAuthenticationProcessingFilter.java:331)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.successfulAuthentication(AbstractAuthenticationProcessingFilter.java:298)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:235)
> ~[spring-security-web-3.2.3.RELEASE.jar:3.2.3.RELEASE]
> at
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
>
[jira] [Commented] (WW-4869) Struts2.5.13 can't run in java9 win10
[
https://issues.apache.org/jira/browse/WW-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200690#comment-16200690
]
Aleksandr Mashchenko commented on WW-4869:
--
[~d87904488] > so I didn't know which jetty I used,maven do itself automatic.
Take a look into the pom. Try to upgrade to latest.
[~yasser.zamani] > do you get same result in
how-to-create-a-struts2-web-application tutorial.
What is the difference? Struts is Struts.
> Struts2.5.13 can't run in java9 win10
> -
>
> Key: WW-4869
> URL: https://issues.apache.org/jira/browse/WW-4869
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
>Affects Versions: 2.5.13
> Environment: windows 10-jdk9-maven3.5
>Reporter: Smith Cruise
>Assignee: Lukasz Lenart
> Labels: java9
> Fix For: 2.6
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> I followed the official
> tutorial,http://struts.apache.org/getting-started/how-to-create-a-struts2-web-application.html.
> But always throw exception when i run webapp.i tried many times but I really
> don't know how to reslove it.
> Here is Exception
> {noformat}
> java.nio.file.InvalidPathException: Illegal char <:> at index 3:
> jar:file:\D:\.m2\repository\org\apache\struts\struts2-core\2.5.13\struts2-core-2.5.13.jar
> at
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at
> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
> at java.base/java.io.File.toPath(File.java:2300)
> at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:951)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:216)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:148)
> at java.base/java.util.jar.JarFile.(JarFile.java:324)
> at java.base/java.util.jar.JarFile.(JarFile.java:295)
> at java.base/java.util.jar.JarFile.(JarFile.java:234)
> at
> com.opensymphony.xwork2.util.fs.JarEntryRevision.needsReloading(JarEntryRevision.java:73)
> at
> com.opensymphony.xwork2.util.fs.DefaultFileManager.fileNeedsReloading(DefaultFileManager.java:62)
> at
> com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.needsReload(XmlConfigurationProvider.java:425)
> at
> org.apache.struts2.config.StrutsXmlConfigurationProvider.needsReload(StrutsXmlConfigurationProvider.java:163)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.needReloadContainerProviders(ConfigurationManager.java:208)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.conditionalReload(ConfigurationManager.java:174)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:69)
> at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960)
> at
> org.apache.struts2.dispatcher.ExecuteOperations.executeStaticResourceRequest(ExecuteOperations.java:59)
> at
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:130)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1476)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:370)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)
> at
> org
[jira] [Commented] (WW-4869) Struts2.5.13 can't run in java9 win10
[
https://issues.apache.org/jira/browse/WW-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199072#comment-16199072
]
Aleksandr Mashchenko commented on WW-4869:
--
Can someone reproduce this? The blank archetype app works fine for me in ubuntu
with latest jdk-9 and latest jetty.
[~d87904488] Which build version of java 9 are you using? Where do you run your
app?
> Struts2.5.13 can't run in java9 win10
> -
>
> Key: WW-4869
> URL: https://issues.apache.org/jira/browse/WW-4869
> Project: Struts 2
> Issue Type: Bug
> Components: Dispatch Filter
>Affects Versions: 2.5.13
> Environment: windows 10-jdk9-maven3.5
>Reporter: Smith Cruise
>Assignee: Lukasz Lenart
> Labels: java9
> Fix For: 2.6
>
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> I followed the official
> tutorial,http://struts.apache.org/getting-started/how-to-create-a-struts2-web-application.html.
> But always throw exception when i run webapp.i tried many times but I really
> don't know how to reslove it.
> Here is Exception
> {noformat}
> java.nio.file.InvalidPathException: Illegal char <:> at index 3:
> jar:file:\D:\.m2\repository\org\apache\struts\struts2-core\2.5.13\struts2-core-2.5.13.jar
> at
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at
> java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
> at java.base/java.io.File.toPath(File.java:2300)
> at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:951)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:216)
> at java.base/java.util.zip.ZipFile.(ZipFile.java:148)
> at java.base/java.util.jar.JarFile.(JarFile.java:324)
> at java.base/java.util.jar.JarFile.(JarFile.java:295)
> at java.base/java.util.jar.JarFile.(JarFile.java:234)
> at
> com.opensymphony.xwork2.util.fs.JarEntryRevision.needsReloading(JarEntryRevision.java:73)
> at
> com.opensymphony.xwork2.util.fs.DefaultFileManager.fileNeedsReloading(DefaultFileManager.java:62)
> at
> com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.needsReload(XmlConfigurationProvider.java:425)
> at
> org.apache.struts2.config.StrutsXmlConfigurationProvider.needsReload(StrutsXmlConfigurationProvider.java:163)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.needReloadContainerProviders(ConfigurationManager.java:208)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.conditionalReload(ConfigurationManager.java:174)
> at
> com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:69)
> at
> org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960)
> at
> org.apache.struts2.dispatcher.ExecuteOperations.executeStaticResourceRequest(ExecuteOperations.java:59)
> at
> org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:130)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1476)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
> at org.eclipse.jetty.server.Server.handle(Server.java:370)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)
> at
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)
> at
> org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.heade
[jira] [Commented] (WW-4851) Upgrade to Log4j2 2.9.0
[
https://issues.apache.org/jira/browse/WW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183205#comment-16183205
]
Aleksandr Mashchenko commented on WW-4851:
--
The jetty used in the showcase app is pretty old. I don't see this warning with
the latest jetty.
> Upgrade to Log4j2 2.9.0
> ---
>
> Key: WW-4851
> URL: https://issues.apache.org/jira/browse/WW-4851
> Project: Struts 2
> Issue Type: Dependency
>Reporter: Stefaan Dutry
>Priority: Trivial
> Fix For: 2.5.14
>
>
> version {{2.9.0}} was released on {{2017-08-26}}
> [changelog|https://logging.apache.org/log4j/2.0/changes-report.html#a2.9.0]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WW-4849) ObjectFactory constructor signature change breaks extensions
[
https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159009#comment-16159009
]
Aleksandr Mashchenko commented on WW-4849:
--
_ Any other custom object factories will still be broken, though._ And w/o it
the injection might not work as expected. :)
I can try to re-test it in my setup with your solution, but still it doesn't
solve the original issue.
> ObjectFactory constructor signature change breaks extensions
>
>
> Key: WW-4849
> URL: https://issues.apache.org/jira/browse/WW-4849
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.5.13
>Reporter: Mitth'raw'nuruodo
> Fix For: 2.5.14
>
>
> Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of
> the {{ObjectFactory}} constructor, breaking all classes that extend
> {{ObjectFactory}} (as per https://struts.apache.org/docs/objectfactory.html).
> This affects eg the [{{guice-servlet}} Struts plugin|
> https://github.com/google/guice/blob/master/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java].
> This was not listed on the [2.5.13 version
> notes|https://struts.apache.org/docs/version-notes-2513.html] as a breaking
> change, and breaking changes should preferably be avoided in critical
> security updates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
