[jira] [Commented] (WW-5059) primer.html link to spring-security is broken
[ https://issues.apache.org/jira/browse/WW-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160965#comment-17160965 ] Hudson commented on WW-5059: SUCCESS: Integrated in Jenkins build Struts-staged-site #53 (See [https://builds.apache.org/job/Struts-staged-site/53/]) Correct link to Spring Security - WW-5059 (github: [https://github.com/apache/struts-site/commit/02a1379788fb08cba89e1ebd43159d65b5fedbe4]) * (edit) source/primer.md > primer.html link to spring-security is broken > - > > Key: WW-5059 > URL: https://issues.apache.org/jira/browse/WW-5059 > Project: Struts 2 > Issue Type: Bug > Components: Documentation >Affects Versions: 2.5.22 > Environment: N/A >Reporter: Patrick McEvoy >Assignee: René Gielen >Priority: Trivial > Labels: documentation, easy-fix > Fix For: 2.6 > > Original Estimate: 1h > Remaining Estimate: 1h > > In primer.html#security, the link to spring-security is broken > The broken link is [http://www.springframework.org/spring-security/] > It correct link is [https://spring.io/projects/spring-security] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5062) Use downloads.a.o instead of archive
[ https://issues.apache.org/jira/browse/WW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160964#comment-17160964 ] Hudson commented on WW-5062: SUCCESS: Integrated in Jenkins build Struts-staged-site #53 (See [https://builds.apache.org/job/Struts-staged-site/53/]) WW-5062 Uses downloads.a.o instead of www.apache.org/dist (lukaszlenart: [https://github.com/apache/struts-site/commit/039da160c2fbcda375381697c93192125ca5827b]) * (edit) source/download.html > Use downloads.a.o instead of archive > > > Key: WW-5062 > URL: https://issues.apache.org/jira/browse/WW-5062 > Project: Struts 2 > Issue Type: Improvement > Components: Documentation >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Use https://downloads.apache.org/ instead of http://archive.apache.org/dist/ > in our site > {noformat} > Hello, Apache PMCs, > In order to better provide our millions of users with downloads, the > Apache Infrastructure Team has been restructuring the way downloads work > for our main distribution channels in the past few weeks. For users, > this will largely go unnoticed, and for projects likely the same, but we > did want to reach out to projects and inform them of the changes we've > made: > As of March 2020, we are deprecating www.apache.org/dist/ in favor of > https://downloads.apache.org/ for backup downloads as well as signature > and checksum verification. The primary driver has been splitting up web > site visits and downloads to gain better control and offer a better > service for both downloads and web site visits. > As stated, this does not impact end-users, and should have a minimal > impact on projects, as our download selectors as well as visits to > www.apache.org/dist/ have been adjusted to make use of > downloads.apache.org instead. We do however ask that projects, in their > own time-frame, change references on their own web sites from > www.apache.org/dist/ to downloads.apache.org wherever such references > may exist, to complete the switch in full. We will NOT be turning off > www.apache.org/dist/ in the near future, but would greatly appreciate if > projects could help us transition away from the old URLs in their > documentation and on their download pages. > The standard way of uploading releases[1] will STILL apply, however > there may be a short delay (<= 15 minutes) between releasing and > releases showing up on downloads.apache.org for technical reasons. > If you have any questions about this change, please do not hesitate > to reach out to us at us...@infra.apache.org. > With regards, > Daniel on behalf of ASF Infrastructure. > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5059) primer.html link to spring-security is broken
[ https://issues.apache.org/jira/browse/WW-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081222#comment-17081222 ] Hudson commented on WW-5059: SUCCESS: Integrated in Jenkins build Struts-site #272 (See [https://builds.apache.org/job/Struts-site/272/]) Correct link to Spring Security - WW-5059 (github: rev 02a1379788fb08cba89e1ebd43159d65b5fedbe4) * (edit) source/primer.md > primer.html link to spring-security is broken > - > > Key: WW-5059 > URL: https://issues.apache.org/jira/browse/WW-5059 > Project: Struts 2 > Issue Type: Bug > Components: Documentation >Affects Versions: 2.5.22 > Environment: N/A >Reporter: Patrick McEvoy >Assignee: René Gielen >Priority: Trivial > Labels: documentation, easy-fix > Fix For: 2.6 > > Original Estimate: 1h > Remaining Estimate: 1h > > In primer.html#security, the link to spring-security is broken > The broken link is [http://www.springframework.org/spring-security/] > It correct link is [https://spring.io/projects/spring-security] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5062) Use downloads.a.o instead of archive
[ https://issues.apache.org/jira/browse/WW-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052517#comment-17052517 ] Hudson commented on WW-5062: SUCCESS: Integrated in Jenkins build Struts-site #267 (See [https://builds.apache.org/job/Struts-site/267/]) WW-5062 Uses downloads.a.o instead of www.apache.org/dist (lukaszlenart: rev 039da160c2fbcda375381697c93192125ca5827b) * (edit) source/download.html > Use downloads.a.o instead of archive > > > Key: WW-5062 > URL: https://issues.apache.org/jira/browse/WW-5062 > Project: Struts 2 > Issue Type: Improvement > Components: Documentation >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Use https://downloads.apache.org/ instead of http://archive.apache.org/dist/ > in our site > {noformat} > Hello, Apache PMCs, > In order to better provide our millions of users with downloads, the > Apache Infrastructure Team has been restructuring the way downloads work > for our main distribution channels in the past few weeks. For users, > this will largely go unnoticed, and for projects likely the same, but we > did want to reach out to projects and inform them of the changes we've > made: > As of March 2020, we are deprecating www.apache.org/dist/ in favor of > https://downloads.apache.org/ for backup downloads as well as signature > and checksum verification. The primary driver has been splitting up web > site visits and downloads to gain better control and offer a better > service for both downloads and web site visits. > As stated, this does not impact end-users, and should have a minimal > impact on projects, as our download selectors as well as visits to > www.apache.org/dist/ have been adjusted to make use of > downloads.apache.org instead. We do however ask that projects, in their > own time-frame, change references on their own web sites from > www.apache.org/dist/ to downloads.apache.org wherever such references > may exist, to complete the switch in full. We will NOT be turning off > www.apache.org/dist/ in the near future, but would greatly appreciate if > projects could help us transition away from the old URLs in their > documentation and on their download pages. > The standard way of uploading releases[1] will STILL apply, however > there may be a short delay (<= 15 minutes) between releasing and > releases showing up on downloads.apache.org for technical reasons. > If you have any questions about this change, please do not hesitate > to reach out to us at us...@infra.apache.org. > With regards, > Daniel on behalf of ASF Infrastructure. > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5041) Upgrade to OGNL 3.1.26 and adapt to its new features
[ https://issues.apache.org/jira/browse/WW-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039772#comment-17039772 ] Hudson commented on WW-5041: FAILURE: Integrated in Jenkins build Struts-staged-site #25 (See [https://builds.apache.org/job/Struts-staged-site/25/]) WW-5041 adapt to new OGNL security features (yasserzamani: [https://github.com/apache/struts-site/commit/081ddfd114dae12c8b096da9cd9a53e71deb60cf]) * (edit) source/security/index.md WW-5041 make note (yasserzamani: [https://github.com/apache/struts-site/commit/e04d7c544d600ca49536d74880049cbcb3dbad21]) * (edit) source/security/index.md > Upgrade to OGNL 3.1.26 and adapt to its new features > > > Key: WW-5041 > URL: https://issues.apache.org/jira/browse/WW-5041 > Project: Struts 2 > Issue Type: Dependency >Reporter: Yasser Zamani >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.22 > > > We're required to adapt and use OGNL new features (security manager and > expression max length) for next release version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5057) Cleanup and/or improvements to Showcase Applications
[ https://issues.apache.org/jira/browse/WW-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028448#comment-17028448 ] Hudson commented on WW-5057: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #285 (See [https://builds.apache.org/job/Struts-master-JDK8/285/]) WW-5057 Showcase cleanup for 2.6 branch: - Added missing elements to the (43964333+jcgh4164838gh792c124b5: rev ecba2406d5ca60aee1a1cb69484e70c3c634664a) * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/actionPrefixExample.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/redirectActionPrefix.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/token/example4.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/ui/example.vm * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/ui/exampleSubmited.vm * (edit) apps/showcase/src/main/webapp/WEB-INF/hangman/hangmanNonAjax.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/methodPrefix.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/normalSubmit.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/ui/lotsOfOptiontransferselectSubmit.jsp * (edit) apps/showcase/src/main/java/org/apache/struts2/showcase/MoreSelectsAction.java * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/ui/exampleSubmited.jsp * (edit) apps/showcase/src/main/webapp/WEB-INF/person/new-person.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/ui/example.jsp * (edit) apps/showcase/src/main/java/org/apache/struts2/showcase/source/ViewSourceAction.java * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/actionPrefix.ftl * (edit) apps/showcase/pom.xml > Cleanup and/or improvements to Showcase Applications > > > Key: WW-5057 > URL: https://issues.apache.org/jira/browse/WW-5057 > Project: Struts 2 > Issue Type: Improvement > Components: Example Applications >Affects Versions: 2.6 >Reporter: James Chaplin >Priority: Minor > Fix For: 2.6 > > > Please refer to this Jira for tracking any cleanup or improvements to the > Showcase Applications on the 2.6 branch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5050) Upgrade to OGNL 3.2.12
[ https://issues.apache.org/jira/browse/WW-5050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013489#comment-17013489 ] Hudson commented on WW-5050: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #284 (See [https://builds.apache.org/job/Struts-master-JDK8/284/]) Minor follow-up to WW-5050 changes to ContainerImpl. - Made isStatic() (43964333+jcgh4164838gh792c124b5: rev ee583c22f1f96b736424b56f7a2c9727cc1fc4af) * (edit) core/src/main/java/com/opensymphony/xwork2/inject/ContainerImpl.java > Upgrade to OGNL 3.2.12 > -- > > Key: WW-5050 > URL: https://issues.apache.org/jira/browse/WW-5050 > Project: Struts 2 > Issue Type: Dependency >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > OGNL 3.2.12 is out > https://github.com/jkuhnert/ognl/blob/master/docs/VersionNotes.md#release-notes---version-3212 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5047) Upgrade Velocity to 2.1 and Velocity Tools to 3.0
[ https://issues.apache.org/jira/browse/WW-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004833#comment-17004833 ] Hudson commented on WW-5047: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #283 (See [https://builds.apache.org/job/Struts-master-JDK8/283/]) WW-5047 Avoids confusion about scope's default value (lukaszlenart: rev 503c8b7623767a5cbb97b361a34ca619114ef7b1) * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java > Upgrade Velocity to 2.1 and Velocity Tools to 3.0 > - > > Key: WW-5047 > URL: https://issues.apache.org/jira/browse/WW-5047 > Project: Struts 2 > Issue Type: Dependency >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > A new version of Velocity and Velocity is available, it would be good to use > them. > https://velocity.apache.org/engine/2.1/ > https://velocity.apache.org/tools/3.0/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5049) Move Velocity support into a dedicated plugin
[ https://issues.apache.org/jira/browse/WW-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004832#comment-17004832 ] Hudson commented on WW-5049: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #283 (See [https://builds.apache.org/job/Struts-master-JDK8/283/]) WW-5049 Moves Velocity support into a dedicated plugin (lukaszlenart: rev 5c55e69b4fb8effd6456e222ff4d080c13cd41f1) * (add) plugins/velocity/src/main/resources/template/velocity/xhtml/doubleselect.vm * (add) plugins/velocity/src/main/resources/template/velocity/xhtml/password.vm * (add) plugins/velocity/src/main/resources/template/velocity/xhtml/label.vm * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/StrutsResourceLoader.java * (edit) core/src/test/java/org/apache/struts2/views/TemplateEngineManagerTest.java * (delete) core/src/main/resources/template/archive/simple/submit.vm * (delete) core/src/main/resources/template/archive/simple/password.vm * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/RadioDirective.java * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/OptionTransferSelectDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/AnchorDirective.java * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/PushDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/DateDirective.java * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/TextAreaDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/UpDownSelectDirective.java * (add) plugins/velocity/src/main/resources/template/velocity/simple/doubleselect.vm * (add) plugins/velocity/src/main/resources/template/velocity/ajax/a.vm * (add) plugins/velocity/src/main/resources/template/velocity/simple/select.vm * (delete) core/src/main/resources/template/archive/xhtml/table.vm * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/PropertyDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/RadioDirective.java * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/TokenDirective.java * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/ActionErrorDirective.java * (add) plugins/velocity/src/main/resources/template/velocity/simple/form-close.vm * (add) plugins/velocity/src/main/resources/template/velocity/simple/label.vm * (delete) core/src/main/resources/template/archive/simple/textarea.vm * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/SubmitDirective.java * (delete) core/src/main/resources/template/archive/xhtml/controlheader.vm * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/LabelDirective.java * (delete) core/src/main/resources/template/archive/ajax/submit.vm * (add) plugins/velocity/src/main/resources/template/velocity/simple/combobox.vm * (delete) core/src/main/resources/template/archive/simple/radiomap.vm * (add) plugins/velocity/src/main/resources/template/velocity/simple/debug.vm * (delete) core/src/main/resources/template/archive/ajax/form-close.vm * (delete) core/src/main/resources/template/archive/ajax/a-close.vm * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/BeanDirective.java * (add) plugins/velocity/pom.xml * (edit) apps/showcase/src/main/resources/struts-tags-ui.xml * (add) plugins/velocity/src/main/resources/template/velocity/xhtml/hidden.vm * (edit) core/src/main/java/org/apache/struts2/StrutsConstants.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/ActionMessageDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/PasswordDirective.java * (add) plugins/velocity/src/main/resources/template/velocity/simple/token.vm * (delete) core/src/main/java/org/apache/struts2/views/velocity/components/InputTransferSelectDirective.java * (add) plugins/velocity/src/main/resources/template/velocity/simple/file.vm * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/FileDirective.java * (add) plugins/velocity/src/main/resources/template/velocity/simple/checkboxlist.vm * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/VelocityConstants.java * (delete) core/src/main/resources/template/archive/xhtml/token.vm * (add) plugins/velocity/src/main/resources/template/velocity/simple/scripting-events.vm * (delete) core/src/main/java/org/apache/struts2/views/velocity/package.html * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/ComponentDirective.java * (add) plugins/velocity/src/main/java/org/apache/struts2/views/velocity/components/ResetDirective.java * (add) plugins/vel
[jira] [Commented] (WW-5003) Use StrutsException instead of XWorkException
[ https://issues.apache.org/jira/browse/WW-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004500#comment-17004500 ] Hudson commented on WW-5003: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #282 (See [https://builds.apache.org/job/Struts-master-JDK8/282/]) WW-5003 Drops XWorkException and uses StrutsException instead (lukaszlenart: rev 140bea2e1c766b77e4870934f0ec5e619bf8c199) * (edit) core/src/main/java/com/opensymphony/xwork2/ActionChainResult.java * (edit) core/src/test/java/com/opensymphony/xwork2/interceptor/ExceptionMappingInterceptorTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java * (edit) core/src/main/java/com/opensymphony/xwork2/DefaultActionInvocation.java * (add) core/src/test/java/org/apache/struts2/StrutsExceptionTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ActionInvocationTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkList.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java * (edit) core/src/test/java/com/opensymphony/xwork2/config/providers/SomeUnknownHandler.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/DefaultValidatorFactory.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/DefaultActionValidatorManagerTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/DomHelper.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/ConfigurationException.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/NumberConverter.java * (edit) core/src/main/java/org/apache/struts2/util/StrutsTypeConverter.java * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-exception-mappings.xml * (edit) core/src/main/java/com/opensymphony/xwork2/util/reflection/ReflectionException.java * (edit) plugins/convention/src/main/java/org/apache/struts2/convention/DefaultClassFinder.java * (edit) plugins/convention/src/main/java/org/apache/struts2/convention/ConventionUnknownHandler.java * (edit) core/src/main/java/com/opensymphony/xwork2/ActionContext.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DateConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/DefaultValidatorFileParserTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ChainResultTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/UnknownHandler.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkBasicConverter.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ScopedModelDrivenInterceptor.java * (delete) core/src/test/java/com/opensymphony/xwork2/XWorkExceptionTest.java * (delete) core/src/main/java/com/opensymphony/xwork2/XWorkException.java * (edit) core/src/main/java/org/apache/struts2/StrutsException.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/classloader/ReloadingClassLoader.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/TypeConversionException.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkBasicConverterTest.java > Use StrutsException instead of XWorkException > - > > Key: WW-5003 > URL: https://issues.apache.org/jira/browse/WW-5003 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > We should replace {{XWorkException}} with {{StrutsException}} and mark > {{XWorkException}} as deprecated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5041) Upgrade to OGNL 3.1.26 and adapt to its new features
[ https://issues.apache.org/jira/browse/WW-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002878#comment-17002878 ] Hudson commented on WW-5041: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #280 (See [https://builds.apache.org/job/Struts-master-JDK8/280/]) WW-5041 Upgrade to OGNL 3.1.26 and adapt to its new features (yasserzamani: rev 11999d148ef879683195a8327ac67001d391a0c2) * (edit) core/src/main/java/org/apache/struts2/StrutsConstants.java * (edit) core/src/main/java/com/opensymphony/xwork2/inject/ContainerImpl.java * (edit) core/src/test/java/org/apache/struts2/result/StreamResultTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/OgnlTool.java * (edit) core/src/main/resources/org/apache/struts2/default.properties * (edit) core/src/main/resources/struts-default.xml * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * (edit) pom.xml > Upgrade to OGNL 3.1.26 and adapt to its new features > > > Key: WW-5041 > URL: https://issues.apache.org/jira/browse/WW-5041 > Project: Struts 2 > Issue Type: Dependency >Reporter: Yasser Zamani >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.22 > > > We're required to adapt and use OGNL new features (security manager and > expression max length) for next release version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5041) Upgrade to OGNL 3.1.26 and adapt to its new features
[ https://issues.apache.org/jira/browse/WW-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972385#comment-16972385 ] Hudson commented on WW-5041: SUCCESS: Integrated in Jenkins build Struts-site #263 (See [https://builds.apache.org/job/Struts-site/263/]) WW-5041 adapt to new OGNL security features (yasserzamani: rev 081ddfd114dae12c8b096da9cd9a53e71deb60cf) * (edit) source/security/index.md WW-5041 make note (yasserzamani: rev e04d7c544d600ca49536d74880049cbcb3dbad21) * (edit) source/security/index.md > Upgrade to OGNL 3.1.26 and adapt to its new features > > > Key: WW-5041 > URL: https://issues.apache.org/jira/browse/WW-5041 > Project: Struts 2 > Issue Type: Dependency >Reporter: Yasser Zamani >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21 > > > We're required to adapt and use OGNL new features (security manager and > expression max length) for next release version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5041) Upgrade to OGNL 3.1.26 and adapt to its new features
[ https://issues.apache.org/jira/browse/WW-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972342#comment-16972342 ] Hudson commented on WW-5041: SUCCESS: Integrated in Jenkins build Struts-staged-site #22 (See [https://builds.apache.org/job/Struts-staged-site/22/]) WW-5041 adapt to new OGNL security features (yasserzamani: [https://github.com/apache/struts-site/commit/081ddfd114dae12c8b096da9cd9a53e71deb60cf]) * (edit) source/security/index.md WW-5041 make note (yasserzamani: [https://github.com/apache/struts-site/commit/e04d7c544d600ca49536d74880049cbcb3dbad21]) * (edit) source/security/index.md > Upgrade to OGNL 3.1.26 and adapt to its new features > > > Key: WW-5041 > URL: https://issues.apache.org/jira/browse/WW-5041 > Project: Struts 2 > Issue Type: Dependency >Reporter: Yasser Zamani >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21 > > > We're required to adapt and use OGNL new features (security manager and > expression max length) for next release version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5041) Upgrade to OGNL 3.1.26 and adapt to its new features
[ https://issues.apache.org/jira/browse/WW-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972262#comment-16972262 ] Hudson commented on WW-5041: SUCCESS: Integrated in Jenkins build Struts-staged-site #21 (See [https://builds.apache.org/job/Struts-staged-site/21/]) WW-5041 adapt to new OGNL security features (yasserzamani: [https://github.com/apache/struts-site/commit/081ddfd114dae12c8b096da9cd9a53e71deb60cf]) * (edit) source/security/index.md > Upgrade to OGNL 3.1.26 and adapt to its new features > > > Key: WW-5041 > URL: https://issues.apache.org/jira/browse/WW-5041 > Project: Struts 2 > Issue Type: Dependency >Reporter: Yasser Zamani >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21 > > > We're required to adapt and use OGNL new features (security manager and > expression max length) for next release version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5022) Struts 2.6 escaping behaviour change for s:a (anchor) tag
[ https://issues.apache.org/jira/browse/WW-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971404#comment-16971404 ] Hudson commented on WW-5022: FAILURE: Integrated in Jenkins build Struts-master-JDK8 #271 (See [https://builds.apache.org/job/Struts-master-JDK8/271/]) WW-5022 Adds missing autogenerated tags (lukaszlenart: rev d83e93919c6ec7899c75c22d705fd30fa15c1990) * (edit) core/src/site/resources/tags/a.html * (edit) core/src/site/resources/tags/submit.html > Struts 2.6 escaping behaviour change for s:a (anchor) tag > - > > Key: WW-5022 > URL: https://issues.apache.org/jira/browse/WW-5022 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.6 > Environment: Tomcat 7.0, 8.5 using Java 8 and 11. >Reporter: James Chaplin >Priority: Major > Fix For: 2.6 > > > While interacting with the current 2.6 Showcase application I recently > noticed that+ the "Home" glyph icon was not displaying correctly+. Instead > of the icon, +the page displayed the body content literally in the browser+. > Checking the page source (view source in browser) it turns out the body > content of the tag was HTML-escaped. I double-checked and this does not > happen to Struts 2.5.21 (snapshot) or older 2.6 Showcase apps. > This behaviour might affect other tags, but +it was noticed and confirmed > with "s:a"+ (the JSP anchor tag). > After some digging (using older commits from GitHub and building the 2.6 > Showcase app from them) it appears the automatic body escaping did not occur > prior to January 2nd 2019, but was introduced with one of the multiple > commits applied on January 3rd 2019. > It could be an interaction between earlier mid-December 2018 commits that > changed the Freemarker configuration version in FreemarkerManager > (Configuration.VERSION_2_3_0) to a new one (Configuration.VERSION_2_3_28), > combined with the January 3rd commits. Couldn't find the exact cause, but > perhaps one of the Struts Team might be able to do so. > Given the original/old behaviour +it seems that auto-escaping the tag body > might be a bug+. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5045) Update jasperreports to 6.10.0
[ https://issues.apache.org/jira/browse/WW-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970340#comment-16970340 ] Hudson commented on WW-5045: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #270 (See [https://builds.apache.org/job/Struts-master-JDK8/270/]) WW-5045 Update jasperreports to 6.10.0 (s.peters: rev 13b5b8e881f2435f70a6be62b67d782c004c56a6) * (edit) plugins/jasperreports/pom.xml > Update jasperreports to 6.10.0 > -- > > Key: WW-5045 > URL: https://issues.apache.org/jira/browse/WW-5045 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - JasperReports >Reporter: Sebastian Peters >Priority: Trivial > Fix For: 2.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5022) Struts 2.6 escaping behaviour change for s:a (anchor) tag
[ https://issues.apache.org/jira/browse/WW-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955218#comment-16955218 ] Hudson commented on WW-5022: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #268 (See [https://builds.apache.org/job/Struts-master-JDK8/268/]) Proposed fix for WW-5022 (escape html tag body control flag) - Added (43964333+jcgh4164838gh792c124b5: rev 9592355960850108af0097c44ac49600cc062734) * (edit) apps/showcase/src/main/webapp/WEB-INF/decorators/main.jsp * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/SubmitTest.java * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-5.txt * (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/SubmitTag.java * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-4.txt * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/subsetIteratorTagDemoResult.jsp * (edit) core/src/main/resources/template/simple/a-close.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/filedownload/index.jsp * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/iteratorGeneratorTagDemoResult.jsp * (edit) core/src/main/java/org/apache/struts2/components/Anchor.java * (edit) core/src/main/java/org/apache/struts2/components/Submit.java * (edit) core/src/main/resources/template/simple/submit-close.ftl * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/AnchorTest.java * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/mergeIteratorTagDemoResult.jsp * (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/AnchorTag.java * (edit) core/src/main/java/org/apache/struts2/components/Component.java * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-3.txt * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Submit-11.txt * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/appendIteratorTagDemoResult.jsp * (edit) core/src/test/java/org/apache/struts2/components/ComponentTest.java * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Submit-12.txt > Struts 2.6 escaping behaviour change for s:a (anchor) tag > - > > Key: WW-5022 > URL: https://issues.apache.org/jira/browse/WW-5022 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.6 > Environment: Tomcat 7.0, 8.5 using Java 8 and 11. >Reporter: James Chaplin >Priority: Major > Fix For: 2.6 > > > While interacting with the current 2.6 Showcase application I recently > noticed that+ the "Home" glyph icon was not displaying correctly+. Instead > of the icon, +the page displayed the body content literally in the browser+. > Checking the page source (view source in browser) it turns out the body > content of the tag was HTML-escaped. I double-checked and this does not > happen to Struts 2.5.21 (snapshot) or older 2.6 Showcase apps. > This behaviour might affect other tags, but +it was noticed and confirmed > with "s:a"+ (the JSP anchor tag). > After some digging (using older commits from GitHub and building the 2.6 > Showcase app from them) it appears the automatic body escaping did not occur > prior to January 2nd 2019, but was introduced with one of the multiple > commits applied on January 3rd 2019. > It could be an interaction between earlier mid-December 2018 commits that > changed the Freemarker configuration version in FreemarkerManager > (Configuration.VERSION_2_3_0) to a new one (Configuration.VERSION_2_3_28), > combined with the January 3rd commits. Couldn't find the exact cause, but > perhaps one of the Struts Team might be able to do so. > Given the original/old behaviour +it seems that auto-escaping the tag body > might be a bug+. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5042) Upgrade jackson-databind to version 2.10.0
[ https://issues.apache.org/jira/browse/WW-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951802#comment-16951802 ] Hudson commented on WW-5042: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #265 (See [https://builds.apache.org/job/Struts-master-JDK8/265/]) WW-5042 Upgrade jackson-databind to version 2.10.0 (s.peters: rev 4556f404bddc99c90f90c359351797f4b54b3917) * (edit) pom.xml > Upgrade jackson-databind to version 2.10.0 > -- > > Key: WW-5042 > URL: https://issues.apache.org/jira/browse/WW-5042 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - REST > Environment: See > https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10 >Reporter: Sebastian Peters >Priority: Minor > Fix For: 2.6 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (WW-5033) Update a few Struts 2.5.x libraries to more recent versions
[ https://issues.apache.org/jira/browse/WW-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924829#comment-16924829 ] Hudson commented on WW-5033: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #263 (See [https://builds.apache.org/job/Struts-master-JDK8/263/]) WW-5033 - Update to latest versions for some Struts 2.5.x dependencies: (yasserzamani: rev 9453e05559731a4f20e720fa268e25c0040b80c0) * (edit) pom.xml > Update a few Struts 2.5.x libraries to more recent versions > --- > > Key: WW-5033 > URL: https://issues.apache.org/jira/browse/WW-5033 > Project: Struts 2 > Issue Type: Dependency > Components: Build Management, Other >Affects Versions: 2.5.20 >Reporter: James Chaplin >Priority: Minor > Labels: build, pull-request-available > Fix For: 2.5.21, 2.6 > > > Hello Apache Struts Team. > This Jira issue is intended to track introduction of newer (compatible) > library versions for the Struts 2.5.x line. > Please find below a list of library version updates for the 2.5.x build line, > for which the regression build completes successfully. > - > Update Struts 2.5.20 build with some newer (compatible) library versions. > Change the main pom.xml library versions for the following: > - Jackson 2.9.8 -> 2.9.9 > - Log4j2 2.11.1 -> 2.11.2 > - OGNL 3.1.22 -> 3.1.23 > - > There is an open PR #356 demonstrating the CI build completes with the above > library upgrades. > Please review and consider for inclusion in 2.5.21. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (WW-5035) Provide mechanism to clear OgnlUtil caches
[ https://issues.apache.org/jira/browse/WW-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924828#comment-16924828 ] Hudson commented on WW-5035: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #263 (See [https://builds.apache.org/job/Struts-master-JDK8/263/]) Proposed WW-5035 enhancement: - Provide cache clearing methods for (yasserzamani: rev 6d453ca70d5ccce80b1cf2708fb79c214a65d407) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java > Provide mechanism to clear OgnlUtil caches > -- > > Key: WW-5035 > URL: https://issues.apache.org/jira/browse/WW-5035 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Environment: All >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.5.21, 2.6 > > > Hello Apache Struts Team. > This Jira proposes to provide some cache-clearing methods for the OgnlUtil > class, as well as methods to check the current cache element count. > These methods will allow applications to clear the OgnlUtil expression cache > and BeanInfo cache when necessary (using application-specific usage profile). > Currently the only OgnlUtil cache control available to applications is to > enable/disable the OgnlUtil expressionCache > ({{struts.ognl.enableExpressionCache flag}}). > Using the new methods applications that have resource (memory) leak issues > with the caches may be able to use the caches to gain some performance > benefits, while periodically clearing them to recover memory resources. > Application developers can determine how frequently (e.g. hourly, daily) such > cache clearing is needed. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (WW-5038) Upgrade jackson-databind to version 2.9.9.3
[ https://issues.apache.org/jira/browse/WW-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924758#comment-16924758 ] Hudson commented on WW-5038: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #262 (See [https://builds.apache.org/job/Struts-master-JDK8/262/]) WW-5038 Upgrades jackson-databind to version 2.9.9.3 plus upgrades (lukaszlenart: rev 8187006c31f1ebdc80f4090a2e1f05c8bdc223f7) * (edit) pom.xml > Upgrade jackson-databind to version 2.9.9.3 > --- > > Key: WW-5038 > URL: https://issues.apache.org/jira/browse/WW-5038 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - REST >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.5.21, 2.6 > > > One or more dependencies were identified with known vulnerabilities in Struts > 2 REST Plugin: > jackson-databind-2.9.8.jar (cpe:/a:fasterxml:jackson:2.9.8, > cpe:/a:fasterxml:jackson-databind:2.9.8, > com.fasterxml.jackson.core:jackson-databind:2.9.8) : CVE-2019-14379, > CVE-2019-12814, CVE-2019-14439, CVE-2019-12086, CVE-2019-12384 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (WW-5037) Upgrade commons-beanutils to version 1.9.4
[ https://issues.apache.org/jira/browse/WW-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920797#comment-16920797 ] Hudson commented on WW-5037: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #260 (See [https://builds.apache.org/job/Struts-master-JDK8/260/]) WW-5037 Upgrades commons-beanutils to version 1.9.4 (lukaszlenart: rev f840c7123e3774a7baa81b5ed4765a867d0f6635) * (edit) pom.xml > Upgrade commons-beanutils to version 1.9.4 > -- > > Key: WW-5037 > URL: https://issues.apache.org/jira/browse/WW-5037 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.5.21, 2.6 > > > One or more dependencies were identified with known vulnerabilities in Struts > 2 Core: > commons-beanutils-1.9.3.jar (cpe:/a:apache:commons_beanutils:1.9.3, > commons-beanutils:commons-beanutils:1.9.3) : CVE-2019-10086 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854361#comment-16854361 ] Hudson commented on WW-4999: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #257 (See [https://builds.apache.org/job/Struts-master-JDK8/257/]) fix compilation error of WW-4999 cherry picks (yasserzamani: rev 570f8c3e67001c17b5fa6049945f187dd40c6696) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854319#comment-16854319 ] Hudson commented on WW-4999: FAILURE: Integrated in Jenkins build Struts-master-JDK8 #256 (See [https://builds.apache.org/job/Struts-master-JDK8/256/]) fix logMissingProperties (WW-4999) (yasserzamani: rev b657a272d1d2ae93dc5fd0a1b7f81d6ae1772e89) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java not log user exceptions as missing properties (WW-4999) (yasserzamani: rev 382124cfd2c3eb2f757e6faaf9a7a58f5e002765) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java test not throw exception on top missing property (WW-4999) (yasserzamani: rev a16cd4fca62e5df43b9afb045443f6e581d4a41e) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java decouple logMissingProperties from devMode (WW-4999) (yasserzamani: rev eca9c34645882b7d28b5b2dab42c0c3b4a0b10a3) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java test false for logMissingProperties (WW-4999) (yasserzamani: rev 704e41c6e802972def971c1223a3aa522e525bdb) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5034) Minor enhancement/fix to AbstractLocalizedTextProvider
[ https://issues.apache.org/jira/browse/WW-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854239#comment-16854239 ] Hudson commented on WW-5034: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #255 (See [https://builds.apache.org/job/Struts-master-JDK8/255/]) [WW-5034] Forward port Minor enhancement/fix to (43964333+jcgh4164838gh792c124b5: rev 5c30e0d5c6ed8c6237f1e3705c8639a7f7a35214) * (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java * (edit) core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java > Minor enhancement/fix to AbstractLocalizedTextProvider > -- > > Key: WW-5034 > URL: https://issues.apache.org/jira/browse/WW-5034 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Affects Versions: 2.5.20 >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.5.21, 2.6 > > > Hello Apache Struts Team. > This Jira issue is to track a minor enhancement/fix for the > AbstractLocalizedTextProvider. > - Made a "constant" static to save an initialization for instance members. > - Updated clearBundle() method comment for accuracy, added debug log output. > - Introduced a protected clearBundle(bundle, locale) method, with debug log > output. > - Introduced protected clearMissingBundlesCache() method, with debug log > output. > The additional methods could allow for more flexible custom > AbstractLocalizedTextProvider descendants for use in scenarios where > applications desire different behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5029) The content allowed-methods tag of the XML configuration is sometimes truncated
[ https://issues.apache.org/jira/browse/WW-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822370#comment-16822370 ] Hudson commented on WW-5029: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #251 (See [https://builds.apache.org/job/Struts-master-JDK8/251/]) Proposed fix for WW-5029 for the 2.5.x branch (#347) (yasserzamani: rev 47a8a21da276ca1f2521685f7445330be84c66ee) * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java * (edit) core/src/test/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProviderTest.java > The content allowed-methods tag of the XML configuration is sometimes > truncated > --- > > Key: WW-5029 > URL: https://issues.apache.org/jira/browse/WW-5029 > Project: Struts 2 > Issue Type: Bug > Components: XML Configuration >Affects Versions: 2.5.18 >Reporter: Maxime Clement >Priority: Major > Fix For: 2.5.21, 2.6 > > > Under WebSphere 8.5, the SAX parser sometimes create multiple text elements > to represent the value of the "allowed-methods" tag found in the struts.xml > configuration file. This happens when the text is read in chunks as stated > here: > [https://docs.oracle.com/javase/8/docs/api/org/xml/sax/ContentHandler.html#characters-char:A-int-int-]. > This case is not handled in class XmlConfigurationProvider, which only reads > the first child of the org.w3c.dom.Node returned by the parser (see > [https://github.com/apache/struts/blob/struts-2-5-x/core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java#L879]). > > This means that with this configuration: > {code:java} > method1,method2 > {code} > The node instance almost always contains a single child [ "method1,method2" > ], but randomly the node instance can contain two children: [ "method1,me", > "thod2" ]. As only the first child is considered, the retrieved text is > truncated and the configuration doesn't work. > > It happens randomly and cannot be reproduced easily, but we can see in the > XmlConfigurationProvider class that this case has been taken into account for > the "result" tag: > {code:java} > something > {code} > See: > [https://github.com/apache/struts/blob/struts-2-5-x/core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java#L767] > where all node children of type Node.TEXT_NODE are concatenated to retrieve > the text value, so even if the SAX parser returns multiple chunks, the word > is correctly reconstructed. > > As a workaround I created a custom configuration provider that overrides > StrutsXmlConfigurationProvider and redefines the method "buildAllowedMethods" > in order to parse all children of the node object, as done in method > "buildResults". Note that the same problem applies for > "global-allowed-methods" as the XmlConfigurationProvider also considers the > first child only. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5028) Dispatcher prints stacktraces directly to the console
[ https://issues.apache.org/jira/browse/WW-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822357#comment-16822357 ] Hudson commented on WW-5028: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #250 (See [https://builds.apache.org/job/Struts-master-JDK8/250/]) (Amended commit based on feedback) Proposed fix for WW-5028 for the (yasserzamani: rev f0776aeac6297c849b14921debec4c9cb5653c37) * (edit) core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java > Dispatcher prints stacktraces directly to the console > - > > Key: WW-5028 > URL: https://issues.apache.org/jira/browse/WW-5028 > Project: Struts 2 > Issue Type: Bug > Components: Dispatch Filter >Affects Versions: 2.5.18 >Reporter: Stuart Harper >Priority: Minor > Fix For: 2.5.21, 2.6 > > > After upgrading from Struts 2.3.x to 2.5.x we noticed a stack trace in our > logs which was not previously present. The error is actually quite minor and > doesn't impact any functionality, the problem is we have no ability to > control its presence in our logs do the way the Dispatcher.java prints > directly to the console. > This can be seen in class org.apache.struts2.dispatcher.Dispatcher around > line 586 > Only after the error is printed is a check made on whether to handle it. The > exception is then rethrown. > I think it would make more sense to use the logging framework to log > exceptions or otherwise give us some control over whether this appears. As it > is it's impossible to turn it off. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters
[ https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806493#comment-16806493 ] Hudson commented on WW-5024: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #248 (See [https://builds.apache.org/job/Struts-master-JDK8/248/]) Forward port fix for WW-5024 to 2.6: - NOTE: If the PR is accepted (43964333+jcgh4164838gh792c124b5: rev 3e11e1db4775a5f4f21d57f0361ea06ed06e1578) * (edit) core/src/main/java/org/apache/struts2/interceptor/ActionMappingParametersInterceptor.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java * (add) core/src/test/java/org/apache/struts2/interceptor/ActionMappingParametersInterceptorTest.java > HttpParameters.Builder can wrap objects in two layers of Parameters > --- > > Key: WW-5024 > URL: https://issues.apache.org/jira/browse/WW-5024 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.20 >Reporter: Robert Hollencamp >Priority: Major > Fix For: 2.5.21, 2.6 > > > Parameters added to ActionMapping can end up wrapped in Parameter twice -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5026) Double-submit of TokenSessionStoreInterceptor broken since 2.5.16
[ https://issues.apache.org/jira/browse/WW-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806461#comment-16806461 ] Hudson commented on WW-5026: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #247 (See [https://builds.apache.org/job/Struts-master-JDK8/247/]) Forward-port fix for WW-5026 to 2.6. - Equivalent to PR#342 for 2.5.x, (43964333+jcgh4164838gh792c124b5: rev bb7cf092bc9374af743de67ec9e2aa4d0f55cdf0) * (edit) core/src/test/java/org/apache/struts2/util/InvocationSessionStoreTest.java * (edit) core/src/main/java/org/apache/struts2/interceptor/TokenSessionStoreInterceptor.java * (edit) core/src/main/java/org/apache/struts2/util/InvocationSessionStore.java > Double-submit of TokenSessionStoreInterceptor broken since 2.5.16 > - > > Key: WW-5026 > URL: https://issues.apache.org/jira/browse/WW-5026 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors >Affects Versions: 2.5.16, 2.5.20 > Environment: Tomcat 7.0.x (but should reproduce on any application > server) >Reporter: James Chaplin >Priority: Major > Labels: pull-request-available > Fix For: 2.5.21, 2.6 > > > With recent fixes to the Showcase application it was discovered that the 3rd > Token example (for TokenSessionStoreInterceptor) is failing upon the > double-submit with Struts versions 2.5.16 - 2.5.20 (and 2.5.21 snapshot). > Steps to reproduce: > 1) Launch Struts 2.5.21-snapshot showcase application > 2) Open the Examples, Token, Example 3. > 3) Click on submit (wait for completion), back button in browser, then submit > again. > 4) Application container returns a response code 500. > The issue appears to have been introduced with fixes for WW-4873. A proposed > fix for this issue will be provided in a PR shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5023) Upgrade SLF4J to latest 1.7.x version
[ https://issues.apache.org/jira/browse/WW-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789274#comment-16789274 ] Hudson commented on WW-5023: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #245 (See [https://builds.apache.org/job/Struts-master-JDK8/245/]) Upgrade SLF4J to 1.7.26 (WW-5023) (#337) (lukasz.lenart: rev e82c5a207f62fdb1bb6e8da690325b5a109c924f) * (edit) pom.xml > Upgrade SLF4J to latest 1.7.x version > - > > Key: WW-5023 > URL: https://issues.apache.org/jira/browse/WW-5023 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Affects Versions: 2.5.20, 2.6 > Environment: All >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.5.21, 2.6 > > > Upgrade both the 2.5.x and 2.6 Struts branches to utilize SLF4J 1.7.26, which > was recently released. > A PR for each Struts branch will be created to update the SLF4J version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5016) Support java8 date/time in date tag
[ https://issues.apache.org/jira/browse/WW-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762452#comment-16762452 ] Hudson commented on WW-5016: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #236 (See [https://builds.apache.org/job/Struts-master-JDK8/236/]) WW-5016 Support java8 date/time in date tag (amashchenko: rev aacac5b9fc0cbf4c191fcb2e8be232e3fa736dd0) * (edit) core/src/main/java/org/apache/struts2/components/Date.java * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/DateTagTest.java > Support java8 date/time in date tag > --- > > Key: WW-5016 > URL: https://issues.apache.org/jira/browse/WW-5016 > Project: Struts 2 > Issue Type: Task > Components: Core Tags >Affects Versions: 2.6 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5009) EmptyStackException in JSON plugin due to concurrency
[ https://issues.apache.org/jira/browse/WW-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760705#comment-16760705 ] Hudson commented on WW-5009: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #234 (See [https://builds.apache.org/job/Struts-master-JDK8/234/]) WW-5009 EmptyStackException in JSON plugin due to concurrency (amashchenko: rev be457f4241418b75cdcf0a9b71775dde91f94163) * (edit) plugins/json/src/main/java/org/apache/struts2/json/JSONInterceptor.java * (edit) plugins/json/src/test/java/org/apache/struts2/json/JSONInterceptorTest.java > EmptyStackException in JSON plugin due to concurrency > - > > Key: WW-5009 > URL: https://issues.apache.org/jira/browse/WW-5009 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - JSON >Affects Versions: 2.5.20 > Environment: JDK 1.8_0_191 > Tomcat 9.0.12 >Reporter: Eduardo Quintanilla >Assignee: Aleksandr Mashchenko >Priority: Critical > Labels: json, json-rpc > Fix For: 2.5.21, 2.6 > > Attachments: logs.txt, struts-json-example-master.zip > > > EmptyStackException in JSON plugin due to concurrency > Note: The issue was found in an app that was upgraded from version 2.3.34 > Logs: [^logs.txt] > I created a sample application that should help reproducing the error. > [^struts-json-example-master.zip] > The error happened opening the app (localhost/struts-json-example) in 4 > different browsers / sessions. > As a workaround I have overridden the JSONInterceptor so a new instance of > JSONUtil is used with every request and the issue is not happening anymore. I > suppose there is a performance cost with that change but for now it works. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4991) Not existing property in listValueKey throws exception
[ https://issues.apache.org/jira/browse/WW-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760174#comment-16760174 ] Hudson commented on WW-4991: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #264 (See [https://builds.apache.org/job/Struts-master-JDK7/264/]) WW-4991 Not existing property in listValueKey throws exception (amashchenko: rev f6e0cdeb67540ceacff6bc4f167907650640) * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/SelectTest.java * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/RadioTest.java * (edit) core/src/main/resources/template/simple/select.ftl * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Radio-8.txt * (edit) core/src/main/resources/template/simple/radiomap.ftl * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Select-16.txt > Not existing property in listValueKey throws exception > -- > > Key: WW-4991 > URL: https://issues.apache.org/jira/browse/WW-4991 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Tags >Affects Versions: 2.5.x, 2.6 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.5.21, 2.6 > > > {\{}} and \{{}} tags are affected. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5004) No more calling of a static variable in Struts 2.8.20 available
[ https://issues.apache.org/jira/browse/WW-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757416#comment-16757416 ] Hudson commented on WW-5004: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #258 (See [https://builds.apache.org/job/Struts-master-JDK7/258/]) Fix for access issue for 2.6 discovered in WW-5004 (2nd amended commit): (43964333+jcgh4164838gh792c124b5: rev 925eb62949347eaf29867b295bcfbc55f210f23a) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/interceptor/ParametersInterceptorTest.java * (edit) core/src/test/java/org/apache/struts2/util/SecurityMemberAccessInServletsTest.java * (add) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-staticfield-false.xml * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessProxyTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/SetPropertiesTest.java * (add) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-staticfield-true.xml * (edit) core/src/main/java/org/apache/struts2/StrutsConstants.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStackFactory.java * (edit) core/src/test/java/org/apache/struts2/result/ServletRedirectResultTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java Fix for access issue for 2.6 discovered in WW-5004 (Minor update to (43964333+jcgh4164838gh792c124b5: rev 64bd12b26da0916b088910c21e1852ef1f2ccaeb) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java > No more calling of a static variable in Struts 2.8.20 available > --- > > Key: WW-5004 > URL: https://issues.apache.org/jira/browse/WW-5004 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.20 > Environment: Java 7.1 and JSP Websites >Reporter: Deniz Renkligül >Priority: Critical > Labels: build, features, patch, usability > Fix For: 2.5.21, 2.6 > > > After the update from Struts 2.5.18 to 2.5.20 it is not more possible to call > a java static variable in JSP like > {code:java} > > {code} > Please see for more details the release notes of 2.5.20 > [link > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20|https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.20] > and I tried without success the following description assigned above in the > release version notes 2.5.20 with : > {code:java} > > > {code} > https://issues.apache.org/jira/browse/WW-4984 > > Thanks in advance for your support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5007) Upgrade Jackson library to the latest version
[ https://issues.apache.org/jira/browse/WW-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752218#comment-16752218 ] Hudson commented on WW-5007: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #254 (See [https://builds.apache.org/job/Struts-master-JDK7/254/]) WW-5007 Upgrades Jackson libraries to version 2.9.8 (lukaszlenart: rev 9029f159dbbba43e84bece2ee339a34a4810b627) * (edit) pom.xml > Upgrade Jackson library to the latest version > - > > Key: WW-5007 > URL: https://issues.apache.org/jira/browse/WW-5007 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - REST >Affects Versions: 2.5.20 >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.5.21, 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-5001) Allow to define converters in "struts-conversion.properties" file
[ https://issues.apache.org/jira/browse/WW-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749200#comment-16749200 ] Hudson commented on WW-5001: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #252 (See [https://builds.apache.org/job/Struts-master-JDK7/252/]) WW-5001 Adds support for struts-conversion.properties files (lukaszlenart: rev fc81832e8afbe9e47f74e4f61b74733ec66892c1) * (edit) core/src/main/resources/struts-default.xml * (add) core/src/test/resources/com/opensymphony/xwork2/conversion/impl/test-struts-conversion.properties * (delete) core/src/test/resources/com/opensymphony/xwork2/conversion/impl/test-xwork-conversion.properties * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultConversionPropertiesProcessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (add) core/src/main/java/org/apache/struts2/conversion/StrutsConversionPropertiesProcessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java > Allow to define converters in "struts-conversion.properties" file > - > > Key: WW-5001 > URL: https://issues.apache.org/jira/browse/WW-5001 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Now you must register a new converters in {{xwork-conversion.properties}} > which is an inherited from XWork days. As we move away from XWork it would be > good to use {{struts-conversion.properties}} instead. > This is small change in code with a warning about using > {{xwork-conversion.properties}} and docs must be updated as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4998) I18nInterceptor's default storage should store locale
[ https://issues.apache.org/jira/browse/WW-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738661#comment-16738661 ] Hudson commented on WW-4998: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #250 (See [https://builds.apache.org/job/Struts-master-JDK7/250/]) WW-4998 I18nInterceptor's default storage should store locale (amashchenko: rev b315b6e5fdbd5cae6877cf87d232956fca12a899) * (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java * (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java > I18nInterceptor's default storage should store locale > - > > Key: WW-4998 > URL: https://issues.apache.org/jira/browse/WW-4998 > Project: Struts 2 > Issue Type: Task > Components: Core Interceptors >Affects Versions: 2.5.18, 2.6 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.5.20, 2.6 > > > First request to application with \{{request_locale}} parameter doesn't save > locale if session was not created yet. > [Discussion|https://lists.apache.org/thread.html/0a3168cb80ddfe0e3a920f010bffc719707b4626478aee26fe78b8de@%3Cdev.struts.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4972) Switch to latest freemarker version when defining incompatible_improvements
[ https://issues.apache.org/jira/browse/WW-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735328#comment-16735328 ] Hudson commented on WW-4972: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #249 (See [https://builds.apache.org/job/Struts-master-JDK7/249/]) WW-4972 Switches incompatible_improvements to VERSION_2_3_28 (lukaszlenart: rev 796c15ee673247fe6c0c23da0b4e29a6ec4bb29d) * (edit) core/src/main/resources/template/simple/scripting-events.ftl * (edit) core/src/main/resources/template/simple/radiomap.ftl * (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java WW-4972 Uses built-in auto escaping instead of escaping each parameter (lukaszlenart: rev 3d20e80950d3c66759e70c650662aac573c66cc6) * (edit) core/src/main/resources/template/simple/css.ftl * (edit) core/src/main/resources/template/xhtml/control.ftl * (edit) core/src/main/java/org/apache/struts2/components/UIBean.java * (edit) core/src/main/resources/template/simple/optgroup.ftl * (edit) core/src/main/resources/template/simple/debug.ftl * (edit) core/src/main/resources/template/simple/form-common.ftl * (edit) core/src/main/resources/template/simple/form.ftl * (edit) core/src/main/resources/template/simple/submit.ftl * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/controlfooter.ftl * (edit) core/src/main/resources/template/simple/actionerror.ftl * (edit) core/src/main/resources/template/simple/text.ftl * (edit) plugins/config-browser/src/main/resources/config-browser/validatorDetails.ftl * (edit) core/src/main/resources/template/simple/textarea.ftl * (edit) core/src/main/resources/template/simple/reset.ftl * (edit) core/src/main/resources/template/xhtml/controlheader.ftl * (edit) core/src/main/resources/template/xhtml/controlfooter.ftl * (edit) core/src/main/resources/template/xhtml/controlheader-core.ftl * (edit) plugins/config-browser/src/main/resources/config-browser/showConfig.ftl * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Radio-6.txt * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/controlheader-core.ftl * (edit) core/src/main/resources/template/simple/password.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/methodPrefix.ftl * (edit) core/src/main/resources/org/apache/struts2/dispatcher/error.ftl * (edit) core/src/main/resources/template/simple/select.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/actionPrefix.ftl * (edit) core/src/main/resources/template/simple/hidden.ftl * (edit) core/src/main/java/org/apache/struts2/views/freemarker/FreemarkerManager.java * (edit) core/src/main/resources/template/simple/scripting-events.ftl * (edit) core/src/main/resources/template/simple/doubleselect.ftl * (edit) core/src/main/resources/template/simple/inputtransferselect.ftl * (edit) core/src/main/resources/template/css_xhtml/checkbox.ftl * (edit) core/src/main/resources/template/simple/file.ftl * (edit) core/src/main/resources/template/xhtml/tooltip.ftl * (edit) core/src/main/resources/template/simple/dynamic-attributes.ftl * (edit) core/src/main/resources/template/xhtml/form-close.ftl * (edit) core/src/main/resources/template/simple/fielderror.ftl * (edit) core/src/main/resources/template/simple/combobox.ftl * (edit) core/src/main/resources/template/simple/checkbox.ftl * (edit) core/src/main/resources/template/simple/token.ftl * (edit) core/src/main/resources/template/simple/optiontransferselect.ftl * (edit) core/src/main/resources/template/xhtml/checkbox.ftl * (edit) core/src/main/resources/template/simple/label.ftl * (edit) core/src/main/resources/template/simple/radiomap.ftl * (edit) core/src/main/resources/template/simple/a-close.ftl * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/ActionErrorTagTest.java * (edit) plugins/config-browser/src/main/resources/config-browser/actionNames.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/actionPrefix/redirectActionPrefix.ftl * (edit) core/src/main/resources/template/simple/common-attributes.ftl * (edit) apps/showcase/src/main/webapp/WEB-INF/person/list-people.ftl * (edit) core/src/main/resources/template/xhtml/form.ftl * (edit) core/src/main/resources/template/css_xhtml/controlheader-core.ftl * (edit) core/src/main/resources/template/css_xhtml/label.ftl * (edit) apps/showcase/src/main/resources/template/ajaxErrorContainers/actionerror.ftl * (edit) core/src/main/resources/template/simple/actionmessage.ftl * (edit) core/src/main/resources/template/simple/checkboxlist.ftl * (edit) core/src/main/resources/template/css_xhtml/controlfooter.ftl WW-4972 Uses proper statement to escape JS related events (lukaszlenart: rev 35497649baf9d3ed98f66d8165a415f2c88561b3) * (edit) core/src/main/resources/template/xhtml/tooltip.ftl * (edit) core/src/main/resources/template/xhtml/form.ftl * (edit) core/src/main/resources/template/simple/form-c
[jira] [Commented] (WW-4996) Refactor DefaultTypeConverterCreator to use ObjectFactory#buildConverter
[ https://issues.apache.org/jira/browse/WW-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735095#comment-16735095 ] Hudson commented on WW-4996: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #248 (See [https://builds.apache.org/job/Struts-master-JDK7/248/]) WW-4996 Refactors creator to use ObjectFactory#buildConverter method (lukaszlenart: rev 243a8c832b9fc3b3628ef9302085c9ec128fd0fc) * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverterCreator.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/main/resources/struts-default.xml * (add) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java WW-4996 Renames and moves class to proper package to better expose its (lukaszlenart: rev 6adfbed282d50318290de9414c9fed8bd2cd3775) * (add) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterHolder.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverterHolder.java * (edit) core/src/main/resources/struts-default.xml * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java * (edit) core/src/main/java/com/opensymphony/xwork2/factory/DefaultConverterFactory.java WW-4996 Reduces code duplication (lukaszlenart: rev c941326bf3da458beabcaab81456e51951318bcf) * (edit) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java WW-4996 Uses Struts* naming pattern instead of Default* (lukaszlenart: rev 19134516d8ef338c28c08dde60a7fb413be0357c) * (edit) core/src/main/resources/struts-default.xml * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (delete) core/src/main/java/com/opensymphony/xwork2/factory/DefaultConverterFactory.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (add) core/src/main/java/com/opensymphony/xwork2/factory/StrutsConverterFactory.java WW-4996 Fixes post rebase file name changes (lukaszlenart: rev a4bfb0d0f2108e087dadf96a20a1d1387e8c86a5) * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-devmode-true.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-devmode-true.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-devmode-false.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-true.xml > Refactor DefaultTypeConverterCreator to use ObjectFactory#buildConverter > > > Key: WW-4996 > URL: https://issues.apache.org/jira/browse/WW-4996 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > Right now {{DefaultTypeConverterCreator}} doesn't use > {{ObjectFactory#buildConverter()}} method which is a bit misleading. Also the > class name is misleading as this is a default Struts implementation so it > should be named {{StrutsTypeConverterCreator}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4975) Upgraded commons-fileupload to version 1.4
[ https://issues.apache.org/jira/browse/WW-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730898#comment-16730898 ] Hudson commented on WW-4975: SUCCESS: Integrated in Jenkins build Struts-2-3-JDK6 #27 (See [https://builds.apache.org/job/Struts-2-3-JDK6/27/]) WW-4975 Upgrades commons-fileupload to version 1.4 (lukaszlenart: rev 6870fb7f79a42ac119c3ab84e9564c707bdfe522) * (edit) pom.xml > Upgraded commons-fileupload to version 1.4 > -- > > Key: WW-4975 > URL: https://issues.apache.org/jira/browse/WW-4975 > Project: Struts 2 > Issue Type: Dependency > Components: Core Interceptors >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.37, 2.5.19 > > > https://commons.apache.org/proper/commons-fileupload/changes-report.html#a1.4 > I have referred 2.3.37 and 2.5.19 to investigate if this won't break backward > comaptibility. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4938) ObjectFactory should use Container to instantiate actions and inject dependencies
[ https://issues.apache.org/jira/browse/WW-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730781#comment-16730781 ] Hudson commented on WW-4938: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #245 (See [https://builds.apache.org/job/Struts-master-JDK7/245/]) WW-4938 Adds missing test case and properly fix injecting internal beans (lukaszlenart: rev a7524b04bed5b65e4b89a600dba6f4c4e586c075) * (edit) core/src/test/java/com/opensymphony/xwork2/spring/SpringObjectFactoryTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/spring/SpringObjectFactory.java * (edit) core/src/main/java/com/opensymphony/xwork2/ObjectFactory.java > ObjectFactory should use Container to instantiate actions and inject > dependencies > -- > > Key: WW-4938 > URL: https://issues.apache.org/jira/browse/WW-4938 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > It isn't possible to define an action with a constructor and annotated with > {{@Inject}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4975) Upgraded commons-fileupload to version 1.4
[ https://issues.apache.org/jira/browse/WW-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730782#comment-16730782 ] Hudson commented on WW-4975: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #245 (See [https://builds.apache.org/job/Struts-master-JDK7/245/]) WW-4975 Upgrades commons-fileupload to version 1.4 (lukaszlenart: rev 80a901d292dcf864e16456b7103b22a940f0829b) * (edit) pom.xml > Upgraded commons-fileupload to version 1.4 > -- > > Key: WW-4975 > URL: https://issues.apache.org/jira/browse/WW-4975 > Project: Struts 2 > Issue Type: Dependency > Components: Core Interceptors >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.37, 2.5.19 > > > https://commons.apache.org/proper/commons-fileupload/changes-report.html#a1.4 > I have referred 2.3.37 and 2.5.19 to investigate if this won't break backward > comaptibility. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4938) ObjectFactory should use Container to instantiate actions and inject dependencies
[ https://issues.apache.org/jira/browse/WW-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728052#comment-16728052 ] Hudson commented on WW-4938: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #244 (See [https://builds.apache.org/job/Struts-master-JDK7/244/]) WW-4938 Reverts dropping injecting internal beans in Spring Factory (lukaszlenart: rev f9272f8590be3d93a558421042573218cd6e9433) * (edit) core/src/main/java/com/opensymphony/xwork2/spring/SpringObjectFactory.java > ObjectFactory should use Container to instantiate actions and inject > dependencies > -- > > Key: WW-4938 > URL: https://issues.apache.org/jira/browse/WW-4938 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > It isn't possible to define an action with a constructor and annotated with > {{@Inject}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4995) Enhancement for s:set tag to improve tag body whitespace control.
[ https://issues.apache.org/jira/browse/WW-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727035#comment-16727035 ] Hudson commented on WW-4995: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #243 (See [https://builds.apache.org/job/Struts-master-JDK7/243/]) WW-4995 Add trimBody attribute to set tag (aleksandr.7m: rev cd434da6f0f28153d5446e1f7849bd4740da4023) * (edit) core/src/main/java/org/apache/struts2/views/jsp/SetTag.java * (edit) core/src/test/java/org/apache/struts2/views/jsp/SetTagTest.java * (edit) core/src/main/java/org/apache/struts2/components/Set.java > Enhancement for s:set tag to improve tag body whitespace control. > - > > Key: WW-4995 > URL: https://issues.apache.org/jira/browse/WW-4995 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Affects Versions: 2.5.18 > Environment: All environments. >Reporter: James Chaplin >Priority: Minor > Labels: pull-request-available > Fix For: 2.5.19 > > > Hello Apache Struts Team. > The current s:set tag performs an automatic _trim()_ on any body content used > (when using the something style with a body). > The current behaviour limits white-space control for the text body passed to > the s:set tag (and makes assigning a single-or-muliple-character whitespace > set - e.g. " " impossible via the tag body).. > A proposed improvement is to introduce two optional attributes to the s:set > tag which will permit the following: > * Allow an override to prevent the trim() from happening (helps to preserve > existing whitespace).. > * Allow the optional removal of all line-breaks from the tag body content > (to allow vertical collapsing of tag body content without impacting anything > else). > There is a PR available with a proposed implementation for the enhancement. > I believe having this additional flexibility will be beneficial for some JSP > content generation scenarios. > Please review and advise if this minor enhancement can be considered for > inclusion in 2.5.19 (and then ported forward for 2.6). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4938) ObjectFactory should use Container to instantiate actions and inject dependencies
[ https://issues.apache.org/jira/browse/WW-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724015#comment-16724015 ] Hudson commented on WW-4938: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #241 (See [https://builds.apache.org/job/Struts-master-JDK7/241/]) [WW-4938] Uses container to create an instance of the class (#295) (yasser.zamani: rev 699f5d6c79ec12978c6fa33ea4e8b5cef70c616f) * (edit) core/src/main/java/com/opensymphony/xwork2/ObjectFactory.java * (edit) plugins/convention/src/test/java/org/apache/struts2/convention/PackageBasedActionConfigBuilderTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/spring/SpringObjectFactory.java * (add) core/src/test/java/com/opensymphony/xwork2/mock/DummyTextProvider.java * (add) core/src/test/java/com/opensymphony/xwork2/mock/InjectableAction.java * (add) core/src/test/java/com/opensymphony/xwork2/ObjectFactoryTest.java > ObjectFactory should use Container to instantiate actions and inject > dependencies > -- > > Key: WW-4938 > URL: https://issues.apache.org/jira/browse/WW-4938 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.6 > > > It isn't possible to define an action with a constructor and annotated with > {{@Inject}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4989) Use JacksonXML handler instead of XStream as a default handler for XML in the REST plugin
[ https://issues.apache.org/jira/browse/WW-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721458#comment-16721458 ] Hudson commented on WW-4989: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #234 (See [https://builds.apache.org/job/Struts-master-JDK7/234/]) [WW-4989] Uses JacksonXML handler a default handler for XML in the REST (yasser.zamani: rev 85812fb9bbf1dc8358d0352157142ec3131e015b) * (delete) plugins/rest/src/main/java/org/apache/struts2/rest/handler/JacksonLibHandler.java * (add) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JacksonJsonHandlerTest.java * (edit) plugins/rest/src/main/resources/struts-plugin.xml * (delete) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JacksonLibHandlerTest.java * (add) plugins/rest/src/main/java/org/apache/struts2/rest/handler/JacksonJsonHandler.java > Use JacksonXML handler instead of XStream as a default handler for XML in the > REST plugin > - > > Key: WW-4989 > URL: https://issues.apache.org/jira/browse/WW-4989 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - REST >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > XStream library isn't actively developed but still maintained. Switching to > JacksonXML is just a matter of a simple change in struts.xml. Backward > compatibility will be kept by allowing users to use the existing XStream > handler as optional to JacksonXML. > https://struts.apache.org/plugins/rest/#custom-contenttypehandlers -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4992) Mark the Embedded JSP plugin as depracted
[ https://issues.apache.org/jira/browse/WW-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721333#comment-16721333 ] Hudson commented on WW-4992: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #233 (See [https://builds.apache.org/job/Struts-master-JDK7/233/]) WW-4992 Marks Embedded JSP plugin as deprecated (lukaszlenart: rev f4c8994da43fef66f9b56a610fe2b682e0fcb385) * (edit) plugins/embeddedjsp/pom.xml * (edit) bundles/pom.xml * (edit) plugins/pom.xml > Mark the Embedded JSP plugin as depracted > - > > Key: WW-4992 > URL: https://issues.apache.org/jira/browse/WW-4992 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - Embedded JSP >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > Servlet 3.0 spec supports embedding JSPs into JARs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4964) Missing javascript in form-validate.ftl
[ https://issues.apache.org/jira/browse/WW-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720587#comment-16720587 ] Hudson commented on WW-4964: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #231 (See [https://builds.apache.org/job/Struts-master-JDK7/231/]) WW-4964 Drops duplicated import of utils.js it should be already (lukaszlenart: rev 072cb725f27879b2695401080b3e730fbbe2a029) * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-2.txt * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-24.txt * (edit) core/src/main/resources/template/xhtml/form-validate.ftl * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-22.txt * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-11.txt > Missing javascript in form-validate.ftl > --- > > Key: WW-4964 > URL: https://issues.apache.org/jira/browse/WW-4964 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.17 >Reporter: nikos dimitrakas >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > There are two versions of form-validate.ftl, one in xhtml theme and one in > css_xhtml theme. The one in css_xhtml is missing the script tag for utils.js > (and also some special character cleaning). This causes the following error > on the client: > Uncaught ReferenceError: StrutsUtils is not defined > at validation.js:161 > (anonymous) @ validation.js:161 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4889) Implement REST content handlers using Apache Juneau
[ https://issues.apache.org/jira/browse/WW-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716625#comment-16716625 ] Hudson commented on WW-4889: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #224 (See [https://builds.apache.org/job/Struts-master-JDK7/224/]) WW-4889 Adds XML handler based on Apache Juneau (lukaszlenart: rev 629ce0d9aa1b95e1067aebc9d55bac686fe5cb4a) * (add) plugins/rest/src/main/java/org/apache/struts2/rest/handler/JuneauXmlHandler.java * (add) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JuneauXmlHandlerTest.java * (edit) plugins/rest/pom.xml * (edit) pom.xml WW-4889 Uses proper order of params in assertEquals (lukaszlenart: rev 314dcdb78094d0a28f2219e5635817b07e723f5c) * (edit) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JuneauXmlHandlerTest.java WW-4889 Uses .contains to avoid issues with serialisation order (lukaszlenart: rev 9d8edf5265864c4e0b858f8c764dee6a594d4f7b) * (edit) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JuneauXmlHandlerTest.java > Implement REST content handlers using Apache Juneau > --- > > Key: WW-4889 > URL: https://issues.apache.org/jira/browse/WW-4889 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - REST >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > The Apache Juneau http://juneau.apache.org/#marshall.html provides a list of > serializers that can be used instead of XStream library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4987) Setting Struts2 options Css Class
[ https://issues.apache.org/jira/browse/WW-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711202#comment-16711202 ] Hudson commented on WW-4987: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #223 (See [https://builds.apache.org/job/Struts-master-JDK7/223/]) WW-4987 Add listCssClass to optgroup tag (amashchenko: rev c0eafac042d3e4487824b1095e21ca306439fc6e) * (edit) core/src/main/java/org/apache/struts2/components/OptGroup.java * (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/OptGroupTag.java * (edit) core/src/main/resources/template/simple/optgroup.ftl * (edit) core/src/site/resources/tags/optgroup.html WW-4987 Add test for listCssClass in optgroup tag (amashchenko: rev 94210a02e73a32a0e20d111ac8270191ee2cb5d6) * (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/OptGroupTest.java * (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/OptGroup-8.txt > Setting Struts2 options Css Class > > > Key: WW-4987 > URL: https://issues.apache.org/jira/browse/WW-4987 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.5.17 >Reporter: Muhammad Salman >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6, 2.5.19 > > Attachments: optgroup.ftl, select.ftl, struts.log > > > Hi > I am working on an application that is built on struts 2.5.17. I have > {{}} tag with and . I am trying to add cssClass > to under . I am trying to add css class to using > listCssClass attribute of {{}} but it is not adding class to the > . Any help would be much appreciated. > Here is code from my JSP: > {code:xml} > cssStyle="width:250px;" title="templateDesc" cssClass="templateType" > onchange="adjustReportText()" name="templateID" listCssClass="templateType"> > status="stat"> > listValue="templateName" > > > > {code} > Initially we were working on struts 2.2.3 version and in that version, > cssClass attribute populates the CSS Class for , but in 2.5.17 > neither cssClass is populated class to nor listCssClass. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4983) Set private access modifier for HttpParameters.toMap
[ https://issues.apache.org/jira/browse/WW-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693148#comment-16693148 ] Hudson commented on WW-4983: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #214 (See [https://builds.apache.org/job/Struts-master-JDK7/214/]) WW-4983 Set private access modifier for HttpParameters.toMap (Sebastian.Peters: rev c10d62209d4ca6502e9d2f056a76a48102ed5e31) * (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java > Set private access modifier for HttpParameters.toMap > > > Key: WW-4983 > URL: https://issues.apache.org/jira/browse/WW-4983 > Project: Struts 2 > Issue Type: Task > Components: Core >Reporter: Sebastian Peters >Priority: Minor > Labels: easyfix, security > Fix For: 2.6 > > > As stated in WW-4710 by [~lukaszlenart] this method can be potentially > dangerous as it allows access to raw parameter values. It should only be used > internally. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4981) Add support for Java 11
[ https://issues.apache.org/jira/browse/WW-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691350#comment-16691350 ] Hudson commented on WW-4981: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #212 (See [https://builds.apache.org/job/Struts-master-JDK7/212/]) [WW-4981] Adds support for JDK11 (#270) (yasser.zamani: rev 2a60c1eee69f976a6e20f20add04cdc39b757ead) * (edit) core/src/test/java/org/apache/struts2/views/freemarker/FreemarkerThemeTemplateLoaderTest.java * (edit) plugins/rest/pom.xml * (edit) core/src/main/java/com/opensymphony/xwork2/util/ClassPathFinder.java * (edit) core/src/test/java/org/apache/struts2/conversion/UploadedFileConverterTest.java * (edit) plugins/json/pom.xml * (edit) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JacksonXmlHandlerTest.java * (edit) pom.xml * (edit) core/src/test/java/org/apache/struts2/TestUtils.java * (edit) core/src/test/java/com/opensymphony/xwork2/util/ClassPathFinderTest.java * (edit) .gitignore * (edit) plugins/bean-validation/pom.xml * (edit) plugins/json/src/test/java/org/apache/struts2/json/JSONValidationInterceptorTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/util/fs/JarEntryRevisionTest.java * (edit) .travis.yml * (edit) core/src/test/java/com/opensymphony/xwork2/util/AnnotationUtilsTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java * (edit) core/pom.xml * (edit) assembly/src/main/assembly/min-lib.xml * (edit) plugins/embeddedjsp/src/test/java/org/apache/struts2/EmbeddedJSPResultTest.java > Add support for Java 11 > --- > > Key: WW-4981 > URL: https://issues.apache.org/jira/browse/WW-4981 > Project: Struts 2 > Issue Type: Task > Components: Build Management > Environment: {{oraclejdk11, }}{{openjdk11, > [https://adoptopenjdk.net|https://adoptopenjdk.net/]}} >Reporter: Sebastian Peters >Priority: Critical > Fix For: 2.6 > > > Java 11 is the new LTS release and Java 9 and 10 are already EOL. > see [https://www.oracle.com/technetwork/java/javase/eol-135779.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4977) Fixing flaky test in Jsr168DispatcherTest and Jsr286DispatcherTest
[ https://issues.apache.org/jira/browse/WW-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690881#comment-16690881 ] Hudson commented on WW-4977: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #209 (See [https://builds.apache.org/job/Struts-master-JDK7/209/]) [WW-4977] Fixing flaky test in Jsr168DispatcherTest and (ordtesters: rev 2d4e26ff8ab727b625aa744235523729cbb74c5b) * (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/dispatcher/Jsr168DispatcherTest.java * (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/dispatcher/Jsr286DispatcherTest.java > Fixing flaky test in Jsr168DispatcherTest and Jsr286DispatcherTest > -- > > Key: WW-4977 > URL: https://issues.apache.org/jira/browse/WW-4977 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Portlet >Reporter: OrDTesters >Priority: Minor > Fix For: 2.6 > > > testRender_ok and testProcessAction_ok in Jsr168DispatcherTest have > test-order dependencies and fail when they are run after > testModeChangeUsingPortletWidgets. Similarly, testRender_ok and > testProcessAction_ok in Jsr286DispatcherTest also have this problem. > > These tests can be fixed by adding the entry > \{STRUTS_ALWAYS_SELECT_FULL_NAMESPACE=“true”} to initParams in > testModeChangeUsingPortletWidgets, as shown in the following pull request. > The fix will enable the tests in these classes to now pass in any order. > (*to be replaced with a link to pull request when a pull request is made*) > > Without the fix, the tests will get an error. More specifically, the error > from Jsr168DispatcherTest.testProcessAction_ok is shown below. Let me know if > you want to discuss more. > > {code:java} > org.jmock.core.DynamicMockError: mockActionProxyFactory: unexpected invocation > Invoked: mockActionProxyFactory.createActionProxy("", "testAction", null, > <{com.opensymphony.xwork2.dispatcher.HttpServletRequest=org.apache.struts2.dispatcher.StrutsRequestWrapper@6063f37, > application={viewNamespace=/view, > struts.mapper.alwaysSelectFullNamespace=true}, > com.opensymphony.xwork2.ActionContext.locale=en_US, > com.opensymphony.xwork2.dispatcher.HttpServletResponse=org.apache.struts2.portlet.servlet.PortletServletResponse@42036f8, > struts.portlet.modeActionMap={help=ActionMapping{name='default', > namespace='', method='null', extension='null', params={}, result=null}, > preview=ActionMapping{name='default', namespace='', method='null', > extension='null', params={}, result=null}, edit=ActionMapping{name='default', > namespace='', method='null', extension='null', params={}, result=null}, > about=ActionMapping{name='default', namespace='', method='null', > extension='null', params={}, result=null}, > edit_defaults=ActionMapping{name='default', namespace='', method='null', > extension='null', params={}, result=null}, > config=ActionMapping{name='default', namespace='', method='null', > extension='null', params={}, result=null}, view=ActionMapping{name='default', > namespace='/view', method='null', extension='null', params={}, result=null}, > print=ActionMapping{name='default', namespace='', method='null', > extension='null', params={}, result=null}}, struts.portlet.portletNamespace=, > struts.portlet.modeNamespaceMap={help=, preview=, edit=, about=, > edit_defaults=, config=, view=/view, print=}, > com.opensymphony.xwork2.ActionContext.application={viewNamespace=/view, > struts.mapper.alwaysSelectFullNamespace=true}, attr=AttributeMap {request={}, > session={}, application={viewNamespace=/view, > struts.mapper.alwaysSelectFullNamespace=true}}, struts.portlet.request=null, > com.opensymphony.xwork2.dispatcher.ServletContext=org.apache.struts2.portlet.servlet.PortletServletContext@5ef8d5e5, > struts.portlet.defaultActionForMode=ActionMapping{name='default', > namespace='/view', method='null', extension='null', params={}, result=null}, > struts.portlet.phase=ACTION_PHASE, > com.opensymphony.xwork2.ActionContext.session={}, > struts.portlet.context=null, session={}, request={}, > struts.portlet.config=null, > struts.actionMapping=ActionMapping{name='testAction', namespace='', > method='null', extension='action', params={}, result=null}, > parameters={struts.portlet.mode=[Ljava.lang.String;@22a2de19, > struts.portlet.action=[Ljava.lang.String;@72a34d12}, > com.opensymphony.xwork2.ActionContext.parameters={struts.portlet.mode=view, > struts.portlet.action=/view/testAction}, > struts.portlet.response=mockActionResponse}>) > Allowed: > expected once: createActionProxy( eq("/view"), eq("testAction"), null, an > instance of java.util.Map ), returns > {code} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4982) Remove the deprecated JsonLibHandler and outdated json-lib dependency
[ https://issues.apache.org/jira/browse/WW-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690864#comment-16690864 ] Hudson commented on WW-4982: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #208 (See [https://builds.apache.org/job/Struts-master-JDK7/208/]) WW-4982 Remove the deprecated JsonLibHandler and json-lib dependency (Sebastian.Peters: rev 26dc995866c70e9c82c60c602f9704407a98c9c3) * (edit) pom.xml * (delete) plugins/rest/src/test/java/org/apache/struts2/rest/handler/JsonLibHandlerTest.java * (edit) assembly/src/main/resources/NOTICE.txt * (edit) plugins/rest/pom.xml * (edit) plugins/rest/src/main/resources/NOTICE.txt * (delete) plugins/rest/src/main/java/org/apache/struts2/rest/handler/JsonLibHandler.java > Remove the deprecated JsonLibHandler and outdated json-lib dependency > - > > Key: WW-4982 > URL: https://issues.apache.org/jira/browse/WW-4982 > Project: Struts 2 > Issue Type: Task > Components: Plugin - REST >Reporter: Sebastian Peters >Priority: Trivial > Fix For: 2.6 > > > JsonLibHandler has been deprecated with WW-4892 in version > [2.5.14.1|https://issues.apache.org/jira/issues/?jql=project+%3D+WW+AND+fixVersion+%3D+2.5.14.1] > and could be removed for 2.6. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4930) SMI cannot be diasabled for action-packages found via the convention-plugin
[ https://issues.apache.org/jira/browse/WW-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688221#comment-16688221 ] Hudson commented on WW-4930: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #205 (See [https://builds.apache.org/job/Struts-master-JDK7/205/]) WW-4930 Add constant to enable smi inheritance between parent package (p.heidelbach: rev 38b96b11fe043a6892108b28d0758a9f0d4533e8) * (edit) plugins/convention/src/main/java/org/apache/struts2/convention/ConventionConstants.java * (edit) plugins/convention/src/test/java/org/apache/struts2/convention/PackageBasedActionConfigBuilderTest.java * (edit) plugins/convention/src/main/resources/struts-plugin.xml * (edit) plugins/convention/src/main/java/org/apache/struts2/convention/PackageBasedActionConfigBuilder.java * (edit) plugins/convention/src/main/java/org/apache/struts2/convention/config/entities/ConventionConstantConfig.java WW-4930 Add test run with enabled SMI inheritance (p.heidelbach: rev 8b4755dc4964226762398567e4c6aa6fda9a072f) * (edit) plugins/convention/src/test/java/org/apache/struts2/convention/PackageBasedActionConfigBuilderTest.java > SMI cannot be diasabled for action-packages found via the convention-plugin > --- > > Key: WW-4930 > URL: https://issues.apache.org/jira/browse/WW-4930 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Convention >Affects Versions: 2.5.16 > Environment: Windows 10 > Java 1.8 >Reporter: Philipp Heidelbach >Priority: Major > Fix For: 2.6 > > > I'm trying to update Struts 2.3.34 to 2.5.16 and disabling SMI doesn't seem > to work. > I debuged XmlConfigurationProvider but in the packageConfig of our package > (named default see below) SMI is correctly set to false. Debugging > PackageBaseActionConfigBuilder shows that our default-package is used as > parent package and in the parentPkg SMI is set to false. The pkgConfig > however is alwasy null (line: 1043) and so a new package config is created in > which SMI is set to true. > Thus for all these actions methods i get the error that these methods aren't > allowed. > If I use @AllowedMethod-annotations it works fine. > Below the beginning of our struts.xml > {code:xml} > > "-//Apache Software Foundation//DTD Struts Configuration 2.5//EN" > "http://struts.apache.org/dtds/struts-2.5.dtd";> > > > value="jar,zip,vfsfile,vfszip" /> > value=".*/newd[-.\w]*\.jar(!/)?" /> > value="org.apache.struts.*,org.apache.struts2.*,org.springframework.web.struts.*,org.springframework.web.struts2.*,org.hibernate.*" > /> > > value="applicationResources" /> > > > > > > > > > strict-method-invocation="false"> > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4952) Upgrade to apache-master version 21
[ https://issues.apache.org/jira/browse/WW-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687592#comment-16687592 ] Hudson commented on WW-4952: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #204 (See [https://builds.apache.org/job/Struts-master-JDK7/204/]) WW-4952 Uses the latest struts-master pom in bom as well (lukaszlenart: rev 4df1e965bcc1dc57246201973c7b729bf55a3ae9) * (edit) bom/pom.xml > Upgrade to apache-master version 21 > --- > > Key: WW-4952 > URL: https://issues.apache.org/jira/browse/WW-4952 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Blocker > Fix For: 2.6 > > > We must use the latest {{apache parent pom}} to support generating {{sha256}} > signatures during release process. It is related to WW-4951 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4866) ASM 5.2 and Java 9 leads to IllegalArgumentException
[ https://issues.apache.org/jira/browse/WW-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682870#comment-16682870 ] Hudson commented on WW-4866: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #200 (See [https://builds.apache.org/job/Struts-master-JDK7/200/]) WW-4866 Includes 9+ JDKs (lukaszlenart: rev af3ee0747410ffb64448e933888ff4a15d72fe10) * (edit) pom.xml > ASM 5.2 and Java 9 leads to IllegalArgumentException > > > Key: WW-4866 > URL: https://issues.apache.org/jira/browse/WW-4866 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Convention >Affects Versions: 2.5.13 > Environment: Java 9 >Reporter: Michael Hintenaus >Assignee: Lukasz Lenart >Priority: Critical > Fix For: 2.6 > > > With ASM 5.2 and Java 9 I will get the following Stacktrace: > {noformat} > java.lang.IllegalArgumentException > at org.objectweb.asm.ClassReader.(Unknown Source) > at org.objectweb.asm.ClassReader.(Unknown Source) > at org.objectweb.asm.ClassReader.(Unknown Source) > at > org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:461) > at > org.apache.struts2.convention.DefaultClassFinder.access$200(DefaultClassFinder.java:52) > at > org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.extractSuperInterfaces(DefaultClassFinder.java:514) > at > org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.visit(DefaultClassFinder.java:501) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at > org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:462) > at > org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:93) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:395) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:377) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:333) > at > org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:52) > at > com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:198) > at > com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:63) > at > org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960) > at > org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:466) > at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:499) > at > org.apache.struts2.util.StrutsTestCaseHelper.initDispatcher(StrutsTestCaseHelper.java:47) > at > org.apache.struts2.StrutsJUnit4TestCase.initDispatcher(StrutsJUnit4TestCase.java:247) > at > org.apache.struts2.StrutsJUnit4TestCase.setUp(StrutsJUnit4TestCase.java:236) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4866) ASM 5.2 and Java 9 leads to IllegalArgumentException
[ https://issues.apache.org/jira/browse/WW-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682805#comment-16682805 ] Hudson commented on WW-4866: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #199 (See [https://builds.apache.org/job/Struts-master-JDK7/199/]) WW-4866 Includes 1.8+ JDKs (lukaszlenart: rev 2d86cc69dcfcddce1559362de8f776f0de721d65) * (edit) pom.xml > ASM 5.2 and Java 9 leads to IllegalArgumentException > > > Key: WW-4866 > URL: https://issues.apache.org/jira/browse/WW-4866 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Convention >Affects Versions: 2.5.13 > Environment: Java 9 >Reporter: Michael Hintenaus >Assignee: Lukasz Lenart >Priority: Critical > Fix For: 2.6 > > > With ASM 5.2 and Java 9 I will get the following Stacktrace: > {noformat} > java.lang.IllegalArgumentException > at org.objectweb.asm.ClassReader.(Unknown Source) > at org.objectweb.asm.ClassReader.(Unknown Source) > at org.objectweb.asm.ClassReader.(Unknown Source) > at > org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:461) > at > org.apache.struts2.convention.DefaultClassFinder.access$200(DefaultClassFinder.java:52) > at > org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.extractSuperInterfaces(DefaultClassFinder.java:514) > at > org.apache.struts2.convention.DefaultClassFinder$InfoBuildingVisitor.visit(DefaultClassFinder.java:501) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at org.objectweb.asm.ClassReader.accept(Unknown Source) > at > org.apache.struts2.convention.DefaultClassFinder.readClassDef(DefaultClassFinder.java:462) > at > org.apache.struts2.convention.DefaultClassFinder.(DefaultClassFinder.java:93) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:395) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:377) > at > org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:333) > at > org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:52) > at > com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:198) > at > com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:63) > at > org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:960) > at > org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:466) > at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:499) > at > org.apache.struts2.util.StrutsTestCaseHelper.initDispatcher(StrutsTestCaseHelper.java:47) > at > org.apache.struts2.StrutsJUnit4TestCase.initDispatcher(StrutsJUnit4TestCase.java:247) > at > org.apache.struts2.StrutsJUnit4TestCase.setUp(StrutsJUnit4TestCase.java:236) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4976) Upgrade ASM to version 7.0
[ https://issues.apache.org/jira/browse/WW-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682782#comment-16682782 ] Hudson commented on WW-4976: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #198 (See [https://builds.apache.org/job/Struts-master-JDK7/198/]) WW-4976 Upgrades ASM to version 7.0 (lukaszlenart: rev 518854a08565c894a18168db136c9f3b8f99) * (edit) pom.xml > Upgrade ASM to version 7.0 > -- > > Key: WW-4976 > URL: https://issues.apache.org/jira/browse/WW-4976 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > This version supports JDK11 > https://asm.ow2.io/versions.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4971) s:include tag fails with truncated content in certain circumstances
[ https://issues.apache.org/jira/browse/WW-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672151#comment-16672151 ] Hudson commented on WW-4971: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #195 (See [https://builds.apache.org/job/Struts-master-JDK7/195/]) WW-4971 Use response encoding for include by default (amashchenko: rev 9fd8d6fa8019e7a15ee3dfb9fba17aca36ff0b20) * (edit) core/src/main/java/org/apache/struts2/components/Include.java > s:include tag fails with truncated content in certain circumstances > --- > > Key: WW-4971 > URL: https://issues.apache.org/jira/browse/WW-4971 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 2.3.36, 2.5.18 > Environment: Windows 10, Java 7/8 (but issue isn't environment > specific) >Reporter: James Chaplin >Priority: Major > Fix For: 2.6, 2.5.19 > > Attachments: WW4791_Reproducer.war > > > Hello Apache Struts Team. > There is an issue with the Struts include tag (s:include) when processing > includes on a page that isn't using UTF-8 encoding (e.g. ISO-8859-1 or > Windows-1252 page encoding). > In some circumstances the s:include tag results in truncated content from the > child page (i.e. the parent page including the child page via s:include > experiences incomplete rendering of the included content). This happens when > the included page contains certain characters (e.g. 'ç') in a non-UTF8 > encoding (whether directly or from a resource bundle). > There are no warnings produced in the logs (even in debug mode), so the issue > can only be detected visually when things fail. > Changing all the content to UTF-8 is a workaround, but that is not feasible > in all circumstances. Given the preceding and the lack of warnings I'm > initially submitting it as a major priority. > I will attempt to submit a bugfix for consideration shortly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4973) Upgrade to OGNL 3.2.8
[ https://issues.apache.org/jira/browse/WW-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670088#comment-16670088 ] Hudson commented on WW-4973: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #194 (See [https://builds.apache.org/job/Struts-master-JDK7/194/]) [WW-4973] Upgrades to OGNL 3.2.8 (#258) (yasser.zamani: rev b82db24fb66dc7b956d5b87c979335292ad7911f) * (edit) pom.xml * (edit) core/src/main/java/com/opensymphony/xwork2/util/ProxyUtil.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/SecurityMemberAccessTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java * (edit) core/src/test/java/com/opensymphony/xwork2/spring/SpringProxyUtilTest.java > Upgrade to OGNL 3.2.8 > - > > Key: WW-4973 > URL: https://issues.apache.org/jira/browse/WW-4973 > Project: Struts 2 > Issue Type: Dependency >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > > https://github.com/jkuhnert/ognl/blob/master/docs/VersionNotes.md#release-notes---version-3119-328 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4963) Implement new Aware interfaces that are using withXxxx pattern instead of setters
[ https://issues.apache.org/jira/browse/WW-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658881#comment-16658881 ] Hudson commented on WW-4963: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #193 (See [https://builds.apache.org/job/Struts-master-JDK7/193/]) WW-4963 Implements new SessionAware interface that uses withSession (lukaszlenart: rev d38efae5f09776e45dd0e0faaa8bf1cf2ab04dad) * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java * (edit) core/src/main/java/org/apache/struts2/interceptor/SessionAware.java * (add) core/src/main/java/org/apache/struts2/action/SessionAware.java WW-4963 Implements new ServletRequestAware interface that uses (lukaszlenart: rev 3820eae31f9db2016ac8d9576ed2346cda41fc9b) * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletRequestAware.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java * (add) core/src/main/java/org/apache/struts2/action/ServletRequestAware.java WW-4963 Implements new ServletResponseAware interface that uses (lukaszlenart: rev e0fb8031ce99dcb893dbc0b223845235eca7721a) * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java * (add) core/src/main/java/org/apache/struts2/action/ServletResponseAware.java * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletResponseAware.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java WW-4963 Implements new ApplicationAware interface that uses (lukaszlenart: rev dc7138ee2ea42194ee51cc886b1598021d536f0f) * (edit) core/src/main/java/org/apache/struts2/interceptor/ApplicationAware.java * (add) core/src/main/java/org/apache/struts2/action/ApplicationAware.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java WW-4963 Implements new PrincipalAware interface that uses (lukaszlenart: rev 384d418039998db6957b49cec806a7a0b2fd03a7) * (edit) core/src/main/java/org/apache/struts2/interceptor/PrincipalAware.java * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ServletConfigInterceptorTest.java * (add) core/src/main/java/org/apache/struts2/action/PrincipalAware.java * (edit) core/src/main/java/org/apache/struts2/interceptor/ServletConfigInterceptor.java WW-4963 Implements new BundleContextAware interface that uses (lukaszlenart: rev 01016b458e7af42b8f645fa6d35c6e929e3fa4c0) * (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/OsgiInterceptor.java * (edit) plugins/osgi/src/test/java/org/apache/struts2/osgi/interceptor/OsgiInterceptorTest.java * (edit) bundles/demo/src/main/java/actions/osgi/BundlesAction.java * (add) plugins/osgi/src/main/java/org/apache/struts2/osgi/action/BundleContextAware.java * (edit) plugins/osgi/src/main/java/org/apache/struts2/osgi/interceptor/BundleContextAware.java WW-4963 Implements new CookiesAware interface that uses withCookies (lukaszlenart: rev 23e9c88135116e420348b2f9867a81f0de2c63e6) * (add) core/src/main/java/org/apache/struts2/action/CookiesAware.java * (edit) core/src/main/java/org/apache/struts2/interceptor/CookieInterceptor.java * (edit) core/src/main/java/org/apache/struts2/interceptor/CookiesAware.java * (edit) core/src/test/java/org/apache/struts2/interceptor/CookieInterceptorTest.java WW-4963 Implements new PortletContextAware interface that uses (lukaszlenart: rev 42245be546c8f8db57ca1b129022ed5a5c05ae89) * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletContextAware.java * (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletContextAware.java * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java WW-4963 Implements new PortletPreferencesAware interface that uses (lukaszlenart: rev f59860026c890f0e2dcc3edea8a41f0e989027f9) * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptor.java * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/interceptor/PortletPreferencesAware.java * (add) plugins/portlet/src/main/java/org/apache/struts2/portlet/action/PortletPreferencesAware.java WW-4963 Implements new PortletRequestAware interface that uses (lukaszlenart: rev ec4a44567d6470ed1a9f457d857e8ce4ac4c3e09) * (edit) plugins/portlet/src/test/java/org/apache/struts2/portlet/interceptor/PortletAwareInterceptorTest.java * (edit) plugins/portlet/src/main/java/org/apache/struts2/portlet/in
[jira] [Commented] (WW-4965) Upgrade to OGNL 3.2.7
[ https://issues.apache.org/jira/browse/WW-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641444#comment-16641444 ] Hudson commented on WW-4965: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #191 (See [https://builds.apache.org/job/Struts-master-JDK7/191/]) WW-4965 Upgrades OGNL to version 3.2.7 (lukaszlenart: rev 2ab2b9b240083b2e1b5a85167198a178049d0f46) * (edit) pom.xml > Upgrade to OGNL 3.2.7 > - > > Key: WW-4965 > URL: https://issues.apache.org/jira/browse/WW-4965 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4952) Upgrade to apache-master version 21
[ https://issues.apache.org/jira/browse/WW-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641084#comment-16641084 ] Hudson commented on WW-4952: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #189 (See [https://builds.apache.org/job/Struts-master-JDK7/189/]) WW-4952 Uses struts parent 13 to fix issue with wrong release profile (lukaszlenart: rev 13d9053050c9e4fb2ef049db6a37d3f6eebf48fa) * (edit) pom.xml > Upgrade to apache-master version 21 > --- > > Key: WW-4952 > URL: https://issues.apache.org/jira/browse/WW-4952 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Blocker > Fix For: 2.6 > > > We must use the latest {{apache parent pom}} to support generating {{sha256}} > signatures during release process. It is related to WW-4951 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4952) Upgrade to apache-master version 21
[ https://issues.apache.org/jira/browse/WW-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637908#comment-16637908 ] Hudson commented on WW-4952: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #159 (See [https://builds.apache.org/job/Struts-master-JDK7/159/]) WW-4952 Uses struts parent 13 to fix issue with wrong release profile (lukaszlenart: rev 13d9053050c9e4fb2ef049db6a37d3f6eebf48fa) * (edit) pom.xml > Upgrade to apache-master version 21 > --- > > Key: WW-4952 > URL: https://issues.apache.org/jira/browse/WW-4952 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Blocker > Fix For: 2.6 > > > We must use the latest {{apache parent pom}} to support generating {{sha256}} > signatures during release process. It is related to WW-4951 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4951) MD5 and SHA1 should no longer be provided on download pages
[ https://issues.apache.org/jira/browse/WW-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618662#comment-16618662 ] Hudson commented on WW-4951: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #146 (See [https://builds.apache.org/job/Struts-master-JDK7/146/]) WW-4951 Upgrades to the latest struts master to support SHA256/512 (lukaszlenart: rev 3e29573a2e5ddf7b948ebe622a01d0fbc20a0b5b) * (edit) assembly/pom.xml * (edit) assembly/src/main/resources/docs-urls.txt * (edit) pom.xml > MD5 and SHA1 should no longer be provided on download pages > > > Key: WW-4951 > URL: https://issues.apache.org/jira/browse/WW-4951 > Project: Struts 2 > Issue Type: Bug >Reporter: Sebb >Priority: Major > Fix For: 2.6, 2.3.36, 2.5.18 > > > As the subject says: > MD5 and SHA1 are deprecated and should no longer be provided on download > pages: > http://www.apache.org/dev/release-distribution#sigs-and-sums -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4954) xml-validation fails since struts 2.5.17
[ https://issues.apache.org/jira/browse/WW-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603388#comment-16603388 ] Hudson commented on WW-4954: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #142 (See [https://builds.apache.org/job/Struts-master-JDK7/142/]) WW-4954 Moves XWorkList out of util package (lukaszlenart: rev f523a341d474eddbc6c941ddbb1d843c743603ca) * (delete) core/src/test/java/com/opensymphony/xwork2/util/XWorkListTest.java * (add) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkListTest.java * (delete) core/src/main/java/com/opensymphony/xwork2/util/XWorkList.java * (add) core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkList.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/CollectionConverter.java > xml-validation fails since struts 2.5.17 > > > Key: WW-4954 > URL: https://issues.apache.org/jira/browse/WW-4954 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.17 >Reporter: Fechner >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.36, 2.5.18 > > Attachments: KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml.alt, KundenAction.java, > ValidatorArrayListSize.java, ValidatorArrayListSize.java, > email_festnetz_email-arrayListStringeSize_festnetz-arrayListStringeSize_otherinvalideValues.png, > email_festnetz_email-arrayListStringeSize_festnetz-fieldexpression.png, > email_festnetz_email-fieldexpression_festnetz-fieldexpression.png, > kundenNeuanlegenAdresse.jspf, kundenVerwaltung.xml, > mitarbeiterVerwaltung.xml, produktVerwaltung.xml, struts.xml > > > xml-Validation of "s:optiontransferselect" and "s:inputtransferselect" fails > since version 2.5.17. > Until version 2.5.16 xml-validation works fine. > Example : > inputtransferselect: > {code:xml} > label="%\{getText('adresse.email')}" > > name="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > > list="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > id="eingabeEmailAdresseKuAnschrift" > cssClass="inputoptionselect" > addLabel="%\{getText('add')}" > removeLabel="%\{getText('remove')}" > removeAllLabel="%\{getText('removeAll')}" > buttonCssClass="navibutton" > allowUpDown="false" > requiredLabel="true" > > tooltip="%\{getText('tooltip.adresse.email')}" > tooltipIconPath="/images/question.gif" > /> > {code} > {code} > "../../../../xwork-validator-1.0.3.dtd"> > > > > > > > > > > > > > > > > {code} > optiontransferselect: > {code:xml} > > id="idListe" > label="%\{getText('pk.klasse.gebiet')}" > name="idListe" > leftTitle="%\{getText('produkt.ag.links')}" > rightTitle="%\{getText('produkt.ag.rechts')}" > list="%\{#session.listeLinks}" > listKey="id" > listValue="anzeige" > multiple="true" > size="15" > cssClass="input_text" > requiredLabel="true" > > buttonCssClass="navibutton" > allowSelectAll="false" > allowUpDownOnLeft="false" > allowUpDownOnRight="false" > allowAddAllToLeft="false" > allowAddAllToRight="false" > addToLeftLabel="%\{getText('remove')}" > addToRightLabel="%\{getText('add')}" > doubleList="%\{#session.listeRechts}" > doubleListKey="id" > doubleListValue="anzeige" > doubleName="selectedIdListe" > doubleSize="15" > doubleCssClass="input_text" > /> > {code} > I hope You can helb > Best regards > Siegfried Fechner > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4954) xml-validation fails since struts 2.5.17
[ https://issues.apache.org/jira/browse/WW-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601808#comment-16601808 ] Hudson commented on WW-4954: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #141 (See [https://builds.apache.org/job/Struts-master-JDK7/141/]) Better logging message (for WW-4954) (amashchenko: rev b213d58f54d3bc89b21726d441325202ef99628d) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java > xml-validation fails since struts 2.5.17 > > > Key: WW-4954 > URL: https://issues.apache.org/jira/browse/WW-4954 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.17 >Reporter: Fechner >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.36, 2.5.18 > > Attachments: KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml.alt, KundenAction.java, > ValidatorArrayListSize.java, ValidatorArrayListSize.java, > email_festnetz_email-arrayListStringeSize_festnetz-arrayListStringeSize_otherinvalideValues.png, > email_festnetz_email-arrayListStringeSize_festnetz-fieldexpression.png, > email_festnetz_email-fieldexpression_festnetz-fieldexpression.png, > kundenNeuanlegenAdresse.jspf, kundenVerwaltung.xml, > mitarbeiterVerwaltung.xml, produktVerwaltung.xml, struts.xml > > > xml-Validation of "s:optiontransferselect" and "s:inputtransferselect" fails > since version 2.5.17. > Until version 2.5.16 xml-validation works fine. > Example : > inputtransferselect: > {code:xml} > label="%\{getText('adresse.email')}" > > name="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > > list="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > id="eingabeEmailAdresseKuAnschrift" > cssClass="inputoptionselect" > addLabel="%\{getText('add')}" > removeLabel="%\{getText('remove')}" > removeAllLabel="%\{getText('removeAll')}" > buttonCssClass="navibutton" > allowUpDown="false" > requiredLabel="true" > > tooltip="%\{getText('tooltip.adresse.email')}" > tooltipIconPath="/images/question.gif" > /> > {code} > {code} > "../../../../xwork-validator-1.0.3.dtd"> > > > > > > > > > > > > > > > > {code} > optiontransferselect: > {code:xml} > > id="idListe" > label="%\{getText('pk.klasse.gebiet')}" > name="idListe" > leftTitle="%\{getText('produkt.ag.links')}" > rightTitle="%\{getText('produkt.ag.rechts')}" > list="%\{#session.listeLinks}" > listKey="id" > listValue="anzeige" > multiple="true" > size="15" > cssClass="input_text" > requiredLabel="true" > > buttonCssClass="navibutton" > allowSelectAll="false" > allowUpDownOnLeft="false" > allowUpDownOnRight="false" > allowAddAllToLeft="false" > allowAddAllToRight="false" > addToLeftLabel="%\{getText('remove')}" > addToRightLabel="%\{getText('add')}" > doubleList="%\{#session.listeRechts}" > doubleListKey="id" > doubleListValue="anzeige" > doubleName="selectedIdListe" > doubleSize="15" > doubleCssClass="input_text" > /> > {code} > I hope You can helb > Best regards > Siegfried Fechner > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4956) Upgrade to Log4j2 2.11.1
[ https://issues.apache.org/jira/browse/WW-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601654#comment-16601654 ] Hudson commented on WW-4956: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #139 (See [https://builds.apache.org/job/Struts-master-JDK7/139/]) WW-4956 Upgrade to Log4j2 2.11.1 (amashchenko: rev fd63512318adc5cbc1f5d627e4ae0f7f257649ce) * (edit) pom.xml > Upgrade to Log4j2 2.11.1 > > > Key: WW-4956 > URL: https://issues.apache.org/jira/browse/WW-4956 > Project: Struts 2 > Issue Type: Dependency >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4954) xml-validation fails since struts 2.5.17
[ https://issues.apache.org/jira/browse/WW-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598648#comment-16598648 ] Hudson commented on WW-4954: SUCCESS: Integrated in Jenkins build Struts-2-3-JDK6 #17 (See [https://builds.apache.org/job/Struts-2-3-JDK6/17/]) WW-4954 Moves XWorkList out of the util package (lukaszlenart: rev 458acb89e597b905835760255433fc4580c83dad) * (add) xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkList.java * (delete) xwork-core/src/test/java/com/opensymphony/xwork2/util/XWorkListTest.java * (add) xwork-core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkListTest.java * (edit) xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/CollectionConverter.java * (delete) xwork-core/src/main/java/com/opensymphony/xwork2/util/XWorkList.java > xml-validation fails since struts 2.5.17 > > > Key: WW-4954 > URL: https://issues.apache.org/jira/browse/WW-4954 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.17 >Reporter: Fechner >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.36, 2.5.18 > > Attachments: KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml.alt, KundenAction.java, > ValidatorArrayListSize.java, ValidatorArrayListSize.java, > email_festnetz_email-arrayListStringeSize_festnetz-arrayListStringeSize_otherinvalideValues.png, > email_festnetz_email-arrayListStringeSize_festnetz-fieldexpression.png, > email_festnetz_email-fieldexpression_festnetz-fieldexpression.png, > kundenNeuanlegenAdresse.jspf, kundenVerwaltung.xml, > mitarbeiterVerwaltung.xml, produktVerwaltung.xml, struts.xml > > > xml-Validation of "s:optiontransferselect" and "s:inputtransferselect" fails > since version 2.5.17. > Until version 2.5.16 xml-validation works fine. > Example : > inputtransferselect: > {code:xml} > label="%\{getText('adresse.email')}" > > name="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > > list="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > id="eingabeEmailAdresseKuAnschrift" > cssClass="inputoptionselect" > addLabel="%\{getText('add')}" > removeLabel="%\{getText('remove')}" > removeAllLabel="%\{getText('removeAll')}" > buttonCssClass="navibutton" > allowUpDown="false" > requiredLabel="true" > > tooltip="%\{getText('tooltip.adresse.email')}" > tooltipIconPath="/images/question.gif" > /> > {code} > {code} > "../../../../xwork-validator-1.0.3.dtd"> > > > > > > > > > > > > > > > > {code} > optiontransferselect: > {code:xml} > > id="idListe" > label="%\{getText('pk.klasse.gebiet')}" > name="idListe" > leftTitle="%\{getText('produkt.ag.links')}" > rightTitle="%\{getText('produkt.ag.rechts')}" > list="%\{#session.listeLinks}" > listKey="id" > listValue="anzeige" > multiple="true" > size="15" > cssClass="input_text" > requiredLabel="true" > > buttonCssClass="navibutton" > allowSelectAll="false" > allowUpDownOnLeft="false" > allowUpDownOnRight="false" > allowAddAllToLeft="false" > allowAddAllToRight="false" > addToLeftLabel="%\{getText('remove')}" > addToRightLabel="%\{getText('add')}" > doubleList="%\{#session.listeRechts}" > doubleListKey="id" > doubleListValue="anzeige" > doubleName="selectedIdListe" > doubleSize="15" > doubleCssClass="input_text" > /> > {code} > I hope You can helb > Best regards > Siegfried Fechner > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4954) xml-validation fails since struts 2.5.17
[ https://issues.apache.org/jira/browse/WW-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598133#comment-16598133 ] Hudson commented on WW-4954: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #138 (See [https://builds.apache.org/job/Struts-master-JDK7/138/]) WW-4954 Adds a test case to cover accessing ArrayList (lukaszlenart: rev 6420f4068f8ddbc54c022fb57d3bed881934b6a6) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilStrutsTest.java * (add) core/src/test/java/com/opensymphony/xwork2/test/TestArrayBean.java > xml-validation fails since struts 2.5.17 > > > Key: WW-4954 > URL: https://issues.apache.org/jira/browse/WW-4954 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.17 >Reporter: Fechner >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.6, 2.3.36, 2.5.18 > > Attachments: KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml, > KundenAction-kundenAdrUebernehmen-validation.xml.alt, KundenAction.java, > ValidatorArrayListSize.java, ValidatorArrayListSize.java, > email_festnetz_email-arrayListStringeSize_festnetz-arrayListStringeSize_otherinvalideValues.png, > email_festnetz_email-arrayListStringeSize_festnetz-fieldexpression.png, > email_festnetz_email-fieldexpression_festnetz-fieldexpression.png, > kundenNeuanlegenAdresse.jspf, kundenVerwaltung.xml, > mitarbeiterVerwaltung.xml, produktVerwaltung.xml, struts.xml > > > xml-Validation of "s:optiontransferselect" and "s:inputtransferselect" fails > since version 2.5.17. > Until version 2.5.16 xml-validation works fine. > Example : > inputtransferselect: > {code:xml} > label="%\{getText('adresse.email')}" > > name="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > > list="kuAnschrift.kontaktMittel.eingabeEmailAdresse" > id="eingabeEmailAdresseKuAnschrift" > cssClass="inputoptionselect" > addLabel="%\{getText('add')}" > removeLabel="%\{getText('remove')}" > removeAllLabel="%\{getText('removeAll')}" > buttonCssClass="navibutton" > allowUpDown="false" > requiredLabel="true" > > tooltip="%\{getText('tooltip.adresse.email')}" > tooltipIconPath="/images/question.gif" > /> > {code} > {code} > "../../../../xwork-validator-1.0.3.dtd"> > > > > > > > > > > > > > > > > {code} > optiontransferselect: > {code:xml} > > id="idListe" > label="%\{getText('pk.klasse.gebiet')}" > name="idListe" > leftTitle="%\{getText('produkt.ag.links')}" > rightTitle="%\{getText('produkt.ag.rechts')}" > list="%\{#session.listeLinks}" > listKey="id" > listValue="anzeige" > multiple="true" > size="15" > cssClass="input_text" > requiredLabel="true" > > buttonCssClass="navibutton" > allowSelectAll="false" > allowUpDownOnLeft="false" > allowUpDownOnRight="false" > allowAddAllToLeft="false" > allowAddAllToRight="false" > addToLeftLabel="%\{getText('remove')}" > addToRightLabel="%\{getText('add')}" > doubleList="%\{#session.listeRechts}" > doubleListKey="id" > doubleListValue="anzeige" > doubleName="selectedIdListe" > doubleSize="15" > doubleCssClass="input_text" > /> > {code} > I hope You can helb > Best regards > Siegfried Fechner > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4955) Upgrade to OGNL 3.2.6
[ https://issues.apache.org/jira/browse/WW-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591361#comment-16591361 ] Hudson commented on WW-4955: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #135 (See [https://builds.apache.org/job/Struts-master-JDK7/135/]) WW-4955 Upgrades OGNL to version 3.2.6 (lukaszlenart: rev 6f4d6feee8411134ce42d66efac239f7a0e0c7c6) * (edit) pom.xml > Upgrade to OGNL 3.2.6 > - > > Key: WW-4955 > URL: https://issues.apache.org/jira/browse/WW-4955 > Project: Struts 2 > Issue Type: Dependency >Reporter: Lukasz Lenart >Priority: Major > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4952) Upgrade to apache-master version 21
[ https://issues.apache.org/jira/browse/WW-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589994#comment-16589994 ] Hudson commented on WW-4952: FAILURE: Integrated in Jenkins build Struts-master #2 (See [https://builds.apache.org/job/Struts-master/2/]) [WW-4952] Upgrades parent pom (#1) (yasser.zamani: rev 45cebb728bcdb86b120bed932d4a3c264bca1501) * (edit) pom.xml > Upgrade to apache-master version 21 > --- > > Key: WW-4952 > URL: https://issues.apache.org/jira/browse/WW-4952 > Project: Struts 2 > Issue Type: Improvement >Reporter: Lukasz Lenart >Priority: Blocker > Fix For: 2.6 > > > We must use the latest {{apache parent pom}} to support generating {{sha256}} > signatures during release process. It is related to WW-4951 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4769) Make SecurityMethodAccess excluded classes & packages definitions immutable
[ https://issues.apache.org/jira/browse/WW-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515517#comment-16515517 ] Hudson commented on WW-4769: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #130 (See [https://builds.apache.org/job/Struts-master-JDK7/130/]) WW-4769 add unit tests to verify immutable collections (ssullivan: rev 9c3f658debf7ee2570a10ff8d0f5d07f2f61a826) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java > Make SecurityMethodAccess excluded classes & packages definitions immutable > --- > > Key: WW-4769 > URL: https://issues.apache.org/jira/browse/WW-4769 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Affects Versions: 2.5.10 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.5.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4940) Corrupted error message with getText
[ https://issues.apache.org/jira/browse/WW-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501514#comment-16501514 ] Hudson commented on WW-4940: SUCCESS: Integrated in Jenkins build Struts-site #218 (See [https://builds.apache.org/job/Struts-site/218/]) WW-4940 Adds missing section about customising validation messages (lukaszlenart: rev cf6c8f50937c2b1411d19a3f14107c817497fbf8) * (edit) source/core-developers/validation.md > Corrupted error message with getText > > > Key: WW-4940 > URL: https://issues.apache.org/jira/browse/WW-4940 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.3.34 >Reporter: nitin pericherla >Priority: Major > > *Issue:* > The dev team is running into an issue randomly in Strut2 validation, the > broken getText() function is diplayed in error messages as shown below and > this happens randomly , it depends on number of error messages and sequence > the way the error is displayed , we found that by formating the XML in > certain way would reduce these instances but randomly another error message > will turn to "getText" So far we have not found the best way to avoid these. > , please check below for this issue > > Background: > During our migration from struts 1 to struts 2, we had to migrate STRUTS XML > Validation from struts1 to struts 2 validation as it has changed, Although > there are other ways but we used getText function to get the desired results > so we do not have to change how our error messages getting displayed. > Basically using the application resource file for getting column labels and > error message text. > > *Validation Error:- You must correct the following error(s) before > proceeding:* > * Error Message 1. > * Error Message 2. > * Error Message 3. > * *$\{getText("sample.col.samplefi* > * Error Message 4. > > > *O**riginal struts 1 XML validation is migrated to struts 2 in this following > way* > > > > > > > test > > > > > > > *Struts 2 XML Validation snippet* > > > true > > ${getText("errors.required",\{getText("sample.col.samplefield1")})} > > > > > > > > ${getText("errors.required",\{getText("sample.col.samplefield2")})} > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4940) Corrupted error message with getText
[ https://issues.apache.org/jira/browse/WW-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501483#comment-16501483 ] Hudson commented on WW-4940: SUCCESS: Integrated in Jenkins build Struts-examples-JDK8-master #72 (See [https://builds.apache.org/job/Struts-examples-JDK8-master/72/]) WW-4940 Adds an example app how to customise validation messages (lukaszlenart: rev 1c6ff24bb6d6e9c1aca4be48c1d59e85e47bea31) * (add) validation-messages/src/main/webapp/index.html * (add) validation-messages/src/main/webapp/WEB-INF/Login.jsp * (add) validation-messages/src/main/webapp/WEB-INF/web.xml * (add) validation-messages/src/main/webapp/WEB-INF/Menu.jsp * (add) validation-messages/src/main/resources/struts.xml * (add) validation-messages/src/main/resources/org/apache/struts/validation_messages/package.properties * (add) validation-messages/src/main/java/org/apache/struts/validation_messages/ExampleSupport.java * (edit) pom.xml * (add) validation-messages/src/main/java/org/apache/struts/validation_messages/Login.java * (add) validation-messages/src/main/webapp/WEB-INF/Missing.jsp * (add) validation-messages/pom.xml * (add) validation-messages/src/main/resources/org/apache/struts/validation_messages/Login-validation.xml * (add) validation-messages/src/main/resources/log4j2.xml * (add) validation-messages/src/main/resources/org/apache/struts/validation_messages/package_es.properties > Corrupted error message with getText > > > Key: WW-4940 > URL: https://issues.apache.org/jira/browse/WW-4940 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.3.34 >Reporter: nitin pericherla >Priority: Major > > *Issue:* > The dev team is running into an issue randomly in Strut2 validation, the > broken getText() function is diplayed in error messages as shown below and > this happens randomly , it depends on number of error messages and sequence > the way the error is displayed , we found that by formating the XML in > certain way would reduce these instances but randomly another error message > will turn to "getText" So far we have not found the best way to avoid these. > , please check below for this issue > > Background: > During our migration from struts 1 to struts 2, we had to migrate STRUTS XML > Validation from struts1 to struts 2 validation as it has changed, Although > there are other ways but we used getText function to get the desired results > so we do not have to change how our error messages getting displayed. > Basically using the application resource file for getting column labels and > error message text. > > *Validation Error:- You must correct the following error(s) before > proceeding:* > * Error Message 1. > * Error Message 2. > * Error Message 3. > * *$\{getText("sample.col.samplefi* > * Error Message 4. > > > *O**riginal struts 1 XML validation is migrated to struts 2 in this following > way* > > > > > > > test > > > > > > > *Struts 2 XML Validation snippet* > > > true > > ${getText("errors.required",\{getText("sample.col.samplefield1")})} > > > > > > > > ${getText("errors.required",\{getText("sample.col.samplefield2")})} > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4865) Struts s:checkbox conversion fails to List
[ https://issues.apache.org/jira/browse/WW-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412224#comment-16412224 ] Hudson commented on WW-4865: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #116 (See [https://builds.apache.org/job/Struts-master-JDK7/116/]) WW-4865 Change submitUnchecked type to Boolean (amashchenko: rev 8eced2493cd0a910cb843c9819997007f723c2e1) * (edit) core/src/main/resources/template/simple/checkbox.ftl * (edit) core/src/main/java/org/apache/struts2/components/Checkbox.java * (edit) core/src/site/resources/tags/checkbox.html > Struts s:checkbox conversion fails to List > --- > > Key: WW-4865 > URL: https://issues.apache.org/jira/browse/WW-4865 > Project: Struts 2 > Issue Type: Bug > Components: Core, Core Tags >Affects Versions: 2.5.13 >Reporter: Burton Rhodes >Priority: Minor > Fix For: 2.6 > > Original Estimate: 24h > Remaining Estimate: 24h > > Struts is not converted correctly to List when only one > checkbox element is present and checkbox is not checked. > [Given] > 1) Mapping s:checkbox to a List > 2) there is only one checkbox in the list > 3) the checkbox is not checked when the form is submitted. > [Result] > Input invalid > The issue is caused by the checkbox tag using the "submit unchecked values" > design pattern. As a result, the code base tries to convert the value of the > single unchecked element to false (rather than not setting any value of the > List). > Fix: Allow the developer to choose if the "submit unchecked values" is to be > implemented. Add a new parameter to the s:checkbox tag ("requiredValue"). > Default of requiredValue=true for backwards compatibility. When set to > false, no hidden input values will be displayed in the view. This > flexibility might be needed in other scenarios as well. > Pull Request: https://github.com/apache/struts/pull/169 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4928) Setting struts.devMode from system property not working as described
[ https://issues.apache.org/jira/browse/WW-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410899#comment-16410899 ] Hudson commented on WW-4928: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #115 (See [https://builds.apache.org/job/Struts-master-JDK7/115/]) WW-4928 Using the same default value delimiter for system properties (amashchenko: rev c3e5755fae584927060d3f4fb447c62fc9ea1bdc) * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java * (edit) core/src/test/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutorTest.java > Setting struts.devMode from system property not working as described > > > Key: WW-4928 > URL: https://issues.apache.org/jira/browse/WW-4928 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.14.1 > Environment: **Windows, Linux, Solaris >Reporter: Peter J Ford >Priority: Minor > Labels: documentation, easyfix > Fix For: 2.6 > > > According to > [http://struts.apache.org/core-developers/constant-configuration.html] the > struts.devMode setting can be read from environment strings or system > properties. This works correctly when setting from an environment string - > for example: > {{}} > However it does not work for system properties, such as setting > "-DstrutsDevMode=true" as a system property and this in struts.xml: > {{}} > Having dug through the source I found that this is to do with the way the > value substitutor is configured, and that using ":-" instead of ":" as the > separator string when using system properties will work: > {{}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4874) Asynchronous action method
[ https://issues.apache.org/jira/browse/WW-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406423#comment-16406423 ] Hudson commented on WW-4874: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #114 (See [https://builds.apache.org/job/Struts-master-JDK7/114/]) WW-4874 Introduces Servlet3 plugin by adding support for async action (yasser.zamani: rev 1c0976a8693519f03b3796215bb9140a3c3160fc) * (edit) plugins/pom.xml * (add) plugins/servlet3/src/main/java/org/apache/struts2/servlet3/async/AsyncAction.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/PrepareOperations.java * (add) core/src/main/java/com/opensymphony/xwork2/AsyncManager.java * (add) plugins/servlet3/src/main/java/org/apache/struts2/servlet3/async/Servlet3AsyncManager.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java * (add) plugins/servlet3/pom.xml * (edit) core/src/main/java/com/opensymphony/xwork2/DefaultActionInvocation.java * (add) plugins/servlet3/src/main/resources/struts-plugin.xml WW-4874 Refactors technology name, servlet3, to asset name, async (yasser.zamani: rev eaed709f1d314f02b3318667c434e5addc922154) * (edit) plugins/pom.xml * (add) plugins/async/src/main/java/org/apache/struts2/async/AsyncAction.java * (add) plugins/async/src/main/java/org/apache/struts2/async/DefaultAsyncManager.java * (add) plugins/async/src/main/resources/struts-plugin.xml * (add) plugins/async/pom.xml * (delete) plugins/servlet3/src/main/java/org/apache/struts2/servlet3/async/AsyncAction.java * (delete) plugins/servlet3/pom.xml * (delete) plugins/servlet3/src/main/java/org/apache/struts2/servlet3/async/Servlet3AsyncManager.java * (delete) plugins/servlet3/src/main/resources/struts-plugin.xml WW-4874 Adds unit tests (yasser.zamani: rev 4ac287abd7da73273b162b2dc203c3636e9cb44f) * (add) plugins/async/src/test/java/org/apache/struts2/async/DefaultAsyncManagerTest.java * (edit) core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java * (edit) plugins/async/pom.xml * (edit) core/src/test/java/com/opensymphony/xwork2/DefaultActionInvocationTest.java * (add) core/src/test/java/org/apache/struts2/dispatcher/PrepareOperationsTest.java WW-4874 Updates parent version (yasser.zamani: rev e65d77bae1757b7306bfac8deb38704335d43779) * (edit) plugins/async/src/main/java/org/apache/struts2/async/DefaultAsyncManager.java * (edit) core/src/main/java/com/opensymphony/xwork2/AsyncManager.java * (edit) plugins/async/src/main/java/org/apache/struts2/async/AsyncAction.java * (edit) plugins/async/pom.xml WW-4874 Renames local variable inv to invocation (yasserzamani: rev fb8f139b069dd32ccecf9abe6b4c110a666ca860) * (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java > Asynchronous action method > -- > > Key: WW-4874 > URL: https://issues.apache.org/jira/browse/WW-4874 > Project: Struts 2 > Issue Type: New Feature > Components: Core Actions, Dispatch Filter >Reporter: Yasser Zamani >Priority: Major > Labels: action, asynchronous > Fix For: 2.6 > > Original Estimate: 1,344h > Remaining Estimate: 1,344h > > User will be able to return {{java.util.concurrent.Callable}} in > their actions. Struts when sees such result, runs {{resultCode = > result.call();}} in it's own managed thread pool but exits from servlet's > main thread with a null result, i.e. gives back main thread to container and > leaves response open for concurrent processing. When {{resultCode = > result.call();}} returned, Struts calls > {{javax.servlet.AsyncContext.dispatch()}} and {{resumes request processing}} > within a container's thread servlet to generate the appropriate result for > user according to {{resultCode}}. > This adds better support for SLS (Short request processing, Long action > execution, Short response processing) via Servlet 3's Async API. > Support of other cases like SSL (e.g. a download server) or LLL(e.g. a video > converter server) is still open. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-685) Generic error message - Type Conversion Error Handling
[ https://issues.apache.org/jira/browse/WW-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401943#comment-16401943 ] Hudson commented on WW-685: --- SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #111 (See [https://builds.apache.org/job/Struts-master-JDK7/111/]) WW-685 Add class to hold conversion related data (amashchenko: rev 5b4ae03e7506c1a10640849ee21a4d79b57c4193) * (edit) core/src/test/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptorTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/ConversionErrorFieldValidator.java * (edit) core/src/test/java/org/apache/struts2/interceptor/StrutsConversionErrorInterceptorTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ActionSupportTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/ActionContextTest.java * (add) core/src/main/java/com/opensymphony/xwork2/conversion/impl/ConversionData.java * (edit) core/src/main/java/com/opensymphony/xwork2/ActionSupport.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/ConversionErrorFieldValidatorTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/RepopulateConversionErrorFieldValidatorSupportTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/AnnotationXWorkConverterTest.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/VisitorFieldValidatorTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/ActionContext.java WW-685 Add generic type conversion error message (amashchenko: rev 1b15cfdfc684cc9ff5027b6299e0b51fcbea516f) * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/AnnotationXWorkConverterTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/ConversionErrorFieldValidator.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkConverter.java WW-685 Add tests (amashchenko: rev 34979cf51e109173c91f03f20282108554938604) * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkConverterTest.java * (edit) core/src/test/resources/com/opensymphony/xwork2/SimpleAction.properties WW-685 Fix getText expression (amashchenko: rev 1fcd1aeacfc96b9fd4abfb24ecf6b0a8938445a7) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkConverter.java > Generic error message - Type Conversion Error Handling > -- > > Key: WW-685 > URL: https://issues.apache.org/jira/browse/WW-685 > Project: Struts 2 > Issue Type: Improvement >Reporter: Ricardo Lecheta >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > To change the default message "invalid field value for field "xxx"", > you can put this line in the Action.properties > > invalid.fieldvalue.[propertyName] > But will be useful if there is a way to do a generic custom message to any > type? For example a custom message for Dates, double, boolean, etc: > > invalid.fieldvalue.For_All_Dates=This is not a valid date. > I don´t know how to implement it, but could be like this: > > invalid.fieldvalue.java.lang.Integer=This is not a valid Number. > > invalid.fieldvalue.java.util.Date=This is not a valid Date. > - > I tried the following examples, but them doesn´t work: > invalid.fieldvalue.*=Invalid Date. > and > invalid.fieldvalue.[*]=Invalid Date. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4915) Replace deprecated commons-lang3 classes
[ https://issues.apache.org/jira/browse/WW-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401942#comment-16401942 ] Hudson commented on WW-4915: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #111 (See [https://builds.apache.org/job/Struts-master-JDK7/111/]) WW-4915 Replace deprecated commons-lang3 classes (add commons-text (amashchenko: rev 478945a0bd563a5586eccfa34fc033c0ba24168d) * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/RepopulateConversionErrorFieldValidatorSupport.java * (edit) core/src/main/java/org/apache/struts2/util/TextProviderHelper.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/Parameter.java * (edit) pom.xml * (edit) core/pom.xml * (edit) plugins/json/src/main/java/org/apache/struts2/json/JSONValidationInterceptor.java * (edit) core/src/main/java/org/apache/struts2/views/util/DefaultUrlHelper.java * (edit) apps/showcase/src/main/java/org/apache/struts2/showcase/model/Skill.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/Attributes.java * (edit) plugins/json/pom.xml * (edit) plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ActionNamesAction.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxHandler.java * (edit) core/src/main/java/com/opensymphony/xwork2/interceptor/ConversionErrorInterceptor.java * (edit) plugins/javatemplates/pom.xml * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/XHTMLTagSerializer.java * (edit) plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowConfigAction.java * (edit) core/src/main/java/com/opensymphony/xwork2/DefaultActionProxy.java * (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java WW-4915 Replace deprecated commons-lang3 classes (replace (amashchenko: rev eb6ea7656720650dcd54aa8739b7284cd46286c4) * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/EnvsValueSubstitutor.java WW-4915 Replace deprecated commons-lang3 classes (replace (amashchenko: rev dac624431ef42352cd5343a1a1a7275398ec45d4) * (edit) core/src/main/java/org/apache/struts2/components/Property.java * (edit) core/src/main/java/org/apache/struts2/components/Text.java > Replace deprecated commons-lang3 classes > > > Key: WW-4915 > URL: https://issues.apache.org/jira/browse/WW-4915 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > The Apache Commons Community has recently set up the Commons Text component > as a home for algorithms working on strings. For this reason most of the > string focused functionality in Commons Lang has been deprecated and moved to > Commons Text. This includes: > * All classes in the org.apache.commons.lang3.text and the > org.apache.commons.lang3.text.translate packages > * org.apache.commons.lang3.StringEscapeUtils > * org.apache.commons.lang3.RandomStringUtils > * The methods org.apache.commons.lang3.StringUtils.getJaroWinklerDistance > and org.apache.commons.lang3.StringUtils.getLevenshteinDistance > For more information see the Commons Text website: > http://commons.apache.org/text -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4875) Java configuration
[ https://issues.apache.org/jira/browse/WW-4875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401941#comment-16401941 ] Hudson commented on WW-4875: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #111 (See [https://builds.apache.org/job/Struts-master-JDK7/111/]) WW-4875 Add ability to use Java based configuration (amashchenko: rev 0a86e4fe1621bc0fdd01346aed94eab1f0ab920d) * (add) core/src/main/java/org/apache/struts2/config/StrutsJavaConfiguration.java * (add) core/src/main/java/org/apache/struts2/config/StrutsJavaConfigurationProvider.java * (add) core/src/main/java/org/apache/struts2/config/entities/BeanConfig.java * (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java * (add) core/src/main/java/org/apache/struts2/config/entities/ConstantConfig.java WW-4875 Add location information for java based configuration (amashchenko: rev 55ae024c0af6feef0efd6e90ba76bea54a3037e0) * (edit) core/src/main/java/org/apache/struts2/config/StrutsJavaConfigurationProvider.java * (edit) core/src/test/java/com/opensymphony/xwork2/util/location/LocationUtilsTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/location/LocationUtils.java WW-4875 Add convention constant configuration (aleksandr.7m: rev 302b53d43c1665a745836ab355e1703a424e7f8d) * (add) plugins/convention/src/main/java/org/apache/struts2/convention/config/entities/ConventionConstantConfig.java WW-4875 Add json constant configuration (aleksandr.7m: rev 7a9b5029a59412e1b9faf1a1699451f880e29af0) * (add) plugins/json/src/main/java/org/apache/struts2/json/config/entities/JSONConstantConfig.java * (edit) plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java * (edit) plugins/json/src/main/java/org/apache/struts2/json/JSONConstants.java WW-4875 Add rest constant configuration (aleksandr.7m: rev a049d1709b65ea01a2ddcee659fd74c5e5cb24bf) * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/RestActionInvocation.java * (add) plugins/rest/src/main/java/org/apache/struts2/rest/RestConstants.java * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/RestWorkflowInterceptor.java * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/DefaultContentTypeHandlerManager.java * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/RestActionProxyFactory.java * (add) plugins/rest/src/main/java/org/apache/struts2/rest/config/entities/RestConstantConfig.java * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/RestActionMapper.java WW-4875 Add spring constant configuration (aleksandr.7m: rev b2ff4bb56b21af384e5602ac68d80125b8da74ca) * (add) plugins/spring/src/main/java/org/apache/struts2/spring/SpringConstants.java * (edit) plugins/spring/src/main/java/org/apache/struts2/spring/StrutsSpringObjectFactory.java * (add) plugins/spring/src/main/java/org/apache/struts2/spring/config/entities/SpringConstantConfig.java > Java configuration > -- > > Key: WW-4875 > URL: https://issues.apache.org/jira/browse/WW-4875 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.13 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Major > Fix For: 2.6 > > > Some people are allergic to XML and even with convention plugin currently > there is no way to define properties w/o struts.xml or properties file. > It would be great to add the ability to configure app via java configuration. > We can start with adding support for constant, bean and unknown-handler-stack > and see how it goes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4923) JasperReportResult: NPE When Not Using SQL Connection
[ https://issues.apache.org/jira/browse/WW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380060#comment-16380060 ] Hudson commented on WW-4923: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #104 (See [https://builds.apache.org/job/Struts-master-JDK7/104/]) WW-4923 Null check to avoid NPE when not passing a JDBC connection to (paul.zepernick: rev 8bf6605e6bc08cbc3e7bfd70d03ac5f988808405) * (edit) plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java > JasperReportResult: NPE When Not Using SQL Connection > - > > Key: WW-4923 > URL: https://issues.apache.org/jira/browse/WW-4923 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - JasperReports >Affects Versions: 2.5.14.1 >Reporter: Paul Zepernick >Priority: Minor > Fix For: 2.5.16 > > > The JasperReportResult throws a NPE in the finally when closing the SQL > connection when using a Data Source from the value stack instead of supplying > a SQL connection to the report. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-3915) In devMode configs are reloaded on each request even if there is no file change
[ https://issues.apache.org/jira/browse/WW-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379901#comment-16379901 ] Hudson commented on WW-3915: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #103 (See [https://builds.apache.org/job/Struts-master-JDK7/103/]) fix javadoc to being consistent with WW-3915 changes (yasserzamani: rev 8d91536b17dee58bd3734c4d3b69cb1416c5223a) * (edit) core/src/main/java/com/opensymphony/xwork2/FileManager.java > In devMode configs are reloaded on each request even if there is no file > change > --- > > Key: WW-3915 > URL: https://issues.apache.org/jira/browse/WW-3915 > Project: Struts 2 > Issue Type: Bug > Components: XML Configuration >Affects Versions: 2.3.4.1 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Minor > Fix For: 2.3.7 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4914) Update Log4j2 to 2.10.0
[ https://issues.apache.org/jira/browse/WW-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352707#comment-16352707 ] Hudson commented on WW-4914: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #96 (See [https://builds.apache.org/job/Struts-master-JDK7/96/]) WW-4914 Update Log4j2 to 2.10.0 (amashchenko: rev 56c6456c617893867f6b2beb7f38d8a381c257b6) * (edit) pom.xml > Update Log4j2 to 2.10.0 > --- > > Key: WW-4914 > URL: https://issues.apache.org/jira/browse/WW-4914 > Project: Struts 2 > Issue Type: Improvement >Affects Versions: 2.5.14.1 >Reporter: Aleksandr Mashchenko >Assignee: Aleksandr Mashchenko >Priority: Minor > Fix For: 2.5.15 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4741) Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value.
[ https://issues.apache.org/jira/browse/WW-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346835#comment-16346835 ] Hudson commented on WW-4741: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #95 (See [https://builds.apache.org/job/Struts-master-JDK7/95/]) WW-4741 Does not create session if it doesn't exist (lukaszlenart: rev e9a4bcd776e82afb135091f7ad48ada90bf5d2e6) * (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java WW-4741 Improves tests to cover the new logic (lukaszlenart: rev 92e931d169ccd35cf3a8456451a74901979aed76) * (edit) core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java > Http Sessions forcefully created for all requests using I18nInterceptor with > default Storage value. > --- > > Key: WW-4741 > URL: https://issues.apache.org/jira/browse/WW-4741 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.10 >Reporter: Adam Greenfield >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.5.15 > > > Changes made in WW-4730 for store and read functions cause an httpSession to > be created for every request that uses I18nInterceptor when storage = > Storage.SESSION. > Current code checks for > {noformat}Map session = > invocation.getInvocationContext().getSession(){noformat} > to be null and then calls > {noformat}ServletActionContext.getRequest().getSession(){noformat} > (notice how the second one references the HttpServletRequest. The > HttpServletRequest Session and and the InvocationContext session are > different. The request's session can be null, even if the > InvocationContext's session is not). > Calling .getSession() in this manner forcefully creates a session. > An appropriate check here might be > {noformat}HttpSession httpSession = > ServletActionContext.getRequest().getSession(false); > if(httpSession != null) { > ... // get sessionId and synchronize on it > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4903) Dependency Mapping Exception When Using PrefixBasedActionProxyFactory
[ https://issues.apache.org/jira/browse/WW-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307451#comment-16307451 ] Hudson commented on WW-4903: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #77 (See [https://builds.apache.org/job/Struts-master-JDK7/77/]) WW-4903 Drops injecting defined factory to avoid mapping exception (lukaszlenart: rev 15e6be1d66be7bc60d26b305dcf768e540900346) * (edit) core/src/main/java/org/apache/struts2/factory/PrefixBasedActionProxyFactory.java WW-4903 Uses Initializable to properly initialise the factory (lukaszlenart: rev 6fc695970f60d7cceca075314076d574370c1a05) * (edit) core/src/main/java/org/apache/struts2/factory/PrefixBasedActionProxyFactory.java WW-4903 Adds a unit test to cover the new functionality (lukaszlenart: rev 457f7c2f57da58c7ae75b75773c017d45bfc519d) * (add) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java WW-4903 Covers fallback to default factory with unit test (lukaszlenart: rev a2710a6f040bfe523395c0024d356dc20a5ae022) * (edit) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java WW-4903 Uses StrutsActionProxyFactory as a default factory (lukaszlenart: rev 7116ac8801582f593f6d08bb96cb20b232955362) * (edit) core/src/main/java/org/apache/struts2/factory/PrefixBasedActionProxyFactory.java * (edit) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java WW-4903 Extends test of empty prefix (lukaszlenart: rev 7cdc319b412a723070915b2d97d966c861ba3d74) * (edit) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java WW-4903 Reverts to previous initialise mechanism (lukaszlenart: rev 033573e8fb5c4aceba1e4469b41ff777210a109a) * (edit) core/src/main/java/org/apache/struts2/factory/PrefixBasedActionProxyFactory.java * (edit) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java WW-4903 Adds missing header with license (lukaszlenart: rev 809d8968ca8a47fd7bd3a3e9f532ff861f89ba31) * (edit) core/src/test/java/org/apache/struts2/factory/PrefixBasedActionProxyFactoryTest.java > Dependency Mapping Exception When Using PrefixBasedActionProxyFactory > - > > Key: WW-4903 > URL: https://issues.apache.org/jira/browse/WW-4903 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - REST >Reporter: aditya shrivastava >Assignee: Lukasz Lenart > Fix For: 2.5.15 > > Attachments: error_screen_shot.png > > > I am using struts-rest plugin with REST & NON REST flow I am using STRUTS > 2.3.34 version. > To achieve this I am using following configuration. > {code:java} > value="org.apache.struts2.dispatcher.mapper.PrefixBasedActionMapper"/> > value="/sm:rest,/pd:rest,:struts"/> > > {code} > When I start my tomcat & hit on url > https://localhost:8080/myapp > I always get the exception > {code:java} > HTTP Status 500 – Internal Server Error > Type Exception Report > Message java.lang.RuntimeException: > com.opensymphony.xwork2.inject.DependencyException: > com.opensymphony.xwork2.inject.ContainerImpl$MissingDependencyException: No > mapping found for dependency > [type=com.opensymphony.xwork2.ActionProxyFactory, > name='struts.actionProxyFactory'] in public void > org.apache.struts2.impl.PrefixBasedActionProxyFactory.setActionProxyFactory(com.opensymphony.xwork2.ActionProxyFactory). > Description The server encountered an unexpected condition that prevented it > from fulfilling the request. > Exception > java.lang.RuntimeException: java.lang.RuntimeException: > com.opensymphony.xwork2.inject.DependencyException: > com.opensymphony.xwork2.inject.ContainerImpl$MissingDependencyException: No > mapping found for dependency > [type=com.opensymphony.xwork2.ActionProxyFactory, > name='struts.actionProxyFactory'] in public void > org.apache.struts2.impl.PrefixBasedActionProxyFactory.setActionProxyFactory(com.opensymphony.xwork2.ActionProxyFactory). > > com.opensymphony.xwork2.inject.ContainerBuilder$4.create(ContainerBuilder.java:132) > com.opensymphony.xwork2.inject.Scope$2$1.create(Scope.java:51) > > com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:514) > > com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:524) > > com.opensymphony.xwork2.inject.ContainerImpl$9.call(ContainerImpl.java:555) > > com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:584) > > com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:553) > > org.apache.struts2.dispatcher.Dispatcher.serviceAction(Dispatcher.java:565) > > org.apache.struts2.dispatcher.ng.ExecuteOperations.executeAction(ExecuteOperations.jav
[jira] [Commented] (WW-4873) NotSerializableException - org.apache.struts2.dispatcher.StrutsRequestWrapper
[ https://issues.apache.org/jira/browse/WW-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293742#comment-16293742 ] Hudson commented on WW-4873: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #74 (See [https://builds.apache.org/job/Struts-master-JDK7/74/]) WW-4873 Makes ActionInvocation not serializable (yasserzamani: rev 4738d1d80228f86da880ed207294349566a260a2) * (edit) plugins/dwr/src/main/java/org/apache/struts2/validators/DWRValidator.java * (edit) core/src/main/java/com/opensymphony/xwork2/ActionInvocation.java * (edit) plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/OldDecorator2NewStrutsDecorator.java * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/RestActionInvocation.java * (edit) core/src/main/java/org/apache/struts2/util/InvocationSessionStore.java * (edit) core/src/test/java/com/opensymphony/xwork2/spring/interceptor/TestActionInvocation.java * (edit) plugins/json/src/test/java/org/apache/struts2/json/JSONInterceptorTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/DefaultActionInvocation.java * (edit) core/src/main/java/com/opensymphony/xwork2/mock/MockActionInvocation.java * (edit) core/src/test/java/com/opensymphony/xwork2/DefaultActionInvocationTest.java WW-4873 Makes InvocationSessionStore$InvocationContext transient (yasserzamani: rev 2941416a1832393a25a9bb823f5763fc7851da23) * (edit) core/src/main/java/org/apache/struts2/util/InvocationSessionStore.java * (edit) core/src/test/java/org/apache/struts2/util/InvocationSessionStoreTest.java > NotSerializableException - org.apache.struts2.dispatcher.StrutsRequestWrapper > - > > Key: WW-4873 > URL: https://issues.apache.org/jira/browse/WW-4873 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.13 >Reporter: Michael Hum >Assignee: Yasser Zamani > Fix For: 2.5.15 > > > We are attempting to test session replication on our websphere servers but > run into the given error when websphere tries to serialize the session. > {code} > [10/18/17 10:33:38:094 EDT] 0335 WASSessionE MTMBuffWrapper getBytes > write object exception. e= java.io.NotSerializableException: > org.apache.struts2.dispatcher.StrutsRequestWrapper > {code} > It appears the ActionInvocation stores the ActionContext which stores the > offending property: com.opensymphony.xwork2.dispatcher.HttpServletRequest --> > StrutsRequestWrapper > After a little digging we narrowed it down to our use of the > TokenSessionStoreInterceptor which stores the value in the session and uses > it to redirect the failed request to the original one. Is this > intended/expected? Or is there no requirement that the contents in the > session be serializable - in which case we would have to look to our own > solution. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4901) ClassCastException in JarEntryRevision
[ https://issues.apache.org/jira/browse/WW-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290538#comment-16290538 ] Hudson commented on WW-4901: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #71 (See [https://builds.apache.org/job/Struts-master-JDK7/71/]) WW-4901 Decouples Struts from URL.openConnection implementation of (yasserzamani: rev 94758b699cfea1bb8bfba777dcc383b4dcd41436) * (add) core/src/main/java/com/opensymphony/xwork2/util/fs/StrutsJarURLConnection.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/fs/JarEntryRevision.java WW-4901 Falls back if JarURLConnection was present already (yasserzamani: rev d082aaca2a6d2d3a37b374ad34f4ea8d091d09f1) * (edit) core/src/test/java/com/opensymphony/xwork2/util/fs/JarEntryRevisionTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/fs/JarEntryRevision.java * (edit) core/src/main/java/com/opensymphony/xwork2/util/fs/StrutsJarURLConnection.java > ClassCastException in JarEntryRevision > -- > > Key: WW-4901 > URL: https://issues.apache.org/jira/browse/WW-4901 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.14.1 > Environment: Websphere 8.5.5.12 >Reporter: Michael Hum >Assignee: Yasser Zamani >Priority: Critical > Fix For: 2.5.15 > > > After upgrading to struts 2.5.14.1 we are unable to startup the application > on websphere. The logs show class cast exceptions in the JarEntryRevision > class: > {code} > [12/7/17 16:50:18:323 EST] 0502 JarEntryRevis W > com.opensymphony.xwork2.util.fs.JarEntryRevision build Could not create > JarEntryRevision for > [wsjar:file:/icosdata/IBM/WebSphere/AppServer/profiles/CmpAppSrv01/installedApps/CMPDMDEVCell01/icos-dev.ear/icos-web.war/WEB-INF/lib/struts2-core-2.5.14.1.jar!/struts-default.xml]! > java.lang.ClassCastException: > com.ibm.ws.classloader.Handler$ClassLoaderURLConnection incompatible with > java.net.JarURLConnection > at > com.opensymphony.xwork2.util.fs.JarEntryRevision.build(JarEntryRevision.java:44) > at > com.opensymphony.xwork2.util.fs.DefaultFileManager.monitorFile(DefaultFileManager.java:94) > at > com.opensymphony.xwork2.util.fs.DefaultFileManager.loadFile(DefaultFileManager.java:73) > at > com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadConfigurationFiles(XmlConfigurationProvider.java:1054) > at > com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadDocuments(XmlConfigurationProvider.java:198) > at > com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.init(XmlConfigurationProvider.java:165) > at > com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:166) > at > com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:66) > at > org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:957) > at > org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:463) > at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:496) > at > org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:73) > at > org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:61) > at > com.ibm.ws.webcontainer.filter.FilterInstanceWrapper.init(FilterInstanceWrapper.java:145) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager._loadFilter(WebAppFilterManager.java:607) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager.loadFilter(WebAppFilterManager.java:514) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager.getFilterInstanceWrapper(WebAppFilterManager.java:319) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager.getFilterChain(WebAppFilterManager.java:392) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager.doFilter(WebAppFilterManager.java:931) > at > com.ibm.ws.webcontainer.filter.WebAppFilterManager.invokeFilters(WebAppFilterManager.java:1107) > at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:3980) > at > com.ibm.ws.webcontainer.webapp.WebGroup.handleRequest(WebGroup.java:304) > at > com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:1016) > at > com.ibm.ws.webcontainer.WSWebContainer.handleRequest(WSWebContainer.java:1817) > at > com.ibm.ws.webcontainer.channel.WCChannelLink.ready(WCChannelLink.java:200) > at > com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleDiscrimination(HttpInboundLink.java:463) > at > com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleNewRequest(HttpInboundLink.java:530) > at > com.ibm.ws.http.channel.inboun
[jira] [Commented] (WW-4900) NotSerializableException: com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector when using ExecuteAndWait interceptor
[ https://issues.apache.org/jira/browse/WW-4900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289262#comment-16289262 ] Hudson commented on WW-4900: FAILURE: Integrated in Jenkins build Struts-master-JDK7 #70 (See [https://builds.apache.org/job/Struts-master-JDK7/70/]) WW-4900 Makes BackgroundProcess transient (yasserzamani: rev dda3facc265d4e1c3b1c60fa2bcc4240953ee35c) * (add) core/src/test/java/org/apache/struts2/interceptor/BackgroundProcessTest.java * (edit) core/src/test/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptorTest.java * (edit) core/src/main/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptor.java * (edit) core/src/main/java/org/apache/struts2/interceptor/BackgroundProcess.java WW-4900 Reverts BackgroundProcess access modifiers (yasserzamani: rev 6b131550a649106766f45c83279b036544afc58c) * (edit) core/src/main/java/org/apache/struts2/interceptor/BackgroundProcess.java WW-4900 Fixes BackgroundProcessTest via synchronization (yasserzamani: rev a8ecd9bd297670b048dd3d12ee7211d4984db664) * (edit) core/src/test/java/org/apache/struts2/interceptor/BackgroundProcessTest.java > NotSerializableException: > com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector when using > ExecuteAndWait interceptor > > > Key: WW-4900 > URL: https://issues.apache.org/jira/browse/WW-4900 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.5.14.1 >Reporter: Erica Kane >Assignee: Yasser Zamani > Fix For: 2.5.15 > > > We are running Struts 2.5.14.1 and working on externalizing Tomcat session > state. This requires Serializable sessions. However, our Action with the > ExecuteAndWait interceptor fails. Since our original code was quite complex I > wrote a simpler one below which demonstrates the exact same behavior. > The simple action is shown here: > {noformat} > package com.sentrylink.web.actions; > import java.util.concurrent.TimeUnit; > import org.apache.struts2.convention.annotation.InterceptorRef; > import org.apache.struts2.convention.annotation.InterceptorRefs; > import org.apache.struts2.convention.annotation.Result; > import org.apache.struts2.convention.annotation.Results; > import com.opensymphony.xwork2.ActionSupport; > @SuppressWarnings("serial") > @Results({ > @Result(name="wait", location="/"), > @Result(name=ActionSupport.SUCCESS, > location="/WEB-INF/content/messagePage.jsp"), > }) > @InterceptorRefs({ > @InterceptorRef("webStack"), > @InterceptorRef("execAndWait") > }) > public class TestExecuteAndWait extends ActionSupport { > public String execute() throws Exception { > TimeUnit.SECONDS.sleep(10); > return SUCCESS; > } > } > {noformat} > Running this gives > {noformat} > WARNING: Cannot serialize session attribute __execWaittest-execute-and-wait > for session 74CDB9F8D00BBC697030AFC6978E94F6 > java.io.NotSerializableException: > com.opensymphony.xwork2.inject.ContainerImpl$ConstructorInjector > {noformat} > Removing the ExecuteAndWait interceptor fixes the issue. > According to [~yasser.zamani] in WW-4873 : I reviewed > {{ExecuteAndWaitInterceptor}} and seems has this bug when session goes to > being serialized in middle of an background process. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4034) Allow to use custom JSONwriter
[ https://issues.apache.org/jira/browse/WW-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276726#comment-16276726 ] Hudson commented on WW-4034: SUCCESS: Integrated in Jenkins build Struts-site #162 (See [https://builds.apache.org/job/Struts-site/162/]) WW-4034 Adds example for how customizing JSONWriter (yasserzamani: rev 1f278c4fe64e7fe1ee9ba0dc15507488a9e0e0b5) * (edit) source/plugins/json/index.md WW-4034 Fixes an apostrophe typo (yasserzamani: rev d5be4eff2e60719d939deddb21178ff27705f11b) * (edit) source/plugins/json/index.md > Allow to use custom JSONwriter > -- > > Key: WW-4034 > URL: https://issues.apache.org/jira/browse/WW-4034 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - JSON >Reporter: Emir Buğra KÖKSALAN >Priority: Minor > Labels: JSON > Fix For: 2.5.14 > > > Throws when accessing to a private inner class in that method: > private void map(Map map, Method method) throws JSONException > May be pass when trying to access a private class. example source code should > be: > {code:java} > private void map(Map map, Method method) throws JSONException { > this.add("{"); > ... > while (it.hasNext()) { > Map.Entry entry = (Map.Entry) it.next(); > Object key = entry.getKey(); > String expr = null; > if (this.buildExpr) { > try { > if (key == null) { > LOG.error("Cannot build expression for null key in " + > this.exprStack); > continue; > } else { > expr = this.expandExpr(key.toString()); > if (this.shouldExcludeProperty(expr)) { > continue; > } > expr = this.setExprStack(expr); > } > } > catch (Exception ex) { > LOG.error("Error: " + ex.getLocalizedMessage()); > continue; > } > } > if (hasData) { > this.add(','); > } > ... > this.add("}"); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4034) Allow to use custom JSONwriter
[ https://issues.apache.org/jira/browse/WW-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276396#comment-16276396 ] Hudson commented on WW-4034: SUCCESS: Integrated in Jenkins build Struts-examples-JDK8-master #69 (See [https://builds.apache.org/job/Struts-examples-JDK8-master/69/]) WW-4034 Example for customizing JSONWriter (yasserzamani: rev d482811ab8cad7f69520e63c3b51fe068e12cd1c) * (add) json-customize/src/main/resources/struts.xml * (add) json-customize/src/main/java/org/demo/FlexJSONWriter.java * (add) json-customize/src/main/webapp/WEB-INF/index.jsp * (add) json-customize/src/main/java/org/demo/Zipcode.java * (add) json-customize/src/main/webapp/WEB-INF/web.xml * (edit) pom.xml * (add) json-customize/src/main/java/org/demo/Person.java * (add) json-customize/src/main/java/org/demo/ExcludeTransformer.java * (add) json-customize/pom.xml * (add) json-customize/src/main/resources/log4j2.xml * (add) json-customize/src/main/java/org/demo/Phone.java * (add) json-customize/src/main/java/org/demo/Address.java * (add) json-customize/src/main/java/org/demo/ProduceAction.java * (add) json-customize/src/main/java/org/demo/PasswordTransformer.java * (add) json-customize/src/main/java/org/demo/User.java > Allow to use custom JSONwriter > -- > > Key: WW-4034 > URL: https://issues.apache.org/jira/browse/WW-4034 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - JSON >Reporter: Emir Buğra KÖKSALAN >Priority: Minor > Labels: JSON > Fix For: 2.5.14 > > > Throws when accessing to a private inner class in that method: > private void map(Map map, Method method) throws JSONException > May be pass when trying to access a private class. example source code should > be: > {code:java} > private void map(Map map, Method method) throws JSONException { > this.add("{"); > ... > while (it.hasNext()) { > Map.Entry entry = (Map.Entry) it.next(); > Object key = entry.getKey(); > String expr = null; > if (this.buildExpr) { > try { > if (key == null) { > LOG.error("Cannot build expression for null key in " + > this.exprStack); > continue; > } else { > expr = this.expandExpr(key.toString()); > if (this.shouldExcludeProperty(expr)) { > continue; > } > expr = this.setExprStack(expr); > } > } > catch (Exception ex) { > LOG.error("Error: " + ex.getLocalizedMessage()); > continue; > } > } > if (hasData) { > this.add(','); > } > ... > this.add("}"); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4893) Upgrade Jackson to version 2.9.2
[ https://issues.apache.org/jira/browse/WW-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268302#comment-16268302 ] Hudson commented on WW-4893: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #64 (See [https://builds.apache.org/job/Struts-master-JDK7/64/]) WW-4893 Upgrades Jackson to version 2.9.2 (lukaszlenart: rev 0d42ff50ac147df883372c0c513734af8abaee39) * (edit) pom.xml > Upgrade Jackson to version 2.9.2 > > > Key: WW-4893 > URL: https://issues.apache.org/jira/browse/WW-4893 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - REST >Affects Versions: 2.5.14 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart >Priority: Trivial > Fix For: 2.5.14.1 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4892) Use Jackson handle by default to handle JSON
[ https://issues.apache.org/jira/browse/WW-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268303#comment-16268303 ] Hudson commented on WW-4892: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #64 (See [https://builds.apache.org/job/Struts-master-JDK7/64/]) WW-4892 Uses Jackson handler as a default one to handle JSON (lukaszlenart: rev 941374ecdb99ccc316f6b527b8df0f1cf2bb80c0) * (edit) plugins/rest/src/main/resources/struts-plugin.xml WW-4892 Makes json-lib optional (lukaszlenart: rev a2824b7c87659c0c8f8cfc4b1b1fe2cc60b19138) * (edit) plugins/rest/pom.xml WW-4892 Marks handler as deprecated (lukaszlenart: rev 794cd5e1413f77f6a350528e4b068dad872c3642) * (edit) plugins/rest/src/main/java/org/apache/struts2/rest/handler/JsonLibHandler.java > Use Jackson handle by default to handle JSON > > > Key: WW-4892 > URL: https://issues.apache.org/jira/browse/WW-4892 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - REST >Affects Versions: 2.5.14 >Reporter: Lukasz Lenart >Assignee: Lukasz Lenart > Fix For: 2.5.14.1 > > > Existing JsonLibHandler is using outdated json-lib which wasn't updated for > years, switching to Jackson (which is already available in to the plugin) is > the best option. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4888) HTML escaping on the text tag
[ https://issues.apache.org/jira/browse/WW-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254069#comment-16254069 ] Hudson commented on WW-4888: SUCCESS: Integrated in Jenkins build Struts-site #129 (See [https://builds.apache.org/job/Struts-site/129/]) WW-4888 Documents escaping possibilities of text-tag (yasser.zamani: rev 5b91cd9f1c940366c1bacd56347aa3939dd1e89c) * (edit) source/tag-developers/text-tag.md > HTML escaping on the text tag > - > > Key: WW-4888 > URL: https://issues.apache.org/jira/browse/WW-4888 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Affects Versions: 2.5.13 >Reporter: Pierre-Yves Soblet > Fix For: 2.5.14 > > Attachments: text-vs-property.png > > > Assuming an i18n bundle with the following entry: > {code} > sample.message=This is a dumb smiley <:‑| > {code} > The following tag produces a value that is properly escaped for HTML: > {code} > > {code} > However, the *text* tag does not escape the "<" character and cannot be > safely used in HTML: > {code} > > {code} > The text tag documentation > (http://struts.apache.org/tag-developers/text-tag.html) neither states HTML > escaping is performed nor warns it is not. > In the FAQ, the "How to escape special chars in resource bundles" article > (https://struts.apache.org/docs/how-to-escape-special-chars-in-resource-bundles.html) > describes how to escape special characters of the MessageFormat syntax but > does not mention HTML escaping. > I assume HTML escaping on the text tag cannot be added now without breaking > backward compatibility, but maybe an "escapeHtml" attribute could be added > (as with the property tag)? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4876) NullPointerException in com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile
[ https://issues.apache.org/jira/browse/WW-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249164#comment-16249164 ] Hudson commented on WW-4876: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #60 (See [https://builds.apache.org/job/Struts-master-JDK7/60/]) WW-4876 WW-4841 Parses validators after all injections done (yasser.zamani: rev 9418cb5e89001f90a5e5b9320e03dfd372b2c18d) * (edit) core/src/test/java/com/opensymphony/xwork2/spring/SpringObjectFactoryTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/ValidatorFactory.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/DefaultValidatorFactory.java * (add) core/src/test/resources/com/opensymphony/xwork2/spring/emptyContext-spring.xml > NullPointerException in > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile > --- > > Key: WW-4876 > URL: https://issues.apache.org/jira/browse/WW-4876 > Project: Struts 2 > Issue Type: Bug >Affects Versions: 2.3.32 >Reporter: Zac Zhang > > hi Lukasz Lenart, my project sometimes casue such error, i don't know why, > please help , thanks > {noformat} > java.lang.NullPointerException > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.loadFile(AnnotationActionValidatorManager.java:390) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildClassValidatorConfigs(AnnotationActionValidatorManager.java:282) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:374) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.buildValidatorConfigs(AnnotationActionValidatorManager.java:353) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.getValidators(AnnotationActionValidatorManager.java:98) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:140) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:132) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:127) > at > com.opensymphony.xwork2.validator.ValidationInterceptor.doBeforeInvocation(ValidationInterceptor.java:222) > at > com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:263) > at > org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:76) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.intercept(ConversionErrorInterceptor.java:138) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:229) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:229) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:191) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > org.apache.struts2.interceptor.MultiselectInterceptor.intercept(MultiselectInterceptor.java:73) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > org.apache.struts2.interceptor.DateTextFieldInterceptor.intercept(DateTextFieldInterceptor.java:125) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:245) > at > org.apache.str
[jira] [Commented] (WW-4841) Struts2.5.12 - NPE in DeligatingValidatorContext
[ https://issues.apache.org/jira/browse/WW-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249165#comment-16249165 ] Hudson commented on WW-4841: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #60 (See [https://builds.apache.org/job/Struts-master-JDK7/60/]) WW-4876 WW-4841 Parses validators after all injections done (yasser.zamani: rev 9418cb5e89001f90a5e5b9320e03dfd372b2c18d) * (edit) core/src/test/java/com/opensymphony/xwork2/spring/SpringObjectFactoryTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/ValidatorFactory.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/DefaultValidatorFactory.java * (add) core/src/test/resources/com/opensymphony/xwork2/spring/emptyContext-spring.xml > Struts2.5.12 - NPE in DeligatingValidatorContext > > > Key: WW-4841 > URL: https://issues.apache.org/jira/browse/WW-4841 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.12 >Reporter: Prasann Grampurohit > Labels: struts2.5.12 > Fix For: 2.5.13 > > Attachments: ActionValidatorManager.JPG, struts2_error.log > > > We are upgrading one of our project to Struts 2.5.12. My project setup is as > mentioned in the link: > https://stackoverflow.com/questions/45347478/struts2-5-12-npe-while-using-gettext-method-from-actionsupport > When I try to submit request to action on the first page, I see > NullPointerException as below. Debugged it and found that textProviderFactory > is null. Tried it a several times and I see that it is intermittent. > Approximately twice in 10 server restarts the textProviderFactory is > initialized. > Could you please check if I am missing any configuration? I have raised a > stackoverflow for this, but haven't got any response yet - > https://stackoverflow.com/questions/45483364/struts2-5-12-npe-in-deligatingvalidatorcontext > Exception: > {code:java} > java.lang.NullPointerException > at > com.opensymphony.xwork2.validator.DelegatingValidatorContext.makeTextProvider(DelegatingValidatorContext.java:210) > at > com.opensymphony.xwork2.validator.DelegatingValidatorContext.(DelegatingValidatorContext.java:63) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:125) > at > com.opensymphony.xwork2.validator.AnnotationActionValidatorManager.validate(AnnotationActionValidatorManager.java:121) > at > com.opensymphony.xwork2.validator.ValidationInterceptor.doBeforeInvocation(ValidationInterceptor.java:224) > at > com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:259) > at > org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:52) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.my.company.web.interceptor.ButtonPressedInterceptor.intercept(ButtonPressedInterceptor.java:40) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor.doIntercept(ConversionErrorInterceptor.java:139) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.opensymphony.xwork2.interceptor.ParametersInterceptor.doIntercept(ParametersInterceptor.java:134) > at > com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:98) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:199) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > org.apache.struts2.interceptor.CheckboxInterceptor.intercept(CheckboxInterceptor.java:88) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > org.apache.struts2.interceptor.FileUploadInterceptor.intercept(FileUploadInterceptor.java:246) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor.intercept(ModelDrivenInterceptor.java:99) > at > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:247) > at > com.opensymphony
[jira] [Commented] (WW-4713) Drop "searchValueStack" attribute from tag
[ https://issues.apache.org/jira/browse/WW-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248561#comment-16248561 ] Hudson commented on WW-4713: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #59 (See [https://builds.apache.org/job/Struts-master-JDK7/59/]) WW-4713 Added deprecation warnings as preparation to drop (stefaan.dutry: rev bfbc17e1ad496c18933fda5a3b53f097cc5c2ecf) * (edit) core/src/main/java/org/apache/struts2/util/TextProviderHelper.java * (edit) core/src/main/java/org/apache/struts2/components/Text.java * (edit) core/src/main/java/org/apache/struts2/views/jsp/TextTag.java > Drop "searchValueStack" attribute from tag > > > Key: WW-4713 > URL: https://issues.apache.org/jira/browse/WW-4713 > Project: Struts 2 > Issue Type: Improvement > Components: Core Tags >Affects Versions: 2.5.8 >Reporter: Lukasz Lenart >Assignee: Stefaan Dutry > Fix For: 2.6 > > > This attribute is only used to evaluate a {{defaultMessage}} against a > ValueStack which is useless in most cases as the {{defaultMessage}} should be > a static text, not an expression. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4851) Upgrade to Log4j2 2.9.0
[ https://issues.apache.org/jira/browse/WW-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246355#comment-16246355 ] Hudson commented on WW-4851: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #56 (See [https://builds.apache.org/job/Struts-master-JDK7/56/]) WW-4851 upgrade Log4j2 to version 2.9.1 (stefaan.dutry: rev 025aba98fe4bcffe4d68d0992a644d373c80d764) * (edit) pom.xml > Upgrade to Log4j2 2.9.0 > --- > > Key: WW-4851 > URL: https://issues.apache.org/jira/browse/WW-4851 > Project: Struts 2 > Issue Type: Dependency >Reporter: Stefaan Dutry >Priority: Trivial > Fix For: 2.5.14 > > > version {{2.9.0}} was released on {{2017-08-26}} > [changelog|https://logging.apache.org/log4j/2.0/changes-report.html#a2.9.0] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WW-4871) Decimal converters should avoid loss of user's data caused by rounding
[ https://issues.apache.org/jira/browse/WW-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246085#comment-16246085 ] Hudson commented on WW-4871: SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #54 (See [https://builds.apache.org/job/Struts-master-JDK7/54/]) WW-4871 Fixes StringConverter and improves it's tests (yasser.zamani: rev 8af1d014cbd3b5b3e1e524dbcf8b554b7a6b954c) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java WW-4871 Reverts setMinimumFractionDigits(1) to pass rest tests (yasser.zamani: rev 69d6287566f23dcfded5fdcf8f25ac14f9c257e3) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java WW-4871 Fixes previous unit tests after setMinimumFractionDigits(1) (yasser.zamani: rev 3514e4f68287dc7e36875dc878fa9a0bc7e1ee01) * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java WW-4871 Fixes max fraction digits to bigger than max precision (yasser.zamani: rev 86bb7fced47e9735554d15b87c3b6a77c3c9d128) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java WW-4871 Makes NumberConverter's test harder (yasser.zamani: rev f01475f08ca6d7f0915e841ac8144ef99a091f3c) * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/NumberConverterTest.java WW-4871 Fixes max fraction digits to Integer.MAX_VALUE (yasser.zamani: rev 888f2fc8e0e8dc3087a2ee787727933b63df4040) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java WW-4871 Drops setMinimumFractionDigits (yasser.zamani: rev 66ae66141362e3fd1c3db26149e15619f6c20fcb) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Select-3.txt * (edit) core/src/test/java/com/opensymphony/xwork2/validator/DoubleRangeFieldValidatorTest.java WW-4871 Fixes java.text.NumberFormat.format's float to double (yasser.zamani: rev 8b7c68171e8bfe16ea57eb6ec232778f1502e067) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java WW-4871 Documents our manual jdk fix by a TODO (yasser.zamani: rev b60425e5348ad0b4e503e442594417d93dd61856) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java WW-4871 Tests if StringConverter changes float input parameter (yasser.zamani: rev e0d83b840f64eb7581134c925d70cc472914d50c) * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java WW-4871 Removes assignment to value parameter (yasser.zamani: rev a5db2881308cfccf52edf165447188ba09124772) * (edit) core/src/main/java/com/opensymphony/xwork2/conversion/impl/StringConverter.java * (edit) core/src/test/java/com/opensymphony/xwork2/conversion/impl/StringConverterTest.java > Decimal converters should avoid loss of user's data caused by rounding > -- > > Key: WW-4871 > URL: https://issues.apache.org/jira/browse/WW-4871 > Project: Struts 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.5.12, 2.5.13 >Reporter: Yasser Zamani > Fix For: 2.5.14 > > > For example in following jsp: > {code:xml} > > > > > {code} > User loses decimal digits when posts back because of converter's locale based > rounding. -- This message was sent by Atlassian JIRA (v6.4.14#64029)