[jira] [Commented] (WW-5438) Wrong scope on weld dependencies
[ https://issues.apache.org/jira/browse/WW-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871912#comment-17871912 ] Jens Viebig commented on WW-5438: - Looks good to me > Wrong scope on weld dependencies > > > Key: WW-5438 > URL: https://issues.apache.org/jira/browse/WW-5438 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - CDI >Affects Versions: 7.0.0 >Reporter: Jens Viebig >Priority: Major > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > We started to migrate our application to jakartaee10 with the M7 build and > all is going quite well so far. > One thing we came across is the removal of the "provided" and "test" scope > from the weld dependencies in the pom of the struts-cdi-plugin. By default, > this now adds a lot of weld and jakartaee standards dependencies to the > WEB-INF/lib directory which are normally provided by the application server. > For now we worked around this by adding exclusions to the weld dependencies > but wondering: > Was the removal of the scopes intentional ? > This is the commit where the scopes were removed: > [https://github.com/apache/struts/commit/8fecaa2c3008ec6a9f9653b991e017caa84423ed] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871667#comment-17871667
]
Lukasz Lenart commented on WW-5450:
---
No worries, I will also take a look during weekend
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871665#comment-17871665
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 2:19 PM:
--
I changed the %{#request to %{#attr and I am having other problems with spring
security. I need more time to see what is going on, and probably would not be
able to test this until the weekend.
In the meantime, have you tried to write a simple action to dispatch to a jsp
and see if you get a FORWARD? I am thinking of writing a very simple webapp
with an action redenring a jsP and see what happens. I don't have time right
now.
was (Author: JIRAUSER305904):
I changed the %{#request to %{#attr and I am having other problems with spring
security. I need more time to see what is going on, and probably would not be
able to test this until the weekend.
In the meantime, have you tried to write a simple action to dispatch to a jsp
and see if you get a FORWARD? I am thinking of writing a very simple webapp
with an action redenring a jsP and see what happens. I don't have time right
now due to my full-time work.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871665#comment-17871665
]
Rubens Gomes commented on WW-5450:
--
I changed the %{#request to %{#attr and I am having other problems with spring
security. I need more time to see what is going on, and probably would not be
able to test this until the weekend.
In the meantime, have you tried to write a simple action to dispatch to a jsp
and see if you get a FORWARD? I am thinking of writing a very simple webapp
with an action redenring a jsP and see what happens. I don't have time right
now due to my full-time work.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart reassigned WW-5450:
-
Assignee: Lukasz Lenart
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work started] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on WW-5450 started by Lukasz Lenart.
-
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871539#comment-17871539
]
Lukasz Lenart commented on WW-5450:
---
We did a lot of security related changes in Struts 7.0 which can affect
evaluating expressions, I want to be sure that's not an issue in this case.
Also there were no changes in the dispatcher result between Struts 6 vs 7,
which could affect the behaviour, so it must be something else. Maybe I will
add more logging for now to see what's going on.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871492#comment-17871492
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:46 AM:
---
1) I have 3 (three) different types of JSP folders in webapp/WEB-INF/content:
* desktop
* smartphone
* feature (used for old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named ""%\{#request.device}" which is
what you see in the @Result annotation block. See piece of code from
interceptor below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
was (Author: JIRAUSER305904):
1) I have 3 (three) different types of JSP folders in webapp/WEB-INF/content:
* desktop
* smartphone
* feature (used for old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named ""%\{#request.device}" which is
what you see in the @Result annotation block. See piece of code from
interceptor below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871498#comment-17871498
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:46 AM:
---
I can try your suggestion of using %\{#attr.device}, but wondering why is that
going to help? I ask because resolving the path to JSP is not a problem. In
fact, this code using %\{#request.device} works in Struts 6.6.0 as said before.
My problem happens in Struts 7.x with Tomcat using GET instead of FORWARD to
render the JSP file.
was (Author: JIRAUSER305904):
I can try your suggestion of using %\{#attr.device}, but wondering why is that
going to help? I ask because resolving the path to JSP is not a problem. In
fact, this code using %\{#request.device} works in Struts 6.6.0 as said before.
My problem is Tomcat using GET instead of FORWARD to render the JSP file. Not
sure why it would work in 6.6.0 and not in 7.0.0?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871498#comment-17871498
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:45 AM:
---
I can try your suggestion of using %\{#attr.device}, but wondering why is that
going to help? I ask because resolving the path to JSP is not a problem. In
fact, this code using %\{#request.device} works in Struts 6.6.0 as said before.
My problem is Tomcat using GET instead of FORWARD to render the JSP file. Not
sure why it would work in 6.6.0 and not in 7.0.0?
was (Author: JIRAUSER305904):
I can try your suggestion of using %\{attr.device}, but wondering why is that
going to help? I ask because resolving the path to JSP is not a problem. In
fact, this code using %\{request.device} works in Struts 6.6.0 as said before.
My problem is Tomcat using GET instead of FORWARD to render the JSP file. Not
sure why it would work in 6.6.0 and not in 7.0.0?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871498#comment-17871498
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:44 AM:
---
I can try your suggestion of using %\{attr.device}, but wondering why is that
going to help? I ask because resolving the path to JSP is not a problem. In
fact, this code using %\{request.device} works in Struts 6.6.0 as said before.
My problem is Tomcat using GET instead of FORWARD to render the JSP file. Not
sure why it would work in 6.6.0 and not in 7.0.0?
was (Author: JIRAUSER305904):
I can try your suggestion, but wondering why is that going to help? I ask
because resolving the path to JSP is not a problem. In fact, this code using
%\{request.device} works in Struts 6.6.0 as said before. My problem is Tomcat
using GET instead of FORWARD to render the JSP file. Not sure why it would
work in 6.6.0 and not in 7.0.0?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871498#comment-17871498
]
Rubens Gomes commented on WW-5450:
--
I can try your suggestion, but wondering why is that going to help? I ask
because resolving the path to JSP is not a problem. In fact, this code using
%\{request.device} works in Struts 6.6.0 as said before. My problem is Tomcat
using GET instead of FORWARD to render the JSP file. Not sure why it would
work in 6.6.0 and not in 7.0.0?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871492#comment-17871492
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:40 AM:
---
1) I have 3 (three) different types of JSP folders in webapp/WEB-INF/content:
* desktop
* smartphone
* feature (used for old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named ""%\{#request.device}" which is
what you see in the @Result annotation block. See piece of code from
interceptor below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
was (Author: JIRAUSER305904):
1) I have 3 (three) different JSP folders in webapp/WEB-INF/content:
* desktop
* smartphone
* feature (used for old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named "%\{#attr.device}". See code
below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871494#comment-17871494
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:36 AM:
---
As for the security concerns, I am using SpringSecurity to enfoce that any JSP
should only be retrieved using internal FORWARD messages: meaning that whoever
trigger the rendering of the JSP should be my own code internally thru the use
of that type="dispatcher" in the @Result annotation.
Notice that in Struts 6 it works fine with that @Result type = "dispatcher"
inside the @Result annotation block.
I only started having the reported issue with GET being used with the version
7.x
was (Author: JIRAUSER305904):
As for the security concerns, I am using SpringSecurity to enfoce that any JSP
should only be retrieved using internal FORWARD messages: meaning that whoever
trigger the rendering of the JSP should be my own code internally thru the use
of that dispatcher.
Notice that in Struts 6 it works fine with that @Result type = "dispatcher"
inside the @Result annotation block.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871494#comment-17871494
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:35 AM:
---
As for the security concerns, I am using SpringSecurity to enfoce that any JSP
should only be retrieved using internal FORWARD messages: meaning that whoever
trigger the rendering of the JSP should be my own code internally thru the use
of that dispatcher.
Notice that in Struts 6 it works fine with that @Result type = "dispatcher"
inside the @Result annotation block.
was (Author: JIRAUSER305904):
responded in the Jira comments.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871494#comment-17871494
]
Rubens Gomes commented on WW-5450:
--
responded in the Jira comments.
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871492#comment-17871492
]
Rubens Gomes edited comment on WW-5450 at 8/7/24 12:28 AM:
---
1) I have 3 (three) different JSP folders in webapp/WEB-INF/content:
* desktop
* smartphone
* feature (used for old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named "%\{#attr.device}". See code
below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
was (Author: JIRAUSER305904):
1) I have 3 (three) different JSP folders in webapp/WEB-INF:
* desktop
* smartphone (for smartphones and tables)
* feature (this was used for the old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named "%\{#attr.device}". See code
below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871492#comment-17871492
]
Rubens Gomes commented on WW-5450:
--
1) I have 3 (three) different JSP folders in webapp/WEB-INF:
* desktop
* smartphone (for smartphones and tables)
* feature (this was used for the old basic cell phones) : no longer supported
2) I have configured a Struts Interceptor in the request pipeline. I believe
this interceptor runs before the Action is invoked.
3) This interceptor looks at session to see if a device has been detected
previously. If not it uses a DeviceDetector that parses HTTP headers looking
for any clues which might help decipher one of the device types above. If none
is found, it defaults to smartphone.
4) The interceptor in 3) then updates session if not up-to-date and makes the
following call, whre DEVICE_SELECTED_KEY is "device". And since the attribute
is being set on the request object it is named "%\{#attr.device}". See code
below:
{code:java}
request.setAttribute(DEVICE_SELECTED_KEY,
userSession.getSelectedDevice().getType());
{code}
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871436#comment-17871436
]
Lukasz Lenart commented on WW-5450:
---
Could you also share how do you set {{{}#request.device{}}}?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871422#comment-17871422
]
Lukasz Lenart commented on WW-5450:
---
Could you try to use
{code:java}
location = "/WEB-INF/content/%{#attr.device}/login.jsp" {code}
?
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17871409#comment-17871409
]
Lukasz Lenart commented on WW-5450:
---
Are you sure this expression is properly evaluated? Could you enable DEBUG log
level and see if there is no Security warnings
{code:java}
location = "/WEB-INF/content/%{#request.device}/login.jsp"
{code}
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage resolved WW-5453. - Resolution: Fixed > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5454) Log warnings on startup for disabled critical security features
[ https://issues.apache.org/jira/browse/WW-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage resolved WW-5454. - Resolution: Fixed > Log warnings on startup for disabled critical security features > --- > > Key: WW-5454 > URL: https://issues.apache.org/jira/browse/WW-5454 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage resolved WW-5449. - Resolution: Fixed > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?focusedWorklogId=928803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928803 ] ASF GitHub Bot logged work on WW-5453: -- Author: ASF GitHub Bot Created on: 06/Aug/24 02:12 Start Date: 06/Aug/24 02:12 Worklog Time Spent: 10m Work Description: kusalk merged PR #1009: URL: https://github.com/apache/struts/pull/1009 Issue Time Tracking --- Worklog Id: (was: 928803) Time Spent: 50m (was: 40m) > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5454) Log warnings on startup for disabled critical security features
[ https://issues.apache.org/jira/browse/WW-5454?focusedWorklogId=928802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928802 ] ASF GitHub Bot logged work on WW-5454: -- Author: ASF GitHub Bot Created on: 06/Aug/24 02:12 Start Date: 06/Aug/24 02:12 Worklog Time Spent: 10m Work Description: kusalk merged PR #1010: URL: https://github.com/apache/struts/pull/1010 Issue Time Tracking --- Worklog Id: (was: 928802) Time Spent: 40m (was: 0.5h) > Log warnings on startup for disabled critical security features > --- > > Key: WW-5454 > URL: https://issues.apache.org/jira/browse/WW-5454 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5455) Bump net.sf.jasperreports:jasperreports from 6.21.3 to 7.0.0
Lukasz Lenart created WW-5455: - Summary: Bump net.sf.jasperreports:jasperreports from 6.21.3 to 7.0.0 Key: WW-5455 URL: https://issues.apache.org/jira/browse/WW-5455 Project: Struts 2 Issue Type: Dependency Components: Plugin - JasperReports Reporter: Lukasz Lenart Fix For: 7.0.0 See https://github.com/apache/struts/pull/1007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5454) Log warnings on startup for disabled critical security features
[ https://issues.apache.org/jira/browse/WW-5454?focusedWorklogId=928630=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928630 ] ASF GitHub Bot logged work on WW-5454: -- Author: ASF GitHub Bot Created on: 03/Aug/24 10:31 Start Date: 03/Aug/24 10:31 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #1010: URL: https://github.com/apache/struts/pull/1010#issuecomment-228945 ## [](https://sonarcloud.io/dashboard?id=apache_struts=1010) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_struts=1010=OPEN,CONFIRMED=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts=1010=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1010=OPEN,CONFIRMED=true)  [84.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1010=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1010=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1010) Issue Time Tracking --- Worklog Id: (was: 928630) Time Spent: 0.5h (was: 20m) > Log warnings on startup for disabled critical security features > --- > > Key: WW-5454 > URL: https://issues.apache.org/jira/browse/WW-5454 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5454) Log warnings on startup for disabled critical security features
[
https://issues.apache.org/jira/browse/WW-5454?focusedWorklogId=928629=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928629
]
ASF GitHub Bot logged work on WW-5454:
--
Author: ASF GitHub Bot
Created on: 03/Aug/24 10:29
Start Date: 03/Aug/24 10:29
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #1010:
URL: https://github.com/apache/struts/pull/1010#discussion_r1702680866
##
core/src/main/java/com/opensymphony/xwork2/util/DebugUtils.java:
##
@@ -37,4 +42,12 @@ public static void notifyDeveloperOfError(Logger log, Object
action, String mess
}
}
+/**
+ * @since 7.0
+ */
+public static void logWarningForFirstOccurrence(String key, Logger log,
String msg, Object... args) {
Review Comment:
This method isn't really a `DebugUtils` method but couldn't think of a
better home - can create a separate class if you prefer
Issue Time Tracking
---
Worklog Id: (was: 928629)
Time Spent: 20m (was: 10m)
> Log warnings on startup for disabled critical security features
> ---
>
> Key: WW-5454
> URL: https://issues.apache.org/jira/browse/WW-5454
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5454) Log warnings on startup for disabled critical security features
[ https://issues.apache.org/jira/browse/WW-5454?focusedWorklogId=928627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928627 ] ASF GitHub Bot logged work on WW-5454: -- Author: ASF GitHub Bot Created on: 03/Aug/24 10:25 Start Date: 03/Aug/24 10:25 Worklog Time Spent: 10m Work Description: kusalk opened a new pull request, #1010: URL: https://github.com/apache/struts/pull/1010 WW-5454 -- Issue Time Tracking --- Worklog Id: (was: 928627) Remaining Estimate: 0h Time Spent: 10m > Log warnings on startup for disabled critical security features > --- > > Key: WW-5454 > URL: https://issues.apache.org/jira/browse/WW-5454 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5454) Log warnings on startup for disabled critical security features
Kusal Kithul-Godage created WW-5454: --- Summary: Log warnings on startup for disabled critical security features Key: WW-5454 URL: https://issues.apache.org/jira/browse/WW-5454 Project: Struts 2 Issue Type: Improvement Components: Core Reporter: Kusal Kithul-Godage Fix For: 7.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?focusedWorklogId=928455=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928455 ] ASF GitHub Bot logged work on WW-5453: -- Author: ASF GitHub Bot Created on: 02/Aug/24 10:05 Start Date: 02/Aug/24 10:05 Worklog Time Spent: 10m Work Description: asf-ci commented on PR #243: URL: https://github.com/apache/struts-site/pull/243#issuecomment-2265029013 Staged site is ready at https://struts.staged.apache.org/ Issue Time Tracking --- Worklog Id: (was: 928455) Time Spent: 40m (was: 0.5h) > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?focusedWorklogId=928452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928452 ] ASF GitHub Bot logged work on WW-5453: -- Author: ASF GitHub Bot Created on: 02/Aug/24 10:01 Start Date: 02/Aug/24 10:01 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #1009: URL: https://github.com/apache/struts/pull/1009#issuecomment-2265020820 ## [](https://sonarcloud.io/dashboard?id=apache_struts=1009) **Quality Gate passed** Issues  [11 New issues](https://sonarcloud.io/project/issues?id=apache_struts=1009=OPEN,CONFIRMED=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts=1009=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1009=OPEN,CONFIRMED=true)  [82.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1009=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1009=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1009) Issue Time Tracking --- Worklog Id: (was: 928452) Time Spent: 0.5h (was: 20m) > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?focusedWorklogId=928451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928451 ] ASF GitHub Bot logged work on WW-5453: -- Author: ASF GitHub Bot Created on: 02/Aug/24 10:01 Start Date: 02/Aug/24 10:01 Worklog Time Spent: 10m Work Description: kusalk opened a new pull request, #243: URL: https://github.com/apache/struts-site/pull/243 Reverts apache/struts-site#229 Issue Time Tracking --- Worklog Id: (was: 928451) Time Spent: 20m (was: 10m) > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5453) Rename VelocityManager interface and default implementation
[ https://issues.apache.org/jira/browse/WW-5453?focusedWorklogId=928449=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928449 ] ASF GitHub Bot logged work on WW-5453: -- Author: ASF GitHub Bot Created on: 02/Aug/24 09:55 Start Date: 02/Aug/24 09:55 Worklog Time Spent: 10m Work Description: kusalk opened a new pull request, #1009: URL: https://github.com/apache/struts/pull/1009 WW-5453 -- This follows on from #867 where the new `VelocityManager` interface was named `VelocityManagerInterface` to preserve backwards compatibility. In Struts 7.0 we can now safely rename these. Issue Time Tracking --- Worklog Id: (was: 928449) Remaining Estimate: 0h Time Spent: 10m > Rename VelocityManager interface and default implementation > --- > > Key: WW-5453 > URL: https://issues.apache.org/jira/browse/WW-5453 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5453) Rename VelocityManager interface and default implementation
Kusal Kithul-Godage created WW-5453: --- Summary: Rename VelocityManager interface and default implementation Key: WW-5453 URL: https://issues.apache.org/jira/browse/WW-5453 Project: Struts 2 Issue Type: Improvement Components: Plugin - Velocity Reporter: Kusal Kithul-Godage Fix For: 7.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart resolved WW-5451.
---
Resolution: Fixed
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?focusedWorklogId=928276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928276
]
ASF GitHub Bot logged work on WW-5451:
--
Author: ASF GitHub Bot
Created on: 01/Aug/24 10:01
Start Date: 01/Aug/24 10:01
Worklog Time Spent: 10m
Work Description: lukaszlenart merged PR #1008:
URL: https://github.com/apache/struts/pull/1008
Issue Time Tracking
---
Worklog Id: (was: 928276)
Time Spent: 40m (was: 0.5h)
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?focusedWorklogId=928179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928179
]
ASF GitHub Bot logged work on WW-5451:
--
Author: ASF GitHub Bot
Created on: 31/Jul/24 15:09
Start Date: 31/Jul/24 15:09
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1008:
URL: https://github.com/apache/struts/pull/1008#issuecomment-2260753569
## [](https://sonarcloud.io/dashboard?id=apache_struts=1008)
**Quality Gate failed**
Failed conditions
 [10 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1008=OPEN,CONFIRMED=true)
 [31.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1008=new_coverage=list)
(required ≥ 80%)
 [3.9% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1008=new_duplicated_lines_density=list)
(required ≤ 3%)
 [E Security Rating on New
Code](https://sonarcloud.io/dashboard?id=apache_struts=1008)
(required ≥ A)
 [E Reliability Rating on New
Code](https://sonarcloud.io/dashboard?id=apache_struts=1008)
(required ≥ A)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1008)
##
 Catch issues before they fail your Quality Gate with our IDE extension
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
Issue Time Tracking
---
Worklog Id: (was: 928179)
Time Spent: 0.5h (was: 20m)
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869926#comment-17869926
]
Jon Pulice commented on WW-5451:
Looks good to me. Thanks
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?focusedWorklogId=928174=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928174
]
ASF GitHub Bot logged work on WW-5451:
--
Author: ASF GitHub Bot
Created on: 31/Jul/24 14:59
Start Date: 31/Jul/24 14:59
Worklog Time Spent: 10m
Work Description: kusalk commented on PR #1008:
URL: https://github.com/apache/struts/pull/1008#issuecomment-2260728702
NIce catch
Issue Time Tracking
---
Worklog Id: (was: 928174)
Time Spent: 20m (was: 10m)
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869921#comment-17869921
]
Lukasz Lenart commented on WW-5451:
---
[~jonp] could you review the PR?
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?focusedWorklogId=928173=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928173
]
ASF GitHub Bot logged work on WW-5451:
--
Author: ASF GitHub Bot
Created on: 31/Jul/24 14:54
Start Date: 31/Jul/24 14:54
Worklog Time Spent: 10m
Work Description: lukaszlenart opened a new pull request, #1008:
URL: https://github.com/apache/struts/pull/1008
PR fixes NPE
```
ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler -
Exception occurred during processing request: null
java.lang.NullPointerException: null
at
org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
~[struts2-core-6.4.0.jar:6.4.0]
...
```
Fixes [WW-5451](https://issues.apache.org/jira/browse/WW-5451)
Issue Time Tracking
---
Worklog Id: (was: 928173)
Remaining Estimate: 0h
Time Spent: 10m
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869919#comment-17869919
]
Jon Pulice commented on WW-5451:
Here is a more complete stack trace
{code:java}
ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
occurred during processing request: null
java.lang.NullPointerException: null
at
org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
~[struts2-core-6.4.0.jar:6.4.0]
at
org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
~[struts2-core-6.4.0.jar:6.4.0]
at org.apache.tiles.request.jsp.JspRequest.doInclude(JspRequest.java:116)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.AbstractViewRequest.dispatch(AbstractViewRequest.java:42)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.render.DispatchRenderer.render(DispatchRenderer.java:43)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.render.ChainedDelegateRenderer.render(ChainedDelegateRenderer.java:63)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.core.impl.BasicTilesContainer.render(BasicTilesContainer.java:253)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.api.TilesContainerWrapper.render(TilesContainerWrapper.java:95)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.template.InsertAttributeModel.renderAttribute(InsertAttributeModel.java:193)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.template.InsertAttributeModel.execute(InsertAttributeModel.java:137)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.web.jsp.taglib.InsertAttributeTag.doTag(InsertAttributeTag.java:296)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.servlet.ServletRequest.forward(ServletRequest.java:274)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.servlet.ServletRequest.doForward(ServletRequest.java:235)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.AbstractClientRequest.dispatch(AbstractClientRequest.java:51)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.request.render.DispatchRenderer.render(DispatchRenderer.java:43)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.core.impl.BasicTilesContainer.render(BasicTilesContainer.java:253)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.core.impl.BasicTilesContainer.render(BasicTilesContainer.java:393)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.core.impl.BasicTilesContainer.render(BasicTilesContainer.java:230)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.api.TilesContainerWrapper.render(TilesContainerWrapper.java:90)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.tiles.core.impl.mgmt.CachingTilesContainer.render(CachingTilesContainer.java:110)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.struts2.views.tiles.TilesResult.doExecute(TilesResult.java:140)
~[struts2-tiles-plugin-6.4.0.jar:6.4.0]
at
org.apache.struts2.result.StrutsResultSupport.execute(StrutsResultSupport.java:206)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.executeResult(DefaultActionInvocation.java:377)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:284)
~[struts2-core-6.4.0.jar:6.4.0]
at
org.apache.struts2.interceptor.debugging.DebuggingInterceptor.intercept(DebuggingInterceptor.java:260)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.executeConditional(DefaultActionInvocation.java:299)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:253)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor.doIntercept(DefaultWorkflowInterceptor.java:179)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:99)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.executeConditional(DefaultActionInvocation.java:299)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:253)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.validator.ValidationInterceptor.doIntercept(ValidationInterceptor.java:263)
~[struts2-core-6.4.0.jar:6.4.0]
at
org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor.doIntercept(AnnotationValidationInterceptor.java:49)
~[struts2-core-6.4.0.jar:6.4.0]
at
com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept
[jira] [Work started] (WW-5452) Freemarker error with empty boolean parameter
[
https://issues.apache.org/jira/browse/WW-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on WW-5452 started by Lukasz Lenart.
-
> Freemarker error with empty boolean parameter
> -
>
> Key: WW-5452
> URL: https://issues.apache.org/jira/browse/WW-5452
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language
>Affects Versions: 7.0.0
>Reporter: Johannes Geppert
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> Switching to latest milestone release for version 7.0.0 resulted in
> freemarker errors when building Struts jQuery Plugin.
>
> {code:java}
> FreeMarker template error:For "#if" condition: Expected a boolean, but this
> has evaluated to an extended_hash+string
> (org.apache.struts2.dispatcher.Parameter$Empty wrapped into
> f.e.b.GenericObjectModel):==> parameters.loadFromCdn!false [in template
> "template/jquery/head.ftl" at line 70, column 6]
> FTL stack trace ("~" means nesting-related): - Failed at: #if
> parameters.loadFromCdn!false [in template "template/jquery/head.ftl" at line
> 70, column 1]
> Java stack trace (for programmers):freemarker.core.NonBooleanException:
> [... Exception message was already printed; see it above ...] at
> freemarker.core.Expression.modelToBoolean(Expression.java:195) at
> freemarker.core.Expression.evalToBoolean(Expression.java:178)at
> freemarker.core.Expression.evalToBoolean(Expression.java:163)at
> freemarker.core.IfBlock.accept(IfBlock.java:50) at
> freemarker.core.Environment.visit(Environment.java:344) at
> freemarker.core.Environment.visit(Environment.java:350) at
> freemarker.core.Environment.process(Environment.java:323)at
> freemarker.template.Template.process(Template.java:383) at
> org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:154)
> at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:594)
> at org.apache.struts2.components.UIBean.end(UIBean.java:553)at
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
>at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspx_meth_sj_005fhead_005f0(events_jsp.java:178)
> at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspService(events_jsp.java:135)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5452) Freemarker error with empty boolean parameter
[
https://issues.apache.org/jira/browse/WW-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-5452:
--
Fix Version/s: 7.0.0
> Freemarker error with empty boolean parameter
> -
>
> Key: WW-5452
> URL: https://issues.apache.org/jira/browse/WW-5452
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language
>Affects Versions: 7.0.0
>Reporter: Johannes Geppert
>Priority: Major
> Fix For: 7.0.0
>
>
> Switching to latest milestone release for version 7.0.0 resulted in
> freemarker errors when building Struts jQuery Plugin.
>
> {code:java}
> FreeMarker template error:For "#if" condition: Expected a boolean, but this
> has evaluated to an extended_hash+string
> (org.apache.struts2.dispatcher.Parameter$Empty wrapped into
> f.e.b.GenericObjectModel):==> parameters.loadFromCdn!false [in template
> "template/jquery/head.ftl" at line 70, column 6]
> FTL stack trace ("~" means nesting-related): - Failed at: #if
> parameters.loadFromCdn!false [in template "template/jquery/head.ftl" at line
> 70, column 1]
> Java stack trace (for programmers):freemarker.core.NonBooleanException:
> [... Exception message was already printed; see it above ...] at
> freemarker.core.Expression.modelToBoolean(Expression.java:195) at
> freemarker.core.Expression.evalToBoolean(Expression.java:178)at
> freemarker.core.Expression.evalToBoolean(Expression.java:163)at
> freemarker.core.IfBlock.accept(IfBlock.java:50) at
> freemarker.core.Environment.visit(Environment.java:344) at
> freemarker.core.Environment.visit(Environment.java:350) at
> freemarker.core.Environment.process(Environment.java:323)at
> freemarker.template.Template.process(Template.java:383) at
> org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:154)
> at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:594)
> at org.apache.struts2.components.UIBean.end(UIBean.java:553)at
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
>at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspx_meth_sj_005fhead_005f0(events_jsp.java:178)
> at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspService(events_jsp.java:135)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (WW-5452) Freemarker error with empty boolean parameter
[
https://issues.apache.org/jira/browse/WW-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart reassigned WW-5452:
-
Assignee: Lukasz Lenart
> Freemarker error with empty boolean parameter
> -
>
> Key: WW-5452
> URL: https://issues.apache.org/jira/browse/WW-5452
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language
>Affects Versions: 7.0.0
>Reporter: Johannes Geppert
>Assignee: Lukasz Lenart
>Priority: Major
> Fix For: 7.0.0
>
>
> Switching to latest milestone release for version 7.0.0 resulted in
> freemarker errors when building Struts jQuery Plugin.
>
> {code:java}
> FreeMarker template error:For "#if" condition: Expected a boolean, but this
> has evaluated to an extended_hash+string
> (org.apache.struts2.dispatcher.Parameter$Empty wrapped into
> f.e.b.GenericObjectModel):==> parameters.loadFromCdn!false [in template
> "template/jquery/head.ftl" at line 70, column 6]
> FTL stack trace ("~" means nesting-related): - Failed at: #if
> parameters.loadFromCdn!false [in template "template/jquery/head.ftl" at line
> 70, column 1]
> Java stack trace (for programmers):freemarker.core.NonBooleanException:
> [... Exception message was already printed; see it above ...] at
> freemarker.core.Expression.modelToBoolean(Expression.java:195) at
> freemarker.core.Expression.evalToBoolean(Expression.java:178)at
> freemarker.core.Expression.evalToBoolean(Expression.java:163)at
> freemarker.core.IfBlock.accept(IfBlock.java:50) at
> freemarker.core.Environment.visit(Environment.java:344) at
> freemarker.core.Environment.visit(Environment.java:350) at
> freemarker.core.Environment.process(Environment.java:323)at
> freemarker.template.Template.process(Template.java:383) at
> org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:154)
> at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:594)
> at org.apache.struts2.components.UIBean.end(UIBean.java:553)at
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
>at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspx_meth_sj_005fhead_005f0(events_jsp.java:178)
> at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspService(events_jsp.java:135)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869915#comment-17869915
]
Lukasz Lenart commented on WW-5451:
---
Wrong, it's related to changes in WW-5352
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5452) Freemarker error with empty boolean parameter
[
https://issues.apache.org/jira/browse/WW-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johannes Geppert updated WW-5452:
-
Description:
Switching to latest milestone release for version 7.0.0 resulted in freemarker
errors when building Struts jQuery Plugin.
{code:java}
FreeMarker template error:For "#if" condition: Expected a boolean, but this has
evaluated to an extended_hash+string
(org.apache.struts2.dispatcher.Parameter$Empty wrapped into
f.e.b.GenericObjectModel):==> parameters.loadFromCdn!false [in template
"template/jquery/head.ftl" at line 70, column 6]
FTL stack trace ("~" means nesting-related):- Failed at: #if
parameters.loadFromCdn!false [in template "template/jquery/head.ftl" at line
70, column 1]
Java stack trace (for programmers):freemarker.core.NonBooleanException:
[... Exception message was already printed; see it above ...] at
freemarker.core.Expression.modelToBoolean(Expression.java:195) at
freemarker.core.Expression.evalToBoolean(Expression.java:178)at
freemarker.core.Expression.evalToBoolean(Expression.java:163)at
freemarker.core.IfBlock.accept(IfBlock.java:50) at
freemarker.core.Environment.visit(Environment.java:344) at
freemarker.core.Environment.visit(Environment.java:350) at
freemarker.core.Environment.process(Environment.java:323)at
freemarker.template.Template.process(Template.java:383) at
org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:154)
at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:594) at
org.apache.struts2.components.UIBean.end(UIBean.java:553)at
org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
at
org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspx_meth_sj_005fhead_005f0(events_jsp.java:178)
at
org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspService(events_jsp.java:135)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)
{code}
> Freemarker error with empty boolean parameter
> -
>
> Key: WW-5452
> URL: https://issues.apache.org/jira/browse/WW-5452
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language
>Affects Versions: 7.0.0
>Reporter: Johannes Geppert
>Priority: Major
>
> Switching to latest milestone release for version 7.0.0 resulted in
> freemarker errors when building Struts jQuery Plugin.
>
> {code:java}
> FreeMarker template error:For "#if" condition: Expected a boolean, but this
> has evaluated to an extended_hash+string
> (org.apache.struts2.dispatcher.Parameter$Empty wrapped into
> f.e.b.GenericObjectModel):==> parameters.loadFromCdn!false [in template
> "template/jquery/head.ftl" at line 70, column 6]
> FTL stack trace ("~" means nesting-related): - Failed at: #if
> parameters.loadFromCdn!false [in template "template/jquery/head.ftl" at line
> 70, column 1]
> Java stack trace (for programmers):freemarker.core.NonBooleanException:
> [... Exception message was already printed; see it above ...] at
> freemarker.core.Expression.modelToBoolean(Expression.java:195) at
> freemarker.core.Expression.evalToBoolean(Expression.java:178)at
> freemarker.core.Expression.evalToBoolean(Expression.java:163)at
> freemarker.core.IfBlock.accept(IfBlock.java:50) at
> freemarker.core.Environment.visit(Environment.java:344) at
> freemarker.core.Environment.visit(Environment.java:350) at
> freemarker.core.Environment.process(Environment.java:323)at
> freemarker.template.Template.process(Template.java:383) at
> org.apache.struts2.components.template.FreemarkerTemplateEngine.renderTemplate(FreemarkerTemplateEngine.java:154)
> at org.apache.struts2.components.UIBean.mergeTemplate(UIBean.java:594)
> at org.apache.struts2.components.UIBean.end(UIBean.java:553)at
> org.apache.struts2.views.jsp.ComponentTagSupport.doEndTag(ComponentTagSupport.java:39)
>at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspx_meth_sj_005fhead_005f0(events_jsp.java:178)
> at
> org.apache.jsp.WEB_002dINF.content.uncompressed.div.events_jsp._jspService(events_jsp.java:135)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:587)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (WW-5452) Freemarker error with empty boolean parameter
Johannes Geppert created WW-5452: Summary: Freemarker error with empty boolean parameter Key: WW-5452 URL: https://issues.apache.org/jira/browse/WW-5452 Project: Struts 2 Issue Type: Bug Components: Expression Language Affects Versions: 7.0.0 Reporter: Johannes Geppert -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869914#comment-17869914
]
Lukasz Lenart commented on WW-5451:
---
Could you post a stacktrace?
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869912#comment-17869912
]
Lukasz Lenart commented on WW-5451:
---
It can be related to WW-5360 and [PR
852|https://github.com/apache/struts/pull/852]
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-5451:
--
Fix Version/s: 6.7.0
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
> Fix For: 6.7.0
>
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5451) NullPointerException when value array contains a null in the first entry
[
https://issues.apache.org/jira/browse/WW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Pulice updated WW-5451:
---
Summary: NullPointerException when value array contains a null
in the first entry (was: NullPointerException when value array
contains a null in the first entry)
> NullPointerException when value array contains a null in the
> first entry
> -
>
> Key: WW-5451
> URL: https://issues.apache.org/jira/browse/WW-5451
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.4.0
>Reporter: Jon Pulice
>Priority: Minor
>
> When the first entry in an array contains a null value, and that array is
> used as the source for an tag, a NullPointerException is thrown.
> This exception did not occur in prior versions of Struts 6.x
> Exception:
>
> {code:java}
> ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
> occurred during processing request: null
> java.lang.NullPointerException: null
> at
> org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
> ~[struts2-core-6.4.0.jar:6.4.0]
> at
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
> ~[struts2-core-6.4.0.jar:6.4.0]
> ...{code}
>
>
> A trivial example would be this tag:
> {code:java}
>
> ...
> {code}
> and Action:
>
> {code:java}
> public class TestAction extends ActionSupport {
> private Object[] pages = null;
>
> public String prompt() throws Exception {
> pages = new Object[10];
> return SUCCESS;
> }
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (WW-5451) NullPointerException when value array contains a null in the first entry
Jon Pulice created WW-5451:
--
Summary: NullPointerException when value array
contains a null in the first entry
Key: WW-5451
URL: https://issues.apache.org/jira/browse/WW-5451
Project: Struts 2
Issue Type: Bug
Affects Versions: 6.4.0
Reporter: Jon Pulice
When the first entry in an array contains a null value, and that array is used
as the source for an tag, a NullPointerException is thrown. This
exception did not occur in prior versions of Struts 6.x
Exception:
{code:java}
ERROR org.apache.struts2.dispatcher.DefaultDispatcherErrorHandler - Exception
occurred during processing request: null
java.lang.NullPointerException: null
at
org.apache.struts2.components.IteratorComponent.start(IteratorComponent.java:309)
~[struts2-core-6.4.0.jar:6.4.0]
at
org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport.java:51)
~[struts2-core-6.4.0.jar:6.4.0]
...{code}
A trivial example would be this tag:
{code:java}
...
{code}
and Action:
{code:java}
public class TestAction extends ActionSupport {
private Object[] pages = null;
public String prompt() throws Exception {
pages = new Object[10];
return SUCCESS;
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?focusedWorklogId=927750=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927750 ] ASF GitHub Bot logged work on WW-5449: -- Author: ASF GitHub Bot Created on: 29/Jul/24 09:32 Start Date: 29/Jul/24 09:32 Worklog Time Spent: 10m Work Description: kusalk merged PR #1005: URL: https://github.com/apache/struts/pull/1005 Issue Time Tracking --- Worklog Id: (was: 927750) Time Spent: 50m (was: 40m) > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-5450:
--
Fix Version/s: 7.0.0
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
> Fix For: 7.0.0
>
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> —
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rubens Gomes updated WW-5450:
-
Description:
I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring Security
with embedded tomcat version is "10.1.26"
Environment:
Struts 2 "7.0.0-M9"
Spring Boot "3.3.2"
Tomcat "10.1.26"
Java 21
I have a Struts Action class annotated with :
{code:java}
@Result(
name = Action.INPUT,
location = "/WEB-INF/content/%{#request.device}/login.jsp",
type = "dispatcher"
){code}
I have noticed that after returning from the Action class
(ViewLoginAction.java) the framework is invoking the above JSP using a
DispatcherType.GET instead of DisplatcherType.FORWARD.
StrutsRequestWrapper is missing request attribute
"jakarta.servlet.forward.request_uri"
Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward method
fails to find that attribute in the following line:
{code:java}
if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
{
...
...
// then tomcat defaults to setting value of various request attributes
...
...
}
{code}
And after that, tomcat calls "processRequest(request, response, state);" in the
same instance "ApplicationDispatcher" and fails to resolve a FORWARD dispatcher
type below.
Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type it
does a GET on the JSP, instead of FORWARD.
Should StrutsRequestWrapper have request attribute
"jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
instead of FORWARD?
I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded Tomcat
"9.0.83". which is based on javax.servlet instead.
—
Rubens Gomes
was:
I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring Security
with embedded tomcat version is "10.1.26"
I have a Struts Action class annotated with :
{code:java}
@Result(
name = Action.INPUT,
location = "/WEB-INF/content/%{#request.device}/login.jsp",
type = "dispatcher"
){code}
I have noticed that after returning from the Action class
(ViewLoginAction.java) the framework is invoking the above JSP using a
DispatcherType.GET instead of DisplatcherType.FORWARD.
StrutsRequestWrapper is missing request attribute
"jakarta.servlet.forward.request_uri"
Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward method
fails to find that attribute in the following line:
{code:java}
if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
{
...
...
// then tomcat defaults to setting value of various request attributes
...
...
}
{code}
And after that, tomcat calls "processRequest(request, response, state);" in the
same instance "ApplicationDispatcher" and fails to resolve a FORWARD dispatcher
type below.
Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type it
does a GET on the JSP, instead of FORWARD.
Should StrutsRequestWrapper have request attribute
"jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
instead of FORWARD?
I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded Tomcat
"9.0.83". which is based on javax.servlet instead.
---
Rubens Gomes
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
>
> Environment:
> Struts 2 "7.0.0-M9"
> Spring Boot "3.3.2"
> Tomcat "10.1.26"
> Java 21
>
> I have a Struts Action class annotated with :
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> met
[jira] [Commented] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
[
https://issues.apache.org/jira/browse/WW-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17869210#comment-17869210
]
Rubens Gomes commented on WW-5450:
--
More details reported in the Struts-User Mailing List link below entitled:
"Struts ServletDispatcherResult Forwarding GET Instead of FORWARD"
posted on Monday, July 22, 2024 10:23:51 AM CDT
[https://lists.apache.org/thread/dbgqnl76gqv36hv4hmosn9xm9hy43xx8]
> ServletDispatcherResult Forwarding GET Instead of FORWARD
> -
>
> Key: WW-5450
> URL: https://issues.apache.org/jira/browse/WW-5450
> Project: Struts 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 7.0.0
>Reporter: Rubens Gomes
>Priority: Major
>
> I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring
> Security with embedded tomcat version is "10.1.26"
> I have a Struts Action class annotated with :
>
> {code:java}
> @Result(
> name = Action.INPUT,
> location = "/WEB-INF/content/%{#request.device}/login.jsp",
> type = "dispatcher"
> ){code}
>
> I have noticed that after returning from the Action class
> (ViewLoginAction.java) the framework is invoking the above JSP using a
> DispatcherType.GET instead of DisplatcherType.FORWARD.
>
> StrutsRequestWrapper is missing request attribute
> "jakarta.servlet.forward.request_uri"
>
> Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward
> method fails to find that attribute in the following line:
>
>
> {code:java}
> if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
> {
> ...
> ...
> // then tomcat defaults to setting value of various request attributes
> ...
> ...
> }
>
> {code}
>
> And after that, tomcat calls "processRequest(request, response, state);" in
> the same instance "ApplicationDispatcher" and fails to resolve a FORWARD
> dispatcher type below.
>
> Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type
> it does a GET on the JSP, instead of FORWARD.
>
> Should StrutsRequestWrapper have request attribute
> "jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
> instead of FORWARD?
>
> I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded
> Tomcat "9.0.83". which is based on javax.servlet instead.
>
> ---
> Rubens Gomes
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (WW-5450) ServletDispatcherResult Forwarding GET Instead of FORWARD
Rubens Gomes created WW-5450:
Summary: ServletDispatcherResult Forwarding GET Instead of FORWARD
Key: WW-5450
URL: https://issues.apache.org/jira/browse/WW-5450
Project: Struts 2
Issue Type: Bug
Components: Core
Affects Versions: 7.0.0
Reporter: Rubens Gomes
I am running Struts "7.0.0-M9" along with Spring Boot "3.3.2" + Spring Security
with embedded tomcat version is "10.1.26"
I have a Struts Action class annotated with :
{code:java}
@Result(
name = Action.INPUT,
location = "/WEB-INF/content/%{#request.device}/login.jsp",
type = "dispatcher"
){code}
I have noticed that after returning from the Action class
(ViewLoginAction.java) the framework is invoking the above JSP using a
DispatcherType.GET instead of DisplatcherType.FORWARD.
StrutsRequestWrapper is missing request attribute
"jakarta.servlet.forward.request_uri"
Then, tomcat "org.apache.catalina.core.ApplicationDispatcher" doForward method
fails to find that attribute in the following line:
{code:java}
if (hrequest.getAttribute(FORWARD_REQUEST_URI) == null)
{
...
...
// then tomcat defaults to setting value of various request attributes
...
...
}
{code}
And after that, tomcat calls "processRequest(request, response, state);" in the
same instance "ApplicationDispatcher" and fails to resolve a FORWARD dispatcher
type below.
Instead, it resolves a REQUEST. And when tomcat sees REQUEST dispatcher type it
does a GET on the JSP, instead of FORWARD.
Should StrutsRequestWrapper have request attribute
"jakarta.servlet.forward.request_uri"? If not why tomcat is resolving a GET
instead of FORWARD?
I do not see this issue with Struts 6.6.0 + Spring 2.7.18 with embedded Tomcat
"9.0.83". which is based on javax.servlet instead.
---
Rubens Gomes
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (WW-5440) Fix OGNL allowlist compatibility with Convention plugin
[ https://issues.apache.org/jira/browse/WW-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage resolved WW-5440. - Resolution: Fixed > Fix OGNL allowlist compatibility with Convention plugin > --- > > Key: WW-5440 > URL: https://issues.apache.org/jira/browse/WW-5440 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Convention >Affects Versions: 6.4.0 >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.6.0, 7.0.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (WW-5353) Implement stronger security defaults in Struts 7.0
[
https://issues.apache.org/jira/browse/WW-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kusal Kithul-Godage resolved WW-5353.
-
Resolution: Fixed
> Implement stronger security defaults in Struts 7.0
> --
>
> Key: WW-5353
> URL: https://issues.apache.org/jira/browse/WW-5353
> Project: Struts 2
> Issue Type: Improvement
>Reporter: Kusal Kithul-Godage
>Priority: Major
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{struts.ognl.allowStaticFieldAccess=false}}
> {{struts.ognl.excludedNodeTypes=}}
> {{struts.ognl.expressionMaxLength=150}}
> {{struts.disallowDefaultPackageAccess=true}}
> {{struts.disallowProxyMemberAccess=true}}
> {{struts.parameters.requireAnnotations=true}}
> {{struts.ognl.disallowCustomOgnlMap=true}}
> {{struts.allowlist.enable=true}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kusal Kithul-Godage resolved WW-5411.
-
Resolution: Fixed
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5440) Fix OGNL allowlist compatibility with Convention plugin
[ https://issues.apache.org/jira/browse/WW-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage updated WW-5440: Fix Version/s: 6.6.0 (was: 6.7.0) > Fix OGNL allowlist compatibility with Convention plugin > --- > > Key: WW-5440 > URL: https://issues.apache.org/jira/browse/WW-5440 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - Convention >Affects Versions: 6.4.0 >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.6.0, 7.0.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?focusedWorklogId=927524=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927524 ] ASF GitHub Bot logged work on WW-5449: -- Author: ASF GitHub Bot Created on: 26/Jul/24 10:27 Start Date: 26/Jul/24 10:27 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #1005: URL: https://github.com/apache/struts/pull/1005#issuecomment-2252460251 ## [](https://sonarcloud.io/dashboard?id=apache_struts=1005) **Quality Gate passed** Issues  [6 New issues](https://sonarcloud.io/project/issues?id=apache_struts=1005=OPEN,CONFIRMED=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts=1005=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1005=OPEN,CONFIRMED=true)  [82.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1005=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1005=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1005) Issue Time Tracking --- Worklog Id: (was: 927524) Time Spent: 40m (was: 0.5h) > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?focusedWorklogId=927522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927522 ] ASF GitHub Bot logged work on WW-5449: -- Author: ASF GitHub Bot Created on: 26/Jul/24 10:06 Start Date: 26/Jul/24 10:06 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #1005: URL: https://github.com/apache/struts/pull/1005#issuecomment-2252423047 ## [](https://sonarcloud.io/dashboard?id=apache_struts=1005) **Quality Gate failed** Failed conditions  [70.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1005=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1005) Issue Time Tracking --- Worklog Id: (was: 927522) Time Spent: 0.5h (was: 20m) > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?focusedWorklogId=927518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927518 ] ASF GitHub Bot logged work on WW-5449: -- Author: ASF GitHub Bot Created on: 26/Jul/24 09:36 Start Date: 26/Jul/24 09:36 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #1005: URL: https://github.com/apache/struts/pull/1005#issuecomment-2252355153 ## [](https://sonarcloud.io/dashboard?id=apache_struts=1005) **Quality Gate failed** Failed conditions  [62.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts=1005=new_coverage=list) (required ≥ 80%) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1005) Issue Time Tracking --- Worklog Id: (was: 927518) Time Spent: 20m (was: 10m) > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?focusedWorklogId=927517=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927517 ] ASF GitHub Bot logged work on WW-5449: -- Author: ASF GitHub Bot Created on: 26/Jul/24 09:20 Start Date: 26/Jul/24 09:20 Worklog Time Spent: 10m Work Description: kusalk opened a new pull request, #1005: URL: https://github.com/apache/struts/pull/1005 WW-5449 -- I suspect many applications that use the Velocity plugin don't need Velocity Tools. By extracting the Velocity Tools functionality into a separate class `VelocityTools` we give applications the ability to opt out. This class will only be initialised if `struts.velocity.toolboxlocation` is set. I've also refactored `VelocityManager` to be more readable. Issue Time Tracking --- Worklog Id: (was: 927517) Remaining Estimate: 0h Time Spent: 10m > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5449) Make Velocity Tools dependency optional for Velocity plugin
[ https://issues.apache.org/jira/browse/WW-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kusal Kithul-Godage updated WW-5449: Summary: Make Velocity Tools dependency optional for Velocity plugin (was: Remove Velocity plugin dependency on Velocity Tools) > Make Velocity Tools dependency optional for Velocity plugin > --- > > Key: WW-5449 > URL: https://issues.apache.org/jira/browse/WW-5449 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 7.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5449) Remove Velocity plugin dependency on Velocity Tools
Kusal Kithul-Godage created WW-5449: --- Summary: Remove Velocity plugin dependency on Velocity Tools Key: WW-5449 URL: https://issues.apache.org/jira/browse/WW-5449 Project: Struts 2 Issue Type: Improvement Components: Plugin - Velocity Reporter: Kusal Kithul-Godage Fix For: 7.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927516=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927516
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 09:14
Start Date: 26/Jul/24 09:14
Worklog Time Spent: 10m
Work Description: kusalk merged PR #1004:
URL: https://github.com/apache/struts/pull/1004
Issue Time Tracking
---
Worklog Id: (was: 927516)
Time Spent: 3h 10m (was: 3h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927502=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927502
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 07:35
Start Date: 26/Jul/24 07:35
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1004:
URL: https://github.com/apache/struts/pull/1004#issuecomment-2252151055
## [](https://sonarcloud.io/dashboard?id=apache_struts=1004)
**Quality Gate passed**
Issues
 [0 New
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0 Accepted
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=ACCEPTED)
Measures
 [0 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_coverage=list)
 [0.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_duplicated_lines_density=list)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1004)
Issue Time Tracking
---
Worklog Id: (was: 927502)
Time Spent: 3h (was: 2h 50m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927497=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927497
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 07:22
Start Date: 26/Jul/24 07:22
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1004:
URL: https://github.com/apache/struts/pull/1004#issuecomment-2252133036
## [](https://sonarcloud.io/dashboard?id=apache_struts=1004)
**Quality Gate passed**
Issues
 [0 New
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0 Accepted
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=ACCEPTED)
Measures
 [0 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_coverage=list)
 [0.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_duplicated_lines_density=list)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1004)
Issue Time Tracking
---
Worklog Id: (was: 927497)
Time Spent: 2h 50m (was: 2h 40m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927494=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927494
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 07:05
Start Date: 26/Jul/24 07:05
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1004:
URL: https://github.com/apache/struts/pull/1004#issuecomment-2252110174
## [](https://sonarcloud.io/dashboard?id=apache_struts=1004)
**Quality Gate passed**
Issues
 [0 New
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0 Accepted
issues](https://sonarcloud.io/project/issues?id=apache_struts=1004=ACCEPTED)
Measures
 [0 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1004=OPEN,CONFIRMED=true)
 [0.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_coverage=list)
 [0.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1004=new_duplicated_lines_density=list)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1004)
Issue Time Tracking
---
Worklog Id: (was: 927494)
Time Spent: 2h 40m (was: 2.5h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927492=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927492
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 07:00
Start Date: 26/Jul/24 07:00
Worklog Time Spent: 10m
Work Description: kusalk opened a new pull request, #1004:
URL: https://github.com/apache/struts/pull/1004
WW-5411
--
Issue Time Tracking
---
Worklog Id: (was: 927492)
Time Spent: 2.5h (was: 2h 20m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927478=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927478
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 26/Jul/24 00:16
Start Date: 26/Jul/24 00:16
Worklog Time Spent: 10m
Work Description: kusalk merged PR #1003:
URL: https://github.com/apache/struts/pull/1003
Issue Time Tracking
---
Worklog Id: (was: 927478)
Time Spent: 2h 20m (was: 2h 10m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (WW-5448) Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0
[ https://issues.apache.org/jira/browse/WW-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart closed WW-5448. - Resolution: Fixed > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > --- > > Key: WW-5448 > URL: https://issues.apache.org/jira/browse/WW-5448 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 6.7.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > [https://github.com/apache/struts/pull/1000] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5448) Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0
[ https://issues.apache.org/jira/browse/WW-5448?focusedWorklogId=927452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927452 ] ASF GitHub Bot logged work on WW-5448: -- Author: ASF GitHub Bot Created on: 25/Jul/24 18:05 Start Date: 25/Jul/24 18:05 Worklog Time Spent: 10m Work Description: lukaszlenart merged PR #1000: URL: https://github.com/apache/struts/pull/1000 Issue Time Tracking --- Worklog Id: (was: 927452) Remaining Estimate: 0h Time Spent: 10m > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > --- > > Key: WW-5448 > URL: https://issues.apache.org/jira/browse/WW-5448 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 6.7.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > [https://github.com/apache/struts/pull/1000] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5448) Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0
[ https://issues.apache.org/jira/browse/WW-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5448: -- Description: Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 [https://github.com/apache/struts/pull/1000] was: h1. Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 https://github.com/apache/struts/pull/1000 > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > --- > > Key: WW-5448 > URL: https://issues.apache.org/jira/browse/WW-5448 > Project: Struts 2 > Issue Type: Dependency > Components: Core >Reporter: Lukasz Lenart >Priority: Minor > Fix For: 6.7.0 > > > Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 > [https://github.com/apache/struts/pull/1000] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5448) Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0
Lukasz Lenart created WW-5448: - Summary: Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 Key: WW-5448 URL: https://issues.apache.org/jira/browse/WW-5448 Project: Struts 2 Issue Type: Dependency Components: Core Reporter: Lukasz Lenart Fix For: 6.7.0 h1. Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 https://github.com/apache/struts/pull/1000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927433=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927433
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 15:54
Start Date: 25/Jul/24 15:54
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1003:
URL: https://github.com/apache/struts/pull/1003#issuecomment-2250771475
## [](https://sonarcloud.io/dashboard?id=apache_struts=1003)
**Quality Gate failed**
Failed conditions
 [74.2% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1003=new_coverage=list)
(required ≥ 80%)
 [3.4% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1003=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1003)
Issue Time Tracking
---
Worklog Id: (was: 927433)
Time Spent: 2h 10m (was: 2h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927432
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 15:48
Start Date: 25/Jul/24 15:48
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1003:
URL: https://github.com/apache/struts/pull/1003#issuecomment-2250749433
## [](https://sonarcloud.io/dashboard?id=apache_struts=1003)
**Quality Gate failed**
Failed conditions
 [74.2% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1003=new_coverage=list)
(required ≥ 80%)
 [3.4% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1003=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1003)
Issue Time Tracking
---
Worklog Id: (was: 927432)
Time Spent: 2h (was: 1h 50m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927430
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 15:30
Start Date: 25/Jul/24 15:30
Worklog Time Spent: 10m
Work Description: kusalk opened a new pull request, #1003:
URL: https://github.com/apache/struts/pull/1003
WW-5411
--
Issue Time Tracking
---
Worklog Id: (was: 927430)
Time Spent: 1h 50m (was: 1h 40m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927429
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 15:29
Start Date: 25/Jul/24 15:29
Worklog Time Spent: 10m
Work Description: kusalk merged PR #1002:
URL: https://github.com/apache/struts/pull/1002
Issue Time Tracking
---
Worklog Id: (was: 927429)
Time Spent: 1h 40m (was: 1.5h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927400=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927400
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 11:22
Start Date: 25/Jul/24 11:22
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1002:
URL: https://github.com/apache/struts/pull/1002#issuecomment-2250091480
## [](https://sonarcloud.io/dashboard?id=apache_struts=1002)
**Quality Gate failed**
Failed conditions
 [1 Security
Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_struts=1002=OPEN,CONFIRMED=true)
 [59.6% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_coverage=list)
(required ≥ 80%)
 [6.1% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1002)
Issue Time Tracking
---
Worklog Id: (was: 927400)
Time Spent: 1.5h (was: 1h 20m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927397=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927397
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 10:30
Start Date: 25/Jul/24 10:30
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1002:
URL: https://github.com/apache/struts/pull/1002#issuecomment-2250003587
## [](https://sonarcloud.io/dashboard?id=apache_struts=1002)
**Quality Gate failed**
Failed conditions
 [69.5% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_coverage=list)
(required ≥ 80%)
 [10.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1002)
Issue Time Tracking
---
Worklog Id: (was: 927397)
Time Spent: 1h 20m (was: 1h 10m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927394=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927394
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 10:18
Start Date: 25/Jul/24 10:18
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1002:
URL: https://github.com/apache/struts/pull/1002#issuecomment-2249983397
## [](https://sonarcloud.io/dashboard?id=apache_struts=1002)
**Quality Gate failed**
Failed conditions
 [73.7% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_coverage=list)
(required ≥ 80%)
 [6.5% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1002)
Issue Time Tracking
---
Worklog Id: (was: 927394)
Time Spent: 1h 10m (was: 1h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927393=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927393
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 10:18
Start Date: 25/Jul/24 10:18
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1002:
URL: https://github.com/apache/struts/pull/1002#issuecomment-2249982599
## [](https://sonarcloud.io/dashboard?id=apache_struts=1002)
**Quality Gate failed**
Failed conditions
 [62.5% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_coverage=list)
(required ≥ 80%)
 [8.3% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_duplicated_lines_density=list)
(required ≤ 3%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1002)
Issue Time Tracking
---
Worklog Id: (was: 927393)
Time Spent: 1h (was: 50m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927385=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927385
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 09:58
Start Date: 25/Jul/24 09:58
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1002:
URL: https://github.com/apache/struts/pull/1002#issuecomment-2249943709
## [](https://sonarcloud.io/dashboard?id=apache_struts=1002)
**Quality Gate failed**
Failed conditions
 [62.5% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts=1002=new_coverage=list)
(required ≥ 80%)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts=1002)
Issue Time Tracking
---
Worklog Id: (was: 927385)
Time Spent: 50m (was: 40m)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5411) Delete deprecated classes and members
[
https://issues.apache.org/jira/browse/WW-5411?focusedWorklogId=927381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927381
]
ASF GitHub Bot logged work on WW-5411:
--
Author: ASF GitHub Bot
Created on: 25/Jul/24 09:52
Start Date: 25/Jul/24 09:52
Worklog Time Spent: 10m
Work Description: kusalk opened a new pull request, #1002:
URL: https://github.com/apache/struts/pull/1002
WW-5411
--
Issue Time Tracking
---
Worklog Id: (was: 927381)
Time Spent: 40m (was: 0.5h)
> Delete deprecated classes and members
> -
>
> Key: WW-5411
> URL: https://issues.apache.org/jira/browse/WW-5411
> Project: Struts 2
> Issue Type: Task
> Components: Core
>Reporter: Kusal Kithul-Godage
>Priority: Minor
> Fix For: 7.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ToDo:
> {code:java}
> com.opensymphony.xwork2.interceptor.annotations.Allowed
> com.opensymphony.xwork2.interceptor.annotations.BlockByDefault
> com.opensymphony.xwork2.interceptor.annotations.Blocked
> com.opensymphony.xwork2.interceptor.annotations.AnnotationParameterFilterInterceptor
> {code}
> Done:
> {code:java}
> StrutsPrepareAndExecuteFilter#excludedPatterns
> StrutsPrepareFilter#excludedPatterns
> InitOperations#buildExcludedPatternsList
> PrepareOperations#isUrlExcluded(HttpServletRequest, List)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (WW-5447) Radio Tag not supporting labelPosition attribute
[ https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart closed WW-5447. - Resolution: Not A Problem > Radio Tag not supporting labelPosition attribute > > > Key: WW-5447 > URL: https://issues.apache.org/jira/browse/WW-5447 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 6.3.0 >Reporter: gauravseta >Priority: Critical > Fix For: 6.7.0 > > > Radio Tag "s:radio" is not supporting "labelPosition" attribute even though > official docs mentions it in Struts 6.3.0 > # Add "labelPosition" attribute at this line > [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] > 2. though code will build successfully, but as soon as war is deployed in a > container. > 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without > "labelPosition" attribute crud module works fine. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5447) Radio Tag not supporting labelPosition attribute
[ https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868387#comment-17868387 ] Lukasz Lenart commented on WW-5447: --- That's fine, thanks for testing the M9 and helping us! > Radio Tag not supporting labelPosition attribute > > > Key: WW-5447 > URL: https://issues.apache.org/jira/browse/WW-5447 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 6.3.0 >Reporter: gauravseta >Priority: Critical > Fix For: 6.7.0 > > > Radio Tag "s:radio" is not supporting "labelPosition" attribute even though > official docs mentions it in Struts 6.3.0 > # Add "labelPosition" attribute at this line > [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] > 2. though code will build successfully, but as soon as war is deployed in a > container. > 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without > "labelPosition" attribute crud module works fine. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (WW-5447) Radio Tag not supporting labelPosition attribute
[ https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868387#comment-17868387 ] Lukasz Lenart edited comment on WW-5447 at 7/24/24 2:19 PM: That's fine, thanks for testing the version and helping us! was (Author: lukaszlenart): That's fine, thanks for testing the M9 and helping us! > Radio Tag not supporting labelPosition attribute > > > Key: WW-5447 > URL: https://issues.apache.org/jira/browse/WW-5447 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 6.3.0 >Reporter: gauravseta >Priority: Critical > Fix For: 6.7.0 > > > Radio Tag "s:radio" is not supporting "labelPosition" attribute even though > official docs mentions it in Struts 6.3.0 > # Add "labelPosition" attribute at this line > [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] > 2. though code will build successfully, but as soon as war is deployed in a > container. > 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without > "labelPosition" attribute crud module works fine. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5447) Radio Tag not supporting labelPosition attribute
[ https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868386#comment-17868386 ] gauravseta commented on WW-5447: [~lukaszlenart] I have some different observation will raise different some other day, but regarding this I see labelPosition working and i had some cache issues. Apologies for inconvenience. Dont know if I am allowed to close this bug, please if you could close it. > Radio Tag not supporting labelPosition attribute > > > Key: WW-5447 > URL: https://issues.apache.org/jira/browse/WW-5447 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 6.3.0 >Reporter: gauravseta >Priority: Critical > Fix For: 6.7.0 > > > Radio Tag "s:radio" is not supporting "labelPosition" attribute even though > official docs mentions it in Struts 6.3.0 > # Add "labelPosition" attribute at this line > [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] > 2. though code will build successfully, but as soon as war is deployed in a > container. > 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without > "labelPosition" attribute crud module works fine. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WW-5447) Radio Tag not supporting labelPosition attribute
[
https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868301#comment-17868301
]
Lukasz Lenart commented on WW-5447:
---
Are you sure "labelPosition" is the issue? I was able to set it to "top" and
see a change in the layout by applying "tdLabelTop". By default "left" is used
and this corresponds to "tdLabel"
{code:html}
{code}
{code:html}
Gender:
{code}
vs
{code:html}
{code}
{code:html}
Gender:
{code}
> Radio Tag not supporting labelPosition attribute
>
>
> Key: WW-5447
> URL: https://issues.apache.org/jira/browse/WW-5447
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
>Affects Versions: 6.3.0
>Reporter: gauravseta
>Priority: Critical
> Fix For: 6.7.0
>
>
> Radio Tag "s:radio" is not supporting "labelPosition" attribute even though
> official docs mentions it in Struts 6.3.0
> # Add "labelPosition" attribute at this line
> [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28]
> 2. though code will build successfully, but as soon as war is deployed in a
> container.
> 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without
> "labelPosition" attribute crud module works fine.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (WW-5447) Radio Tag not supporting labelPosition attribute
[ https://issues.apache.org/jira/browse/WW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5447: -- Fix Version/s: 6.7.0 > Radio Tag not supporting labelPosition attribute > > > Key: WW-5447 > URL: https://issues.apache.org/jira/browse/WW-5447 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags >Affects Versions: 6.3.0 >Reporter: gauravseta >Priority: Critical > Fix For: 6.7.0 > > > Radio Tag "s:radio" is not supporting "labelPosition" attribute even though > official docs mentions it in Struts 6.3.0 > # Add "labelPosition" attribute at this line > [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] > 2. though code will build successfully, but as soon as war is deployed in a > container. > 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without > "labelPosition" attribute crud module works fine. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (WW-5447) Radio Tag not supporting labelPosition attribute
gauravseta created WW-5447: -- Summary: Radio Tag not supporting labelPosition attribute Key: WW-5447 URL: https://issues.apache.org/jira/browse/WW-5447 Project: Struts 2 Issue Type: Bug Components: Core Tags Affects Versions: 6.3.0 Reporter: gauravseta Radio Tag "s:radio" is not supporting "labelPosition" attribute even though official docs mentions it in Struts 6.3.0 # Add "labelPosition" attribute at this line [https://github.com/apache/struts-examples/blob/master/crud/src/main/webapp/WEB-INF/jsp/editPerson.jsp#L28] 2. though code will build successfully, but as soon as war is deployed in a container. 3. "crud-1.1.0/index.jsp" becomes inaccessible, though without "labelPosition" attribute crud module works fine. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5441) Bump net.sf.jasperreports:jasperreports from 6.21.0 to 6.21.3
[ https://issues.apache.org/jira/browse/WW-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5441: -- Fix Version/s: 6.5.0 (was: 6.6.0) > Bump net.sf.jasperreports:jasperreports from 6.21.0 to 6.21.3 > - > > Key: WW-5441 > URL: https://issues.apache.org/jira/browse/WW-5441 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - JasperReports >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Bump net.sf.jasperreports:jasperreports from 6.21.0 to 6.21.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5442) Enforce allowlist for OgnlReflectionProvider
[ https://issues.apache.org/jira/browse/WW-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5442: -- Fix Version/s: 6.5.0 (was: 6.6.0) > Enforce allowlist for OgnlReflectionProvider > > > Key: WW-5442 > URL: https://issues.apache.org/jira/browse/WW-5442 > Project: Struts 2 > Issue Type: Improvement > Components: Core >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (WW-5443) Bump Spring dependencies from 5.3.31 to 5.3.37
[ https://issues.apache.org/jira/browse/WW-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart updated WW-5443: -- Fix Version/s: 6.5.0 (was: 6.6.0) > Bump Spring dependencies from 5.3.31 to 5.3.37 > -- > > Key: WW-5443 > URL: https://issues.apache.org/jira/browse/WW-5443 > Project: Struts 2 > Issue Type: Dependency > Components: Plugin - Spring >Reporter: Kusal Kithul-Godage >Priority: Minor > Fix For: 6.5.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Bump net.sf.jasperreports:jasperreports from 6.21.0 to 6.21.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
