[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534837#comment-13534837 ] Link Qian commented on WW-3924: --- Not exactly. Struts1, Struts2 file upload framework limits Action to use java.io.File to reference a uploading multipart content from http request because FileUploadIntercetor and MultiPartResolver only expose File type to others class needs. It's hard to extend and low performance fact which discuss more thread more time. Thus, it's necessary refactor the old file upload processing framework. meanwhile, we need to protect user's program work in new struts release including the refactor code as well. So the Ng (new generation) file upload process framework is not constraint, instead of an alternative for experimental framework aim to easy extension and high performance usage. It is easy to switch and is off in default. As Lukasz said, it's a big change with a bit change core code. The patch provides a solution that easy to write plugin, whatever commons-fu, fastupload and others. what use commons-fu API implements NgMultiPartResolver and wrap MultiPart is easy. also I would like to say sorry for the codestyle issue. include license, comments etc. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534786#comment-13534786 ] Rene Gielen commented on WW-3924: - Uhm - sorry guys, but so far this looks not like what we discussed in the list. AFACIS we talked about providing non breaking API extensions to support multipart handler plugins a plugin. It was explicitely not about changing core to use some new library, even not if it is marked optional. Some more concrete stuff regarding the patch - Please provide a pure patch. Roughly two third of this patch is reformatted original code. Please keep your IDE from automatic reformatting. A patch / commit is either functional or reformatting the code, but not both - please tidy up your code. Things like IDEA standard file template comments or commented out code should not go into a patch. Best example is FastUploadMultiPartHandler, which includes a wrong JavaDoc-comment and code in comments. - Again FastUploadMultiPartHandler: Please use one file for one class, as long you are not creating inner classes. This java-File contains two toplevel classes - Please be sure to review your code for general quality. As I understood, you are using IntelliJ IDEA. Reviewing warnings would easily have revealed that in NgFileUploadInterceptor:182 there is a senseless null check due to NPE about to happen before in line 176ff. Also you might want to review Dispatcher#cleanUpRequest, just to name another one - DispatcherTest#testConfigurationManager - what is this URL, split into two lines, one now marking a Java label? That was just a quick first review. A cleaner patch helps reviewing by far... Now regarding the API changes - NG as naming component is a bit unfortunate. What comes in two years, when we have even better ideas? NNG? :) - As I see it, a new API for MultiPart should either be extending the old or providing a full new implementation if you flip the switch. Full means full alternative, that is: it should provide an implementation of the former functionality. Only then it is possible to deprecate the old API and declare the new stuff as API to use. What I see here is having just two APIs, one for commons-fu etc and one for fastupload. An API change proposal should - check wether the old API can be reused, starting with factoring out more general interfaces and more abstract classes in the hierarchy. Did that happen? - if extending the old doesn't work, provide a complete implemetation for the former functionality. That is, implement a commons-fu Provider For the integration of fastupload itself: This library and related implementations will not make it into core any time soon, as it would not for other "new" libs. You are providing an implementation alternative. Fine. That's what plugis are for. So if a new MultiPart API makes it into the distribution, feel free to provide a plugin, maybe as part of your library distribution. A small tip: even if we would want to include the lib into our distro, we couldn't. You don't provide any license. To make it into any Apache related distro, a library must be released under a APL compatible license. To get adoption at all, your lib should generally be released under an accepted OSS license. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534748#comment-13534748 ] Link Qian commented on WW-3924: --- hence the patch is based struts 2.3.7. if you find any issue when patch it into struts 2.3.8 codebase. please let me know. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534742#comment-13534742 ] Lukasz Lenart commented on WW-3924: --- When I'll have a time ;-) > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534740#comment-13534740 ] Link Qian commented on WW-3924: --- sure, when will you review it. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534738#comment-13534738 ] Lukasz Lenart commented on WW-3924: --- But it must be reviewed by a committer and that takes time. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534736#comment-13534736 ] Link Qian commented on WW-3924: --- all code is tested, you're safe to introduce current release > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534734#comment-13534734 ] Lukasz Lenart commented on WW-3924: --- Because the change was huge and I didn't want to introduce such big change as the main goal of 2.3.8 was to improve performance - which was broken. It's simple matter of what is more important. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534731#comment-13534731 ] Link Qian commented on WW-3924: --- why nope > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534693#comment-13534693 ] Lukasz Lenart commented on WW-3924: --- Nope > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534484#comment-13534484 ] Link Qian commented on WW-3924: --- does the patch merge into struts 2.3.8? > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.9 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529704#comment-13529704 ] Lukasz Lenart commented on WW-3924: --- No specific date right now, but probably soon > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529607#comment-13529607 ] Link Qian commented on WW-3924: --- when shall struts 2.3.8 release? > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509576#comment-13509576 ] Lukasz Lenart commented on WW-3924: --- You're not allowed to do it ;-) It will be introduced sooner or later :-) > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509564#comment-13509564 ] Link Qian commented on WW-3924: --- should I implement the change into code SVN repository? > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508558#comment-13508558 ] Lukasz Lenart commented on WW-3924: --- As I see, Fastupload, library is already in Maven Central Repo so I think we can implement the change. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Attachments: fileupload-patch.txt > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501750#comment-13501750 ] Lukasz Lenart commented on WW-3924: --- Perfect! > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501744#comment-13501744 ] Link Qian commented on WW-3924: --- patch will be ready in future. > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3924) refactor file upload framework
[ https://issues.apache.org/jira/browse/WW-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501726#comment-13501726 ] Lukasz Lenart commented on WW-3924: --- Could you attach a patch ? > refactor file upload framework > -- > > Key: WW-3924 > URL: https://issues.apache.org/jira/browse/WW-3924 > Project: Struts 2 > Issue Type: Improvement > Components: "New" API, Integration >Affects Versions: 2.3.7 > Environment: HTTP, RFC 1867, form-based upload. >Reporter: Link Qian > Labels: features, patch > Fix For: 2.3.8 > > Original Estimate: 504h > Remaining Estimate: 504h > > refactor current file upload framework in Struts2, the goals are: > 1, compatible with current file upload API in Struts2. > 2, enable file upload framework to integration with form-based upload > components easily. > 3, enable user to use stream/memory parsing model beyond temporary file > parsing model. > 4, testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
