[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981826#comment-15981826 ] Hudson commented on WW-3952: SUCCESS: Integrated in Jenkins build Struts-JDK7-master #623 (See [https://builds.apache.org/job/Struts-JDK7-master/623/]) WW-3952 Adds implementation of credit card validator (lukaszlenart: rev 01d710bdf3dace8cf964bcd32d0afe14cf251dc2) * (add) core/src/main/java/com/opensymphony/xwork2/validator/validators/CreditCardValidator.java WW-3952 Adds test to check implementation (lukaszlenart: rev fc497360bee7084293749f712dec233eb219bbf4) * (add) core/src/test/java/com/opensymphony/xwork2/validator/validators/CreditCardValidatorTest.java WW-3952 Introduces annotation (lukaszlenart: rev 743d27f841ce990ed3153f569f890179bdbb6a37) * (add) core/src/main/java/com/opensymphony/xwork2/validator/annotations/CreditCardValidator.java WW-3952 Extends existing logic to handle credit card validation (lukaszlenart: rev 0813eaa0c8f446404243fba87cde51a619643cb9) * (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/RegexFieldValidator.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilder.java * (edit) core/src/main/java/com/opensymphony/xwork2/validator/annotations/Validations.java * (edit) core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationAction.java * (edit) core/src/test/resources/validators.xml WW-3952 Updates test to include credit card validation (lukaszlenart: rev eb4fcb4afc79dac03f6ed0780211f98e72a09851) * (edit) core/src/test/java/com/opensymphony/xwork2/validator/AnnotationValidationConfigurationBuilderTest.java WW-3952 Adds client side validation support (lukaszlenart: rev 9eec07b310b4ac9e99342cfd632293acd2a45d8b) * (edit) core/src/main/resources/template/xhtml/form-close-validate.ftl WW-3952 Fixes test (lukaszlenart: rev 6ef9f7a3aadd1c9dea5ca7a7a5ae350f37e6e96b) * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-2.txt * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-24.txt * (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/Formtag-22.txt > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981194#comment-15981194 ] ASF GitHub Bot commented on WW-3952: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/130 > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980848#comment-15980848 ] ASF subversion and git services commented on WW-3952: - Commit 9eec07b310b4ac9e99342cfd632293acd2a45d8b in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9eec07b ] WW-3952 Adds client side validation support > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980849#comment-15980849 ] ASF subversion and git services commented on WW-3952: - Commit 6ef9f7a3aadd1c9dea5ca7a7a5ae350f37e6e96b in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=6ef9f7a ] WW-3952 Fixes test > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980846#comment-15980846 ] ASF subversion and git services commented on WW-3952: - Commit 0813eaa0c8f446404243fba87cde51a619643cb9 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=0813eaa ] WW-3952 Extends existing logic to handle credit card validation > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980842#comment-15980842 ] ASF subversion and git services commented on WW-3952: - Commit 01d710bdf3dace8cf964bcd32d0afe14cf251dc2 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=01d710b ] WW-3952 Adds implementation of credit card validator > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980847#comment-15980847 ] ASF subversion and git services commented on WW-3952: - Commit eb4fcb4afc79dac03f6ed0780211f98e72a09851 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=eb4fcb4 ] WW-3952 Updates test to include credit card validation > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980845#comment-15980845 ] ASF subversion and git services commented on WW-3952: - Commit 743d27f841ce990ed3153f569f890179bdbb6a37 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=743d27f ] WW-3952 Introduces annotation > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980850#comment-15980850 ] ASF subversion and git services commented on WW-3952: - Commit 775d1c8c65e4207e0590b8d7bfb56f0423f89d90 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=775d1c8 ] WW-3952 introduces credit card validator > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre >Assignee: Lukasz Lenart > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980843#comment-15980843 ] ASF subversion and git services commented on WW-3952: - Commit fc497360bee7084293749f712dec233eb219bbf4 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=fc49736 ] WW-3952 Adds test to check implementation > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978212#comment-15978212 ] ASF GitHub Bot commented on WW-3952: Github user gregh3269 commented on the issue: https://github.com/apache/struts/pull/130 Last time I did some credit card validation, I needed to use a java script version as the payment process obscured the field names by not having the "name" attribute (so it was not obvious when these were sent over https) and I was unable to do server side validation. > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976260#comment-15976260 ] ASF GitHub Bot commented on WW-3952: Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 If patterns change users have another reason to upgrade to latest struts 😆 > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976255#comment-15976255 ] ASF GitHub Bot commented on WW-3952: Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 Good question... I have used those random card numbers in tests and looks ok (but we will see) https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976244#comment-15976244 ] ASF GitHub Bot commented on WW-3952: Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 How often do credit card companies change their number-patterns in a way that the regex needs to be updated? 'guess it is rare enough. > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976230#comment-15976230 ] ASF GitHub Bot commented on WW-3952: Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 > I hope the regex is stable What do you mean by that? I have used this http://www.regular-expressions.info/creditcard.html > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976223#comment-15976223 ] ASF GitHub Bot commented on WW-3952: Github user cnenning commented on the issue: https://github.com/apache/struts/pull/130 I hope the regex is stable 😉 > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976188#comment-15976188 ] ASF GitHub Bot commented on WW-3952: Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/130 This is ready for review > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974975#comment-15974975 ] ASF GitHub Bot commented on WW-3952: GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/130 WW-3952: Credit card validator Implements a credit card validator [WW-3952](https://issues.apache.org/jira/browse/WW-3952) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts credit-card-validations Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #130 commit 01d710bdf3dace8cf964bcd32d0afe14cf251dc2 Author: Lukasz Lenart Date: 2017-04-19T16:05:53Z WW-3952 Adds implementation of credit card validator commit fc497360bee7084293749f712dec233eb219bbf4 Author: Lukasz Lenart Date: 2017-04-19T16:06:17Z WW-3952 Adds test to check implementation commit 743d27f841ce990ed3153f569f890179bdbb6a37 Author: Lukasz Lenart Date: 2017-04-19T16:06:31Z WW-3952 Introduces annotation commit 0813eaa0c8f446404243fba87cde51a619643cb9 Author: Lukasz Lenart Date: 2017-04-19T16:07:16Z WW-3952 Extends existing logic to handle credit card validation commit eb4fcb4afc79dac03f6ed0780211f98e72a09851 Author: Lukasz Lenart Date: 2017-04-19T16:07:38Z WW-3952 Updates test to include credit card validation > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5.next > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078108#comment-14078108 ] Lukasz Lenart commented on WW-3952: --- Postpoining... > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.5 > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[
https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078105#comment-14078105
]
Lukasz Lenart commented on WW-3952:
---
I think the simplest solution is to use {{RegexValidator}} and one of the regex
(or all) for given card vendor
http://www.regular-expressions.info/creditcard.html
> creditCard validator available in Struts 1 missing in Struts 2
> --
>
> Key: WW-3952
> URL: https://issues.apache.org/jira/browse/WW-3952
> Project: Struts 2
> Issue Type: Improvement
> Components: XML Validators
>Affects Versions: 2.3.8
>Reporter: Daniel Le Berre
> Fix For: 2.3.18
>
>
> Struts 1 has a creditCard validator. That validator does not exists in Struts
> 2.
> It would be nice to have also that validator in Struts 2 to allow an easier
> migration from Struts 1 to Struts 2.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966568#comment-13966568 ] Daniel Le Berre commented on WW-3952: - I noticed the problem when I moved my exercises for Struts 1 to Struts 2. The point was to promote the use of a framework for common tasks :) > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.3.18 > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966524#comment-13966524 ] Rene Gielen commented on WW-3952: - Two nice ideas coming to my mind: - show your students how to use RegExp validations, taking credit card number as example - show your students how to implement custom validators, which is fairly easy :) Re-applying the Struts 1 solution has the downside of introducing a fairly heavy new dependency (commons-validator). On the other hand, maybe some people find it useful to create an externally hosted Struts2 plugin for bridging commons-validator... > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.3.18 > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966514#comment-13966514 ] Daniel Le Berre commented on WW-3952: - I know. But good patches are typically non trivial to write when you do not know the codebase, which is the case for me :) (just using struts2 with my students, not on a daily basis on production app) > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.3.18 > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966489#comment-13966489 ] Rene Gielen commented on WW-3952: - [~dleberre] When doing feature requests, patches are always welcome :) > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.3.18 > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-3952) creditCard validator available in Struts 1 missing in Struts 2
[ https://issues.apache.org/jira/browse/WW-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539880#comment-13539880 ] Lukasz Lenart commented on WW-3952: --- Basically, creditCard validator delegates validation to Commons CreditCardValidator http://commons.apache.org/validator/api-1.4.0/org/apache/commons/validator/CreditCardValidator.html > creditCard validator available in Struts 1 missing in Struts 2 > -- > > Key: WW-3952 > URL: https://issues.apache.org/jira/browse/WW-3952 > Project: Struts 2 > Issue Type: Improvement > Components: XML Validators >Affects Versions: 2.3.8 >Reporter: Daniel Le Berre > Fix For: 2.3.x > > > Struts 1 has a creditCard validator. That validator does not exists in Struts > 2. > It would be nice to have also that validator in Struts 2 to allow an easier > migration from Struts 1 to Struts 2. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
