[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045846#comment-14045846 ] ASF GitHub Bot commented on WW-4346: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/13 Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Assignee: Lukasz Lenart Labels: patch Fix For: 2.3.18 Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045844#comment-14045844 ] ASF subversion and git services commented on WW-4346: - Commit 3a07c317724c1f8017be93f0e1bae23392c08fc6 in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3a07c31 ] WW-4346 Solves problem with nested visitor validator returns wrong full field name Closes #13 Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001414#comment-14001414 ] Lukasz Lenart commented on WW-4346: --- Good question! I must clarify that, submitting patches here doesn't make sense for me, but maybe I'm wrong ;-) Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000694#comment-14000694 ] Lukasz Lenart commented on WW-4346: --- Is this the same code as in the Pull Request? Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000731#comment-14000731 ] Aleksandr Mashchenko commented on WW-4346: -- Yes it is. Do we have to attach patch files to issues or PR is enough? Documentation says we should: http://struts.apache.org/git-for-struts.html. Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Attachments: tests-visitor-full-field-name.diff, visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4346) Nested visitor validator returns wrong full field name
[ https://issues.apache.org/jira/browse/WW-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997929#comment-13997929 ] ASF GitHub Bot commented on WW-4346: GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/13 WW-4346 - Nested visitor validator returns wrong full field name get correct full field name in visitor field validator You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m/struts feature/visitor-validator-full-field-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 2b8a805eb0794abd5c804c0bc9059e56b72c985f Author: Aleksandr Mashchenko aleksandr...@gmail.com Date: 2014-05-14T17:22:29Z get correct full field name in visitor field validator Nested visitor validator returns wrong full field name -- Key: WW-4346 URL: https://issues.apache.org/jira/browse/WW-4346 Project: Struts 2 Issue Type: Bug Reporter: Aleksandr Mashchenko Labels: patch Fix For: 2.3.18 Attachments: visitor-full-field-name.diff Original issue report: http://stackoverflow.com/questions/23544452/chaining-visitor-validator-in-struts-2. This bug can be reproduced by nesting two or more visitor validators with a conversion validator in the last validation configuration. Conversion validator in nested visitor validators doesn't work as expected because getFullFieldName method in VisitorFieldValidator.AppendingValidatorContext returns not a full field name. This patch makes sure that the correct full field name is returned. Also the InternalValidatorContextWrapper-s from AnnotationActionValidatorManager and DefaultActionValidatorManager could be removed because they were introduced to fix similar issue with nested visitor validators. See https://issues.apache.org/jira/browse/XW-588 and https://issues.apache.org/jira/browse/XW-618 for more details. -- This message was sent by Atlassian JIRA (v6.2#6252)
