[jira] [Commented] (WW-4355) Remove HTML5 deprecated attributes from templates

2014-06-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017465#comment-14017465
 ] 

ASF GitHub Bot commented on WW-4355:


Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/14#issuecomment-45061200
  
I'm not sure if this is the best idea, I mean hardcoding styles in tags - 
they will always take precedence over CSS classes.


> Remove HTML5 deprecated attributes from templates
> -
>
> Key: WW-4355
> URL: https://issues.apache.org/jira/browse/WW-4355
> Project: Struts 2
>  Issue Type: Improvement
>  Components: Plugin - Tags
>Affects Versions: 2.3.16.3
>Reporter: Aleksandr Mashchenko
>  Labels: patch
> Fix For: 2.3.18
>
>
> Change HTML5 deprecated attributes to CSS in templates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (WW-4355) Remove HTML5 deprecated attributes from templates

2014-06-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WW-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016915#comment-14016915
 ] 

ASF GitHub Bot commented on WW-4355:


GitHub user aleksandr-m opened a pull request:

https://github.com/apache/struts/pull/14

WW-4355 - Remove HTML5 deprecated attributes from templates

Changed HTML5 deprecated attributes to CSS in templates.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aleksandr-m/struts 
feature/remove-html5-deprecations

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 1de0e779f2be090e75f613ad9c87228ac92183ab
Author: Aleksandr Mashchenko 
Date:   2014-05-30T06:27:43Z

converted align and valign to css text-align and vertical-align

commit d0a6d6e895187422547d7e4a3e16d1276ba2e948
Author: Aleksandr Mashchenko 
Date:   2014-06-03T16:38:43Z

js align and valign to style

commit 8953ae3f24849b8f2db1ac3b45e846cc5f27c7a9
Author: Aleksandr Mashchenko 
Date:   2014-06-03T17:15:03Z

bgcolor, cellpadding, cellspacing converted to css style in debug.ftl




> Remove HTML5 deprecated attributes from templates
> -
>
> Key: WW-4355
> URL: https://issues.apache.org/jira/browse/WW-4355
> Project: Struts 2
>  Issue Type: Improvement
>Reporter: Aleksandr Mashchenko
>  Labels: patch
>
> Change HTML5 deprecated attributes to CSS in templates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)