[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077888#comment-14077888 ] ASF GitHub Bot commented on WW-4360: Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/16 Fix potential NullPointerExceptions in xwork-core - Key: WW-4360 URL: https://issues.apache.org/jira/browse/WW-4360 Project: Struts 2 Issue Type: Bug Reporter: Joseph Walton Priority: Minor Fix For: 2.3.18 Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078132#comment-14078132 ] Hudson commented on WW-4360: SUCCESS: Integrated in Struts-JDK6-develop #66 (See [https://builds.apache.org/job/Struts-JDK6-develop/66/]) WW-4360 Fixes potential NullPointerExceptions (lukaszlenart: rev 413d67bd28ea414e586e596a50d68d9d2d0312a2) * xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/NumberConverter.java * xwork-core/src/main/java/com/opensymphony/xwork2/util/finder/ResourceFinder.java * xwork-core/src/main/java/com/opensymphony/xwork2/util/NamedVariablePatternMatcher.java * xwork-core/src/main/java/com/opensymphony/xwork2/util/location/LocationUtils.java * xwork-core/src/test/java/com/opensymphony/xwork2/util/NamedVariablePatternMatcherTest.java * xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java WW-4360 Fixes potential NullPointerExceptions (lukaszlenart: rev 47d1fe04dc1790473e9bd464d84e65ca76368ba5) * xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java Fix potential NullPointerExceptions in xwork-core - Key: WW-4360 URL: https://issues.apache.org/jira/browse/WW-4360 Project: Struts 2 Issue Type: Bug Reporter: Joseph Walton Priority: Minor Fix For: 2.3.18 Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076671#comment-14076671 ] ASF subversion and git services commented on WW-4360: - Commit 413d67bd28ea414e586e596a50d68d9d2d0312a2 in struts's branch refs/heads/develop from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=413d67b ] WW-4360 Fixes potential NullPointerExceptions Fix potential NullPointerExceptions in xwork-core - Key: WW-4360 URL: https://issues.apache.org/jira/browse/WW-4360 Project: Struts 2 Issue Type: Bug Reporter: Joseph Walton Priority: Minor Fix For: 2.3.18 Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[
https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046787#comment-14046787
]
ASF GitHub Bot commented on WW-4360:
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/16#discussion_r14322940
--- Diff:
xwork-core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -425,7 +427,7 @@ protected void addAction(Element actionElement,
PackageConfig.Builder packageCon
} else {
if (!verifyAction(className, name, location)) {
if (LOG.isErrorEnabled())
-LOG.error(Unable to verify action [#0] with class
[#1], from [#2], name, className, location.toString());
+LOG.error(Unable to verify action [#0] with class
[#1], from [#2], name, className, ObjectUtils.toString(location));
--- End diff --
I prefer extending `Logger` interface and define new method: `void
error(String msg, Object... args);` the same as I already did for `debug` and
`trace`. Thus will allow reduce `ObjectUtils` dependency and give new
functionality :-)
This can be handled with dedicated PR
Fix potential NullPointerExceptions in xwork-core
-
Key: WW-4360
URL: https://issues.apache.org/jira/browse/WW-4360
Project: Struts 2
Issue Type: Bug
Reporter: Joseph Walton
Priority: Minor
Fix For: 2.3.18
Eclipse's static analysis of nulls identifies a number of spots in xwork-core
where a NullPointerException can occur. This change fixes them either to
rearrange things so they can't happen or to throw a more specific exception.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027846#comment-14027846 ] ASF GitHub Bot commented on WW-4360: GitHub user josephw opened a pull request: https://github.com/apache/struts/pull/16 WW-4360: Fix a few NullPointerExceptions identified by Eclipse #15 Eclipse's static analysis of nulls identifies a number of spots where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/josephw/struts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 81cdd6e0d8fe01616e5c3055e5536ee63199b6e6 Author: Joseph Walton jwal...@atlassian.com Date: 2014-06-10T12:21:39Z Clean up potential NullPointerExceptions. - Construct BufferedReaders ahead of try blocks - Don't catch exceptions in tests - Specifically check for mismatched braces in patterns - Fail on an unknown numeric type commit f98e92c154add1c869efe88ce1fdba984a5f71aa Author: Joseph Walton jwal...@atlassian.com Date: 2014-06-10T12:21:55Z Fix potential NullPointerExceptions. - Allow for a null location when logging - Don't try to use a null LocationFinder Fix potential NullPointerExceptions in xwork-core - Key: WW-4360 URL: https://issues.apache.org/jira/browse/WW-4360 Project: Struts 2 Issue Type: Bug Reporter: Joseph Walton Priority: Minor Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WW-4360) Fix potential NullPointerExceptions in xwork-core
[ https://issues.apache.org/jira/browse/WW-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027848#comment-14027848 ] Joseph Walton commented on WW-4360: --- The changes are in this pull request: https://github.com/apache/struts/pull/16 . Fix potential NullPointerExceptions in xwork-core - Key: WW-4360 URL: https://issues.apache.org/jira/browse/WW-4360 Project: Struts 2 Issue Type: Bug Reporter: Joseph Walton Priority: Minor Eclipse's static analysis of nulls identifies a number of spots in xwork-core where a NullPointerException can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception. -- This message was sent by Atlassian JIRA (v6.2#6252)
