[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082888#comment-15082888
]
Sanjeev Kumar commented on WW-4482:
---
Nice to have this fixed.
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.3.24
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953002#comment-14953002
]
Hudson commented on WW-4482:
SUCCESS: Integrated in Struts-JDK7-master #371 (See
[https://builds.apache.org/job/Struts-JDK7-master/371/])
WW-4482 Fallbacks to non-collection evaluation for non-collection param
(lukaszlenart: rev 4a08f070f101dbe8a74b7ed53794d645274ee9da)
* xwork-core/src/main/java/com/opensymphony/xwork2/util/TextParseUtil.java
> Conversion annotation ignored for ServletAction parameter
> -
>
> Key: WW-4482
> URL: https://issues.apache.org/jira/browse/WW-4482
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language, Value Stack
>Affects Versions: 2.3.20
>Reporter: Jasper Rosenberg
>Assignee: Lukasz Lenart
>Priority: Critical
> Fix For: 2.3.24
>
>
> This definitely worked before 2.3.20, but unfortunately I haven’t been able
> to track down the actual source of the bug introduced for 2.3.20. My best
> guess is that it was introduced when the code was refactored to support
> Collections.
> Basically I have an Action, with a setter and getter for state that uses a
> custom type convertor like so:
> {code:java}
> /** @return the state. */
> @TypeConversion(converter = "com.myco.typeconvertor.RegionTypeConvertor")
> public RegionI getState() {
> return state;
> }
> {code}
> When I submit the action, this type convertor is correctly used to turn the
> “state” post parameter into a RegionI object which is injected into the
> Action. So far so good.
> However, the result looks like:
> {code:xml}
>
> confirmAccount
> ${streetAddress}
> ${city}
> ${state}
> ${postalCode}
> ...
>
> {code}
> And in the latest release, when it evaluates $\{state} it uses the default
> type convertor (in this case for an enum because the concrete class is a
> USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
> specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483014#comment-14483014
]
Hudson commented on WW-4482:
SUCCESS: Integrated in Struts-JDK6-master #905 (See
[https://builds.apache.org/job/Struts-JDK6-master/905/])
WW-4482 Fallbacks to non-collection evaluation for non-collection param
(lukaszlenart: rev 4a08f070f101dbe8a74b7ed53794d645274ee9da)
* xwork-core/src/main/java/com/opensymphony/xwork2/util/TextParseUtil.java
Conversion annotation ignored for ServletAction parameter
-
Key: WW-4482
URL: https://issues.apache.org/jira/browse/WW-4482
Project: Struts 2
Issue Type: Bug
Components: Expression Language, Value Stack
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Assignee: Lukasz Lenart
Priority: Critical
Fix For: 2.3.23
This definitely worked before 2.3.20, but unfortunately I haven’t been able
to track down the actual source of the bug introduced for 2.3.20. My best
guess is that it was introduced when the code was refactored to support
Collections.
Basically I have an Action, with a setter and getter for state that uses a
custom type convertor like so:
{code:java}
/** @return the state. */
@TypeConversion(converter = com.myco.typeconvertor.RegionTypeConvertor)
public RegionI getState() {
return state;
}
{code}
When I submit the action, this type convertor is correctly used to turn the
“state” post parameter into a RegionI object which is injected into the
Action. So far so good.
However, the result looks like:
{code:xml}
result name=selfSignupFlow type=redirectAction
param name=actionNameconfirmAccount/param
param name=streetAddress${streetAddress}/param
param name=city${city}/param
param name=state${state}/param
param name=postalCode${postalCode}/param
...
/result
{code}
And in the latest release, when it evaluates $\{state} it uses the default
type convertor (in this case for an enum because the concrete class is a
USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392359#comment-14392359
]
ASF subversion and git services commented on WW-4482:
-
Commit 4a08f070f101dbe8a74b7ed53794d645274ee9da in struts's branch
refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4a08f07 ]
WW-4482 Fallbacks to non-collection evaluation for non-collection param
Conversion annotation ignored for ServletAction parameter
-
Key: WW-4482
URL: https://issues.apache.org/jira/browse/WW-4482
Project: Struts 2
Issue Type: Bug
Components: Expression Language, Value Stack
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Priority: Critical
Fix For: 2.3.23
This definitely worked before 2.3.20, but unfortunately I haven’t been able
to track down the actual source of the bug introduced for 2.3.20. My best
guess is that it was introduced when the code was refactored to support
Collections.
Basically I have an Action, with a setter and getter for state that uses a
custom type convertor like so:
{code:java}
/** @return the state. */
@TypeConversion(converter = com.myco.typeconvertor.RegionTypeConvertor)
public RegionI getState() {
return state;
}
{code}
When I submit the action, this type convertor is correctly used to turn the
“state” post parameter into a RegionI object which is injected into the
Action. So far so good.
However, the result looks like:
{code:xml}
result name=selfSignupFlow type=redirectAction
param name=actionNameconfirmAccount/param
param name=streetAddress${streetAddress}/param
param name=city${city}/param
param name=state${state}/param
param name=postalCode${postalCode}/param
...
/result
{code}
And in the latest release, when it evaluates $\{state} it uses the default
type convertor (in this case for an enum because the concrete class is a
USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392521#comment-14392521
]
Jasper Rosenberg commented on WW-4482:
--
Awesome, thanks!
Conversion annotation ignored for ServletAction parameter
-
Key: WW-4482
URL: https://issues.apache.org/jira/browse/WW-4482
Project: Struts 2
Issue Type: Bug
Components: Expression Language, Value Stack
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Assignee: Lukasz Lenart
Priority: Critical
Fix For: 2.3.23
This definitely worked before 2.3.20, but unfortunately I haven’t been able
to track down the actual source of the bug introduced for 2.3.20. My best
guess is that it was introduced when the code was refactored to support
Collections.
Basically I have an Action, with a setter and getter for state that uses a
custom type convertor like so:
{code:java}
/** @return the state. */
@TypeConversion(converter = com.myco.typeconvertor.RegionTypeConvertor)
public RegionI getState() {
return state;
}
{code}
When I submit the action, this type convertor is correctly used to turn the
“state” post parameter into a RegionI object which is injected into the
Action. So far so good.
However, the result looks like:
{code:xml}
result name=selfSignupFlow type=redirectAction
param name=actionNameconfirmAccount/param
param name=streetAddress${streetAddress}/param
param name=city${city}/param
param name=state${state}/param
param name=postalCode${postalCode}/param
...
/result
{code}
And in the latest release, when it evaluates $\{state} it uses the default
type convertor (in this case for an enum because the concrete class is a
USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392578#comment-14392578
]
Hudson commented on WW-4482:
SUCCESS: Integrated in Struts-JDK6-develop #138 (See
[https://builds.apache.org/job/Struts-JDK6-develop/138/])
WW-4482 Fallbacks to non-collection evaluation for non-collection param
(lukaszlenart: rev 4a08f070f101dbe8a74b7ed53794d645274ee9da)
* xwork-core/src/main/java/com/opensymphony/xwork2/util/TextParseUtil.java
Conversion annotation ignored for ServletAction parameter
-
Key: WW-4482
URL: https://issues.apache.org/jira/browse/WW-4482
Project: Struts 2
Issue Type: Bug
Components: Expression Language, Value Stack
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Assignee: Lukasz Lenart
Priority: Critical
Fix For: 2.3.23
This definitely worked before 2.3.20, but unfortunately I haven’t been able
to track down the actual source of the bug introduced for 2.3.20. My best
guess is that it was introduced when the code was refactored to support
Collections.
Basically I have an Action, with a setter and getter for state that uses a
custom type convertor like so:
{code:java}
/** @return the state. */
@TypeConversion(converter = com.myco.typeconvertor.RegionTypeConvertor)
public RegionI getState() {
return state;
}
{code}
When I submit the action, this type convertor is correctly used to turn the
“state” post parameter into a RegionI object which is injected into the
Action. So far so good.
However, the result looks like:
{code:xml}
result name=selfSignupFlow type=redirectAction
param name=actionNameconfirmAccount/param
param name=streetAddress${streetAddress}/param
param name=city${city}/param
param name=state${state}/param
param name=postalCode${postalCode}/param
...
/result
{code}
And in the latest release, when it evaluates $\{state} it uses the default
type convertor (in this case for an enum because the concrete class is a
USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4482) Conversion annotation ignored for ServletAction parameter
[
https://issues.apache.org/jira/browse/WW-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372705#comment-14372705
]
Jasper Rosenberg commented on WW-4482:
--
Also, I have confirmed this issue for 2.3.22 as well.
Conversion annotation ignored for ServletAction parameter
-
Key: WW-4482
URL: https://issues.apache.org/jira/browse/WW-4482
Project: Struts 2
Issue Type: Bug
Components: Expression Language, Value Stack
Affects Versions: 2.3.20
Reporter: Jasper Rosenberg
Priority: Critical
This definitely worked before 2.3.20, but unfortunately I haven’t been able
to track down the actual source of the bug introduced for 2.3.20. My best
guess is that it was introduced when the code was refactored to support
Collections.
Basically I have an Action, with a setter and getter for state that uses a
custom type convertor like so:
{code:java}
/** @return the state. */
@TypeConversion(converter = com.myco.typeconvertor.RegionTypeConvertor)
public RegionI getState() {
return state;
}
{code}
When I submit the action, this type convertor is correctly used to turn the
“state” post parameter into a RegionI object which is injected into the
Action. So far so good.
However, the result looks like:
{code:xml}
result name=selfSignupFlow type=redirectAction
param name=actionNameconfirmAccount/param
param name=streetAddress${streetAddress}/param
param name=city${city}/param
param name=state${state}/param
param name=postalCode${postalCode}/param
...
/result
{code}
And in the latest release, when it evaluates $\{state} it uses the default
type convertor (in this case for an enum because the concrete class is a
USState enum), rather than the com.myco.typeconvertor.RegionTypeConvertor
specified on both the getter and setter for state in the action.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
