[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396629#comment-16396629 ] Hedju Hor commented on WW-4646: --- Just a hint. Weblogic Server 12.1.3 has a default installation of asm-3.1.jar in folder ...weblogic\oracle_common\modules\ after remove this jar Convention plugin works fine. > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart >Priority: Major > Fix For: 2.5.5 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420876#comment-15420876 ] Sebastian Götz commented on WW-4646: Thanks a lot Lukasz. I did not understand that I had to include the java8-support-plugin explicitly. Now after including it even my Lamba-expression action classes are loaded and fully functional. > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420834#comment-15420834 ] Lukasz Lenart commented on WW-4646: --- Just downloaded the jar from here [1] and it's ok - maybe you should clean up Ivy's cache? [1] http://repo1.maven.org/maven2/org/apache/struts/struts2-java8-support-plugin/2.5.2/ > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[
https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420799#comment-15420799
]
Sebastian Götz commented on WW-4646:
To me it looks more like the content of the convention-plugin jar is not what
it should be. I defined the bean you as you suggested. But it failed with the
exception below. Opening the jar file shows me, that there actually is no
Java8ClassFinderFactory class inside. Could someone verify that the jar is
correct?
{noformat}
ERROR Dispatcher Dispatcher initialization failed
Unable to load configuration. - bean -
file:/B:/deploy8/wtpwebapps/web-gui/WEB-INF/classes/struts.xml:40:151
at
com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:70)
at
org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:897)
at
org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:437)
at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:478)
at
org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:75)
at
org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:63)
at
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:279)
at
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:260)
at
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:105)
at
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4573)
at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5188)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1409)
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1399)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: Unable to load bean:
type:com.opensymphony.xwork2.util.finder.ClassFinderFactory
class:org.apache.struts2.convention.Java8ClassFinderFactory - bean -
file:/B:/deploy8/wtpwebapps/web-gui/WEB-INF/classes/struts.xml:40:151
at
com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.register(XmlConfigurationProvider.java:265)
at
org.apache.struts2.config.StrutsXmlConfigurationProvider.register(StrutsXmlConfigurationProvider.java:98)
at
com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:163)
at
com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:67)
... 17 more
Caused by: java.lang.ClassNotFoundException:
org.apache.struts2.convention.Java8ClassFinderFactory
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1305)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1157)
at
com.opensymphony.xwork2.util.ClassLoaderUtil.loadClass(ClassLoaderUtil.java:176)
at
com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.register(XmlConfigurationProvider.java:238)
... 20 more
{noformat}
> remove ASM 3 from struts2
> -
>
> Key: WW-4646
> URL: https://issues.apache.org/jira/browse/WW-4646
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions, Plugin - Convention
>Affects Versions: 2.5
>Reporter: adam brin
>Assignee: Lukasz Lenart
> Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin
> and 3x for the rest of struts. A basic search of the codebase suggests that
> the only direct uses of ASM are via the ClassFinder class in Xwork and used
> by the Convention plugin. Based on this
> [https://issues.apache.org/jira/browse/WW-4435] and
> [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/],
> I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in
> general
> 2. move the ClassFinder class and direct dependencies the convention plugin
> and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package
> tree so it can live with other versions of ASM.
> -
> the core issue for us is that there are overlaps between ASM 5
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420777#comment-15420777 ] Lukasz Lenart commented on WW-4646: --- Yes, there are. The Convention plugin is using ASM3 by default, but this can be overwritten with the Java 8 Support plugin. > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[
https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420772#comment-15420772
]
Lukasz Lenart commented on WW-4646:
---
Looks like plugin wasn't loaded properly, strange. Can you define a bean in
{{struts.xml}}
{code:xml}
{code}
?
> remove ASM 3 from struts2
> -
>
> Key: WW-4646
> URL: https://issues.apache.org/jira/browse/WW-4646
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions, Plugin - Convention
>Affects Versions: 2.5
>Reporter: adam brin
>Assignee: Lukasz Lenart
> Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin
> and 3x for the rest of struts. A basic search of the codebase suggests that
> the only direct uses of ASM are via the ClassFinder class in Xwork and used
> by the Convention plugin. Based on this
> [https://issues.apache.org/jira/browse/WW-4435] and
> [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/],
> I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in
> general
> 2. move the ClassFinder class and direct dependencies the convention plugin
> and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package
> tree so it can live with other versions of ASM.
> -
> the core issue for us is that there are overlaps between ASM 5 and ASM 3, and
> become explicit when launching our app with the maven-jetty-plugin. Classes
> with the same name in both packages though they have different groupIds and
> thus cause exceptions in startup either due to (a) Missing Classes like
> EmptyVisitor or (b) incompatible classes. It's our hope that by removing this
> dual dependency, we can take advantage of Java8 features and also simplify
> dependency management in our pom.
> thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420761#comment-15420761 ] Sebastian Götz commented on WW-4646: Sure. I did explicitly exclude asm AND asm-commons via IVY exclude and then added asm AND asm-commons 5.1. I even investigated the success with the Eclipse Reverse Dependency Explorer (tool to visualize dependency hierarchy) AND did check the webapps deployment folder for libraries. > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[
https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420745#comment-15420745
]
Lukasz Lenart commented on WW-4646:
---
But did you use the plugin as well? And you must exclude ASM3 dependency in
{{struts2-core}} (the docs are outdated :()
{code:xml}
org.apache.struts
struts2-core
asm
asm
asm
asm-commons
{code}
> remove ASM 3 from struts2
> -
>
> Key: WW-4646
> URL: https://issues.apache.org/jira/browse/WW-4646
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions, Plugin - Convention
>Affects Versions: 2.5
>Reporter: adam brin
>Assignee: Lukasz Lenart
> Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin
> and 3x for the rest of struts. A basic search of the codebase suggests that
> the only direct uses of ASM are via the ClassFinder class in Xwork and used
> by the Convention plugin. Based on this
> [https://issues.apache.org/jira/browse/WW-4435] and
> [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/],
> I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in
> general
> 2. move the ClassFinder class and direct dependencies the convention plugin
> and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package
> tree so it can live with other versions of ASM.
> -
> the core issue for us is that there are overlaps between ASM 5 and ASM 3, and
> become explicit when launching our app with the maven-jetty-plugin. Classes
> with the same name in both packages though they have different groupIds and
> thus cause exceptions in startup either due to (a) Missing Classes like
> EmptyVisitor or (b) incompatible classes. It's our hope that by removing this
> dual dependency, we can take advantage of Java8 features and also simplify
> dependency management in our pom.
> thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[
https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420643#comment-15420643
]
Sebastian Götz commented on WW-4646:
Thank you for that Lukasz.
I was not Aware of that plugin. We use Apache Ivy for dependency resolution.
But after excluding transitive asm 3.3 and asm-commons 3.3 dependencies from
struts-core 2.5.2 and adding explicit asm 5.1 and asm-commons 5.1 I still have
problems. From the stacktrace I would guess it is related to the convention
plugin (we use Action annotations for URl mapping). Will this be fixed as well
in 2.5.3?
{noformat}
java.lang.NoClassDefFoundError: org/objectweb/asm/commons/EmptyVisitor
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at
org.apache.catalina.loader.WebappClassLoaderBase.findClassInternal(WebappClassLoaderBase.java:2472)
at
org.apache.catalina.loader.WebappClassLoaderBase.findClass(WebappClassLoaderBase.java:854)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1274)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1157)
at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildClassFinder(PackageBasedActionConfigBuilder.java:397)
at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.findActions(PackageBasedActionConfigBuilder.java:379)
at
org.apache.struts2.convention.PackageBasedActionConfigBuilder.buildActionConfigs(PackageBasedActionConfigBuilder.java:335)
at
org.apache.struts2.convention.ClasspathPackageProvider.loadPackages(ClasspathPackageProvider.java:53)
at
com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:197)
at
com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:67)
at
org.apache.struts2.dispatcher.Dispatcher.getContainer(Dispatcher.java:897)
at
org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:437)
at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:478)
at
org.apache.struts2.dispatcher.InitOperations.initDispatcher(InitOperations.java:75)
at
org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:63)
at
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:279)
at
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:260)
at
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:105)
at
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4573)
at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5188)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1409)
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1399)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassNotFoundException:
org.objectweb.asm.commons.EmptyVisitor
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1305)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1157)
... 30 more
{noformat}
> remove ASM 3 from struts2
> -
>
> Key: WW-4646
> URL: https://issues.apache.org/jira/browse/WW-4646
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions, Plugin - Convention
>Affects Versions: 2.5
>Reporter: adam brin
>Assignee: Lukasz Lenart
> Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin
> and 3x for the rest of struts. A basic search of the codebase suggests that
> the only direct uses of ASM are via the ClassFinder class in Xwork and used
> by the Convention plugin. Based on this
> [https://issues.apache.org/jira/browse/WW-4435] and
> [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/],
> I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in
>
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419839#comment-15419839 ] Lukasz Lenart commented on WW-4646: --- There is no exact date but probably it will be at the end of August. And you can use the Java 8 Support plugin to solve your problems with ASM http://struts.apache.org/docs/java-8-support-plugin.html > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418638#comment-15418638 ] Sebastian Götz commented on WW-4646: Good job! I am currently stumbling over this since we have already several action classes in the next release version that do not work since they use Java 8 lambda expressions. Before reverting to loop constructs I have tried to find out a release date for the 2.5.3 release with no success. Maybe Lukas can give me a hint. I need not to know an exact date. But I would be glad to hear if it will come this month. > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376549#comment-15376549 ] Hudson commented on WW-4646: SUCCESS: Integrated in Struts-JDK7-master #492 (See [https://builds.apache.org/job/Struts-JDK7-master/492/]) WW-4646 Replaces ASM3 with the latest version of ASM5 (lukaszlenart: rev 8db9d8352f515de2bf714a174bec8f8a9248db0a) * plugins/pom.xml * core/src/main/java/com/opensymphony/xwork2/util/finder/DefaultClassFinder.java * plugins/java8-support/src/main/resources/LICENSE.txt * plugins/java8-support/src/main/java/org/apache/struts2/convention/Java8ClassFinderFactory.java * plugins/java8-support/src/main/resources/NOTICE.txt * plugins/java8-support/src/main/java/org/apache/struts2/convention/Java8ClassFinder.java * plugins/java8-support/pom.xml * core/pom.xml * plugins/java8-support/src/main/resources/struts-plugin.xml * plugins/java8-support/README.adoc * plugins/java8-support/src/site/site.xml * pom.xml > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376470#comment-15376470 ] ASF subversion and git services commented on WW-4646: - Commit 8db9d8352f515de2bf714a174bec8f8a9248db0a in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8db9d83 ] WW-4646 Replaces ASM3 with the latest version of ASM5 > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin >Assignee: Lukasz Lenart > Fix For: 2.5.3 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WW-4646) remove ASM 3 from struts2
[ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338492#comment-15338492 ] Charles Parker commented on WW-4646: I strongly support these recommendations. This ASM 3.3 dependency has confounded my build process for several years. It is impossible to build or deploy Struts2 applications with third party libraries that are dependent on ASM >= 4.0 due to the missing asm-commons-3.x EmptyVisitor class. For instance, FindBugs (ASM 5.0) cannot be run against Struts2 projects. For reference, the "incompatible classes" issue occurs during our build process as: Exception in thread "main" java.lang.IncompatibleClassChangeError: class edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM$1 has interface org.objectweb.asm.ClassVisitor as super class > remove ASM 3 from struts2 > - > > Key: WW-4646 > URL: https://issues.apache.org/jira/browse/WW-4646 > Project: Struts 2 > Issue Type: Bug > Components: Core Actions, Plugin - Convention >Affects Versions: 2.5 >Reporter: adam brin > Fix For: 2.5.2 > > > Pulling from the discussion on the struts2-users list: > Struts2 maintains two different versions of ASM 5x for the Convention plugin > and 3x for the rest of struts. A basic search of the codebase suggests that > the only direct uses of ASM are via the ClassFinder class in Xwork and used > by the Convention plugin. Based on this > [https://issues.apache.org/jira/browse/WW-4435] and > [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], > I wonder if it might make sense to: > 1. remove the direct dependency on ASM entirely for XWork and Struts2 in > general > 2. move the ClassFinder class and direct dependencies the convention plugin > and make them explicitly dependent on ASM 5x. > 3. Like other apps like Spring, repackage/embed ASM into it's own package > tree so it can live with other versions of ASM. > - > the core issue for us is that there are overlaps between ASM 5 and ASM 3, and > become explicit when launching our app with the maven-jetty-plugin. Classes > with the same name in both packages though they have different groupIds and > thus cause exceptions in startup either due to (a) Missing Classes like > EmptyVisitor or (b) incompatible classes. It's our hope that by removing this > dual dependency, we can take advantage of Java8 features and also simplify > dependency management in our pom. > thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
