[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854361#comment-16854361 ] Hudson commented on WW-4999: SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #257 (See [https://builds.apache.org/job/Struts-master-JDK8/257/]) fix compilation error of WW-4999 cherry picks (yasserzamani: rev 570f8c3e67001c17b5fa6049945f187dd40c6696) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854327#comment-16854327 ] ASF subversion and git services commented on WW-4999: - Commit 570f8c3e67001c17b5fa6049945f187dd40c6696 in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=570f8c3 ] fix compilation error of WW-4999 cherry picks > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854319#comment-16854319 ] Hudson commented on WW-4999: FAILURE: Integrated in Jenkins build Struts-master-JDK8 #256 (See [https://builds.apache.org/job/Struts-master-JDK8/256/]) fix logMissingProperties (WW-4999) (yasserzamani: rev b657a272d1d2ae93dc5fd0a1b7f81d6ae1772e89) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java not log user exceptions as missing properties (WW-4999) (yasserzamani: rev 382124cfd2c3eb2f757e6faaf9a7a58f5e002765) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/accessor/CompoundRootAccessor.java * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java test not throw exception on top missing property (WW-4999) (yasserzamani: rev a16cd4fca62e5df43b9afb045443f6e581d4a41e) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java decouple logMissingProperties from devMode (WW-4999) (yasserzamani: rev eca9c34645882b7d28b5b2dab42c0c3b4a0b10a3) * (edit) core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java test false for logMissingProperties (WW-4999) (yasserzamani: rev 704e41c6e802972def971c1223a3aa522e525bdb) * (edit) core/src/test/java/com/opensymphony/xwork2/ognl/OgnlValueStackTest.java > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854312#comment-16854312 ] ASF subversion and git services commented on WW-4999: - Commit 382124cfd2c3eb2f757e6faaf9a7a58f5e002765 in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=382124c ] not log user exceptions as missing properties (WW-4999) Also reaks loop on user method exceptions - but continue to next objects in stack on NoSuchMethodException. (cherry picked from commit 0999fba) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854310#comment-16854310 ] ASF subversion and git services commented on WW-4999: - Commit b657a272d1d2ae93dc5fd0a1b7f81d6ae1772e89 in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=b657a27 ] fix logMissingProperties (WW-4999) Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop because it shouldn't throw exception on first failure while is trying all root objects. Returns on first successful call because it's not rational and is confusing user to skip when user method successfully returns null as an actual result. Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlValueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. (cherry picked from commit 3ac6835) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854315#comment-16854315 ] ASF subversion and git services commented on WW-4999: - Commit 704e41c6e802972def971c1223a3aa522e525bdb in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=704e41c ] test false for logMissingProperties (WW-4999) (cherry picked from commit a50af87) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854313#comment-16854313 ] ASF subversion and git services commented on WW-4999: - Commit a16cd4fca62e5df43b9afb045443f6e581d4a41e in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=a16cd4f ] test not throw exception on top missing property (WW-4999) instead continue to next objects in stack Also tests not skip returned null values by user method (cherry picked from commit d4dd338) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854314#comment-16854314 ] ASF subversion and git services commented on WW-4999: - Commit eca9c34645882b7d28b5b2dab42c0c3b4a0b10a3 in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=eca9c34 ] decouple logMissingProperties from devMode (WW-4999) (cherry picked from commit 9e01fbd) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854311#comment-16854311 ] ASF subversion and git services commented on WW-4999: - Commit b657a272d1d2ae93dc5fd0a1b7f81d6ae1772e89 in struts's branch refs/heads/master from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=b657a27 ] fix logMissingProperties (WW-4999) Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop because it shouldn't throw exception on first failure while is trying all root objects. Returns on first successful call because it's not rational and is confusing user to skip when user method successfully returns null as an actual result. Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlValueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. (cherry picked from commit 3ac6835) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854262#comment-16854262 ] ASF subversion and git services commented on WW-4999: - Commit a50af87644320a3ca85283ccab7bc72822cb230b in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=a50af87 ] test false for logMissingProperties (WW-4999) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854257#comment-16854257 ] ASF subversion and git services commented on WW-4999: - Commit 3ac6835c5ca71cc5ee085680ade48aac6883d2fa in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=3ac6835 ] fix logMissingProperties (WW-4999) Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop because it shouldn't throw exception on first failure while is trying all root objects. Returns on first successful call because it's not rational and is confusing user to skip when user method successfully returns null as an actual result. Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlValueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854260#comment-16854260 ] ASF subversion and git services commented on WW-4999: - Commit d4dd3386cc02833fa7113a496092b2e09a53c9e4 in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=d4dd338 ] test not throw exception on top missing property (WW-4999) instead continue to next objects in stack Also tests not skip returned null values by user method > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854258#comment-16854258 ] ASF subversion and git services commented on WW-4999: - Commit 3ac6835c5ca71cc5ee085680ade48aac6883d2fa in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=3ac6835 ] fix logMissingProperties (WW-4999) Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop because it shouldn't throw exception on first failure while is trying all root objects. Returns on first successful call because it's not rational and is confusing user to skip when user method successfully returns null as an actual result. Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlValueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854259#comment-16854259 ] ASF subversion and git services commented on WW-4999: - Commit 0999fba8c496588bb55df0a025875cc76b35ce96 in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=0999fba ] not log user exceptions as missing properties (WW-4999) Also reaks loop on user method exceptions - but continue to next objects in stack on NoSuchMethodException. > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854263#comment-16854263 ] ASF subversion and git services commented on WW-4999: - Commit 651eac2c57396aa11ee65002006b3123dd69cbb4 in struts's branch refs/heads/struts-2-5-x from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=651eac2 ] Merge pull request #358 from yasserzamani/WW-4999 fix logMissingProperties (WW-4999) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854264#comment-16854264 ] ASF subversion and git services commented on WW-4999: - Commit 651eac2c57396aa11ee65002006b3123dd69cbb4 in struts's branch refs/heads/struts-2-5-x from Lukasz Lenart [ https://gitbox.apache.org/repos/asf?p=struts.git;h=651eac2 ] Merge pull request #358 from yasserzamani/WW-4999 fix logMissingProperties (WW-4999) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854261#comment-16854261 ] ASF subversion and git services commented on WW-4999: - Commit 9e01fbd2ddeb6dd1962f76a3bd8af227d370762d in struts's branch refs/heads/struts-2-5-x from Yasser Zamani [ https://gitbox.apache.org/repos/asf?p=struts.git;h=9e01fbd ] decouple logMissingProperties from devMode (WW-4999) > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854256#comment-16854256 ] ASF GitHub Bot commented on WW-4999: lukaszlenart commented on pull request #358: fix logMissingProperties (WW-4999) URL: https://github.com/apache/struts/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851802#comment-16851802 ] ASF GitHub Bot commented on WW-4999: yasserzamani commented on pull request #358: fix logMissingProperties (WW-4999) URL: https://github.com/apache/struts/pull/358 Moves checking OgnlValueStack.THROW_EXCEPTION_ON_FAILURE outside loop because it shouldn't throw exception on first failure while is trying all root objects. Returns on first successful call because it's not rational and is confusing user to skip when user method successfully returns null as an actual result. Fixes WW-4999 via honoring (devMode && logMissingProperties) for OgnlValueStack.THROW_EXCEPTION_ON_FAILURE and REPORT_ERRORS_ON_NO_PROP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849721#comment-16849721 ] ASF GitHub Bot commented on WW-4999: yasserzamani commented on pull request #357: WW-4999 honor logMissingProperties on findValue as well URL: https://github.com/apache/struts/pull/357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Assignee: Yasser Zamani >Priority: Major > Fix For: 2.5.21, 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[
https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747731#comment-16747731
]
Lukasz Lenart commented on WW-4999:
---
Yes, it has something to do with changes in OGNL as it throws {{OgnlException}}
instead of {{NoSuchMethodException}}
> Can't get OgnlValueStack log even if enable logMissingProperties
>
>
> Key: WW-4999
> URL: https://issues.apache.org/jira/browse/WW-4999
> Project: Struts 2
> Issue Type: Bug
> Components: Value Stack
>Affects Versions: 2.5.17
>Reporter: Quincy Qu
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> I'm in devMode, enabled logMissingProperties and expect to see missing
> property warning in the log. I was surprised that I can't get the missing
> property log even if logMissingProperties is set true. The application run
> smoothly and skip the missing property - as expected though.
> In another run, I enabled both logMissingProperties and
> throwExceptionOnFailure. This time the application crash at the missing
> property and I can get both logs and exception.
> After I dive deeper using debugger, I convince myself the config is good,
> since devMode and logMissingProperties are true at runtime in OgnlValueStack.
> I was confused, why we can't get missing property log without throwing
> OgnlException?
> Are we able to enter handleOgnlException(String expr, boolean
> throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure
> is false, in which my expected log is written?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745702#comment-16745702 ] Quincy Qu commented on WW-4999: --- Hey Lukasz, were you able to reproduce this bug? > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Priority: Major > Fix For: 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[ https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739633#comment-16739633 ] Quincy Qu commented on WW-4999: --- In struts.xml. > Can't get OgnlValueStack log even if enable logMissingProperties > > > Key: WW-4999 > URL: https://issues.apache.org/jira/browse/WW-4999 > Project: Struts 2 > Issue Type: Bug > Components: Value Stack >Affects Versions: 2.5.17 >Reporter: Quincy Qu >Priority: Major > Fix For: 2.6 > > > I'm in devMode, enabled logMissingProperties and expect to see missing > property warning in the log. I was surprised that I can't get the missing > property log even if logMissingProperties is set true. The application run > smoothly and skip the missing property - as expected though. > In another run, I enabled both logMissingProperties and > throwExceptionOnFailure. This time the application crash at the missing > property and I can get both logs and exception. > After I dive deeper using debugger, I convince myself the config is good, > since devMode and logMissingProperties are true at runtime in OgnlValueStack. > I was confused, why we can't get missing property log without throwing > OgnlException? > Are we able to enter handleOgnlException(String expr, boolean > throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure > is false, in which my expected log is written? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WW-4999) Can't get OgnlValueStack log even if enable logMissingProperties
[
https://issues.apache.org/jira/browse/WW-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739177#comment-16739177
]
Lukasz Lenart commented on WW-4999:
---
How did you setup the {{logMissingProperties}} constant?
> Can't get OgnlValueStack log even if enable logMissingProperties
>
>
> Key: WW-4999
> URL: https://issues.apache.org/jira/browse/WW-4999
> Project: Struts 2
> Issue Type: Bug
> Components: Value Stack
>Affects Versions: 2.5.17
>Reporter: Quincy Qu
>Priority: Major
> Fix For: 2.6
>
>
> I'm in devMode, enabled logMissingProperties and expect to see missing
> property warning in the log. I was surprised that I can't get the missing
> property log even if logMissingProperties is set true. The application run
> smoothly and skip the missing property - as expected though.
> In another run, I enabled both logMissingProperties and
> throwExceptionOnFailure. This time the application crash at the missing
> property and I can get both logs and exception.
> After I dive deeper using debugger, I convince myself the config is good,
> since devMode and logMissingProperties are true at runtime in OgnlValueStack.
> I was confused, why we can't get missing property log without throwing
> OgnlException?
> Are we able to enter handleOgnlException(String expr, boolean
> throwExceptionOnFailure, OgnlException e) at all if throwExceptionOnFailure
> is false, in which my expected log is written?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
