[jira] [Commented] (WW-5240) doubleOnchange attribute of the doubleselect tag doesn't call method
[
https://issues.apache.org/jira/browse/WW-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616215#comment-17616215
]
Lukasz Lenart commented on WW-5240:
---
It's ok, just open a PR with your changes, you can point the PR to this ticket.
> doubleOnchange attribute of the doubleselect tag doesn't call method
>
>
> Key: WW-5240
> URL: https://issues.apache.org/jira/browse/WW-5240
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.0.0
>Reporter: James Hartleroad
>Priority: Minor
> Fix For: 6.1.0
>
>
> When setting up a doubleselect tag with a call to a java script on the
> doubleOnchange attribute, the java script is not called.
> For example a jsp with the following doubleselect
> {code}
> id="selectapp" name="selectapp"
> list="appreleaseMap.keySet()" onchange="app2select()"
> doubleId="selectrel" doubleName="selectrel"
> doubleList="appreleaseMap.get(top)"
> doubleOnchange="rel2select()" />
> {code}
> and a java script file with (alerts added for debugging)
> {code:javascript}
> function app2select() {
> alert('app2select');
> var elmnt = document.getElementById('selectapp');
> var value = elmnt.value;
> alert('value is:' + value);
> document.getElementById('applid').value = value;
> document.getElementById('release').value = '';
> }
> function rel2select() {
> alert('rel2select');
> var elmnt = document.getElementById('selectrel');
> var value = elmnt.value;
> alert('value=' + value);
> document.getElementById('release').value = value;
> }
> {code}
> The app2select is called when selecting the first element, but the rel2select
> is not called when selecting the 2nd element.
> Per information I found on the web I updated the
> template/simple2/doubleselect.ftl by adding the following and then it worked.
> {code}
> <#if parameters.doubleOnchange??><#t/>
> onchange="<#outputformat
> 'JavaScript'>${parameters.doubleOnchange}"
> <#t/>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5240) doubleOnchange attribute of the doubleselect tag doesn't call method
[
https://issues.apache.org/jira/browse/WW-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615892#comment-17615892
]
James Hartleroad commented on WW-5240:
--
ok, so not a bug.
If I wanted to create an enhancement and follow the contributing guidelines to
add it, would that be ok or am I missing a fundamental point that it just
shouldn't be there?
> doubleOnchange attribute of the doubleselect tag doesn't call method
>
>
> Key: WW-5240
> URL: https://issues.apache.org/jira/browse/WW-5240
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.0.0
>Reporter: James Hartleroad
>Priority: Minor
> Fix For: 6.1.0
>
>
> When setting up a doubleselect tag with a call to a java script on the
> doubleOnchange attribute, the java script is not called.
> For example a jsp with the following doubleselect
> {code}
> id="selectapp" name="selectapp"
> list="appreleaseMap.keySet()" onchange="app2select()"
> doubleId="selectrel" doubleName="selectrel"
> doubleList="appreleaseMap.get(top)"
> doubleOnchange="rel2select()" />
> {code}
> and a java script file with (alerts added for debugging)
> {code:javascript}
> function app2select() {
> alert('app2select');
> var elmnt = document.getElementById('selectapp');
> var value = elmnt.value;
> alert('value is:' + value);
> document.getElementById('applid').value = value;
> document.getElementById('release').value = '';
> }
> function rel2select() {
> alert('rel2select');
> var elmnt = document.getElementById('selectrel');
> var value = elmnt.value;
> alert('value=' + value);
> document.getElementById('release').value = value;
> }
> {code}
> The app2select is called when selecting the first element, but the rel2select
> is not called when selecting the 2nd element.
> Per information I found on the web I updated the
> template/simple2/doubleselect.ftl by adding the following and then it worked.
> {code}
> <#if parameters.doubleOnchange??><#t/>
> onchange="<#outputformat
> 'JavaScript'>${parameters.doubleOnchange}"
> <#t/>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5240) doubleOnchange attribute of the doubleselect tag doesn't call method
[
https://issues.apache.org/jira/browse/WW-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613636#comment-17613636
]
Lukasz Lenart commented on WW-5240:
---
but the original
[doubleselect.ftl|https://github.com/apache/struts/blob/master/core/src/main/resources/template/simple/doubleselect.ftl]
doesn't use {{doubleOnchange}} - there is an attribute
[doubleOnchange|https://struts.apache.org/tag-developers/doubleselect-tag], but
it's unused (it's there by inheritance).
> doubleOnchange attribute of the doubleselect tag doesn't call method
>
>
> Key: WW-5240
> URL: https://issues.apache.org/jira/browse/WW-5240
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.0.0
>Reporter: James Hartleroad
>Priority: Minor
> Fix For: 6.1.0
>
>
> When setting up a doubleselect tag with a call to a java script on the
> doubleOnchange attribute, the java script is not called.
> For example a jsp with the following doubleselect
> {code}
> id="selectapp" name="selectapp"
> list="appreleaseMap.keySet()" onchange="app2select()"
> doubleId="selectrel" doubleName="selectrel"
> doubleList="appreleaseMap.get(top)"
> doubleOnchange="rel2select()" />
> {code}
> and a java script file with (alerts added for debugging)
> {code:javascript}
> function app2select() {
> alert('app2select');
> var elmnt = document.getElementById('selectapp');
> var value = elmnt.value;
> alert('value is:' + value);
> document.getElementById('applid').value = value;
> document.getElementById('release').value = '';
> }
> function rel2select() {
> alert('rel2select');
> var elmnt = document.getElementById('selectrel');
> var value = elmnt.value;
> alert('value=' + value);
> document.getElementById('release').value = value;
> }
> {code}
> The app2select is called when selecting the first element, but the rel2select
> is not called when selecting the 2nd element.
> Per information I found on the web I updated the
> template/simple2/doubleselect.ftl by adding the following and then it worked.
> {code}
> <#if parameters.doubleOnchange??><#t/>
> onchange="<#outputformat
> 'JavaScript'>${parameters.doubleOnchange}"
> <#t/>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5240) doubleOnchange attribute of the doubleselect tag doesn't call method
[
https://issues.apache.org/jira/browse/WW-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613574#comment-17613574
]
James Hartleroad commented on WW-5240:
--
I looked in the 6.0.0 structs code and it has the same problem. I also did a
comparison of the template/simple code from the repository vs. what I have in
template/simple2 and there were no differences, so I believe it is an issue
with the Structs.
> doubleOnchange attribute of the doubleselect tag doesn't call method
>
>
> Key: WW-5240
> URL: https://issues.apache.org/jira/browse/WW-5240
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.0.0
>Reporter: James Hartleroad
>Priority: Minor
> Fix For: 6.1.0
>
>
> When setting up a doubleselect tag with a call to a java script on the
> doubleOnchange attribute, the java script is not called.
> For example a jsp with the following doubleselect
> {code}
> id="selectapp" name="selectapp"
> list="appreleaseMap.keySet()" onchange="app2select()"
> doubleId="selectrel" doubleName="selectrel"
> doubleList="appreleaseMap.get(top)"
> doubleOnchange="rel2select()" />
> {code}
> and a java script file with (alerts added for debugging)
> {code:javascript}
> function app2select() {
> alert('app2select');
> var elmnt = document.getElementById('selectapp');
> var value = elmnt.value;
> alert('value is:' + value);
> document.getElementById('applid').value = value;
> document.getElementById('release').value = '';
> }
> function rel2select() {
> alert('rel2select');
> var elmnt = document.getElementById('selectrel');
> var value = elmnt.value;
> alert('value=' + value);
> document.getElementById('release').value = value;
> }
> {code}
> The app2select is called when selecting the first element, but the rel2select
> is not called when selecting the 2nd element.
> Per information I found on the web I updated the
> template/simple2/doubleselect.ftl by adding the following and then it worked.
> {code}
> <#if parameters.doubleOnchange??><#t/>
> onchange="<#outputformat
> 'JavaScript'>${parameters.doubleOnchange}"
> <#t/>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (WW-5240) doubleOnchange attribute of the doubleselect tag doesn't call method
[
https://issues.apache.org/jira/browse/WW-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613380#comment-17613380
]
Lukasz Lenart commented on WW-5240:
---
I assume you have your own theme {{template/simple2/doubleselect.ftl}} so this
isn't a bug in Struts code.
> doubleOnchange attribute of the doubleselect tag doesn't call method
>
>
> Key: WW-5240
> URL: https://issues.apache.org/jira/browse/WW-5240
> Project: Struts 2
> Issue Type: Bug
>Affects Versions: 6.0.0
>Reporter: James Hartleroad
>Priority: Minor
> Fix For: 6.1.0
>
>
> When setting up a doubleselect tag with a call to a java script on the
> doubleOnchange attribute, the java script is not called.
> For example a jsp with the following doubleselect
> {code}
> id="selectapp" name="selectapp"
> list="appreleaseMap.keySet()" onchange="app2select()"
> doubleId="selectrel" doubleName="selectrel"
> doubleList="appreleaseMap.get(top)"
> doubleOnchange="rel2select()" />
> {code}
> and a java script file with (alerts added for debugging)
> {code:javascript}
> function app2select() {
> alert('app2select');
> var elmnt = document.getElementById('selectapp');
> var value = elmnt.value;
> alert('value is:' + value);
> document.getElementById('applid').value = value;
> document.getElementById('release').value = '';
> }
> function rel2select() {
> alert('rel2select');
> var elmnt = document.getElementById('selectrel');
> var value = elmnt.value;
> alert('value=' + value);
> document.getElementById('release').value = value;
> }
> {code}
> The app2select is called when selecting the first element, but the rel2select
> is not called when selecting the 2nd element.
> Per information I found on the web I updated the
> template/simple2/doubleselect.ftl by adding the following and then it worked.
> {code}
> <#if parameters.doubleOnchange??><#t/>
> onchange="<#outputformat
> 'JavaScript'>${parameters.doubleOnchange}"
> <#t/>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
