[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Lukasz Lenart (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621262#comment-17621262
 ] 

Lukasz Lenart commented on WW-5247:
---

I see, but I have no idea how to fix that now :\

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Javier (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621173#comment-17621173
 ] 

Javier commented on WW-5247:




     2021
    2022
    2023


So it is replacing the single quotes ' to "  hence the onchange event does 
NOT work.
but swapping the " and ' makes it work.

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Lukasz Lenart (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621125#comment-17621125
 ] 

Lukasz Lenart commented on WW-5247:
---

Interesting, but this can be related to new Freemarker auto-escape mechanism
https://freemarker.apache.org/docs/dgui_misc_autoescaping.html

Could show the messed up html?

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Javier (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621119#comment-17621119
 ] 

Javier commented on WW-5247:


Yeah I agree. I will upgrade to 6.0.3.
On thing I noticed on 6.0.3.
 // generates messed up HTML
had to change it to ( swapped the " and ' ) :
onchange="$('input[type=submit]',this.form).trigger('click')"

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Lukasz Lenart (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621096#comment-17621096
 ] 

Lukasz Lenart commented on WW-5247:
---

I'm just trying identify where lays the problem - you said it works with Struts 
6.0.3 and I assume you are using JQuery plugin version 5.0.0 (as this is the 
only version which supports Struts 6), which means the JQuery plugin has been 
adjusted to changes made in 2.5.29/6.0.0. I would suggest upgrading to Struts 
6.0.3 and use JQuery plugin 5.0.1 - it rather won't be possible to fix JQuery 
4.x to work properly with Struts 2.5.29

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Javier (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621092#comment-17621092
 ] 

Javier commented on WW-5247:


Yes, the jquery-plugin is causing the problem but
this works with 2.5.20 but does NOT work with 2.5.29, 2.5.30 and they all use 
the same jquery plugin version. Hence it is because of the changes made in 
2.5.29 and 2.5.30.
To test I changed the code to this ( using regular html form, hidden field ):

 
   
                        

                        
                        
                    

And THIS WORKS 100% the way it should, on  2.5.29 and 2.5.30. Hence, I believe 
it is because of the changes made in 2.5.29 and 2.5.30.



 

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WW-5247) Related to: [WW-5117] - %{id} evaluates different for data-* and value attribute

2022-10-20 Thread Lukasz Lenart (Jira)


[ 
https://issues.apache.org/jira/browse/WW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620777#comment-17620777
 ] 

Lukasz Lenart commented on WW-5247:
---

Isn't this related to JQuery plugin?

> Related to: [WW-5117] - %{id} evaluates different for data-* and value 
> attribute
> 
>
> Key: WW-5247
> URL: https://issues.apache.org/jira/browse/WW-5247
> Project: Struts 2
>  Issue Type: Bug
>Affects Versions: 2.5.30
>Reporter: Javier
>Priority: Major
> Fix For: 6.1.0
>
>
> I upgraded from 2.5.20 to 2.5.30 and the following stopped working:
>  id="currentObj" name="${roleEntry.value}" >
>                 
>                  property="name"    />
>                  style="width:1%">
>                      theme="simple" action="getRoleAuthRolesPerms" >    
>                          value="%\{#attr.currentObj.roleid}" />
>                          indicator="roleIndicator"  cssClass="tooltipBorderless"  title="View Role" 
> type="image" src="../img/view.gif"  />
>                         
>                     
>                 
> 
> Generates:
>  action="/apps/epar/getRoleAuthRolesPerms.action" method="post" 
> class="formstyle">    
>                          value="159" id="getRole159_authorityRole_roleid">
>                          id="submit_213350257" value="Submit" class="tooltipBorderless" title="View 
> Role">
> 
> jQuery(document).ready(function () { 
>     var options_submit_213350257 = {};
>     options_submit_213350257.jqueryaction = "button";
>     options_submit_213350257.id = "submit_213350257";
>     options_submit_213350257.targets = "roleAjaxDiv";
>     options_submit_213350257.href = "#";
>     options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
>     options_submit_213350257.indicatorid = "roleIndicator";
>     options_submit_213350257.effect = "highlight";
>     options_submit_213350257.effectoptions = {};
> jQuery.struts2_jquery.bind(jQuery('#submit_213350257'),options_submit_213350257);
>  });  
> 
>  
> The JS that it generates does NOT translate: 
> options_submit_213350257.formids = "getRole%\{#attr.currentObj.roleid}";
> This works with 2.5.20 but does NOT work with 2.5.29, 2.5.30. 
> Works with 6.0.3, but not ready to upgrade to it, seems very unstable.
> I believe this is related to: 
>  * [WW-5117] - %\{id} evaluates different for data-* and value attribute
>  
>  
>                 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)