[jira] [Resolved] (SYSTEMML-609) StepLinregDS algorithm fails on parfor optimization
[
https://issues.apache.org/jira/browse/SYSTEMML-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Boehm resolved SYSTEMML-609.
-
Resolution: Fixed
Fix Version/s: SystemML 0.10
> StepLinregDS algorithm fails on parfor optimization
> ---
>
> Key: SYSTEMML-609
> URL: https://issues.apache.org/jira/browse/SYSTEMML-609
> Project: SystemML
> Issue Type: Bug
> Components: Compiler, Runtime
>Reporter: Matthias Boehm
> Fix For: SystemML 0.10
>
>
> StepLinregDS fails - independent of the datasize - during parfor
> optimization, specifically during the update in-place rewrite.
> {code}
> Exception in thread "main" org.apache.sysml.api.DMLException:
> org.apache.sysml.runtime.DMLRuntimeException: java.lang.ClassCastException:
> org.apache.sysml.hops.FunctionOp incompatible with
> org.apache.sysml.parser.StatementBlock
> at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:350)
> at org.apache.sysml.api.DMLScript.main(DMLScript.java:197)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
> at java.lang.reflect.Method.invoke(Method.java:611)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:212)
> Caused by: org.apache.sysml.runtime.DMLRuntimeException:
> java.lang.ClassCastException: org.apache.sysml.hops.FunctionOp incompatible
> with org.apache.sysml.parser.StatementBlock
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:153)
> at org.apache.sysml.api.DMLScript.execute(DMLScript.java:678)
> at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:338)
> ... 6 more
> Caused by: java.lang.ClassCastException: org.apache.sysml.hops.FunctionOp
> incompatible with org.apache.sysml.parser.StatementBlock
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptTreePlanMappingAbstract.getMappedProg(OptTreePlanMappingAbstract.java:101)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rComputeSumMemoryIntermediates(OptimizerRuleBased.java:2746)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rComputeSumMemoryIntermediates(OptimizerRuleBased.java:2732)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rComputeSumMemoryIntermediates(OptimizerRuleBased.java:2732)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rComputeSumMemoryIntermediates(OptimizerRuleBased.java:2732)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rComputeSumMemoryIntermediates(OptimizerRuleBased.java:2732)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.rewriteSetInPlaceResultIndexing(OptimizerRuleBased.java:1891)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizerRuleBased.optimize(OptimizerRuleBased.java:311)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizationWrapper.optimize(OptimizationWrapper.java:322)
> at
> org.apache.sysml.runtime.controlprogram.parfor.opt.OptimizationWrapper.optimize(OptimizationWrapper.java:175)
> at
> org.apache.sysml.runtime.controlprogram.ParForProgramBlock.execute(ParForProgramBlock.java:549)
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:146)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-611) Enhance display of parsing errors for user
[
https://issues.apache.org/jira/browse/SYSTEMML-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-611:
Description:
Currently, if parsing errors occur, the actual messages are not displayed to
standard output or standard error except via log4j. As a result, if a user does
not have log4j configured, they do not see any of the actual parsing error
messages, which makes it extremely difficult to fix DML/PyDML.
As an example, executing the following code via DMLScript:
{code}
foo();
{code}
generates the following result to the console if log4j is not configured:
{code}
Exception in thread "main" org.apache.sysml.api.DMLException:
org.apache.sysml.parser.ParseException: One or more errors found during parsing
(could not construct AST for file: example.dml). Cannot proceed ahead.
at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:350)
at org.apache.sysml.api.DMLScript.main(DMLScript.java:197)
Caused by: org.apache.sysml.parser.ParseException: One or more errors found
during parsing (could not construct AST for file: example.dml). Cannot proceed
ahead.
at
org.apache.sysml.parser.dml.DMLParserWrapper.parse(DMLParserWrapper.java:98)
at org.apache.sysml.api.DMLScript.execute(DMLScript.java:588)
at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:338)
... 1 more
{code}
There are a few issues to address here.
1) A stacktrace such as the one above does not help an end user to write/fix
DML/PyDML. In fact, it detracts from the important information (the parse error
message) that the user needs.
2) The actual parsing errors are needed by the end user (not the stacktrace),
and these should be displayed to standard output/standard error (ie, the
console) if SystemML is being invoked via DMLScript.
3) The parsing error information should be available at higher levels of the
call stack (ie, in DMLScript and MLContext, for example). Allowing this
information to be available at these higher levels has benefits, for example to
display the parse error information in a notebook via MLContext.
was:
Currently, if parsing errors occur, the actual messages are not displayed to
standard output or standard error except via log4j. As a result, if a user does
not have log4j configured, they do not see any of the actual parsing error
messages, which makes it extremely difficult to fix DML/PyDML.
As an example, executing the following code via DMLScript:
{code}
foo();
{code}
generates the following result to the console if log4j is not configured:
{code}
Exception in thread "main" org.apache.sysml.api.DMLException:
org.apache.sysml.parser.ParseException: One or more errors found during parsing
(could not construct AST for file: example.dml). Cannot proceed ahead.
at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:350)
at org.apache.sysml.api.DMLScript.main(DMLScript.java:197)
Caused by: org.apache.sysml.parser.ParseException: One or more errors found
during parsing (could not construct AST for file: example.dml). Cannot proceed
ahead.
at
org.apache.sysml.parser.dml.DMLParserWrapper.parse(DMLParserWrapper.java:98)
at org.apache.sysml.api.DMLScript.execute(DMLScript.java:588)
at org.apache.sysml.api.DMLScript.executeScript(DMLScript.java:338)
... 1 more
{code}
There are a few issues to address here.
1) A stacktrace such as the one above does not help an end user to write/fix
DML/PyDML. In fact, it detracts from the import information (the parse error
message) that the user needs.
2) The actual parsing errors are needed by the end user (not the stacktrace),
and these should be displayed to standard output/standard error (ie, the
console) if SystemML is being invoked via DMLScript.
3) The parsing error information should be available at higher levels of the
call stack (ie, in DMLScript and MLContext, for example). Allowing this
information to be available at these higher levels has benefits, for example to
display the parse error information in a notebook via MLContext.
> Enhance display of parsing errors for user
> --
>
> Key: SYSTEMML-611
> URL: https://issues.apache.org/jira/browse/SYSTEMML-611
> Project: SystemML
> Issue Type: Task
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> Currently, if parsing errors occur, the actual messages are not displayed to
> standard output or standard error except via log4j. As a result, if a user
> does not have log4j configured, they do not see any of the actual parsing
> error messages, which makes it extremely difficult to fix DML/PyDML.
> As an example, executing the following code via DMLScript:
> {code}
> foo();
> {code}
> generates the following result to the
[jira] [Created] (SYSTEMML-610) Add Databricks Notebook example to MLContext documentation
Deron Eriksson created SYSTEMML-610: --- Summary: Add Databricks Notebook example to MLContext documentation Key: SYSTEMML-610 URL: https://issues.apache.org/jira/browse/SYSTEMML-610 Project: SystemML Issue Type: Task Reporter: Deron Eriksson Assignee: Deron Eriksson Add an example of configuring a Databricks Notebook to use SystemML to the Spark MLContext Programming Guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-551) Enhance JMLC javadocs
[ https://issues.apache.org/jira/browse/SYSTEMML-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-551: --- Assignee: Deron Eriksson > Enhance JMLC javadocs > - > > Key: SYSTEMML-551 > URL: https://issues.apache.org/jira/browse/SYSTEMML-551 > Project: SystemML > Issue Type: Task > Components: Documentation >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > JMLC needs its Javadocs enhanced to better explain the classes and methods > involved in its usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SYSTEMML-551) Enhance JMLC javadocs
[ https://issues.apache.org/jira/browse/SYSTEMML-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson updated SYSTEMML-551: Summary: Enhance JMLC javadocs (was: Enhance jMLC javadocs) > Enhance JMLC javadocs > - > > Key: SYSTEMML-551 > URL: https://issues.apache.org/jira/browse/SYSTEMML-551 > Project: SystemML > Issue Type: Task > Components: Documentation >Reporter: Deron Eriksson > > jMLC needs its Javadocs enhanced to better explain the classes and methods > involved in its usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SYSTEMML-551) Enhance JMLC javadocs
[ https://issues.apache.org/jira/browse/SYSTEMML-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson updated SYSTEMML-551: Description: JMLC needs its Javadocs enhanced to better explain the classes and methods involved in its usage. (was: jMLC needs its Javadocs enhanced to better explain the classes and methods involved in its usage.) > Enhance JMLC javadocs > - > > Key: SYSTEMML-551 > URL: https://issues.apache.org/jira/browse/SYSTEMML-551 > Project: SystemML > Issue Type: Task > Components: Documentation >Reporter: Deron Eriksson > > JMLC needs its Javadocs enhanced to better explain the classes and methods > involved in its usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
