[jira] [Commented] (SYSTEMML-1238) Python test failing for LinearRegCG
[
https://issues.apache.org/jira/browse/SYSTEMML-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857289#comment-15857289
]
Imran Younus commented on SYSTEMML-1238:
[~niketanpansare] [~mboehm7] [~acs_s]
> Python test failing for LinearRegCG
> ---
>
> Key: SYSTEMML-1238
> URL: https://issues.apache.org/jira/browse/SYSTEMML-1238
> Project: SystemML
> Issue Type: Bug
> Components: Algorithms, APIs
>Affects Versions: SystemML 0.13
>Reporter: Imran Younus
> Attachments: python_LinearReg_test_spark.1.6.log,
> python_LinearReg_test_spark.2.1.log
>
>
> [~deron] discovered that the one of the python test ({{test_mllearn_df.py}})
> with spark 2.1.0 was failing because the test score from linear regression
> was very low ({{~ 0.24}}). I did a some investigation and it turns out the
> the model parameters computed by the dml script are incorrect. In
> systemml.12, the values of betas from linear regression model are
> {{\[152.919, 938.237\]}}. This is what we expect from normal equation. (I
> also tested this with sklearn). But the values of betas from systemml.13
> (with spark 2.1.0) come out to be {{\[153.146, 458.489\]}}. These are not
> correct and therefore the test score is much lower than expected. The data
> going into DML script is correct. I printed out the valued of {{X}} and {{Y}}
> in dml and I didn't see any issue there.
> Attached are the log files for two different tests (systemml0.12 and 0.13)
> with explain flag.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (SYSTEMML-1238) Python test failing for LinearRegCG
Imran Younus created SYSTEMML-1238:
--
Summary: Python test failing for LinearRegCG
Key: SYSTEMML-1238
URL: https://issues.apache.org/jira/browse/SYSTEMML-1238
Project: SystemML
Issue Type: Bug
Components: Algorithms, APIs
Affects Versions: SystemML 0.13
Reporter: Imran Younus
Attachments: python_LinearReg_test_spark.1.6.log,
python_LinearReg_test_spark.2.1.log
[~deron] discovered that the one of the python test ({{test_mllearn_df.py}})
with spark 2.1.0 was failing because the test score from linear regression was
very low ({{~ 0.24}}). I did a some investigation and it turns out the the
model parameters computed by the dml script are incorrect. In systemml.12, the
values of betas from linear regression model are {{\[152.919, 938.237\]}}. This
is what we expect from normal equation. (I also tested this with sklearn). But
the values of betas from systemml.13 (with spark 2.1.0) come out to be
{{\[153.146, 458.489\]}}. These are not correct and therefore the test score is
much lower than expected. The data going into DML script is correct. I printed
out the valued of {{X}} and {{Y}} in dml and I didn't see any issue there.
Attached are the log files for two different tests (systemml0.12 and 0.13) with
explain flag.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SYSTEMML-1237) Add input float support to MLContext
[ https://issues.apache.org/jira/browse/SYSTEMML-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-1237. > Add input float support to MLContext > > > Key: SYSTEMML-1237 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1237 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > Fix For: SystemML 0.13 > > > Currently java.lang.Float is not a supported input type for the new MLContext > API. This type can be cast to a double in `public Script in(String name, > Object value, Metadata metadata)` to implicitly add float input support to > the API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SYSTEMML-1237) Add input float support to MLContext
[ https://issues.apache.org/jira/browse/SYSTEMML-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-1237. -- Resolution: Fixed Fix Version/s: SystemML 0.13 Fixed by [PR382|https://github.com/apache/incubator-systemml/pull/382]. > Add input float support to MLContext > > > Key: SYSTEMML-1237 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1237 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > Fix For: SystemML 0.13 > > > Currently java.lang.Float is not a supported input type for the new MLContext > API. This type can be cast to a double in `public Script in(String name, > Object value, Metadata metadata)` to implicitly add float input support to > the API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SYSTEMML-1235) Migrate GNMFTest to new MLContext
[ https://issues.apache.org/jira/browse/SYSTEMML-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-1235. > Migrate GNMFTest to new MLContext > - > > Key: SYSTEMML-1235 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1235 > Project: SystemML > Issue Type: Task > Components: Test >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > org.apache.sysml.test.integration.functions.mlcontext.GNMFTest currently uses > the old MLContext API. It should be migrated to the new API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SYSTEMML-1235) Migrate GNMFTest to new MLContext
[ https://issues.apache.org/jira/browse/SYSTEMML-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-1235. -- Resolution: Fixed Fix Version/s: SystemML 0.13 Fixed by [PR381|https://github.com/apache/incubator-systemml/pull/381]. > Migrate GNMFTest to new MLContext > - > > Key: SYSTEMML-1235 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1235 > Project: SystemML > Issue Type: Task > Components: Test >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > org.apache.sysml.test.integration.functions.mlcontext.GNMFTest currently uses > the old MLContext API. It should be migrated to the new API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SYSTEMML-1233) Deprecate old MLContext API
[ https://issues.apache.org/jira/browse/SYSTEMML-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-1233. -- Resolution: Fixed Fix Version/s: SystemML 0.13 Fixed by [PR378|https://github.com/apache/incubator-systemml/pull/378]. > Deprecate old MLContext API > --- > > Key: SYSTEMML-1233 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1233 > Project: SystemML > Issue Type: Task > Components: APIs >Affects Versions: SystemML 0.13 >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > Deprecate the old MLContext API as it will be removed. It has been replaced > by the new MLContext API. > Most likely it will be removed for the SystemML 1.0 release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SYSTEMML-1233) Deprecate old MLContext API
[ https://issues.apache.org/jira/browse/SYSTEMML-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-1233. > Deprecate old MLContext API > --- > > Key: SYSTEMML-1233 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1233 > Project: SystemML > Issue Type: Task > Components: APIs >Affects Versions: SystemML 0.13 >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > Deprecate the old MLContext API as it will be removed. It has been replaced > by the new MLContext API. > Most likely it will be removed for the SystemML 1.0 release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SYSTEMML-1209) Add configurable jekyll option to add API docs link to documentation header
[ https://issues.apache.org/jira/browse/SYSTEMML-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-1209. > Add configurable jekyll option to add API docs link to documentation header > --- > > Key: SYSTEMML-1209 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1209 > Project: SystemML > Issue Type: Task > Components: Documentation >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > Add a configurable jekyll option to conditionally allow an API docs link to > be added to the header of the project documentation. This option should be on > when the documentation is generated for the main website since the versioned > project documentation should be able to point to the versioned javadoc > documentation. > The FEEDBACK_LINKS option in _config.yml is an example of allowing such a > condition. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SYSTEMML-1209) Add configurable jekyll option to add API docs link to documentation header
[ https://issues.apache.org/jira/browse/SYSTEMML-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-1209. -- Resolution: Fixed Fix Version/s: SystemML 0.13 Fixed by https://github.com/apache/incubator-systemml/commit/54b35455752472ec0345828030f860da772942fb > Add configurable jekyll option to add API docs link to documentation header > --- > > Key: SYSTEMML-1209 > URL: https://issues.apache.org/jira/browse/SYSTEMML-1209 > Project: SystemML > Issue Type: Task > Components: Documentation >Reporter: Deron Eriksson >Assignee: Deron Eriksson > Fix For: SystemML 0.13 > > > Add a configurable jekyll option to conditionally allow an API docs link to > be added to the header of the project documentation. This option should be on > when the documentation is generated for the main website since the versioned > project documentation should be able to point to the versioned javadoc > documentation. > The FEEDBACK_LINKS option in _config.yml is an example of allowing such a > condition. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
