[jira] [Commented] (SYSTEMML-294) Print matrix capability
[
https://issues.apache.org/jira/browse/SYSTEMML-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243832#comment-15243832
]
Deron Eriksson commented on SYSTEMML-294:
-
Thank you [~nakul02]. This would be a big win for usability.
> Print matrix capability
> ---
>
> Key: SYSTEMML-294
> URL: https://issues.apache.org/jira/browse/SYSTEMML-294
> Project: SystemML
> Issue Type: Improvement
> Components: APIs
>Reporter: Deron Eriksson
>
> The ability to output a matrix or a part of a matrix to standard output would
> be very useful to have while developing DML and PyDML scripts. By having the
> functionality as a built-in function, capabilities such as alignment of cell
> values could be performed. Such a built-in function could also optionally
> take parameters to limit the output to a certain subset of cells in the
> matrix. Such a function would be useful for small matrices. An error could be
> thrown if an attempt is made to use the function with a matrix that is too
> large.
> Here's an example of a printMatrix function in DML:
> {code}
> printMatrix = function(matrix[double] mat) {
> for (i in 1:nrow(mat)) {
> colVals = '| '
> for (j in 1:ncol(mat)) {
> n = mat[i,j]
> colVals = colVals + as.scalar(n) + ' | '
> }
> print(colVals)
> }
> }
> m = matrix("1 2 3 4 5 6 7 8 9 10 11 12", rows=4, cols=3)
> z = printMatrix(m)
> {code}
> Here's an example of a printMatrix function in PyDML:
> {code}
> def printMatrix(mat:matrix[float]):
> for (i in 1:nrow(mat)):
> colVals = '| '
> for (j in 1:ncol(mat)):
> n = mat[i,j]
> colVals = colVals + scalar(n) + ' | '
> print(colVals)
> m = full("1 2 3 4 5 6 7 8 9 10 11 12", rows=4, cols=3)
> z = printMatrix(m)
> {code}
> Here is the output:
> {code}
> | 1.0 | 2.0 | 3.0 |
> | 4.0 | 5.0 | 6.0 |
> | 7.0 | 8.0 | 9.0 |
> | 10.0 | 11.0 | 12.0 |
> {code}
> Notice how alignment readily becomes an issue if an attempt is made to do
> this with DML or PyDML.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-639) Can't use semicolon after user-defined function in DML
Deron Eriksson created SYSTEMML-639:
---
Summary: Can't use semicolon after user-defined function in DML
Key: SYSTEMML-639
URL: https://issues.apache.org/jira/browse/SYSTEMML-639
Project: SystemML
Issue Type: Bug
Components: APIs
Reporter: Deron Eriksson
Priority: Minor
This is valid:
{code}
x=1;print(x);
printFoo=function(int y){print(y);}
z=printFoo(x);
{code}
This is invalid:
{code}
x=1;print(x);
printFoo=function(int y){print(y);};z=printFoo(x);
{code}
and generates:
{code}
The following parse issue was encountered:
example.dml [line 2:35] [Syntax error] -> printFoo=function(int
y){print(y);};z=printFoo(x);
extraneous input ';' expecting {, 'while', 'for', 'if', 'source',
'setwd', 'parfor', '[', ID, COMMANDLINE_NAMED_ID, COMMANDLINE_POSITION_ID}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-642) Wrong-case boolean input parameter gives somewhat cryptic message
Deron Eriksson created SYSTEMML-642:
---
Summary: Wrong-case boolean input parameter gives somewhat cryptic
message
Key: SYSTEMML-642
URL: https://issues.apache.org/jira/browse/SYSTEMML-642
Project: SystemML
Issue Type: Improvement
Components: APIs
Reporter: Deron Eriksson
Priority: Minor
If input parameter $X is "true" rather than "TRUE" and DML script is the
following:
{code}
print("test:" + ($X == TRUE));
{code}
The resulting error is:
{code}
...
org.apache.sysml.lops.LopsException: ERROR: line 1, column 16 -- Problem
generating simple inst -
CP°==°true·SCALAR·STRING·true°true·SCALAR·BOOLEAN·true°_Var2·SCALAR·BOOLEAN
...
Caused by: org.apache.sysml.runtime.DMLRuntimeException: unexpected value-type
in Relational Binary Instruction involving scalar operands.
{code}
I have generated this error a few times, since I have not initially realized
that my boolean input parameter coming from outside of a DML script needs to be
the correct case for DML. The error is correct, but perhaps something like
"Input parameter $X (value='true') is not valid in Relational Binary
Instruction (boolean value can only be TRUE or FALSE)", or something like that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-642) Wrong-case boolean input parameter gives somewhat cryptic message
[
https://issues.apache.org/jira/browse/SYSTEMML-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-642:
Description:
If input parameter $X is "true" rather than "TRUE" and DML script is the
following:
{code}
print("test:" + ($X == TRUE));
{code}
The resulting error is:
{code}
...
org.apache.sysml.lops.LopsException: ERROR: line 1, column 16 -- Problem
generating simple inst -
CP°==°true·SCALAR·STRING·true°true·SCALAR·BOOLEAN·true°_Var2·SCALAR·BOOLEAN
...
Caused by: org.apache.sysml.runtime.DMLRuntimeException: unexpected value-type
in Relational Binary Instruction involving scalar operands.
{code}
I have generated this error a few times, since I have not initially realized
that my boolean input parameter coming from outside of a DML script needs to be
the correct case for DML. The error is correct, but perhaps something like
"Input parameter $X (value='true') is not valid in Relational Binary
Instruction (boolean value can only be TRUE or FALSE)", or something like that,
would make it easier for the user.
was:
If input parameter $X is "true" rather than "TRUE" and DML script is the
following:
{code}
print("test:" + ($X == TRUE));
{code}
The resulting error is:
{code}
...
org.apache.sysml.lops.LopsException: ERROR: line 1, column 16 -- Problem
generating simple inst -
CP°==°true·SCALAR·STRING·true°true·SCALAR·BOOLEAN·true°_Var2·SCALAR·BOOLEAN
...
Caused by: org.apache.sysml.runtime.DMLRuntimeException: unexpected value-type
in Relational Binary Instruction involving scalar operands.
{code}
I have generated this error a few times, since I have not initially realized
that my boolean input parameter coming from outside of a DML script needs to be
the correct case for DML. The error is correct, but perhaps something like
"Input parameter $X (value='true') is not valid in Relational Binary
Instruction (boolean value can only be TRUE or FALSE)", or something like that.
> Wrong-case boolean input parameter gives somewhat cryptic message
> -
>
> Key: SYSTEMML-642
> URL: https://issues.apache.org/jira/browse/SYSTEMML-642
> Project: SystemML
> Issue Type: Improvement
> Components: APIs
>Reporter: Deron Eriksson
>Priority: Minor
>
> If input parameter $X is "true" rather than "TRUE" and DML script is the
> following:
> {code}
> print("test:" + ($X == TRUE));
> {code}
> The resulting error is:
> {code}
> ...
> org.apache.sysml.lops.LopsException: ERROR: line 1, column 16 -- Problem
> generating simple inst -
> CP°==°true·SCALAR·STRING·true°true·SCALAR·BOOLEAN·true°_Var2·SCALAR·BOOLEAN
> ...
> Caused by: org.apache.sysml.runtime.DMLRuntimeException: unexpected
> value-type in Relational Binary Instruction involving scalar operands.
> {code}
> I have generated this error a few times, since I have not initially realized
> that my boolean input parameter coming from outside of a DML script needs to
> be the correct case for DML. The error is correct, but perhaps something like
> "Input parameter $X (value='true') is not valid in Relational Binary
> Instruction (boolean value can only be TRUE or FALSE)", or something like
> that, would make it easier for the user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-645) accuracy result in naive-bayes should be a scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson updated SYSTEMML-645: Assignee: Tommy Yu > accuracy result in naive-bayes should be a scalar > - > > Key: SYSTEMML-645 > URL: https://issues.apache.org/jira/browse/SYSTEMML-645 > Project: SystemML > Issue Type: Bug > Components: Algorithms >Reporter: Tommy Yu >Assignee: Tommy Yu >Priority: Minor > > Naiver-bayes export accuracy string as result: > acc_str = "Training Accuracy (%): " + acc > print(acc_str) > write(acc_str, $accuracy) > same for Naiver-bayes-predict > acc_str = "Accuracy (%): " + acc > print(acc_str) > if(cmdLine_accuracy != " ") > write(acc_str, cmdLine_accuracy) > I thought maybe it's issues here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-645) accuracy result in naive-bayes should be a scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-645. - Resolution: Fixed Fixed by [PR127|https://github.com/apache/incubator-systemml/pull/127]. > accuracy result in naive-bayes should be a scalar > - > > Key: SYSTEMML-645 > URL: https://issues.apache.org/jira/browse/SYSTEMML-645 > Project: SystemML > Issue Type: Bug > Components: Algorithms >Reporter: Tommy Yu >Assignee: Tommy Yu >Priority: Minor > > Naiver-bayes export accuracy string as result: > acc_str = "Training Accuracy (%): " + acc > print(acc_str) > write(acc_str, $accuracy) > same for Naiver-bayes-predict > acc_str = "Accuracy (%): " + acc > print(acc_str) > if(cmdLine_accuracy != " ") > write(acc_str, cmdLine_accuracy) > I thought maybe it's issues here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-645) accuracy result in naive-bayes should be a scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-645. --- > accuracy result in naive-bayes should be a scalar > - > > Key: SYSTEMML-645 > URL: https://issues.apache.org/jira/browse/SYSTEMML-645 > Project: SystemML > Issue Type: Bug > Components: Algorithms >Reporter: Tommy Yu >Assignee: Tommy Yu >Priority: Minor > > Naiver-bayes export accuracy string as result: > acc_str = "Training Accuracy (%): " + acc > print(acc_str) > write(acc_str, $accuracy) > same for Naiver-bayes-predict > acc_str = "Accuracy (%): " + acc > print(acc_str) > if(cmdLine_accuracy != " ") > write(acc_str, cmdLine_accuracy) > I thought maybe it's issues here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SYSTEMML-625) Handle circular import references
[
https://issues.apache.org/jira/browse/SYSTEMML-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-625:
Assignee: Glenn Weidner
> Handle circular import references
> -
>
> Key: SYSTEMML-625
> URL: https://issues.apache.org/jira/browse/SYSTEMML-625
> Project: SystemML
> Issue Type: Sub-task
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Glenn Weidner
>
> Suppose we have a DML file named "example.dml" that contains a source call to
> itself:
> {code}
> source("./example.dml") as example;
> {code}
> This produces an infinite loop that gives:
> {code}
> Exception in thread "main" java.lang.StackOverflowError
> {code}
> Similar error occurs for other types of circular references such as script1
> imports script2 imports script3 imports1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-625) Handle circular import references
[
https://issues.apache.org/jira/browse/SYSTEMML-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254966#comment-15254966
]
Deron Eriksson commented on SYSTEMML-625:
-
Thank you [~gweidner]. Fixed by
[PR126|https://github.com/apache/incubator-systemml/pull/126].
> Handle circular import references
> -
>
> Key: SYSTEMML-625
> URL: https://issues.apache.org/jira/browse/SYSTEMML-625
> Project: SystemML
> Issue Type: Sub-task
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Glenn Weidner
>
> Suppose we have a DML file named "example.dml" that contains a source call to
> itself:
> {code}
> source("./example.dml") as example;
> {code}
> This produces an infinite loop that gives:
> {code}
> Exception in thread "main" java.lang.StackOverflowError
> {code}
> Similar error occurs for other types of circular references such as script1
> imports script2 imports script3 imports1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-625) Handle circular import references
[
https://issues.apache.org/jira/browse/SYSTEMML-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-625.
-
Resolution: Fixed
> Handle circular import references
> -
>
> Key: SYSTEMML-625
> URL: https://issues.apache.org/jira/browse/SYSTEMML-625
> Project: SystemML
> Issue Type: Sub-task
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Glenn Weidner
>
> Suppose we have a DML file named "example.dml" that contains a source call to
> itself:
> {code}
> source("./example.dml") as example;
> {code}
> This produces an infinite loop that gives:
> {code}
> Exception in thread "main" java.lang.StackOverflowError
> {code}
> Similar error occurs for other types of circular references such as script1
> imports script2 imports script3 imports1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-625) Handle circular import references
[
https://issues.apache.org/jira/browse/SYSTEMML-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-625.
---
> Handle circular import references
> -
>
> Key: SYSTEMML-625
> URL: https://issues.apache.org/jira/browse/SYSTEMML-625
> Project: SystemML
> Issue Type: Sub-task
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Glenn Weidner
>
> Suppose we have a DML file named "example.dml" that contains a source call to
> itself:
> {code}
> source("./example.dml") as example;
> {code}
> This produces an infinite loop that gives:
> {code}
> Exception in thread "main" java.lang.StackOverflowError
> {code}
> Similar error occurs for other types of circular references such as script1
> imports script2 imports script3 imports1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-647) Replace all castAsScalar calls with as.scalar
Deron Eriksson created SYSTEMML-647: --- Summary: Replace all castAsScalar calls with as.scalar Key: SYSTEMML-647 URL: https://issues.apache.org/jira/browse/SYSTEMML-647 Project: SystemML Issue Type: Task Components: APIs Reporter: Deron Eriksson Priority: Minor The castAsScalar calls in the project need to be replaced by calls to as.scalar so that castAsScalar can eventually be removed. There are 85 'castAsScalar' matches in the scripts directory. There are 415 *.dml 'castAsScalar' matches in the src directory. There are 69 *.pydml 'castAsScalar' matches in the src directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-648) Issue deprecated log warning if castAsScalar called
Deron Eriksson created SYSTEMML-648: --- Summary: Issue deprecated log warning if castAsScalar called Key: SYSTEMML-648 URL: https://issues.apache.org/jira/browse/SYSTEMML-648 Project: SystemML Issue Type: Task Components: APIs Reporter: Deron Eriksson The castAsScalar function has been replaced by as.scalar. As a result, if a call to castAsScalar occurs, we should issue a log warning stating that castAsScalar has been deprecated and has been replaced by as.scalar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-649) JMLC/MLContext support for scalar output variables
[ https://issues.apache.org/jira/browse/SYSTEMML-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-649: --- Assignee: Deron Eriksson > JMLC/MLContext support for scalar output variables > -- > > Key: SYSTEMML-649 > URL: https://issues.apache.org/jira/browse/SYSTEMML-649 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Matthias Boehm >Assignee: Deron Eriksson > > Right now neither JMLC nor MLContext supports scalar output variables. This > task aims to extend both APIs with the required primitives. > The workaround is to cast any output scalar on script-level with as.matrix to > a 1-1 matrix and handle it in the calling application. However, especially > with MLContext this puts an unnecessary burden on the user as he needs to > deal with RDDs for a simple scalar too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-649) JMLC/MLContext support for scalar output variables
[
https://issues.apache.org/jira/browse/SYSTEMML-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256721#comment-15256721
]
Deron Eriksson commented on SYSTEMML-649:
-
Do scalar inputs via JMLC currently work? If I have this DML:
{code}
inMatrix = read("./tmp/inMatrix", rows=-1, cols=-1);
print('inMatrix: ' + nrow(inMatrix) + 'x' + ncol(inMatrix));
inScalar = read("./tmp/inScalar", data_type="scalar", value_type="int");
print('inScalar: ' + inScalar);
outMatrix = matrix("1 2 3 0", rows=2, cols=2);
print('outMatrix: ' + nrow(outMatrix) + 'x' + ncol(outMatrix));
write(outMatrix, "./tmp", format="text");
{code}
and I do this:
{code}
Connection conn = new Connection();
String dml = conn.readScript("scalar-test.dml");
PreparedScript script = conn.prepareScript(dml, new String[] { "inMatrix",
"inScalar" }, new String[] { "outMatrix" }, false);
double[][] inMatrix = matrix(2, 2, new double[] { 1, 2, 3, 4 });
int inScalar = 5;
script.setMatrix("inMatrix", inMatrix);
script.setScalar("inScalar", inScalar);
ResultVariables results = script.executeScript();
double[][] result = results.getMatrix("outMatrix");
{code}
I get:
{code}
Exception in thread "main" org.apache.sysml.runtime.DMLRuntimeException:
org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error in program
block generated from statement block between lines 1 and 9 -- Error evaluating
instruction: CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
at
org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:152)
at
org.apache.sysml.api.jmlc.PreparedScript.executeScript(PreparedScript.java:390)
at org.apache.sysml.JMLCExampleScalar.main(JMLCExampleScalar.java:26)
Caused by: org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error
in program block generated from statement block between lines 1 and 9 -- Error
evaluating instruction:
CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.executeSingleInstruction(ProgramBlock.java:333)
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.executeInstructions(ProgramBlock.java:222)
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.execute(ProgramBlock.java:166)
at
org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:145)
... 2 more
Caused by: org.apache.sysml.runtime.DMLRuntimeException:
java.io.FileNotFoundException: File tmp/inScalar does not exist
{code}
The matrix input and output work fine.
> JMLC/MLContext support for scalar output variables
> --
>
> Key: SYSTEMML-649
> URL: https://issues.apache.org/jira/browse/SYSTEMML-649
> Project: SystemML
> Issue Type: Task
> Components: APIs
>Reporter: Matthias Boehm
>Assignee: Deron Eriksson
>
> Right now neither JMLC nor MLContext supports scalar output variables. This
> task aims to extend both APIs with the required primitives.
> The workaround is to cast any output scalar on script-level with as.matrix to
> a 1-1 matrix and handle it in the calling application. However, especially
> with MLContext this puts an unnecessary burden on the user as he needs to
> deal with RDDs for a simple scalar too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-649) JMLC/MLContext support for scalar output variables
[ https://issues.apache.org/jira/browse/SYSTEMML-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256732#comment-15256732 ] Deron Eriksson commented on SYSTEMML-649: - Am I doing something wrong? Am I supposed to register a scalar input differently than this? Before tackling the scalar output, I wanted to see the scalar input working. > JMLC/MLContext support for scalar output variables > -- > > Key: SYSTEMML-649 > URL: https://issues.apache.org/jira/browse/SYSTEMML-649 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Matthias Boehm >Assignee: Deron Eriksson > > Right now neither JMLC nor MLContext supports scalar output variables. This > task aims to extend both APIs with the required primitives. > The workaround is to cast any output scalar on script-level with as.matrix to > a 1-1 matrix and handle it in the calling application. However, especially > with MLContext this puts an unnecessary burden on the user as he needs to > deal with RDDs for a simple scalar too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-649) JMLC/MLContext support for scalar output variables
[ https://issues.apache.org/jira/browse/SYSTEMML-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256804#comment-15256804 ] Deron Eriksson commented on SYSTEMML-649: - Thank you [~mboehm7]. I'll take a look at that too. I will let you know if I need any guidance. > JMLC/MLContext support for scalar output variables > -- > > Key: SYSTEMML-649 > URL: https://issues.apache.org/jira/browse/SYSTEMML-649 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Matthias Boehm >Assignee: Deron Eriksson > > Right now neither JMLC nor MLContext supports scalar output variables. This > task aims to extend both APIs with the required primitives. > The workaround is to cast any output scalar on script-level with as.matrix to > a 1-1 matrix and handle it in the calling application. However, especially > with MLContext this puts an unnecessary burden on the user as he needs to > deal with RDDs for a simple scalar too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-651) Fix scalar input support for JMLC
Deron Eriksson created SYSTEMML-651:
---
Summary: Fix scalar input support for JMLC
Key: SYSTEMML-651
URL: https://issues.apache.org/jira/browse/SYSTEMML-651
Project: SystemML
Issue Type: Bug
Components: APIs
Reporter: Deron Eriksson
Assignee: Deron Eriksson
Priority: Minor
Currently scalar input variables via JMLC do not work.
Sample DML (matrix input, scalar input, and a matrix output):
{code}
inMatrix = read("./tmp/inMatrix", rows=-1, cols=-1);
print('inMatrix: ' + nrow(inMatrix) + 'x' + ncol(inMatrix));
inScalar = read("./tmp/inScalar", data_type="scalar", value_type="int");
print('inScalar: ' + inScalar);
outMatrix = matrix("1 2 3 0", rows=2, cols=2);
print('outMatrix: ' + nrow(outMatrix) + 'x' + ncol(outMatrix));
write(outMatrix, "./tmp", format="text");
{code}
JMLC code:
{code}
Connection conn = new Connection();
String dml = conn.readScript("scalar-test.dml");
PreparedScript script = conn.prepareScript(dml, new String[] { "inMatrix",
"inScalar" }, new String[] { "outMatrix" }, false);
double[][] inMatrix = matrix(2, 2, new double[] { 1, 2, 3, 4 });
int inScalar = 5;
script.setMatrix("inMatrix", inMatrix);
script.setScalar("inScalar", inScalar);
ResultVariables results = script.executeScript();
double[][] result = results.getMatrix("outMatrix");
{code}
Generates the following error:
{code}
Exception in thread "main" org.apache.sysml.runtime.DMLRuntimeException:
org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error in program
block generated from statement block between lines 1 and 9 -- Error evaluating
instruction: CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
at
org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:152)
at
org.apache.sysml.api.jmlc.PreparedScript.executeScript(PreparedScript.java:390)
at org.apache.sysml.JMLCExampleScalar.main(JMLCExampleScalar.java:26)
Caused by: org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error
in program block generated from statement block between lines 1 and 9 -- Error
evaluating instruction:
CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.executeSingleInstruction(ProgramBlock.java:333)
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.executeInstructions(ProgramBlock.java:222)
at
org.apache.sysml.runtime.controlprogram.ProgramBlock.execute(ProgramBlock.java:166)
at
org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:145)
... 2 more
Caused by: org.apache.sysml.runtime.DMLRuntimeException:
java.io.FileNotFoundException: File tmp/inScalar does not exist
{code}
The matrix input and output work fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-260) Can't specify a linefeed character when printing to console
[
https://issues.apache.org/jira/browse/SYSTEMML-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-260:
Assignee: Niketan Pansare
> Can't specify a linefeed character when printing to console
> ---
>
> Key: SYSTEMML-260
> URL: https://issues.apache.org/jira/browse/SYSTEMML-260
> Project: SystemML
> Issue Type: Improvement
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Niketan Pansare
>Priority: Minor
>
> When trying to figure out DML and PyDML code, it is very useful to print
> information to the console (using the print() function). Currently, it does
> not appear possible to be able to output a linefeed character.
> For example, the following DML:
> {code}x=1
> y=2
> print('x:' + x + '\ny:' + y)
> print('x:' + x + '\\ny:' + y){code}
> produces:
> {code}x:1\ny:2
> x:1\\ny:2{code}
> This becomes more of an issue as the complexity of what is being looked at
> increases.
> For example, here a function returning a string displaying the values in a
> matrix is called and the results are printed to the console.
> {code}matrixVals = function(matrix[double] mat) return (string str){
> str = '';
> for (i in 1:nrow(mat)) {
> str = str + '| '
> for (j in 1:ncol(mat)) {
> n = mat[i,j]
> str = str + as.scalar(n) + ' | '
> }
> str = str + '\n'
> }
> }
> m = matrix("1 2 3 4 5 6 7 8 9 10 11 12", rows=4, cols=3)
> vals = matrixVals(m)
> print(vals){code}
> The printed string is:
> {code}| 1.0 | 2.0 | 3.0 | \n| 4.0 | 5.0 | 6.0 | \n| 7.0 | 8.0 | 9.0 | \n|
> 10.0 | 11.0 | 12.0 | \n{code}
> Being able to output a linefeed character can assist DML/PyDML creators when
> figuring out their scripts.
> Note: it's possible to output a linefeed by actually having a linefeed in the
> string, but this produces code that is difficult to manage.
> {code}x=1
> y=2
> print('x:' + x + '
> y:' + y){code}
> produces:
> {code}x:1
> y:2{code}
> So, it would be nice to be able to recognize either \n or a double
> backslashed n as a linefeed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-260) Can't specify a linefeed character when printing to console
[
https://issues.apache.org/jira/browse/SYSTEMML-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-260.
---
> Can't specify a linefeed character when printing to console
> ---
>
> Key: SYSTEMML-260
> URL: https://issues.apache.org/jira/browse/SYSTEMML-260
> Project: SystemML
> Issue Type: Improvement
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Niketan Pansare
>Priority: Minor
>
> When trying to figure out DML and PyDML code, it is very useful to print
> information to the console (using the print() function). Currently, it does
> not appear possible to be able to output a linefeed character.
> For example, the following DML:
> {code}x=1
> y=2
> print('x:' + x + '\ny:' + y)
> print('x:' + x + '\\ny:' + y){code}
> produces:
> {code}x:1\ny:2
> x:1\\ny:2{code}
> This becomes more of an issue as the complexity of what is being looked at
> increases.
> For example, here a function returning a string displaying the values in a
> matrix is called and the results are printed to the console.
> {code}matrixVals = function(matrix[double] mat) return (string str){
> str = '';
> for (i in 1:nrow(mat)) {
> str = str + '| '
> for (j in 1:ncol(mat)) {
> n = mat[i,j]
> str = str + as.scalar(n) + ' | '
> }
> str = str + '\n'
> }
> }
> m = matrix("1 2 3 4 5 6 7 8 9 10 11 12", rows=4, cols=3)
> vals = matrixVals(m)
> print(vals){code}
> The printed string is:
> {code}| 1.0 | 2.0 | 3.0 | \n| 4.0 | 5.0 | 6.0 | \n| 7.0 | 8.0 | 9.0 | \n|
> 10.0 | 11.0 | 12.0 | \n{code}
> Being able to output a linefeed character can assist DML/PyDML creators when
> figuring out their scripts.
> Note: it's possible to output a linefeed by actually having a linefeed in the
> string, but this produces code that is difficult to manage.
> {code}x=1
> y=2
> print('x:' + x + '
> y:' + y){code}
> produces:
> {code}x:1
> y:2{code}
> So, it would be nice to be able to recognize either \n or a double
> backslashed n as a linefeed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-260) Can't specify a linefeed character when printing to console
[
https://issues.apache.org/jira/browse/SYSTEMML-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-260.
-
Resolution: Fixed
Fixed by [commit
1b48ca0a91997f1efa72210dbb1d289359f043e6|https://github.com/apache/incubator-systemml/commit/1b48ca0a91997f1efa72210dbb1d289359f043e6]
> Can't specify a linefeed character when printing to console
> ---
>
> Key: SYSTEMML-260
> URL: https://issues.apache.org/jira/browse/SYSTEMML-260
> Project: SystemML
> Issue Type: Improvement
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Niketan Pansare
>Priority: Minor
>
> When trying to figure out DML and PyDML code, it is very useful to print
> information to the console (using the print() function). Currently, it does
> not appear possible to be able to output a linefeed character.
> For example, the following DML:
> {code}x=1
> y=2
> print('x:' + x + '\ny:' + y)
> print('x:' + x + '\\ny:' + y){code}
> produces:
> {code}x:1\ny:2
> x:1\\ny:2{code}
> This becomes more of an issue as the complexity of what is being looked at
> increases.
> For example, here a function returning a string displaying the values in a
> matrix is called and the results are printed to the console.
> {code}matrixVals = function(matrix[double] mat) return (string str){
> str = '';
> for (i in 1:nrow(mat)) {
> str = str + '| '
> for (j in 1:ncol(mat)) {
> n = mat[i,j]
> str = str + as.scalar(n) + ' | '
> }
> str = str + '\n'
> }
> }
> m = matrix("1 2 3 4 5 6 7 8 9 10 11 12", rows=4, cols=3)
> vals = matrixVals(m)
> print(vals){code}
> The printed string is:
> {code}| 1.0 | 2.0 | 3.0 | \n| 4.0 | 5.0 | 6.0 | \n| 7.0 | 8.0 | 9.0 | \n|
> 10.0 | 11.0 | 12.0 | \n{code}
> Being able to output a linefeed character can assist DML/PyDML creators when
> figuring out their scripts.
> Note: it's possible to output a linefeed by actually having a linefeed in the
> string, but this produces code that is difficult to manage.
> {code}x=1
> y=2
> print('x:' + x + '
> y:' + y){code}
> produces:
> {code}x:1
> y:2{code}
> So, it would be nice to be able to recognize either \n or a double
> backslashed n as a linefeed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-648) Issue deprecated log warning if castAsScalar called
[ https://issues.apache.org/jira/browse/SYSTEMML-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-648: --- Assignee: Deron Eriksson > Issue deprecated log warning if castAsScalar called > --- > > Key: SYSTEMML-648 > URL: https://issues.apache.org/jira/browse/SYSTEMML-648 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The castAsScalar function has been replaced by as.scalar. As a result, if a > call to castAsScalar occurs, we should issue a log warning stating that > castAsScalar has been deprecated and has been replaced by as.scalar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-647) Replace all castAsScalar calls with as.scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261262#comment-15261262 ] Deron Eriksson commented on SYSTEMML-647: - Note: as.scalar() needed for DML, scalar() needed for PYDML > Replace all castAsScalar calls with as.scalar > - > > Key: SYSTEMML-647 > URL: https://issues.apache.org/jira/browse/SYSTEMML-647 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Priority: Minor > > The castAsScalar calls in the project need to be replaced by calls to > as.scalar so that castAsScalar can eventually be removed. > There are 85 'castAsScalar' matches in the scripts directory. > There are 415 *.dml 'castAsScalar' matches in the src directory. > There are 69 *.pydml 'castAsScalar' matches in the src directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-656) Read-in boolean variable math treated as doubles rather than booleans
Deron Eriksson created SYSTEMML-656:
---
Summary: Read-in boolean variable math treated as doubles rather
than booleans
Key: SYSTEMML-656
URL: https://issues.apache.org/jira/browse/SYSTEMML-656
Project: SystemML
Issue Type: Bug
Reporter: Deron Eriksson
If we have two boolean variables and add them normally, the addition is treated
as boolean algebra (true + true = true).
{code}
x = TRUE;
y = TRUE;
z = x + y;
print(x);
print(y);
print(z);
{code}
produces
{code}
TRUE
TRUE
TRUE
{code}
However, if we read in boolean scalars using the read statement and add the
boolean variables, the math ends up giving a double result instead of a boolean
result:
{code}
x = read("./tmp/sc1", data_type="scalar", value_type="boolean");
y = read("./tmp/sc2", data_type="scalar", value_type="boolean");
z = x + y;
print(x);
print(y);
print(z);
{code}
produces (where ./tmp/sc1 contains "TRUE" and ./tmp/sc2 contains "TRUE"):
{code}
TRUE
TRUE
2.0
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-656) Read-in boolean variable math treated as doubles rather than booleans
[
https://issues.apache.org/jira/browse/SYSTEMML-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-656:
Description:
If we have two boolean variables and add them normally, the addition is treated
as boolean algebra (true + true = true).
{code}
x = TRUE;
y = TRUE;
z = x + y;
print(x);
print(y);
print(z);
{code}
produces
{code}
TRUE
TRUE
TRUE
{code}
However, if we read in boolean scalars using the read statement and add the
boolean variables, the math ends up giving a double result instead of a boolean
result:
{code}
x = read("./tmp/sc1", data_type="scalar", value_type="boolean");
y = read("./tmp/sc2", data_type="scalar", value_type="boolean");
z = x + y;
print(x);
print(y);
print(z);
{code}
This produces (where ./tmp/sc1 contains "TRUE" and ./tmp/sc2 contains "TRUE"):
{code}
TRUE
TRUE
2.0
{code}
was:
If we have two boolean variables and add them normally, the addition is treated
as boolean algebra (true + true = true).
{code}
x = TRUE;
y = TRUE;
z = x + y;
print(x);
print(y);
print(z);
{code}
produces
{code}
TRUE
TRUE
TRUE
{code}
However, if we read in boolean scalars using the read statement and add the
boolean variables, the math ends up giving a double result instead of a boolean
result:
{code}
x = read("./tmp/sc1", data_type="scalar", value_type="boolean");
y = read("./tmp/sc2", data_type="scalar", value_type="boolean");
z = x + y;
print(x);
print(y);
print(z);
{code}
produces (where ./tmp/sc1 contains "TRUE" and ./tmp/sc2 contains "TRUE"):
{code}
TRUE
TRUE
2.0
{code}
> Read-in boolean variable math treated as doubles rather than booleans
> -
>
> Key: SYSTEMML-656
> URL: https://issues.apache.org/jira/browse/SYSTEMML-656
> Project: SystemML
> Issue Type: Bug
>Reporter: Deron Eriksson
>
> If we have two boolean variables and add them normally, the addition is
> treated as boolean algebra (true + true = true).
> {code}
> x = TRUE;
> y = TRUE;
> z = x + y;
> print(x);
> print(y);
> print(z);
> {code}
> produces
> {code}
> TRUE
> TRUE
> TRUE
> {code}
> However, if we read in boolean scalars using the read statement and add the
> boolean variables, the math ends up giving a double result instead of a
> boolean result:
> {code}
> x = read("./tmp/sc1", data_type="scalar", value_type="boolean");
> y = read("./tmp/sc2", data_type="scalar", value_type="boolean");
> z = x + y;
> print(x);
> print(y);
> print(z);
> {code}
> This produces (where ./tmp/sc1 contains "TRUE" and ./tmp/sc2 contains "TRUE"):
> {code}
> TRUE
> TRUE
> 2.0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-658) Setting scalar strings not automatically treated as strings by JMLC
Deron Eriksson created SYSTEMML-658:
---
Summary: Setting scalar strings not automatically treated as
strings by JMLC
Key: SYSTEMML-658
URL: https://issues.apache.org/jira/browse/SYSTEMML-658
Project: SystemML
Issue Type: Bug
Reporter: Deron Eriksson
Priority: Minor
When using JMLC to set scalar string values, the values are not automatically
treated as strings as a result of calling setScalar with a string value.
For example, take the following DML:
{code}
inScalar1 = read("./tmp/doesntexist1", data_type="scalar", value_type="string");
inScalar2 = read("./tmp/doesntexist2", data_type="scalar", value_type="string");
print(inScalar1 + inScalar2);
{code}
The above will be treated correctly. However, the following won't be treated
correctly:
{code}
inScalar1 = read("./tmp/doesntexist1", data_type="scalar");
inScalar2 = read("./tmp/doesntexist2", data_type="scalar");
print(inScalar1 + inScalar2);
{code}
(this will output "0.0")
Calling PreparedScript's setScalar with a String should automatically resolve
to a String.
{code}
Connection conn = new Connection();
String str = conn.readScript("scalar-input-string.dml");
PreparedScript script = conn.prepareScript(str, new String[] { "inScalar1",
"inScalar2" }, new String[] {},
false);
String inScalar1 = "hello";
String inScalar2 = "goodbye";
script.setScalar("inScalar1", inScalar1);
script.setScalar("inScalar2", inScalar2);
script.executeScript();
{code}
This should produce "hellogoodbye" rather than "0.0" with both DML examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-651) Fix scalar input support for JMLC
[
https://issues.apache.org/jira/browse/SYSTEMML-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-651.
-
Resolution: Fixed
Fixed by [PR129|https://github.com/apache/incubator-systemml/pull/129].
> Fix scalar input support for JMLC
> -
>
> Key: SYSTEMML-651
> URL: https://issues.apache.org/jira/browse/SYSTEMML-651
> Project: SystemML
> Issue Type: Bug
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>Priority: Minor
>
> Currently scalar input variables via JMLC do not work.
> Sample DML (matrix input, scalar input, and a matrix output):
> {code}
> inMatrix = read("./tmp/inMatrix", rows=-1, cols=-1);
> print('inMatrix: ' + nrow(inMatrix) + 'x' + ncol(inMatrix));
> inScalar = read("./tmp/inScalar", data_type="scalar", value_type="int");
> print('inScalar: ' + inScalar);
> outMatrix = matrix("1 2 3 0", rows=2, cols=2);
> print('outMatrix: ' + nrow(outMatrix) + 'x' + ncol(outMatrix));
> write(outMatrix, "./tmp", format="text");
> {code}
> JMLC code:
> {code}
> Connection conn = new Connection();
> String dml = conn.readScript("scalar-test.dml");
> PreparedScript script = conn.prepareScript(dml, new String[] { "inMatrix",
> "inScalar" }, new String[] { "outMatrix" }, false);
> double[][] inMatrix = matrix(2, 2, new double[] { 1, 2, 3, 4 });
> int inScalar = 5;
> script.setMatrix("inMatrix", inMatrix);
> script.setScalar("inScalar", inScalar);
> ResultVariables results = script.executeScript();
> double[][] result = results.getMatrix("outMatrix");
> {code}
> Generates the following error:
> {code}
> Exception in thread "main" org.apache.sysml.runtime.DMLRuntimeException:
> org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error in program
> block generated from statement block between lines 1 and 9 -- Error
> evaluating instruction:
> CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:152)
> at
> org.apache.sysml.api.jmlc.PreparedScript.executeScript(PreparedScript.java:390)
> at org.apache.sysml.JMLCExampleScalar.main(JMLCExampleScalar.java:26)
> Caused by: org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error
> in program block generated from statement block between lines 1 and 9 --
> Error evaluating instruction:
> CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.executeSingleInstruction(ProgramBlock.java:333)
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.executeInstructions(ProgramBlock.java:222)
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.execute(ProgramBlock.java:166)
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:145)
> ... 2 more
> Caused by: org.apache.sysml.runtime.DMLRuntimeException:
> java.io.FileNotFoundException: File tmp/inScalar does not exist
> {code}
> The matrix input and output work fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-651) Fix scalar input support for JMLC
[
https://issues.apache.org/jira/browse/SYSTEMML-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-651.
---
> Fix scalar input support for JMLC
> -
>
> Key: SYSTEMML-651
> URL: https://issues.apache.org/jira/browse/SYSTEMML-651
> Project: SystemML
> Issue Type: Bug
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>Priority: Minor
>
> Currently scalar input variables via JMLC do not work.
> Sample DML (matrix input, scalar input, and a matrix output):
> {code}
> inMatrix = read("./tmp/inMatrix", rows=-1, cols=-1);
> print('inMatrix: ' + nrow(inMatrix) + 'x' + ncol(inMatrix));
> inScalar = read("./tmp/inScalar", data_type="scalar", value_type="int");
> print('inScalar: ' + inScalar);
> outMatrix = matrix("1 2 3 0", rows=2, cols=2);
> print('outMatrix: ' + nrow(outMatrix) + 'x' + ncol(outMatrix));
> write(outMatrix, "./tmp", format="text");
> {code}
> JMLC code:
> {code}
> Connection conn = new Connection();
> String dml = conn.readScript("scalar-test.dml");
> PreparedScript script = conn.prepareScript(dml, new String[] { "inMatrix",
> "inScalar" }, new String[] { "outMatrix" }, false);
> double[][] inMatrix = matrix(2, 2, new double[] { 1, 2, 3, 4 });
> int inScalar = 5;
> script.setMatrix("inMatrix", inMatrix);
> script.setScalar("inScalar", inScalar);
> ResultVariables results = script.executeScript();
> double[][] result = results.getMatrix("outMatrix");
> {code}
> Generates the following error:
> {code}
> Exception in thread "main" org.apache.sysml.runtime.DMLRuntimeException:
> org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error in program
> block generated from statement block between lines 1 and 9 -- Error
> evaluating instruction:
> CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:152)
> at
> org.apache.sysml.api.jmlc.PreparedScript.executeScript(PreparedScript.java:390)
> at org.apache.sysml.JMLCExampleScalar.main(JMLCExampleScalar.java:26)
> Caused by: org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error
> in program block generated from statement block between lines 1 and 9 --
> Error evaluating instruction:
> CP°read°_Var4·SCALAR·INT·false°./tmp/inScalar·SCALAR·STRING·true
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.executeSingleInstruction(ProgramBlock.java:333)
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.executeInstructions(ProgramBlock.java:222)
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.execute(ProgramBlock.java:166)
> at
> org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:145)
> ... 2 more
> Caused by: org.apache.sysml.runtime.DMLRuntimeException:
> java.io.FileNotFoundException: File tmp/inScalar does not exist
> {code}
> The matrix input and output work fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-373) as.scalar vs castAsScalar
[
https://issues.apache.org/jira/browse/SYSTEMML-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269631#comment-15269631
]
Deron Eriksson commented on SYSTEMML-373:
-
This issue has been addressed by SYSTEMML-647 and SYSTEMML-648. I will
therefore close this issue.
> as.scalar vs castAsScalar
> -
>
> Key: SYSTEMML-373
> URL: https://issues.apache.org/jira/browse/SYSTEMML-373
> Project: SystemML
> Issue Type: Improvement
> Components: APIs, Documentation
>Reporter: Deron Eriksson
>Priority: Minor
>
> Currently, as.scalar() and castAsScalar() both allow a matrix element value
> to be cast to a scalar, as in this example:
> {code}
> A = matrix("1 2 3 4", rows=2, cols=2)
> print(as.scalar(A[1,1]))
> print(castAsScalar(A[1,1]))
> {code}
> The as.scalar() function is documented in the DML Language Reference. The
> castAsScalar() function is not documented in the DML Language Reference.
> Which function is the preferred method to use to cast a matrix element to a
> scalar value?
> Should both functions exist, or should only one function exist?
> If castAsScalar() should continue to exist, the DML Language Reference should
> be updated to include it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-647) Replace all castAsScalar calls with as.scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-647: --- Assignee: Deron Eriksson > Replace all castAsScalar calls with as.scalar > - > > Key: SYSTEMML-647 > URL: https://issues.apache.org/jira/browse/SYSTEMML-647 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > The castAsScalar calls in the project need to be replaced by calls to > as.scalar so that castAsScalar can eventually be removed. > There are 85 'castAsScalar' matches in the scripts directory. > There are 415 *.dml 'castAsScalar' matches in the src directory. > There are 69 *.pydml 'castAsScalar' matches in the src directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-373) as.scalar vs castAsScalar
[
https://issues.apache.org/jira/browse/SYSTEMML-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-373.
-
Resolution: Duplicate
> as.scalar vs castAsScalar
> -
>
> Key: SYSTEMML-373
> URL: https://issues.apache.org/jira/browse/SYSTEMML-373
> Project: SystemML
> Issue Type: Improvement
> Components: APIs, Documentation
>Reporter: Deron Eriksson
>Priority: Minor
>
> Currently, as.scalar() and castAsScalar() both allow a matrix element value
> to be cast to a scalar, as in this example:
> {code}
> A = matrix("1 2 3 4", rows=2, cols=2)
> print(as.scalar(A[1,1]))
> print(castAsScalar(A[1,1]))
> {code}
> The as.scalar() function is documented in the DML Language Reference. The
> castAsScalar() function is not documented in the DML Language Reference.
> Which function is the preferred method to use to cast a matrix element to a
> scalar value?
> Should both functions exist, or should only one function exist?
> If castAsScalar() should continue to exist, the DML Language Reference should
> be updated to include it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-373) as.scalar vs castAsScalar
[
https://issues.apache.org/jira/browse/SYSTEMML-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-373.
---
> as.scalar vs castAsScalar
> -
>
> Key: SYSTEMML-373
> URL: https://issues.apache.org/jira/browse/SYSTEMML-373
> Project: SystemML
> Issue Type: Improvement
> Components: APIs, Documentation
>Reporter: Deron Eriksson
>Priority: Minor
>
> Currently, as.scalar() and castAsScalar() both allow a matrix element value
> to be cast to a scalar, as in this example:
> {code}
> A = matrix("1 2 3 4", rows=2, cols=2)
> print(as.scalar(A[1,1]))
> print(castAsScalar(A[1,1]))
> {code}
> The as.scalar() function is documented in the DML Language Reference. The
> castAsScalar() function is not documented in the DML Language Reference.
> Which function is the preferred method to use to cast a matrix element to a
> scalar value?
> Should both functions exist, or should only one function exist?
> If castAsScalar() should continue to exist, the DML Language Reference should
> be updated to include it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-648) Issue deprecated log warning if castAsScalar called
[ https://issues.apache.org/jira/browse/SYSTEMML-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-648. --- > Issue deprecated log warning if castAsScalar called > --- > > Key: SYSTEMML-648 > URL: https://issues.apache.org/jira/browse/SYSTEMML-648 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The castAsScalar function has been replaced by as.scalar. As a result, if a > call to castAsScalar occurs, we should issue a log warning stating that > castAsScalar has been deprecated and has been replaced by as.scalar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-648) Issue deprecated log warning if castAsScalar called
[ https://issues.apache.org/jira/browse/SYSTEMML-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-648. - Resolution: Fixed Fixed by [PR130|https://github.com/apache/incubator-systemml/pull/130]. > Issue deprecated log warning if castAsScalar called > --- > > Key: SYSTEMML-648 > URL: https://issues.apache.org/jira/browse/SYSTEMML-648 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The castAsScalar function has been replaced by as.scalar. As a result, if a > call to castAsScalar occurs, we should issue a log warning stating that > castAsScalar has been deprecated and has been replaced by as.scalar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-659) Update license and notice for main jar artifact
Deron Eriksson created SYSTEMML-659:
---
Summary: Update license and notice for main jar artifact
Key: SYSTEMML-659
URL: https://issues.apache.org/jira/browse/SYSTEMML-659
Project: SystemML
Issue Type: Task
Components: Build
Reporter: Deron Eriksson
The main project jar file that is built (such as
systemml-0.10.0-incubating-SNAPSHOT.jar) contains classes from some other
projects since they are set to the default scope (compile). These projects can
be seen in META-INF/DEPENDENCIES:
{code}
// --
// Transitive dependencies of this project determined from the
// maven pom organized by organization.
// --
SystemML
From: 'abego Software GmbH, Germany' (http://abego-software.de)
- abego TreeLayout Core (http://code.google.com/p/treelayout/)
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
(http://treelayout.googlecode.com/files/LICENSE.TXT)
From: 'an unknown organization'
- Guava: Google Core Libraries for Java
(http://code.google.com/p/guava-libraries/guava)
com.google.guava:guava:bundle:14.0.1
License: The Apache Software License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0.txt)
From: 'ANTLR' (http://www.antlr.org)
- ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
org.antlr:antlr4-annotations:jar:4.3
License: The BSD License (http://www.antlr.org/license.html)
- ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
org.antlr:antlr4-runtime:jar:4.3
License: The BSD License (http://www.antlr.org/license.html)
From: 'The Apache Software Foundation' (http://www.apache.org/)
- Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
org.apache.wink:wink-json4j:jar:1.4
License: The Apache Software License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0.txt)
{code}
The LICENSE and NOTICE files (in META-INF) included in the jar most likely need
to be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-660) Add incubator disclaimer to main jar artifact
Deron Eriksson created SYSTEMML-660: --- Summary: Add incubator disclaimer to main jar artifact Key: SYSTEMML-660 URL: https://issues.apache.org/jira/browse/SYSTEMML-660 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson Priority: Minor The Apache incubator DISCLAIMER should be included in the main jar artifact (at META-INF/DISCLAIMER). By main jar artifact, I mean the primary jar file (such as systemml-0.10.0-incubating-SNAPSHOT.jar). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-661) Update license and notice for distrib assembly (tar.gz and zip)
Deron Eriksson created SYSTEMML-661:
---
Summary: Update license and notice for distrib assembly (tar.gz
and zip)
Key: SYSTEMML-661
URL: https://issues.apache.org/jira/browse/SYSTEMML-661
Project: SystemML
Issue Type: Task
Components: Build
Reporter: Deron Eriksson
The distrib assembly (see pom.xml which references src/assembly/distrib.xml)
generates tar.gz and zip artifacts (such as
systemml-0.10.0-incubating-SNAPSHOT.tar.gz and
systemml-0.10.0-incubating-SNAPSHOT.zip). These artifacts contain the
SystemML.jar file. This file contains classes from other projects since the
scope of these projects is set to the default "compile" scope (see
SYSTEMML-659).
These dependencies can be seen in the META-INF/DEPENDENCIES file in the
SystemML.jar file:
{code}
// --
// Transitive dependencies of this project determined from the
// maven pom organized by organization.
// --
SystemML
From: 'abego Software GmbH, Germany' (http://abego-software.de)
- abego TreeLayout Core (http://code.google.com/p/treelayout/)
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
(http://treelayout.googlecode.com/files/LICENSE.TXT)
From: 'an unknown organization'
- Guava: Google Core Libraries for Java
(http://code.google.com/p/guava-libraries/guava)
com.google.guava:guava:bundle:14.0.1
License: The Apache Software License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0.txt)
From: 'ANTLR' (http://www.antlr.org)
- ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
org.antlr:antlr4-annotations:jar:4.3
License: The BSD License (http://www.antlr.org/license.html)
- ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
org.antlr:antlr4-runtime:jar:4.3
License: The BSD License (http://www.antlr.org/license.html)
From: 'The Apache Software Foundation' (http://www.apache.org/)
- Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
org.apache.wink:wink-json4j:jar:1.4
License: The Apache Software License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0.txt)
{code}
The LICENSE and NOTICE files in the base directory in the tar.gz and zip files
should be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
Deron Eriksson created SYSTEMML-662: --- Summary: Fix license, notice, and disclaimer for standalone jar artifact Key: SYSTEMML-662 URL: https://issues.apache.org/jira/browse/SYSTEMML-662 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson The standalone jar artifact (see "create-standalone-jar" in pom.xml, which delegates to "src/assembly/standalone-jar.xml") has issues with its license, notice, and disclaimer files. #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no META-INF/NOTICE file for SystemML. #3) It contains a META-INF/LICENSE file which is the general Apache license and a META-INF/LICENSE.txt file which is also the general Apache license. However, the LICENSE file most likely should include a listing of the license information for all the projects contained in the project (similar to src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-647) Replace all castAsScalar calls with as.scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-647. - Resolution: Fixed Fixed by [PR136|https://github.com/apache/incubator-systemml/pull/136]. > Replace all castAsScalar calls with as.scalar > - > > Key: SYSTEMML-647 > URL: https://issues.apache.org/jira/browse/SYSTEMML-647 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > The castAsScalar calls in the project need to be replaced by calls to > as.scalar so that castAsScalar can eventually be removed. > There are 85 'castAsScalar' matches in the scripts directory. > There are 415 *.dml 'castAsScalar' matches in the src directory. > There are 69 *.pydml 'castAsScalar' matches in the src directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-647) Replace all castAsScalar calls with as.scalar
[ https://issues.apache.org/jira/browse/SYSTEMML-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-647. --- > Replace all castAsScalar calls with as.scalar > - > > Key: SYSTEMML-647 > URL: https://issues.apache.org/jira/browse/SYSTEMML-647 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > The castAsScalar calls in the project need to be replaced by calls to > as.scalar so that castAsScalar can eventually be removed. > There are 85 'castAsScalar' matches in the scripts directory. > There are 415 *.dml 'castAsScalar' matches in the src directory. > There are 69 *.pydml 'castAsScalar' matches in the src directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-663) Remove redundancies in standalone tar.gz and zip artifacts
Deron Eriksson created SYSTEMML-663: --- Summary: Remove redundancies in standalone tar.gz and zip artifacts Key: SYSTEMML-663 URL: https://issues.apache.org/jira/browse/SYSTEMML-663 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson The standalone tar.gz and zip artifacts (such as systemml-0.10.0-incubating-SNAPSHOT-standalone.tar.gz and systemml-0.10.0-incubating-SNAPSHOT-standalone.zip) contain redundancies in their included projects. In the lib directory, we have the following redundant jars: 1) antlr4-annotations-4.3.jar 2) antlr4-runtime-4.3.jar 3) wink-json4j-1.4.jar These dependencies are also contained (as class files) in the SystemML jar file within the standalone tar.gz and zip files (such as the lib/systemml-0.10.0-incubating-SNAPSHOT.jar file) because they are set to "compile" scope. So, either these jars should be removed from the assembly for these standalone artifacts (src/assembly/standalone.xml), or in pom.xml these dependencies should be set to "provided" scope. Also, the LICENSE/NOTICE files (in src/assembly/standalone) should be updated appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-664) Add incubator disclaimer to javadoc and sources jars
Deron Eriksson created SYSTEMML-664: --- Summary: Add incubator disclaimer to javadoc and sources jars Key: SYSTEMML-664 URL: https://issues.apache.org/jira/browse/SYSTEMML-664 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson Priority: Minor The Apache incubator DISCLAIMER should be included in the javadoc jar and sources jar artifacts (at META-INF/DISCLAIMER). Examples of these artifacts are systemml-0.10.0-incubating-SNAPSHOT-javadoc.jar and systemml-0.10.0-incubating-SNAPSHOT-sources.jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272132#comment-15272132 ] Deron Eriksson commented on SYSTEMML-662: - The DISCLAIMER, NOTICE, and LICENSE files could be located at the base level of the jar artifact. That might be a potentially better location than META-INF/ since other NOTICE and LICENSE files have resolved to META-INF/. > Fix license, notice, and disclaimer for standalone jar artifact > --- > > Key: SYSTEMML-662 > URL: https://issues.apache.org/jira/browse/SYSTEMML-662 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson > > The standalone jar artifact (see "create-standalone-jar" in pom.xml, which > delegates to "src/assembly/standalone-jar.xml") has issues with its license, > notice, and disclaimer files. > #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. > #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a > META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no > META-INF/NOTICE file for SystemML. > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the project (similar to > src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-665) Fix license, notice, and disclaimer for in-memory jar artifact
Deron Eriksson created SYSTEMML-665: --- Summary: Fix license, notice, and disclaimer for in-memory jar artifact Key: SYSTEMML-665 URL: https://issues.apache.org/jira/browse/SYSTEMML-665 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which delegates to "src/assembly/inmemory.xml") has issues with its license, notice, and disclaimer files. #1) The DISCLAIMER file "should" be included (probably best located at base level). #2) It contains a META-INF/NOTICE file for commons logging and a META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file for SystemML (probably best located at base level). #3) It contains a META-INF/LICENSE file which is the general Apache license and a META-INF/LICENSE.txt file which is also the general Apache license. However, the LICENSE file most likely should include a listing of the license information for all the projects contained in the artifact (similar to src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662. This LICENSE for SystemML is probably best located at the base level of the artifact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-638) Random Forest Predict Execution Fails
[
https://issues.apache.org/jira/browse/SYSTEMML-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272959#comment-15272959
]
Deron Eriksson commented on SYSTEMML-638:
-
I believe Faraz and Stacey are discussing this issue.
> Random Forest Predict Execution Fails
> -
>
> Key: SYSTEMML-638
> URL: https://issues.apache.org/jira/browse/SYSTEMML-638
> Project: SystemML
> Issue Type: Bug
>Affects Versions: SystemML 0.10
>Reporter: Stacey Ronaghan
>
> Issue executing the prediction for random forest algorithm on SystemML 0.10
> (incubating) via MLContext with Scala Spark on a cluster.
> Related to [SYSTEMML-597|https://issues.apache.org/jira/browse/SYSTEMML-597].
> X is the same input passed into execute for random-forest.dml (mentioned in
> [SYSTEMML-597|https://issues.apache.org/jira/browse/SYSTEMML-597]) and M is
> its output model.
> Code:
> {code}
> // Register inputs & outputs for prediction
> ml.reset()
> ml.registerInput("X", X)
> //ml.registerInput("Y", Y)
> ml.registerInput("M", M)
> ml.registerOutput("P")
> //ml.registerOutput("A")
> // Run the script
> //val nargs = Map("X" -> "", "Y" -> "", "M" -> "", "P" -> "", "A" -> "")
> val nargs = Map("X" -> "", "M" -> "", "P" -> "")
> val outputs =
> ml.execute("/home/biadmin/spark-enablement/installs/SystemML/algorithms/random-forest-predict.dml",
> nargs)
> val P = outputs.getDF(sqlContext, "P")
> //val A = outputs.getDF(sqlContext, "A")
> {code}
> Output:
> {code}
> import org.apache.sysml.api.MLContext ml: org.apache.sysml.api.MLContext =
> org.apache.sysml.api.MLContext@5649f7b4 nargs:
> scala.collection.immutable.Map[String,String] = Map(X -> "", M -> "", P ->
> "") org.apache.sysml.runtime.DMLRuntimeException:
> org.apache.sysml.runtime.DMLRuntimeException: ERROR: Runtime error in program
> block generated from statement block between lines 68 and 89 -- Error
> evaluating instruction:
> CP°groupedagg°target=_mVar60580°groups=_mVar60580°fn=count°k=40°_mVar60581·MATRIX·DOUBLE
> at org.apache.sysml.runtime.controlprogram.Program.execute(Program.java:152)
> at
> org.apache.sysml.api.MLContext.executeUsingSimplifiedCompilationChain(MLContext.java:1365)
> at
> org.apache.sysml.api.MLContext.compileAndExecuteScript(MLContext.java:1225)
> at
> org.apache.sysml.api.MLContext.compileAndExecuteScript(MLContext.java:1173)
> at org.apache.sysml.api.MLContext.execute(MLContext.java:640) at
> org.apache.sysml.api.MLContext.execute(MLContext.java:675) at
> org.apache.sysml.api.MLContext.execute(MLContext.java:688) at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:41)
> at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:46)
> at $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:48) at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:50) at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:52) at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:54) at
> $iwC$$iwC$$iwC$$iwC$$iwC$$iwC.(:56) at
> $iwC$$iwC$$iwC$$iwC$$iwC.(:58) at
> $iwC$$iwC$$iwC$$iwC.(:60) at
> $iwC$$iwC$$iwC.(:62) at $iwC$$iwC.(:64) at
> $iwC.(:66) at (:68) at .(:72) at
> .() at .(:7) at .() at
> $print() at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497) at
> org.apache.spark.repl.SparkIMain$ReadEvalPrint.call(SparkIMain.scala:1065) at
> org.apache.spark.repl.SparkIMain$Request.loadAndRun(SparkIMain.scala:1338) at
> org.apache.spark.repl.SparkIMain.loadAndRunReq$1(SparkIMain.scala:840) at
> org.apache.spark.repl.SparkIMain.interpret(SparkIMain.scala:871) at
> org.apache.spark.repl.SparkIMain.interpret(SparkIMain.scala:819) at
> org.apache.zeppelin.spark.SparkInterpreter.interpretInput(SparkInterpreter.java:646)
> at
> org.apache.zeppelin.spark.SparkInterpreter.interpret(SparkInterpreter.java:611)
> at
> org.apache.zeppelin.spark.SparkInterpreter.interpret(SparkInterpreter.java:604)
> at
> org.apache.zeppelin.interpreter.ClassloaderInterpreter.interpret(ClassloaderInterpreter.java:57)
> at
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:93)
> at
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:292)
> at org.apache.zeppelin.scheduler.Job.run(Job.java:170) at
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:118) at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at
> java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>
[jira] [Assigned] (SYSTEMML-666) Small Error in Matrix Representation on Decision Tree Docs
[ https://issues.apache.org/jira/browse/SYSTEMML-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-666: --- Assignee: Deron Eriksson > Small Error in Matrix Representation on Decision Tree Docs > -- > > Key: SYSTEMML-666 > URL: https://issues.apache.org/jira/browse/SYSTEMML-666 > Project: SystemML > Issue Type: Bug >Reporter: Stacey Ronaghan >Assignee: Deron Eriksson >Priority: Minor > > The matrix representation for the example decision tree on the [Decision Tree > Documentation|http://apache.github.io/incubator-systemml/algorithms-classification.html#decision-trees] > has a minor error on Row 3, Col 2. The value here should be moved to Row 3, > Col 3 as it refers to the feature index for node 3. Node 2 isn't an internal > node and therefore, the value at Row 3, Col 2 should be 0. > Current: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|5|0|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | > Suggested: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|0|5|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-666) Small Error in Matrix Representation on Decision Tree Docs
[ https://issues.apache.org/jira/browse/SYSTEMML-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273434#comment-15273434 ] Deron Eriksson commented on SYSTEMML-666: - Thank you [~ronaghan]. [PR138|https://github.com/apache/incubator-systemml/pull/138] submitted. > Small Error in Matrix Representation on Decision Tree Docs > -- > > Key: SYSTEMML-666 > URL: https://issues.apache.org/jira/browse/SYSTEMML-666 > Project: SystemML > Issue Type: Bug >Reporter: Stacey Ronaghan >Assignee: Deron Eriksson >Priority: Minor > > The matrix representation for the example decision tree on the [Decision Tree > Documentation|http://apache.github.io/incubator-systemml/algorithms-classification.html#decision-trees] > has a minor error on Row 3, Col 2. The value here should be moved to Row 3, > Col 3 as it refers to the feature index for node 3. Node 2 isn't an internal > node and therefore, the value at Row 3, Col 2 should be 0. > Current: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|5|0|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | > Suggested: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|0|5|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-667) Remove js and css references from standalone license
Deron Eriksson created SYSTEMML-667: --- Summary: Remove js and css references from standalone license Key: SYSTEMML-667 URL: https://issues.apache.org/jira/browse/SYSTEMML-667 Project: SystemML Issue Type: Task Reporter: Deron Eriksson Priority: Minor Currently the only artifacts that contain the project documentation in docs/ are the 'src' distributions (tar.gz and zip). The standalone tar.gz and zip artifacts do not contain the docs folder (which contains the js and css files). Therefore, the js and css project license info can be removed from src/assembly/standalone/LICENSE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-663) Remove redundancies in standalone tar.gz and zip artifacts
[ https://issues.apache.org/jira/browse/SYSTEMML-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276570#comment-15276570 ] Deron Eriksson commented on SYSTEMML-663: - The classes within the specified jars are also included in the SystemML jar file since they are "compile" scope. By having assembly also include the jar, two copies of the classes are being supplied. For example: lib/antlr4-annotations-4.3.jar!org.antlr.v4.runtime.misc.NotNull.class lib/systemml-0.10.0-incubating-SNAPSHOT.jar!org.antlr.v4.runtime.misc.NotNull.class [~mboehm7] Any thoughts? > Remove redundancies in standalone tar.gz and zip artifacts > -- > > Key: SYSTEMML-663 > URL: https://issues.apache.org/jira/browse/SYSTEMML-663 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson > > The standalone tar.gz and zip artifacts (such as > systemml-0.10.0-incubating-SNAPSHOT-standalone.tar.gz and > systemml-0.10.0-incubating-SNAPSHOT-standalone.zip) contain redundancies in > their included projects. > In the lib directory, we have the following redundant jars: > 1) antlr4-annotations-4.3.jar > 2) antlr4-runtime-4.3.jar > 3) wink-json4j-1.4.jar > These dependencies are also contained (as class files) in the SystemML jar > file within the standalone tar.gz and zip files (such as the > lib/systemml-0.10.0-incubating-SNAPSHOT.jar file) because they are set to > "compile" scope. > So, either these jars should be removed from the assembly for these > standalone artifacts (src/assembly/standalone.xml), or in pom.xml these > dependencies should be set to "provided" scope. Also, the LICENSE/NOTICE > files (in src/assembly/standalone) should be updated appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-508) Extend "executeScript" In MLContext To Accept PyDML
[
https://issues.apache.org/jira/browse/SYSTEMML-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276700#comment-15276700
]
Deron Eriksson commented on SYSTEMML-508:
-
[~mwdus...@us.ibm.com] Thanks for keeping me posted. :-)
> Extend "executeScript" In MLContext To Accept PyDML
> ---
>
> Key: SYSTEMML-508
> URL: https://issues.apache.org/jira/browse/SYSTEMML-508
> Project: SystemML
> Issue Type: Sub-task
>Reporter: Mike Dusenberry
>Assignee: Mike Dusenberry
>Priority: Minor
> Fix For: SystemML 0.10
>
>
> When executing a script stored in a string with {{MLContext::executeScript}},
> PyDML is currently not supported. This task is to extend the
> {{executeScript}} API to accept PyDML, much like {{execute}} currently does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-664) Add incubator disclaimer to javadoc and sources jars
[ https://issues.apache.org/jira/browse/SYSTEMML-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276729#comment-15276729 ] Deron Eriksson commented on SYSTEMML-664: - Thank you [~luciano resende]. Verified as fixed by [commit b352521...|https://github.com/apache/incubator-systemml/commit/b352521c996c46443999d27bfb811d2b6af6523c]. > Add incubator disclaimer to javadoc and sources jars > > > Key: SYSTEMML-664 > URL: https://issues.apache.org/jira/browse/SYSTEMML-664 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende >Priority: Minor > Fix For: SystemML 0.10 > > > The Apache incubator DISCLAIMER should be included in the javadoc jar and > sources jar artifacts (at META-INF/DISCLAIMER). Examples of these artifacts > are systemml-0.10.0-incubating-SNAPSHOT-javadoc.jar and > systemml-0.10.0-incubating-SNAPSHOT-sources.jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-664) Add incubator disclaimer to javadoc and sources jars
[ https://issues.apache.org/jira/browse/SYSTEMML-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-664. --- > Add incubator disclaimer to javadoc and sources jars > > > Key: SYSTEMML-664 > URL: https://issues.apache.org/jira/browse/SYSTEMML-664 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende >Priority: Minor > Fix For: SystemML 0.10 > > > The Apache incubator DISCLAIMER should be included in the javadoc jar and > sources jar artifacts (at META-INF/DISCLAIMER). Examples of these artifacts > are systemml-0.10.0-incubating-SNAPSHOT-javadoc.jar and > systemml-0.10.0-incubating-SNAPSHOT-sources.jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-667) Remove js and css references from standalone license
[ https://issues.apache.org/jira/browse/SYSTEMML-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-667: --- Assignee: Deron Eriksson > Remove js and css references from standalone license > > > Key: SYSTEMML-667 > URL: https://issues.apache.org/jira/browse/SYSTEMML-667 > Project: SystemML > Issue Type: Task >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > Currently the only artifacts that contain the project documentation in docs/ > are the 'src' distributions (tar.gz and zip). > The standalone tar.gz and zip artifacts do not contain the docs folder (which > contains the js and css files). Therefore, the js and css project license > info can be removed from src/assembly/standalone/LICENSE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-508) Extend "executeScript" In MLContext To Accept PyDML
[
https://issues.apache.org/jira/browse/SYSTEMML-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276740#comment-15276740
]
Deron Eriksson commented on SYSTEMML-508:
-
We should decide on the best mechanism for this. We could probably do it in
either the MLContext constructor or we could even have a PyMLContext subclass
of MLContext, which might be good if there are other Python-specific defaults
and methods that only make sense from Python.
> Extend "executeScript" In MLContext To Accept PyDML
> ---
>
> Key: SYSTEMML-508
> URL: https://issues.apache.org/jira/browse/SYSTEMML-508
> Project: SystemML
> Issue Type: Sub-task
>Reporter: Mike Dusenberry
>Assignee: Mike Dusenberry
>Priority: Minor
> Fix For: SystemML 0.10
>
>
> When executing a script stored in a string with {{MLContext::executeScript}},
> PyDML is currently not supported. This task is to extend the
> {{executeScript}} API to accept PyDML, much like {{execute}} currently does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-665) Fix license, notice, and disclaimer for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276813#comment-15276813 ] Deron Eriksson commented on SYSTEMML-665: - [~luciano resende] #1) DISCLAIMER looks good. Thank you! #2) NOTICE has SystemML and says contains Apache software. Also mentions ANTLR and SLF4J. Does something need to be there for org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 (BSD license), the classes of which are included in the SystemML jar file (via compile scope)? Or is it fine just referencing this library in the LICENSE file. #3) I think LICENSE of standalone can't be used here and that the in-memory artifact needs its own LICENSE. For example, the following need to be included (these are compile-scope dependencies in in-memory jar artifact): org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 com.google.guava:guava:bundle:14.0.1 org.apache.wink:wink-json4j:jar:1.4 Also, the libraries included in the in-memory jar are different from the libraries included in the standalone jars. See inmemory.xml: *:commons-collections* *:commons-configuration* *:commons-lang* *:commons-logging* *:hadoop-auth* *:hadoop-common* *:hadoop-mapreduce-client-core* *:log4j* *:slf4j-api* *:slf4j-log4j* *:systemml* > Fix license, notice, and disclaimer for in-memory jar artifact > -- > > Key: SYSTEMML-665 > URL: https://issues.apache.org/jira/browse/SYSTEMML-665 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which > delegates to "src/assembly/inmemory.xml") has issues with its license, > notice, and disclaimer files. > #1) The DISCLAIMER file "should" be included (probably best located at base > level). > #2) It contains a META-INF/NOTICE file for commons logging and a > META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file > for SystemML (probably best located at base level). > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the artifact (similar to > src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662. > This LICENSE for SystemML is probably best located at the base level of the > artifact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SYSTEMML-665) Fix license, notice, and disclaimer for in-memory jar artifact
[
https://issues.apache.org/jira/browse/SYSTEMML-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276813#comment-15276813
]
Deron Eriksson edited comment on SYSTEMML-665 at 5/9/16 6:56 PM:
-
[~luciano resende]
#1) DISCLAIMER looks good. Thank you!
#2) NOTICE has SystemML and says contains Apache software. Also mentions ANTLR
and SLF4J. Does something need to be there for
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 (BSD license), the
classes of which are included in the SystemML jar file (via compile scope)? Or
is it fine just referencing this library in the LICENSE file.
#3) I think LICENSE of standalone can't be used here and that the in-memory
artifact needs its own LICENSE. For example, the following need to be included
(these are compile-scope dependencies in in-memory jar artifact):
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
com.google.guava:guava:bundle:14.0.1
org.apache.wink:wink-json4j:jar:1.4
Also, the libraries included in the in-memory jar are different from the
libraries included in the standalone jars. See inmemory.xml:
{code}
*:commons-collections*
*:commons-configuration*
*:commons-lang*
*:commons-logging*
*:hadoop-auth*
*:hadoop-common*
*:hadoop-mapreduce-client-core*
*:log4j*
*:slf4j-api*
*:slf4j-log4j*
*:systemml*
{code}
was (Author: deron):
[~luciano resende]
#1) DISCLAIMER looks good. Thank you!
#2) NOTICE has SystemML and says contains Apache software. Also mentions ANTLR
and SLF4J. Does something need to be there for
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 (BSD license), the
classes of which are included in the SystemML jar file (via compile scope)? Or
is it fine just referencing this library in the LICENSE file.
#3) I think LICENSE of standalone can't be used here and that the in-memory
artifact needs its own LICENSE. For example, the following need to be included
(these are compile-scope dependencies in in-memory jar artifact):
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
com.google.guava:guava:bundle:14.0.1
org.apache.wink:wink-json4j:jar:1.4
Also, the libraries included in the in-memory jar are different from the
libraries included in the standalone jars. See inmemory.xml:
*:commons-collections*
*:commons-configuration*
*:commons-lang*
*:commons-logging*
*:hadoop-auth*
*:hadoop-common*
*:hadoop-mapreduce-client-core*
*:log4j*
*:slf4j-api*
*:slf4j-log4j*
*:systemml*
> Fix license, notice, and disclaimer for in-memory jar artifact
> --
>
> Key: SYSTEMML-665
> URL: https://issues.apache.org/jira/browse/SYSTEMML-665
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Luciano Resende
> Fix For: SystemML 0.10
>
>
> The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which
> delegates to "src/assembly/inmemory.xml") has issues with its license,
> notice, and disclaimer files.
> #1) The DISCLAIMER file "should" be included (probably best located at base
> level).
> #2) It contains a META-INF/NOTICE file for commons logging and a
> META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file
> for SystemML (probably best located at base level).
> #3) It contains a META-INF/LICENSE file which is the general Apache license
> and a META-INF/LICENSE.txt file which is also the general Apache license.
> However, the LICENSE file most likely should include a listing of the license
> information for all the projects contained in the artifact (similar to
> src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662.
> This LICENSE for SystemML is probably best located at the base level of the
> artifact.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-508) Extend "executeScript" In MLContext To Accept PyDML
[
https://issues.apache.org/jira/browse/SYSTEMML-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276819#comment-15276819
]
Deron Eriksson commented on SYSTEMML-508:
-
If it's a single default I'd be in favor of using a constructor. If it turns
out we need multiple methods to specifically support Python, then it would be
nice to put these in a subclass.
> Extend "executeScript" In MLContext To Accept PyDML
> ---
>
> Key: SYSTEMML-508
> URL: https://issues.apache.org/jira/browse/SYSTEMML-508
> Project: SystemML
> Issue Type: Sub-task
>Reporter: Mike Dusenberry
>Assignee: Mike Dusenberry
>Priority: Minor
> Fix For: SystemML 0.10
>
>
> When executing a script stored in a string with {{MLContext::executeScript}},
> PyDML is currently not supported. This task is to extend the
> {{executeScript}} API to accept PyDML, much like {{execute}} currently does.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-663) Remove redundancies in standalone tar.gz and zip artifacts
[ https://issues.apache.org/jira/browse/SYSTEMML-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-663: --- Assignee: Deron Eriksson > Remove redundancies in standalone tar.gz and zip artifacts > -- > > Key: SYSTEMML-663 > URL: https://issues.apache.org/jira/browse/SYSTEMML-663 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The standalone tar.gz and zip artifacts (such as > systemml-0.10.0-incubating-SNAPSHOT-standalone.tar.gz and > systemml-0.10.0-incubating-SNAPSHOT-standalone.zip) contain redundancies in > their included projects. > In the lib directory, we have the following redundant jars: > 1) antlr4-annotations-4.3.jar > 2) antlr4-runtime-4.3.jar > 3) wink-json4j-1.4.jar > These dependencies are also contained (as class files) in the SystemML jar > file within the standalone tar.gz and zip files (such as the > lib/systemml-0.10.0-incubating-SNAPSHOT.jar file) because they are set to > "compile" scope. > So, either these jars should be removed from the assembly for these > standalone artifacts (src/assembly/standalone.xml), or in pom.xml these > dependencies should be set to "provided" scope. Also, the LICENSE/NOTICE > files (in src/assembly/standalone) should be updated appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277106#comment-15277106 ] Deron Eriksson commented on SYSTEMML-662: - [~luciano resende] Thank you for working on this. #1) Looks good. #2) The NOTICE still mentions Wink but not SystemML. Also, do we need any other projects mentioned? #3) The LICENSE contains the basic Apache license but does not mention other projects. Please see the standalone (tar.gz and zip) LICENSE and also the related issues (such as SYSTEMML-665). Do you agree that it would be nice to decrease the number of artifacts that we are generating (11 jars, tar.gz's, zips, etc)? It's extremely difficult to get the licensing and related files correct for so many different artifacts. > Fix license, notice, and disclaimer for standalone jar artifact > --- > > Key: SYSTEMML-662 > URL: https://issues.apache.org/jira/browse/SYSTEMML-662 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The standalone jar artifact (see "create-standalone-jar" in pom.xml, which > delegates to "src/assembly/standalone-jar.xml") has issues with its license, > notice, and disclaimer files. > #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. > #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a > META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no > META-INF/NOTICE file for SystemML. > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the project (similar to > src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-660) Add incubator disclaimer to main jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-660. - Resolution: Fixed Thank you [~luciano resende]. Verified as fixed by [commit b352521...|https://github.com/apache/incubator-systemml/commit/b352521c996c46443999d27bfb811d2b6af6523c]. > Add incubator disclaimer to main jar artifact > - > > Key: SYSTEMML-660 > URL: https://issues.apache.org/jira/browse/SYSTEMML-660 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende >Priority: Minor > > The Apache incubator DISCLAIMER should be included in the main jar artifact > (at META-INF/DISCLAIMER). By main jar artifact, I mean the primary jar file > (such as systemml-0.10.0-incubating-SNAPSHOT.jar). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SYSTEMML-660) Add incubator disclaimer to main jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson updated SYSTEMML-660: Assignee: Luciano Resende > Add incubator disclaimer to main jar artifact > - > > Key: SYSTEMML-660 > URL: https://issues.apache.org/jira/browse/SYSTEMML-660 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende >Priority: Minor > > The Apache incubator DISCLAIMER should be included in the main jar artifact > (at META-INF/DISCLAIMER). By main jar artifact, I mean the primary jar file > (such as systemml-0.10.0-incubating-SNAPSHOT.jar). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-660) Add incubator disclaimer to main jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-660. --- The fix for SYSTEMML-664 fixed this JIRA. > Add incubator disclaimer to main jar artifact > - > > Key: SYSTEMML-660 > URL: https://issues.apache.org/jira/browse/SYSTEMML-660 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende >Priority: Minor > > The Apache incubator DISCLAIMER should be included in the main jar artifact > (at META-INF/DISCLAIMER). By main jar artifact, I mean the primary jar file > (such as systemml-0.10.0-incubating-SNAPSHOT.jar). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-666) Small Error in Matrix Representation on Decision Tree Docs
[ https://issues.apache.org/jira/browse/SYSTEMML-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-666. - Resolution: Fixed Fixed by [PR138|https://github.com/apache/incubator-systemml/pull/138]. > Small Error in Matrix Representation on Decision Tree Docs > -- > > Key: SYSTEMML-666 > URL: https://issues.apache.org/jira/browse/SYSTEMML-666 > Project: SystemML > Issue Type: Bug >Reporter: Stacey Ronaghan >Assignee: Deron Eriksson >Priority: Minor > > The matrix representation for the example decision tree on the [Decision Tree > Documentation|http://apache.github.io/incubator-systemml/algorithms-classification.html#decision-trees] > has a minor error on Row 3, Col 2. The value here should be moved to Row 3, > Col 3 as it refers to the feature index for node 3. Node 2 isn't an internal > node and therefore, the value at Row 3, Col 2 should be 0. > Current: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|5|0|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | > Suggested: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|0|5|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-666) Small Error in Matrix Representation on Decision Tree Docs
[ https://issues.apache.org/jira/browse/SYSTEMML-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-666. --- > Small Error in Matrix Representation on Decision Tree Docs > -- > > Key: SYSTEMML-666 > URL: https://issues.apache.org/jira/browse/SYSTEMML-666 > Project: SystemML > Issue Type: Bug >Reporter: Stacey Ronaghan >Assignee: Deron Eriksson >Priority: Minor > > The matrix representation for the example decision tree on the [Decision Tree > Documentation|http://apache.github.io/incubator-systemml/algorithms-classification.html#decision-trees] > has a minor error on Row 3, Col 2. The value here should be moved to Row 3, > Col 3 as it refers to the feature index for node 3. Node 2 isn't an internal > node and therefore, the value at Row 3, Col 2 should be 0. > Current: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|5|0|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | > Suggested: > || Col 1||Col 2||Col 3||Col 4||Col 5|| > |Row 1|1|2|3|6| 7| > |Row 2|1|0|1|0| 0| > |Row 3|3|0|5|0| 0| > |Row 4|1|1|2|2|1| > |Row 5|1|0|2|0|0| > |Row 6|0.45|0|2|0|0| > |Row 7| | |3| | | -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-667) Remove js and css references from standalone license
[ https://issues.apache.org/jira/browse/SYSTEMML-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-667. - Resolution: Fixed Fixed by [PR143|https://github.com/apache/incubator-systemml/pull/143]. > Remove js and css references from standalone license > > > Key: SYSTEMML-667 > URL: https://issues.apache.org/jira/browse/SYSTEMML-667 > Project: SystemML > Issue Type: Task >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > Currently the only artifacts that contain the project documentation in docs/ > are the 'src' distributions (tar.gz and zip). > The standalone tar.gz and zip artifacts do not contain the docs folder (which > contains the js and css files). Therefore, the js and css project license > info can be removed from src/assembly/standalone/LICENSE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-667) Remove js and css references from standalone license
[ https://issues.apache.org/jira/browse/SYSTEMML-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-667. --- > Remove js and css references from standalone license > > > Key: SYSTEMML-667 > URL: https://issues.apache.org/jira/browse/SYSTEMML-667 > Project: SystemML > Issue Type: Task >Reporter: Deron Eriksson >Assignee: Deron Eriksson >Priority: Minor > > Currently the only artifacts that contain the project documentation in docs/ > are the 'src' distributions (tar.gz and zip). > The standalone tar.gz and zip artifacts do not contain the docs folder (which > contains the js and css files). Therefore, the js and css project license > info can be removed from src/assembly/standalone/LICENSE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-663) Remove redundancies in standalone tar.gz and zip artifacts
[ https://issues.apache.org/jira/browse/SYSTEMML-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-663. - Resolution: Fixed Fixed by [PR144|https://github.com/apache/incubator-systemml/pull/144]. > Remove redundancies in standalone tar.gz and zip artifacts > -- > > Key: SYSTEMML-663 > URL: https://issues.apache.org/jira/browse/SYSTEMML-663 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The standalone tar.gz and zip artifacts (such as > systemml-0.10.0-incubating-SNAPSHOT-standalone.tar.gz and > systemml-0.10.0-incubating-SNAPSHOT-standalone.zip) contain redundancies in > their included projects. > In the lib directory, we have the following redundant jars: > 1) antlr4-annotations-4.3.jar > 2) antlr4-runtime-4.3.jar > 3) wink-json4j-1.4.jar > These dependencies are also contained (as class files) in the SystemML jar > file within the standalone tar.gz and zip files (such as the > lib/systemml-0.10.0-incubating-SNAPSHOT.jar file) because they are set to > "compile" scope. > So, either these jars should be removed from the assembly for these > standalone artifacts (src/assembly/standalone.xml), or in pom.xml these > dependencies should be set to "provided" scope. Also, the LICENSE/NOTICE > files (in src/assembly/standalone) should be updated appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-663) Remove redundancies in standalone tar.gz and zip artifacts
[ https://issues.apache.org/jira/browse/SYSTEMML-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-663. --- > Remove redundancies in standalone tar.gz and zip artifacts > -- > > Key: SYSTEMML-663 > URL: https://issues.apache.org/jira/browse/SYSTEMML-663 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > The standalone tar.gz and zip artifacts (such as > systemml-0.10.0-incubating-SNAPSHOT-standalone.tar.gz and > systemml-0.10.0-incubating-SNAPSHOT-standalone.zip) contain redundancies in > their included projects. > In the lib directory, we have the following redundant jars: > 1) antlr4-annotations-4.3.jar > 2) antlr4-runtime-4.3.jar > 3) wink-json4j-1.4.jar > These dependencies are also contained (as class files) in the SystemML jar > file within the standalone tar.gz and zip files (such as the > lib/systemml-0.10.0-incubating-SNAPSHOT.jar file) because they are set to > "compile" scope. > So, either these jars should be removed from the assembly for these > standalone artifacts (src/assembly/standalone.xml), or in pom.xml these > dependencies should be set to "provided" scope. Also, the LICENSE/NOTICE > files (in src/assembly/standalone) should be updated appropriately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-661) Update license and notice for distrib assembly (tar.gz and zip)
[
https://issues.apache.org/jira/browse/SYSTEMML-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson reassigned SYSTEMML-661:
---
Assignee: Deron Eriksson
> Update license and notice for distrib assembly (tar.gz and zip)
> ---
>
> Key: SYSTEMML-661
> URL: https://issues.apache.org/jira/browse/SYSTEMML-661
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The distrib assembly (see pom.xml which references src/assembly/distrib.xml)
> generates tar.gz and zip artifacts (such as
> systemml-0.10.0-incubating-SNAPSHOT.tar.gz and
> systemml-0.10.0-incubating-SNAPSHOT.zip). These artifacts contain the
> SystemML.jar file. This file contains classes from other projects since the
> scope of these projects is set to the default "compile" scope (see
> SYSTEMML-659).
> These dependencies can be seen in the META-INF/DEPENDENCIES file in the
> SystemML.jar file:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files in the base directory in the tar.gz and zip
> files should be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-661) Update license and notice for distrib assembly (tar.gz and zip)
[
https://issues.apache.org/jira/browse/SYSTEMML-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-661.
---
> Update license and notice for distrib assembly (tar.gz and zip)
> ---
>
> Key: SYSTEMML-661
> URL: https://issues.apache.org/jira/browse/SYSTEMML-661
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The distrib assembly (see pom.xml which references src/assembly/distrib.xml)
> generates tar.gz and zip artifacts (such as
> systemml-0.10.0-incubating-SNAPSHOT.tar.gz and
> systemml-0.10.0-incubating-SNAPSHOT.zip). These artifacts contain the
> SystemML.jar file. This file contains classes from other projects since the
> scope of these projects is set to the default "compile" scope (see
> SYSTEMML-659).
> These dependencies can be seen in the META-INF/DEPENDENCIES file in the
> SystemML.jar file:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files in the base directory in the tar.gz and zip
> files should be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-661) Update license and notice for distrib assembly (tar.gz and zip)
[
https://issues.apache.org/jira/browse/SYSTEMML-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-661.
-
Resolution: Fixed
Fixed by [PR146|https://github.com/apache/incubator-systemml/pull/146].
> Update license and notice for distrib assembly (tar.gz and zip)
> ---
>
> Key: SYSTEMML-661
> URL: https://issues.apache.org/jira/browse/SYSTEMML-661
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The distrib assembly (see pom.xml which references src/assembly/distrib.xml)
> generates tar.gz and zip artifacts (such as
> systemml-0.10.0-incubating-SNAPSHOT.tar.gz and
> systemml-0.10.0-incubating-SNAPSHOT.zip). These artifacts contain the
> SystemML.jar file. This file contains classes from other projects since the
> scope of these projects is set to the default "compile" scope (see
> SYSTEMML-659).
> These dependencies can be seen in the META-INF/DEPENDENCIES file in the
> SystemML.jar file:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files in the base directory in the tar.gz and zip
> files should be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278569#comment-15278569 ] Deron Eriksson commented on SYSTEMML-662: - [PR146|https://github.com/apache/incubator-systemml/pull/146] deals with a similar issue for the distrib assembly. You may want to have a look at that. > Fix license, notice, and disclaimer for standalone jar artifact > --- > > Key: SYSTEMML-662 > URL: https://issues.apache.org/jira/browse/SYSTEMML-662 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The standalone jar artifact (see "create-standalone-jar" in pom.xml, which > delegates to "src/assembly/standalone-jar.xml") has issues with its license, > notice, and disclaimer files. > #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. > #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a > META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no > META-INF/NOTICE file for SystemML. > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the project (similar to > src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-665) Fix license, notice, and disclaimer for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278571#comment-15278571 ] Deron Eriksson commented on SYSTEMML-665: - [PR146|https://github.com/apache/incubator-systemml/pull/146] deals with a similar issue for the distrib assembly. > Fix license, notice, and disclaimer for in-memory jar artifact > -- > > Key: SYSTEMML-665 > URL: https://issues.apache.org/jira/browse/SYSTEMML-665 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which > delegates to "src/assembly/inmemory.xml") has issues with its license, > notice, and disclaimer files. > #1) The DISCLAIMER file "should" be included (probably best located at base > level). > #2) It contains a META-INF/NOTICE file for commons logging and a > META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file > for SystemML (probably best located at base level). > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the artifact (similar to > src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662. > This LICENSE for SystemML is probably best located at the base level of the > artifact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-649) JMLC/MLContext support for scalar output variables
[ https://issues.apache.org/jira/browse/SYSTEMML-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280517#comment-15280517 ] Deron Eriksson commented on SYSTEMML-649: - JMLC scalar output support fixed by [PR150|https://github.com/apache/incubator-systemml/pull/150]. I will address MLContext scalar support in the new MLContext API. > JMLC/MLContext support for scalar output variables > -- > > Key: SYSTEMML-649 > URL: https://issues.apache.org/jira/browse/SYSTEMML-649 > Project: SystemML > Issue Type: Task > Components: APIs >Reporter: Matthias Boehm >Assignee: Deron Eriksson > > Right now neither JMLC nor MLContext supports scalar output variables. This > task aims to extend both APIs with the required primitives. > The workaround is to cast any output scalar on script-level with as.matrix to > a 1-1 matrix and handle it in the calling application. However, especially > with MLContext this puts an unnecessary burden on the user as he needs to > deal with RDDs for a simple scalar too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-662. --- > Fix license, notice, and disclaimer for standalone jar artifact > --- > > Key: SYSTEMML-662 > URL: https://issues.apache.org/jira/browse/SYSTEMML-662 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The standalone jar artifact (see "create-standalone-jar" in pom.xml, which > delegates to "src/assembly/standalone-jar.xml") has issues with its license, > notice, and disclaimer files. > #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. > #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a > META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no > META-INF/NOTICE file for SystemML. > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the project (similar to > src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYSTEMML-662) Fix license, notice, and disclaimer for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280634#comment-15280634 ] Deron Eriksson commented on SYSTEMML-662: - I will close this issue and create another JIRA for the additional updates. Thank you. > Fix license, notice, and disclaimer for standalone jar artifact > --- > > Key: SYSTEMML-662 > URL: https://issues.apache.org/jira/browse/SYSTEMML-662 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The standalone jar artifact (see "create-standalone-jar" in pom.xml, which > delegates to "src/assembly/standalone-jar.xml") has issues with its license, > notice, and disclaimer files. > #1) There is no META-INF/DISCLAIMER incubator file, which "should" be there. > #2) It contains a META-INF/NOTICE file for "Apache Wink :: JSON4J" and a > META-INF/NOTICE.txt file for "Apache Commons CLI". However, there is no > META-INF/NOTICE file for SystemML. > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the project (similar to > src/assembly/standalone/LICENSE). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-665) Fix license, notice, and disclaimer for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-665. --- I will close this issue and create another JIRA for the additional updates. Thank you. > Fix license, notice, and disclaimer for in-memory jar artifact > -- > > Key: SYSTEMML-665 > URL: https://issues.apache.org/jira/browse/SYSTEMML-665 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Luciano Resende > Fix For: SystemML 0.10 > > > The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which > delegates to "src/assembly/inmemory.xml") has issues with its license, > notice, and disclaimer files. > #1) The DISCLAIMER file "should" be included (probably best located at base > level). > #2) It contains a META-INF/NOTICE file for commons logging and a > META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file > for SystemML (probably best located at base level). > #3) It contains a META-INF/LICENSE file which is the general Apache license > and a META-INF/LICENSE.txt file which is also the general Apache license. > However, the LICENSE file most likely should include a listing of the license > information for all the projects contained in the artifact (similar to > src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662. > This LICENSE for SystemML is probably best located at the base level of the > artifact. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-682) Update LICENSE and NOTICE for in-memory jar artifact
Deron Eriksson created SYSTEMML-682: --- Summary: Update LICENSE and NOTICE for in-memory jar artifact Key: SYSTEMML-682 URL: https://issues.apache.org/jira/browse/SYSTEMML-682 Project: SystemML Issue Type: Task Reporter: Deron Eriksson LICENSE and NOTICE files need to be updated to reflect the library dependencies packaged in in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-682) Update LICENSE and NOTICE for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-682: --- Assignee: Deron Eriksson > Update LICENSE and NOTICE for in-memory jar artifact > > > Key: SYSTEMML-682 > URL: https://issues.apache.org/jira/browse/SYSTEMML-682 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > LICENSE and NOTICE files need to be updated to reflect the library > dependencies packaged in in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SYSTEMML-682) Update LICENSE and NOTICE for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson updated SYSTEMML-682: Component/s: Build > Update LICENSE and NOTICE for in-memory jar artifact > > > Key: SYSTEMML-682 > URL: https://issues.apache.org/jira/browse/SYSTEMML-682 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > LICENSE and NOTICE files need to be updated to reflect the library > dependencies packaged in in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-683) Update LICENSE and NOTICE for in-memory jar artifact
Deron Eriksson created SYSTEMML-683: --- Summary: Update LICENSE and NOTICE for in-memory jar artifact Key: SYSTEMML-683 URL: https://issues.apache.org/jira/browse/SYSTEMML-683 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson Update assembly for the LICENSE and NOTICE for the dependencies contained in the in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-683) Update LICENSE and NOTICE for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-683: --- Assignee: Deron Eriksson > Update LICENSE and NOTICE for in-memory jar artifact > > > Key: SYSTEMML-683 > URL: https://issues.apache.org/jira/browse/SYSTEMML-683 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-684) Update LICENSE and NOTICE for standalone jar artifact
Deron Eriksson created SYSTEMML-684: --- Summary: Update LICENSE and NOTICE for standalone jar artifact Key: SYSTEMML-684 URL: https://issues.apache.org/jira/browse/SYSTEMML-684 Project: SystemML Issue Type: Task Components: Build Reporter: Deron Eriksson Update assembly for the LICENSE and NOTICE for the dependencies contained in the standalone jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-684) Update LICENSE and NOTICE for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson reassigned SYSTEMML-684: --- Assignee: Deron Eriksson > Update LICENSE and NOTICE for standalone jar artifact > - > > Key: SYSTEMML-684 > URL: https://issues.apache.org/jira/browse/SYSTEMML-684 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the standalone jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-683) Update LICENSE and NOTICE for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-683. - Resolution: Fixed Fixed by [PR152|https://github.com/apache/incubator-systemml/pull/152]. Note that this was originally handled by SYSTEMML-682 but this issue disappeared from the system, so it was replaced by SYSTEMML-683. > Update LICENSE and NOTICE for in-memory jar artifact > > > Key: SYSTEMML-683 > URL: https://issues.apache.org/jira/browse/SYSTEMML-683 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-683) Update LICENSE and NOTICE for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-683. --- > Update LICENSE and NOTICE for in-memory jar artifact > > > Key: SYSTEMML-683 > URL: https://issues.apache.org/jira/browse/SYSTEMML-683 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the in-memory jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-684) Update LICENSE and NOTICE for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson resolved SYSTEMML-684. - Resolution: Fixed Fixed by [PR153|https://github.com/apache/incubator-systemml/pull/153]. > Update LICENSE and NOTICE for standalone jar artifact > - > > Key: SYSTEMML-684 > URL: https://issues.apache.org/jira/browse/SYSTEMML-684 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the standalone jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-684) Update LICENSE and NOTICE for standalone jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deron Eriksson closed SYSTEMML-684. --- > Update LICENSE and NOTICE for standalone jar artifact > - > > Key: SYSTEMML-684 > URL: https://issues.apache.org/jira/browse/SYSTEMML-684 > Project: SystemML > Issue Type: Task > Components: Build >Reporter: Deron Eriksson >Assignee: Deron Eriksson > > Update assembly for the LICENSE and NOTICE for the dependencies contained in > the standalone jar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-688) Package algorithm files in folder in several artifacts
Deron Eriksson created SYSTEMML-688:
---
Summary: Package algorithm files in folder in several artifacts
Key: SYSTEMML-688
URL: https://issues.apache.org/jira/browse/SYSTEMML-688
Project: SystemML
Issue Type: Task
Components: Build
Reporter: Deron Eriksson
The main algorithm files are written to the base directory of the following
artifacts:
systemml-0.10.0-incubating-SNAPSHOT.jar
systemml-0.10.0-incubating-SNAPSHOT-inmemory.jar
systemml-0.10.0-incubating-SNAPSHOT-sources.jar
systemml-0.10.0-incubating-SNAPSHOT-standalone.jar
It would be good to package these algorithm files either into a scripts/ folder
or a scripts/algorithms folder.
As an example, here is the current primary jar file base directory contents:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── ALS-CG.dml
├── ALS-DS.dml
├── ALS_predict.dml
├── ALS_topk_predict.dml
├── Cox-predict.dml
├── Cox.dml
├── CsplineCG.dml
├── CsplineDS.dml
├── GLM-predict.dml
├── GLM.dml
├── KM.dml
├── Kmeans-predict.dml
├── Kmeans.dml
├── LinearRegCG.dml
├── LinearRegDS.dml
├── META-INF
├── MultiLogReg.dml
├── PCA.dml
├── StepGLM.dml
├── StepLinearRegDS.dml
├── Univar-Stats.dml
├── apply-transform.dml
├── bivar-stats.dml
├── com
├── decision-tree-predict.dml
├── decision-tree.dml
├── l2-svm-predict.dml
├── l2-svm.dml
├── m-svm-predict.dml
├── m-svm.dml
├── naive-bayes-predict.dml
├── naive-bayes.dml
├── obsolete
├── org
├── random-forest-predict.dml
├── random-forest.dml
├── stratstats.dml
└── transform.dml
{code}
Placing the *.dml files in a scripts/ or scripts/algorithms/ folder would give
the following contents in the base directory:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── META-INF
├── com
├── org
└── scripts
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SYSTEMML-688) Package algorithm files in folder in several artifacts
[
https://issues.apache.org/jira/browse/SYSTEMML-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson updated SYSTEMML-688:
Description:
The main algorithm files are written to the base directory of the following
artifacts:
systemml-0.10.0-incubating-SNAPSHOT.jar
systemml-0.10.0-incubating-SNAPSHOT-inmemory.jar
systemml-0.10.0-incubating-SNAPSHOT-sources.jar
systemml-0.10.0-incubating-SNAPSHOT-standalone.jar
It would be good to package these algorithm files either into a scripts/ folder
or a scripts/algorithms folder.
As an example, here are the current primary jar file base directory contents:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── ALS-CG.dml
├── ALS-DS.dml
├── ALS_predict.dml
├── ALS_topk_predict.dml
├── Cox-predict.dml
├── Cox.dml
├── CsplineCG.dml
├── CsplineDS.dml
├── GLM-predict.dml
├── GLM.dml
├── KM.dml
├── Kmeans-predict.dml
├── Kmeans.dml
├── LinearRegCG.dml
├── LinearRegDS.dml
├── META-INF
├── MultiLogReg.dml
├── PCA.dml
├── StepGLM.dml
├── StepLinearRegDS.dml
├── Univar-Stats.dml
├── apply-transform.dml
├── bivar-stats.dml
├── com
├── decision-tree-predict.dml
├── decision-tree.dml
├── l2-svm-predict.dml
├── l2-svm.dml
├── m-svm-predict.dml
├── m-svm.dml
├── naive-bayes-predict.dml
├── naive-bayes.dml
├── obsolete
├── org
├── random-forest-predict.dml
├── random-forest.dml
├── stratstats.dml
└── transform.dml
{code}
Placing the *.dml files in a scripts/ or scripts/algorithms/ folder would give
the following contents in the base directory:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── META-INF
├── com
├── org
└── scripts
{code}
was:
The main algorithm files are written to the base directory of the following
artifacts:
systemml-0.10.0-incubating-SNAPSHOT.jar
systemml-0.10.0-incubating-SNAPSHOT-inmemory.jar
systemml-0.10.0-incubating-SNAPSHOT-sources.jar
systemml-0.10.0-incubating-SNAPSHOT-standalone.jar
It would be good to package these algorithm files either into a scripts/ folder
or a scripts/algorithms folder.
As an example, here is the current primary jar file base directory contents:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── ALS-CG.dml
├── ALS-DS.dml
├── ALS_predict.dml
├── ALS_topk_predict.dml
├── Cox-predict.dml
├── Cox.dml
├── CsplineCG.dml
├── CsplineDS.dml
├── GLM-predict.dml
├── GLM.dml
├── KM.dml
├── Kmeans-predict.dml
├── Kmeans.dml
├── LinearRegCG.dml
├── LinearRegDS.dml
├── META-INF
├── MultiLogReg.dml
├── PCA.dml
├── StepGLM.dml
├── StepLinearRegDS.dml
├── Univar-Stats.dml
├── apply-transform.dml
├── bivar-stats.dml
├── com
├── decision-tree-predict.dml
├── decision-tree.dml
├── l2-svm-predict.dml
├── l2-svm.dml
├── m-svm-predict.dml
├── m-svm.dml
├── naive-bayes-predict.dml
├── naive-bayes.dml
├── obsolete
├── org
├── random-forest-predict.dml
├── random-forest.dml
├── stratstats.dml
└── transform.dml
{code}
Placing the *.dml files in a scripts/ or scripts/algorithms/ folder would give
the following contents in the base directory:
{code}
$ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
systemml-0.10.0-incubating-SNAPSHOT
├── META-INF
├── com
├── org
└── scripts
{code}
> Package algorithm files in folder in several artifacts
> --
>
> Key: SYSTEMML-688
> URL: https://issues.apache.org/jira/browse/SYSTEMML-688
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>
> The main algorithm files are written to the base directory of the following
> artifacts:
> systemml-0.10.0-incubating-SNAPSHOT.jar
> systemml-0.10.0-incubating-SNAPSHOT-inmemory.jar
> systemml-0.10.0-incubating-SNAPSHOT-sources.jar
> systemml-0.10.0-incubating-SNAPSHOT-standalone.jar
> It would be good to package these algorithm files either into a scripts/
> folder or a scripts/algorithms folder.
> As an example, here are the current primary jar file base directory contents:
> {code}
> $ tree -L 1 systemml-0.10.0-incubating-SNAPSHOT
> systemml-0.10.0-incubating-SNAPSHOT
> ├── ALS-CG.dml
> ├── ALS-DS.dml
> ├── ALS_predict.dml
> ├── ALS_topk_predict.dml
> ├── Cox-predict.dml
> ├── Cox.dml
> ├── CsplineCG.dml
> ├── CsplineDS.dml
> ├── GLM-predict.dml
> ├── GLM.dml
> ├── KM.dml
> ├── Kmeans-predict.dml
> ├── Kmeans.dml
> ├── LinearRegCG.dml
> ├── LinearRegDS.dml
> ├── META-INF
> ├── MultiLogReg.dml
> ├── PCA.dml
> ├── StepGLM.dml
> ├── StepLinearRegDS.dml
> ├── Univar-Stats.dml
> ├── apply-transform.dml
> ├── bivar-stats.dml
> ├── com
> ├── decision-tree-predict.dml
> ├── decision-tree.dml
> ├── l2-svm-predict.dml
> ├── l2-svm.dml
> ├── m-svm-predict.dml
> ├── m-svm.dml
> ├── naive-bayes-predict.dml
> ├── naive-bayes.dml
> ├── obsolete
> ├── org
> ├── random-forest-predict.dml
> ├── random-forest.dml
> ├── st
[jira] [Assigned] (SYSTEMML-659) Update license and notice for main jar artifact
[
https://issues.apache.org/jira/browse/SYSTEMML-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson reassigned SYSTEMML-659:
---
Assignee: Deron Eriksson
> Update license and notice for main jar artifact
> ---
>
> Key: SYSTEMML-659
> URL: https://issues.apache.org/jira/browse/SYSTEMML-659
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The main project jar file that is built (such as
> systemml-0.10.0-incubating-SNAPSHOT.jar) contains classes from some other
> projects since they are set to the default scope (compile). These projects
> can be seen in META-INF/DEPENDENCIES:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files (in META-INF) included in the jar most likely
> need to be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SYSTEMML-698) Investigate removal of compile-scope dependencies
Deron Eriksson created SYSTEMML-698: --- Summary: Investigate removal of compile-scope dependencies Key: SYSTEMML-698 URL: https://issues.apache.org/jira/browse/SYSTEMML-698 Project: SystemML Issue Type: Improvement Components: Build Reporter: Deron Eriksson Assignee: Deron Eriksson SystemML currently has several compile-scope dependencies. Including these in the main jar leads to a larger jar and complicates LICENSE/NOTICE maintenance. Investigate if any or all of these can be removed, replaced, or set to package scope. These are: org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 com.google.guava:guava:bundle:14.0.1 org.antlr:antlr4-annotations:jar:4.3 org.antlr:antlr4-runtime:jar:4.3 org.apache.wink:wink-json4j:jar:1.4 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SYSTEMML-699) Increase prominence of Notebook documentation
Deron Eriksson created SYSTEMML-699: --- Summary: Increase prominence of Notebook documentation Key: SYSTEMML-699 URL: https://issues.apache.org/jira/browse/SYSTEMML-699 Project: SystemML Issue Type: Task Components: Documentation Reporter: Deron Eriksson Currently the primary documentation for running SystemML in a Notebook (Jupyter, Zeppelin) is buried in the MLContext documentation. Given the importance of this SystemML execution path for data scientists, the Notebook documentation needs to be more prominent. It can potentially be split into its own section. It should also be linked to not just from index.md but also from the GitHub README. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SYSTEMML-533) Error when print consecutive pound signs
[
https://issues.apache.org/jira/browse/SYSTEMML-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-533.
---
Fixed by
https://github.com/apache/incubator-systemml/commit/e0356496adc2070c2d532fd242c7dbf263ab73e4
> Error when print consecutive pound signs
>
>
> Key: SYSTEMML-533
> URL: https://issues.apache.org/jira/browse/SYSTEMML-533
> Project: SystemML
> Issue Type: Bug
> Components: Parser
>Reporter: Deron Eriksson
>Assignee: Matthias Boehm
>Priority: Minor
> Fix For: SystemML 0.10
>
>
> Trying to print consecutive pound (#) signs results in an error:
> {code}
> print("#"); # this works
> print("##"); # this doesn't work
> print("###"); # this doesn't work
> print("#"+"#"); # this doesn't work
> a="##";
> print(a); # this doesn't work
> b="#";
> print(b+b); # this doesn't work
> {code}
> Error:
> {code}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -12
> at java.lang.String.substring(String.java:1937)
> at
> org.apache.sysml.lops.runtime.RunMRJobs.updateInstLabels(RunMRJobs.java:449)
> at
> org.apache.sysml.lops.runtime.RunMRJobs.updateLabels(RunMRJobs.java:478)
> at
> org.apache.sysml.runtime.instructions.cp.CPInstruction.preprocessInstruction(CPInstruction.java:81)
> at
> org.apache.sysml.runtime.controlprogram.ProgramBlock.executeSingleInstruction(ProgramBlock.java:306)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-656) Read-in boolean variable math treated as doubles rather than booleans
[
https://issues.apache.org/jira/browse/SYSTEMML-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-656.
---
Fixed by
https://github.com/apache/incubator-systemml/commit/5bde577a2414ef851bc8601b84aa5f6323ee6260
> Read-in boolean variable math treated as doubles rather than booleans
> -
>
> Key: SYSTEMML-656
> URL: https://issues.apache.org/jira/browse/SYSTEMML-656
> Project: SystemML
> Issue Type: Bug
>Reporter: Deron Eriksson
>Assignee: Matthias Boehm
> Fix For: SystemML 0.10
>
>
> If we have two boolean variables and add them normally, the addition is
> treated as boolean algebra (true + true = true).
> {code}
> x = TRUE;
> y = TRUE;
> z = x + y;
> print(x);
> print(y);
> print(z);
> {code}
> produces
> {code}
> TRUE
> TRUE
> TRUE
> {code}
> However, if we read in boolean scalars using the read statement and add the
> boolean variables, the math ends up giving a double result instead of a
> boolean result:
> {code}
> x = read("./tmp/sc1", data_type="scalar", value_type="boolean");
> y = read("./tmp/sc2", data_type="scalar", value_type="boolean");
> z = x + y;
> print(x);
> print(y);
> print(z);
> {code}
> This produces (where ./tmp/sc1 contains "TRUE" and ./tmp/sc2 contains "TRUE"):
> {code}
> TRUE
> TRUE
> 2.0
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-296) Add elif (else if) to PyDML
[
https://issues.apache.org/jira/browse/SYSTEMML-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-296.
-
Resolution: Fixed
Thank you [~nishiyama]!
Fixed by [PR151|https://github.com/apache/incubator-systemml/pull/151].
> Add elif (else if) to PyDML
> ---
>
> Key: SYSTEMML-296
> URL: https://issues.apache.org/jira/browse/SYSTEMML-296
> Project: SystemML
> Issue Type: Improvement
> Components: Parser, PyDML
>Reporter: Deron Eriksson
>Assignee: Tatsuya Nishiyama
>Priority: Minor
>
> "Else if" (elif) statements are useful since they avoid the need for nested
> if/else statements. Currently, DML has "else if" but PyDML does not have an
> equivalent "elif".
> As an example, here is DML containing "else if" statements:
> {code}
> x = 6
> if (x == 1) {
> print('A')
> } else if (x == 2) {
> print('B')
> } else if (x == 3) {
> print('C')
> } else if (x == 4) {
> print('D')
> } else if (x == 5) {
> print('E')
> } else {
> print('F')
> }
> {code}
> Here is the logical equivalent in PyDML using nested "if else" statements:
> {code}
> x = 6
> if (x == 1):
> print('A')
> else:
> if (x == 2):
> print('B')
> else:
> if (x == 3):
> print('C')
> else:
> if (x == 4):
> print('D')
> else:
> if (x == 5):
> print('E')
> else:
> print('F')
> {code}
> The nesting becomes especially challenging in a Python-like language as the
> number of nested "if else" statements increases due to the use of whitespace
> indentations to specify blocks of code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-296) Add elif (else if) to PyDML
[
https://issues.apache.org/jira/browse/SYSTEMML-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-296.
---
> Add elif (else if) to PyDML
> ---
>
> Key: SYSTEMML-296
> URL: https://issues.apache.org/jira/browse/SYSTEMML-296
> Project: SystemML
> Issue Type: Improvement
> Components: Parser, PyDML
>Reporter: Deron Eriksson
>Assignee: Tatsuya Nishiyama
>Priority: Minor
>
> "Else if" (elif) statements are useful since they avoid the need for nested
> if/else statements. Currently, DML has "else if" but PyDML does not have an
> equivalent "elif".
> As an example, here is DML containing "else if" statements:
> {code}
> x = 6
> if (x == 1) {
> print('A')
> } else if (x == 2) {
> print('B')
> } else if (x == 3) {
> print('C')
> } else if (x == 4) {
> print('D')
> } else if (x == 5) {
> print('E')
> } else {
> print('F')
> }
> {code}
> Here is the logical equivalent in PyDML using nested "if else" statements:
> {code}
> x = 6
> if (x == 1):
> print('A')
> else:
> if (x == 2):
> print('B')
> else:
> if (x == 3):
> print('C')
> else:
> if (x == 4):
> print('D')
> else:
> if (x == 5):
> print('E')
> else:
> print('F')
> {code}
> The nesting becomes especially challenging in a Python-like language as the
> number of nested "if else" statements increases due to the use of whitespace
> indentations to specify blocks of code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SYSTEMML-659) Update license and notice for main jar artifact
[
https://issues.apache.org/jira/browse/SYSTEMML-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson closed SYSTEMML-659.
---
> Update license and notice for main jar artifact
> ---
>
> Key: SYSTEMML-659
> URL: https://issues.apache.org/jira/browse/SYSTEMML-659
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The main project jar file that is built (such as
> systemml-0.10.0-incubating-SNAPSHOT.jar) contains classes from some other
> projects since they are set to the default scope (compile). These projects
> can be seen in META-INF/DEPENDENCIES:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files (in META-INF) included in the jar most likely
> need to be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SYSTEMML-659) Update license and notice for main jar artifact
[
https://issues.apache.org/jira/browse/SYSTEMML-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson resolved SYSTEMML-659.
-
Resolution: Fixed
Fixed by [PR157|https://github.com/apache/incubator-systemml/pull/157]
> Update license and notice for main jar artifact
> ---
>
> Key: SYSTEMML-659
> URL: https://issues.apache.org/jira/browse/SYSTEMML-659
> Project: SystemML
> Issue Type: Task
> Components: Build
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>
> The main project jar file that is built (such as
> systemml-0.10.0-incubating-SNAPSHOT.jar) contains classes from some other
> projects since they are set to the default scope (compile). These projects
> can be seen in META-INF/DEPENDENCIES:
> {code}
> // --
> // Transitive dependencies of this project determined from the
> // maven pom organized by organization.
> // --
> SystemML
> From: 'abego Software GmbH, Germany' (http://abego-software.de)
> - abego TreeLayout Core (http://code.google.com/p/treelayout/)
> org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
> License: BSD 3-Clause "New" or "Revised" License (BSD-3-Clause)
> (http://treelayout.googlecode.com/files/LICENSE.TXT)
> From: 'an unknown organization'
> - Guava: Google Core Libraries for Java
> (http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:14.0.1
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> From: 'ANTLR' (http://www.antlr.org)
> - ANTLR 4 Runtime Annotations (http://www.antlr.org/antlr4-annotations)
> org.antlr:antlr4-annotations:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> - ANTLR 4 Runtime (http://www.antlr.org/antlr4-runtime)
> org.antlr:antlr4-runtime:jar:4.3
> License: The BSD License (http://www.antlr.org/license.html)
> From: 'The Apache Software Foundation' (http://www.apache.org/)
> - Apache Wink :: JSON4J (http://www.apache.org/wink/wink-json4j/)
> org.apache.wink:wink-json4j:jar:1.4
> License: The Apache Software License, Version 2.0
> (http://www.apache.org/licenses/LICENSE-2.0.txt)
> {code}
> The LICENSE and NOTICE files (in META-INF) included in the jar most likely
> need to be updated to reference these libraries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SYSTEMML-639) Can't use semicolon after user-defined function in DML
[
https://issues.apache.org/jira/browse/SYSTEMML-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deron Eriksson reassigned SYSTEMML-639:
---
Assignee: Deron Eriksson
> Can't use semicolon after user-defined function in DML
> --
>
> Key: SYSTEMML-639
> URL: https://issues.apache.org/jira/browse/SYSTEMML-639
> Project: SystemML
> Issue Type: Bug
> Components: APIs
>Reporter: Deron Eriksson
>Assignee: Deron Eriksson
>Priority: Minor
>
> This is valid:
> {code}
> x=1;print(x);
> printFoo=function(int y){print(y);}
> z=printFoo(x);
> {code}
> This is invalid:
> {code}
> x=1;print(x);
> printFoo=function(int y){print(y);};z=printFoo(x);
> {code}
> and generates:
> {code}
> The following parse issue was encountered:
> example.dml [line 2:35] [Syntax error] -> printFoo=function(int
> y){print(y);};z=printFoo(x);
>extraneous input ';' expecting {, 'while', 'for', 'if', 'source',
> 'setwd', 'parfor', '[', ID, COMMANDLINE_NAMED_ID, COMMANDLINE_POSITION_ID}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
