[jira] [Commented] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969149#comment-16969149 ] László Bodor commented on TEZ-3860: --- [~ashutoshc], [~jeagles]: I think I found and issue with this patch this patch is intended to replace the system classloader with a singleton TezClassLoader, however I left one more occurrence of getSystemClassLoader here: https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L1407 I think we need to use the singleton TezClassLoader here as well, otherwise, we cannot expect local resources to be found later > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-3860: -- Attachment: TEZ-3860.02.patch > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch, TEZ-3860.02.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-3860: -- Attachment: (was: TEZ-3860.02.patch) > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-3860: -- Attachment: TEZ-3860.02.patch > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-3860: -- Attachment: (was: TEZ-3860.02.patch) > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-3860: -- Attachment: TEZ-3860.02.patch > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch, TEZ-3860.02.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969149#comment-16969149 ] László Bodor edited comment on TEZ-3860 at 11/7/19 10:49 AM: - [~ashutoshc], [~jeagles]: I think I found and issue with this patch this patch is intended to replace the system classloader with a singleton TezClassLoader, however I left one more occurrence of getSystemClassLoader here: https://github.com/apache/tez/blob/e6722a96b4827d19850a5a73bc7024941a9deb54/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L1407 I think we need to use the singleton TezClassLoader here as well, otherwise, we cannot expect local resources to be found later uploaded [^TEZ-3860.02.patch] was (Author: abstractdog): [~ashutoshc], [~jeagles]: I think I found and issue with this patch this patch is intended to replace the system classloader with a singleton TezClassLoader, however I left one more occurrence of getSystemClassLoader here: https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L1407 I think we need to use the singleton TezClassLoader here as well, otherwise, we cannot expect local resources to be found later > JDK9: ReflectionUtils may not use URLClassLoader > > > Key: TEZ-3860 > URL: https://issues.apache.org/jira/browse/TEZ-3860 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Zoltan Haindrich >Assignee: László Bodor >Priority: Major > Attachments: TEZ-3860.01.patch, TEZ-3860.02.patch > > Time Spent: 20m > Remaining Estimate: 0h > > The following code > https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/common/ReflectionUtils.java#L125 > is not compatible with JDK9 since the classloader is an AppClassLoader > causes exceptions like this: > {code} > java.lang.ClassCastException: > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to > java.base/java.net.URLClassLoader > at > org.apache.tez.common.ReflectionUtils.addResourcesToSystemClassLoader(ReflectionUtils.java:125) > ~[tez-api-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.utils.RelocalizationUtils.addUrlsToClassPath(RelocalizationUtils.java:57) > ~[tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1793) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.dag.impl.DAGImpl$StartTransition.transition(DAGImpl.java:1776) > ~[tez-dag-0.9.0.jar:0.9.0] > at > org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448) > ~[hadoop-yarn-common-2.8.1.jar:?] > at > org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59) > ~[tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:1156) > [tez-dag-0.9.0.jar:0.9.0] > at org.apache.tez.dag.app.dag.impl.DAGImpl.handle(DAGImpl.java:147) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2251) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.dag.app.DAGAppMaster$DagEventDispatcher.handle(DAGAppMaster.java:2242) > [tez-dag-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180) > [tez-common-0.9.0.jar:0.9.0] > at > org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115) > [tez-common-0.9.0.jar:0.9.0] > at java.base/java.lang.Thread.run(Thread.java:844) [?:?] > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-3860) JDK9: ReflectionUtils may not use URLClassLoader
[ https://issues.apache.org/jira/browse/TEZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969174#comment-16969174 ] TezQA commented on TEZ-3860: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 22s{color} | {color:orange} tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 55s{color} | {color:red} tez-api generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 49s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 50s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 4s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:tez-api | | | org.apache.tez.common.TezClassLoader.() creates a org.apache.tez.common.TezClassLoader classloader, which should be performed within a doPrivileged block At TezClassLoader.java:a org.apache.tez.common.TezClassLoader classloader, which should be performed within a doPrivileged block At TezClassLoader.java:[line 26] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.4 Server=19.03.4 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-3860 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12985194/TEZ-3860.02.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 2bd748e3edaf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b99c7ce | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/193/artifact/out/diff-checkstyle-tez-api.txt | | findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/193/artifact/out/new-findbugs-tez-api.html | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/193/testReport/ | | Max. process+thread count | 230 (vs. ulimit of 5500) | |
[jira] [Commented] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969381#comment-16969381 ] TezQA commented on TEZ-4067: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 31s{color} | {color:orange} tez-dag: The patch generated 8 new + 142 unchanged - 1 fixed = 150 total (was 143) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 3s{color} | {color:red} tez-dag generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 48s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 24s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:tez-dag | | | org.apache.tez.dag.app.dag.speculation.legacy.LegacySpeculator.isStarted() does not release lock on all exception paths At LegacySpeculator.java:on all exception paths At LegacySpeculator.java:[line 182] | | | org.apache.tez.dag.app.dag.speculation.legacy.LegacySpeculator.serviceStop() does not release lock on all exception paths At LegacySpeculator.java:on all exception paths At LegacySpeculator.java:[line 229] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.4 Server=19.03.4 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4067 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12970227/TEZ-4067.002.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux c4b218af8abb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b99c7ce | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/194/artifact/out/diff-checkstyle-tez-dag.txt | | findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/194/artifact/out/new-findbugs-tez-dag.html | | Test Results | https://builds.a
[jira] [Updated] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-4067: --- Attachment: TEZ-4067.003.patch > Tez Speculation decision is calculated on each update by the dispatcher > --- > > Key: TEZ-4067 > URL: https://issues.apache.org/jira/browse/TEZ-4067 > Project: Apache Tez > Issue Type: Improvement >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Minor > Attachments: TEZ-4067.001.patch, TEZ-4067.002.patch, > TEZ-4067.003.patch > > > LegacySpeculator is an object field in VertexImpl. Therefore, all events are > handled synchronously by the caller (dispatcher). This implies the following: > # the dispatcher spends long time executing updateStatus as it needs to > check the runtime estimation of the tezAttempts within the vertex. > # the speculator is per stage: lunching a speculation may not the optimum > decision. Ideally, based on resources, speculated tasks should be the ones > with slowest progress. > # the time between speculation is skewed because there is a big delay for > the dispatcher to complete a full cycle. Also, speculation will be more > aggressive compared to MR because MR waits for > "soonest.retry.after.speculate" whenever a task is speculated. On the other > hand, Tez speculates more tasks as it processes stages in parallel. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969556#comment-16969556 ] Ahmed Hussein commented on TEZ-4067: Uploaded a new patch to fix error reported in checkstyle and windbags. > Tez Speculation decision is calculated on each update by the dispatcher > --- > > Key: TEZ-4067 > URL: https://issues.apache.org/jira/browse/TEZ-4067 > Project: Apache Tez > Issue Type: Improvement >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Minor > Attachments: TEZ-4067.001.patch, TEZ-4067.002.patch, > TEZ-4067.003.patch > > > LegacySpeculator is an object field in VertexImpl. Therefore, all events are > handled synchronously by the caller (dispatcher). This implies the following: > # the dispatcher spends long time executing updateStatus as it needs to > check the runtime estimation of the tezAttempts within the vertex. > # the speculator is per stage: lunching a speculation may not the optimum > decision. Ideally, based on resources, speculated tasks should be the ones > with slowest progress. > # the time between speculation is skewed because there is a big delay for > the dispatcher to complete a full cycle. Also, speculation will be more > aggressive compared to MR because MR waits for > "soonest.retry.after.speculate" whenever a task is speculated. On the other > hand, Tez speculates more tasks as it processes stages in parallel. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969556#comment-16969556 ] Ahmed Hussein edited comment on TEZ-4067 at 11/7/19 9:07 PM: - Uploaded a new patch to fix error reported in checkstyle and findbugs. was (Author: ahussein): Uploaded a new patch to fix error reported in checkstyle and windbags. > Tez Speculation decision is calculated on each update by the dispatcher > --- > > Key: TEZ-4067 > URL: https://issues.apache.org/jira/browse/TEZ-4067 > Project: Apache Tez > Issue Type: Improvement >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Minor > Attachments: TEZ-4067.001.patch, TEZ-4067.002.patch, > TEZ-4067.003.patch > > > LegacySpeculator is an object field in VertexImpl. Therefore, all events are > handled synchronously by the caller (dispatcher). This implies the following: > # the dispatcher spends long time executing updateStatus as it needs to > check the runtime estimation of the tezAttempts within the vertex. > # the speculator is per stage: lunching a speculation may not the optimum > decision. Ideally, based on resources, speculated tasks should be the ones > with slowest progress. > # the time between speculation is skewed because there is a big delay for > the dispatcher to complete a full cycle. Also, speculation will be more > aggressive compared to MR because MR waits for > "soonest.retry.after.speculate" whenever a task is speculated. On the other > hand, Tez speculates more tasks as it processes stages in parallel. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969574#comment-16969574 ] TezQA commented on TEZ-4067: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 51s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} The patch passed checkstyle in tez-api {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} tez-dag: The patch generated 0 new + 142 unchanged - 1 fixed = 142 total (was 143) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 54s{color} | {color:green} tez-api in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 49s{color} | {color:red} tez-dag in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 35s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 5s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | tez.dag.app.TestSpeculation | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.4 Server=19.03.4 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4067 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12985272/TEZ-4067.003.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 97af557c6346 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b99c7ce | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | unit | https://builds.apache.org/job/PreCommit-TEZ-Build/195/artifact/out/patch-unit-tez-dag.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/195/testReport/ | | Max. process+thread count | 230 (vs. ulimit of 5500) | | modules | C: tez-api tez-dag U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/195/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Tez Speculation decision is calculated on each update by the dispatcher > --
[jira] [Updated] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-4067: --- Attachment: TEZ-4067.004.patch > Tez Speculation decision is calculated on each update by the dispatcher > --- > > Key: TEZ-4067 > URL: https://issues.apache.org/jira/browse/TEZ-4067 > Project: Apache Tez > Issue Type: Improvement >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Minor > Attachments: TEZ-4067.001.patch, TEZ-4067.002.patch, > TEZ-4067.003.patch, TEZ-4067.004.patch > > > LegacySpeculator is an object field in VertexImpl. Therefore, all events are > handled synchronously by the caller (dispatcher). This implies the following: > # the dispatcher spends long time executing updateStatus as it needs to > check the runtime estimation of the tezAttempts within the vertex. > # the speculator is per stage: lunching a speculation may not the optimum > decision. Ideally, based on resources, speculated tasks should be the ones > with slowest progress. > # the time between speculation is skewed because there is a big delay for > the dispatcher to complete a full cycle. Also, speculation will be more > aggressive compared to MR because MR waits for > "soonest.retry.after.speculate" whenever a task is speculated. On the other > hand, Tez speculates more tasks as it processes stages in parallel. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4067) Tez Speculation decision is calculated on each update by the dispatcher
[ https://issues.apache.org/jira/browse/TEZ-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969622#comment-16969622 ] TezQA commented on TEZ-4067: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} The patch passed checkstyle in tez-api {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} tez-dag: The patch generated 0 new + 142 unchanged - 1 fixed = 142 total (was 143) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 51s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 51s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 39s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 34s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.4 Server=19.03.4 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4067 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12985279/TEZ-4067.004.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 92b8321e0241 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b99c7ce | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/196/testReport/ | | Max. process+thread count | 241 (vs. ulimit of 5500) | | modules | C: tez-api tez-dag U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/196/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Tez Speculation decision is calculated on each update by the dispatcher > --- > > Key: TEZ-4067 > URL: https://issues.apache.org/jira/browse/TEZ-4067 >
[jira] [Commented] (TEZ-4096) SSLFactory should make an attempt to add ssl config resources as "Path"
[ https://issues.apache.org/jira/browse/TEZ-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969884#comment-16969884 ] Gopal Vijayaraghavan commented on TEZ-4096: --- LGTM - +1 on the new change. Also {code} -keystoresFactory = ReflectionUtils.newInstance(klass, sslConf); - +keystoresFactory = ReflectionUtils.newInstance(klass, conf); {code} looks to be an actual fix for an unreported bug (i.e local configs not matching wire configs from AM). > SSLFactory should make an attempt to add ssl config resources as "Path" > --- > > Key: TEZ-4096 > URL: https://issues.apache.org/jira/browse/TEZ-4096 > Project: Apache Tez > Issue Type: Improvement >Reporter: Rajesh Balamohan >Priority: Major > Attachments: TEZ-4096.1.patch, TEZ-4096.2.patch, TEZ-4096.3.patch > > > SSLFactory uses "String" instead of "Path" for adding "ssl-client.xml". When > addResource is invoked with string, {{Configuration}} tries to find it in > classloader and does not load the file correctly. > [https://github.com/apache/tez/blob/master/tez-runtime-library/src/main/java/org/apache/tez/http/SSLFactory.java#L107] > Conf: > [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L3064] > This creates issue when ssl-client.xml is located in different path other > than the classpath. -- This message was sent by Atlassian Jira (v8.3.4#803005)