[jira] [Comment Edited] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[
https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021623#comment-17021623
]
László Bodor edited comment on TEZ-4101 at 1/22/20 11:46 PM:
-
actually, there are very many occurrences of checkState/checkArgument, you just
cannot see them in this patch as I haven't changed the classname
Preconditions...so I'll go with encapsulating
{code}
grep -iRH "Preconditions.checkState" --include "*.java" | wc -l
207
grep -iRH "Preconditions.checkArgument" --include "*.java" | wc -l
286
{code}
2 separate files are because tez-common depends on tez-api, so I haven't had
the chance two put this only into tez-common...maybe I would go with this
duplicate now and create a separate issue for creating a real common module,
which would not depend on others
was (Author: abstractdog):
actually, there are very many occurrences of checkState/checkArgument, you just
cannot see them in this patch as I haven't changed the classname
Preconditions...so I'll go this encapsulating
{code}
grep -iRH "Preconditions.checkState" --include "*.java" | wc -l
207
grep -iRH "Preconditions.checkArgument" --include "*.java" | wc -l
286
{code}
2 separate files are because tez-common depends on tez-api, so I haven't had
the chance two put this only into tez-common...maybe I would go with this
duplicate now and create a separate issue for creating a real common module,
which would not depend on others
> Eliminate some guava dependencies by Java8+ features - Preconditions
>
>
> Key: TEZ-4101
> URL: https://issues.apache.org/jira/browse/TEZ-4101
> Project: Apache Tez
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch
>
>
> 1. Preconditions.checkNotNull -> Objects.requireNonNull
> 2. wrap others into a tez common class
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[
https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021623#comment-17021623
]
László Bodor commented on TEZ-4101:
---
actually, there are very many occurrences of checkState/checkArgument, you just
cannot see them in this patch as I haven't changed the classname
Preconditions...so I'll go this encapsulating
{code}
grep -iRH "Preconditions.checkState" --include "*.java" | wc -l
207
grep -iRH "Preconditions.checkArgument" --include "*.java" | wc -l
286
{code}
2 separate files are because tez-common depends on tez-api, so I haven't had
the chance two put this only into tez-common...maybe I would go with this
duplicate now and create a separate issue for creating a real common module,
which would not depend on others
> Eliminate some guava dependencies by Java8+ features - Preconditions
>
>
> Key: TEZ-4101
> URL: https://issues.apache.org/jira/browse/TEZ-4101
> Project: Apache Tez
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch
>
>
> 1. Preconditions.checkNotNull -> Objects.requireNonNull
> 2. wrap others into a tez common class
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
[
https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor resolved TEZ-4116.
---
Resolution: Invalid
seems like failures in TEZ-4101 are related to that patch, this is invalid
> TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
> ---
>
> Key: TEZ-4116
> URL: https://issues.apache.org/jira/browse/TEZ-4116
> Project: Apache Tez
> Issue Type: Bug
>Reporter: László Bodor
>Priority: Major
> Attachments: patch-unit-tez-dag.txt
>
>
> {code}
> Error Message
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> Stacktrace
> org.mockito.exceptions.verification.WantedButNotInvoked:
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> Standard Output
> 2020-01-15 10:34:33,326 INFO [main] shim.HadoopShimsLoader
> (HadoopShimsLoader.java:(80)) - Trying to locate HadoopShimProvider for
> hadoopVersion=3.0.3, majorVersion=3, minorVersion=0
> 2020-01-15 10:34:33,327 INFO [main] shim.HadoopShimsLoader
> (HadoopShimsLoader.java:(139)) - Picked HadoopShim
> org.apache.tez.hadoop.shim.DefaultHadoopShim, providerName=null,
> overrideProviderViaConfig=null, hadoopVersion=3.0.3, majorVersion=3,
> minorVersion=0
> 2020-01-15 10:34:33,452 ERROR [TaskSchedulerEventHandlerThread]
> rm.TaskSchedulerManager (TaskSchedulerManager.java:run(686)) - Error in
> handling event type S_TA_LAUNCH_REQUEST to the TaskScheduler
> java.lang.NullPointerException
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager.handleTaLaunchRequest(TaskSchedulerManager.java:495)
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager.handleEvent(TaskSchedulerManager.java:273)
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager$1.run(TaskSchedulerManager.java:684)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (TEZ-3391) Optimize single split MR split reader
[
https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Hussein updated TEZ-3391:
---
Description:
During initialization, each task creates an array of objects
\{{TaskSplitMetaInfo[]}}. This represents unnecessary space and time overhead
as each task needs only its corresponding split object. Beside the current
implementation is \{{n^2}} space complexity, it leaks the inputstream.
We need to optimize that implementation by returning only a single object
instead of an entire array.
[~rohini] suggested the following:
{quote}
In the vertex construct TaskSplitMetaInfo only for the split of that task
instead of constructing for all splits. ie change
public static TaskSplitMetaInfo[] readSplitMetaInfo(Configuration conf,
FileSystem fs) to public static TaskSplitMetaInfo
getSplitMetaInfo(Configuration conf, FileSystem fs, int index) and skip reading
splits below the index. If there are 1000 splits, the first task will read 1
split, second task will read 2 splits and so on instead of each task reading
all the 1000 splits as is happening now.
{quote}
was:
We had a case where Split metadata size exceeded 1000. Instead of job
failing from validation during initialization in AM like mapreduce, each of the
tasks failed doing that validation during initialization.
Summary: Optimize single split MR split reader (was: MR split file
validation should be done in the AM)
> Optimize single split MR split reader
> -
>
> Key: TEZ-3391
> URL: https://issues.apache.org/jira/browse/TEZ-3391
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch
>
>
> During initialization, each task creates an array of objects
> \{{TaskSplitMetaInfo[]}}. This represents unnecessary space and time overhead
> as each task needs only its corresponding split object. Beside the current
> implementation is \{{n^2}} space complexity, it leaks the inputstream.
> We need to optimize that implementation by returning only a single object
> instead of an entire array.
> [~rohini] suggested the following:
> {quote}
> In the vertex construct TaskSplitMetaInfo only for the split of that task
> instead of constructing for all splits. ie change
> public static TaskSplitMetaInfo[] readSplitMetaInfo(Configuration conf,
> FileSystem fs) to public static TaskSplitMetaInfo
> getSplitMetaInfo(Configuration conf, FileSystem fs, int index) and skip
> reading splits below the index. If there are 1000 splits, the first task will
> read 1 split, second task will read 2 splits and so on instead of each task
> reading all the 1000 splits as is happening now.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021581#comment-17021581 ] Jonathan Turner Eagles commented on TEZ-4101: - [~abstractdog], there are so few checkState (throw IllegalStateException) and checkArgument (IllegalArgumentException), so they could be done manually with a if/throw block. If you want to create a class to encapsulate, that is fine also. In that case, try to avoid creating two separate files that contain the same logic. > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021570#comment-17021570 ] Jonathan Turner Eagles commented on TEZ-3391: - Actually, [~ahussein], can you update the summary to better reflect this? That way the commit message will have the correct summary as well and puts you in control of what the summary says. I'll commit once summary is updated. > MR split file validation should be done in the AM > - > > Key: TEZ-3391 > URL: https://issues.apache.org/jira/browse/TEZ-3391 > Project: Apache Tez > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Ahmed Hussein >Priority: Major > Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch > > > We had a case where Split metadata size exceeded 1000. Instead of job > failing from validation during initialization in AM like mapreduce, each of > the tasks failed doing that validation during initialization. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021569#comment-17021569 ] László Bodor commented on TEZ-4101: --- unfortunately, Objects or other Java built-in classes don't have the corresponding methods for checkArgument/checkState, so I will have to implement them again in tez common Preconditions (right?) https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Preconditions.java however, these are quite simple methods, so this implementation will be very similar to Guava's, hope it's not an issue... > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021553#comment-17021553 ] Jonathan Turner Eagles commented on TEZ-4101: - I think I prefer the Objects implementation. It gets tricky to copy code with a difference license. Instead you can copy the API and have to come up with a new implementation. It's pretty messy. > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
[
https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4116:
--
Attachment: patch-unit-tez-dag.txt
> TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
> ---
>
> Key: TEZ-4116
> URL: https://issues.apache.org/jira/browse/TEZ-4116
> Project: Apache Tez
> Issue Type: Bug
>Reporter: László Bodor
>Priority: Major
> Attachments: patch-unit-tez-dag.txt
>
>
> {code}
> Error Message
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> Stacktrace
> org.mockito.exceptions.verification.WantedButNotInvoked:
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> Standard Output
> 2020-01-15 10:34:33,326 INFO [main] shim.HadoopShimsLoader
> (HadoopShimsLoader.java:(80)) - Trying to locate HadoopShimProvider for
> hadoopVersion=3.0.3, majorVersion=3, minorVersion=0
> 2020-01-15 10:34:33,327 INFO [main] shim.HadoopShimsLoader
> (HadoopShimsLoader.java:(139)) - Picked HadoopShim
> org.apache.tez.hadoop.shim.DefaultHadoopShim, providerName=null,
> overrideProviderViaConfig=null, hadoopVersion=3.0.3, majorVersion=3,
> minorVersion=0
> 2020-01-15 10:34:33,452 ERROR [TaskSchedulerEventHandlerThread]
> rm.TaskSchedulerManager (TaskSchedulerManager.java:run(686)) - Error in
> handling event type S_TA_LAUNCH_REQUEST to the TaskScheduler
> java.lang.NullPointerException
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager.handleTaLaunchRequest(TaskSchedulerManager.java:495)
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager.handleEvent(TaskSchedulerManager.java:273)
> at
> org.apache.tez.dag.app.rm.TaskSchedulerManager$1.run(TaskSchedulerManager.java:684)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
[
https://issues.apache.org/jira/browse/TEZ-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4116:
--
Description:
{code}
Error Message
Wanted but not invoked:
taskScheduler.allocateTask(
Mock for TaskAttemptImpl, hashCode: 1958148268,
,
Mock for ContainerId, hashCode: 162527046,
3,
null,
EventType: S_TA_LAUNCH_REQUEST
);
-> at
org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
However, there were other interactions with this mock:
taskScheduler.initialize();
-> at
org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
taskScheduler.start();
-> at
org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
Stacktrace
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
taskScheduler.allocateTask(
Mock for TaskAttemptImpl, hashCode: 1958148268,
,
Mock for ContainerId, hashCode: 162527046,
3,
null,
EventType: S_TA_LAUNCH_REQUEST
);
-> at
org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
However, there were other interactions with this mock:
taskScheduler.initialize();
-> at
org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
taskScheduler.start();
-> at
org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
at
org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
Standard Output
2020-01-15 10:34:33,326 INFO [main] shim.HadoopShimsLoader
(HadoopShimsLoader.java:(80)) - Trying to locate HadoopShimProvider for
hadoopVersion=3.0.3, majorVersion=3, minorVersion=0
2020-01-15 10:34:33,327 INFO [main] shim.HadoopShimsLoader
(HadoopShimsLoader.java:(139)) - Picked HadoopShim
org.apache.tez.hadoop.shim.DefaultHadoopShim, providerName=null,
overrideProviderViaConfig=null, hadoopVersion=3.0.3, majorVersion=3,
minorVersion=0
2020-01-15 10:34:33,452 ERROR [TaskSchedulerEventHandlerThread]
rm.TaskSchedulerManager (TaskSchedulerManager.java:run(686)) - Error in
handling event type S_TA_LAUNCH_REQUEST to the TaskScheduler
java.lang.NullPointerException
at
org.apache.tez.dag.app.rm.TaskSchedulerManager.handleTaLaunchRequest(TaskSchedulerManager.java:495)
at
org.apache.tez.dag.app.rm.TaskSchedulerManager.handleEvent(TaskSchedulerManager.java:273)
at
org.apache.tez.dag.app.rm.TaskSchedulerManager$1.run(TaskSchedulerManager.java:684)
{code}
> TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
> ---
>
> Key: TEZ-4116
> URL: https://issues.apache.org/jira/browse/TEZ-4116
> Project: Apache Tez
> Issue Type: Bug
>Reporter: László Bodor
>Priority: Major
>
> {code}
> Error Message
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> Stacktrace
> org.mockito.exceptions.verification.WantedButNotInvoked:
> Wanted but not invoked:
> taskScheduler.allocateTask(
> Mock for TaskAttemptImpl, hashCode: 1958148268,
> ,
> Mock for ContainerId, hashCode: 162527046,
> 3,
> null,
> EventType: S_TA_LAUNCH_REQUEST
> );
> -> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> However, there were other interactions with this mock:
> taskScheduler.initialize();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceInit(ServicePluginLifecycleAbstractService.java:36)
> taskScheduler.start();
> -> at
> org.apache.tez.dag.app.ServicePluginLifecycleAbstractService.serviceStart(ServicePluginLifecycleAbstractService.java:41)
> at
> org.apache.tez.dag.app.rm.TestTaskSchedulerManager.testTaskBasedAffinity(TestTaskSchedulerManager.java:327)
> Standard Output
> 2020-01-15 10:34:33,326 INFO [main] shim.HadoopShimsLoader
> (HadoopShimsLoader.java:(80)) - Trying to
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021533#comment-17021533 ] László Bodor commented on TEZ-4101: --- I thinks TestTaskSchedulerManager.testTaskBasedAffinity is not related, created TEZ-4116 about that > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TEZ-4116) TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly
László Bodor created TEZ-4116: - Summary: TestTaskSchedulerManager.testTaskBasedAffinity fails in preCommit regularly Key: TEZ-4116 URL: https://issues.apache.org/jira/browse/TEZ-4116 Project: Apache Tez Issue Type: Bug Reporter: László Bodor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021533#comment-17021533 ] László Bodor edited comment on TEZ-4101 at 1/22/20 9:37 PM: I think TestTaskSchedulerManager.testTaskBasedAffinity is not related, created TEZ-4116 about that was (Author: abstractdog): I thinks TestTaskSchedulerManager.testTaskBasedAffinity is not related, created TEZ-4116 about that > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021379#comment-17021379 ] Jonathan Turner Eagles commented on TEZ-3391: - +1. Let's put this in. I spent some time verifying this doesn't break pig or hive. I'm going to change the summary to better reflect the new purpose of this jira. > MR split file validation should be done in the AM > - > > Key: TEZ-3391 > URL: https://issues.apache.org/jira/browse/TEZ-3391 > Project: Apache Tez > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Ahmed Hussein >Priority: Major > Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch > > > We had a case where Split metadata size exceeded 1000. Instead of job > failing from validation during initialization in AM like mapreduce, each of > the tasks failed doing that validation during initialization. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[
https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021220#comment-17021220
]
TezQA commented on TEZ-4101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
34s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} tez-api: The patch generated 2 new + 316
unchanged - 0 fixed = 318 total (was 316) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} tez-common: The patch generated 2 new + 37
unchanged - 0 fixed = 39 total (was 37) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
41s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} tez-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
38s{color} | {color:green} tez-runtime-internals in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
14s{color} | {color:green} tez-runtime-library in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
2s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} tez-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 46s{color}
| {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 19s{color}
| {color:red} tez-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
38s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
4s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit
[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM
[
https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021148#comment-17021148
]
TezQA commented on TEZ-3391:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
18s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
12s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/251/artifact/out/Dockerfile |
| JIRA Issue | TEZ-3391 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12991529/TEZ-3391.002.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux 5681a9c7b74a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 5b81017 |
| Default Java | 1.8.0_232 |
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/251/testReport/ |
| Max. process+thread count | 208 (vs. ulimit of 5500) |
| modules | C: tez-mapreduce U: tez-mapreduce |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/251/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> MR split file validation should be done in the AM
> -
>
> Key: TEZ-3391
> URL: https://issues.apache.org/jira/browse/TEZ-3391
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch
>
>
> We had a
[jira] [Comment Edited] (TEZ-3391) MR split file validation should be done in the AM
[
https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021119#comment-17021119
]
Ahmed Hussein edited comment on TEZ-3391 at 1/22/20 2:38 PM:
-
I agree with [~rohini] that the implementation is not efficient.
The ideal fix is to read the object array {{TaskSplitMetaInfo[]}} only once and
do all the validation in the AM, then pass the {{TaskSplitMetaInfo[index]}} to
the task initializer. This may imply significant code changes.
The existing code also has significant space overhead. Because each task
creates an array of meta split. This means the code is {{n^2}} space
complexity. The patch will reduce the space complexity but it each task needs
to go through the entire meta file.
Finally, the code was not closing the InputStream properly. An exception would
leak the handler.
[~jeagles], Can you please take a look at the patch and merge it at your
convenience?
was (Author: ahussein):
I agree with [~rohini] that the implementation is not efficient.
The ideal fix is to read the object array {{TaskSplitMetaInfo[]}} only once and
do all the validation in the AM, then pass the {{TaskSplitMetaInfo[index]}} to
the task initializer. This may imply significant code changes.
The existing code also has significant space overhead. Because each task
creates an array of meta split. This means the code is {{n^2}} space
complexity. The patch will reduce the space complexity but it each task needs
to go through the entire meta file.
[~jeagles], Can you please take a look at the patch and merge it at your
convenience?
> MR split file validation should be done in the AM
> -
>
> Key: TEZ-3391
> URL: https://issues.apache.org/jira/browse/TEZ-3391
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch
>
>
> We had a case where Split metadata size exceeded 1000. Instead of job
> failing from validation during initialization in AM like mapreduce, each of
> the tasks failed doing that validation during initialization.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM
[
https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021119#comment-17021119
]
Ahmed Hussein commented on TEZ-3391:
I agree with [~rohini] that the implementation is not efficient.
The ideal fix is to read the object array {{TaskSplitMetaInfo[]}} only once and
do all the validation in the AM, then pass the {{TaskSplitMetaInfo[index]}} to
the task initializer. This may imply significant code changes.
The existing code also has significant space overhead. Because each task
creates an array of meta split. This means the code is {{n^2}} space
complexity. The patch will reduce the space complexity but it each task needs
to go through the entire meta file.
[~jeagles], Can you please take a look at the patch and merge it at your
convenience?
> MR split file validation should be done in the AM
> -
>
> Key: TEZ-3391
> URL: https://issues.apache.org/jira/browse/TEZ-3391
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch
>
>
> We had a case where Split metadata size exceeded 1000. Instead of job
> failing from validation during initialization in AM like mapreduce, each of
> the tasks failed doing that validation during initialization.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (TEZ-3391) MR split file validation should be done in the AM
[ https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated TEZ-3391: --- Attachment: TEZ-3391.002.patch > MR split file validation should be done in the AM > - > > Key: TEZ-3391 > URL: https://issues.apache.org/jira/browse/TEZ-3391 > Project: Apache Tez > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Ahmed Hussein >Priority: Major > Attachments: TEZ-3391.001.patch, TEZ-3391.002.patch > > > We had a case where Split metadata size exceeded 1000. Instead of job > failing from validation during initialization in AM like mapreduce, each of > the tasks failed doing that validation during initialization. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-3391) MR split file validation should be done in the AM
[
https://issues.apache.org/jira/browse/TEZ-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021100#comment-17021100
]
TezQA commented on TEZ-3391:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
0s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
11s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
8s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/250/artifact/out/Dockerfile |
| JIRA Issue | TEZ-3391 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12991477/TEZ-3391.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux 4a78af525a8f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 5b81017 |
| Default Java | 1.8.0_232 |
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/250/testReport/ |
| Max. process+thread count | 209 (vs. ulimit of 5500) |
| modules | C: tez-mapreduce U: tez-mapreduce |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/250/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> MR split file validation should be done in the AM
> -
>
> Key: TEZ-3391
> URL: https://issues.apache.org/jira/browse/TEZ-3391
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Rohini Palaniswamy
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: TEZ-3391.001.patch
>
>
> We had a case where Split
[jira] [Updated] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Bodor updated TEZ-4101: -- Attachment: TEZ-4101.03.patch > Eliminate some guava dependencies by Java8+ features - Preconditions > > > Key: TEZ-4101 > URL: https://issues.apache.org/jira/browse/TEZ-4101 > Project: Apache Tez > Issue Type: Improvement >Reporter: László Bodor >Assignee: László Bodor >Priority: Major > Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch, TEZ-4101.03.patch > > > 1. Preconditions.checkNotNull -> Objects.requireNonNull > 2. wrap others into a tez common class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions
[
https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020875#comment-17020875
]
TezQA commented on TEZ-4101:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} TEZ-4101 does not apply to master. Rebase required? Wrong Branch?
See https://cwiki.apache.org/confluence/display/TEZ/How+to+Contribute+to+Tez
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | TEZ-4101 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12991437/TEZ-4101.02.patch |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/248/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Eliminate some guava dependencies by Java8+ features - Preconditions
>
>
> Key: TEZ-4101
> URL: https://issues.apache.org/jira/browse/TEZ-4101
> Project: Apache Tez
> Issue Type: Improvement
>Reporter: László Bodor
>Assignee: László Bodor
>Priority: Major
> Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch
>
>
> 1. Preconditions.checkNotNull -> Objects.requireNonNull
> 2. wrap others into a tez common class
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
