[jira] [Commented] (TEZ-4127) TestMergeManager#testOnDiskMergerFilenames fails with dot directory name

2020-02-26 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046208#comment-17046208
 ] 

László Bodor commented on TEZ-4127:
---

reproduced locally, patch seems to solve it
+1


> TestMergeManager#testOnDiskMergerFilenames fails with dot directory name
> 
>
> Key: TEZ-4127
> URL: https://issues.apache.org/jira/browse/TEZ-4127
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4127.001.patch
>
>
> Setup. # run test from directory with a dot in the name
>  - git clone into /home/$USER/tez.dot
>  - run test mvn clean test -Dtest=TestMergeManager -pl ./tez-runtime-library/ 
> -am
>  - test will fail with Values should be different. Actual: /home/$USER/tez
> {noformat}
> [INFO] Running 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.448 
> s <<< FAILURE! - in 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] 
> testOnDiskMergerFilenames(org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager)
>   Time elapsed: 0.086 s  <<< FAILURE!
> java.lang.AssertionError: Values should be different. Actual: /home/$USER/tez
>   at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testOnDiskMergerFilenames(TestMergeManager.java:765)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (TEZ-4119) TestSpeculation is flaky

2020-02-26 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046200#comment-17046200
 ] 

László Bodor edited comment on TEZ-4119 at 2/27/20 6:21 AM:


yes [~ahussein], I've seen it in recent precommit tests
my experience was that if I run only TestSpeculation, it passes quickly, but if 
I run mvn clean test for whole tez-dag submodule, it will more likely fail, 
hope this helps to reproduce
e.g. 2 days ago: 
https://issues.apache.org/jira/browse/TEZ-4039?focusedCommentId=17043556&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17043556
maven logs are: 
https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/patch-unit-tez-dag.txt


was (Author: abstractdog):
yes [~ahussein], I've seen it in recent precommit tests
my experience was that if I run only TestSpeculation, it passes quickly, but if 
I run mvn clean test for whole tez-dag submodule, it will more likely fail, 
hope this helps to reproduce
e.g. 2 days ago: 
https://issues.apache.org/jira/browse/TEZ-4039?focusedCommentId=17043556&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17043556

> TestSpeculation is flaky
> 
>
> Key: TEZ-4119
> URL: https://issues.apache.org/jira/browse/TEZ-4119
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: jstack.log, jstack4.log, jstack6.log, 
> org.apache.tez.dag.app.TestSpeculation-output.txt
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4119) TestSpeculation is flaky

2020-02-26 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046200#comment-17046200
 ] 

László Bodor commented on TEZ-4119:
---

yes [~ahussein], I've seen it in recent precommit tests
my experience was that if I run only TestSpeculation, it passes quickly, but if 
I run mvn clean test for whole tez-dag submodule, it will more likely fail, 
hope this helps to reproduce
e.g. 2 days ago: 
https://issues.apache.org/jira/browse/TEZ-4039?focusedCommentId=17043556&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17043556

> TestSpeculation is flaky
> 
>
> Key: TEZ-4119
> URL: https://issues.apache.org/jira/browse/TEZ-4119
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: jstack.log, jstack4.log, jstack6.log, 
> org.apache.tez.dag.app.TestSpeculation-output.txt
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4127) TestMergeManager#testOnDiskMergerFilenames fails with dot directory name

2020-02-26 Thread Jira 


[ 
https://issues.apache.org/jira/browse/TEZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045627#comment-17045627
 ] 

László Bodor commented on TEZ-4127:
---

i'll take a look today

> TestMergeManager#testOnDiskMergerFilenames fails with dot directory name
> 
>
> Key: TEZ-4127
> URL: https://issues.apache.org/jira/browse/TEZ-4127
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4127.001.patch
>
>
> Setup. # run test from directory with a dot in the name
>  - git clone into /home/$USER/tez.dot
>  - run test mvn clean test -Dtest=TestMergeManager -pl ./tez-runtime-library/ 
> -am
>  - test will fail with Values should be different. Actual: /home/$USER/tez
> {noformat}
> [INFO] Running 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.448 
> s <<< FAILURE! - in 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] 
> testOnDiskMergerFilenames(org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager)
>   Time elapsed: 0.086 s  <<< FAILURE!
> java.lang.AssertionError: Values should be different. Actual: /home/$USER/tez
>   at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testOnDiskMergerFilenames(TestMergeManager.java:765)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4119) TestSpeculation is flaky

2020-02-26 Thread Ahmed Hussein (Jira) 


[ 
https://issues.apache.org/jira/browse/TEZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045614#comment-17045614
 ] 

Ahmed Hussein commented on TEZ-4119:


Hey [~abstractdog], Do you still see this error? 

> TestSpeculation is flaky
> 
>
> Key: TEZ-4119
> URL: https://issues.apache.org/jira/browse/TEZ-4119
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: jstack.log, jstack4.log, jstack6.log, 
> org.apache.tez.dag.app.TestSpeculation-output.txt
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TEZ-4127) TestMergeManager#testOnDiskMergerFilenames fails with dot directory name

2020-02-26 Thread Jonathan Turner Eagles (Jira) 


[ 
https://issues.apache.org/jira/browse/TEZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045602#comment-17045602
 ] 

Jonathan Turner Eagles commented on TEZ-4127:
-

[~rajesh.balamohan] or [~abstractdog], could one of you review this trivial 
change?

> TestMergeManager#testOnDiskMergerFilenames fails with dot directory name
> 
>
> Key: TEZ-4127
> URL: https://issues.apache.org/jira/browse/TEZ-4127
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Jonathan Turner Eagles
>Assignee: Jonathan Turner Eagles
>Priority: Major
> Attachments: TEZ-4127.001.patch
>
>
> Setup. # run test from directory with a dot in the name
>  - git clone into /home/$USER/tez.dot
>  - run test mvn clean test -Dtest=TestMergeManager -pl ./tez-runtime-library/ 
> -am
>  - test will fail with Values should be different. Actual: /home/$USER/tez
> {noformat}
> [INFO] Running 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.448 
> s <<< FAILURE! - in 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager
> [ERROR] 
> testOnDiskMergerFilenames(org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager)
>   Time elapsed: 0.086 s  <<< FAILURE!
> java.lang.AssertionError: Values should be different. Actual: /home/$USER/tez
>   at 
> org.apache.tez.runtime.library.common.shuffle.orderedgrouped.TestMergeManager.testOnDiskMergerFilenames(TestMergeManager.java:765)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)