[jira] [Commented] (TEZ-4119) TestSpeculation is flaky

2020-03-02 Thread Ahmed Hussein (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049306#comment-17049306
 ] 

Ahmed Hussein commented on TEZ-4119:


Thanks [~abstractdog]. This was very helpful.

I had a look at the test case. The main problem with that test case is that it 
was designed without taking into consideration that the speculator can run as a 
background service.

> TestSpeculation is flaky
> 
>
> Key: TEZ-4119
> URL: https://issues.apache.org/jira/browse/TEZ-4119
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: jstack.log, jstack4.log, jstack6.log, 
> org.apache.tez.dag.app.TestSpeculation-output.txt
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (TEZ-4119) TestSpeculation is flaky

2020-03-02 Thread Ahmed Hussein (Jira)


[ 
https://issues.apache.org/jira/browse/TEZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049306#comment-17049306
 ] 

Ahmed Hussein edited comment on TEZ-4119 at 3/2/20 3:18 PM:


Thanks [~abstractdog]. This was very helpful.

I had a look at the test case. The main problem with that test case is that it 
was designed without taking into consideration that the speculator can run as a 
background service.
Once I changed the implementation to make the speculator run in parallel, the 
test case became fuzzy.
It will take me sometime to reimplement the JUnit test according to the new 
speculator design.


was (Author: ahussein):
Thanks [~abstractdog]. This was very helpful.

I had a look at the test case. The main problem with that test case is that it 
was designed without taking into consideration that the speculator can run as a 
background service.

> TestSpeculation is flaky
> 
>
> Key: TEZ-4119
> URL: https://issues.apache.org/jira/browse/TEZ-4119
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: László Bodor
>Assignee: Ahmed Hussein
>Priority: Major
> Attachments: jstack.log, jstack4.log, jstack6.log, 
> org.apache.tez.dag.app.TestSpeculation-output.txt
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)