Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
BilwaST commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2094554985 Thanks for your patch @slfan1989. Looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
slfan1989 commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2076405395 > @slfan1989 @abstractdog Can we update protobuf version to 3.24.4? Hive is also using the same version Thanks for your message, I will try to upgrade to 3.24.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
BilwaST commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2076402664 @slfan1989 @abstractdog Can we protobuf version to 3.24.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
abstractdog commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2054152360 > > > @slfan1989, for protobuf version upgrade, you need to update the generated code for the corresponding proto files as well. > > > > > > what kind of generated code upgrade do we expect here? does anything change if we run "mvn clean install -DskipTests"? > > My bad, as per my understanding, for .proto file, the generated code for that corresponding proto file, generally have some changes when we change protobuf version but here its not the case(I should have tested this before commenting 🙁) no worries, thanks for the comments and activity here! I believe we are good to proceed with this once it's moved from draft and we have a precommit test run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
Aggarwal-Raghav commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2054010958 > > @slfan1989, for protobuf version upgrade, you need to update the generated code for the corresponding proto files as well. > > what kind of generated code upgrade do we expect here? does anything change if we run "mvn clean install -DskipTests"? My bad, as per my understanding, for .proto file, the generated code for that corresponding proto file, generally have some changes when we change protobuf version but in this case its not the case(I should have tested this before commenting 🙁) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
abstractdog commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2053963980 > @slfan1989, for protobuf version upgrade, you need to update the generated code for the corresponding proto files as well. what kind of generated code upgrade do we expect here? does anything change if we run "mvn clean install -DskipTests"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
Aggarwal-Raghav commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2053542796 @slfan1989, for protobuf version upgrade, you need to update the generated code for the corresponding proto files as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TEZ-4552. Upgrade protobuf to 3.23.4. [tez]
tez-yetus commented on PR #345: URL: https://github.com/apache/tez/pull/345#issuecomment-2035882477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 12m 8s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 | | +1 :green_heart: | compile | 1m 13s | master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | | +1 :green_heart: | javadoc | 1m 2s | master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 | | +1 :green_heart: | javadoc | 0m 45s | master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 | | +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | ||| _ Other Tests _ | | -1 :x: | unit | 41m 1s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 77m 59s | | | Reason | Tests | |---:|:--| | Failed junit tests | tez.test.TestAMRecovery | | | tez.test.TestDAGRecovery | | | tez.test.TestRecovery | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-345/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/tez/pull/345 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux b86c62c507ed 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / f080031f5 | | Default Java | Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06 | | unit | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-345/1/artifact/out/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-345/1/testReport/ | | Max. process+thread count | 2100 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-345/1/console | | versions | git=2.34.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
