[jira] [Comment Edited] (TEZ-1961) Remove misleading exception "No running dag" from AM logs

2015-05-07 Thread Jeff Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533653#comment-14533653
 ] 

Jeff Zhang edited comment on TEZ-1961 at 5/8/15 12:48 AM:
--

I also rename DAGClientHandler#getSessionStatus to 
DAGClientHandler#getTezAppMasterStatus and make it support non-session mode in 
this patch to avoid misleading. If it is valid, I can do it in this patch, 
because the it is a very simple change. 

{noformat}
-  public synchronized TezAppMasterStatus getSessionStatus() throws 
TezException {
-if (!dagAppMaster.isSession()) {
-  throw new TezException("Unsupported operation as AM not running in"
-  + " session mode");
-}
+  public synchronized TezAppMasterStatus getTezAppMasterStatus() throws 
TezException {
 switch (dagAppMaster.getState()) {
 case NEW:
 case INITED:
{noformat}


was (Author: zjffdu):
I also rename DAGClientHandler#getSessionState to DAGClientHandler#getAMState 
and make it support non-session mode in this patch to avoid misleading. If it 
is valid, I can do it in this patch, because the it is a very simple change. 

{noformat}
-  public synchronized TezAppMasterStatus getSessionStatus() throws 
TezException {
-if (!dagAppMaster.isSession()) {
-  throw new TezException("Unsupported operation as AM not running in"
-  + " session mode");
-}
+  public synchronized TezAppMasterStatus getTezAppMasterStatus() throws 
TezException {
 switch (dagAppMaster.getState()) {
 case NEW:
 case INITED:
{noformat}

> Remove misleading exception "No running dag" from AM logs
> -
>
> Key: TEZ-1961
> URL: https://issues.apache.org/jira/browse/TEZ-1961
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Jeff Zhang
>Priority: Critical
> Attachments: TEZ-1961-1.patch, TEZ-1961-2.patch, TEZ-1961-3.patch
>
>
> {code}
> 15/01/14 16:45:06 INFO ipc.Server: IPC Server handler 0 on 51000, call 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPB.getDAGStatus 
> from  Call#0 Retry#0
> org.apache.tez.dag.api.TezException: No running dag at present
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getDAG(DAGClientHandler.java:84)
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getACLManager(DAGClientHandler.java:151)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPBServerImpl.getDAGStatus(DAGClientAMProtocolBlockingPBServerImpl.java:94)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolRPC$DAGClientAMProtocol$2.callBlockingMethod(DAGClientAMProtocolRPC.java:7375)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2041)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2037)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:415)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2035)
> 15/01/14 16:45:06 INFO client.DAGClientImpl: DAG initialized: 
> CurrentState=Running
> {code}
> This exception shows up fairly often and isn't very relevant - queries before 
> a DAG is submitted to the AM.
> This is very misleading, especially for folks new to Tez, and should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (TEZ-1961) Remove misleading exception "No running dag" from AM logs

2015-05-07 Thread Jeff Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533653#comment-14533653
 ] 

Jeff Zhang edited comment on TEZ-1961 at 5/8/15 12:47 AM:
--

I also rename DAGClientHandler#getSessionState to DAGClientHandler#getAMState 
and make it support non-session mode in this patch to avoid misleading. If it 
is valid, I can do it in this patch, because the it is a very simple change. 

{noformat}
-  public synchronized TezAppMasterStatus getSessionStatus() throws 
TezException {
-if (!dagAppMaster.isSession()) {
-  throw new TezException("Unsupported operation as AM not running in"
-  + " session mode");
-}
+  public synchronized TezAppMasterStatus getTezAppMasterStatus() throws 
TezException {
 switch (dagAppMaster.getState()) {
 case NEW:
 case INITED:
{noformat}


was (Author: zjffdu):
I also rename DAGClientHandler#getSessionState to DAGClientHandler#getAMState 
and make it support non-session mode in this patch to avoid misleading. If it 
is valid, I can do it in this patch, because the it is a very simple change. 

> Remove misleading exception "No running dag" from AM logs
> -
>
> Key: TEZ-1961
> URL: https://issues.apache.org/jira/browse/TEZ-1961
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Jeff Zhang
>Priority: Critical
> Attachments: TEZ-1961-1.patch, TEZ-1961-2.patch, TEZ-1961-3.patch
>
>
> {code}
> 15/01/14 16:45:06 INFO ipc.Server: IPC Server handler 0 on 51000, call 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPB.getDAGStatus 
> from  Call#0 Retry#0
> org.apache.tez.dag.api.TezException: No running dag at present
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getDAG(DAGClientHandler.java:84)
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getACLManager(DAGClientHandler.java:151)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPBServerImpl.getDAGStatus(DAGClientAMProtocolBlockingPBServerImpl.java:94)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolRPC$DAGClientAMProtocol$2.callBlockingMethod(DAGClientAMProtocolRPC.java:7375)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2041)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2037)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:415)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2035)
> 15/01/14 16:45:06 INFO client.DAGClientImpl: DAG initialized: 
> CurrentState=Running
> {code}
> This exception shows up fairly often and isn't very relevant - queries before 
> a DAG is submitted to the AM.
> This is very misleading, especially for folks new to Tez, and should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (TEZ-1961) Remove misleading exception "No running dag" from AM logs

2015-05-07 Thread Jeff Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533653#comment-14533653
 ] 

Jeff Zhang edited comment on TEZ-1961 at 5/8/15 12:17 AM:
--

I also rename DAGClientHandler#getSessionState to DAGClientHandler#getAMState 
and make it support non-session mode in this patch to avoid misleading. If it 
is valid, I can do it in this patch, because the it is a very simple change. 


was (Author: zjffdu):
I also rename DAGClientHandler#getSessionState to DAGClientHandler#getAMState 
in this patch to avoid misleading. If it is valid, I can do it in this patch, 
because the it is a very simple change. 

> Remove misleading exception "No running dag" from AM logs
> -
>
> Key: TEZ-1961
> URL: https://issues.apache.org/jira/browse/TEZ-1961
> Project: Apache Tez
>  Issue Type: Improvement
>Reporter: Siddharth Seth
>Assignee: Jeff Zhang
>Priority: Critical
> Attachments: TEZ-1961-1.patch, TEZ-1961-2.patch, TEZ-1961-3.patch
>
>
> {code}
> 15/01/14 16:45:06 INFO ipc.Server: IPC Server handler 0 on 51000, call 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPB.getDAGStatus 
> from  Call#0 Retry#0
> org.apache.tez.dag.api.TezException: No running dag at present
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getDAG(DAGClientHandler.java:84)
>   at 
> org.apache.tez.dag.api.client.DAGClientHandler.getACLManager(DAGClientHandler.java:151)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPBServerImpl.getDAGStatus(DAGClientAMProtocolBlockingPBServerImpl.java:94)
>   at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolRPC$DAGClientAMProtocol$2.callBlockingMethod(DAGClientAMProtocolRPC.java:7375)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2041)
>   at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2037)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at javax.security.auth.Subject.doAs(Subject.java:415)
>   at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
>   at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2035)
> 15/01/14 16:45:06 INFO client.DAGClientImpl: DAG initialized: 
> CurrentState=Running
> {code}
> This exception shows up fairly often and isn't very relevant - queries before 
> a DAG is submitted to the AM.
> This is very misleading, especially for folks new to Tez, and should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)