[jira] [Comment Edited] (TEZ-3775) Tez UI: Show DAG context in document title

2017-06-28 Thread Sreenath Somarajapuram (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066533#comment-16066533
 ] 

Sreenath Somarajapuram edited comment on TEZ-3775 at 6/28/17 2:12 PM:
--

I feel Ember way to do that would be to convert title into a computed property. 
In-fact code in tez-ui/src/main/webapp/app/routes/abstract.js is designed for 
that.

For example. Title in tez-ui/src/main/webapp/app/routes/vertex/tasks.js could 
be changed as follows.
{code}
  title: Ember.computed(function () {
var vertex = this.modelFor("vertex"),
vertexName = vertex.get("name"),
entityID = vertex.get("entityID");
return `Vertex Tasks: ${vertexName} (${entityID})`;
  }).volatile(),
{code}

Please note the extra ".volatile()" function call. Its added so that the 
compute function is called always. 
As we don't have a direct path to the values its necessary (As we are getting 
the vertex object via modelFor). Else the volatile call could have been avoided.


was (Author: sreenath):
I feel Ember way to do that would be to convert title into a computed property. 
In-fact code in tez-ui/src/main/webapp/app/routes/abstract.js is designed for 
that.

For example. Title in tez-ui/src/main/webapp/app/routes/vertex/tasks.js could 
be changed as follows.
{code}
  title: Ember.computed(function () {
var vertex = this.modelFor("vertex"),
vertexName = vertex.get("name"),
entityID = vertex.get("entityID");
return `Vertex Tasks: ${vertexName} (${entityID})`;
  }).volatile(),
{code}

Please note the extra ".volatile()" function call. Its added so that the 
compute function is called always. 
As we don't have a direct path to the values its necessary (As we are getting 
the vertex object via modelFor). Else the volatile could have been avoided.

> Tez UI: Show DAG context in document title 
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
>  Issue Type: Bug
>  Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the 
> document title. This was lost in the 0.9 UI migration. This jira attempts to 
> bring that feature back. This feature is essential when supporting large 
> clusters where a dev or support person may have dozens of dags open at the 
> same time. Having context in the document title (the tab title), will allow 
> us to quickly navigate.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (TEZ-3775) Tez UI: Show DAG context in document title

2017-06-27 Thread Jonathan Eagles (JIRA)

[ 
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065231#comment-16065231
 ] 

Jonathan Eagles edited comment on TEZ-3775 at 6/27/17 8:09 PM:
---

[~rohini], changed to 1) Application Configuration and 2) Vertex Task Attempts. 
Left the ":" \-> "-" change, but could be change if needed.


was (Author: jeagles):
[~rohini], changed to 1) Application Configuration and 2) Vertex Task Attempts. 
Left the ":" -> "-" change but could be change if needed.

> Tez UI: Show DAG context in document title 
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
>  Issue Type: Bug
>  Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the 
> document title. This was lost in the 0.9 UI migration. This jira attempts to 
> bring that feature back. This feature is essential when supporting large 
> clusters where a dev or support person may have dozens of dags open at the 
> same time. Having context in the document title (the tab title), will allow 
> us to quickly navigate.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)