[
https://issues.apache.org/jira/browse/TEZ-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280059#comment-14280059
]
Hadoop QA commented on TEZ-1593:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12692726/TEZ-1593.2.patch
against master revision cdf253f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 68 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/45//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/45//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/45//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/45//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/45//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/45//console
This message is automatically generated.
> Refactor PipelinedSorter to remove all MMAP based ByteBuffer references
> ---
>
> Key: TEZ-1593
> URL: https://issues.apache.org/jira/browse/TEZ-1593
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.6.0
>Reporter: Gopal V
>Assignee: Gopal V
> Labels: Performance
> Attachments: TEZ-1593.1.patch, TEZ-1593.2-WIP.patch, TEZ-1593.2.patch
>
>
> The current implementation of PipelinedSorter has a slow section which
> revolves around key comparisons - this was relevant when the implementation
> used direct byte buffers to back the kvbuffer.
> {code}
> kvbuffer.position(istart);
> kvbuffer.get(ki, 0, ilen);
> kvbuffer.position(jstart);
> kvbuffer.get(kj, 0, jlen);
> // sort by key
> final int cmp = comparator.compare(ki, 0, ilen, kj, 0, jlen);
> {code}
> The kvbuffer.get into the arrays ki and kj are the slowest part of the
> comparator operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
