[jira] [Commented] (TEZ-1910) Build fails against hadoop-2.2.0
[ https://issues.apache.org/jira/browse/TEZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14268549#comment-14268549 ] Jonathan Eagles commented on TEZ-1910: -- +1. Will commit shortly. Thanks, [~hitesh]. Build fails against hadoop-2.2.0 Key: TEZ-1910 URL: https://issues.apache.org/jira/browse/TEZ-1910 Project: Apache Tez Issue Type: Bug Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Blocker Attachments: TEZ-1910.1.patch, TEZ-1910.2.patch https://builds.apache.org/job/Tez-Build-Hadoop-2.2/2/console -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1910) Build fails against hadoop-2.2.0
[ https://issues.apache.org/jira/browse/TEZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266801#comment-14266801 ] Siddharth Seth commented on TEZ-1910: - What was causing the build to fail ? The patch itself looks good to me, but not sure what is fixing the 2.2 build. Build fails against hadoop-2.2.0 Key: TEZ-1910 URL: https://issues.apache.org/jira/browse/TEZ-1910 Project: Apache Tez Issue Type: Bug Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Blocker Attachments: TEZ-1910.1.patch https://builds.apache.org/job/Tez-Build-Hadoop-2.2/2/console -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1910) Build fails against hadoop-2.2.0
[
https://issues.apache.org/jira/browse/TEZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267044#comment-14267044
]
Hitesh Shah commented on TEZ-1910:
--
[~sseth] Couple of issues were seen:
- Something changed in Configuration which ended up causing fs.default.name
to return a null ( when fs.defaultFS was set ) - this test fails with 2.2 but
works with 2.4+
- The other issue was the check for https which [~jeagles] pointed out.
[~jeagles] I considered replicating the https check from hadoop-2.2 ( code
below ) :
{code}
-boolean sslEnabled = conf.getBoolean(
-CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_KEY,
-CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_DEFAULT);
- }
{code}
But I did not want to introduce deprecated code which will likely not be used
as Timeline does not even exist in 2.2.0. If someone configures the timeline
client with hadoop-2.2.0, firstly this would be a user error and furthermore,
there will be other failures which may happen before the https check is
triggered. Comments?
Build fails against hadoop-2.2.0
Key: TEZ-1910
URL: https://issues.apache.org/jira/browse/TEZ-1910
Project: Apache Tez
Issue Type: Bug
Reporter: Hitesh Shah
Assignee: Hitesh Shah
Priority: Blocker
Attachments: TEZ-1910.1.patch
https://builds.apache.org/job/Tez-Build-Hadoop-2.2/2/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-1910) Build fails against hadoop-2.2.0
[
https://issues.apache.org/jira/browse/TEZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266976#comment-14266976
]
Jonathan Eagles commented on TEZ-1910:
--
Looks like we are disabling the TestATSHttpClient since the useHttps method
isn't available in 2.2. The fix works, so I'm ok with it. There are other ways
of fixing it, like having the DAGClientTimelineImpl decide whether to default
to not use https or look up the config value directly. This way is cleanest.
{quote}
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.366 sec
FAILURE!
testGetDagStatusSimple(org.apache.tez.dag.api.client.TestATSHttpClient) Time
elapsed: 0.297 sec ERROR!
org.apache.tez.dag.api.TezException: java.lang.NoSuchMethodException:
org.apache.hadoop.yarn.conf.YarnConfiguration.useHttps(org.apache.hadoop.conf.Configuration)
at java.lang.Class.getMethod(Class.java:1607)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.webappHttpsOnly(DAGClientTimelineImpl.java:450)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.init(DAGClientTimelineImpl.java:102)
at
org.apache.tez.dag.api.client.TestATSHttpClient.testGetDagStatusSimple(TestATSHttpClient.java:70)
testGetVertexStatusSimple(org.apache.tez.dag.api.client.TestATSHttpClient)
Time elapsed: 0.001 sec ERROR!
org.apache.tez.dag.api.TezException: java.lang.NoSuchMethodException:
org.apache.hadoop.yarn.conf.YarnConfiguration.useHttps(org.apache.hadoop.conf.Configuration)
at java.lang.Class.getMethod(Class.java:1607)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.webappHttpsOnly(DAGClientTimelineImpl.java:450)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.init(DAGClientTimelineImpl.java:102)
at
org.apache.tez.dag.api.client.TestATSHttpClient.testGetVertexStatusSimple(TestATSHttpClient.java:130)
testGetDagStatusThrowsExceptionOnEmptyJson(org.apache.tez.dag.api.client.TestATSHttpClient)
Time elapsed: 0.003 sec ERROR!
org.apache.tez.dag.api.TezException: java.lang.NoSuchMethodException:
org.apache.hadoop.yarn.conf.YarnConfiguration.useHttps(org.apache.hadoop.conf.Configuration)
at java.lang.Class.getMethod(Class.java:1607)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.webappHttpsOnly(DAGClientTimelineImpl.java:450)
at
org.apache.tez.dag.api.client.DAGClientTimelineImpl.init(DAGClientTimelineImpl.java:102)
at
org.apache.tez.dag.api.client.TestATSHttpClient.testGetDagStatusThrowsExceptionOnEmptyJson(TestATSHttpClient.java:46)
{quote}
Build fails against hadoop-2.2.0
Key: TEZ-1910
URL: https://issues.apache.org/jira/browse/TEZ-1910
Project: Apache Tez
Issue Type: Bug
Reporter: Hitesh Shah
Assignee: Hitesh Shah
Priority: Blocker
Attachments: TEZ-1910.1.patch
https://builds.apache.org/job/Tez-Build-Hadoop-2.2/2/console
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-1910) Build fails against hadoop-2.2.0
[ https://issues.apache.org/jira/browse/TEZ-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267205#comment-14267205 ] Jonathan Eagles commented on TEZ-1910: -- +1. I think the patch is implemented simply enough. Please add comment in TestATSHttpClient why this is disabled (API added in 2.4) since it isn't directly clear without the seeing the test failure. Build fails against hadoop-2.2.0 Key: TEZ-1910 URL: https://issues.apache.org/jira/browse/TEZ-1910 Project: Apache Tez Issue Type: Bug Reporter: Hitesh Shah Assignee: Hitesh Shah Priority: Blocker Attachments: TEZ-1910.1.patch https://builds.apache.org/job/Tez-Build-Hadoop-2.2/2/console -- This message was sent by Atlassian JIRA (v6.3.4#6332)
