[jira] [Commented] (TEZ-1913) Reduce deserialize cost in ValuesIterator

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276307#comment-14276307
 ] 

Hadoop QA commented on TEZ-1913:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12692091/TEZ-1913.3.patch
  against master revision 8326165.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:red}-1 findbugs{color}.  The patch appears to introduce 260 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/17//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/17//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/17//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/17//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/17//artifact/patchprocess/newPatchFindbugsWarningstez-tests.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/17//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/17//console

This message is automatically generated.

> Reduce deserialize cost in ValuesIterator
> -
>
> Key: TEZ-1913
> URL: https://issues.apache.org/jira/browse/TEZ-1913
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>  Labels: perfomance
> Attachments: TEZ-1913.1.patch, TEZ-1913.2.patch, TEZ-1913.3.patch
>
>
> When TezRawKeyValueIterator->isSameKey() is added, it should be possible to 
> reduce the number of deserializations in ValuesIterator->readNextKey().
> Creating this ticket to track the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-1913) Reduce deserialize cost in ValuesIterator

[Siddharth Seth (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274256#comment-14274256
 ] 

Siddharth Seth commented on TEZ-1913:
-

bq. Right, should we return "false" in MRResultsIterator and PipelineSorter 
until isSameKey is properly implemented?
I think so.

+1. The rest looks good. Thanks!

> Reduce deserialize cost in ValuesIterator
> -
>
> Key: TEZ-1913
> URL: https://issues.apache.org/jira/browse/TEZ-1913
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>  Labels: perfomance
> Attachments: TEZ-1913.1.patch, TEZ-1913.2.patch
>
>
> When TezRawKeyValueIterator->isSameKey() is added, it should be possible to 
> reduce the number of deserializations in ValuesIterator->readNextKey().
> Creating this ticket to track the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-1913) Reduce deserialize cost in ValuesIterator

[Siddharth Seth (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEZ-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268331#comment-14268331
 ] 

Siddharth Seth commented on TEZ-1913:
-

Questions/comments on the patch.
- The ValuesIterator is used by the Combiners as well. I'm not sure a result of 
a merge (RawKViterator which support isSameKey) is the only iterator which will 
be used in these cases. From the PipelineSorter, there were some RawKVIterators 
which don't implement the method.
- EmptyIteartor.isSameKey isn't implemented - don't think we'll ever his this, 
but the Merger can return an instance of this. Should probably change this to 
return false.
- Test in TestValuesIterator to validate same keys working.

> Reduce deserialize cost in ValuesIterator
> -
>
> Key: TEZ-1913
> URL: https://issues.apache.org/jira/browse/TEZ-1913
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>  Labels: perfomance
> Attachments: TEZ-1913.1.patch
>
>
> When TezRawKeyValueIterator->isSameKey() is added, it should be possible to 
> reduce the number of deserializations in ValuesIterator->readNextKey().
> Creating this ticket to track the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)