[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286767#comment-14286767 ] Jeff Zhang commented on TEZ-1934: - backport it to branch-0.5 commit 119003effd4acfcba6f26397fddc8f4d8b0f4671 (HEAD, origin/branch-0.5, branch-0.5) Author: Jeff Zhang zjf...@apache.org Date: Fri Jan 16 09:47:46 2015 +0800 TEZ-1934. TestAMRecovery may fail due to the execution order is not determined. (zjffdu) (cherry picked from commit 880d4f38f4ccb2de987a7c9ca4cbbbe67b0a833e) Conflicts: CHANGES.txt TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Fix For: 0.7.0 Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280116#comment-14280116 ] Jeff Zhang commented on TEZ-1934: - committed to master TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278908#comment-14278908 ] Hitesh Shah commented on TEZ-1934: -- Not sure why one build worked fine and the latter didnt. Triggered test patch again. TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279328#comment-14279328 ] Hitesh Shah commented on TEZ-1934: -- +1. Looks good to commit ( after git comes back online ) TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278123#comment-14278123 ] Hitesh Shah commented on TEZ-1934: -- Triggered test patch for this jira. TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[
https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278185#comment-14278185
]
Hadoop QA commented on TEZ-1934:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12691636/TEZ-1934-1.patch
against master revision 61bb0f8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 179 javac
compiler warnings (more than the master's current 171 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
See
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/diffJavadocWarnings.txt
for details.
{color:red}-1 findbugs{color}. The patch appears to introduce 260 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/27//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/newPatchFindbugsWarningstez-tests.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
Javac warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/27//console
This message is automatically generated.
TestAMRecovery may fail due to the execution order is not determined
-
Key: TEZ-1934
URL: https://issues.apache.org/jira/browse/TEZ-1934
Project: Apache Tez
Issue Type: Bug
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Attachments: TEZ-1934-1.patch
task_1 is not guaranteed to been scheduled before task_0, so task_1 may
finished before task_0. While in the current TestAMRecovery, the finish of
task_1 is treated as the finished signal of vertex ( only 2 tasks in this
vertex)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278121#comment-14278121 ] Hitesh Shah commented on TEZ-1934: -- Mostly looks good. Does the onSourceTaskCompleted function need to be synchronized - can it be called concurrently for diff tasks finishing? TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278128#comment-14278128 ] Jeff Zhang commented on TEZ-1934: - onSourceTaskCompleted is only called in the main dispatcher thread. it should be fine without synchronized TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278131#comment-14278131 ] Hitesh Shah commented on TEZ-1934: -- +1. TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[
https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278182#comment-14278182
]
Hadoop QA commented on TEZ-1934:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12691636/TEZ-1934-1.patch
against master revision 61bb0f8.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 260 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/26//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/26//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/26//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/26//artifact/patchprocess/newPatchFindbugsWarningstez-tests.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/26//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/26//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/26//console
This message is automatically generated.
TestAMRecovery may fail due to the execution order is not determined
-
Key: TEZ-1934
URL: https://issues.apache.org/jira/browse/TEZ-1934
Project: Apache Tez
Issue Type: Bug
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Attachments: TEZ-1934-1.patch
task_1 is not guaranteed to been scheduled before task_0, so task_1 may
finished before task_0. While in the current TestAMRecovery, the finish of
task_1 is treated as the finished signal of vertex ( only 2 tasks in this
vertex)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-1934) TestAMRecovery may fail due to the execution order is not determined
[ https://issues.apache.org/jira/browse/TEZ-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278194#comment-14278194 ] Jeff Zhang commented on TEZ-1934: - [~hitesh], New javac compiler warnings and javadoc warnings are generated, where can I see these warnings ? The link https://builds.apache.org/job/PreCommit-TEZ-Build/27//artifact/patchprocess/diffJavadocWarnings.txt looks broken. TestAMRecovery may fail due to the execution order is not determined - Key: TEZ-1934 URL: https://issues.apache.org/jira/browse/TEZ-1934 Project: Apache Tez Issue Type: Bug Reporter: Jeff Zhang Assignee: Jeff Zhang Attachments: TEZ-1934-1.patch task_1 is not guaranteed to been scheduled before task_0, so task_1 may finished before task_0. While in the current TestAMRecovery, the finish of task_1 is treated as the finished signal of vertex ( only 2 tasks in this vertex) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
