[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-17 Thread Bikas Saha (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805026#comment-14805026
 ] 

Bikas Saha commented on TEZ-2832:
-

Thanks! I am trying to improve the common case where a large allocation 
overhead shows up in the critical path. Running multiple waves of a given 
vertex would imply that the job could run faster if it had more capacity. This 
is just a first step. We could probably analyze the container allocations to 
derive more insights.

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch, TEZ-2832.2.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-17 Thread Rajesh Balamohan (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805008#comment-14805008
 ] 

Rajesh Balamohan commented on TEZ-2832:
---

lgtm. +1.  Were the changes related to "tracking multiple waves that were run 
on the same container" added for any specific debugging reason?.

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch, TEZ-2832.2.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-17 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804882#comment-14804882
 ] 

TezQA commented on TEZ-2832:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12757191/TEZ-2832.2.patch
  against master revision 35cf023.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1151//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1151//console

This message is automatically generated.

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch, TEZ-2832.2.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-17 Thread Bikas Saha (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803330#comment-14803330
 ] 

Bikas Saha commented on TEZ-2832:
-

[~rajesh.balamohan] Please review when convenient!

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-15 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746467#comment-14746467
 ] 

TezQA commented on TEZ-2832:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12756099/TEZ-2832.1.patch
  against master revision c3ce351.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1144//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1144//console

This message is automatically generated.

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-2832) Support tests for both SimpleHistory logging and ATS logging

2015-09-15 Thread Bikas Saha (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746357#comment-14746357
 ] 

Bikas Saha commented on TEZ-2832:
-

The test change is to run all dags in 2 modes - ats and no-ats. Then stop the 
session and then verify all dags. this also removes race conditions to sync the 
data before reading them in the test (specially for simple history).
Also adds a waves analysis to the critical path analyzer that reports if a 
container was reused for the same vertex while it was waiting for allocation 
for a task on the critical path. More improvements to come here.
[~rajesh.balamohan] please review

> Support tests for both SimpleHistory logging and ATS logging
> 
>
> Key: TEZ-2832
> URL: https://issues.apache.org/jira/browse/TEZ-2832
> Project: Apache Tez
>  Issue Type: Sub-task
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2832.1.patch
>
>
> This will ensure that both kinds of logging continue to be valid for using 
> with the cp analyzer



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)