[jira] [Commented] (TEZ-3177) Non-DAG events should use the session domain or no domain if the data does not need protection

2016-04-04 Thread Siddharth Seth (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225189#comment-15225189
 ] 

Siddharth Seth commented on TEZ-3177:
-

+1.

> Non-DAG events should use the session domain or no domain if the data does 
> not need protection 
> ---
>
> Key: TEZ-3177
> URL: https://issues.apache.org/jira/browse/TEZ-3177
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Hitesh Shah
> Attachments: TEZ-3177.1.patch, TEZ-3177.2.patch
>
>
> There have been issues noticed where when using dag specific domains, 
> container events get generated under different dags causing issues as they 
> are updated using different domains. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3177) Non-DAG events should use the session domain or no domain if the data does not need protection

2016-04-02 Thread Siddharth Seth (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223051#comment-15223051
 ] 

Siddharth Seth commented on TEZ-3177:
-

{code}
+  if (historyACLPolicyManager != null
+  && sessionDomainId != null && !sessionDomainId.isEmpty()
+  && domainId != null && !domainId.isEmpty()) {
+if 
(HistoryEventType.isDAGSpecificEvent(event.getHistoryEvent().getEventType())) {
   historyACLPolicyManager.updateTimelineEntityDomain(entities[i], 
domainId);
+} else {
+  historyACLPolicyManager.updateTimelineEntityDomain(entities[i], 
sessionDomainId);
 }
{code}

Dag specific domain id / session domain id - will both either be set, or unset 
? Do wen end up missing the domainId in some cases if both are unset. It may be 
better to flip the check to say - if(dagDomainType) - null check the 
dagDomainId, otherwise null check the sessionDomainId.

Rest looks good.


> Non-DAG events should use the session domain or no domain if the data does 
> not need protection 
> ---
>
> Key: TEZ-3177
> URL: https://issues.apache.org/jira/browse/TEZ-3177
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Hitesh Shah
> Attachments: TEZ-3177.1.patch
>
>
> There have been issues noticed where when using dag specific domains, 
> container events get generated under different dags causing issues as they 
> are updated using different domains. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3177) Non-DAG events should use the session domain or no domain if the data does not need protection

2016-03-31 Thread Hitesh Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220406#comment-15220406
 ] 

Hitesh Shah commented on TEZ-3177:
--

[~sseth] [~rajesh.balamohan] please review

> Non-DAG events should use the session domain or no domain if the data does 
> not need protection 
> ---
>
> Key: TEZ-3177
> URL: https://issues.apache.org/jira/browse/TEZ-3177
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Hitesh Shah
>Assignee: Hitesh Shah
> Attachments: TEZ-3177.1.patch
>
>
> There have been issues noticed where when using dag specific domains, 
> container events get generated under different dags causing issues as they 
> are updated using different domains. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)