[jira] [Commented] (TEZ-3625) Dag.getVertex should obtain a readlock

2017-02-24 Thread Siddharth Seth (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883486#comment-15883486
 ] 

Siddharth Seth commented on TEZ-3625:
-

This change ended up resulting in a race and occasional deadlock between 
dagCompletion and some call from the VertexManagerPlugin for dags with 0 
fragments. Reverting.

> Dag.getVertex should obtain a readlock
> --
>
> Key: TEZ-3625
> URL: https://issues.apache.org/jira/browse/TEZ-3625
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
>Priority: Minor
> Fix For: 0.9.0, 0.8.5
>
> Attachments: TEZ-3625.01.patch
>
>
> getVertex(String) does not obtain a readLock. It should, similar to 
> getVertex(TezVertexId)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TEZ-3625) Dag.getVertex should obtain a readlock

2017-02-15 Thread Siddharth Seth (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869145#comment-15869145
 ] 

Siddharth Seth commented on TEZ-3625:
-

Thanks for the review. Committing.

> Dag.getVertex should obtain a readlock
> --
>
> Key: TEZ-3625
> URL: https://issues.apache.org/jira/browse/TEZ-3625
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
>Priority: Minor
> Attachments: TEZ-3625.01.patch
>
>
> getVertex(String) does not obtain a readLock. It should, similar to 
> getVertex(TezVertexId)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TEZ-3625) Dag.getVertex should obtain a readlock

2017-02-14 Thread Rajesh Balamohan (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866921#comment-15866921
 ] 

Rajesh Balamohan commented on TEZ-3625:
---

lgtm. +1

> Dag.getVertex should obtain a readlock
> --
>
> Key: TEZ-3625
> URL: https://issues.apache.org/jira/browse/TEZ-3625
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
>Priority: Minor
> Attachments: TEZ-3625.01.patch
>
>
> getVertex(String) does not obtain a readLock. It should, similar to 
> getVertex(TezVertexId)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TEZ-3625) Dag.getVertex should obtain a readlock

2017-02-14 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866829#comment-15866829
 ] 

TezQA commented on TEZ-3625:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12852658/TEZ-3625.01.patch
  against master revision cd44c90.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/2260//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2260//console

This message is automatically generated.

> Dag.getVertex should obtain a readlock
> --
>
> Key: TEZ-3625
> URL: https://issues.apache.org/jira/browse/TEZ-3625
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Siddharth Seth
>Assignee: Siddharth Seth
>Priority: Minor
> Attachments: TEZ-3625.01.patch
>
>
> getVertex(String) does not obtain a readLock. It should, similar to 
> getVertex(TezVertexId)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)