[jira] [Commented] (TEZ-3707) TezSharedExecutor race condition in awaitTermination vs isTerminated.
[ https://issues.apache.org/jira/browse/TEZ-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994158#comment-15994158 ] Siddharth Seth commented on TEZ-3707: - +1 > TezSharedExecutor race condition in awaitTermination vs isTerminated. > - > > Key: TEZ-3707 > URL: https://issues.apache.org/jira/browse/TEZ-3707 > Project: Apache Tez > Issue Type: Bug >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash > Attachments: TEZ-3707.01.patch > > > awaitTermination finishes if all the futures are resolved. isTerminated > returns true if futures is empty. future done is invoked after the future is > resolve, which can lead to awaitTermination finishing but isTerminated is > false until done is invoked. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TEZ-3707) TezSharedExecutor race condition in awaitTermination vs isTerminated.
[ https://issues.apache.org/jira/browse/TEZ-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992574#comment-15992574 ] Harish Jaiprakash commented on TEZ-3707: Test case failures unrelated to this patch. > TezSharedExecutor race condition in awaitTermination vs isTerminated. > - > > Key: TEZ-3707 > URL: https://issues.apache.org/jira/browse/TEZ-3707 > Project: Apache Tez > Issue Type: Bug >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash > Attachments: TEZ-3707.01.patch > > > awaitTermination finishes if all the futures are resolved. isTerminated > returns true if futures is empty. future done is invoked after the future is > resolve, which can lead to awaitTermination finishing but isTerminated is > false until done is invoked. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TEZ-3707) TezSharedExecutor race condition in awaitTermination vs isTerminated.
[
https://issues.apache.org/jira/browse/TEZ-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992391#comment-15992391
]
TezQA commented on TEZ-3707:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12865872/TEZ-3707.01.patch
against master revision ebf3fb1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2407//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2407//console
This message is automatically generated.
> TezSharedExecutor race condition in awaitTermination vs isTerminated.
> -
>
> Key: TEZ-3707
> URL: https://issues.apache.org/jira/browse/TEZ-3707
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
> Attachments: TEZ-3707.01.patch
>
>
> awaitTermination finishes if all the futures are resolved. isTerminated
> returns true if futures is empty. future done is invoked after the future is
> resolve, which can lead to awaitTermination finishing but isTerminated is
> false until done is invoked.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
