[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[ https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069561#comment-16069561 ] Sreenath Somarajapuram commented on TEZ-3775: - Thanks [~jeagles] +1 looks good to me. > Tez UI: Show DAG context in document title > --- > > Key: TEZ-3775 > URL: https://issues.apache.org/jira/browse/TEZ-3775 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch, > TEZ-3775.4.patch > > > In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the > document title. This was lost in the 0.9 UI migration. This jira attempts to > bring that feature back. This feature is essential when supporting large > clusters where a dev or support person may have dozens of dags open at the > same time. Having context in the document title (the tab title), will allow > us to quickly navigate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068987#comment-16068987
]
TezQA commented on TEZ-3775:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874935/TEZ-3775.4.patch
against master revision a47e8fc.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2563//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2563//console
This message is automatically generated.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch,
> TEZ-3775.4.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066533#comment-16066533
]
Sreenath Somarajapuram commented on TEZ-3775:
-
I feel Ember way to do that would be to convert title into a computed property.
In-fact code in tez-ui/src/main/webapp/app/routes/abstract.js is designed for
that.
For example. Title in tez-ui/src/main/webapp/app/routes/vertex/tasks.js could
be changed as follows.
{code}
title: Ember.computed(function () {
var vertex = this.modelFor("vertex"),
vertexName = vertex.get("name"),
entityID = vertex.get("entityID");
return `Vertex Tasks: ${vertexName} (${entityID})`;
}).volatile(),
{code}
Please note the extra ".volatile()" function call. Its added so that the
compute function is called always.
As we don't have a direct path to the values its necessary (As we are getting
the vertex object via modelFor). Else the volatile could have been avoided.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065962#comment-16065962
]
Harish Jaiprakash commented on TEZ-3775:
{code}var titleText = typeof title == 'function' ? this.title() : title;{code}
Shouldn't we use title.apply(this)? It works currently because this.title and
this.get('title') are same.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065713#comment-16065713
]
TezQA commented on TEZ-3775:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874768/TEZ-3775.3.patch
against master revision de72fbe.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2557//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2557//console
This message is automatically generated.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch, TEZ-3775.3.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[ https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065589#comment-16065589 ] Rohini Palaniswamy commented on TEZ-3775: - Couple more comments: 1) Tez UI in each title seems redundant. Have to increase tab width more than before (using https://addons.mozilla.org/en-US/firefox/addon/tree-style-tab/) to view full title. If we are removing "Tez UI:" , can we change - to : in 0.9 as well? Consistent when dealing with multiple versions and easier on eyes like mine with OCD . 2) Details can also be removed for same reason. DAG/Vertex/Task/Task Attempt is good enough for the details page. 3) 0.9 shows vertex title as "Tez UI: Vertex Details - vertex_1492628984747_2502482_7_00" . 0.7 shows the vertex title as "Vertex: File Merge - vertex_1492628984747_2502482_7_00" where "File Merge" is the name of vertex in this hive DAG. In Pig DAG's you will have scope- in there. Name of the vertex is the most useful info. That needs to be added back. Thanks for fixing this. I have been going crazy without this when opening lot of tabs and struggling to switch between them without a clue. > Tez UI: Show DAG context in document title > --- > > Key: TEZ-3775 > URL: https://issues.apache.org/jira/browse/TEZ-3775 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch > > > In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the > document title. This was lost in the 0.9 UI migration. This jira attempts to > bring that feature back. This feature is essential when supporting large > clusters where a dev or support person may have dozens of dags open at the > same time. Having context in the document title (the tab title), will allow > us to quickly navigate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065436#comment-16065436
]
TezQA commented on TEZ-3775:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874719/TEZ-3775.2.patch
against master revision 5b0f5a0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2554//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2554//console
This message is automatically generated.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch, TEZ-3775.2.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[ https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065165#comment-16065165 ] Rohini Palaniswamy commented on TEZ-3775: - Noticed two things different from 0.7 - We are replacing : in 0.7 with - in 0.9 as a separator. Not a big deal. - 0.7 did not have Details/Counters/Tasks/Attempts for vertex, task, attempt. This patch adds it and it is good. Just couple of minor comments. 1) Application Configurations -> Application Configuration 2) Vertex Attempts -> Task Attempts or Vertex Task Attempts > Tez UI: Show DAG context in document title > --- > > Key: TEZ-3775 > URL: https://issues.apache.org/jira/browse/TEZ-3775 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-3775.1.patch > > > In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the > document title. This was lost in the 0.9 UI migration. This jira attempts to > bring that feature back. This feature is essential when supporting large > clusters where a dev or support person may have dozens of dags open at the > same time. Having context in the document title (the tab title), will allow > us to quickly navigate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3775) Tez UI: Show DAG context in document title
[
https://issues.apache.org/jira/browse/TEZ-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063582#comment-16063582
]
TezQA commented on TEZ-3775:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874520/TEZ-3775.1.patch
against master revision a7f93ae.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2542//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2542//console
This message is automatically generated.
> Tez UI: Show DAG context in document title
> ---
>
> Key: TEZ-3775
> URL: https://issues.apache.org/jira/browse/TEZ-3775
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-3775.1.patch
>
>
> In Tez UI 0.7, DAG (vertex, app, task, attempt) context was shown in the
> document title. This was lost in the 0.9 UI migration. This jira attempts to
> bring that feature back. This feature is essential when supporting large
> clusters where a dev or support person may have dozens of dags open at the
> same time. Having context in the document title (the tab title), will allow
> us to quickly navigate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
