[jira] [Commented] (TEZ-3816) Ability to automatically speculate single-task vertices
[
https://issues.apache.org/jira/browse/TEZ-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126181#comment-16126181
]
TezQA commented on TEZ-3816:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12881795/TEZ-3816.003.patch
against master revision 1061cf5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2613//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2613//console
This message is automatically generated.
> Ability to automatically speculate single-task vertices
> ---
>
> Key: TEZ-3816
> URL: https://issues.apache.org/jira/browse/TEZ-3816
> Project: Apache Tez
> Issue Type: Improvement
>Reporter: Muhammad Samir Khan
>Assignee: Muhammad Samir Khan
> Attachments: TEZ-3816.001.patch, TEZ-3816.002.patch,
> TEZ-3816.003.patch
>
>
> When a single-task vertex is unlucky, it lands on a very slow node.
> Speculation doesn't currently apply when there are no other tasks to compare
> with. It would be good to have a configurable timeout after which the tasks
> automatically speculate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3816) Ability to automatically speculate single-task vertices
[ https://issues.apache.org/jira/browse/TEZ-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126168#comment-16126168 ] Siddharth Seth commented on TEZ-3816: - +1. Thanks [~samkhan]. Will commit once jenkins gets back. > Ability to automatically speculate single-task vertices > --- > > Key: TEZ-3816 > URL: https://issues.apache.org/jira/browse/TEZ-3816 > Project: Apache Tez > Issue Type: Improvement >Reporter: Muhammad Samir Khan >Assignee: Muhammad Samir Khan > Attachments: TEZ-3816.001.patch, TEZ-3816.002.patch, > TEZ-3816.003.patch > > > When a single-task vertex is unlucky, it lands on a very slow node. > Speculation doesn't currently apply when there are no other tasks to compare > with. It would be good to have a configurable timeout after which the tasks > automatically speculate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3816) Ability to automatically speculate single-task vertices
[ https://issues.apache.org/jira/browse/TEZ-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122452#comment-16122452 ] Siddharth Seth commented on TEZ-3816: - I believe a max of 2 attempts (for a single task) running is handled via the regular flow? So that this does not end up spawning new attempts up to the max limit each time this timeout is exceeded. May be easier to put all the logic in a single place - LegacySpeculator.maybeScheduleASpeculation, instead of having to change multiple methods on the LegactyRuntimeEstimator class. Another possible enhancement, at a later point, would be to speculate earlier rather than later, once there is sufficient confidence that the current attempt will miss the timeout, based on progress information available. > Ability to automatically speculate single-task vertices > --- > > Key: TEZ-3816 > URL: https://issues.apache.org/jira/browse/TEZ-3816 > Project: Apache Tez > Issue Type: Improvement >Reporter: Muhammad Samir Khan >Assignee: Muhammad Samir Khan > Attachments: TEZ-3816.001.patch > > > When a single-task vertex is unlucky, it lands on a very slow node. > Speculation doesn't currently apply when there are no other tasks to compare > with. It would be good to have a configurable timeout after which the tasks > automatically speculate. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3816) Ability to automatically speculate single-task vertices
[
https://issues.apache.org/jira/browse/TEZ-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122443#comment-16122443
]
TezQA commented on TEZ-3816:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12881087/TEZ-3816.001.patch
against master revision 1061cf5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2610//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2610//console
This message is automatically generated.
> Ability to automatically speculate single-task vertices
> ---
>
> Key: TEZ-3816
> URL: https://issues.apache.org/jira/browse/TEZ-3816
> Project: Apache Tez
> Issue Type: Improvement
>Reporter: Muhammad Samir Khan
>Assignee: Muhammad Samir Khan
> Attachments: TEZ-3816.001.patch
>
>
> When a single-task vertex is unlucky, it lands on a very slow node.
> Speculation doesn't currently apply when there are no other tasks to compare
> with. It would be good to have a configurable timeout after which the tasks
> automatically speculate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
