[jira] [Commented] (TEZ-3830) HistoryEventTimelineConversion should not hard code the Task state.
[ https://issues.apache.org/jira/browse/TEZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188405#comment-16188405 ] Jonathan Eagles commented on TEZ-3830: -- +1. Thanks, [~kshukla]. > HistoryEventTimelineConversion should not hard code the Task state. > --- > > Key: TEZ-3830 > URL: https://issues.apache.org/jira/browse/TEZ-3830 > Project: Apache Tez > Issue Type: Bug >Reporter: Kuhu Shukla >Assignee: Kuhu Shukla > Attachments: TEZ-3830.001.patch > > > TaskStartedEvent can have the state of the task so that the HistoryConversion > does not require task state to be hardcoded to SCHEDULED. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3830) HistoryEventTimelineConversion should not hard code the Task state.
[
https://issues.apache.org/jira/browse/TEZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184402#comment-16184402
]
TezQA commented on TEZ-3830:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889504/TEZ-3830.001.patch
against master revision 8f61c51.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2644//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2644//console
This message is automatically generated.
> HistoryEventTimelineConversion should not hard code the Task state.
> ---
>
> Key: TEZ-3830
> URL: https://issues.apache.org/jira/browse/TEZ-3830
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Kuhu Shukla
>Assignee: Kuhu Shukla
> Attachments: TEZ-3830.001.patch
>
>
> TaskStartedEvent can have the state of the task so that the HistoryConversion
> does not require task state to be hardcoded to SCHEDULED.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TEZ-3830) HistoryEventTimelineConversion should not hard code the Task state.
[ https://issues.apache.org/jira/browse/TEZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179501#comment-16179501 ] Jonathan Eagles commented on TEZ-3830: -- Any plans to provide a simple patch to address this issue. Seems a good fix to me. > HistoryEventTimelineConversion should not hard code the Task state. > --- > > Key: TEZ-3830 > URL: https://issues.apache.org/jira/browse/TEZ-3830 > Project: Apache Tez > Issue Type: Bug >Reporter: Kuhu Shukla >Assignee: Kuhu Shukla > > TaskStartedEvent can have the state of the task so that the HistoryConversion > does not require task state to be hardcoded to SCHEDULED. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEZ-3830) HistoryEventTimelineConversion should not hard code the Task state.
[ https://issues.apache.org/jira/browse/TEZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161691#comment-16161691 ] Kuhu Shukla commented on TEZ-3830: -- Even if we change the state in the logging to getState() from SCHEDULED, it would not show any difference since the transition from scheduled does not happen until after this entity log. > HistoryEventTimelineConversion should not hard code the Task state. > --- > > Key: TEZ-3830 > URL: https://issues.apache.org/jira/browse/TEZ-3830 > Project: Apache Tez > Issue Type: Bug >Reporter: Kuhu Shukla >Assignee: Kuhu Shukla > > TaskStartedEvent can have the state of the task so that the HistoryConversion > does not require task state to be hardcoded to SCHEDULED. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
