[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[ https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494101#comment-16494101 ] Jason Lowe commented on TEZ-3943: - +1 lgtm. The unit test failures are expected due to the recent update of netty dependencies conflicting with the Hadoop 2.x minicluster and should be resolved when TEZ-3923 is resolved. Committing this. > TezClient leaks DAGClient for prewarm > - > > Key: TEZ-3943 > URL: https://issues.apache.org/jira/browse/TEZ-3943 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: TEZ-3943.01.patch, TEZ-3943.02.patch, TEZ-3943.patch > > > This may in turn leak some security related threads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[ https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491395#comment-16491395 ] Sergey Shelukhin commented on TEZ-3943: --- Looks like testshiffle is pretty unstable. https://builds.apache.org/job/PreCommit-TEZ-Build/2815/testReport/org.apache.tez.test/TestSecureShuffle/testSecureShuffle_test_sslInCluster_true__resultWithTezSSL_0__resultWithoutTezSSL_1__asyncHttp_false__/history/ The other test also fails often: https://builds.apache.org/job/PreCommit-TEZ-Build/2815/testReport/org.apache.tez.test/TestAMRecovery/testVertexCompletelyFinished_Broadcast/history/ [~ashutoshc] [~hagleitn] can you commit? [~ewohlstadter] reviewed above, but neither of us is a committer > TezClient leaks DAGClient for prewarm > - > > Key: TEZ-3943 > URL: https://issues.apache.org/jira/browse/TEZ-3943 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: TEZ-3943.01.patch, TEZ-3943.02.patch, TEZ-3943.patch > > > This may in turn leak some security related threads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[
https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491382#comment-16491382
]
TezQA commented on TEZ-3943:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12925209/TEZ-3943.02.patch
against master revision f6624c1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestSecureShuffle
org.apache.tez.test.TestAMRecovery
The following test timeouts occurred in :
org.apache.tez.tests.TestExternalTezServices
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2815//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2815//console
This message is automatically generated.
> TezClient leaks DAGClient for prewarm
> -
>
> Key: TEZ-3943
> URL: https://issues.apache.org/jira/browse/TEZ-3943
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: TEZ-3943.01.patch, TEZ-3943.02.patch, TEZ-3943.patch
>
>
> This may in turn leak some security related threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[
https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491260#comment-16491260
]
TezQA commented on TEZ-3943:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12925207/TEZ-3943.01.patch
against master revision f6624c1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to cause Findbugs
(version ) to fail.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2814//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2814//console
This message is automatically generated.
> TezClient leaks DAGClient for prewarm
> -
>
> Key: TEZ-3943
> URL: https://issues.apache.org/jira/browse/TEZ-3943
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: TEZ-3943.01.patch, TEZ-3943.patch
>
>
> This may in turn leak some security related threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[ https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491243#comment-16491243 ] Sergey Shelukhin commented on TEZ-3943: --- Fixed some client test. The other ones pass for me. > TezClient leaks DAGClient for prewarm > - > > Key: TEZ-3943 > URL: https://issues.apache.org/jira/browse/TEZ-3943 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: TEZ-3943.01.patch, TEZ-3943.patch > > > This may in turn leak some security related threads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[
https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489965#comment-16489965
]
TezQA commented on TEZ-3943:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12925024/TEZ-3943.patch
against master revision f6624c1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.test.TestSecureShuffle
org.apache.tez.client.TestTezClient
The following test timeouts occurred in :
org.apache.tez.tests.TestExternalTezServices
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2812//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2812//console
This message is automatically generated.
> TezClient leaks DAGClient for prewarm
> -
>
> Key: TEZ-3943
> URL: https://issues.apache.org/jira/browse/TEZ-3943
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
>Priority: Major
> Attachments: TEZ-3943.patch
>
>
> This may in turn leak some security related threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[ https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489855#comment-16489855 ] Eric Wohlstadter commented on TEZ-3943: --- lgtm, pending QA reporter Should also commit this to branch-0.9 > TezClient leaks DAGClient for prewarm > - > > Key: TEZ-3943 > URL: https://issues.apache.org/jira/browse/TEZ-3943 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: TEZ-3943.patch > > > This may in turn leak some security related threads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TEZ-3943) TezClient leaks DAGClient for prewarm
[ https://issues.apache.org/jira/browse/TEZ-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489808#comment-16489808 ] Sergey Shelukhin commented on TEZ-3943: --- [~ewohlstadter] can you take a look? > TezClient leaks DAGClient for prewarm > - > > Key: TEZ-3943 > URL: https://issues.apache.org/jira/browse/TEZ-3943 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: TEZ-3943.patch > > > This may in turn leak some security related threads. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
