[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542181#comment-16542181
]
ASF GitHub Bot commented on TEZ-3964:
-
Github user beltran closed the pull request at:
https://github.com/apache/tez/pull/25
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
> Fix For: 0.9.2, 0.10.0
>
> Attachments: TEZ-3964.2.patch
>
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541837#comment-16541837
]
Jason Lowe commented on TEZ-3964:
-
Thanks for updating the patch! +1 lgtm. Committing this.
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
> Attachments: TEZ-3964.2.patch
>
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540720#comment-16540720
]
TezQA commented on TEZ-3964:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12931214/TEZ-3964.2.patch
against master revision 919d328.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2858//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2858//console
This message is automatically generated.
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
> Attachments: TEZ-3964.2.patch
>
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540668#comment-16540668
]
Kuhu Shukla commented on TEZ-3964:
--
bq. Please feel free to remove if you don't think it fits for that release.
Target version looks good to me.
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
> Attachments: TEZ-3964.2.patch
>
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540591#comment-16540591
]
Eric Wohlstadter commented on TEZ-3964:
---
[~kshukla]
Added Target Version 0.9.2. Please feel free to remove if you don't think it
fits for that release.
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540588#comment-16540588
]
Eric Wohlstadter commented on TEZ-3964:
---
[~jmarhuen]
When you have a patch addressing review comments, can you attach and submit?
Thanks!
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534215#comment-16534215
]
Jaume M commented on TEZ-3964:
--
Thank you for reviewing [~jlowe]. Looks like the method doesn't throw
{{IOException}} despite being declared in the method. Maybe we can remove the
{{throws IOException}} from the declaration. We can still do the refactor you
mentioned in case some returns early in the future.
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Assignee: Jaume M
>Priority: Major
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TEZ-3964) Inflater not closed in some places
[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526913#comment-16526913
]
ASF GitHub Bot commented on TEZ-3964:
-
GitHub user beltran opened a pull request:
https://github.com/apache/tez/pull/25
TEZ-3964: https://issues.apache.org/jira/browse/TEZ-3964
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beltran/tez TEZ-3964
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tez/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
commit 0e64b2bcdf69de668908d138eb0fffbaa47940b3
Author: Jaume Marhuenda
Date: 2018-06-28T23:26:56Z
TEZ-3964: https://issues.apache.org/jira/browse/TEZ-3964
> Inflater not closed in some places
> --
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
>Affects Versions: 0.9.1
>Reporter: Jaume M
>Priority: Major
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
