[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Fix Version/s: 0.7.1 > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Fix For: 0.7.1, 0.8.2 > > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, TEZ-2918.3.patch, > TEZ-2918.4.patch, TEZ-2918.branch-0.7.patch, jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.branch-0.7.patch Patch for branch-0.7. [~rajesh.balamohan] Could you please do a quick sanity check. I cherry-picked and did some manual resolves (mainly around interruptibility that does not exist in branch-0.7) Thanks! > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Fix For: 0.8.2 > > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, TEZ-2918.3.patch, > TEZ-2918.4.patch, TEZ-2918.branch-0.7.patch, jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.4.patch > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, TEZ-2918.3.patch, > TEZ-2918.4.patch, jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: (was: TEZ-2918.3.patch) > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, > jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.3.patch > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, TEZ-2918.3.patch, > jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.3.patch > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, TEZ-2918.3.patch, > jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajesh Balamohan updated TEZ-2918: -- Attachment: jmh-microbenchmark.tar.gz Tried out a simple JMH microbenchmark which updates boolean vs volatile boolean. Attached the src details here and the results are as follows {noformat} Benchmark Mode Cnt Score Error Units TestVolatileMicrobenchmark.write_atomic_boolean_with_lazyset avgt5 1.085 ± 1.466 ns/op TestVolatileMicrobenchmark.write_plain_booleanavgt5 0.647 ± 0.322 ns/op TestVolatileMicrobenchmark.write_volatile_boolean avgt5 9.694 ± 6.095 ns/op {noformat} It appears that the volatile is a lot more expensive that the non-volatile writes by 9x times. Since it is getting updated by a single writer, I tried with AtomicBoolean.lazySet(boolean) which claims to be a lot more faster than volatile and results show that it is a lot better compared to volatile (just ~2x as compared to 9x in volatile). Ref for atomic lazySet http://mithun-ruikar.blogspot.in/2014/10/why-atomic-lazyset-is-faster.html, http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6275329. May be we could consider using AtomicBoolean.lazySet() which is internally supported by JDK itself? > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch, > jmh-microbenchmark.tar.gz > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.2.patch Updating patch for test failures > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch, TEZ-2918.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-2918) Make progress notifications in IOs
[ https://issues.apache.org/jira/browse/TEZ-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bikas Saha updated TEZ-2918: Attachment: TEZ-2918.1.patch Patch updates IO's to make notifyProgress() API (added in TEZ-808) calls at different places to notify that progress is being made. Different places are where readers and writers transfer KV transfer KV pairs, spills, event generation, sorts, merges. Some places (merge, sorts etc.) have existing updating via progressable objects (which were nullprogressable until now). Changed them to use the new API with a different progressable. [~rajesh.balamohan] [~jlowe] Please review! > Make progress notifications in IOs > -- > > Key: TEZ-2918 > URL: https://issues.apache.org/jira/browse/TEZ-2918 > Project: Apache Tez > Issue Type: Sub-task >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2918.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)