[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated TEZ-3077: Issue Type: Improvement (was: Bug) > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch, > TEZ-3077.003.patch, TEZ-3077.004.patch, TEZ-3077.005.patch, > TEZ-3077.005.ratfix.txt > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated TEZ-3077: Attachment: TEZ-3077.005.ratfix.txt > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch, > TEZ-3077.003.patch, TEZ-3077.004.patch, TEZ-3077.005.patch, > TEZ-3077.005.ratfix.txt > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated TEZ-3077: - Attachment: TEZ-3077.005.patch Patch addressing comments. I have added the Javadoc comment for the new Exception SessionNotReady. Did not change the Javadoc for preWarm since TezException covers the new Exception which is similar to how waitTillReady handles SessionNotRunning. > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch, > TEZ-3077.003.patch, TEZ-3077.004.patch, TEZ-3077.005.patch > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated TEZ-3077: - Attachment: TEZ-3077.004.patch Rebasing patch for minor conflicts in the test class. > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch, > TEZ-3077.003.patch, TEZ-3077.004.patch > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated TEZ-3077: - Attachment: TEZ-3077.003.patch Updating patch addressing comments. The test now checks if DAG was submitted within the stipulated time for 3 scenarios. Please let me know if I am missing anything. > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch, > TEZ-3077.003.patch > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuhu Shukla updated TEZ-3077: - Attachment: TEZ-3077.002.patch Thank you so much [~sseth] for the review comments. Apologies for the delay. I have attached a revised patch and added a new waitTillReady and preWarm method. Currently the sleep time is decided as either the diff of SLEEP_FOR_READY and timeout if SLEEP_FOR_READY is greater. This could lead to more sleeps if the difference between the two is very small. I wonder if setting it to a fraction of the client timeout like 1/3 (in case of some yarn NM timeouts) may be a better idea? The older waitTillReady calls the new one with value 0. > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > Attachments: TEZ-3077.001.patch, TEZ-3077.002.patch > > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[
https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuhu Shukla updated TEZ-3077:
-
Attachment: TEZ-3077.001.patch
Putting an initial patch based on peer comments. Do we want to change the calls
to {{waitTillReady}} in cases like JoinValidate:
{code}
DAG dag = createDag(tezConf, lhsPath, rhsPath, numPartitions);
tezClient.waitTillReady();
DAGClient dagClient = tezClient.submitDAG(dag);
{code}
Also currently the configured timeout is 10 seconds, does that sound right?
> TezClient.waitTillReady should support timeout
> --
>
> Key: TEZ-3077
> URL: https://issues.apache.org/jira/browse/TEZ-3077
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Kuhu Shukla
> Attachments: TEZ-3077.001.patch
>
>
> Also preWarm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Shah updated TEZ-3077: - Assignee: Kuhu Shukla > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Kuhu Shukla > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TEZ-3077) TezClient.waitTillReady should support timeout
[ https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated TEZ-3077: -- Description: Also preWarm. > TezClient.waitTillReady should support timeout > -- > > Key: TEZ-3077 > URL: https://issues.apache.org/jira/browse/TEZ-3077 > Project: Apache Tez > Issue Type: Bug >Reporter: Sergey Shelukhin > > Also preWarm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
