[GitHub] asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys

[GitBox]

asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys
URL: https://github.com/apache/trafficcontrol/pull/2432#issuecomment-398625670
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1858/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

[GitBox]

rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table 
Endpoints in Go
URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296
 
 
   # Table Usage
   
   ```
   get /api/1.1/cdns/:name/configs/routing
   - DB: Server, Profile, Cdn, Parameter, ProfileParameter, CacheGroup, Regex, 
Type, StaticDNSEntry, DeliveryService
   
   get /api/1.1/cdns/domains
   - DB: Profile, CDN
   
   get /api/1.1/servers/:id/configfiles/ats
   get /api/1.1/profiles/:id/configfiles/ats/:filename
   get /api/1.1/servers/:id/configfiles/ats/:filename
   get /api/1.1/cdns/:id/configfiles/ats/:filename
   
   get /api/1.1/dbdump
   - Ext: pg_dump
   
   put /api/1.1/deliveryservices/:id/safe
   - DB: Deliveryservice, DeliveryServiceRegex, Regex, Profile, Type, Tenant
   
   delete /api/1.1/deliveryservice_server/:dsId/:serverId
   - DB: DeliveryService, DeliveryServiceServer, Tenant
   
   get /api/1.1/deliveryservices/:id/health
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/capacity
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/routing
   - DB: Tenant, DeliveryService, DeliveryServiceRegex, Regex, Cdn, Type
   - Ext: Router
   
   get /api/1.1/deliveryservices/:id/state
   - DB: Tenant, DeliveryService, CDN
   - Ext: Monitor
   
   post /api/1.1/deliveryservices/request
   - Ext: Email
   
   get /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   get /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   post /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   put /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   delete /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget
   
   delete /api/1.1/divisions/name/:name
   - DB: Division, Region
   
   get /api/1.1/federations
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService
   
   post /api/1.1/federations
   put /api/1.1/federations
   delete /api/1.1/federations
   get /api/1.1/cdns/:name/federations
   get /api/1.1/cdns/:name/federations/:fedId
   post /api/1.1/cdns/:name/federations
   put /api/1.1/cdns/:name/federations/:fedId
   delete /api/1.1/cdns/:name/federations/:fedId
   get /api/1.1/federations/:fedId/users
   post /api/1.1/federations/:fedId/users
   delete /api/1.1/federations/:fedId/users/:userId
   get /api/1.1/federations/:fedId/deliveryservices
   post /api/1.1/federations/:fedId/deliveryservices
   delete /api/1.1/federations/:fedId/deliveryservices/:dsId
   get /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federation_resolvers
   delete /api/1.1/federation_resolvers/:id
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService, 
FederationResolver, FederationFederationResolver
   
   get /api/1.1/hwinfo/dtdata
   - DB: HwInfo, Server
   
   get /api/1.1/osversions
   - DB: Parameter, Server
   - Ext: file:osversions.cfg
   
   post /api/1.1/isos
   - DB: Parameter
   - Ext: mkisofs
   
   get /api/1.1/jobs
   - DB: DeliveryService, Tenant, Job
   
   get /api/1.1/jobs/:id
   - DB: DeliveryService, Job
   
   get /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/parameters/validate
   - DB: Parameter
   
   get /api/1.1/cachegroups/:id/parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:id/unassigned_parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroup/:parameter_id/parameter
   - DB: Cachegroup, CachegroupParameter
   
   get /api/1.1/cachegroupparameters
   - DB: CachegroupParameter
   
   post /api/1.1/cachegroupparameters
   - DB: Cachegroup, Parameter, ProfileParameter, CachegroupParameter
   
   delete /api/1.1/cachegroupparameters/:cachegroup_id/:parameter_id
   - DB: Cachegroup, Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:parameter_id/parameter/available
   - DB: Cachegroup, CachegroupParameter
   
   post /api/1.1/regions/:region_name/phys_locations
   - DB: PhysLocation, Region
   
   post /api/1.1/profiles/name/:profile_name/copy/:profile_copy_from
   - DB: Profile, ProfileParameter
   
   get /api/1.1/profiles/:id/export
   - DB: Profile, ProfileParameter, Parameter
   
   post /api/1.1/profiles/import
   - DB: Cdn, Profile, ProfileTypeValue, Parameter, ProfileParameter
   
   get /api/1.1/parameters/:id/profiles
   - DB: Profile, ProfileParameter
   
   get /api/1.1/parameters/:id/unassigned_profiles
   - DB: Profile, ProfileParameter
   
   post /api/1.1/divisions/:division_name/regions
   - DB: Region, Division
   
   delete /api/1.1/regions/name/:name
   - DB: Region
   

[GitHub] asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys

[GitBox]

asfgit commented on issue #2432: Add TO Go deliveryservices urlkeys
URL: https://github.com/apache/trafficcontrol/pull/2432#issuecomment-398618771
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1857/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

[GitBox]

rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table 
Endpoints in Go
URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296
 
 
   # Table Usage
   
   ```
   get /api/1.1/cdns/:name/configs/routing
   - DB: Server, Profile, Cdn, Parameter, ProfileParameter, CacheGroup, Regex, 
Type, StaticDNSEntry, DeliveryService
   
   get /api/1.1/cdns/domains
   - DB: Profile, CDN
   
   get /api/1.1/servers/:id/configfiles/ats
   get /api/1.1/profiles/:id/configfiles/ats/:filename
   get /api/1.1/servers/:id/configfiles/ats/:filename
   get /api/1.1/cdns/:id/configfiles/ats/:filename
   
   get /api/1.1/dbdump
   - Ext: pg_dump
   
   put /api/1.1/deliveryservices/:id/safe
   - DB: Deliveryservice, DeliveryServiceRegex, Regex, Profile, Type, Tenant
   
   delete /api/1.1/deliveryservice_server/:dsId/:serverId
   - DB: DeliveryService, DeliveryServiceServer, Tenant
   
   get /api/1.1/deliveryservices/:id/health
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/capacity
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/routing
   - DB: Tenant, DeliveryService, DeliveryServiceRegex, Regex, Cdn, Type
   - Ext: Router
   
   get /api/1.1/deliveryservices/:id/state
   - DB: Tenant, DeliveryService, CDN
   - Ext: Monitor
   
   post /api/1.1/deliveryservices/request
   - Ext: Email
   
   get /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   get /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   post /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   put /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   delete /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget
   
   post /api/1.1/deliveryservices/xmlId/:xmlId/urlkeys/generate
   - DB: DeliveryService, Tenant
   - Ext: Riak
   
   delete /api/1.1/divisions/name/:name
   - DB: Division, Region
   
   get /api/1.1/federations
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService
   
   post /api/1.1/federations
   put /api/1.1/federations
   delete /api/1.1/federations
   get /api/1.1/cdns/:name/federations
   get /api/1.1/cdns/:name/federations/:fedId
   post /api/1.1/cdns/:name/federations
   put /api/1.1/cdns/:name/federations/:fedId
   delete /api/1.1/cdns/:name/federations/:fedId
   get /api/1.1/federations/:fedId/users
   post /api/1.1/federations/:fedId/users
   delete /api/1.1/federations/:fedId/users/:userId
   get /api/1.1/federations/:fedId/deliveryservices
   post /api/1.1/federations/:fedId/deliveryservices
   delete /api/1.1/federations/:fedId/deliveryservices/:dsId
   get /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federation_resolvers
   delete /api/1.1/federation_resolvers/:id
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService, 
FederationResolver, FederationFederationResolver
   
   get /api/1.1/hwinfo/dtdata
   - DB: HwInfo, Server
   
   get /api/1.1/osversions
   - DB: Parameter, Server
   - Ext: file:osversions.cfg
   
   post /api/1.1/isos
   - DB: Parameter
   - Ext: mkisofs
   
   get /api/1.1/jobs
   - DB: DeliveryService, Tenant, Job
   
   get /api/1.1/jobs/:id
   - DB: DeliveryService, Job
   
   get /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/parameters/validate
   - DB: Parameter
   
   get /api/1.1/cachegroups/:id/parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:id/unassigned_parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroup/:parameter_id/parameter
   - DB: Cachegroup, CachegroupParameter
   
   get /api/1.1/cachegroupparameters
   - DB: CachegroupParameter
   
   post /api/1.1/cachegroupparameters
   - DB: Cachegroup, Parameter, ProfileParameter, CachegroupParameter
   
   delete /api/1.1/cachegroupparameters/:cachegroup_id/:parameter_id
   - DB: Cachegroup, Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:parameter_id/parameter/available
   - DB: Cachegroup, CachegroupParameter
   
   post /api/1.1/regions/:region_name/phys_locations
   - DB: PhysLocation, Region
   
   post /api/1.1/profiles/name/:profile_name/copy/:profile_copy_from
   - DB: Profile, ProfileParameter
   
   get /api/1.1/profiles/:id/export
   - DB: Profile, ProfileParameter, Parameter
   
   post /api/1.1/profiles/import
   - DB: Cdn, Profile, ProfileTypeValue, Parameter, ProfileParameter
   
   get /api/1.1/parameters/:id/profiles
   - DB: Profile, ProfileParameter
   
   get /api/1.1/parameters/:id/unassigned_profiles
   - DB: Profile, ProfileParameter
   
   post 

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #1126

[Apache Jenkins Server]

See 

[GitHub] asfgit commented on issue #2432: Add TO Go deliveryservices/id/urlkeys, xmlId/urlkeys

[GitBox]

asfgit commented on issue #2432: Add TO Go deliveryservices/id/urlkeys, 
xmlId/urlkeys
URL: https://github.com/apache/trafficcontrol/pull/2432#issuecomment-398610976
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1856/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table Endpoints in Go

[GitBox]

rob05c edited a comment on issue #2232: Rewrite Traffic Ops CRConfig Table 
Endpoints in Go
URL: https://github.com/apache/trafficcontrol/issues/2232#issuecomment-398070296
 
 
   # Table Usage
   
   ```
   get /api/1.1/cdns/:name/configs/routing
   - DB: Server, Profile, Cdn, Parameter, ProfileParameter, CacheGroup, Regex, 
Type, StaticDNSEntry, DeliveryService
   
   get /api/1.1/cdns/domains
   - DB: Profile, CDN
   
   get /api/1.1/servers/:id/configfiles/ats
   get /api/1.1/profiles/:id/configfiles/ats/:filename
   get /api/1.1/servers/:id/configfiles/ats/:filename
   get /api/1.1/cdns/:id/configfiles/ats/:filename
   
   get /api/1.1/dbdump
   - Ext: pg_dump
   
   put /api/1.1/deliveryservices/:id/safe
   - DB: Deliveryservice, DeliveryServiceRegex, Regex, Profile, Type, Tenant
   
   delete /api/1.1/deliveryservice_server/:dsId/:serverId
   - DB: DeliveryService, DeliveryServiceServer, Tenant
   
   get /api/1.1/deliveryservices/:id/health
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/capacity
   - DB: Tenant, DeliveryService
   - Ext: Monitor
   
   get /api/1.1/deliveryservices/:id/routing
   - DB: Tenant, DeliveryService, DeliveryServiceRegex, Regex, Cdn, Type
   - Ext: Router
   
   get /api/1.1/deliveryservices/:id/state
   - DB: Tenant, DeliveryService, CDN
   - Ext: Monitor
   
   post /api/1.1/deliveryservices/request
   - Ext: Email
   
   get /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   get /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   post /api/1.1/steering/:id/targets
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   put /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget, Type
   
   delete /api/1.1/steering/:id/targets/:target_id
   - DB: Tenant, DeliveryService, SteeringTarget
   
   post /api/1.1/deliveryservices/xmlId/:xmlId/urlkeys/generate
   - DB: DeliveryService, Tenant
   - Ext: Riak
   
   post 
/api/1.1/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
   - DB: DeliveryService, Tenant
   - Ext: Riak
   
   delete /api/1.1/divisions/name/:name
   - DB: Division, Region
   
   get /api/1.1/federations
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService
   
   post /api/1.1/federations
   put /api/1.1/federations
   delete /api/1.1/federations
   get /api/1.1/cdns/:name/federations
   get /api/1.1/cdns/:name/federations/:fedId
   post /api/1.1/cdns/:name/federations
   put /api/1.1/cdns/:name/federations/:fedId
   delete /api/1.1/cdns/:name/federations/:fedId
   get /api/1.1/federations/:fedId/users
   post /api/1.1/federations/:fedId/users
   delete /api/1.1/federations/:fedId/users/:userId
   get /api/1.1/federations/:fedId/deliveryservices
   post /api/1.1/federations/:fedId/deliveryservices
   delete /api/1.1/federations/:fedId/deliveryservices/:dsId
   get /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federations/:fedId/federation_resolvers
   post /api/1.1/federation_resolvers
   delete /api/1.1/federation_resolvers/:id
   - DB: TmUser, FederationTmUser, FederationDeliveryService, DeliveryService, 
FederationResolver, FederationFederationResolver
   
   get /api/1.1/hwinfo/dtdata
   - DB: HwInfo, Server
   
   get /api/1.1/osversions
   - DB: Parameter, Server
   - Ext: file:osversions.cfg
   
   post /api/1.1/isos
   - DB: Parameter
   - Ext: mkisofs
   
   get /api/1.1/jobs
   - DB: DeliveryService, Tenant, Job
   
   get /api/1.1/jobs/:id
   - DB: DeliveryService, Job
   
   get /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/user/current/jobs
   - DB: Tenant, DeliveryService, Job, TmUser
   
   post /api/1.1/parameters/validate
   - DB: Parameter
   
   get /api/1.1/cachegroups/:id/parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:id/unassigned_parameters
   - DB: Parameter, CachegroupParameter
   
   get /api/1.1/cachegroup/:parameter_id/parameter
   - DB: Cachegroup, CachegroupParameter
   
   get /api/1.1/cachegroupparameters
   - DB: CachegroupParameter
   
   post /api/1.1/cachegroupparameters
   - DB: Cachegroup, Parameter, ProfileParameter, CachegroupParameter
   
   delete /api/1.1/cachegroupparameters/:cachegroup_id/:parameter_id
   - DB: Cachegroup, Parameter, CachegroupParameter
   
   get /api/1.1/cachegroups/:parameter_id/parameter/available
   - DB: Cachegroup, CachegroupParameter
   
   post /api/1.1/regions/:region_name/phys_locations
   - DB: PhysLocation, Region
   
   post /api/1.1/profiles/name/:profile_name/copy/:profile_copy_from
   - DB: Profile, ProfileParameter
   
   get /api/1.1/profiles/:id/export
   - DB: Profile, ProfileParameter, Parameter
   
   post /api/1.1/profiles/import
   - DB: Cdn, Profile, ProfileTypeValue, Parameter, ProfileParameter
   
   get /api/1.1/parameters/:id/profiles
   - DB: 

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #1125

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1855
originally caused by:
 GitHub pull request #2187 of commit f6488c16a53ac5e19c46e4b532640b9ca38ecd84, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H28 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins6612533556758416527.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins5421316415191824808.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ sort -r
++ cut -d / -f 12
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ head -n 1
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.rMl3dlAxwT
+ ratjar=/tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 1587k0 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1444k  0  0:00:01  0:00:01 --:--:-- 1445k
+ curl -L -o /tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0400 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 74  0 --:--:-- --:--:-- --:--:--74
++ sha1sum /tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.rMl3dlAxwT/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.rMl3dlAxwT
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  

[GitHub] asfgit commented on issue #2187: updating roles and capabilities seeds

[GitBox]

asfgit commented on issue #2187: updating roles and capabilities seeds
URL: https://github.com/apache/trafficcontrol/pull/2187#issuecomment-398601066
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1855/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : incubator-trafficcontrol-PR #1854

[Apache Jenkins Server]

See 

Build failed in Jenkins: incubator-trafficcontrol-PR #1853

[Apache Jenkins Server]

See 


--
GitHub pull request #2364 of commit a6bafee664f9d38655b22d161676164573f9a393, 
no merge conflicts.
Setting status of a6bafee664f9d38655b22d161676164573f9a393 to PENDING with url 
https://builds.apache.org/job/incubator-trafficcontrol-PR/1853/ and message: 
'Build started sha1 is merged.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H34 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/incubator-trafficcontrol.git
 > git init  # 
 > timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
 > git rev-parse origin/a6bafee664f9d38655b22d161676164573f9a393^{commit} # 
 > timeout=10
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
 > git rev-parse origin/a6bafee664f9d38655b22d161676164573f9a393^{commit} # 
 > timeout=10
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > git://github.com/apache/incubator-trafficcontrol.git # timeout=10
Fetching upstream changes from 
git://github.com/apache/incubator-trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress 
 > git://github.com/apache/incubator-trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
 > git rev-parse origin/a6bafee664f9d38655b22d161676164573f9a393^{commit} # 
 > timeout=10
 > git rev-parse a6bafee664f9d38655b22d161676164573f9a393^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Archiving artifacts
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script  : export COMPOSE_HTTP_TIMEOUT=120
./bin/docker-compose -p "${BUILD_TAG}" -f 
infrastructure/docker/build/docker-compose.yml down -v
[incubator-trafficcontrol-PR] $ /bin/bash -xe /tmp/jenkins8993326276861350654.sh
+ export COMPOSE_HTTP_TIMEOUT=120
+ COMPOSE_HTTP_TIMEOUT=120
+ ./bin/docker-compose -p jenkins-incubator-trafficcontrol-PR-1853 -f 
infrastructure/docker/build/docker-compose.yml down -v
/tmp/jenkins8993326276861350654.sh: line 3: ./bin/docker-compose: No such file 
or directory
POST BUILD TASK : FAILURE
END OF POST BUILD TASK : 0

[GitHub] asfgit commented on issue #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

asfgit commented on issue #2364: Fix Traffic Ops Go to use transactions for 
deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#issuecomment-398592917
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1853/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2395: To go ds sslkeys generate

[GitBox]

asfgit commented on issue #2395: To go ds sslkeys generate
URL: https://github.com/apache/trafficcontrol/pull/2395#issuecomment-398592087
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1851/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2400: To go cdns sslkeys

[GitBox]

asfgit commented on issue #2400: To go cdns sslkeys
URL: https://github.com/apache/trafficcontrol/pull/2400#issuecomment-398591337
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1850/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2402: To go riak ping

[GitBox]

asfgit commented on issue #2402: To go riak ping
URL: https://github.com/apache/trafficcontrol/pull/2402#issuecomment-398585650
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1849/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2405: Add Traffic Ops Golang user/current

[GitBox]

asfgit commented on issue #2405: Add Traffic Ops Golang user/current
URL: https://github.com/apache/trafficcontrol/pull/2405#issuecomment-398584719
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1848/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-test-master-build #2

[Apache Jenkins Server]

See 


--
Started by user dangogh
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init 
 >  # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 75d6735362fa79c8fe4e0e4cd17849c2683680b9 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 75d6735362fa79c8fe4e0e4cd17849c2683680b9
Commit message: "Fix DSR Origin resolution"
First time build. Skipping changelog.
[trafficcontrol-test-master-build] $ /bin/bash 
/tmp/jenkins7752832041372886655.sh
+ proj=tc16259
+ cd infrastructure/docker/build
+ docker-compose -p tc16259 build
Traceback (most recent call last):
  File "/usr/local/bin/docker-compose", line 7, in 
from compose.cli.main import main
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/main.py", line 45, 
in 
from .command import get_config_from_options
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/command.py", line 
17, in 
from .docker_client import docker_client
  File "/usr/local/lib/python2.7/dist-packages/compose/cli/docker_client.py", 
line 12, in 
from docker.utils.config import home_dir
ImportError: No module named config
+ exit 1
Build step 'Execute shell' marked build as failure
Archiving artifacts

[GitHub] asfgit commented on issue #2409: Add TO Go /user/id/deliveryservices/available

[GitBox]

asfgit commented on issue #2409: Add TO Go /user/id/deliveryservices/available
URL: https://github.com/apache/trafficcontrol/pull/2409#issuecomment-398576422
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1847/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2415: Add TO Go deliveryservice_matches

[GitBox]

asfgit commented on issue #2415: Add TO Go deliveryservice_matches
URL: https://github.com/apache/trafficcontrol/pull/2415#issuecomment-398574851
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1846/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2421: Add TO Go deliveryservices/sslkeys/delete

[GitBox]

asfgit commented on issue #2421: Add TO Go deliveryservices/sslkeys/delete
URL: https://github.com/apache/trafficcontrol/pull/2421#issuecomment-398573454
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1845/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2432: Add TO Go deliveryservices/id/urlkeys

[GitBox]

asfgit commented on issue #2432: Add TO Go deliveryservices/id/urlkeys
URL: https://github.com/apache/trafficcontrol/pull/2432#issuecomment-398572469
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1844/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2428: Utility to update TO profile from ATS6 to ATS7

[GitBox]

rawlinp commented on a change in pull request #2428: Utility to update TO 
profile from ATS6 to ATS7
URL: https://github.com/apache/trafficcontrol/pull/2428#discussion_r196598144
 
 

 ##
 File path: traffic_ops/install/bin/convert_profile/convert_profile_test.go
 ##
 @@ -0,0 +1,108 @@
+// Unit Tests for Profile Conversion Utility
 
 Review comment:
   missing the Apache License header


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rob05c commented on issue #2364: Fix Traffic Ops Go to use transactions for 
deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#issuecomment-398566757
 
 
   @alficles Fixed weasel issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2433: Fix DSR Origin resolution

[GitBox]

asfgit commented on issue #2433: Fix DSR Origin resolution
URL: https://github.com/apache/trafficcontrol/pull/2433#issuecomment-398564900
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1843/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2382: To go dnsseckeys generate

[GitBox]

asfgit commented on issue #2382: To go dnsseckeys generate
URL: https://github.com/apache/trafficcontrol/pull/2382#issuecomment-398563878
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1842/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #2433: Fix DSR Origin resolution

[GitBox]

mitchell852 closed pull request #2433: Fix DSR Origin resolution
URL: https://github.com/apache/trafficcontrol/pull/2433
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
 
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
index 3c5352e8d..a42ded891 100644
--- 
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
+++ 
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
@@ -156,7 +156,7 @@
 Required
 Must 
start with http:// or https:// and be followed by a valid hostname with an 
optional port (no trailing slash)
 Current 
Value: [ {{dsCurrent.orgServerFqdn}} ]
-View Details
+View Details
 
 
 
diff --git 
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
 
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
index 090829574..c0fb63d31 100644
--- 
a/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
+++ 
b/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html
@@ -156,7 +156,7 @@
 Required
 Must 
start with http:// or https:// and be followed by a valid hostname with an 
optional port (no trailing slash)
 Current 
Value: [ {{dsCurrent.orgServerFqdn}} ]
-View Details
+View Details
 
 
 
diff --git 
a/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/FormEditDeliveryServiceRequestController.js
 
b/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/FormEditDeliveryServiceRequestController.js
index 79ed64d14..31ce61df1 100644
--- 
a/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/FormEditDeliveryServiceRequestController.js
+++ 
b/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/FormEditDeliveryServiceRequestController.js
@@ -17,12 +17,12 @@
  * under the License.
  */
 
-var FormEditDeliveryServiceRequestController = 
function(deliveryServiceRequest, deliveryService, type, types, $scope, $state, 
$stateParams, $controller, $uibModal, $anchorScroll, $q, $location, 
locationUtils, deliveryServiceService, deliveryServiceRequestService, 
messageModel, userModel) {
+var FormEditDeliveryServiceRequestController = 
function(deliveryServiceRequest, deliveryService, origin, type, types, $scope, 
$state, $stateParams, $controller, $uibModal, $anchorScroll, $q, $location, 
locationUtils, deliveryServiceService, deliveryServiceRequestService, 
messageModel, userModel) {
 
$scope.dsRequest = deliveryServiceRequest[0];

// extends the FormDeliveryServiceController to inherit common methods
-   angular.extend(this, $controller('FormDeliveryServiceController', { 
deliveryService: $scope.dsRequest.deliveryService, dsCurrent: deliveryService, 
type: type, types: types, $scope: $scope }));
+   angular.extend(this, $controller('FormDeliveryServiceController', { 
deliveryService: $scope.dsRequest.deliveryService, dsCurrent: deliveryService, 
origin: origin, type: type, types: types, $scope: $scope }));
 
$scope.changeType = $scope.dsRequest.changeType;
 
@@ -259,5 +259,5 @@ var FormEditDeliveryServiceRequestController = 
function(deliveryServiceRequest,
 
 };
 
-FormEditDeliveryServiceRequestController.$inject = ['deliveryServiceRequest', 
'deliveryService', 'type', 'types', '$scope', '$state', '$stateParams', 
'$controller', '$uibModal', '$anchorScroll', '$q', '$location', 
'locationUtils', 'deliveryServiceService', 'deliveryServiceRequestService', 
'messageModel', 'userModel'];
+FormEditDeliveryServiceRequestController.$inject = ['deliveryServiceRequest', 
'deliveryService', 'origin', 'type', 'types', '$scope', '$state', 
'$stateParams', '$controller', '$uibModal', '$anchorScroll', '$q', '$location', 
'locationUtils', 'deliveryServiceService', 'deliveryServiceRequestService', 
'messageModel', 'userModel'];
 module.exports = FormEditDeliveryServiceRequestController;
diff --git 
a/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/index.js 
b/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/index.js
index 9702bad5f..a81aa1900 100644
--- 
a/traffic_portal/app/src/modules/private/deliveryServiceRequests/edit/index.js
+++ 

[GitHub] rawlinp opened a new pull request #2433: Fix DSR Origin resolution

[GitBox]

rawlinp opened a new pull request #2433: Fix DSR Origin resolution
URL: https://github.com/apache/trafficcontrol/pull/2433
 
 
   This fixes a bug introduced by #2401 that broke Delivery Service Requests in 
Traffic Portal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : incubator-trafficcontrol-PR-rat #1111

[Apache Jenkins Server]

See 

[GitHub] dangogh closed pull request #2431: Changed version on DeliveryServicesResponse to fix TM build

[GitBox]

dangogh closed pull request #2431: Changed version on DeliveryServicesResponse 
to fix TM build
URL: https://github.com/apache/trafficcontrol/pull/2431
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lib/go-tc/deliveryservices.go b/lib/go-tc/deliveryservices.go
index 8b556e945..f63d1a4a5 100644
--- a/lib/go-tc/deliveryservices.go
+++ b/lib/go-tc/deliveryservices.go
@@ -26,12 +26,12 @@ const DefaultRoutingName = "cdn"
 //
 // GetDeliveryServiceResponse is deprecated use DeliveryServicesResponse...
 type GetDeliveryServiceResponse struct {
-   Response []DeliveryServiceV13 `json:"response"`
+   Response []DeliveryService `json:"response"`
 }
 
 // DeliveryServicesResponse ...
 type DeliveryServicesResponse struct {
-   Response []DeliveryService `json:"response"`
+   Response []DeliveryServiceV13 `json:"response"`
 }
 
 // CreateDeliveryServiceResponse ...
diff --git a/traffic_ops/client/v13/deliveryservice.go 
b/traffic_ops/client/v13/deliveryservice.go
index 3791f6650..93dc29f48 100644
--- a/traffic_ops/client/v13/deliveryservice.go
+++ b/traffic_ops/client/v13/deliveryservice.go
@@ -30,7 +30,7 @@ func (to *Session) DeliveryServices() 
([]tc.DeliveryServiceV13, error) {
 }
 
 func (to *Session) GetDeliveryServices() ([]tc.DeliveryServiceV13, ReqInf, 
error) {
-   var data tc.GetDeliveryServiceResponse
+   var data tc.DeliveryServicesResponse
reqInf, err := get(to, deliveryServicesEp(), )
if err != nil {
return nil, reqInf, err
@@ -47,7 +47,7 @@ func (to *Session) DeliveryServicesByServer(id int) 
([]tc.DeliveryServiceV13, er
 }
 
 func (to *Session) GetDeliveryServicesByServer(id int) 
([]tc.DeliveryServiceV13, ReqInf, error) {
-   var data tc.GetDeliveryServiceResponse
+   var data tc.DeliveryServicesResponse
reqInf, err := get(to, deliveryServicesByServerEp(strconv.Itoa(id)), 
)
if err != nil {
return nil, reqInf, err
@@ -64,7 +64,7 @@ func (to *Session) DeliveryService(id string) 
(*tc.DeliveryServiceV13, error) {
 }
 
 func (to *Session) GetDeliveryService(id string) (*tc.DeliveryServiceV13, 
ReqInf, error) {
-   var data tc.GetDeliveryServiceResponse
+   var data tc.DeliveryServicesResponse
reqInf, err := get(to, deliveryServiceEp(id), )
if err != nil {
return nil, reqInf, err


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #2432: Add TO Go deliveryservices/id/urlkeys

[GitBox]

rob05c opened a new pull request #2432: Add TO Go deliveryservices/id/urlkeys
URL: https://github.com/apache/trafficcontrol/pull/2432
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2431: Changed version on DeliveryServicesResponse to fix TM build

[GitBox]

asfgit commented on issue #2431: Changed version on DeliveryServicesResponse to 
fix TM build
URL: https://github.com/apache/trafficcontrol/pull/2431#issuecomment-398544926
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2431: Changed version on DeliveryServicesResponse to fix TM build

[GitBox]

asfgit commented on issue #2431: Changed version on DeliveryServicesResponse to 
fix TM build
URL: https://github.com/apache/trafficcontrol/pull/2431#issuecomment-398544642
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rivasj opened a new pull request #2431: Changed version on DeliveryServicesResponse to fix TM build

[GitBox]

rivasj opened a new pull request #2431: Changed version on 
DeliveryServicesResponse to fix TM build
URL: https://github.com/apache/trafficcontrol/pull/2431
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2430: change `incubator-trafficcontrol` to `trafficcontrol`

[GitBox]

dangogh opened a new pull request #2430: change `incubator-trafficcontrol` to 
`trafficcontrol`
URL: https://github.com/apache/trafficcontrol/pull/2430
 
 
   @jrushford changed grove already and @knutsel changed the docs.  This 
changes the remaining components to reference `trafficcontrol` instead of 
`incubator-trafficcontrol`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #1110

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1840
originally caused by:
 GitHub pull request #2428 of commit 9d1344436e6081b02e3114b7269c685b88df8b10, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H28 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins1977916543926495675.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7244351341589413679.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ sort -r
++ head -n 1
++ cut -d / -f 12
++ awk -F '"' '{print $2}'
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.xB5CNtVyoC
+ ratjar=/tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
13 1587k   13  214k0 0   269k  0  0:00:05 --:--:--  0:00:05  
269k100 1587k  100 1587k0 0  1692k  0 --:--:-- --:--:-- --:--:-- 
1692k
+ curl -L -o /tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 78  0 --:--:-- --:--:-- --:--:--78
++ sha1sum /tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.xB5CNtVyoC/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.xB5CNtVyoC
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=1
+ [[ 1 != 0 ]]
+ echo '1 Unknown Licenses'
1 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/traffic_ops/install/bin/convert_profile/convert_profile_test.go

*
+ exit 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
[Fast Archiver] Compressed 484.00 KB of artifacts by 79.3% relative to 

[GitHub] asfgit commented on issue #2428: Utility to update TO profile from ATS6 to ATS7

[GitBox]

asfgit commented on issue #2428: Utility to update TO profile from ATS6 to ATS7
URL: https://github.com/apache/trafficcontrol/pull/2428#issuecomment-398532867
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1840/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : incubator-trafficcontrol-traffic_ops-test #706

[Apache Jenkins Server]

See 

[GitHub] jhg03a opened a new issue #2429: Autocreate self-signed SSL certificates

[GitBox]

jhg03a opened a new issue #2429: Autocreate self-signed SSL certificates
URL: https://github.com/apache/trafficcontrol/issues/2429
 
 
   When creating a new Delivery service or modifying the type to support HTTPS, 
a default self-signed certificate should be created.  This could be triggered 
by a miss when looking up the DS in riak.  This specifically prevents 
situations where a CDN could be queued by a second user unaware of a DS change 
in flight.  This is not prevented by DS Requests since you must fulfill the DS 
before you could create SSL certs.  If this situation happens and ORT runs an 
update before SSL Keys are in place, a syncds will fail.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2428: Conversion Utility to modify Traffic Ops profile based on conversion rules

[GitBox]

asfgit commented on issue #2428: Conversion Utility to modify Traffic Ops 
profile based on conversion rules
URL: https://github.com/apache/trafficcontrol/pull/2428#issuecomment-398526945
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited opened a new pull request #2428: Conversion Utility to modify Traffic Ops profile based on conversion …

[GitBox]

limited opened a new pull request #2428: Conversion Utility to modify Traffic 
Ops profile based on conversion …
URL: https://github.com/apache/trafficcontrol/pull/2428
 
 
   Includes conversion rules to convert an ATS6 profile into an ATS7 profile


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited closed pull request #2427: Clean up docs, incubator and conf.py for PDF

[GitBox]

limited closed pull request #2427: Clean up docs, incubator and conf.py for PDF
URL: https://github.com/apache/trafficcontrol/pull/2427
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/source/_static/bad.png b/docs/source/_static/bad.png
new file mode 100644
index 0..485e3da77
Binary files /dev/null and b/docs/source/_static/bad.png differ
diff --git a/docs/source/_static/clock-black.png 
b/docs/source/_static/clock-black.png
new file mode 100644
index 0..4783c01bd
Binary files /dev/null and b/docs/source/_static/clock-black.png differ
diff --git a/docs/source/_static/clock.png b/docs/source/_static/clock.png
new file mode 100644
index 0..a4a5f1f73
Binary files /dev/null and b/docs/source/_static/clock.png differ
diff --git a/docs/source/_static/good.png b/docs/source/_static/good.png
new file mode 100644
index 0..84d96cde8
Binary files /dev/null and b/docs/source/_static/good.png differ
diff --git a/docs/source/_static/graph.png b/docs/source/_static/graph.png
new file mode 100644
index 0..4502a2d14
Binary files /dev/null and b/docs/source/_static/graph.png differ
diff --git a/docs/source/_static/info.png b/docs/source/_static/info.png
new file mode 100644
index 0..3e1125c8d
Binary files /dev/null and b/docs/source/_static/info.png differ
diff --git a/docs/source/_static/warning.png b/docs/source/_static/warning.png
new file mode 100644
index 0..57cccda1c
Binary files /dev/null and b/docs/source/_static/warning.png differ
diff --git a/docs/source/admin/traffic_ops/default_profiles.rst 
b/docs/source/admin/traffic_ops/default_profiles.rst
index 9b629be7e..75a71d290 100644
--- a/docs/source/admin/traffic_ops/default_profiles.rst
+++ b/docs/source/admin/traffic_ops/default_profiles.rst
@@ -24,7 +24,7 @@ Traffic Ops - Default Profiles
 Traffic Ops has the concept of :ref:`rl-working-with-profiles`, which are an 
integral function within Traffic Ops.  To get started, a set of default Traffic 
Ops profiles need to be imported into Traffic Ops
 to get started to support Traffic Control components Traffic Router, Traffic 
Monitor, and Apache Traffic Server.
 
-`Download Default Profiles from here 
`_ 
+`Download Default Profiles from here 
`_ 
 
 .. _rl-to-profiles-min-needed:
 
diff --git a/docs/source/admin/traffic_ops/using.rst 
b/docs/source/admin/traffic_ops/using.rst
index c7273e5e8..97e20cbf6 100644
--- a/docs/source/admin/traffic_ops/using.rst
+++ b/docs/source/admin/traffic_ops/using.rst
@@ -13,11 +13,11 @@
 .. limitations under the License.
 ..
 
-.. |graph| image:: ../../../../traffic_ops/app/public/images/graph.png
-.. |info| image:: ../../../../traffic_ops/app/public/images/info.png
-.. |checkmark| image:: ../../../../traffic_ops/app/public/images/good.png
-.. |X| image:: ../../../../traffic_ops/app/public/images/bad.png
-.. |clock| image:: ../../../../traffic_ops/app/public/images/clock-black.png
+.. |graph| image:: ../../_static/graph.png
+.. |info| image:: ../../_static//info.png
+.. |checkmark| image:: ../../_static/good.png
+.. |X| image:: ../../_static/bad.png
+.. |clock| image:: ../../_static/clock-black.png
 
 Traffic Ops - Using
 %%%
diff --git a/docs/source/admin/traffic_server.rst 
b/docs/source/admin/traffic_server.rst
index 828cb4706..d4b817e25 100644
--- a/docs/source/admin/traffic_server.rst
+++ b/docs/source/admin/traffic_server.rst
@@ -25,11 +25,11 @@ Installing Traffic Server
 
 #. Build the astats RPM using the appropriate version number: ::
 
-
https://github.com/apache/incubator-trafficcontrol/tree//traffic_server
+https://github.com/apache/trafficcontrol/tree//traffic_server
 
Sample link: ::
 
- 
https://github.com/apache/incubator-trafficcontrol/tree/master/traffic_server
+ https://github.com/apache/trafficcontrol/tree/master/traffic_server
 
 #.  Install Traffic Server and astats: ::
 
diff --git a/docs/source/admin/traffic_stats.rst 
b/docs/source/admin/traffic_stats.rst
index a1d20b39c..d484f59d2 100644
--- a/docs/source/admin/traffic_stats.rst
+++ b/docs/source/admin/traffic_stats.rst
@@ -25,7 +25,7 @@ Installation
 **Installing Traffic Stats:**
 
- See the `downloads 
`_ page for Traffic 
Control to get the latest release.
-   - Follow our build `intructions 
`_ to 
generate an RPM.
+   - Follow our build `intructions 
`_ to generate an 
RPM.
- Copy the RPM to your server
- perform the following command: 

[GitHub] knutsel opened a new pull request #2427: Clean up docs, incubator and conf.py for PDF

[GitBox]

knutsel opened a new pull request #2427: Clean up docs, incubator and conf.py 
for PDF
URL: https://github.com/apache/trafficcontrol/pull/2427
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #705

[Apache Jenkins Server]

See 


Changes:

[friede] try 1

[friede] Trying clean conf.py

[friede] Trying clean conf.py - 1

[friede] rm _themes and _templates

--
[...truncated 1.36 MB...]
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/deliveryservice_matches.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/deliveryservice_regex.t 
... ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | 
unit_1 | #   Failed test 'exact match for JSON Pointer 
"/response/2/server"'
unit_1 | #   at /opt/traffic_ops/app/t/api/1.2/deliveryservice_server.t 
line 55.
unit_1 | #  got: '1300'
unit_1 | # expected: '600'
unit_1 | # Looks like you failed 1 test of 28.
unit_1 | /opt/traffic_ops/app/t/api/1.2/deliveryservice_server.t 
.. 
unit_1 | Dubious, test returned 1 (wstat 256, 0x100)
unit_1 | Failed 1/28 subtests 
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/deliveryservice_stats.t 
... ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/deliveryservice_user.t 
 ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/division.t 
 ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/federation.t 
.. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/federation_external.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Federation.pm line 148.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Federation.pm line 148.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Federation.pm line 148.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Federation.pm line 148.
unit_1 | /opt/traffic_ops/app/t/api/1.2/federation_internal.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Iso.pm line 264.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Iso.pm line 271.
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Iso.pm line 278.
unit_1 | /opt/traffic_ops/app/t/api/1.2/iso.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/job.t 
. ok
unit_1 

[GitHub] knutsel closed pull request #2425: Change grove imports and other scripts/files from using 'incubator-trafficcontrol'

[GitBox]

knutsel closed pull request #2425: Change grove imports and other scripts/files 
from using 'incubator-trafficcontrol'
URL: https://github.com/apache/trafficcontrol/pull/2425
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/grove/README.md b/grove/README.md
index 80062d2d0..d258d25f4 100644
--- a/grove/README.md
+++ b/grove/README.md
@@ -39,13 +39,13 @@ go get golang.org/x/net/ipv6
   * golang.org/x must be updated when the Go compiler is, so we treat it as 
part of the compiler, rather than vendoring it like other dependencies, to 
avoid breaking updating to newer compilers than we internally work with. If you 
know what you're doing, feel free to skip this step, or omit `rm` of old `go 
get` source and packages.
 3. Clone this repository into your GOPATH.
 ```bash
-mkdir -p $GOPATH/src/github.com/apache/incubator-trafficcontrol
-cd $GOPATH/src/github.com/apache/incubator-trafficcontrol
-git clone https://github.com/apache/incubator-trafficcontrol/grove
+mkdir -p $GOPATH/src/github.com/apache/trafficcontrol
+cd $GOPATH/src/github.com/apache/trafficcontrol
+git clone https://github.com/apache/trafficcontrol/grove
 ```
 4. Build the application
 ```bash
-cd $GOPATH/src/github.com/apache/incubator-trafficcontrol/grove
+cd $GOPATH/src/github.com/apache/trafficcontrol/grove
 go build
 ```
 6. Install and configure an RPM development environment
@@ -103,7 +103,7 @@ The config file has the following fields:
 
 The remap rules file is specified in the [config file](#configuration).
 
-Note there exists a tool for generating remap rules from [Traffic 
Control](https://github.com/apache/incubator-trafficcontrol), available 
[here](https://github.com/apache/incubator-trafficcontrol/grove/tree/master/grovetccfg).
+Note there exists a tool for generating remap rules from [Traffic 
Control](https://github.com/apache/trafficcontrol), available 
[here](https://github.com/apache/trafficcontrol/grove/tree/master/grovetccfg).
 
 The remap rules file is JSON of the following form:
 
diff --git a/grove/build/grove.spec b/grove/build/grove.spec
index abe34d2ee..6ed87f095 100644
--- a/grove/build/grove.spec
+++ b/grove/build/grove.spec
@@ -18,7 +18,7 @@ License: Apache License, Version 2.0
 Group: Base System/System Tools
 Prefix: /usr/sbin/%{name}
 Source: %{_sourcedir}/%{name}-%{version}.tgz
-URL: https://github.com/apache/incubator-trafficcontrol/%{name}
+URL: https://github.com/apache/trafficcontrol/%{name}
 Distribution: CentOS Linux
 Vendor: Apache Software Foundation
 BuildRoot: %{buildroot}
diff --git a/grove/cache/handler.go b/grove/cache/handler.go
index 0b4e15e49..a1ff499cd 100644
--- a/grove/cache/handler.go
+++ b/grove/cache/handler.go
@@ -22,17 +22,17 @@ import (
"time"
"unsafe"
 
-   "github.com/apache/incubator-trafficcontrol/grove/cachedata"
-   "github.com/apache/incubator-trafficcontrol/grove/plugin"
+   "github.com/apache/trafficcontrol/grove/cachedata"
+   "github.com/apache/trafficcontrol/grove/plugin"
 
-   "github.com/apache/incubator-trafficcontrol/grove/remap"
-   "github.com/apache/incubator-trafficcontrol/grove/remapdata"
-   "github.com/apache/incubator-trafficcontrol/grove/rfc"
-   "github.com/apache/incubator-trafficcontrol/grove/stat"
-   "github.com/apache/incubator-trafficcontrol/grove/thread"
-   "github.com/apache/incubator-trafficcontrol/grove/web"
+   "github.com/apache/trafficcontrol/grove/remap"
+   "github.com/apache/trafficcontrol/grove/remapdata"
+   "github.com/apache/trafficcontrol/grove/rfc"
+   "github.com/apache/trafficcontrol/grove/stat"
+   "github.com/apache/trafficcontrol/grove/thread"
+   "github.com/apache/trafficcontrol/grove/web"
 
-   "github.com/apache/incubator-trafficcontrol/lib/go-log"
+   "github.com/apache/trafficcontrol/lib/go-log"
 )
 
 type HandlerPointer struct {
diff --git a/grove/cache/responder.go b/grove/cache/responder.go
index a211f0ef2..60b9b39a9 100644
--- a/grove/cache/responder.go
+++ b/grove/cache/responder.go
@@ -18,13 +18,13 @@ import (
"net/http"
"time"
 
-   "github.com/apache/incubator-trafficcontrol/grove/cachedata"
-   "github.com/apache/incubator-trafficcontrol/grove/plugin"
-   "github.com/apache/incubator-trafficcontrol/grove/remapdata"
-   "github.com/apache/incubator-trafficcontrol/grove/stat"
-   "github.com/apache/incubator-trafficcontrol/grove/web"
+   "github.com/apache/trafficcontrol/grove/cachedata"
+   "github.com/apache/trafficcontrol/grove/plugin"
+   "github.com/apache/trafficcontrol/grove/remapdata"
+   "github.com/apache/trafficcontrol/grove/stat"
+   "github.com/apache/trafficcontrol/grove/web"
 
-   

[GitHub] asfgit commented on issue #2382: To go dnsseckeys generate

[GitBox]

asfgit commented on issue #2382: To go dnsseckeys generate
URL: https://github.com/apache/trafficcontrol/pull/2382#issuecomment-398496510
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1839/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2421: Add TO Go deliveryservices/sslkeys/delete

[GitBox]

asfgit commented on issue #2421: Add TO Go deliveryservices/sslkeys/delete
URL: https://github.com/apache/trafficcontrol/pull/2421#issuecomment-398494730
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1838/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2425: Change grove imports and other scripts/files from using 'incubator-trafficcontrol'

[GitBox]

asfgit commented on issue #2425: Change grove imports and other scripts/files 
from using 'incubator-trafficcontrol'
URL: https://github.com/apache/trafficcontrol/pull/2425#issuecomment-398493135
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1837/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jhowar201 opened a new issue #2426: Revalidate builds invalid regexes on ANY_MAP Delivery Services

[GitBox]

jhowar201 opened a new issue #2426: Revalidate builds invalid regexes on 
ANY_MAP Delivery Services 
URL: https://github.com/apache/trafficcontrol/issues/2426
 
 
   Revalidate via TP builds useing the URL regex based on origin on the 
delivery service and for ANY_MAP type there is no origin configured. The 
revalidation config files are placed on disk with no origin beginning with a /. 
Attempting to enter the entire origin FQDN manually into the regex in TP will 
still prepend a / to the URL in the revalidate file when placed on cache for 
processing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford opened a new pull request #2425: Change grove imports and other scripts/files from using 'incubator-trafficcontrol'

[GitBox]

jrushford opened a new pull request #2425: Change grove imports and other 
scripts/files from using 'incubator-trafficcontrol'
URL: https://github.com/apache/trafficcontrol/pull/2425
 
 
   The PR modifies all files in the grove directory chaning any imports and 
other text references to 'incubator-trafficcontrol' to just 'trafficcontrol'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2424: Remove _templates and _themes from docs.

[GitBox]

asfgit commented on issue #2424: Remove _templates and _themes from docs.
URL: https://github.com/apache/trafficcontrol/pull/2424#issuecomment-398459401
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1836/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] knutsel opened a new pull request #2424: Remove _templates and _themes from docs.

[GitBox]

knutsel opened a new pull request #2424: Remove _templates and _themes from 
docs.
URL: https://github.com/apache/trafficcontrol/pull/2424
 
 
   For local, you have to now do 
   
   ```
   pip install sphinx_rtd_theme
   ```
   
   This makes it work on readthedocs.io


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rawlinp commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196475489
 
 

 ##
 File path: lib/go-tc/deliveryservices.go
 ##
 @@ -205,6 +216,213 @@ type DeliveryServiceNullableV13 struct {
TRRequestHeaders *string  
`json:"trRequestHeaders,omitempty"`
 }
 
+// NewDeliveryServiceNullableV13FromV12 creates a new V13 DS from a V12 DS, 
filling new fields with appropriate defaults.
+func NewDeliveryServiceNullableV13FromV12(ds DeliveryServiceNullableV12) 
DeliveryServiceNullableV13 {
+   newDS := DeliveryServiceNullableV13{DeliveryServiceNullableV12: ds}
+   newDS.Sanitize()
+   return newDS
+}
+
+func (ds *DeliveryServiceNullableV12) Sanitize() {
+   if ds.GeoLimitCountries != nil {
+   *ds.GeoLimitCountries = 
strings.ToUpper(strings.Replace(*ds.GeoLimitCountries, " ", "", -1))
+   }
+   if ds.ProfileID != nil && *ds.ProfileID == -1 {
+   ds.ProfileID = nil
+   }
+   if ds.EdgeHeaderRewrite != nil && 
strings.TrimSpace(*ds.EdgeHeaderRewrite) == "" {
+   ds.EdgeHeaderRewrite = nil
+   }
+   if ds.MidHeaderRewrite != nil && 
strings.TrimSpace(*ds.MidHeaderRewrite) == "" {
+   ds.MidHeaderRewrite = nil
+   }
+   if ds.RoutingName == nil || *ds.RoutingName == "" {
+   ds.RoutingName = util.StrPtr(DefaultRoutingName)
+   }
+}
+
+func getTypeName(tx *sql.Tx, id int) (string, bool, error) {
+   name := ""
+   if err := tx.QueryRow(`SELECT name from type where id=$1`, 
id).Scan(); err != nil {
+   if err == sql.ErrNoRows {
+   return "", false, nil
+   }
+   return "", false, errors.New("querying type name: " + 
err.Error())
+   }
+   return name, true, nil
+}
+
+func requiredIfMatchesTypeName(patterns []string, typeName string) 
func(interface{}) error {
+   return func(value interface{}) error {
+   switch v := value.(type) {
+   case *int:
+   if v != nil {
+   return nil
+   }
+   case *bool:
+   if v != nil {
+   return nil
+   }
+   case *string:
+   if v != nil {
+   return nil
+   }
+   case *float64:
+   if v != nil {
+   return nil
+   }
+   default:
+   return fmt.Errorf("validation failure: unknown type 
%T", value)
+   }
+   pattern := strings.Join(patterns, "|")
+   var err error
+   var match bool
+   if typeName != "" {
+   match, err = regexp.MatchString(pattern, typeName)
+   if match {
+   return fmt.Errorf("is required if type is 
'%s'", typeName)
+   }
+   }
+   return err
+   }
+}
+
+// util.JoinErrs(errs).Error()
+
+func (ds *DeliveryServiceNullableV12) validateTypeFields(tx *sql.Tx) error {
+   // Validate the TypeName related fields below
+   var typeName string
+   var err error
+   DNSRegexType := "^DNS.*$"
+   HTTPRegexType := "^HTTP.*$"
+   SteeringRegexType := "^STEERING.*$"
+   if ds.TypeID == nil {
+   return errors.New("missing type")
+   }
+   typeName, ok, err := getTypeName(tx, *ds.TypeID)
+   if err != nil {
+   return errors.New("getting type name: " + err.Error())
+   }
+   if !ok {
+   return errors.New("type not found")
+   }
+   errs := validation.Errors{
+   "initialDispersion": validation.Validate(ds.InitialDispersion,
+   
validation.By(requiredIfMatchesTypeName([]string{HTTPRegexType}, typeName))),
+   "ipv6RoutingEnabled": validation.Validate(ds.IPV6RoutingEnabled,
+   
validation.By(requiredIfMatchesTypeName([]string{SteeringRegexType, 
DNSRegexType, HTTPRegexType}, typeName))),
+   "missLat": validation.Validate(ds.MissLat,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "missLong": validation.Validate(ds.MissLong,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "multiSiteOrigin": validation.Validate(ds.MultiSiteOrigin,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "orgServerFqdn": validation.Validate(ds.OrgServerFQDN,
+   

[GitHub] asfgit commented on issue #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

asfgit commented on issue #2364: Fix Traffic Ops Go to use transactions for 
deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#issuecomment-398437071
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1835/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

[GitBox]

rawlinp commented on issue #2407: Edge retrieval from origin - Configuring 
go_direct from traffic ops. [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398433002
 
 
   I don't know what's worse, new DS types or a new DS field that doesn't apply 
to/conflicts with certain types.
   
   That is a lot of DS types, but we'd still be staying with current DS type 
"families" (HTTP/DNS) rather than adding a whole new family like ANY_MAP. So 
maybe it wouldn't be that bad.
   
   > At what point are we implementing a cross product here? Seems like we
   should separate the underlying variables into separate settings, HTTP|DNS,
   disk|ram, mid|no-mid, direct|no-direct, etc. But that might be a bigger
   project.
   
   I like the idea, but that seems like a 2.0 DS API to me. DS types seem like 
a good idea because it hides a lot of these settings from the user so they 
mostly just need to know what kind of content they're serving (e.g VOD, linear, 
etc). So adding some new types for this would jive w/ the existing type-based 
implementation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196461033
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go
 ##
 @@ -133,35 +96,45 @@ func getDSTenantIDByName(db *sql.DB, name string) (*int, 
bool, error) {
 }
 
 // GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
-func (ds *TODeliveryServiceV12) GetXMLID(db *sqlx.DB) (string, bool, error) {
+func (ds *TODeliveryServiceV12) GetXMLID(tx *sql.Tx) (string, bool, error) {
if ds.ID == nil {
return "", false, errors.New("missing ID")
}
+   return GetXMLID(tx, *ds.ID)
+}
+
+// GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
+func GetXMLID(tx *sql.Tx, id int) (string, bool, error) {
xmlID := ""
-   if err := db.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, ds.ID).Scan(); err != nil {
+   if err := tx.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, id).Scan(); err != nil {
if err == sql.ErrNoRows {
return "", false, nil
}
-   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", *ds.ID, err)
+   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", id, err)
}
return xmlID, true, nil
 }
 
 // IsTenantAuthorized checks that the user is authorized for both the delivery 
service's existing tenant, and the new tenant they're changing it to (if 
different).
-func (ds *TODeliveryServiceV12) IsTenantAuthorized(user auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
-   return isTenantAuthorized(user, db, )
+func (ds *TODeliveryServiceV12) IsTenantAuthorized(user *auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
+   tx, err := db.DB.Begin() // must be last, MUST not return an error if 
this suceeds, without closing the tx
+   if err != nil {
+   return false, errors.New("beginning transaction: " + 
err.Error())
+   }
+   defer dbhelpers.FinishTx(tx, util.BoolPtr(true))
+   return isTenantAuthorized(user, tx, 
(*tc.DeliveryServiceNullableV12)(ds))
 }
 
-func isTenantAuthorized(user auth.CurrentUser, db *sqlx.DB, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
+func isTenantAuthorized(user *auth.CurrentUser, tx *sql.Tx, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
if ds.ID == nil && ds.XMLID == nil {
return false, errors.New("delivery service has no ID or XMLID")
}
 
existingID, err := (*int)(nil), error(nil)
 
 Review comment:
   Changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited edited a comment on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

[GitBox]

limited edited a comment on issue #2407: Edge retrieval from origin - 
Configuring go_direct from traffic ops. [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398420385
 
 
   Not a bad idea for a new DS Type. 
   
   We could do (not suggesting actual naming, just the semantics)
   * HTTP_LIVE_NATL_GODIRECT
   * DNS_LIVE_NATL_GODIRECT
   * HTTP_GODIRECT
   * DNS_GODIRECT
   
   This will bring us up to 14 DS types. Should we be concerned that we are 
slowly growing too many DS types?
   
   Also agree to bring it over to the dev list, but can we get some small form 
of consensus here first so we can bring a complete proposal over there?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196448115
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go
 ##
 @@ -133,35 +96,45 @@ func getDSTenantIDByName(db *sql.DB, name string) (*int, 
bool, error) {
 }
 
 // GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
-func (ds *TODeliveryServiceV12) GetXMLID(db *sqlx.DB) (string, bool, error) {
+func (ds *TODeliveryServiceV12) GetXMLID(tx *sql.Tx) (string, bool, error) {
if ds.ID == nil {
return "", false, errors.New("missing ID")
}
+   return GetXMLID(tx, *ds.ID)
+}
+
+// GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
+func GetXMLID(tx *sql.Tx, id int) (string, bool, error) {
xmlID := ""
-   if err := db.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, ds.ID).Scan(); err != nil {
+   if err := tx.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, id).Scan(); err != nil {
if err == sql.ErrNoRows {
return "", false, nil
}
-   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", *ds.ID, err)
+   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", id, err)
}
return xmlID, true, nil
 }
 
 // IsTenantAuthorized checks that the user is authorized for both the delivery 
service's existing tenant, and the new tenant they're changing it to (if 
different).
-func (ds *TODeliveryServiceV12) IsTenantAuthorized(user auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
-   return isTenantAuthorized(user, db, )
+func (ds *TODeliveryServiceV12) IsTenantAuthorized(user *auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
+   tx, err := db.DB.Begin() // must be last, MUST not return an error if 
this suceeds, without closing the tx
+   if err != nil {
+   return false, errors.New("beginning transaction: " + 
err.Error())
+   }
+   defer dbhelpers.FinishTx(tx, util.BoolPtr(true))
+   return isTenantAuthorized(user, tx, 
(*tc.DeliveryServiceNullableV12)(ds))
 }
 
-func isTenantAuthorized(user auth.CurrentUser, db *sqlx.DB, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
+func isTenantAuthorized(user *auth.CurrentUser, tx *sql.Tx, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
if ds.ID == nil && ds.XMLID == nil {
return false, errors.New("delivery service has no ID or XMLID")
}
 
existingID, err := (*int)(nil), error(nil)
 
 Review comment:
   Correct, I didn't change it. I agree. In fact, using a single declaration 
syntax everywhere is even better, 
   ```
   existingID := (*int)(nil)
   err := error(nil)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196448115
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go
 ##
 @@ -133,35 +96,45 @@ func getDSTenantIDByName(db *sql.DB, name string) (*int, 
bool, error) {
 }
 
 // GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
-func (ds *TODeliveryServiceV12) GetXMLID(db *sqlx.DB) (string, bool, error) {
+func (ds *TODeliveryServiceV12) GetXMLID(tx *sql.Tx) (string, bool, error) {
if ds.ID == nil {
return "", false, errors.New("missing ID")
}
+   return GetXMLID(tx, *ds.ID)
+}
+
+// GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
+func GetXMLID(tx *sql.Tx, id int) (string, bool, error) {
xmlID := ""
-   if err := db.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, ds.ID).Scan(); err != nil {
+   if err := tx.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, id).Scan(); err != nil {
if err == sql.ErrNoRows {
return "", false, nil
}
-   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", *ds.ID, err)
+   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", id, err)
}
return xmlID, true, nil
 }
 
 // IsTenantAuthorized checks that the user is authorized for both the delivery 
service's existing tenant, and the new tenant they're changing it to (if 
different).
-func (ds *TODeliveryServiceV12) IsTenantAuthorized(user auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
-   return isTenantAuthorized(user, db, )
+func (ds *TODeliveryServiceV12) IsTenantAuthorized(user *auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
+   tx, err := db.DB.Begin() // must be last, MUST not return an error if 
this suceeds, without closing the tx
+   if err != nil {
+   return false, errors.New("beginning transaction: " + 
err.Error())
+   }
+   defer dbhelpers.FinishTx(tx, util.BoolPtr(true))
+   return isTenantAuthorized(user, tx, 
(*tc.DeliveryServiceNullableV12)(ds))
 }
 
-func isTenantAuthorized(user auth.CurrentUser, db *sqlx.DB, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
+func isTenantAuthorized(user *auth.CurrentUser, tx *sql.Tx, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
if ds.ID == nil && ds.XMLID == nil {
return false, errors.New("delivery service has no ID or XMLID")
}
 
existingID, err := (*int)(nil), error(nil)
 
 Review comment:
   Correct, I didn't change it. I agree. In fact, using a single declaration 
syntax everywhere is even better, ```
   existingID := (*int)(nil)
   err := error(nil)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

rob05c commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196446230
 
 

 ##
 File path: lib/go-tc/deliveryservices.go
 ##
 @@ -205,6 +216,213 @@ type DeliveryServiceNullableV13 struct {
TRRequestHeaders *string  
`json:"trRequestHeaders,omitempty"`
 }
 
+// NewDeliveryServiceNullableV13FromV12 creates a new V13 DS from a V12 DS, 
filling new fields with appropriate defaults.
+func NewDeliveryServiceNullableV13FromV12(ds DeliveryServiceNullableV12) 
DeliveryServiceNullableV13 {
+   newDS := DeliveryServiceNullableV13{DeliveryServiceNullableV12: ds}
+   newDS.Sanitize()
+   return newDS
+}
+
+func (ds *DeliveryServiceNullableV12) Sanitize() {
+   if ds.GeoLimitCountries != nil {
+   *ds.GeoLimitCountries = 
strings.ToUpper(strings.Replace(*ds.GeoLimitCountries, " ", "", -1))
+   }
+   if ds.ProfileID != nil && *ds.ProfileID == -1 {
+   ds.ProfileID = nil
+   }
+   if ds.EdgeHeaderRewrite != nil && 
strings.TrimSpace(*ds.EdgeHeaderRewrite) == "" {
+   ds.EdgeHeaderRewrite = nil
+   }
+   if ds.MidHeaderRewrite != nil && 
strings.TrimSpace(*ds.MidHeaderRewrite) == "" {
+   ds.MidHeaderRewrite = nil
+   }
+   if ds.RoutingName == nil || *ds.RoutingName == "" {
+   ds.RoutingName = util.StrPtr(DefaultRoutingName)
+   }
+}
+
+func getTypeName(tx *sql.Tx, id int) (string, bool, error) {
+   name := ""
+   if err := tx.QueryRow(`SELECT name from type where id=$1`, 
id).Scan(); err != nil {
+   if err == sql.ErrNoRows {
+   return "", false, nil
+   }
+   return "", false, errors.New("querying type name: " + 
err.Error())
+   }
+   return name, true, nil
+}
+
+func requiredIfMatchesTypeName(patterns []string, typeName string) 
func(interface{}) error {
+   return func(value interface{}) error {
+   switch v := value.(type) {
+   case *int:
+   if v != nil {
+   return nil
+   }
+   case *bool:
+   if v != nil {
+   return nil
+   }
+   case *string:
+   if v != nil {
+   return nil
+   }
+   case *float64:
+   if v != nil {
+   return nil
+   }
+   default:
+   return fmt.Errorf("validation failure: unknown type 
%T", value)
+   }
+   pattern := strings.Join(patterns, "|")
 
 Review comment:
   I didn't write, just moved


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

[GitBox]

rawlinp commented on issue #2407: Edge retrieval from origin - Configuring 
go_direct from traffic ops. [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398413475
 
 
   Ok I think I understand now. ATS will go through all the parents first 
before going directly to the origin when `go_direct=true`. This does still 
smell like a new Delivery Service type that we should have, rather than having 
the operator manually set go_direct=true and having to know which DS types that 
setting is incompatible with. I think that makes both the code and the 
interface simpler...but we should probably discuss this on the mailing list to 
get more feedback.
   
   Also, note that Delivery Service API changes need to be made in the Go 
version now that it's been rewritten. The ATS Config API changes can still be 
in Perl because that hasn't been rewritten yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196160170
 
 

 ##
 File path: 
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservicesv12.go
 ##
 @@ -133,35 +96,45 @@ func getDSTenantIDByName(db *sql.DB, name string) (*int, 
bool, error) {
 }
 
 // GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
-func (ds *TODeliveryServiceV12) GetXMLID(db *sqlx.DB) (string, bool, error) {
+func (ds *TODeliveryServiceV12) GetXMLID(tx *sql.Tx) (string, bool, error) {
if ds.ID == nil {
return "", false, errors.New("missing ID")
}
+   return GetXMLID(tx, *ds.ID)
+}
+
+// GetXMLID loads the DeliveryService's xml_id from the database, from the ID. 
Returns whether the delivery service was found, and any error.
+func GetXMLID(tx *sql.Tx, id int) (string, bool, error) {
xmlID := ""
-   if err := db.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, ds.ID).Scan(); err != nil {
+   if err := tx.QueryRow(`SELECT xml_id FROM deliveryservice where id = 
$1`, id).Scan(); err != nil {
if err == sql.ErrNoRows {
return "", false, nil
}
-   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", *ds.ID, err)
+   return "", false, fmt.Errorf("querying xml_id for delivery 
service ID '%v': %v", id, err)
}
return xmlID, true, nil
 }
 
 // IsTenantAuthorized checks that the user is authorized for both the delivery 
service's existing tenant, and the new tenant they're changing it to (if 
different).
-func (ds *TODeliveryServiceV12) IsTenantAuthorized(user auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
-   return isTenantAuthorized(user, db, )
+func (ds *TODeliveryServiceV12) IsTenantAuthorized(user *auth.CurrentUser, db 
*sqlx.DB) (bool, error) {
+   tx, err := db.DB.Begin() // must be last, MUST not return an error if 
this suceeds, without closing the tx
+   if err != nil {
+   return false, errors.New("beginning transaction: " + 
err.Error())
+   }
+   defer dbhelpers.FinishTx(tx, util.BoolPtr(true))
+   return isTenantAuthorized(user, tx, 
(*tc.DeliveryServiceNullableV12)(ds))
 }
 
-func isTenantAuthorized(user auth.CurrentUser, db *sqlx.DB, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
+func isTenantAuthorized(user *auth.CurrentUser, tx *sql.Tx, ds 
*tc.DeliveryServiceNullableV12) (bool, error) {
if ds.ID == nil && ds.XMLID == nil {
return false, errors.New("delivery service has no ID or XMLID")
}
 
existingID, err := (*int)(nil), error(nil)
 
 Review comment:
   I realize you didn't change this, but is this just a confusing way to say:
   
   var existingID *int
   var err error
   
   ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196157510
 
 

 ##
 File path: lib/go-tc/deliveryservices.go
 ##
 @@ -205,6 +216,213 @@ type DeliveryServiceNullableV13 struct {
TRRequestHeaders *string  
`json:"trRequestHeaders,omitempty"`
 }
 
+// NewDeliveryServiceNullableV13FromV12 creates a new V13 DS from a V12 DS, 
filling new fields with appropriate defaults.
+func NewDeliveryServiceNullableV13FromV12(ds DeliveryServiceNullableV12) 
DeliveryServiceNullableV13 {
+   newDS := DeliveryServiceNullableV13{DeliveryServiceNullableV12: ds}
+   newDS.Sanitize()
+   return newDS
+}
+
+func (ds *DeliveryServiceNullableV12) Sanitize() {
+   if ds.GeoLimitCountries != nil {
+   *ds.GeoLimitCountries = 
strings.ToUpper(strings.Replace(*ds.GeoLimitCountries, " ", "", -1))
+   }
+   if ds.ProfileID != nil && *ds.ProfileID == -1 {
+   ds.ProfileID = nil
+   }
+   if ds.EdgeHeaderRewrite != nil && 
strings.TrimSpace(*ds.EdgeHeaderRewrite) == "" {
+   ds.EdgeHeaderRewrite = nil
+   }
+   if ds.MidHeaderRewrite != nil && 
strings.TrimSpace(*ds.MidHeaderRewrite) == "" {
+   ds.MidHeaderRewrite = nil
+   }
+   if ds.RoutingName == nil || *ds.RoutingName == "" {
+   ds.RoutingName = util.StrPtr(DefaultRoutingName)
+   }
+}
+
+func getTypeName(tx *sql.Tx, id int) (string, bool, error) {
+   name := ""
+   if err := tx.QueryRow(`SELECT name from type where id=$1`, 
id).Scan(); err != nil {
+   if err == sql.ErrNoRows {
+   return "", false, nil
+   }
+   return "", false, errors.New("querying type name: " + 
err.Error())
+   }
+   return name, true, nil
+}
+
+func requiredIfMatchesTypeName(patterns []string, typeName string) 
func(interface{}) error {
+   return func(value interface{}) error {
+   switch v := value.(type) {
+   case *int:
+   if v != nil {
+   return nil
+   }
+   case *bool:
+   if v != nil {
+   return nil
+   }
+   case *string:
+   if v != nil {
+   return nil
+   }
+   case *float64:
+   if v != nil {
+   return nil
+   }
+   default:
+   return fmt.Errorf("validation failure: unknown type 
%T", value)
+   }
+   pattern := strings.Join(patterns, "|")
+   var err error
+   var match bool
+   if typeName != "" {
+   match, err = regexp.MatchString(pattern, typeName)
+   if match {
+   return fmt.Errorf("is required if type is 
'%s'", typeName)
+   }
+   }
+   return err
+   }
+}
+
+// util.JoinErrs(errs).Error()
+
+func (ds *DeliveryServiceNullableV12) validateTypeFields(tx *sql.Tx) error {
+   // Validate the TypeName related fields below
+   var typeName string
+   var err error
+   DNSRegexType := "^DNS.*$"
+   HTTPRegexType := "^HTTP.*$"
+   SteeringRegexType := "^STEERING.*$"
+   if ds.TypeID == nil {
+   return errors.New("missing type")
+   }
+   typeName, ok, err := getTypeName(tx, *ds.TypeID)
+   if err != nil {
+   return errors.New("getting type name: " + err.Error())
+   }
+   if !ok {
+   return errors.New("type not found")
+   }
+   errs := validation.Errors{
+   "initialDispersion": validation.Validate(ds.InitialDispersion,
+   
validation.By(requiredIfMatchesTypeName([]string{HTTPRegexType}, typeName))),
+   "ipv6RoutingEnabled": validation.Validate(ds.IPV6RoutingEnabled,
+   
validation.By(requiredIfMatchesTypeName([]string{SteeringRegexType, 
DNSRegexType, HTTPRegexType}, typeName))),
+   "missLat": validation.Validate(ds.MissLat,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "missLong": validation.Validate(ds.MissLong,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "multiSiteOrigin": validation.Validate(ds.MultiSiteOrigin,
+   
validation.By(requiredIfMatchesTypeName([]string{DNSRegexType, HTTPRegexType}, 
typeName))),
+   "orgServerFqdn": validation.Validate(ds.OrgServerFQDN,
+   

[GitHub] alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use transactions for deliveryservices, sslkeys, urisigning

[GitBox]

alficles commented on a change in pull request #2364: Fix Traffic Ops Go to use 
transactions for deliveryservices, sslkeys, urisigning
URL: https://github.com/apache/trafficcontrol/pull/2364#discussion_r196155014
 
 

 ##
 File path: lib/go-tc/deliveryservices.go
 ##
 @@ -205,6 +216,213 @@ type DeliveryServiceNullableV13 struct {
TRRequestHeaders *string  
`json:"trRequestHeaders,omitempty"`
 }
 
+// NewDeliveryServiceNullableV13FromV12 creates a new V13 DS from a V12 DS, 
filling new fields with appropriate defaults.
+func NewDeliveryServiceNullableV13FromV12(ds DeliveryServiceNullableV12) 
DeliveryServiceNullableV13 {
+   newDS := DeliveryServiceNullableV13{DeliveryServiceNullableV12: ds}
+   newDS.Sanitize()
+   return newDS
+}
+
+func (ds *DeliveryServiceNullableV12) Sanitize() {
+   if ds.GeoLimitCountries != nil {
+   *ds.GeoLimitCountries = 
strings.ToUpper(strings.Replace(*ds.GeoLimitCountries, " ", "", -1))
+   }
+   if ds.ProfileID != nil && *ds.ProfileID == -1 {
+   ds.ProfileID = nil
+   }
+   if ds.EdgeHeaderRewrite != nil && 
strings.TrimSpace(*ds.EdgeHeaderRewrite) == "" {
+   ds.EdgeHeaderRewrite = nil
+   }
+   if ds.MidHeaderRewrite != nil && 
strings.TrimSpace(*ds.MidHeaderRewrite) == "" {
+   ds.MidHeaderRewrite = nil
+   }
+   if ds.RoutingName == nil || *ds.RoutingName == "" {
+   ds.RoutingName = util.StrPtr(DefaultRoutingName)
+   }
+}
+
+func getTypeName(tx *sql.Tx, id int) (string, bool, error) {
+   name := ""
+   if err := tx.QueryRow(`SELECT name from type where id=$1`, 
id).Scan(); err != nil {
+   if err == sql.ErrNoRows {
+   return "", false, nil
+   }
+   return "", false, errors.New("querying type name: " + 
err.Error())
+   }
+   return name, true, nil
+}
+
+func requiredIfMatchesTypeName(patterns []string, typeName string) 
func(interface{}) error {
+   return func(value interface{}) error {
+   switch v := value.(type) {
+   case *int:
+   if v != nil {
+   return nil
+   }
+   case *bool:
+   if v != nil {
+   return nil
+   }
+   case *string:
+   if v != nil {
+   return nil
+   }
+   case *float64:
+   if v != nil {
+   return nil
+   }
+   default:
+   return fmt.Errorf("validation failure: unknown type 
%T", value)
+   }
+   pattern := strings.Join(patterns, "|")
 
 Review comment:
   I think this works with the patterns provided, but if we're going to be 
intentionally passing regexes in here, it'll be easier to see that it's right 
if we parenthesize the incoming patterns.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

[GitBox]

limited commented on issue #2407: Edge retrieval from origin - Configuring 
go_direct from traffic ops. [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398382728
 
 
   The edges should automatically switch over to using the origins when the 
mids (i.e. parents) are down. Down meaning "unavailable" in trafficserver 
terminology, not related to Traffic Ops state. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich closed pull request #2416: Update changelog for Release 2.2

[GitBox]

dewrich closed pull request #2416: Update changelog for Release 2.2
URL: https://github.com/apache/trafficcontrol/pull/2416
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f976a40d0..52eb755a2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,11 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
 ### Added
+- Backup Edge Cache group: If the matched group in the CZF is not available, 
this list of backup edge cache group configured via Traffic Ops API can be used 
as backup. In the event of all backup edge cache groups not available, GEO 
location can be optionally used as further backup. APIs detailed here 
[here](http://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_ops_api/v12/cachegroup_fallbacks.html)
+
+
+## [2.2.0] - 2018-06-07
+### Added
 - Per-DeliveryService Routing Names: you can now choose a Delivery Service's 
Routing Name (rather than a hardcoded "tr" or "edge" name). This might require 
a few pre-upgrade steps detailed 
[here](http://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/migration_from_20_to_22.html#per-deliveryservice-routing-names)
 - [Delivery Service 
Requests](http://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ds_requests.html#ds-requests):
 When enabled, delivery service requests are created when ALL users attempt to 
create, update or delete a delivery service. This allows users with higher 
level permissions to review delivery service changes for completeness and 
accuracy before deploying the changes.
 - Traffic Ops Golang Proxy Endpoints
@@ -39,11 +44,12 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
   - /api/1.3/statuses `(GET,POST,PUT,DELETE)`
   - /api/1.3/system/info `(GET)`
   - /api/1.3/types `(GET,POST,PUT,DELETE)`
-- Fair Queuing Pacing: Using the FQ Pacing Rate parameter in Delivery Services 
allows operators to limit the rate of individual sessions to the edge cache. 
This feature requires a Trafficserver RPM containing the fq_pacing experimental 
plugin AND setting 'fq' as the default Linux qdisc in sysctl. 
+- Fair Queuing Pacing: Using the FQ Pacing Rate parameter in Delivery Services 
allows operators to limit the rate of individual sessions to the edge cache. 
This feature requires a Trafficserver RPM containing the fq_pacing experimental 
plugin AND setting 'fq' as the default Linux qdisc in sysctl.
 - Traffic Ops rpm changed to remove world-read permission from configuration 
files.
-- Backup Edge Cache group: If the matched group in the CZF is not available, 
this list of backup edge cache group configured via Traffic Ops API can be used 
as backup. In the event of all backup edge cache groups not available, GEO 
location can be optionally used as further backup. APIs detailed here 
[here](http://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_ops_api/v12/cachegroup_fallbacks.html)
+<
 
 ### Changed
 - Reformatted this CHANGELOG file to the keep-a-changelog format
 
-[Unreleased]: 
https://github.com/apache/incubator-trafficcontrol/compare/RELEASE-2.1.0...HEAD
+[Unreleased]: 
https://github.com/apache/trafficcontrol/compare/RELEASE-2.2.0...HEAD
+[2.2.0]: 
https://github.com/apache/trafficcontrol/compare/RELEASE-2.1.0...RELEASE-2.2.0


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Vijay-1 commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. [WIP]

[GitBox]

Vijay-1 commented on issue #2407: Edge retrieval from origin - Configuring 
go_direct from traffic ops. [WIP]
URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-398358915
 
 
   @rawlinp 
   Right now it is hard coded as false in parent.config for DS of types other 
than HTTP_LIVE, HTTP_NO_CACHE, DNS_LIVE and hence for such delivery services, 
if there occurs a problem in the network / in the Mids and they become 
unreachable / offline, all the requests fail because of this hard coded 
GO_DIRECT setting.
   
   By making this configurable, we are giving a choice to the operators to 
fetch directly from origin under such scenarios.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services