date:20191030

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1616

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[ocket] Match traffic stats response to perl if not data is available 
(#4051)


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H38 (ubuntu xenial) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision e64d6ab70d2e2f59cfaa0faf0a49b04847f17cd7 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e64d6ab70d2e2f59cfaa0faf0a49b04847f17cd7
Commit message: "Match traffic stats response to perl if not data is available 
(#4051)"
 > git rev-list --no-walk c02dfaa01286c14204a6f4af43340546923ed7fe # timeout=10
[trafficcontrol-traffic_ops-test] $ /bin/bash /tmp/jenkins159697269021641.sh
docker-compose version 1.24.1, build 4667896
docker-py version: 3.7.2
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-trafficcontrol-traffic_ops-test-1616
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1616 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1616 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
Build step 'Execute shell' marked build as failure

[GitHub] [trafficcontrol] ocket8888 closed issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket closed issue #4045: Requests to cache_stats endpoint returns Internal 
Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 closed issue #4021: TP Dashboard - request to deliveryservice_stats enpoint returns 500 internal server error

2019-10-30 Thread GitBox

ocket closed issue #4021: TP Dashboard - request to deliveryservice_stats 
enpoint returns 500 internal server error
URL: https://github.com/apache/trafficcontrol/issues/4021
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #4051: Match traffic stats response to perl if not data is available

2019-10-30 Thread GitBox

ocket merged pull request #4051: Match traffic stats response to perl if 
not data is available
URL: https://github.com/apache/trafficcontrol/pull/4051
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1615

2019-10-30 Thread Apache Jenkins Server

See

[GitHub] [trafficcontrol] ocket8888 merged pull request #4042: Foreign key err handling regex was not catching tables with _'s

2019-10-30 Thread GitBox

ocket merged pull request #4042: Foreign key err handling regex was not 
catching tables with _'s
URL: https://github.com/apache/trafficcontrol/pull/4042
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 closed issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

2019-10-30 Thread GitBox

ocket closed issue #4033: To: INternal server error when server capability 
associated with Server/ds is deleted
URL: https://github.com/apache/trafficcontrol/issues/4033
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #4051: Match traffic stats response to perl if not data is available

2019-10-30 Thread GitBox

asf-ci commented on issue #4051: Match traffic stats response to perl if not 
data is available
URL: https://github.com/apache/trafficcontrol/pull/4051#issuecomment-548143018
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4679/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4679

2019-10-30 Thread Apache Jenkins Server

See

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4051: Match traffic stats response to perl if not data is available

2019-10-30 Thread GitBox

mhoppa opened a new pull request #4051: Match traffic stats response to perl if 
not data is available
URL: https://github.com/apache/trafficcontrol/pull/4051
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR fixes #4045 AND #4021 
   
   On the rewrite of cache_stats and deliveryservice_stats when influxdb 
returns a result with no series we return a 500 error.
   
   In Perl implementation if no data is being returned it returns a 200 status 
with series excluded and zero valued summary.
   
   This PR aligns the Go endpoints to match Perl implementation
   
   There is no tests as there is no Influxdb or traffic stats in API tests.
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Traffic Ops
   
   
   ## What is the best way to verify this PR?
   
   Build traffic ops with access to environment where traffic stats and 
influxdb is configured.
   
   Make a request to both endpoints `cache_stats` and `deliveryservice_stats` 
in a time period you know there is no metrics. The endpoint should return 200 
response with zero valued summary and exclude the series.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] I have explained why tests are unnecessary
   - [x] I have explained why documentation is unnecessary
   - [x] This PR does not includes an update to CHANGELOG.md 
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4046: Improve docs

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r340877458
 
 

 ##
 File path: docs/source/admin/traffic_router.rst
 ##
 @@ -577,11 +577,11 @@ What You Need
 
.. seealso:: See :ref:`tr-profile` for details.
 
-#. Deep Caching enabled on one or more HTTP :term:`Delivery Service`\ s (i.e. 
'Deep Caching' field on the :term:`Delivery Service` details page (under 
:guilabel:`Advanced Options`) set to ``ALWAYS``)
+#. Deep Caching enabled on one or more HTTP :term:`Delivery Services` (i.e. 
'Deep Caching' field on the :term:`Delivery Service` details page (under 
:guilabel:`Advanced Options`) set to ``ALWAYS``)
 
 How it Works
 
-Deep Coverage Zone routing is very similar to that of regular Coverage Zone 
routing, except that the :abbr:`DCZF (Deep Coverage Zone File)` is preferred 
over the regular :abbr:`CZF (Coverage Zone File)` for :term:`Delivery Service`\ 
s with Deep Caching enabled. If the client requests a Deep Caching-enabled 
:term:`Delivery Service` and their IP address gets a "hit" in the :abbr:`DCZF 
(Deep Coverage Zone File)`, Traffic Router will attempt to route that client to 
one of the available "deep" :term:`cache server` s in the client's 
corresponding zone. If there are no "deep" :term:`cache server` s available for 
a client's request, Traffic Router will fall back to the regular :abbr:`CZF 
(Coverage Zone File)` and continue regular :abbr:`CZF (Coverage Zone File)` 
routing from there.
+Deep Coverage Zone routing is very similar to that of regular Coverage Zone 
routing, except that the :abbr:`DCZF (Deep Coverage Zone File)` is preferred 
over the regular :abbr:`CZF (Coverage Zone File)` for :term:`Delivery Services` 
with Deep Caching enabled. If the client requests a Deep Caching-enabled 
:term:`Delivery Service` and their IP address gets a "hit" in the :abbr:`DCZF 
(Deep Coverage Zone File)`, Traffic Router will attempt to route that client to 
one of the available "deep" :term:`cache server` s in the client's 
corresponding zone. If there are no "deep" :term:`cache server` s available for 
a client's request, Traffic Router will fall back to the regular :abbr:`CZF 
(Coverage Zone File)` and continue regular :abbr:`CZF (Coverage Zone File)` 
routing from there.
 
 Review comment:
   this:
   ```rst
   :term:`cache server` s ...
   ```
   appears twice in here. I don't think that's something you did, but it could 
be fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4046: Improve docs

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r340874928
 
 

 ##
 File path: docs/source/admin/quick_howto/ciab.rst
 ##
 @@ -237,7 +237,7 @@ Multiple optional containers may be combined by using a 
shell alias:
 
 VNC Server
 --
-The TightVNC optional container provides a basic lightweight window manager 
(fluxbox), Firefox browser, xterm, and a few other utilities within the 
CDN-In-A-Box "tcnet" bridge network. This can be very helpful for quick 
demonstrations of CDN-in-a-Box that require the use of real container network 
:abbr:`FQDN (Fully Qualified Domain Name)`\ s and full X.509 validation.
+The TightVNC optional container provides a basic lightweight window manager 
(fluxbox), Firefox browser, xterm, and a few other utilities within the 
CDN-In-A-Box "tcnet" bridge network. This can be very helpful for quick 
demonstrations of CDN-in-a-Box that require the use of real container network 
:abbr:`FQDN (Fully Qualified Domain Name)s` and full X.509 validation.
 
 Review comment:
   Plurals are allowed in `term`s, but not in `abbr`s, I'm afraid.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 opened a new issue #4050: Quick How-to page for MSO references dead UI

2019-10-30 Thread GitBox

ocket opened a new issue #4050: Quick How-to page for MSO references dead UI
URL: https://github.com/apache/trafficcontrol/issues/4050
 
 
   ## I'm submitting a ...
   - bug report
   
   ## Traffic Control components affected ...
   - Documentation
   
   ## Current behavior:
   The "Quick How-To" page _Configuring Multi-Site Origins_ has screenshots of 
and instructions for the now-removed Traffic Ops UI.
   
   ## Expected / new behavior:
   Any and all UI instructions and/or screenshots should only pertain to the 
only supported and documented UI: Traffic Portal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4035: TP: adds the ability to 
add/remove required server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r340868743
 
 

 ##
 File path: traffic_portal/app/src/common/api/DeliveryServiceService.js
 ##
 @@ -81,6 +81,41 @@ var DeliveryServiceService = function(Restangular, $http, 
$q, locationUtils, htt
 return deferred.promise;
 };
 
+this.getServerCapabilities = function(id) {
+return $http.get(ENV.api['root'] + 
'deliveryservices_required_capabilities', { params: { deliveryServiceID: id } 
}).then(
+function (result) {
+return result.data.response;
+},
+function (err) {
+throw err;
+}
+)
+};
+
+this.addServerCapability = function(deliveryServiceId, capabilityName) {
+return $http.post(ENV.api['root'] + 
'deliveryservices_required_capabilities', { deliveryServiceID: 
deliveryServiceId, requiredCapability: capabilityName}).then(
+function(result) {
+return result.data;
+},
+function(err) {
+messageModel.setMessages(err.data.alerts, false);
 
 Review comment:
   I know that we don't do this anywhere else, but since errors can occur at a 
lower level than the application layer, this `err` may not be an HTTP response 
at all. According to [the `$http` 
docs](https://docs.angularjs.org/api/ng/service/$http#$http-returns), you can 
check `err.status` is greater than zero to determine that. Or you could just 
check that `err.data` and `err.data.alerts` are both defined, since you 
probably want to check the latter in either case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4035: TP: adds the ability to 
add/remove required server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r340864715
 
 

 ##
 File path: docs/source/admin/quick_howto/server_capabililty.rst
 ##
 @@ -38,4 +38,19 @@ Users with the Operations or Admin :term:`Role` can 
associate one or more server
 
Example Server Capabilities for a Server Listing
 
+Assigning a Required Server Capability to a Delivery Service
+
+Users with the Operations or Admin :term:`Role` can associate one or more 
required server capabilities with a :term:`delivery service` by navigating to a 
:term:`delivery service` via :menuselection:`Services --> Delivery Services` 
and using the context menu for the :term:`delivery services` table and 
selecting :menuselection:`Manage Required Server Capabilities` or by navigating 
to :menuselection:`Services --> Delivery Services --> Delivery Service --> More 
--> Manage Required Server Capabilities`.
+
+Adding a required server capability to a :term:`delivery service` with ensure 
two things:
 
 Review comment:
   *will


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4035: TP: adds the ability to 
add/remove required server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r340872048
 
 

 ##
 File path: 
traffic_portal/app/src/common/modules/table/deliveryServices/TableDeliveryServicesController.js
 ##
 @@ -337,13 +337,9 @@ var TableDeliveryServicesController = 
function(deliveryServices, $anchorScroll,
 },
 null, // Divider
 {
-text: 'Manage Targets',
 
 Review comment:
   we're not managing targets in TP anymore?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4035: TP: adds the ability to 
add/remove required server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r340863956
 
 

 ##
 File path: docs/source/admin/quick_howto/server_capabililty.rst
 ##
 @@ -18,7 +18,7 @@
 **
 Manage Server Capabilities
 **
-Server capabilities are designed to enable users with the "operator" 
:term:`role` ("operators") to control the flow of :term:`delivery service` 
traffic through :term:`cache servers` (:term:`Edge` or :term:`Mid`) with ONLY 
the required capabilities. For example, :term:`delivery services` that serve 
large binary files should only be routed to :term:`cache servers` with 
sufficient disk cache. Currently, this can be controlled at the 
:term:`Edge-tier` where system operators can explicitly assign only 
:term:`Edge-tier caches` with sufficient disk cache to the :term:`delivery 
service`. However, the operators do not have control of the :term:`Mid-tier` 
and cannot dictate which :term:`Mid-tier caches` are qualified to serve these 
large binary files. This will cause a problem if a :term:`Mid-tier cache` with 
insufficient disk cache is asked to serve the large binary files.
+Server capabilities are designed to enable users with the Operations or Admin 
:term:`Role` to control the flow of :term:`delivery service` traffic through  
ONLY the :term:`cache servers` (:term:`Edge` or :term:`Mid`) that have the 
required capabilities. For example, :term:`delivery services` designed to serve 
large binary files should only have requests routed to :term:`cache servers` 
with sufficient disk cache. Currently, this can be controlled at the 
:term:`Edge-tier` where system operators can explicitly assign only 
:term:`Edge-tier caches` with sufficient disk cache to the :term:`delivery 
service`. However, operators do not have control of :term:`Mid-tier cache` 
assignments and cannot dictate which :term:`Mid-tier caches` are qualified to 
serve these large binary files. This will cause a problem if a :term:`Mid-tier 
cache` with insufficient disk cache is asked to serve the :term:`delivery 
services` large binary files.
 
 Review comment:
   ```rst
   Stress should be indicated like *this* or - for higher stress - like 
**this**, but not like THIS.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4035: TP: adds the ability to
add/remove required server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r340863486

##
File path: CHANGELOG.md
##
@@ -59,9 +59,9 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
- In Traffic Portal, all tables now include a 'CSV' link to enable the export
of table data in CSV format.
- Pylint configuration now enforced (present in [a file in the Python client
directory](./traffic_control/clients/python/pylint.rc))
- Added an optional SMTP server configuration to the TO configuration file,
api now has unused abilitiy to send emails
-- In Traffic Portal, added the ability to create, view and delete server
capabilities as associate those server capabilities with servers.
- Traffic Monitor now has "gbps" calculated stat, allowing operators to
monitor bandwidth in Gbps.
- Added an API 1.4 endpoint, /api/1.4/deliveryservices_required_capabilities,
to create, read, and delete associations between a delivery service and a
required capability.
+- In Traffic Portal, added the ability to create, view and delete server
capabilities and associate those server capabilities with servers and delivery
services. See
[blueprint](https://github.com/apache/trafficcontrol/blob/master/blueprints/server-capabilitites.md)

Review comment:
Bit of a nit, but links like this should always be relative (i.e.
`./blueprints/server-capabilities.md`) so that they always point to the version
at which they're being read.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

2019-10-30 Thread GitBox

ocket commented on issue #4044: Ensure server_capability can only be 
assigned to edges or mids
URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548113005
 
 
   Lmk when the "TP part" is done and I'll take off the WIP label.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4033: To: INternal server error when server capability associated with Server/ds is deleted

2019-10-30 Thread GitBox

mitchell852 commented on issue #4033: To: INternal server error when server 
capability associated with Server/ds is deleted
URL: https://github.com/apache/trafficcontrol/issues/4033#issuecomment-548109736
 
 
   this is a bug, not an improvement. deleting a server capability that is 
assigned to a server or a ds should result in a 400 Bad Request (i think this 
is normal functionality) or a 409 like @ocket suggested if you want to do 
it better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

2019-10-30 Thread GitBox

mhoppa commented on issue #4044: Ensure server_capability can only be assigned 
to edges or mids
URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548108648
 
 
   need to do TP part here as well 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

2019-10-30 Thread GitBox

mhoppa commented on issue #4038: TP, TO: server capabilities are allowed to be 
assigned to any servers which are not mid or edge
URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-548108511
 
 
   sure!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

2019-10-30 Thread GitBox

mitchell852 commented on issue #4038: TP, TO: server capabilities are allowed 
to be assigned to any servers which are not mid or edge
URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-548107948
 
 
   @mhoppa - you want to do both the TP and TO API parts? If you do the TP part 
search for `serverUtils.isCache` that's how i test if a server is a cache or 
not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

mhoppa commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548107205
 
 
   sounds good Ill make the change to deliveryservice_stats as well 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548106633
 
 
   That sounds fine to me. Influx giving back no data doesn't necessarily mean 
it's encountering problems, just that maybe it doesn't have any data.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

mhoppa commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548103751
 
 
   @ocket since we are rewriting the Perl implementations I think we keep 
the same behavior when there is no data and return 200 with no data. Are you 
okay with that ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-30 Thread GitBox

asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new 
letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#issuecomment-548101561
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4678/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4678

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[matthew_jackson] TP Delivery Service Generate SSL update, new letsencrypt 
generate and

[matthew_jackson] Added API for dns challenges and setup DNS Challenge calls to 
LE

[matthew_jackson] DNS Challenge update

[matthew_jackson] Traffic Router updated to watch for new DNS Challenge TXT 
Records and

[matthew_jackson] updated for TXT record clean up

[matthew_jackson] added email field for LE configuration, updated renewal 
functionality,

[matthew_jackson] added autorenewal functionality

[matthew_jackson] Autorenewal and documentation

[matthew_jackson] Made CSR not required for LE certs, fixed cert encoding

[matthew_jackson] autorenew, formatted email, documentation, async workflow and 
logs to

[matthew_jackson] minor updates and SMTP code relocation

[matthew_jackson] minor update so certs created before this update show in the 
UI as

[matthew_jackson] merge with other SMTP config

[matthew_jackson] updates per comments

[matthew_jackson] updates per comments

[matthew_jackson] Updates per comments

[matthew_jackson] Vendored in lego dependency


--
GitHub pull request #3534 of commit 1410f2787729f79e690f608016f7625cdc26a71c, 
no merge conflicts.
Running as SYSTEM
Setting status of 1410f2787729f79e690f608016f7625cdc26a71c to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4678/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 1410f2787729f79e690f608016f7625cdc26a71c^{commit} # timeout=10
Checking out Revision 1410f2787729f79e690f608016f7625cdc26a71c (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1410f2787729f79e690f608016f7625cdc26a71c
Commit message: "Vendored in lego dependency"
 > git rev-list --no-walk 055ad7950149bf51f1df1152d9acc4bfc9060673 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins4063002577656120726.sh
++ echo jenkins-trafficcontrol-PR-4678
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4678
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-UpZI
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-3r9F
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-UpZI -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1008  0 --:--:-- --:--:-- --:--:--  1006
  6 8079k6  509k0 0   357k  0  0:00:22  0:00:01  0:00:21  
357k100 8079k  100 8079k0 0  4573k  0  0:00:01  0:00:01 --:--:-- 
21.6M
+ chmod +x /tmp/docker-compose-UpZI
+ rm -rf dist
+ /tmp/docker-compose-UpZI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4678 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-UpZI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4678 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-UpZI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4678 rm -v -f
Couldn't connect to Docker

[GitHub] [trafficcontrol] ocket8888 commented on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

ocket commented on issue #4049: deliveryservices_required_capabilities - 
sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548100268
 
 
   Yeah. Since that's a `TimeNoMod`, the current implementation is incapable of 
sorting by it. would be nice, though. There should be an option to pass it 
arbitrary maps to sort on, though maybe that's one of the many things that got 
buried deep in the CRUDer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang commented on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

ZugNZwang commented on issue #4049: deliveryservices_required_capabilities - 
sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548099579
 
 
   Can confirm. On server_server_capabilites endpoint orderBy and sortOrder 
works on all fields except lastUpdated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

mhoppa commented on issue #4049: deliveryservices_required_capabilities - sort 
doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548095601
 
 
   Ahh looks like our order by only allows fields that are defined in the 
queryParams map 
`https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go#L83`
   
   With that `Choose the ordering of the results - must be the name of one of 
the fields of the objects in the response array` which is used in like all the 
docs to describe order by is going to be incorrect 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

lbathina commented on issue #4049: deliveryservices_required_capabilities - 
sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548095573
 
 
   yes. Asked eric to check on another endpoint


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa edited a comment on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

mhoppa edited a comment on issue #4049: deliveryservices_required_capabilities 
- sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548095601
 
 
   Ahh looks like our order by only allows fields that are defined in the 
queryParams map 
   
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go#L83
   
   With that `Choose the ordering of the results - must be the name of one of 
the fields of the objects in the response array` which is used in like all the 
docs to describe order by is going to be incorrect 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2019-10-30 Thread GitBox

rawlinp commented on a change in pull request #2785: In Traffic Router Support 
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r340833282
 
 

 ##
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/edge/Location.java
 ##
 @@ -0,0 +1,92 @@
+/*
+ * Copyright 2015 Comcast Cable Communications Management, LLC
 
 Review comment:
   I'm not a lawyer, but none of the other files in here have this Comcast 
copyright.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2019-10-30 Thread GitBox

rawlinp commented on a change in pull request #2785: In Traffic Router Support 
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r340828620
 
 

 ##
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
 ##
 @@ -886,14 +1109,19 @@ private static Record createRecord(final Name name, 
final InetRecord address) th
Zone zone = getZone(name);
final InetAddress addr = InetAddress.getByName(address);
final int qtype = (addr instanceof Inet6Address) ? 
Type. : Type.A;
-   final Zone dynamicZone = createDynamicZone(zone, name, 
qtype, addr, true, builder);
+   final DNSRequest request = new DNSRequest(zone, name, 
qtype);
+   request.setClientIP(addr.getHostAddress());
+   
request.setHostname(name.relativize(Name.root).toString());
+   request.setDnssec(true);
 
 Review comment:
   why do we enable dnssec on the `DNSRequest` object here? Shouldn't that 
depend on whether or not dnssec validation was actually requested and if it is 
enabled on the CDN?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

2019-10-30 Thread GitBox

rawlinp commented on a change in pull request #2785: In Traffic Router Support 
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r340835514
 
 

 ##
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
 ##
 @@ -755,7 +784,10 @@ public HTTPRouteResult singleRoute(final HTTPRequest 
request, final Track track)

track.setResultDetails(ResultDetails.DS_TLS_MISMATCH);
return null;
}
-   if (!ds.isAvailable()) {
+   if (ds.isRegionalGeoEnabled()) {
 
 Review comment:
   I think this check was actually removed and the functionality fixed so 
probably shouldn't be added back in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

2019-10-30 Thread GitBox

mitchell852 commented on issue #4039: TO,TP: server should not be allowed to be 
deleted when it has a DS assigned to it.
URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-548094534
 
 
   something like "the server you are deleting is currently assigned to 100 
delivery services. Proceed?" I think that is fair.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

ocket commented on issue #4049: deliveryservices_required_capabilities - 
sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049#issuecomment-548093632
 
 
   If that's true, it affects more than just this endpoint - nearly all API 
endpoints use the same subroutine for generating `ORDER BY` clauses.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on issue #4012: Added IPv6 checking to Traffic Monitor

2019-10-30 Thread GitBox

rob05c commented on issue #4012: Added IPv6 checking to Traffic Monitor
URL: https://github.com/apache/trafficcontrol/pull/4012#issuecomment-548093657
 
 
   This is great! We've needed v6 polling for a while now.
   
   I just have a few questions. I see `PeerPollingProtocol` in the config, but 
it doesn't appear to be used?
   
   Running the Monitor, I'm also seeing a lot of `Peer is reachable` in the 
event log. It seems like it's logging every poll (when it should only log if 
the state changes). I could be misreading it, though. I'm not immediately 
seeing what's causing it in the code. Any ideas?
   
   Also, just to verify, `both` polls both, and marks unavailable if either is 
Unavailable? I.e. if a v4 poll fails, then a v6 poll succeeds, it will still be 
Unavailable?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

2019-10-30 Thread GitBox

ocket commented on issue #4039: TO,TP: server should not be allowed to be 
deleted when it has a DS assigned to it.
URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-548093029
 
 
   Sorta why I think it should maybe just be a confirmation dialog in TP - on 
top of the one we already have, or maybe extra cautionary text in the current 
one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

2019-10-30 Thread GitBox

mitchell852 commented on issue #4039: TO,TP: server should not be allowed to be 
deleted when it has a DS assigned to it.
URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-548092391
 
 
   imagine if you could not do this. you have a server that happens to be 
assigned to 100 different delivery services. do you first have to unassign that 
server from all 100 delivery services before you can delete it? seems like a 
operations nightmare.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4039: TO, TP: server should not be allowed to be deleted when it has a DS assigned to it.

2019-10-30 Thread GitBox

mitchell852 commented on issue #4039: TO,TP: server should not be allowed to be 
deleted when it has a DS assigned to it.
URL: https://github.com/apache/trafficcontrol/issues/4039#issuecomment-548091590
 
 
   this is not true. you can delete servers that are assigned to delivery 
services and always have been able to. why should you not be able to do this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina opened a new issue #4049: deliveryservices_required_capabilities - sort doesn't work

2019-10-30 Thread GitBox

lbathina opened a new issue #4049: deliveryservices_required_capabilities - 
sort doesn't work
URL: https://github.com/apache/trafficcontrol/issues/4049
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [X] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   
   both asc and desc gives results in same order. 
   
   
   ## Expected / new behavior:
   
   sorting should be applied on orderby field.
   ## Minimal reproduction of the problem with instructions:
   
   
https://{{TO_BASE_URL}}/api/{{api_version}}/deliveryservices_required_capabilities?orderby=lastUpdated&sortOrder=desc
   
https://{{TO_BASE_URL}}/api/{{api_version}}/deliveryservices_required_capabilities?orderby=lastUpdated&sortOrder=asc
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4043: TO: Internal Server error is returned when user not tenant of the ds assigns/deletes required capability

2019-10-30 Thread GitBox

mitchell852 commented on issue #4043: TO: Internal Server error is returned 
when user not tenant of the ds assigns/deletes required capability
URL: https://github.com/apache/trafficcontrol/issues/4043#issuecomment-548090421
 
 
   I think `403`. Maybe not perfect as it is admitting a ds, but that's what 
we've always done on tenancy failure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

2019-10-30 Thread GitBox

mhoppa commented on a change in pull request #4041: Block server 
servercapability delete if associated ds requires it
URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340832152
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go
 ##
 @@ -117,6 +120,22 @@ func (ssc *TOServerServerCapability) Read() 
([]interface{}, error, error, int) {
 }
 
 func (ssc *TOServerServerCapability) Delete() (error, error, int) {
+   // Ensure that the user is not removing a server capability from the 
server
+   // that is required by the delivery services the server is assigned to 
(if applicable)
+   dsIDs := []int64{}
+   if err := ssc.APIInfo().Tx.QueryRow(checkDSReqCapQuery(), ssc.ServerID, 
ssc.ServerCapability).Scan(pq.Array(&dsIDs)); err != nil {
+   return nil, fmt.Errorf("checking removing server server 
capability would still suffice delivery service requried capabilites: %v", 
err), http.StatusInternalServerError
+   }
+
+   if len(dsIDs) > 0 {
+   dsIdsStr, err := json.Marshal(dsIDs)
+   if err != nil {
+   return nil, fmt.Errorf("formatting response message on 
bad request to disassociate server capability from server: %v", err), 
http.StatusInternalServerError
+   }
+   return fmt.Errorf("cannot remove the capability %v from the 
server %v as the server is assigned to the delivery services %v that require 
it", *ssc.ServerCapability, *ssc.ServerID, string(dsIdsStr)), nil, 
http.StatusBadRequest
 
 Review comment:
   @ocket  I omit the ds IDs the user is not authorized to see from the 
error message. Can you please rereview the PR? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4677

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[ocket] Fix query parameter name (#4031)

[ocket] Correct references to traffic vault (#4040)

[rawlin_peters] Docs/influx fix (#4037)

[ocket] Rewrite cache_stats to Golang (#4029)

[rawlin_peters] Rewrite /federations to Go - POST/PUT/DELETE (#4015)

[Michael_Hoppal] Block server servercapability delete if associated ds requires 
it

[Michael_Hoppal] Clean up code

[Michael_Hoppal] Omit ds IDs from error message if user doesnt have access


--
GitHub pull request #4041 of commit 055ad7950149bf51f1df1152d9acc4bfc9060673, 
no merge conflicts.
Running as SYSTEM
Setting status of 055ad7950149bf51f1df1152d9acc4bfc9060673 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4677/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 055ad7950149bf51f1df1152d9acc4bfc9060673^{commit} # timeout=10
Checking out Revision 055ad7950149bf51f1df1152d9acc4bfc9060673 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 055ad7950149bf51f1df1152d9acc4bfc9060673
Commit message: "Omit ds IDs from error message if user doesnt have access"
 > git rev-list --no-walk 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins3314797695645106494.sh
++ echo jenkins-trafficcontrol-PR-4677
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4677
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-tFNL
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-wTIe
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-tFNL -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0967  0 --:--:-- --:--:-- --:--:--   967
  0 8079k0 169620 0  14033  0  0:09:49  0:00:01  0:09:48 
14033100 8079k  100 8079k0 0  4426k  0  0:00:01  0:00:01 --:--:-- 
12.7M
+ chmod +x /tmp/docker-compose-tFNL
+ rm -rf dist
+ /tmp/docker-compose-tFNL -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4677 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-tFNL -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4677 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-tFNL -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4677 rm -v -f
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ rm -f /tmp/docker-compose-tFNL
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #4041: Block server servercapability delete if associated ds requires it

2019-10-30 Thread GitBox

asf-ci commented on issue #4041: Block server servercapability delete if 
associated ds requires it
URL: https://github.com/apache/trafficcontrol/pull/4041#issuecomment-548089716
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4677/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

mitchell852 commented on issue #4047: Federations API return blank when no 
delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047#issuecomment-548088377
 
 
   ah, i guess it's fine to leave bug on there...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

mitchell852 commented on issue #4047: Federations API return blank when no 
delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047#issuecomment-548084064
 
 
   This is not technically a bug so I'm going to remove that label. It's 
probably simply tech debt + TO api 2.x


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

ocket commented on issue #4047: Federations API return blank when no 
delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047#issuecomment-548083597
 
 
   The Federations API is all kinds of screwy. I genuinely have no idea how one 
would get a list of existing federations not assigned to a deliveryservice or a 
user.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

mitchell852 edited a comment on issue #4047: Federations API return blank when 
no delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047#issuecomment-548082976
 
 
   I **think** the reason for this is:
   
   1. you simply created a federation with `POST 
https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations`
   
   2. you never mapped that federation to a delivery service via `POST 
federations/{id}/deliveryservices`
   
   `GET 
https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations` only 
fetches federations that are assigned to delivery services of that cdn
   
   yes, i agree, it's weird to `POST` and then `GET` to 
`https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations` and 
see nothing. This is probably just poor API design. I guess in hindsight, the 
POST should have required 1 or more ds's.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

mitchell852 commented on issue #4047: Federations API return blank when no 
delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047#issuecomment-548082976
 
 
   I **think** the reason for this is:
   
   1. you simply created a federation with POST 
https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations
   
   2. you never mapped that federation to a delivery service
   
   GET https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations 
only fetches federations that are assigned to delivery services of that cdn
   
   yes, i agree, it's weird to POST and then GET to 
https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations and 
see nothing. This is probably just poor API design. I guess in hindsight, the 
POST should have required 1 or more ds's.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4048: There should be a way to correlate logs on the request made.

2019-10-30 Thread GitBox

lbathina commented on issue #4048: There should be a way to correlate logs on 
the request made. 
URL: https://github.com/apache/trafficcontrol/issues/4048#issuecomment-548080850
 
 
   error and access doesn't have them exposed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

asf-ci commented on issue #4035: TP: adds the ability to add/remove required 
server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-548080202
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4676/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4676

2019-10-30 Thread Apache Jenkins Server

See 

Changes:


--
GitHub pull request #4035 of commit 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5, 
no merge conflicts.
Running as SYSTEM
Setting status of 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4676/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5^{commit} # timeout=10
Checking out Revision 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1688a73d5d9831c3fe2ba557fedf5759f2fd6bf5
Commit message: "adds changelog entry for TP ds/server capability UI"
 > git rev-list --no-walk d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46 # timeout=10
First time build. Skipping changelog.
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins6506367633566473336.sh
++ echo jenkins-trafficcontrol-PR-4676
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4676
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-TFdG
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-RPk2
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-TFdG -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0999  0 --:--:-- --:--:-- --:--:--  1000
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4499k  0  0:00:01  0:00:01 --:--:-- 8372k
+ chmod +x /tmp/docker-compose-TFdG
+ rm -rf dist
+ /tmp/docker-compose-TFdG -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4676 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-TFdG -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4676 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-TFdG -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4676 rm -v -f
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ rm -f /tmp/docker-compose-TFdG
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

asf-ci commented on issue #4035: TP: adds the ability to add/remove required 
server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-548078422
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4675/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4675

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[mitchell852] Removed restangular from ChangeLogService (#3608)

[ocket] Fix TO API test failure when starting from a fresh `db/admin reset`

[ocket] Implement GET /api/1.1/roles handler (#4011)

[mitchell852] Removed restangular from CacheGroupService (#3604)

[ocket] Add deliveryservice server capability docs (#4018)

[ocket] Add TO Go ATS CDN configs (#3875)

[ocket] TP: Ability to manager capabilities of servers (#3998)

[ocket] Fix missed files in PR (#4024)

[ocket] Rewrite federation user GET/POST/DELETE (#4014)

[ocket] Fix endpoint name in docs (#4027)

[ocket] Add TO-Go /api/1.1/servers/status GET handler (#4013)

[ocket] Feature/add deliveryservice required capability (#4026)

[mitchell852] adds the ability to add or remove required server capabilities 
from a

[mitchell852] adds context menu items for viewing a server capability's servers 
and

[mitchell852] adds UI tests for adding a required capability to a ds

[mitchell852] changes menu verbiage to Manage Required Server Capabilities

[mitchell852] adds documentation for ds/server cap assignment UI

[mitchell852] adds changelog entry for TP ds/server capability UI


--
GitHub pull request #4035 of commit d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46, 
no merge conflicts.
Running as SYSTEM
Setting status of d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4675/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46^{commit} # timeout=10
Checking out Revision d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d74a1676c14e44eb8d071dd74f6bc4afe9cc4b46
Commit message: "adds changelog entry for TP ds/server capability UI"
 > git rev-list --no-walk 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins3665299415958857735.sh
++ echo jenkins-trafficcontrol-PR-4675
++ sed s/jenkins//
++ sed s/-//g
+ proj=trafficcontrolPR4675
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-dvzv
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-fNMx
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-dvzv -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1035  0 --:--:-- --:--:-- --:--:--  1036
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4690k  0  0:00:01  0:00:01 --:--:-- 10.6M
+ chmod +x /tmp/docker-compose-dvzv
+ rm -rf dist
+ /tmp/docker-compose-dvzv -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4675 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-dvzv -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4675 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-dvzv -f infrastructure/docker/build/docker-compose.yml -

[GitHub] [trafficcontrol] rawlinp commented on issue #4048: There should be a way to correlate logs on the request made.

2019-10-30 Thread GitBox

rawlinp commented on issue #4048: There should be a way to correlate logs on 
the request made. 
URL: https://github.com/apache/trafficcontrol/issues/4048#issuecomment-548074557
 
 
   They're exposed in the info logs, not the access logs (see `reqid`):
   ```
   INFO: routing.go:196: 2019-10-30T12:18:26.893542-06:00: DELETE 
/api/1.3/cdns/353? handling (reqid 61443)
   DEBUG: plugin.go:178: 2019-10-30T12:18:26.893553-06:00: DEBUG 
plugins.OnRequest calling 0 plugins
   DEBUG: shared_handlers.go:295: 2019-10-30T12:18:26.894426-06:00: changelog 
for delete on object
   [::1]:49701 - admin [30/Oct/2019:12:18:26 -0600] "DELETE /api/1.3/cdns/353? 
HTTP/1.1" 200 81 1 "to-api-v14-client-tests"
   INFO: routing.go:199: 2019-10-30T12:18:26.895136-06:00: DELETE 
/api/1.3/cdns/353? handled (reqid 61443) in 1.583052ms
   INFO: routing.go:196: 2019-10-30T12:18:26.8954-06:00: GET 
/api/1.3/cdns?name=cdn4 handling (reqid 61444)
   ```
   Although, I'm not sure if the `ERROR` log line includes the `reqid`. We 
could probably prepend it to the error log line if not already. It's fairly 
easy to trace which requests caused errors if there are no concurrent requests, 
since the error should be logged between the `handling` and `handled` lines, 
but that goes out the window if TO-Go is handling concurrent requests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4674

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[matthew_jackson] TP Delivery Service Generate SSL update, new letsencrypt 
generate and

[matthew_jackson] Added API for dns challenges and setup DNS Challenge calls to 
LE

[matthew_jackson] DNS Challenge update

[matthew_jackson] Traffic Router updated to watch for new DNS Challenge TXT 
Records and

[matthew_jackson] updated for TXT record clean up

[matthew_jackson] added email field for LE configuration, updated renewal 
functionality,

[matthew_jackson] added autorenewal functionality

[matthew_jackson] Autorenewal and documentation

[matthew_jackson] Made CSR not required for LE certs, fixed cert encoding

[matthew_jackson] autorenew, formatted email, documentation, async workflow and 
logs to

[matthew_jackson] minor updates and SMTP code relocation

[matthew_jackson] minor update so certs created before this update show in the 
UI as

[matthew_jackson] merge with other SMTP config

[matthew_jackson] updates per comments

[matthew_jackson] updates per comments

[matthew_jackson] Updates per comments

[matthew_jackson] Vendored in lego dependency


--
GitHub pull request #3534 of commit 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f, 
has merge conflicts.
Running as SYSTEM
Setting status of 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4674/ and message: 'Build 
started for original commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f^{commit} # timeout=10
Checking out Revision 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2bd4753bc5ff15aed37e00948d12b6e4f4d88e7f
Commit message: "Vendored in lego dependency"
 > git rev-list --no-walk d191b941af2864fce1cfcdb5276e4d9f8742414b # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins4756535710210872268.sh
++ echo jenkins-trafficcontrol-PR-4674
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4674
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-qTQg
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-FnL4
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-qTQg -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1032  0 --:--:-- --:--:-- --:--:--  1031
  5 8079k5  440k0 0   335k  0  0:00:24  0:00:01  0:00:23  
335k100 8079k  100 8079k0 0  4716k  0  0:00:01  0:00:01 --:--:-- 
18.7M
+ chmod +x /tmp/docker-compose-qTQg
+ rm -rf dist
+ /tmp/docker-compose-qTQg -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4674 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-qTQg -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4674 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-qTQg -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4674 rm -v -f
Couldn't connect to Doc

[GitHub] [trafficcontrol] asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-30 Thread GitBox

asf-ci commented on issue #3534: TP Delivery Service Generate SSL update, new 
letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#issuecomment-548073186
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4674/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4048: There should be a way to correlate logs on the request made.

2019-10-30 Thread GitBox

ocket commented on issue #4048: There should be a way to correlate logs on 
the request made. 
URL: https://github.com/apache/trafficcontrol/issues/4048#issuecomment-548068552
 
 
   requests do have unique identifiers already. Just aren't exposed in logs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina opened a new issue #4048: There should be a way to correlate logs on the request made.

2019-10-30 Thread GitBox

lbathina opened a new issue #4048: There should be a way to correlate logs on 
the request made. 
URL: https://github.com/apache/trafficcontrol/issues/4048
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [ ] bug report
   - [ ] new feature / enhancement request
   - [X] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   currently we have logs that has timestamps.
   However, it wasn't easy and clear to track down the error logs corresponding 
to a request.
   
   ## Expected / new behavior:
   
   
   We should have some form of correlation between logs to easily and 
legitimately identify logs corresponding to a specific request. something like 
trace id or request id or session id
this can be applicable to all logs of all components.
   ## Minimal reproduction of the problem with instructions:
   
   
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina edited a comment on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

lbathina edited a comment on issue #4045: Requests to cache_stats endpoint 
returns Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548061869
 
 
   ```
   ERROR: api.go:136: 2019-10-30T18:25:17.695385277Z:  Getting summary response 
from Influx: Improper number of series: 0
   ERROR: api.go:136: 2019-10-30T18:25:17.75008225Z: Getting summary response 
from Influx: Improper number of series: 0
   ```
   Also, request on a CDN that has value we did not get error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

lbathina commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548061869
 
 
   ```
   ERROR: api.go:136: 2019-10-30T18:25:17.695385277Z: 96.118.19.98:60278 
Getting summary response from Influx: Improper number of series: 0
   ERROR: api.go:136: 2019-10-30T18:25:17.75008225Z: 96.118.19.98:60280 Getting 
summary response from Influx: Improper number of series: 0
   ```
   Also, request on a CDN that has value we did not get error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ChrisHines commented on issue #4046: Improve docs

2019-10-30 Thread GitBox

ChrisHines commented on issue #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#issuecomment-548061047
 
 
   OK. Should be good now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548059649
 
 
   What is/are the exact line/lines that tells/tell you that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ChrisHines commented on issue #4046: Improve docs

2019-10-30 Thread GitBox

ChrisHines commented on issue #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#issuecomment-548059601
 
 
   Woops, some build errors. Let me fix those first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ChrisHines commented on issue #4046: Improve docs

2019-10-30 Thread GitBox

ChrisHines commented on issue #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#issuecomment-548059152
 
 
   @ocket I made the suggested simplifications and rebased on the latest 
master to resolve some resulting conflicts. PTAL.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

lbathina commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548058593
 
 
   this issue happens when there is no data to return. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] dandypham opened a new issue #4047: Federations API return blank when no delivery service assign to

2019-10-30 Thread GitBox

dandypham opened a new issue #4047: Federations API return blank when no 
delivery service assign to
URL: https://github.com/apache/trafficcontrol/issues/4047
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [x] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   First do a POST Request to the API : 
https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations
   With this json format:
   {
   "cname": "test.quest.",
   "ttl": 48,
   "description": "A test federation"
   }
   It will be success with status 200.
   After that do a GET Request to the API:
   https://{{TO_BASE_URL}}/api/{{api_version}}/cdns/{{cdnname}}/federations
   
   The return will be blank:
   {
   "response": []
   }
   ## Expected / new behavior:
   Expect the return to display something like this without the delivery 
service:
   { "response": [
   {
   "id": 1,
   "cname": "test.quest.",
   "ttl": 48,
   "description": "A test federation",
   "lastUpdated": "2018-12-05 00:05:16+00",
   "deliveryService": {
   "id": 1,
   "xmlId": "demo1"
   }
   }
   ]}
   
   
   ## Minimal reproduction of the problem with instructions:
   
   
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

2019-10-30 Thread GitBox

asf-ci commented on issue #4030: Rewrite PUT /api/1.1/servers/:id/status to Go
URL: https://github.com/apache/trafficcontrol/pull/4030#issuecomment-548041901
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4673/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4673

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[rawlin_peters] Rewrite PUT /api/1.1/server/:id/status to Go

[rawlin_peters] Return 400 bad request if "status" is missing from request body

[rawlin_peters] Errorf -> Fatalf


--
GitHub pull request #4030 of commit d191b941af2864fce1cfcdb5276e4d9f8742414b, 
no merge conflicts.
Running as SYSTEM
Setting status of d191b941af2864fce1cfcdb5276e4d9f8742414b to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4673/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse d191b941af2864fce1cfcdb5276e4d9f8742414b^{commit} # timeout=10
Checking out Revision d191b941af2864fce1cfcdb5276e4d9f8742414b (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d191b941af2864fce1cfcdb5276e4d9f8742414b
Commit message: "Errorf -> Fatalf"
 > git rev-list --no-walk ce0c97821937fe484117d06aba838f9aa4cff5c7 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins2497349164185224375.sh
++ echo jenkins-trafficcontrol-PR-4673
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4673
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-Cpbh
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-Wjfc
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-Cpbh -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1017  0 --:--:-- --:--:-- --:--:--  1018
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4551k  0  0:00:01  0:00:01 --:--:-- 8734k
+ chmod +x /tmp/docker-compose-Cpbh
+ rm -rf dist
+ /tmp/docker-compose-Cpbh -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4673 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-Cpbh -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4673 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-Cpbh -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4673 rm -v -f
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ rm -f /tmp/docker-compose-Cpbh
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4046: Improve docs

2019-10-30 Thread GitBox

ChrisHines commented on a change in pull request #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r340777041
 
 

 ##
 File path: docs/source/admin/quick_howto/multi_site.rst
 ##
 @@ -50,7 +50,7 @@ The following steps will take you through the procedure of 
setting up an :abbr:`
:scale: 100%
:align: center
 
-   .. Note:: “Origin Server Base URL” uniqueness: In order to enable 
Mid-tier :term:`Cache Group` to distinguish :term:`Delivery Service`\ s by 
different :abbr:`MSO (Multi-Site Origin)` algorithms while performing parent 
fail-over, it requires that :abbr:`OSBU (Origin Server Base URL)` for each 
:abbr:`MSO (Multi-Site Origin)`\ -enabled :term:`Delivery Service` is unique. 
This means that the :abbr:`OSBU (Origin Server Base URL)` of an :abbr:`MSO 
(Multi-Site Origin)`\ -enabled :term:`Delivery Service`\ should be different 
from the :abbr:`OSBU (Origin Server Base URL)`\ s of any other :term:`Delivery 
Service`, regardless of whether they are :abbr:`MSO (Multi-Site Origin)`\ 
-enabled or not. The exceptions to this rule are:
+   .. Note:: “Origin Server Base URL” uniqueness: In order to enable 
Mid-tier :term:`Cache Group` to distinguish :term:`Delivery Service`\ s by 
different :abbr:`MSO (Multi-Site Origin)` algorithms while performing parent 
fail-over, it requires that :abbr:`OSBU (Origin Server Base URL)` for each 
:abbr:`MSO (Multi-Site Origin)`\ -enabled :term:`Delivery Service` is unique. 
This means that the :abbr:`OSBU (Origin Server Base URL)` of an :abbr:`MSO 
(Multi-Site Origin)`\ -enabled :term:`Delivery Service` should be different 
from the :abbr:`OSBU (Origin Server Base URL)`\ s of any other :term:`Delivery 
Service`, regardless of whether they are :abbr:`MSO (Multi-Site Origin)`\ 
-enabled or not. The exceptions to this rule are:
 
 Review comment:
   That's good to know. I was fairly targeted with the search I did for this 
PR, but I can expand that and see what it looks like. Happy to work on that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4046: Improve docs

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r340771982
 
 

 ##
 File path: docs/source/admin/quick_howto/multi_site.rst
 ##
 @@ -50,7 +50,7 @@ The following steps will take you through the procedure of 
setting up an :abbr:`
:scale: 100%
:align: center
 
-   .. Note:: “Origin Server Base URL” uniqueness: In order to enable 
Mid-tier :term:`Cache Group` to distinguish :term:`Delivery Service`\ s by 
different :abbr:`MSO (Multi-Site Origin)` algorithms while performing parent 
fail-over, it requires that :abbr:`OSBU (Origin Server Base URL)` for each 
:abbr:`MSO (Multi-Site Origin)`\ -enabled :term:`Delivery Service` is unique. 
This means that the :abbr:`OSBU (Origin Server Base URL)` of an :abbr:`MSO 
(Multi-Site Origin)`\ -enabled :term:`Delivery Service`\ should be different 
from the :abbr:`OSBU (Origin Server Base URL)`\ s of any other :term:`Delivery 
Service`, regardless of whether they are :abbr:`MSO (Multi-Site Origin)`\ 
-enabled or not. The exceptions to this rule are:
+   .. Note:: “Origin Server Base URL” uniqueness: In order to enable 
Mid-tier :term:`Cache Group` to distinguish :term:`Delivery Service`\ s by 
different :abbr:`MSO (Multi-Site Origin)` algorithms while performing parent 
fail-over, it requires that :abbr:`OSBU (Origin Server Base URL)` for each 
:abbr:`MSO (Multi-Site Origin)`\ -enabled :term:`Delivery Service` is unique. 
This means that the :abbr:`OSBU (Origin Server Base URL)` of an :abbr:`MSO 
(Multi-Site Origin)`\ -enabled :term:`Delivery Service` should be different 
from the :abbr:`OSBU (Origin Server Base URL)`\ s of any other :term:`Delivery 
Service`, regardless of whether they are :abbr:`MSO (Multi-Site Origin)`\ 
-enabled or not. The exceptions to this rule are:
 
 Review comment:
   If you want, the vast majority of those \\s can be removed. It's 
not necessary to have an escaped space before a hyphen and `term`s can be 
plural now. So
   
   ```rst
   :term:`Delivery Services`
   and
   :abbr:`MSO (Multi-Site Origin)`-enabled
   ```
   are both totally permissible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548033893
 
 
   Okay, likely that this is a duplicate of #4021 - can you show us the error 
in the TO logs? It'll make it easier to track down.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

mhoppa commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548033660
 
 
   Can you grab the error from the TO logs so show what the internal server 
error is?
   
   It could be either no data points, invalid configuration for influxdb 
   
   Depending a internal server error may be acceptable


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ZugNZwang commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548031975
 
 
   Problem still manifests after waiting 5 minutes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #4046: Improve docs

2019-10-30 Thread GitBox

asf-ci commented on issue #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046#issuecomment-548031238
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

lbathina commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548030595
 
 
   agree. from users perspective - internal server error isn't acceptable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ChrisHines opened a new pull request #4046: Improve docs

2019-10-30 Thread GitBox

ChrisHines opened a new pull request #4046: Improve docs
URL: https://github.com/apache/trafficcontrol/pull/4046
 
 
   ## What does this PR (Pull Request) do?
   - [x] Removes incorrect whitespace escaping in documentation
   - [x] Clarifies the explanation of HTTP content routing in the Traffic 
Router overview documentation
   - [x] Makes the formatting more consistent in the Traffic Stats overview 
documentation
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   
   ## What is the best way to verify this PR?
   Build the docs and check the updated pages.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master (aa6f608e)
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket edited a comment on issue #4045: Requests to cache_stats endpoint 
returns Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548024439
 
 
   Supposedly they're caused by the same root issue, which would make it a 
duplicate, in my opinion.
   
   But firstly, we need to make sure that's actually what's going on. When 
Traffic Stats has just started, it won't have any data. If you request a time 
period for which it has no data, instead of returning a set of zero data points 
- or even just `null`s -InfluxDB will send a totally empty response. When that 
happens, Traffic Ops doesn't know why or what to do about it, and so it throws 
up its hands and gives the client back an Internal Server Error. "Expected 
Behavior" in that scenario could be to hand back a valid, empty array, but as 
has been previously discussed, Traffic Ops should not disclose struggling 
components in these scenarios.
   
   So the key to understanding what issue is taking place is
   > _"Wait about 5 minutes and try again - does the problem still manifest?"_


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548024439
 
 
   Supposedly they're caused by the same root issue, which would make it a 
duplicate, in my opinion.
   
   But firstly, we need to make sure that's actually what's going on. When 
Traffic Stats has just started, it won't have any data. If you request a time 
period for which it has no data, instead of returning a set of zero data points 
- or even just `null`s -InfluxDB will send a totally empty response. When that 
happens, Traffic Ops doesn't know why or what to do about it, and so it throws 
up its hands and gives the client back an Internal Server Error. "Expected 
Behavior" in that scenario could be to hand back a valid, empty array, but as 
has been previously discussed, Traffic Ops should not disclose struggling 
components in these scenarios.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

lbathina commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548021360
 
 
   not a duplicate but I believe the fix for both is same! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket edited a comment on issue #4045: Requests to cache_stats endpoint 
returns Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548018575
 
 
   Wait about 5 minutes and try again - does the problem still manifest?
   
   Also potential duplicate of #4021 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ocket commented on issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045#issuecomment-548018575
 
 
   Wait about 5 minutes and try again - does the problem still manifest?
   
   Also potential duplicate of #3902 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4045: Requests to cache_stats endpoint returns Internal Server Error

2019-10-30 Thread GitBox

ZugNZwang opened a new issue #4045: Requests to cache_stats endpoint returns 
Internal Server Error
URL: https://github.com/apache/trafficcontrol/issues/4045
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [X] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [X] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   Requests to 
`https://{{TO_BASE_URL}}/api/{{api_version}}/cache_stats?cdnName=ALL&endDate=2019-10-28T20:49:00Z&metricType=bandwidth&startDate=2019-10-28T20:45:00Z`
 returns 500 internal server error
   ## Expected / new behavior:
   
   Response code should be 200 with valid response structure.
   ## Minimal reproduction of the problem with instructions:
   
   
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4672

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[ocket] Fix query parameter name (#4031)

[ocket] Correct references to traffic vault (#4040)

[rawlin_peters] Docs/influx fix (#4037)

[ocket] Rewrite cache_stats to Golang (#4029)

[rawlin_peters] Rewrite /federations to Go - POST/PUT/DELETE (#4015)

[Michael_Hoppal] Ensure server_capability can only be assigned to edges or mids


--
GitHub pull request #4044 of commit ce0c97821937fe484117d06aba838f9aa4cff5c7, 
no merge conflicts.
Running as SYSTEM
Setting status of ce0c97821937fe484117d06aba838f9aa4cff5c7 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4672/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse ce0c97821937fe484117d06aba838f9aa4cff5c7^{commit} # timeout=10
Checking out Revision ce0c97821937fe484117d06aba838f9aa4cff5c7 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f ce0c97821937fe484117d06aba838f9aa4cff5c7
Commit message: "Ensure server_capability can only be assigned to edges or mids"
 > git rev-list --no-walk 0565631e71361c4944c85d5b72e563548e1e70dd # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins6755665748244407416.sh
++ echo jenkins-trafficcontrol-PR-4672
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4672
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-z8VO
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-RdRN
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-z8VO -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1006  0 --:--:-- --:--:-- --:--:--  1006
  0 8079k0 00 0  0  0 --:--:--  0:00:01 --:--:-- 
0100 8079k  100 8079k0 0  4737k  0  0:00:01  0:00:01 --:--:-- 12.7M
+ chmod +x /tmp/docker-compose-z8VO
+ rm -rf dist
+ /tmp/docker-compose-z8VO -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4672 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-z8VO -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4672 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-z8VO -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4672 rm -v -f
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ rm -f /tmp/docker-compose-z8VO
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

2019-10-30 Thread GitBox

asf-ci commented on issue #4044: Ensure server_capability can only be assigned 
to edges or mids
URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548012706
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4672/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4044: Ensure server_capability can only be assigned to edges or mids

2019-10-30 Thread GitBox

mhoppa opened a new pull request #4044: Ensure server_capability can only be 
assigned to edges or mids
URL: https://github.com/apache/trafficcontrol/pull/4044
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR fixes #4038 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Documentation
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Build traffic ops with PR and then attempt to assign a server_capability to 
a non EDGE/MID server. It should be blocked.
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] This PR includes tests
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR does not include an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

2019-10-30 Thread GitBox

asf-ci commented on issue #4035: TP: adds the ability to add/remove required 
server capabilities from DS
URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-548005203
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4671/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4671

2019-10-30 Thread Apache Jenkins Server

See 


Changes:

[ocket] Add top-level vendor dir to TO-Go and TM unit test containers 
(#4009)

[ocket] accounts for null arrays (#4008)

[mitchell852] Rewrote /user/reset_password to Go (#3929)

[mitchell852] Removed restangular from ChangeLogService (#3608)

[ocket] Fix TO API test failure when starting from a fresh `db/admin reset`

[ocket] Implement GET /api/1.1/roles handler (#4011)

[mitchell852] Removed restangular from CacheGroupService (#3604)

[ocket] Add deliveryservice server capability docs (#4018)

[ocket] Add TO Go ATS CDN configs (#3875)

[ocket] TP: Ability to manager capabilities of servers (#3998)

[ocket] Fix missed files in PR (#4024)

[ocket] Rewrite federation user GET/POST/DELETE (#4014)

[ocket] Fix endpoint name in docs (#4027)

[ocket] Add TO-Go /api/1.1/servers/status GET handler (#4013)

[ocket] Feature/add deliveryservice required capability (#4026)

[mitchell852] adds the ability to add or remove required server capabilities 
from a

[mitchell852] adds context menu items for viewing a server capability's servers 
and

[mitchell852] adds UI tests for adding a required capability to a ds


--
GitHub pull request #4035 of commit 0565631e71361c4944c85d5b72e563548e1e70dd, 
no merge conflicts.
Running as SYSTEM
Setting status of 0565631e71361c4944c85d5b72e563548e1e70dd to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4671/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H39 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 0565631e71361c4944c85d5b72e563548e1e70dd^{commit} # timeout=10
Checking out Revision 0565631e71361c4944c85d5b72e563548e1e70dd (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0565631e71361c4944c85d5b72e563548e1e70dd
Commit message: "adds UI tests for adding a required capability to a ds"
 > git rev-list --no-walk 16e21a5998e3037bbb6e45b592c35e7a3dde890e # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins3184638874619756942.sh
++ echo jenkins-trafficcontrol-PR-4671
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4671
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-hzIW
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-C8hl
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-hzIW -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1031  0 --:--:-- --:--:-- --:--:--  1031
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4734k  0  0:00:01  0:00:01 --:--:-- 10.5M
+ chmod +x /tmp/docker-compose-hzIW
+ rm -rf dist
+ /tmp/docker-compose-hzIW -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4671 up
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ exit 1
+ finish
+ /tmp/docker-compose-hzIW -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4671 down -v
Couldn't connect to Docker daemon at http+docker://localunixsocket - is it 
running?

If it's at a non-standard location, specify the URL with the DOCKER_HOST 
environment variable.
+ /tmp/docker-compose-hzIW -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolP

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-30 Thread GitBox

ocket commented on a change in pull request #3534: TP Delivery Service 
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340722930
 
 

 ##
 File path: traffic_ops/app/bin/checks/ToAutorenewCerts.pl
 ##
 @@ -0,0 +1,103 @@
+#!/usr/bin/perl
+#
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# DNSSEC refresh, checks to see if DNSSEC keys need to be re-generated.
+#
+
+use strict;
+use warnings;
+
+$|++;
+
+use LWP::UserAgent;
+use Data::Dumper;
+use Getopt::Std;
+use Log::Log4perl qw(:easy);
+use JSON;
+use Extensions::Helper;
+
+my $VERSION = "0.01";
+my $hostn   = `hostname`;
+chomp($hostn);
+
+my %args = ();
+getopts( "l:c:", \%args );
+
+Log::Log4perl->easy_init($ERROR);
+if ( defined( $args{l} ) ) {
+   if( $args{l} == 1 ) { Log::Log4perl->easy_init($INFO); }
+   elsif ( $args{l} == 2 ) { Log::Log4perl->easy_init($DEBUG); }
+   elsif ( $args{l} == 3 ) { Log::Log4perl->easy_init($TRACE); }
+   elsif ( $args{l} > 3 )  { Log::Log4perl->easy_init($TRACE); }
+   else{ Log::Log4perl->easy_init($INFO); }
+}
+
+DEBUG( "Including DEBUG messages in output. Config is \'" . $args{c} . "\'" );
+TRACE( "Including TRACE messages in output. Config is \'" . $args{c} . "\'" );
+
+if ( !defined( $args{c} ) ) {
+   &help();
+   exit(1);
+}
+
+my $jconf = undef;
+eval { $jconf = decode_json( $args{c} ) };
 
 Review comment:
   Apparently using `eval` is standard practice in Perl - which sounds 
omega-crazy to me, but what're you gonna do? - so I'm not going to block on 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

2019-10-30 Thread GitBox

mattjackson220 commented on a change in pull request #3534: TP Delivery Service 
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r340717043
 
 

 ##
 File path: traffic_ops/app/db/migrations/20191016_add_dns_challenges.sql
 ##
 @@ -0,0 +1,28 @@
+/*
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

2019-10-30 Thread GitBox

mhoppa commented on a change in pull request #4041: Block server 
servercapability delete if associated ds requires it
URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340672906
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go
 ##
 @@ -117,6 +120,22 @@ func (ssc *TOServerServerCapability) Read() 
([]interface{}, error, error, int) {
 }
 
 func (ssc *TOServerServerCapability) Delete() (error, error, int) {
+   // Ensure that the user is not removing a server capability from the 
server
+   // that is required by the delivery services the server is assigned to 
(if applicable)
+   dsIDs := []int64{}
+   if err := ssc.APIInfo().Tx.QueryRow(checkDSReqCapQuery(), ssc.ServerID, 
ssc.ServerCapability).Scan(pq.Array(&dsIDs)); err != nil {
+   return nil, fmt.Errorf("checking removing server server 
capability would still suffice delivery service requried capabilites: %v", 
err), http.StatusInternalServerError
+   }
+
+   if len(dsIDs) > 0 {
+   dsIdsStr, err := json.Marshal(dsIDs)
+   if err != nil {
+   return nil, fmt.Errorf("formatting response message on 
bad request to disassociate server capability from server: %v", err), 
http.StatusInternalServerError
+   }
+   return fmt.Errorf("cannot remove the capability %v from the 
server %v as the server is assigned to the delivery services %v that require 
it", *ssc.ServerCapability, *ssc.ServerID, string(dsIdsStr)), nil, 
http.StatusBadRequest
 
 Review comment:
   Ill omit them 👍 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

2019-10-30 Thread GitBox

ocket commented on a change in pull request #4041: Block server 
servercapability delete if associated ds requires it
URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340671342
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go
 ##
 @@ -117,6 +120,22 @@ func (ssc *TOServerServerCapability) Read() 
([]interface{}, error, error, int) {
 }
 
 func (ssc *TOServerServerCapability) Delete() (error, error, int) {
+   // Ensure that the user is not removing a server capability from the 
server
+   // that is required by the delivery services the server is assigned to 
(if applicable)
+   dsIDs := []int64{}
+   if err := ssc.APIInfo().Tx.QueryRow(checkDSReqCapQuery(), ssc.ServerID, 
ssc.ServerCapability).Scan(pq.Array(&dsIDs)); err != nil {
+   return nil, fmt.Errorf("checking removing server server 
capability would still suffice delivery service requried capabilites: %v", 
err), http.StatusInternalServerError
+   }
+
+   if len(dsIDs) > 0 {
+   dsIdsStr, err := json.Marshal(dsIDs)
+   if err != nil {
+   return nil, fmt.Errorf("formatting response message on 
bad request to disassociate server capability from server: %v", err), 
http.StatusInternalServerError
+   }
+   return fmt.Errorf("cannot remove the capability %v from the 
server %v as the server is assigned to the delivery services %v that require 
it", *ssc.ServerCapability, *ssc.ServerID, string(dsIdsStr)), nil, 
http.StatusBadRequest
 
 Review comment:
   I think the ids oughtta be excluded.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4041: Block server servercapability delete if associated ds requires it

2019-10-30 Thread GitBox

mhoppa commented on a change in pull request #4041: Block server 
servercapability delete if associated ds requires it
URL: https://github.com/apache/trafficcontrol/pull/4041#discussion_r340636148
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go
 ##
 @@ -117,6 +120,22 @@ func (ssc *TOServerServerCapability) Read() 
([]interface{}, error, error, int) {
 }
 
 func (ssc *TOServerServerCapability) Delete() (error, error, int) {
+   // Ensure that the user is not removing a server capability from the 
server
+   // that is required by the delivery services the server is assigned to 
(if applicable)
+   dsIDs := []int64{}
+   if err := ssc.APIInfo().Tx.QueryRow(checkDSReqCapQuery(), ssc.ServerID, 
ssc.ServerCapability).Scan(pq.Array(&dsIDs)); err != nil {
+   return nil, fmt.Errorf("checking removing server server 
capability would still suffice delivery service requried capabilites: %v", 
err), http.StatusInternalServerError
+   }
+
+   if len(dsIDs) > 0 {
+   dsIdsStr, err := json.Marshal(dsIDs)
+   if err != nil {
+   return nil, fmt.Errorf("formatting response message on 
bad request to disassociate server capability from server: %v", err), 
http.StatusInternalServerError
+   }
+   return fmt.Errorf("cannot remove the capability %v from the 
server %v as the server is assigned to the delivery services %v that require 
it", *ssc.ServerCapability, *ssc.ServerID, string(dsIdsStr)), nil, 
http.StatusBadRequest
 
 Review comment:
   I dont think this code needs to change then - as at the point of getting the 
affected DSes ids I  am going to return 400 regardless if they have tenancy or 
not.
   
   One thing I could do is omit the ids from the alert message (either all or 
the ones they dont have permissions to) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

96 matches

Mail list logo