[GitHub] [trafficcontrol] mitchell852 commented on issue #3754: GET api/{version}/users/:userid/deliveryservices returns incorrect results
mitchell852 commented on issue #3754: GET
api/{version}/users/:userid/deliveryservices returns incorrect results
URL: https://github.com/apache/trafficcontrol/issues/3754#issuecomment-586455201
closing this in favor of #4402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #3754: GET api/{version}/users/:userid/deliveryservices returns incorrect results
mitchell852 commented on issue #3754: GET
api/{version}/users/:userid/deliveryservices returns incorrect results
URL: https://github.com/apache/trafficcontrol/issues/3754#issuecomment-535996020
however, if we're not going to fix `GET /users/:id/deliveryservices` i think:
1. it should be deprecated and
2. it's probably a good idea to support something like `GET
/deliveryservices? accessibleTo=tenant1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #3754: GET api/{version}/users/:userid/deliveryservices returns incorrect results
mitchell852 commented on issue #3754: GET
api/{version}/users/:userid/deliveryservices returns incorrect results
URL: https://github.com/apache/trafficcontrol/issues/3754#issuecomment-535994573
Honestly, I think the docs simply need to be changed to:
> _"Retrieves all Delivery Services assigned to the user via tenancy."_
I really don't think this falls under the category of an api breaking
change. It's just an overall change of behavior in the system.
It used to be that a user's delivery services were determined by the
contents of the deliveryservice_tmuser table but not it's determined by the
user's tenancy.
By using GET /users/:id/deliveryservices the api consumer is just looking
for a list of delivery services accessible by the user. how that is determined
(deliveryservice_tmuser or tenancy) should not be a concern of the api consumer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
