[GitHub] incubator-trafficcontrol pull request #496: fix an issue where when read onl...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #496: fix an issue where when read onl...
GitHub user dneuman64 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/496 fix an issue where when read only users try to access a DS they get a⦠â¦n error You can merge this pull request into a Git repository by running: $ git pull https://github.com/dneuman64/incubator-trafficcontrol to-fix-ds-ro Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/496.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #496 commit 4dc9869299f5b606449f5b3619c46a230add9622 Author: David Neuman Date: 2017-04-20T22:25:47Z fix an issue where when read only users try to access a DS they get an error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-243) TO postinstall connection to remote db not working
[ https://issues.apache.org/jira/browse/TC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977563#comment-15977563 ] ASF GitHub Bot commented on TC-243: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/495 > TO postinstall connection to remote db not working > -- > > Key: TC-243 > URL: https://issues.apache.org/jira/browse/TC-243 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Dan Kirkwood >Assignee: Dan Kirkwood > Fix For: 2.0.0 > > > if postgres server is running on a host different from traffic_ops, > postinstall is not able to complete. Connection string for the db test does > not include the host name, so assumes the db is local -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #495: [TC-243] fix DBI->connect calls ...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r112562846
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -226,6 +226,120 @@ sub update {
}
+# Create
+sub create {
+ my $self = shift;
+ my $params = $self->req->json;
+
+ if ( !&is_oper($self) ) {
+ return $self->forbidden();
+ }
+
+ my $name = $params->{username};
+ if ( !defined($name) ) {
+ return $self->alert("Username is required.");
--- End diff --
you check for username, fullName and email in the is_valid method. so you
don't have to do that here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 you might want to run your code thru the perl formatter. I see some formatting errors. Here's more info about that: https://github.com/apache/incubator-trafficcontrol/blob/master/CONTRIBUTING.md#code-formatting http://trafficcontrol.apache.org/docs/latest/development/traffic_ops.html#perl-formatting-conventions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-243) TO postinstall connection to remote db not working
[ https://issues.apache.org/jira/browse/TC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977493#comment-15977493 ] ASF GitHub Bot commented on TC-243: --- GitHub user dangogh opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/495 [TC-243] fix DBI->connect calls to allow connection to remote host also removes default answers for cert generation You can merge this pull request into a Git repository by running: $ git pull https://github.com/dangogh/incubator-trafficcontrol postinstall-remote Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 > TO postinstall connection to remote db not working > -- > > Key: TC-243 > URL: https://issues.apache.org/jira/browse/TC-243 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Dan Kirkwood >Assignee: Dan Kirkwood > Fix For: 2.0.0 > > > if postgres server is running on a host different from traffic_ops, > postinstall is not able to complete. Connection string for the db test does > not include the host name, so assumes the db is local -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #495: [TC-243] fix DBI->connect calls ...
GitHub user dangogh opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/495 [TC-243] fix DBI->connect calls to allow connection to remote host also removes default answers for cert generation You can merge this pull request into a Git repository by running: $ git pull https://github.com/dangogh/incubator-trafficcontrol postinstall-remote Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TC-243) TO postinstall connection to remote db not working
Dan Kirkwood created TC-243: --- Summary: TO postinstall connection to remote db not working Key: TC-243 URL: https://issues.apache.org/jira/browse/TC-243 Project: Traffic Control Issue Type: Bug Components: Traffic Ops Affects Versions: 2.0.0 Reporter: Dan Kirkwood Assignee: Dan Kirkwood Fix For: 2.0.0 if postgres server is running on a host different from traffic_ops, postinstall is not able to complete. Connection string for the db test does not include the host name, so assumes the db is local -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (TC-242) TO - tm_user.username and role should be NOT NULL in the db
Jeremy Mitchell created TC-242: -- Summary: TO - tm_user.username and role should be NOT NULL in the db Key: TC-242 URL: https://issues.apache.org/jira/browse/TC-242 Project: Traffic Control Issue Type: Improvement Components: Traffic Ops Reporter: Jeremy Mitchell Priority: Minor Fix For: 2.1.0 username and role are 2 essential pieces of a user, therefore, the database should enforce their existence. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-240) DB Dump times out
[ https://issues.apache.org/jira/browse/TC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977301#comment-15977301 ] ASF GitHub Bot commented on TC-240: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/494 > DB Dump times out > - > > Key: TC-240 > URL: https://issues.apache.org/jira/browse/TC-240 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Derek Gelinas >Assignee: Derek Gelinas > Fix For: 2.1.0 > > > When generating a DB dump, the operation eventually times out. The dump > command needs to be updated to prevent this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #494: [TC-240] Fix Database dump failu...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #494: Dump wait
GitHub user dg4prez opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/494 Dump wait Downloads were 0 bytes because the password was being incorrectly passed. Removed gzip compression because it was causing the browser to suspect a malicious file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dg4prez/incubator-trafficcontrol dump_wait Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/494.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #494 commit ca62f7cf0346d59e995930c4fabaa2df8d933545 Author: Derek Gelinas Date: 2017-04-20T18:54:37Z fix password passing and remove gzip compression commit d5392f238f9e1122dc779054bc7b4d806b93b278 Author: Derek Gelinas Date: 2017-04-20T18:56:59Z remove .gz from filename, update API with dump fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-228) TO: postinstall changes needed for postgres
[ https://issues.apache.org/jira/browse/TC-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977246#comment-15977246 ] ASF GitHub Bot commented on TC-228: --- Github user limited commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/490 merged to 2.0.x > TO: postinstall changes needed for postgres > --- > > Key: TC-228 > URL: https://issues.apache.org/jira/browse/TC-228 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Dan Kirkwood > Fix For: 2.0.0 > > > more changes needed to get postinstall working correctly for a postgres > installation. > This is needed for 2.0.x release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol issue #490: [BACKPORT TC-228] collective changes to...
Github user limited commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/490 merged to 2.0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-228) TO: postinstall changes needed for postgres
[ https://issues.apache.org/jira/browse/TC-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977243#comment-15977243 ] ASF GitHub Bot commented on TC-228: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/490 > TO: postinstall changes needed for postgres > --- > > Key: TC-228 > URL: https://issues.apache.org/jira/browse/TC-228 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Dan Kirkwood > Fix For: 2.0.0 > > > more changes needed to get postinstall working correctly for a postgres > installation. > This is needed for 2.0.x release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #490: [BACKPORT TC-228] collective cha...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-241) TO API - add api endpoint to remove a server from a delivery service
[ https://issues.apache.org/jira/browse/TC-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977223#comment-15977223 ] ASF GitHub Bot commented on TC-241: --- GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/493 [TC-241] - adds api endpoint to remove a cache from a ds You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-241 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #493 commit 8bd237bdc9092ad02270074a6f7198b080f0a64d Author: Jeremy Mitchell Date: 2017-04-20T18:26:58Z adds api endpoint to remove a cache from a ds commit bb01de3ce110e9e424e2cb9897f4d99a9bd8bae1 Author: Jeremy Mitchell Date: 2017-04-20T18:27:26Z hooks to ui into api to remove cache from a ds > TO API - add api endpoint to remove a server from a delivery service > > > Key: TC-241 > URL: https://issues.apache.org/jira/browse/TC-241 > Project: Traffic Control > Issue Type: New Feature > Components: Traffic Ops API >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > Fix For: 2.1.0 > > > Currently, thru the API, you can assign servers in bulk to a delivery service > using: > POST /api/$version/deliveryservices/:xml_id/servers > However, you can't remove individual servers from a ds. > Create an api to remove individual servers from a ds. i.e. > DELETE /api/$version/deliveryservices/:id/servers/:id which will remove > entries from the deliveryservice_server table. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #493: [TC-241] - adds api endpoint to ...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/493 [TC-241] - adds api endpoint to remove a cache from a ds You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-241 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/493.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #493 commit 8bd237bdc9092ad02270074a6f7198b080f0a64d Author: Jeremy Mitchell Date: 2017-04-20T18:26:58Z adds api endpoint to remove a cache from a ds commit bb01de3ce110e9e424e2cb9897f4d99a9bd8bae1 Author: Jeremy Mitchell Date: 2017-04-20T18:27:26Z hooks to ui into api to remove cache from a ds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TC-241) TO API - add api endpoint to remove a server from a delivery service
Jeremy Mitchell created TC-241: -- Summary: TO API - add api endpoint to remove a server from a delivery service Key: TC-241 URL: https://issues.apache.org/jira/browse/TC-241 Project: Traffic Control Issue Type: New Feature Components: Traffic Ops API Reporter: Jeremy Mitchell Assignee: Jeremy Mitchell Priority: Minor Fix For: 2.1.0 Currently, thru the API, you can assign servers in bulk to a delivery service using: POST /api/$version/deliveryservices/:xml_id/servers However, you can't remove individual servers from a ds. Create an api to remove individual servers from a ds. i.e. DELETE /api/$version/deliveryservices/:id/servers/:id which will remove entries from the deliveryservice_server table. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol issue #433: [TC-184] Tenancy validation for resourc...
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/433 make sure you rebase this when you get a chance. you have conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #434: org tenancy - add tenant name to...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-120) The zero size file can't be updated by Traffic Ops ORT
[ https://issues.apache.org/jira/browse/TC-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976842#comment-15976842 ] ASF GitHub Bot commented on TC-120: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/229 > The zero size file can't be updated by Traffic Ops ORT > -- > > Key: TC-120 > URL: https://issues.apache.org/jira/browse/TC-120 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops ORT >Affects Versions: 1.8.0 >Reporter: Jifeng Yang >Assignee: Jifeng Yang > > The ORT doesn't update a file if the file is zero size. > The configuration file may become zero size file by some reason (such as by > accident). If a file is zero size, it can't be updated any more. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol issue #30: Add --skip-ssl option to post install to...
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/30
I think this should be closed -- postinstall now has `-defaults` option to
write out a cfg file with all default questions/answers. And `-a
-cfile=` to load all from the file with no user input.
To skip cert generation, change this answer to `"no"`:
```
"/opt/traffic_ops/install/data/json/openssl_configuration.json" : [
{
"Do you want to generate a certificate?" : "yes",
"config_var" : "genCert"
},
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #229: Traffic Ops ORT can update zero ...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #229: Traffic Ops ORT can update zero size fi...
Github user dg4prez commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/229 Tested and works as designed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-64) TO experimental SPA application
[ https://issues.apache.org/jira/browse/TC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976807#comment-15976807 ] ASF GitHub Bot commented on TC-64: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/492 > TO experimental SPA application > --- > > Key: TC-64 > URL: https://issues.apache.org/jira/browse/TC-64 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops, Traffic Ops API >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > At the 2016 Traffic Control summit, a prototype of a SPA application > developed by [~mitchell...@apache.org] using AngularJS was demo'd that works > entirely on top of the TO API. > This issue is a placeholder for any work done to this prototype / > experimental UI. The goal is to replicate the functionality of the current > MVC TO UI. nothing more, nothing less. > This will require some additions to the TO API. look for issues regarding > each API addition. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #492: [TC-64] - hooks TOUI into up dbd...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #432: Fix The Monitor host port change...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-64) TO experimental SPA application
[ https://issues.apache.org/jira/browse/TC-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976784#comment-15976784 ] ASF GitHub Bot commented on TC-64: -- GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/492 [TC-64] - hooks TOUI into up dbdump api You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol hook-up-dbdump Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/492.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #492 commit 3efff6a7a890fe775874c57fc674f1e94e6b4f18 Author: Jeremy Mitchell Date: 2017-04-20T02:34:37Z hide loading bar when newlogcount is called commit 583c81fe38d1728fdb5fd7425d7ebc0a9b97250b Author: Jeremy Mitchell Date: 2017-04-20T14:24:36Z hooks up db dump > TO experimental SPA application > --- > > Key: TC-64 > URL: https://issues.apache.org/jira/browse/TC-64 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops, Traffic Ops API >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > At the 2016 Traffic Control summit, a prototype of a SPA application > developed by [~mitchell...@apache.org] using AngularJS was demo'd that works > entirely on top of the TO API. > This issue is a placeholder for any work done to this prototype / > experimental UI. The goal is to replicate the functionality of the current > MVC TO UI. nothing more, nothing less. > This will require some additions to the TO API. look for issues regarding > each API addition. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #492: [TC-64] - hooks TOUI into up dbd...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/492 [TC-64] - hooks TOUI into up dbdump api You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol hook-up-dbdump Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/492.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #492 commit 3efff6a7a890fe775874c57fc674f1e94e6b4f18 Author: Jeremy Mitchell Date: 2017-04-20T02:34:37Z hide loading bar when newlogcount is called commit 583c81fe38d1728fdb5fd7425d7ebc0a9b97250b Author: Jeremy Mitchell Date: 2017-04-20T14:24:36Z hooks up db dump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-184) Tenant Hierarchy
[
https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976701#comment-15976701
]
ASF GitHub Bot commented on TC-184:
---
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/403
@mitchell852 Please note that after rebasing the branch deliveryservice UT
fail.
For some reason the changes I do does not work well with the changes you
did, moving from &UI::DeliveryService::get_regexp_set to $self->get_regexp_set.
Any clue why?
When I'm making the below change the UT passes
@@ -69,7 +69,7 @@ sub index {
# build example urls for each delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
push(
@@ -172,7 +172,7 @@ sub show {
# build example urls for the delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
> Tenant Hierarchy
>
>
> Key: TC-184
> URL: https://issues.apache.org/jira/browse/TC-184
> Project: Traffic Control
> Issue Type: New Feature
> Components: Traffic Ops
>Reporter: Ryan Durfey
> Labels: Access, Tenancy
>
> Design under discussion here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910
> The requirements below are seed requirements and final design guidance should
> defer to the evolving wiki page discussion referenced above.
> Overview
> The goal of this system is to create a hierarchical tenancy system which is
> very simple to understand and administer and is highly expandable so that
> large organizations with many subsidiaries have the flexibility to create
> child-tenants to their liking.
> General Seed Requirements
> 1. Provide a structure to create a hierarchy of Tenants where each Tenant has
> a single parent-Tenant and can have multiple child-Tenants
> 2. Provide the ability to group multiple Delivery Services, Users, and child-
> Tenants under each Tenant
> 3. Provide the ability to create at least 10 child-Tenant layers within the
> system
> 4. Make it easy to assign a User to a single Tenant so that they inherit
> their permissions to all child-Tenants and Delivery Services.
> 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant
> hierarchy does not require re-assigning users. Users inherit pre-defined
> permissions to new tenants and services added below their assigned layer in
> the tenancy tree.
> 6. Allow Users to be assigned multiple Tenants, each with different Roles.
> While a user would inherit their access to all services and child Tenants
> below them, they may need more restrictive access further up the Tenant
> hierarchy or they may want different access to another branch of the tenant
> tree.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/403
@mitchell852 Please note that after rebasing the branch deliveryservice UT
fail.
For some reason the changes I do does not work well with the changes you
did, moving from &UI::DeliveryService::get_regexp_set to $self->get_regexp_set.
Any clue why?
When I'm making the below change the UT passes
@@ -69,7 +69,7 @@ sub index {
# build example urls for each delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
push(
@@ -172,7 +172,7 @@ sub show {
# build example urls for the delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TC-184) Tenant Hierarchy
[ https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976697#comment-15976697 ] ASF GitHub Bot commented on TC-184: --- Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 File was renamed as required > Tenant Hierarchy > > > Key: TC-184 > URL: https://issues.apache.org/jira/browse/TC-184 > Project: Traffic Control > Issue Type: New Feature > Components: Traffic Ops >Reporter: Ryan Durfey > Labels: Access, Tenancy > > Design under discussion here: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910 > The requirements below are seed requirements and final design guidance should > defer to the evolving wiki page discussion referenced above. > Overview > The goal of this system is to create a hierarchical tenancy system which is > very simple to understand and administer and is highly expandable so that > large organizations with many subsidiaries have the flexibility to create > child-tenants to their liking. > General Seed Requirements > 1. Provide a structure to create a hierarchy of Tenants where each Tenant has > a single parent-Tenant and can have multiple child-Tenants > 2. Provide the ability to group multiple Delivery Services, Users, and child- > Tenants under each Tenant > 3. Provide the ability to create at least 10 child-Tenant layers within the > system > 4. Make it easy to assign a User to a single Tenant so that they inherit > their permissions to all child-Tenants and Delivery Services. > 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant > hierarchy does not require re-assigning users. Users inherit pre-defined > permissions to new tenants and services added below their assigned layer in > the tenancy tree. > 6. Allow Users to be assigned multiple Tenants, each with different Roles. > While a user would inherit their access to all services and child Tenants > below them, they may need more restrictive access further up the Tenant > hierarchy or they may want different access to another branch of the tenant > tree. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol issue #403: [TC-184] Org tenancy - delivery service...
Github user nir-sopher commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/403 File was renamed as required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TC-240) DB Dump times out
[ https://issues.apache.org/jira/browse/TC-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Gelinas closed TC-240. Resolution: Fixed > DB Dump times out > - > > Key: TC-240 > URL: https://issues.apache.org/jira/browse/TC-240 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.0.0 >Reporter: Derek Gelinas >Assignee: Derek Gelinas > Fix For: 2.1.0 > > > When generating a DB dump, the operation eventually times out. The dump > command needs to be updated to prevent this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112417979 --- Diff: traffic_ops/app/db/migrations/2017040400_delivery_service_tenancy.sql --- @@ -0,0 +1,30 @@ +/* --- End diff -- OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-184) Tenant Hierarchy
[
https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976446#comment-15976446
]
ASF GitHub Bot commented on TC-184:
---
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418273
--- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ---
@@ -278,11 +278,22 @@ __PACKAGE__->table("deliveryservice");
default_value: false
is_nullable: 1
+=head2 multi_site_origin_algorithm
--- End diff --
Indeed.
For some reason it was not added in the commit creating multi site origin.
I tried to close this gap in PR 379
(https://github.com/apache/incubator-trafficcontrol/pull/379).
Would you like me to manually remove the changes from the file myself?
> Tenant Hierarchy
>
>
> Key: TC-184
> URL: https://issues.apache.org/jira/browse/TC-184
> Project: Traffic Control
> Issue Type: New Feature
> Components: Traffic Ops
>Reporter: Ryan Durfey
> Labels: Access, Tenancy
>
> Design under discussion here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910
> The requirements below are seed requirements and final design guidance should
> defer to the evolving wiki page discussion referenced above.
> Overview
> The goal of this system is to create a hierarchical tenancy system which is
> very simple to understand and administer and is highly expandable so that
> large organizations with many subsidiaries have the flexibility to create
> child-tenants to their liking.
> General Seed Requirements
> 1. Provide a structure to create a hierarchy of Tenants where each Tenant has
> a single parent-Tenant and can have multiple child-Tenants
> 2. Provide the ability to group multiple Delivery Services, Users, and child-
> Tenants under each Tenant
> 3. Provide the ability to create at least 10 child-Tenant layers within the
> system
> 4. Make it easy to assign a User to a single Tenant so that they inherit
> their permissions to all child-Tenants and Delivery Services.
> 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant
> hierarchy does not require re-assigning users. Users inherit pre-defined
> permissions to new tenants and services added below their assigned layer in
> the tenancy tree.
> 6. Allow Users to be assigned multiple Tenants, each with different Roles.
> While a user would inherit their access to all services and child Tenants
> below them, they may need more restrictive access further up the Tenant
> hierarchy or they may want different access to another branch of the tenant
> tree.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418273
--- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ---
@@ -278,11 +278,22 @@ __PACKAGE__->table("deliveryservice");
default_value: false
is_nullable: 1
+=head2 multi_site_origin_algorithm
--- End diff --
Indeed.
For some reason it was not added in the commit creating multi site origin.
I tried to close this gap in PR 379
(https://github.com/apache/incubator-trafficcontrol/pull/379).
Would you like me to manually remove the changes from the file myself?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TC-184) Tenant Hierarchy
[
https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976450#comment-15976450
]
ASF GitHub Bot commented on TC-184:
---
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418816
--- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ---
@@ -390,8 +401,12 @@ __PACKAGE__->add_columns(
{ data_type => "text", is_nullable => 1 },
"logs_enabled",
{ data_type => "boolean", default_value => \"false", is_nullable => 1 },
+ "multi_site_origin_algorithm",
--- End diff --
It is auto generated. Wouldn't it be better to except it or pull pr 379
(https://github.com/apache/incubator-trafficcontrol/pull/379) and merge?
> Tenant Hierarchy
>
>
> Key: TC-184
> URL: https://issues.apache.org/jira/browse/TC-184
> Project: Traffic Control
> Issue Type: New Feature
> Components: Traffic Ops
>Reporter: Ryan Durfey
> Labels: Access, Tenancy
>
> Design under discussion here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910
> The requirements below are seed requirements and final design guidance should
> defer to the evolving wiki page discussion referenced above.
> Overview
> The goal of this system is to create a hierarchical tenancy system which is
> very simple to understand and administer and is highly expandable so that
> large organizations with many subsidiaries have the flexibility to create
> child-tenants to their liking.
> General Seed Requirements
> 1. Provide a structure to create a hierarchy of Tenants where each Tenant has
> a single parent-Tenant and can have multiple child-Tenants
> 2. Provide the ability to group multiple Delivery Services, Users, and child-
> Tenants under each Tenant
> 3. Provide the ability to create at least 10 child-Tenant layers within the
> system
> 4. Make it easy to assign a User to a single Tenant so that they inherit
> their permissions to all child-Tenants and Delivery Services.
> 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant
> hierarchy does not require re-assigning users. Users inherit pre-defined
> permissions to new tenants and services added below their assigned layer in
> the tenancy tree.
> 6. Allow Users to be assigned multiple Tenants, each with different Roles.
> While a user would inherit their access to all services and child Tenants
> below them, they may need more restrictive access further up the Tenant
> hierarchy or they may want different access to another branch of the tenant
> tree.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TC-184) Tenant Hierarchy
[
https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976462#comment-15976462
]
ASF GitHub Bot commented on TC-184:
---
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112420550
--- Diff: traffic_ops/app/t/api/1.2/deliveryservice.t ---
@@ -30,302 +30,407 @@ use Test::TestHelper;
BEGIN { $ENV{MOJO_MODE} = "test" }
-my $schema = Schema->connect_to_database;
-my $dbh= Schema->database_handle;
-my $t = Test::Mojo->new('TrafficOps');
-Test::TestHelper->unload_core_data($schema);
-Test::TestHelper->load_core_data($schema);
-
-ok $t->post_ok( '/login', => form => { u => Test::TestHelper::ADMIN_USER,
p => Test::TestHelper::ADMIN_USER_PASSWORD } )->status_is(302)
- ->or( sub { diag $t->tx->res->content->asset->{content}; } ), 'Should
login?';
-
-# It gets existing delivery services
-ok $t->get_ok("/api/1.2/deliveryservices/list")->status_is(200)->or( sub {
diag $t->tx->res->content->asset->{content} } )
- ->json_is( "/response/0/xmlId", "steering-ds1" )
- ->json_is( "/response/0/logsEnabled", 0 )
- ->json_is( "/response/0/ipv6RoutingEnabled", 1 )
- ->json_is( "/response/1/xmlId", "steering-ds2" );
-
-ok
$t->get_ok("/api/1.2/deliveryservices/list?logsEnabled=true")->status_is(200)->or(
sub { diag $t->tx->res->content->asset->{content} } )
- ->json_is( "/response/0/xmlId", "test-ds1" )
- ->json_is( "/response/0/logsEnabled", 1 )
- ->json_is( "/response/0/ipv6RoutingEnabled", 1 )
- ->json_is( "/response/1/xmlId", "test-ds4" );
-
-# It creates new delivery services
-ok $t->post_ok('/api/1.2/deliveryservices/create' => {Accept =>
'application/json'} => json => {
-"xmlId" => "ds_1",
-"displayName" => "ds_displayname_1",
-"protocol" => "1",
-"orgServerFqdn" => "http://10.75.168.91";,
-"cdnName" => "cdn1",
-"profileName" => "CCR1",
-"type" => "HTTP",
-"multiSiteOrigin" => "0",
-"regionalGeoBlocking" => "1",
-"active" => "false",
-"matchList" => [
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "0",
-"pattern" => ".*\\.ds_1\\..*"
-},
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "1",
-"pattern" => ".*\\.my_vod1\\..*"
-}
-]})
-->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
-->json_is( "/response/xmlId" => "ds_1")
-->json_is( "/response/displayName" => "ds_displayname_1")
-->json_is( "/response/orgServerFqdn" => "http://10.75.168.91";)
-->json_is( "/response/cdnName" => "cdn1")
-->json_is( "/response/profileName" => "CCR1")
-->json_is( "/response/protocol" => "1")
-->json_is( "/response/type" => "HTTP")
-->json_is( "/response/multiSiteOrigin" => "0")
-->json_is( "/response/regionalGeoBlocking" => "1")
-->json_is( "/response/active" => "false")
-->json_is( "/response/matchList/0/type" => "HOST_REGEXP")
-->json_is( "/response/matchList/0/setNumber" => "0")
-->json_is( "/response/matchList/0/pattern" => ".*\\.ds_1\\..*")
-->json_is( "/response/matchList/1/type" => "HOST_REGEXP")
-->json_is( "/response/matchList/1/setNumber" => "1")
-->json_is( "/response/matchList/1/pattern" => ".*\\.my_vod1\\..*")
-, 'Does the deliveryservice details return?';
-
-ok $t->post_ok('/api/1.2/deliveryservices/create' => {Accept =>
'application/json'} => json => {
-"xmlId" => "ds_2",
-"displayName" => "ds_displayname_2",
-"protocol" => "1",
-"orgServerFqdn" => "http://10.75.168.91";,
-"cdnName" => "cdn1",
-"profileName" => "CCR1",
-"type" => "HTTP",
-"multiSiteOrigin" => "0",
-"regionalGeoBlocking" => "1",
-"active" => "false",
-"matchList" => [
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "0",
-"pattern" => ".*\\.ds_2\\..*"
-},
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "1",
-"pattern" => ".*\\.my_vod2\\..*"
-}
-]})
-->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
-->json_is( "/response/xmlId" => "ds_2")
-->json_is( "/resp
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112420550
--- Diff: traffic_ops/app/t/api/1.2/deliveryservice.t ---
@@ -30,302 +30,407 @@ use Test::TestHelper;
BEGIN { $ENV{MOJO_MODE} = "test" }
-my $schema = Schema->connect_to_database;
-my $dbh= Schema->database_handle;
-my $t = Test::Mojo->new('TrafficOps');
-Test::TestHelper->unload_core_data($schema);
-Test::TestHelper->load_core_data($schema);
-
-ok $t->post_ok( '/login', => form => { u => Test::TestHelper::ADMIN_USER,
p => Test::TestHelper::ADMIN_USER_PASSWORD } )->status_is(302)
- ->or( sub { diag $t->tx->res->content->asset->{content}; } ), 'Should
login?';
-
-# It gets existing delivery services
-ok $t->get_ok("/api/1.2/deliveryservices/list")->status_is(200)->or( sub {
diag $t->tx->res->content->asset->{content} } )
- ->json_is( "/response/0/xmlId", "steering-ds1" )
- ->json_is( "/response/0/logsEnabled", 0 )
- ->json_is( "/response/0/ipv6RoutingEnabled", 1 )
- ->json_is( "/response/1/xmlId", "steering-ds2" );
-
-ok
$t->get_ok("/api/1.2/deliveryservices/list?logsEnabled=true")->status_is(200)->or(
sub { diag $t->tx->res->content->asset->{content} } )
- ->json_is( "/response/0/xmlId", "test-ds1" )
- ->json_is( "/response/0/logsEnabled", 1 )
- ->json_is( "/response/0/ipv6RoutingEnabled", 1 )
- ->json_is( "/response/1/xmlId", "test-ds4" );
-
-# It creates new delivery services
-ok $t->post_ok('/api/1.2/deliveryservices/create' => {Accept =>
'application/json'} => json => {
-"xmlId" => "ds_1",
-"displayName" => "ds_displayname_1",
-"protocol" => "1",
-"orgServerFqdn" => "http://10.75.168.91";,
-"cdnName" => "cdn1",
-"profileName" => "CCR1",
-"type" => "HTTP",
-"multiSiteOrigin" => "0",
-"regionalGeoBlocking" => "1",
-"active" => "false",
-"matchList" => [
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "0",
-"pattern" => ".*\\.ds_1\\..*"
-},
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "1",
-"pattern" => ".*\\.my_vod1\\..*"
-}
-]})
-->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
-->json_is( "/response/xmlId" => "ds_1")
-->json_is( "/response/displayName" => "ds_displayname_1")
-->json_is( "/response/orgServerFqdn" => "http://10.75.168.91";)
-->json_is( "/response/cdnName" => "cdn1")
-->json_is( "/response/profileName" => "CCR1")
-->json_is( "/response/protocol" => "1")
-->json_is( "/response/type" => "HTTP")
-->json_is( "/response/multiSiteOrigin" => "0")
-->json_is( "/response/regionalGeoBlocking" => "1")
-->json_is( "/response/active" => "false")
-->json_is( "/response/matchList/0/type" => "HOST_REGEXP")
-->json_is( "/response/matchList/0/setNumber" => "0")
-->json_is( "/response/matchList/0/pattern" => ".*\\.ds_1\\..*")
-->json_is( "/response/matchList/1/type" => "HOST_REGEXP")
-->json_is( "/response/matchList/1/setNumber" => "1")
-->json_is( "/response/matchList/1/pattern" => ".*\\.my_vod1\\..*")
-, 'Does the deliveryservice details return?';
-
-ok $t->post_ok('/api/1.2/deliveryservices/create' => {Accept =>
'application/json'} => json => {
-"xmlId" => "ds_2",
-"displayName" => "ds_displayname_2",
-"protocol" => "1",
-"orgServerFqdn" => "http://10.75.168.91";,
-"cdnName" => "cdn1",
-"profileName" => "CCR1",
-"type" => "HTTP",
-"multiSiteOrigin" => "0",
-"regionalGeoBlocking" => "1",
-"active" => "false",
-"matchList" => [
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "0",
-"pattern" => ".*\\.ds_2\\..*"
-},
-{
-"type" => "HOST_REGEXP",
-"setNumber" => "1",
-"pattern" => ".*\\.my_vod2\\..*"
-}
-]})
-->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
-->json_is( "/response/xmlId" => "ds_2")
-->json_is( "/response/displayName" => "ds_displayname_2")
-->json_is( "/response/orgServerFqdn" => "http://10.75.168.91";)
-->json_is( "/response/cdnName" => "cdn1")
-->json_is( "/response/profileName" => "CCR1")
-->json_is( "/re
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418816
--- Diff: traffic_ops/app/lib/Schema/Result/Deliveryservice.pm ---
@@ -390,8 +401,12 @@ __PACKAGE__->add_columns(
{ data_type => "text", is_nullable => 1 },
"logs_enabled",
{ data_type => "boolean", default_value => \"false", is_nullable => 1 },
+ "multi_site_origin_algorithm",
--- End diff --
It is auto generated. Wouldn't it be better to except it or pull pr 379
(https://github.com/apache/incubator-trafficcontrol/pull/379) and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418640
--- Diff: traffic_ops/app/t/api/1.2/config_files_apache_traffic_server.t ---
@@ -72,7 +72,7 @@ my $count_response = sub {
return $t->success( is( scalar(@$r), $count ) );
};
-$t->get_ok('/api/1.2/deliveryservices/list?logsEnabled=true')->status_is(200)->$count_response(2)
+$t->get_ok('/api/1.2/deliveryservices/list?logsEnabled=true')->status_is(200)->$count_response(3)
--- End diff --
Actualy it is related. I added a DS with the tenant, and the DS has
"logsEnabled". So the count went fom 2 to 3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TC-184) Tenant Hierarchy
[
https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976449#comment-15976449
]
ASF GitHub Bot commented on TC-184:
---
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112418640
--- Diff: traffic_ops/app/t/api/1.2/config_files_apache_traffic_server.t ---
@@ -72,7 +72,7 @@ my $count_response = sub {
return $t->success( is( scalar(@$r), $count ) );
};
-$t->get_ok('/api/1.2/deliveryservices/list?logsEnabled=true')->status_is(200)->$count_response(2)
+$t->get_ok('/api/1.2/deliveryservices/list?logsEnabled=true')->status_is(200)->$count_response(3)
--- End diff --
Actualy it is related. I added a DS with the tenant, and the DS has
"logsEnabled". So the count went fom 2 to 3
> Tenant Hierarchy
>
>
> Key: TC-184
> URL: https://issues.apache.org/jira/browse/TC-184
> Project: Traffic Control
> Issue Type: New Feature
> Components: Traffic Ops
>Reporter: Ryan Durfey
> Labels: Access, Tenancy
>
> Design under discussion here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910
> The requirements below are seed requirements and final design guidance should
> defer to the evolving wiki page discussion referenced above.
> Overview
> The goal of this system is to create a hierarchical tenancy system which is
> very simple to understand and administer and is highly expandable so that
> large organizations with many subsidiaries have the flexibility to create
> child-tenants to their liking.
> General Seed Requirements
> 1. Provide a structure to create a hierarchy of Tenants where each Tenant has
> a single parent-Tenant and can have multiple child-Tenants
> 2. Provide the ability to group multiple Delivery Services, Users, and child-
> Tenants under each Tenant
> 3. Provide the ability to create at least 10 child-Tenant layers within the
> system
> 4. Make it easy to assign a User to a single Tenant so that they inherit
> their permissions to all child-Tenants and Delivery Services.
> 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant
> hierarchy does not require re-assigning users. Users inherit pre-defined
> permissions to new tenants and services added below their assigned layer in
> the tenancy tree.
> 6. Allow Users to be assigned multiple Tenants, each with different Roles.
> While a user would inherit their access to all services and child Tenants
> below them, they may need more restrictive access further up the Tenant
> hierarchy or they may want different access to another branch of the tenant
> tree.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TC-184) Tenant Hierarchy
[ https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976443#comment-15976443 ] ASF GitHub Bot commented on TC-184: --- Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112417979 --- Diff: traffic_ops/app/db/migrations/2017040400_delivery_service_tenancy.sql --- @@ -0,0 +1,30 @@ +/* --- End diff -- OK > Tenant Hierarchy > > > Key: TC-184 > URL: https://issues.apache.org/jira/browse/TC-184 > Project: Traffic Control > Issue Type: New Feature > Components: Traffic Ops >Reporter: Ryan Durfey > Labels: Access, Tenancy > > Design under discussion here: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910 > The requirements below are seed requirements and final design guidance should > defer to the evolving wiki page discussion referenced above. > Overview > The goal of this system is to create a hierarchical tenancy system which is > very simple to understand and administer and is highly expandable so that > large organizations with many subsidiaries have the flexibility to create > child-tenants to their liking. > General Seed Requirements > 1. Provide a structure to create a hierarchy of Tenants where each Tenant has > a single parent-Tenant and can have multiple child-Tenants > 2. Provide the ability to group multiple Delivery Services, Users, and child- > Tenants under each Tenant > 3. Provide the ability to create at least 10 child-Tenant layers within the > system > 4. Make it easy to assign a User to a single Tenant so that they inherit > their permissions to all child-Tenants and Delivery Services. > 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant > hierarchy does not require re-assigning users. Users inherit pre-defined > permissions to new tenants and services added below their assigned layer in > the tenancy tree. > 6. Allow Users to be assigned multiple Tenants, each with different Roles. > While a user would inherit their access to all services and child Tenants > below them, they may need more restrictive access further up the Tenant > hierarchy or they may want different access to another branch of the tenant > tree. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-184) Tenant Hierarchy
[ https://issues.apache.org/jira/browse/TC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976374#comment-15976374 ] ASF GitHub Bot commented on TC-184: --- Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112409155 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -168,6 +168,8 @@ Delivery Service +--++--+ | ``sslKeyVersion``| int | | +--++--+ + | ``tenantId`` | int| Owning tenant ID | --- End diff -- Yes. I plan to do so in a separate PR after Ori's PR for adding it to the user is in. > Tenant Hierarchy > > > Key: TC-184 > URL: https://issues.apache.org/jira/browse/TC-184 > Project: Traffic Control > Issue Type: New Feature > Components: Traffic Ops >Reporter: Ryan Durfey > Labels: Access, Tenancy > > Design under discussion here: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68715910 > The requirements below are seed requirements and final design guidance should > defer to the evolving wiki page discussion referenced above. > Overview > The goal of this system is to create a hierarchical tenancy system which is > very simple to understand and administer and is highly expandable so that > large organizations with many subsidiaries have the flexibility to create > child-tenants to their liking. > General Seed Requirements > 1. Provide a structure to create a hierarchy of Tenants where each Tenant has > a single parent-Tenant and can have multiple child-Tenants > 2. Provide the ability to group multiple Delivery Services, Users, and child- > Tenants under each Tenant > 3. Provide the ability to create at least 10 child-Tenant layers within the > system > 4. Make it easy to assign a User to a single Tenant so that they inherit > their permissions to all child-Tenants and Delivery Services. > 5. Adding child-Tenants or Delivery Services anywhere in an existing tenant > hierarchy does not require re-assigning users. Users inherit pre-defined > permissions to new tenants and services added below their assigned layer in > the tenancy tree. > 6. Allow Users to be assigned multiple Tenants, each with different Roles. > While a user would inherit their access to all services and child Tenants > below them, they may need more restrictive access further up the Tenant > hierarchy or they may want different access to another branch of the tenant > tree. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-trafficcontrol pull request #403: [TC-184] Org tenancy - delivery ...
Github user nir-sopher commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/403#discussion_r112409155 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -168,6 +168,8 @@ Delivery Service +--++--+ | ``sslKeyVersion``| int | | +--++--+ + | ``tenantId`` | int| Owning tenant ID | --- End diff -- Yes. I plan to do so in a separate PR after Ori's PR for adding it to the user is in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
