[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[rob05c]

Github user rob05c commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130758948
  
--- Diff: docs/source/admin/traffic_ops/configuration.rst ---
@@ -296,5 +296,8 @@ This is a standard kickstart formatted file that the 
generate ISO process uses t
 .. seealso:: For in-depth instructions, please see `Kickstart Installation 
`_
 
 
+Configuring the Go Application
+===
+Traffic Ops is in the process of migrating from Perl to Go, and currently 
runs as two applications. The Go application serves all endpoints which have 
been rewritten in the Go language, and transparently proxies all other requests 
to the old Perl application. Both applications are installed by the RPM, and 
both run as a single service. When the project has fully migrated to Go, the 
Perl application will be removed, and the RPM and service will consist solely 
of the Go application.
 
-
+By default, the postinstall script configures the Go application to behave 
and transparently serve as the old Perl Traffic Ops did in previous versions. 
This includes reading the old ``cdn.conf`` and ``database.conf`` config files, 
and logging to the old ``access.log`` location. However, if you wish to 
customize the Go Traffic Ops application, you can do so by running it with the 
``-oldcfg=false`` argument. By default, it will then look for a config file in 
``/opt/traffic_ops/conf/traffic_ops_golang.json``. The new config file location 
may also be customized via the ``-cfg`` flag. A sample config file is installed 
by the RPM at ``/opt/traffic_ops/conf/traffic_ops_golang.json``. If you wish to 
run the new Go Traffic Ops application as a service with a new config file, the 
``-oldcfg=false`` and  ``-cfg`` flags may be added to the ``start`` function in 
the service file, located by default at ``etc/init.d/traffic_ops``.
--- End diff --

Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[rob05c]

Github user rob05c commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130754867
  
--- Diff: 
traffic_ops/traffic_ops_golang/vendor/gopkg.in/DATA-DOG/go-sqlmock/LICENSE ---
@@ -0,0 +1,28 @@
+The three clause BSD license (http://en.wikipedia.org/wiki/BSD_licenses)
+
--- End diff --

Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo updated TC-491:
-
Description: 
Deleting Delivery Service with associated job in job table fails due to foreign 
key constraint violation.

E.g.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
key constraint "fk_job_deliveryservice1" on table "job"
DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
"DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
/opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642

Workaround: No UI/API end-point to delete the associated job.  Delete 
associated job from database.

NOTE: Other Traffic Ops versions may also be affected.

  was:
Deleting Delivery Service with associated job in job table fails due to foreign 
key constraint violation.

E.g.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
key constraint "fk_job_deliveryservice1" on table "job"
DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
"DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
/opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642

Workaround: No API end-point to delete the associated job.  Delete associated 
job from database.

NOTE: Other Traffic Ops versions may also be affected.


> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Priority: Critical
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No UI/API end-point to delete the associated job.  Delete 
> associated job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[Robert Scrimo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scrimo updated TC-491:
-
Priority: Critical  (was: Major)

> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation
> 
>
> Key: TC-491
> URL: https://issues.apache.org/jira/browse/TC-491
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Robert Scrimo
>Priority: Critical
>
> Deleting Delivery Service with associated job in job table fails due to 
> foreign key constraint violation.
> E.g.
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
> failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
> key constraint "fk_job_deliveryservice1" on table "job"
> DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
> "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
> /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642
> Workaround: No API end-point to delete the associated job.  Delete associated 
> job from database.
> NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-493) API documentation is not accurate for API Server Create and Update end-points

[Robert Scrimo (JIRA)]

Robert Scrimo created TC-493:


 Summary: API documentation is not accurate for API Server Create 
and Update end-points
 Key: TC-493
 URL: https://issues.apache.org/jira/browse/TC-493
 Project: Traffic Control
  Issue Type: Bug
  Components: Documentation, Traffic Ops API
Affects Versions: 2.1.0
Reporter: Robert Scrimo


API documentation is not accurate to functionality and lite on details for API 
Server Create and Update end-points.

Also, it may be a good idea to check over the entire Server API documentation 
for accuracy while this work is being done.

NOTE: Other versions of Traffic Ops may be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-492) Deleting Delivery Service with associated static dns entry(s) in staticdnsentry table fails due to foreign key constraint violation

[Robert Scrimo (JIRA)]

Robert Scrimo created TC-492:


 Summary: Deleting Delivery Service with associated static dns 
entry(s) in staticdnsentry table fails due to foreign key constraint violation
 Key: TC-492
 URL: https://issues.apache.org/jira/browse/TC-492
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops API
Affects Versions: 2.1.0
Reporter: Robert Scrimo


Deleting Delivery Service with associated static dns entry in staticdnsentry 
table fails due to foreign key constraint violation.

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
key constraint "fk_staticdnsentry_ds" on table "staticdnsentry"
DETAIL:  Key (id)=(180) is still referenced from table "staticdnsentry". [for 
Statement "DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 
1='180'] at /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642

Workaround: A hack is to use the UI end-point GET "/staticdnsentry/:id/delete" 
to remove the association(s) before deleting the delivery service.

NOTE: Other versions of Traffic Ops may be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-491) Deleting Delivery Service with associated job in job table fails due to foreign key constraint violation

[Robert Scrimo (JIRA)]

Robert Scrimo created TC-491:


 Summary: Deleting Delivery Service with associated job in job 
table fails due to foreign key constraint violation
 Key: TC-491
 URL: https://issues.apache.org/jira/browse/TC-491
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops API
Affects Versions: 2.1.0
Reporter: Robert Scrimo


Deleting Delivery Service with associated job in job table fails due to foreign 
key constraint violation.

E.g.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  update or delete on table "deliveryservice" violates foreign 
key constraint "fk_job_deliveryservice1" on table "job"
DETAIL:  Key (id)=(714) is still referenced from table "job". [for Statement 
"DELETE FROM deliveryservice WHERE ( id = ? )" with ParamValues: 1='714'] at 
/opt/traffic_ops/app/lib/API/Deliveryservice.pm line 642

Workaround: No API end-point to delete the associated job.  Delete associated 
job from database.

NOTE: Other Traffic Ops versions may also be affected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130711484
  
--- Diff: traffic_monitor_golang/traffic_monitor/config/config.go ---
@@ -21,7 +21,6 @@ package config
 
--- End diff --

Heh, I'm too slow. Apparently a second PR is the right answer. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130710775
  
--- Diff: traffic_monitor_golang/traffic_monitor/config/config.go ---
@@ -21,7 +21,6 @@ package config
 
--- End diff --

Should the TM changes go in a separate PR on which this one depends, or are 
you suggesting we branch the log package and keep a separate one for TM and TO?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[rob05c]

Github user rob05c commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130709846
  
--- Diff: traffic_monitor_golang/traffic_monitor/config/config.go ---
@@ -21,7 +21,6 @@ package config
 
--- End diff --

The config changes have been moved into 
https://github.com/apache/incubator-trafficcontrol/pull/620 which has been 
merged. I'll rebase this to remove them and resolve the conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[dewrich]

Github user dewrich commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130709645
  
--- Diff: traffic_ops/traffic_ops_golang/monitoring.go ---
@@ -1,90 +1,45 @@
-// Licensed under the Apache License, Version 2.0 (the "License");
--- End diff --

sorry I got lost when I was popping back and forth for this review, I see 
what you mean now



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[dewrich]

Github user dewrich commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130709534
  
--- Diff: traffic_monitor_golang/traffic_monitor/config/config.go ---
@@ -21,7 +21,6 @@ package config
 
--- End diff --

I disagree with TM changes being in the PR because one of the dependencies 
changed, the smaller we can keep this PR the easier it is to merge (and less 
conflicts) we have to deal with


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #768: Tenant parent - on delete cascade

[nir-sopher]

Github user nir-sopher commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/768
  
Thanks for the feedback!
I was struggling myself what is the correct solution (and therefore the wip)

I started dealing with this issue as I noticed that when my UT crashes,
prove can no longer be run until I "reset" the DB.
The reason for that was that my UT added a child tenant to the defaults set
of tenants, and crashed, leaving this tenant defined. When tear-down was
called, the "delete table" for the "Tenant" table failed, trying to delete
the parent tenant before the child.

There are 2 ways I can see to fix this issue.
1. Write a custom "delete all tenants" function, to be used in tear-down.
The function will delete the tenants in the correct order.
2. Use "ON DELETE CASCADE" - which seems to be common the common practice
in traffic-ops DB.

Is there another way to cascade delete the entire table for the sole
usecase of tear-down?

On Aug 1, 2017 8:02 PM, "Matt Mills"  wrote:

> In that case, why would this be an ON DELETE CASCADE, rather than an ON
> DELETE RESTRICT?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/733
  
One last thing, can you update the documentation 
[here](https://github.com/apache/incubator-trafficcontrol/tree/master/docs/source/development/traffic_ops_api)?
  It doesn't look there is any `urlkey` docs.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #769: Fix TM2 crashing with malformed ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/769


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #620: Add Golang log nil logger suppor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...

[DylanVolz]

Github user DylanVolz commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/733
  
I have reverted the UI changes, and this PR is ready to be evaluated as an 
API change only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TC-489) Multi Site Origin - Invalid default values for multiple config params

[Matt Mills (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Mills updated TC-489:
--
Description: 
Several of the multi site origin parameters default to 0 (including 
mso.algorithm, possibly others ), which is an invalid argument.
   valid values: true, strict, proxy1, false, consistent_hash

   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
{code}
   L2051: $text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring 
go_direct=false parent_is_proxy=false";
{code}

{code}
   parent.config: dest_domain=google.com port=443 ... round_robin=0 ...
{code}
{code}
   [Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
invalid argument to round_robin directive at line 2
{code}

  was:
Several of the multi site origin parameters default to 0 (including 
mso.algorithm, possibly others ), which is an invalid argument.
   valid values: true, strict, proxy1, false, consistent_hash

   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
{code}
   L2051: $text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring 
go_direct=false parent_is_proxy=false";
{code}
   parent.config: dest_domain=google.com port=443 ... round_robin=0 ...


   [Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
invalid argument to round_robin directive at line 2



> Multi Site Origin - Invalid default values for multiple config params
> -
>
> Key: TC-489
> URL: https://issues.apache.org/jira/browse/TC-489
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops, Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Matt Mills
>Priority: Blocker
>
> Several of the multi site origin parameters default to 0 (including 
> mso.algorithm, possibly others ), which is an invalid argument.
>valid values: true, strict, proxy1, false, consistent_hash
>
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
> {code}
>L2051: $text .= "$parents round_robin=$mso_algorithm 
> qstring=$parent_qstring go_direct=false parent_is_proxy=false";
> {code}
> {code}
>parent.config: dest_domain=google.com port=443 ... round_robin=0 ...
> {code}
> {code}
>[Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
> invalid argument to round_robin directive at line 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TC-489) Multi Site Origin - Invalid default values for multiple config params

[Matt Mills (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Mills updated TC-489:
--
Description: 
Several of the multi site origin parameters default to 0 (including 
mso.algorithm, possibly others ), which is an invalid argument.
   valid values: true, strict, proxy1, false, consistent_hash

   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
{code}
   L2051: $text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring 
go_direct=false parent_is_proxy=false";
{code}
   parent.config: dest_domain=google.com port=443 ... round_robin=0 ...


   [Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
invalid argument to round_robin directive at line 2


  was:
Several of the multi site origin parameters default to 0 (including 
mso.algorithm, possibly others ), which is an invalid argument.
   valid: true, strict, proxy1, false, consistent_hash
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
   L2051: $text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring 
go_direct=false parent_is_proxy=false";
   parent.config: dest_domain=google.com port=443 ... round_robin=0 ...
   [Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
invalid argument to round_robin directive at line 2



> Multi Site Origin - Invalid default values for multiple config params
> -
>
> Key: TC-489
> URL: https://issues.apache.org/jira/browse/TC-489
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops, Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Matt Mills
>Priority: Blocker
>
> Several of the multi site origin parameters default to 0 (including 
> mso.algorithm, possibly others ), which is an invalid argument.
>valid values: true, strict, proxy1, false, consistent_hash
>
> https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
> {code}
>L2051: $text .= "$parents round_robin=$mso_algorithm 
> qstring=$parent_qstring go_direct=false parent_is_proxy=false";
> {code}
>parent.config: dest_domain=google.com port=443 ... round_robin=0 ...
>[Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
> invalid argument to round_robin directive at line 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TC-490) mso.qstring_handling parameter is checked but not documented

[Matt Mills (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Mills updated TC-490:
--
Description: 
mso.qstring_handling not listed in docs, seems to be defined elsewhere as 
psel.qstring_handling
   but MID parent selection code checks if mso.qstring_handling is not defined
{code}
   my $qsh= 
$ds->{'param'}->{'parent.config'}->{'mso.qstring_handling'};
   my $parent_qstring = "ignore";   
   # default is ignore, unless for alg consistent_hash
   if ( !defined($qsh) && $mso_algorithm eq 'consistent_hash' && 
$ds->{qstring_ignore} == 0 ) {
  $parent_qstring = 'consider';
   }

{code}

The parameter is unlikely to ever exist, since it's not documented anywhere, 
but either way either the code should be corrected or the documentation should 
be.


  was:
mso.qstring_handling not listed in docs, seems to be defined elsewhere as 
psel.qstring_handling
   but MID parent selection code checks if mso.qstring_handling is not defined

   my $qsh= 
$ds->{'param'}->{'parent.config'}->{'mso.qstring_handling'};
   my $parent_qstring = "ignore";   
   # default is ignore, unless for alg consistent_hash
   if ( !defined($qsh) && $mso_algorithm eq 'consistent_hash' && 
$ds->{qstring_ignore} == 0 ) {
  $parent_qstring = 'consider';
   }



The parameter is unlikely to ever exist, since it's not documented anywhere, 
but either way either the code should be corrected or the documentation should 
be.



> mso.qstring_handling parameter is checked but not documented
> 
>
> Key: TC-490
> URL: https://issues.apache.org/jira/browse/TC-490
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Matt Mills
>Priority: Blocker
>
> mso.qstring_handling not listed in docs, seems to be defined elsewhere as 
> psel.qstring_handling
>but MID parent selection code checks if mso.qstring_handling is not defined
> {code}
>my $qsh= 
> $ds->{'param'}->{'parent.config'}->{'mso.qstring_handling'};
>my $parent_qstring = "ignore"; 
>  # default is ignore, unless for alg consistent_hash
>if ( !defined($qsh) && $mso_algorithm eq 'consistent_hash' && 
> $ds->{qstring_ignore} == 0 ) {
>   $parent_qstring = 'consider';
>}
> {code}
> The parameter is unlikely to ever exist, since it's not documented anywhere, 
> but either way either the code should be corrected or the documentation 
> should be.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-490) mso.qstring_handling parameter is checked but not documented

[Matt Mills (JIRA)]

Matt Mills created TC-490:
-

 Summary: mso.qstring_handling parameter is checked but not 
documented
 Key: TC-490
 URL: https://issues.apache.org/jira/browse/TC-490
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops API
Affects Versions: 2.1.0
Reporter: Matt Mills
Priority: Blocker


mso.qstring_handling not listed in docs, seems to be defined elsewhere as 
psel.qstring_handling
   but MID parent selection code checks if mso.qstring_handling is not defined

   my $qsh= 
$ds->{'param'}->{'parent.config'}->{'mso.qstring_handling'};
   my $parent_qstring = "ignore";   
   # default is ignore, unless for alg consistent_hash
   if ( !defined($qsh) && $mso_algorithm eq 'consistent_hash' && 
$ds->{qstring_ignore} == 0 ) {
  $parent_qstring = 'consider';
   }



The parameter is unlikely to ever exist, since it's not documented anywhere, 
but either way either the code should be corrected or the documentation should 
be.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol issue #768: Tenant parent - on delete cascade

[MattMills]

Github user MattMills commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/768
  
In that case, why would this be an ON DELETE CASCADE, rather than an ON 
DELETE RESTRICT? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-489) Multi Site Origin - Invalid default values for multiple config params

[Matt Mills (JIRA)]

Matt Mills created TC-489:
-

 Summary: Multi Site Origin - Invalid default values for multiple 
config params
 Key: TC-489
 URL: https://issues.apache.org/jira/browse/TC-489
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops, Traffic Ops API
Affects Versions: 2.1.0
Reporter: Matt Mills
Priority: Blocker


Several of the multi site origin parameters default to 0 (including 
mso.algorithm, possibly others ), which is an invalid argument.
   valid: true, strict, proxy1, false, consistent_hash
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L2051
   L2051: $text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring 
go_direct=false parent_is_proxy=false";
   parent.config: dest_domain=google.com port=443 ... round_robin=0 ...
   [Jul 12 02:25:45.987] Server {0x2b54fb7db940} ERROR: [ParentSelection] 
invalid argument to round_robin directive at line 2




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-488) Docs - Multi Site Origin not up to date

[Matt Mills (JIRA)]

Matt Mills created TC-488:
-

 Summary: Docs - Multi Site Origin not up to date
 Key: TC-488
 URL: https://issues.apache.org/jira/browse/TC-488
 Project: Traffic Control
  Issue Type: Bug
  Components: Documentation
Affects Versions: 2.1.0
Reporter: Matt Mills
Priority: Blocker


Current documentation for multi site origin is confusing/wrong/out of date:


   
https://github.com/apache/incubator-trafficcontrol/blob/master/docs/source/admin/quick_howto/multi_site.rst
   Bottom has steps that references configuration that I think has been 
replaced with delivery service profiles.
   
https://github.com/apache/incubator-trafficcontrol/blob/master/docs/source/admin/traffic_ops/using.rst
   mentions the new delivery service profile pieces, but not the cachegroup 
side of multi-site configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TC-487) Multi Site Origin config gets applied even when no valid parents

[Matt Mills (JIRA)]

Matt Mills created TC-487:
-

 Summary: Multi Site Origin config gets applied even when no valid 
parents
 Key: TC-487
 URL: https://issues.apache.org/jira/browse/TC-487
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops
Affects Versions: 2.1.0
Reporter: Matt Mills
Priority: Minor


If MSO is not properly configured with origin servers but is configured with 
multi site origin, it will install the multi site origin parent.config with no 
parent servers listed.


   (Mine had the origin servers in a non ORG type cache group, this generated 
parent="" in the config)
   parent.config: dest_domain=google.com port=443 parent="" ...
   Jul 12 01:26:46 lab-ats-mid-2.local traffic_server[3916]: {0x2ae9206f1940} 
ERROR: [ParentSelection] No parents specified at line 2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109274#comment-16109274
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/770


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/770


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109271#comment-16109271
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661794
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -82,7 +82,7 @@ sub update {
my $target_ds_id   = $self->param('target_id');
my $params = $self->req->json;
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109273#comment-16109273
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661827
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -134,7 +134,7 @@ sub create {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $params->{targetId};
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109272#comment-16109272
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661816
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -185,7 +185,7 @@ sub delete {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $self->param('target_id');
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661827
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -134,7 +134,7 @@ sub create {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $params->{targetId};
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661816
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -185,7 +185,7 @@ sub delete {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $self->param('target_id');
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130661794
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -82,7 +82,7 @@ sub update {
my $target_ds_id   = $self->param('target_id');
my $params = $self->req->json;
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

nvm, since its not this is fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #768: Tenant parent - on delete cascade

[nir-sopher]

Github user nir-sopher commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/768
  
The change is in the db definition

On Aug 1, 2017 7:42 PM, "Nir Sopher"  wrote:

> Indeed. The api and the new portal does not allow tenant deletion if child
> exists.
> The legacy UI does not deal with tenacy at all.
>
> On Aug 1, 2017 7:34 PM, "Matt Mills"  wrote:
>
>> IMO the UI should just throw an error when you try to delete a tenant
>> that has children, rather than delete the children.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> 
,
>> or mute the thread
>> 

>> .
>>
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #768: Tenant parent - on delete cascade

[nir-sopher]

Github user nir-sopher commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/768
  
Indeed. The api and the new portal does not allow tenant deletion if child
exists.
The legacy UI does not deal with tenacy at all.

On Aug 1, 2017 7:34 PM, "Matt Mills"  wrote:

> IMO the UI should just throw an error when you try to delete a tenant that
> has children, rather than delete the children.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109244#comment-16109244
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659093
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -82,7 +82,7 @@ sub update {
my $target_ds_id   = $self->param('target_id');
my $params = $self->req->json;
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109245#comment-16109245
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659137
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -185,7 +185,7 @@ sub delete {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $self->param('target_id');
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109243#comment-16109243
 ] 

ASF GitHub Bot commented on TC-486:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659120
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -134,7 +134,7 @@ sub create {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $params->{targetId};
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659120
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -134,7 +134,7 @@ sub create {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $params->{targetId};
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659137
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -185,7 +185,7 @@ sub delete {
my $steering_ds_id = $self->param('id');
my $target_ds_id   = $self->param('target_id');
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[dneuman64]

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/770#discussion_r130659093
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -82,7 +82,7 @@ sub update {
my $target_ds_id   = $self->param('target_id');
my $params = $self->req->json;
 
-   if ( !_admin($self) ) {
+   if ( !_admin($self) && !_steering($self) ) {
--- End diff --

should this be an OR not an AND?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #729: Traffic Ops Golang Incremental Rewrite ...

[dewrich]

Github user dewrich commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/729
  
My main concern with fine grained control over database connections is that 
this service will co-exist with Mojolicious TO database connections, so we have 
to make sure they both can co-exist in the short term without adverse effects.  

Since Golang is more efficient with connection use, I want the ability to 
carve out a smaller pool of connections to minimize Postgres "out of 
connections" errors.  As long as controlling "Idle" connections doesn't affect 
this goal, I'm ok with excluding `db.SetMaxIdleConns(n int)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #729: Traffic Ops Golang Incremental Rewrite ...

[rob05c]

Github user rob05c commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/729
  
I'll make the config for `MaxOpenConns`. I looked in the Go source, and Go 
will block if it hits that limit, rather than asynchronously returning an 
error. Which should be fine.

I'd vote we omit `MaxIdleConns` and `ConnMaxLifetime`, until we find a 
need. `MaxIdleConns` is strictly less than `MaxOpenConns`, and it shouldn't 
hurt to leave them around, especially for a web service that continuously uses 
them. It's not reasonable for a SQL server to have a max connection lifetime, 
web services keeping connections forever is typical, so leaving that infinite 
should be fine too.

Every additional config is more operations cost to deploy, so we should 
keep configs to a minimum until someone has a need.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/733
  
ok, so I think at least some of these issues are with my environment. 
After talking with Dylan we decided it's best to remove the UI components 
from the PR, leave in the API components and then he will submit a new PR which 
adds the functionality to the new Traffic Portal UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[rob05c]

Github user rob05c commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130630953
  
--- Diff: docs/source/admin/traffic_ops/configuration.rst ---
@@ -296,5 +296,8 @@ This is a standard kickstart formatted file that the 
generate ISO process uses t
 .. seealso:: For in-depth instructions, please see `Kickstart Installation 
`_
 
 
+Configuring the Go Application
+===
+Traffic Ops is in the process of migrating from Perl to Go, and currently 
runs as two applications. The Go application serves all endpoints which have 
been rewritten in the Go language, and transparently proxies all other requests 
to the old Perl application. Both applications are installed by the RPM, and 
both run as a single service. When the project has fully migrated to Go, the 
Perl application will be removed, and the RPM and service will consist solely 
of the Go application.
 
-
+By default, the postinstall script configures the Go application to behave 
and transparently serve as the old Perl Traffic Ops did in previous versions. 
This includes reading the old ``cdn.conf`` and ``database.conf`` config files, 
and logging to the old ``access.log`` location. However, if you wish to 
customize the Go Traffic Ops application, you can do so by running it with the 
``-oldcfg=false`` argument. By default, it will then look for a config file in 
``/opt/traffic_ops/conf/traffic_ops_golang.json``. The new config file location 
may also be customized via the ``-cfg`` flag. A sample config file is installed 
by the RPM at ``/opt/traffic_ops/conf/traffic_ops_golang.json``. If you wish to 
run the new Go Traffic Ops application as a service with a new config file, the 
``-oldcfg=false`` and  ``-cfg`` flags may be added to the ``start`` function in 
the service file, located by default at ``etc/init.d/traffic_ops``.
--- End diff --

Ah, you're right. I meant to rename the file and forgot. I'll change the 
documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #729: Traffic Ops Golang Incremental Rewrite ...

[dewrich]

Github user dewrich commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/729
  
As I was performance testing I noticed we don't have any "gates" on the 
number of concurrent connections coming into the monitoring service.  As 
mentioned, the following database pooling parameters need to be implemented and 
configurable:

`db.SetMaxOpenConns(n int)`
`db.SetMaxIdleConns(n int)`

and maybe this one?

`db.SetConnMaxLifetime(d time.Duration)`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #729: Traffic Ops Golang Incremental R...

[dewrich]

Github user dewrich commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/729#discussion_r130626620
  
--- Diff: docs/source/admin/traffic_ops/configuration.rst ---
@@ -296,5 +296,8 @@ This is a standard kickstart formatted file that the 
generate ISO process uses t
 .. seealso:: For in-depth instructions, please see `Kickstart Installation 
`_
 
 
+Configuring the Go Application
+===
+Traffic Ops is in the process of migrating from Perl to Go, and currently 
runs as two applications. The Go application serves all endpoints which have 
been rewritten in the Go language, and transparently proxies all other requests 
to the old Perl application. Both applications are installed by the RPM, and 
both run as a single service. When the project has fully migrated to Go, the 
Perl application will be removed, and the RPM and service will consist solely 
of the Go application.
 
-
+By default, the postinstall script configures the Go application to behave 
and transparently serve as the old Perl Traffic Ops did in previous versions. 
This includes reading the old ``cdn.conf`` and ``database.conf`` config files, 
and logging to the old ``access.log`` location. However, if you wish to 
customize the Go Traffic Ops application, you can do so by running it with the 
``-oldcfg=false`` argument. By default, it will then look for a config file in 
``/opt/traffic_ops/conf/traffic_ops_golang.json``. The new config file location 
may also be customized via the ``-cfg`` flag. A sample config file is installed 
by the RPM at ``/opt/traffic_ops/conf/traffic_ops_golang.json``. If you wish to 
run the new Go Traffic Ops application as a service with a new config file, the 
``-oldcfg=false`` and  ``-cfg`` flags may be added to the ``start`` function in 
the service file, located by default at ``etc/init.d/traffic_ops``.
--- End diff --

where do I find this `/opt/traffic_ops/conf/traffic_ops_golang.json` I only 
see `/opt/traffic_ops/conf/traffic_ops_golang.config` in the project, which is 
why I commented on it being documented as `.json`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...

[dneuman64]

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/733
  
A few things with this PR:  
1) If I choose to copy URL Sig keys the "From which DS" drop down is never 
populated
2) It looks like the all of the buttons that used to be conditional (Manage 
SSL Keys, Manage Steering Assignments, Create URL Sig Keys, etc) are now always 
show.
3) Adding two more buttons creates some collisions with the close button 
depending upon the options you have chose.
4) I think it would be cleaner to have a "manage URL Sig Keys" button 
rather than a generate and a copy

This PR has been out there for a while and I have been promising to review 
and haven't so I think I am going to see if I can clean some of this up quickly 
and PR it back to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (TC-486) Add steering role to steering apis

[Jeremy Mitchell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Mitchell reassigned TC-486:
--

Assignee: Jeremy Mitchell

> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-486) Add steering role to steering apis

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108942#comment-16108942
 ] 

ASF GitHub Bot commented on TC-486:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/770

[TC-486] - adds steering role to steering apis



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
adds-steering-role

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #770


commit c76be0cb69ba7e3cfa3bcf2894cd3dffe130f0e2
Author: Jeremy Mitchell 
Date:   2017-08-01T13:54:00Z

adds steering role to steering apis




> Add steering role to steering apis
> --
>
> Key: TC-486
> URL: https://issues.apache.org/jira/browse/TC-486
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Ops API
>Reporter: Jeremy Mitchell
>Priority: Minor
>
> Create, update and delete of steering targets should be available to users 
> with the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/770

[TC-486] - adds steering role to steering apis



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
adds-steering-role

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #770


commit c76be0cb69ba7e3cfa3bcf2894cd3dffe130f0e2
Author: Jeremy Mitchell 
Date:   2017-08-01T13:54:00Z

adds steering role to steering apis




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TC-486) Add steering role to steering apis

[Jeremy Mitchell (JIRA)]

Jeremy Mitchell created TC-486:
--

 Summary: Add steering role to steering apis
 Key: TC-486
 URL: https://issues.apache.org/jira/browse/TC-486
 Project: Traffic Control
  Issue Type: Bug
  Components: Traffic Ops API
Reporter: Jeremy Mitchell
Priority: Minor


Create, update and delete of steering targets should be available to users with 
the "steering" role.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)