[GitHub] incubator-trafficcontrol issue #839: Add TO Go monitoring route prepared sta...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/839 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/60/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #839: Add TO Go monitoring route prepared sta...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/839 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/100/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #839: Add TO Go monitoring route prepared sta...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/839 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/62/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #839: Add TO Go monitoring route prepa...
GitHub user rob05c opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/839 Add TO Go monitoring route prepared statements You can merge this pull request into a Git repository by running: $ git pull https://github.com/rob05c/incubator-trafficcontrol to-monitoringstmt Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/839.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #839 commit 0b37c9ea2832e0d27b7e8dce68001b54bf82a36a Author: Robert Butts Date: 2017-08-19T03:23:12Z Add TO Go monitoring route prepared statements --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133584#comment-16133584 ] ASF GitHub Bot commented on TC-541: --- Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 @dneuman64 will be looking at this one > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 @dneuman64 will be looking at this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-296) ANY_MAP doesn't get applied to the mids
[ https://issues.apache.org/jira/browse/TC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133575#comment-16133575 ] Jan van Doorn commented on TC-296: -- I don't think this is must-fix for 2.1 > ANY_MAP doesn't get applied to the mids > --- > > Key: TC-296 > URL: https://issues.apache.org/jira/browse/TC-296 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.1.0, 2.0.0, 2.2.0 >Reporter: Eric Friedrich >Priority: Minor > Labels: any_map, remap.conf > Fix For: 2.2.0 > > > Delivery services of type ANY_MAP only gets a line in remap.conf for caches > of type EDGE. > https://github.com/Comcast/traffic_control/issues/740 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hank Beatty closed TC-441. -- Resolution: Fixed > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133553#comment-16133553 ] ASF GitHub Bot commented on TC-441: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/838 > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133555#comment-16133555 ] ASF GitHub Bot commented on TC-441: --- Github user hbeatty commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 @mitchell852 merged - please close > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #838: [BACKPORT] [TC-441] - hooks up password...
Github user hbeatty commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 @mitchell852 merged - please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #838: [BACKPORT] [TC-441] - hooks up p...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/838 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/99/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133544#comment-16133544 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/99/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133541#comment-16133541 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/61/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133540#comment-16133540 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/59/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/61/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/59/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (TC-518) ToCDUCheck and ToCHRCheck: Value formatted as float instead of int
[ https://issues.apache.org/jira/browse/TC-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Malenfant reassigned TC-518: -- Assignee: Steve Malenfant > ToCDUCheck and ToCHRCheck: Value formatted as float instead of int > -- > > Key: TC-518 > URL: https://issues.apache.org/jira/browse/TC-518 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.1.0, 2.0.0, 2.2.0 >Reporter: Steve Malenfant >Assignee: Steve Malenfant >Priority: Trivial > Fix For: 2.1.0, 2.2.0 > > > CDU check return value are formatted as a float while the database values > were stored as int (mysql) and bigint (postgresql). > This check fails against 2.0+ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133528#comment-16133528 ] ASF GitHub Bot commented on TC-441: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/98/ > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #838: [BACKPORT] [TC-441] - hooks up password...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/98/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133507#comment-16133507 ] ASF GitHub Bot commented on TC-441: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/60/ > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #838: [BACKPORT] [TC-441] - hooks up password...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/60/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133504#comment-16133504 ] ASF GitHub Bot commented on TC-441: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/58/ > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #838: [BACKPORT] [TC-441] - hooks up password...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/838 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/58/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133501#comment-16133501 ] ASF GitHub Bot commented on TC-441: --- GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/838 [BACKPORT] [TC-441] - hooks up password reset to TP (cherry picked from commit 421d390de80d5fa75a0d17488cf3a24bbe2fcc27) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol 2.1.x-tc-441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/838.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #838 commit caab9b148a16cd267d709aceaa99b3d7a0c0256d Author: Jeremy Mitchell Date: 2017-08-16T21:22:13Z hooks up password reset to TP (cherry picked from commit 421d390de80d5fa75a0d17488cf3a24bbe2fcc27) > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #838: [BACKPORT] [TC-441] - hooks up p...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/838 [BACKPORT] [TC-441] - hooks up password reset to TP (cherry picked from commit 421d390de80d5fa75a0d17488cf3a24bbe2fcc27) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol 2.1.x-tc-441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/838.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #838 commit caab9b148a16cd267d709aceaa99b3d7a0c0256d Author: Jeremy Mitchell Date: 2017-08-16T21:22:13Z hooks up password reset to TP (cherry picked from commit 421d390de80d5fa75a0d17488cf3a24bbe2fcc27) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hank Beatty closed TC-533.
--
Resolution: Fixed
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hank Beatty closed TC-374.
--
Resolution: Fixed
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133480#comment-16133480
]
ASF GitHub Bot commented on TC-374:
---
Github user hbeatty commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/837
@dangogh merged - please close
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #837: [BACKPORT] [TC-374] eliminate TO orphan...
Github user hbeatty commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/837 @dangogh merged - please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133479#comment-16133479
]
ASF GitHub Bot commented on TC-374:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/837
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/97/
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #837: [BACKPORT] [TC-374] eliminate TO orphan...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/837 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/97/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133469#comment-16133469
]
ASF GitHub Bot commented on TC-374:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/837
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/59/
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #837: [BACKPORT] [TC-374] eliminate TO orphan...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/837 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/59/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133466#comment-16133466
]
ASF GitHub Bot commented on TC-374:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/837
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/57/
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #837: [BACKPORT] [TC-374] eliminate TO orphan...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/837 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/57/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133456#comment-16133456
]
ASF GitHub Bot commented on TC-374:
---
GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/837
[BACKPORT] [TC-374] eliminate TO orphan processes
(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol
orphan-procs-2.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood
Date: 2017-08-16T18:31:28Z
handle orphan processes in TO
(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #837: [BACKPORT] [TC-374] eliminate TO...
GitHub user dangogh opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/837 [BACKPORT] [TC-374] eliminate TO orphan processes (cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dangogh/incubator-trafficcontrol orphan-procs-2.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/837.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #837 commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8 Author: Dan Kirkwood Date: 2017-08-16T18:31:28Z handle orphan processes in TO (cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #836: [BACKPORT] [TC-374] eliminate TO...
Github user dangogh closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133453#comment-16133453
]
ASF GitHub Bot commented on TC-374:
---
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/836
opened against master -- closing
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133454#comment-16133454
]
ASF GitHub Bot commented on TC-374:
---
Github user dangogh closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/836
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133451#comment-16133451
]
ASF GitHub Bot commented on TC-374:
---
GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/836
[BACKPORT] [TC-374] eliminate TO orphan processes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol
orphan-procs-2.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #836
commit a376bc0670ea137ceef7da7a6e26394600fc77b3
Author: Jeremy Mitchell
Date: 2017-08-09T14:58:10Z
fixes number validation on global max settings
(cherry picked from commit 8603bc83dfe9b667af54f9101028740940bac86f)
commit 66fa1115f3d27b83fc4cbf9f91878b46e86680b1
Author: hbeatty
Date: 2017-08-10T13:08:04Z
closes #792
commit aecd573437e6d765ee315e29bb4a98f51f348e19
Author: Steve Malenfant
Date: 2017-08-11T18:52:32Z
Remove reference to table "public" and match description
commit 7058a550ded22a5f94370ac9a5c1fd8b89707362
Author: Steve Malenfant
Date: 2017-08-11T19:13:13Z
Removed ".go" typo
commit 6aae6f47ff60b8723a54ccf7370e6b684aed3c36
Author: hbeatty
Date: 2017-08-15T16:56:53Z
This closes #797
commit fa18c96ed18d4caabf743cd1ee2a02e008a7
Author: Jeremy Mitchell
Date: 2017-08-15T16:44:56Z
accounts for missing dependency that centos 7.3 doesn't provide. when
centos 7.4 is available this dependency will be provided with the distro.
(cherry picked from commit 15901255c1847800bbd871e33c757017ec23f74f)
commit 53345aa1bf09fa90938c04c2134b543cd0aff434
Author: Steve Malenfant
Date: 2017-08-17T14:14:39Z
This closes #821
commit 1c9ce9eb9ce167d50d945aad085231f68f112bcf
Author: Jeremy Mitchell
Date: 2017-08-15T02:13:51Z
adds back missing tenants menu item
(cherry picked from commit a049589041ece51d6069cae09e2fdf23440d4a91)
commit a581e82a6eeb15a30b12b8a17dd2eb78cfca6bf7
Author: hbeatty
Date: 2017-08-17T17:02:53Z
This closes #814
This closes #TC-519
commit 4350faf99e5df17bc29ec3807885f3ec02ffbe48
Author: nir-sopher
Date: 2017-08-13T16:01:38Z
ssl_keys - tenancy checks
(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)
commit bad7062d2b8444e67da7d37dc373ee43cb7f1f0a
Author: hbeatty
Date: 2017-08-18T18:35:01Z
This closes #835
TC-533 #close fixed by GH PR #835
commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood
Date: 2017-08-16T18:31:28Z
handle orphan processes in TO
(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #836: [BACKPORT] [TC-374] eliminate TO orphan...
Github user dangogh commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/836 opened against master -- closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #836: [BACKPORT] [TC-374] eliminate TO...
GitHub user dangogh opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/836 [BACKPORT] [TC-374] eliminate TO orphan processes You can merge this pull request into a Git repository by running: $ git pull https://github.com/dangogh/incubator-trafficcontrol orphan-procs-2.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/836.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #836 commit a376bc0670ea137ceef7da7a6e26394600fc77b3 Author: Jeremy Mitchell Date: 2017-08-09T14:58:10Z fixes number validation on global max settings (cherry picked from commit 8603bc83dfe9b667af54f9101028740940bac86f) commit 66fa1115f3d27b83fc4cbf9f91878b46e86680b1 Author: hbeatty Date: 2017-08-10T13:08:04Z closes #792 commit aecd573437e6d765ee315e29bb4a98f51f348e19 Author: Steve Malenfant Date: 2017-08-11T18:52:32Z Remove reference to table "public" and match description commit 7058a550ded22a5f94370ac9a5c1fd8b89707362 Author: Steve Malenfant Date: 2017-08-11T19:13:13Z Removed ".go" typo commit 6aae6f47ff60b8723a54ccf7370e6b684aed3c36 Author: hbeatty Date: 2017-08-15T16:56:53Z This closes #797 commit fa18c96ed18d4caabf743cd1ee2a02e008a7 Author: Jeremy Mitchell Date: 2017-08-15T16:44:56Z accounts for missing dependency that centos 7.3 doesn't provide. when centos 7.4 is available this dependency will be provided with the distro. (cherry picked from commit 15901255c1847800bbd871e33c757017ec23f74f) commit 53345aa1bf09fa90938c04c2134b543cd0aff434 Author: Steve Malenfant Date: 2017-08-17T14:14:39Z This closes #821 commit 1c9ce9eb9ce167d50d945aad085231f68f112bcf Author: Jeremy Mitchell Date: 2017-08-15T02:13:51Z adds back missing tenants menu item (cherry picked from commit a049589041ece51d6069cae09e2fdf23440d4a91) commit a581e82a6eeb15a30b12b8a17dd2eb78cfca6bf7 Author: hbeatty Date: 2017-08-17T17:02:53Z This closes #814 This closes #TC-519 commit 4350faf99e5df17bc29ec3807885f3ec02ffbe48 Author: nir-sopher Date: 2017-08-13T16:01:38Z ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) commit bad7062d2b8444e67da7d37dc373ee43cb7f1f0a Author: hbeatty Date: 2017-08-18T18:35:01Z This closes #835 TC-533 #close fixed by GH PR #835 commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8 Author: Dan Kirkwood Date: 2017-08-16T18:31:28Z handle orphan processes in TO (cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-519) TP - tenants menu item mistakenly removed from TP
[ https://issues.apache.org/jira/browse/TC-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133449#comment-16133449 ] ASF GitHub Bot commented on TC-519: --- Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/814 > TP - tenants menu item mistakenly removed from TP > - > > Key: TC-519 > URL: https://issues.apache.org/jira/browse/TC-519 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0, 2.2.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > Fix For: 2.1.0, 2.2.0 > > > Somehow the tenants menu was mistakenly removed from TP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133447#comment-16133447
]
ASF GitHub Bot commented on TC-533:
---
Github user hbeatty commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/835
@mitchell852 merged - please close
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-519) TP - tenants menu item mistakenly removed from TP
[ https://issues.apache.org/jira/browse/TC-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133448#comment-16133448 ] ASF GitHub Bot commented on TC-519: --- Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/814 manually closing > TP - tenants menu item mistakenly removed from TP > - > > Key: TC-519 > URL: https://issues.apache.org/jira/browse/TC-519 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0, 2.2.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > Fix For: 2.1.0, 2.2.0 > > > Somehow the tenants menu was mistakenly removed from TP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #814: [BACKPORT] [TC-519] - adds back ...
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #814: [BACKPORT] [TC-519] - adds back missing...
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/814 manually closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #835: [BACKPORT] [TC-533] - ssl_keys - tenanc...
Github user hbeatty commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/835 @mitchell852 merged - please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133419#comment-16133419
]
ASF GitHub Bot commented on TC-533:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/835
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/96/
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #835: [BACKPORT] [TC-533] - ssl_keys - tenanc...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/835 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/96/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133397#comment-16133397
]
ASF GitHub Bot commented on TC-533:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/835
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/58/
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #835: [BACKPORT] [TC-533] - ssl_keys - tenanc...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/835 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/58/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133396#comment-16133396
]
ASF GitHub Bot commented on TC-533:
---
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/835
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/56/
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #835: [BACKPORT] [TC-533] - ssl_keys - tenanc...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/835 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/56/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133392#comment-16133392
]
ASF GitHub Bot commented on TC-533:
---
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/835
[BACKPORT] [TC-533] - ssl_keys - tenancy checks
(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol
2.1.x-ssl-keys-tenant-tc-533
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/835.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #835
commit 625181df3e872721a3f814660fbc21505fcd24ee
Author: nir-sopher
Date: 2017-08-13T16:01:38Z
ssl_keys - tenancy checks
(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #835: [BACKPORT] [TC-533] - ssl_keys -...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/835 [BACKPORT] [TC-533] - ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol 2.1.x-ssl-keys-tenant-tc-533 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/835.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #835 commit 625181df3e872721a3f814660fbc21505fcd24ee Author: nir-sopher Date: 2017-08-13T16:01:38Z ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133379#comment-16133379
]
ASF GitHub Bot commented on TC-533:
---
Github user mitchell852 closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/834
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #834: [BACKPORT] [TC-533] - ssl_keys -...
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133374#comment-16133374
]
ASF GitHub Bot commented on TC-533:
---
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/834
[BACKPORT] [TC-533] - ssl_keys - tenancy checks
(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol
tc-533-2.1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #834
commit cecadabea9b7ff8779764f69ee666c2f359ef649
Author: nir-sopher
Date: 2017-08-13T16:01:38Z
ssl_keys - tenancy checks
(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #834: [BACKPORT] [TC-533] - ssl_keys -...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/834 [BACKPORT] [TC-533] - ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-533-2.1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/834.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #834 commit cecadabea9b7ff8779764f69ee666c2f359ef649 Author: nir-sopher Date: 2017-08-13T16:01:38Z ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133314#comment-16133314
]
ASF GitHub Bot commented on TC-533:
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/832
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #832: [TC-533] ssl_keys - tenancy chec...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-441) TPv2 - implement password reset functionality
[ https://issues.apache.org/jira/browse/TC-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133299#comment-16133299 ] ASF GitHub Bot commented on TC-441: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/825 > TPv2 - implement password reset functionality > - > > Key: TC-441 > URL: https://issues.apache.org/jira/browse/TC-441 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > > implement password reset functionality -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #825: [TC-441] - hooks up password res...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133276#comment-16133276
]
ASF GitHub Bot commented on TC-535:
---
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007130
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -69,14 +86,17 @@ sub copy_url_sig_keys {
else {
return $self->alert("Delivery Service to copy from
'$copy_from_xml_id' does not exist.");
}
+ if (!$tenant_utils->is_ds_resource_accessible($tenants_data,
$copy_rs->tenant_id)) {
+ return $self->forbidden("Forbidden. Source delivery-service
tenant is not available to the user.");
+ }
my $copy_config_file =
$self->url_sig_config_file_name($copy_from_xml_id);
my $helper = new Utils::Helper( { mojo => $self } );
my $url_sig_key_values_json;
#verify we can copy keys out
if ( $helper->is_valid_delivery_service($copy_ds_id) ) {
- if ( $is_admin ||
$helper->is_delivery_service_assigned($copy_ds_id) ) {
+ if ( $is_admin ||
$helper->is_delivery_service_assigned($copy_ds_id) ||
$tenant_utils->use_tenancy()) {
--- End diff --
I don't understand this line. If use_tenancy is 1 then it doesn't matter if
you are an admin or you have the ds assigned you simply have to have the right
tenant.right?
> DS URL sig key apis needs to have tenancy check in place
>
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133277#comment-16133277
]
ASF GitHub Bot commented on TC-535:
---
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007307
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -134,17 +154,22 @@ sub generate {
my $current_user = $self->current_user()->{username};
&log( $self, "Generated new url_sig_keys for " . $xml_id, "APICHANGE" );
+ my $tenant_utils = Utils::Tenant->new($self);
+ my $tenants_data = $tenant_utils->create_tenants_data_from_db();
my $rs = $self->db->resultset("Deliveryservice")->find( { xml_id =>
$xml_id } );
my $ds_id;
if ( defined($rs) ) {
$ds_id = $rs->id;
+ if (!$tenant_utils->is_ds_resource_accessible($tenants_data,
$rs->tenant_id)) {
+ return $self->forbidden("Forbidden. Delivery-service
tenant is not available to the user.");
+ }
}
my $helper = new Utils::Helper( { mojo => $self } );
# Admins can always do this, otherwise verify the user
if ( ( defined($rs) && $helper->is_valid_delivery_service($ds_id) ) ) {
- if ( &is_admin($self) ||
$helper->is_delivery_service_assigned($ds_id) ) {
+ if ( &is_admin($self) ||
$helper->is_delivery_service_assigned($ds_id) || $tenant_utils->use_tenancy()) {
--- End diff --
same comment as before
> DS URL sig key apis needs to have tenancy check in place
>
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133275#comment-16133275
]
ASF GitHub Bot commented on TC-535:
---
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007263
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -98,7 +118,7 @@ sub copy_url_sig_keys {
if ( defined($url_sig_key_values_json) ) { # verify we got keys copied
# Admins can always do this, otherwise verify the user
if ( $helper->is_valid_delivery_service($ds_id) ) {
- if ( $is_admin ||
$helper->is_delivery_service_assigned($ds_id) ) {
+ if ( $is_admin ||
$helper->is_delivery_service_assigned($ds_id) || $tenant_utils->use_tenancy()) {
--- End diff --
same comment as before
> DS URL sig key apis needs to have tenancy check in place
>
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-535) DS URL sig key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133278#comment-16133278
]
ASF GitHub Bot commented on TC-535:
---
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007236
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -98,7 +118,7 @@ sub copy_url_sig_keys {
if ( defined($url_sig_key_values_json) ) { # verify we got keys copied
# Admins can always do this, otherwise verify the user
--- End diff --
this comment is not true. admins cannot always do this anymore. not if
use_tenancy=1
> DS URL sig key apis needs to have tenancy check in place
>
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007307
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -134,17 +154,22 @@ sub generate {
my $current_user = $self->current_user()->{username};
&log( $self, "Generated new url_sig_keys for " . $xml_id, "APICHANGE" );
+ my $tenant_utils = Utils::Tenant->new($self);
+ my $tenants_data = $tenant_utils->create_tenants_data_from_db();
my $rs = $self->db->resultset("Deliveryservice")->find( { xml_id =>
$xml_id } );
my $ds_id;
if ( defined($rs) ) {
$ds_id = $rs->id;
+ if (!$tenant_utils->is_ds_resource_accessible($tenants_data,
$rs->tenant_id)) {
+ return $self->forbidden("Forbidden. Delivery-service
tenant is not available to the user.");
+ }
}
my $helper = new Utils::Helper( { mojo => $self } );
# Admins can always do this, otherwise verify the user
if ( ( defined($rs) && $helper->is_valid_delivery_service($ds_id) ) ) {
- if ( &is_admin($self) ||
$helper->is_delivery_service_assigned($ds_id) ) {
+ if ( &is_admin($self) ||
$helper->is_delivery_service_assigned($ds_id) || $tenant_utils->use_tenancy()) {
--- End diff --
same comment as before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007130
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -69,14 +86,17 @@ sub copy_url_sig_keys {
else {
return $self->alert("Delivery Service to copy from
'$copy_from_xml_id' does not exist.");
}
+ if (!$tenant_utils->is_ds_resource_accessible($tenants_data,
$copy_rs->tenant_id)) {
+ return $self->forbidden("Forbidden. Source delivery-service
tenant is not available to the user.");
+ }
my $copy_config_file =
$self->url_sig_config_file_name($copy_from_xml_id);
my $helper = new Utils::Helper( { mojo => $self } );
my $url_sig_key_values_json;
#verify we can copy keys out
if ( $helper->is_valid_delivery_service($copy_ds_id) ) {
- if ( $is_admin ||
$helper->is_delivery_service_assigned($copy_ds_id) ) {
+ if ( $is_admin ||
$helper->is_delivery_service_assigned($copy_ds_id) ||
$tenant_utils->use_tenancy()) {
--- End diff --
I don't understand this line. If use_tenancy is 1 then it doesn't matter if
you are an admin or you have the ds assigned you simply have to have the right
tenant.right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007236
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -98,7 +118,7 @@ sub copy_url_sig_keys {
if ( defined($url_sig_key_values_json) ) { # verify we got keys copied
# Admins can always do this, otherwise verify the user
--- End diff --
this comment is not true. admins cannot always do this anymore. not if
use_tenancy=1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007263
--- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
@@ -98,7 +118,7 @@ sub copy_url_sig_keys {
if ( defined($url_sig_key_values_json) ) { # verify we got keys copied
# Admins can always do this, otherwise verify the user
if ( $helper->is_valid_delivery_service($ds_id) ) {
- if ( $is_admin ||
$helper->is_delivery_service_assigned($ds_id) ) {
+ if ( $is_admin ||
$helper->is_delivery_service_assigned($ds_id) || $tenant_utils->use_tenancy()) {
--- End diff --
same comment as before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Updated] (TC-291) GenIso can't handle concurrent requests
[
https://issues.apache.org/jira/browse/TC-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dewayne Richardson updated TC-291:
--
Issue Type: Improvement (was: Bug)
> GenIso can't handle concurrent requests
>
>
> Key: TC-291
> URL: https://issues.apache.org/jira/browse/TC-291
> Project: Traffic Control
> Issue Type: Improvement
> Components: Traffic Ops
>Affects Versions: 2.1.0, 2.0.0, 2.2.0
>Reporter: Dewayne Richardson
> Labels: genlso
> Fix For: 2.1.0, 2.2.0
>
>
> Because GenIso always changes the same files (no temporary directories
> created), it can't handle concurrent requests. We sometimes send commands to
> create 10 Edge Caches at the same time and we found out that the wrong IP
> address shows up on servers.
> I've got the code to fix it up (but need to sign our paperwork). But our
> GenIso.pm now deviates from what's in Traffic Ops because we wanted to keep
> the 1.0.0 functionality (don't use the install_cfg directory, keep using the
> simple network line).
> Suggestion: We should have a parameter to call different ISO generator
> scripts. Seems like this is implementation specific and not really a core
> function of Traffic Ops.
> Basic changes :
> use File::Temp;
> use File::Copy::Recursive;
> my $tmpdir = File::Temp::tempdir(CLEANUP => 1);
> ...
> GenIso.pm:my $tmp = File::Copy::Recursive::dircopy($dir,$tmpdir);
> GenIso.pm: my $cfg_dir = "$tmpdir/$install_cfg";
> GenIso.pm: print STUF "Dir== $tmpdir\n";
> GenIso.pm: my $cmd = "mkisofs -joliet-long -input-charset utf-8 -b
> isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4
> -boot-info-table -R -J -v -T $tmpdir";
> GenIso.pm: open(IN, "<$tmpdir/ks.src") || die("$tmpdir/ks.src:$!");
> GenIso.pm: open (OUT, ">$tmpdir/ks.cfg") || die("$tmpdir/ks.cfg:$!");
> GenIso.pm:File::Path::rmtree $tmpdir;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TC-374) `systemctl stop traffic_ops` does not kill all processes
[
https://issues.apache.org/jira/browse/TC-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133256#comment-16133256
]
ASF GitHub Bot commented on TC-374:
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/823
> `systemctl stop traffic_ops` does not kill all processes
>
>
> Key: TC-374
> URL: https://issues.apache.org/jira/browse/TC-374
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
>Affects Versions: 2.1.0
>Reporter: Dan Kirkwood
>Assignee: Dan Kirkwood
> Labels: systemctl
> Fix For: 2.1.0, 2.2.0
>
>
> not sure why it gets in this state, but traffic_ops processes sometimes get
> in a state where the parent process is the root (1) for many of the
> script/cdn workers. The init.d script doesn't stop them because they don't
> match the pid in `/var/run/traffic_ops.pid`.
> This needs to be more robust.
> Example: on my test VM, if I run this, I see multiple parent processes:
> {quote}
> ps -ef | grep script/cdn|grep -v root | awk '\{print $3\}' | sort -u
> 1
> 22713
> 29306
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #823: [TC-374] handle orphan processes...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/823 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-523) Assigning servers to Delivery services doesn't work in TP
[ https://issues.apache.org/jira/browse/TC-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133229#comment-16133229 ] David Neuman commented on TC-523: - Thanks Jeremy. I will close this issue. > Assigning servers to Delivery services doesn't work in TP > - > > Key: TC-523 > URL: https://issues.apache.org/jira/browse/TC-523 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.2.0 >Reporter: David Neuman >Assignee: Jeremy Mitchell > Fix For: 2.2.0 > > > In Traffic Portal, if I create a new DS and try to assign servers to it, the > servers are not assigned to the DS. I don't get an error, but the servers are > not assigned. The workaround is to go to Traffic Ops and assign the servers > there. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (TC-523) Assigning servers to Delivery services doesn't work in TP
[ https://issues.apache.org/jira/browse/TC-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Neuman closed TC-523. --- Resolution: Not A Bug > Assigning servers to Delivery services doesn't work in TP > - > > Key: TC-523 > URL: https://issues.apache.org/jira/browse/TC-523 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.2.0 >Reporter: David Neuman >Assignee: Jeremy Mitchell > Fix For: 2.2.0 > > > In Traffic Portal, if I create a new DS and try to assign servers to it, the > servers are not assigned to the DS. I don't get an error, but the servers are > not assigned. The workaround is to go to Traffic Ops and assign the servers > there. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol pull request #820: added a secure flag to start.pl
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/820 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-523) Assigning servers to Delivery services doesn't work in TP
[ https://issues.apache.org/jira/browse/TC-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133216#comment-16133216 ] Jeremy Mitchell commented on TC-523: Errors like this happen if the version of TP != the version of TO. Sometimes if you are running a newer version of TP it might depend on an API that is not in your TO. This usually results in a 404 when you inspect Chrome dev tools, network tab. If that's the case and you are seeing a 404, upgrade your TO and you should be good to go. > Assigning servers to Delivery services doesn't work in TP > - > > Key: TC-523 > URL: https://issues.apache.org/jira/browse/TC-523 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.2.0 >Reporter: David Neuman >Assignee: Jeremy Mitchell > Fix For: 2.2.0 > > > In Traffic Portal, if I create a new DS and try to assign servers to it, the > servers are not assigned to the DS. I don't get an error, but the servers are > not assigned. The workaround is to go to Traffic Ops and assign the servers > there. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (TC-523) Assigning servers to Delivery services doesn't work in TP
[ https://issues.apache.org/jira/browse/TC-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Mitchell reassigned TC-523: -- Assignee: Jeremy Mitchell > Assigning servers to Delivery services doesn't work in TP > - > > Key: TC-523 > URL: https://issues.apache.org/jira/browse/TC-523 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.2.0 >Reporter: David Neuman >Assignee: Jeremy Mitchell > Fix For: 2.2.0 > > > In Traffic Portal, if I create a new DS and try to assign servers to it, the > servers are not assigned to the DS. I don't get an error, but the servers are > not assigned. The workaround is to go to Traffic Ops and assign the servers > there. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #820: added a secure flag to start.pl
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/820 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/95/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #820: added a secure flag to start.pl
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/820 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/57/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #820: added a secure flag to start.pl
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/820 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/55/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133201#comment-16133201 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/94/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/94/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133110#comment-16133110 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/56/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/56/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133108#comment-16133108 ] ASF GitHub Bot commented on TC-541: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/54/ > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-trafficcontrol issue #833: [TC-541] - TPv2 - turning on saveState ...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/833 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/54/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #833: [TC-541] - TPv2 - turning on sav...
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/833 [TC-541] - TPv2 - turning on saveState for all tables You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tpv2-preserve-table-filters Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/833.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #833 commit 581826a52a58c23a34bd3852377a7b3c5c362204 Author: Jeremy Mitchell Date: 2017-08-18T15:08:39Z turning on saveState for all TPv2 tables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TC-541) TPv2 - save the state of table filtering, ordering, etc
[ https://issues.apache.org/jira/browse/TC-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133097#comment-16133097 ] ASF GitHub Bot commented on TC-541: --- GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/833 [TC-541] - TPv2 - turning on saveState for all tables You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tpv2-preserve-table-filters Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/833.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #833 commit 581826a52a58c23a34bd3852377a7b3c5c362204 Author: Jeremy Mitchell Date: 2017-08-18T15:08:39Z turning on saveState for all TPv2 tables > TPv2 - save the state of table filtering, ordering, etc > --- > > Key: TC-541 > URL: https://issues.apache.org/jira/browse/TC-541 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Portal >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell >Priority: Minor > > Currently for any of the tables in TPv2 lose their state (filtering, > ordering, etc) when you navigate away from them. This requires the user to > reenter the filter or reorder the table when they return to it which can be > quite time consuming. > Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TC-541) TPv2 - save the state of table filtering, ordering, etc
Jeremy Mitchell created TC-541: -- Summary: TPv2 - save the state of table filtering, ordering, etc Key: TC-541 URL: https://issues.apache.org/jira/browse/TC-541 Project: Traffic Control Issue Type: Improvement Components: Traffic Portal Reporter: Jeremy Mitchell Assignee: Jeremy Mitchell Priority: Minor Currently for any of the tables in TPv2 lose their state (filtering, ordering, etc) when you navigate away from them. This requires the user to reenter the filter or reorder the table when they return to it which can be quite time consuming. Configure the tables to save their state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (TC-514) ORT: Change Traffic Ops hostname in middle of ORT run
[
https://issues.apache.org/jira/browse/TC-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hank Beatty updated TC-514:
---
Fix Version/s: 2.1.0
> ORT: Change Traffic Ops hostname in middle of ORT run
> -
>
> Key: TC-514
> URL: https://issues.apache.org/jira/browse/TC-514
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops ORT
>Affects Versions: 2.1.0, 2.2.0
> Environment: Traffic Ops 2.1 and ORT 2.1
>Reporter: Steve Malenfant
>Assignee: Steve Malenfant
>Priority: Minor
> Fix For: 2.1.0, 2.2.0
>
>
> I'm not sure if this is 2.1 specifics... Worth discussing.
> - Could this prevent load balancing traffic ops from working?
> - Cookies might be different (you need to sync secrets?). These are in the
> cdn.conf and not the database...
> When you instruct the traffic_ops_ort to go to a secondary Traffic Ops, it
> will start on the CLI designated but will move back to the primary during the
> "Start processing packages" process.
> Code in question :
> https://github.com/apache/incubator-trafficcontrol/blob/2.1.x/traffic_ops/bin/traffic_ops_ort.pl#L201
> {code:java}
> [root@edge06 ~]# /opt/ort/traffic_ops_ort.pl -dispersion=0 report DEBUG
> https://traffic-ops-0002.coxlab.net chs:w@term@rk
> Mon Aug 14 13:29:06 UTC 2017
> DEBUG OS release is EL7.
> DEBUG Script running in report mode.
> 302
> DEBUG https://traffic-ops-0002.coxlab.net/login returned HTTP 302.
> DEBUG Cookie is
> mojolicious=eyJhdXRoX2RhdGEi4iJjaHMiLCJleHBpcmVzIjoxNTAyNzMxNzQ2fQ136010205dc8d4951e2e2194b6b463eb3d141f1e.
> DEBUG YUM_OPTS: .
> DEBUG Total connections in LWP cache: 1
> INFO Traffic Ops host: https://traffic-ops-0002.coxlab.net
> ...
> INFO: Start processing packages
> DEBUG Total connections in LWP cache: 1
> INFO Traffic Ops host: https://traffic-ops-0001.coxlab.net
> DEBUG lwp_get called with /ort/psp6cdedge06/packages
> ERROR https://traffic-ops-0001.coxlab.net/ort/edge06/packages returned HTTP
> 401! Unauthorized
> ERROR result for https://traffic-ops-0001/ort/psp6cdedge06/packages is:
> ...
[jira] [Closed] (TC-519) TP - tenants menu item mistakenly removed from TP
[ https://issues.apache.org/jira/browse/TC-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hank Beatty closed TC-519. -- Resolution: Fixed merged PR > TP - tenants menu item mistakenly removed from TP > - > > Key: TC-519 > URL: https://issues.apache.org/jira/browse/TC-519 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Portal >Affects Versions: 2.1.0, 2.2.0 >Reporter: Jeremy Mitchell >Assignee: Jeremy Mitchell > Fix For: 2.1.0, 2.2.0 > > > Somehow the tenants menu was mistakenly removed from TP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (TC-518) ToCDUCheck and ToCHRCheck: Value formatted as float instead of int
[ https://issues.apache.org/jira/browse/TC-518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hank Beatty updated TC-518: --- Fix Version/s: 2.1.0 > ToCDUCheck and ToCHRCheck: Value formatted as float instead of int > -- > > Key: TC-518 > URL: https://issues.apache.org/jira/browse/TC-518 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops >Affects Versions: 2.1.0, 2.0.0, 2.2.0 >Reporter: Steve Malenfant >Priority: Trivial > Fix For: 2.1.0, 2.2.0 > > > CDU check return value are formatted as a float while the database values > were stored as int (mysql) and bigint (postgresql). > This check fails against 2.0+ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (TC-533) DS SSL key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hank Beatty updated TC-533:
---
Fix Version/s: 2.2.0
2.1.0
> DS SSL key apis needs to have tenancy check in place
>
>
> Key: TC-533
> URL: https://issues.apache.org/jira/browse/TC-533
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> get("/api/$version/deliveryservices/xmlId/#xmlid/sslkeys
> post("/api/$version/deliveryservices/sslkeys/generate
> post("/api/$version/deliveryservices/sslkeys/add
> get("/api/$version/deliveryservices/xmlId/:xmlid/sslkeys/delete
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (TC-535) DS URL sig key apis needs to have tenancy check in place
[
https://issues.apache.org/jira/browse/TC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hank Beatty updated TC-535:
---
Fix Version/s: 2.2.0
2.1.0
> DS URL sig key apis needs to have tenancy check in place
>
>
> Key: TC-535
> URL: https://issues.apache.org/jira/browse/TC-535
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops API
>Affects Versions: 2.1.0
>Reporter: Jeremy Mitchell
>Assignee: Nir Sopher
> Fix For: 2.1.0, 2.2.0
>
>
> Tenancy was introduced in 2.1, however, by default it is turned off via the
> use_tenancy parameter but when activated it is used to limit the scope of
> delivery services that a user can act on.
> The following APIs needs to check tenancy to ensure users cannot act on ds's
> that they don't have access to.
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/generate
> post("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys/copyFromXmlId/:copyFromXmlId
> get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
