[GitHub] incubator-trafficcontrol issue #855: [TC-547] Fix regression issues caused b...
Github user DylanVolz commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/855 @zhilhuan Yes that was a build server issue that should be resolved now. This PR looks good; it reverts the breaking changes introduced by the change from xmlId to id in the keysto store ssl keys in riak. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #853: WIP [TC-443] - add the ability t...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/853 WIP [TC-443] - add the ability to manage ssl keys to TPv2 waiting to merge on https://issues.apache.org/jira/browse/TC-547 You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol ssl-key-management-ui Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #853 commit af41ade59a9b8cd8630d652e929349328459e031 Author: Dylan Volz Date: 2017-08-10T17:15:19Z add the ability to manage ssl keys to TPv2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #790: WIP - [TC-336] build ui for managing ur...
Github user DylanVolz commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/790 waiting to merge on https://issues.apache.org/jira/browse/TC-547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #790: [TC-336] build ui for managing u...
Github user DylanVolz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134556388
--- Diff:
traffic_portal/app/src/common/api/DeliveryServiceUrlSigKeysService.js ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var DeliveryServiceUrlSigKeysService = function(locationUtils,
messageModel, $http, $q, ENV) {
+
+ this.generateUrlSigKeys = function(dsXmlId) {
+ var request = $q.defer();
+ $http.post(ENV.api['root'] + 'deliveryservices/xmlId/' +
dsXmlId + '/urlkeys/generate')
+ .then(
+ function(result) {
+ messageModel.setMessages([ { level: 'success',
text: 'URL Sig Keys generated' } ], true);
--- End diff --
fault message included properly now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #790: [TC-336] build ui for managing u...
Github user DylanVolz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134556400
--- Diff:
traffic_portal/app/src/common/api/DeliveryServiceUrlSigKeysService.js ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+var DeliveryServiceUrlSigKeysService = function(locationUtils,
messageModel, $http, $q, ENV) {
+
+ this.generateUrlSigKeys = function(dsXmlId) {
+ var request = $q.defer();
+ $http.post(ENV.api['root'] + 'deliveryservices/xmlId/' +
dsXmlId + '/urlkeys/generate')
+ .then(
+ function(result) {
+ messageModel.setMessages([ { level: 'success',
text: 'URL Sig Keys generated' } ], true);
+ request.resolve();
+ },
+ function() {
+ messageModel.setMessages(fault.data.alerts,
false);
+ request.reject();
+ }
+ );
+ return request.promise;
+ };
+
+ this.copyUrlSigKeys = function(dsXmlId, copyFromXmlId) {
+ var request = $q.defer();
+$http.post(ENV.api['root'] + 'deliveryservices/xmlId/' +
dsXmlId + '/urlkeys/copyFromXmlId/' + copyFromXmlId)
+ .then(
+ function(result) {
+ messageModel.setMessages([ { level: 'success',
text: 'URL Sig Keys copied' } ], true);
--- End diff --
fault message included properly now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #790: [TC-336] build ui for managing u...
Github user DylanVolz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134555976
--- Diff: traffic_ops/app/lib/TrafficOpsRoutes.pm ---
@@ -571,6 +571,11 @@ sub api_routes {
->to( 'KeysUrlSig#copy_url_sig_keys', namespace =>
'API::DeliveryService' );
$r->get("/api/$version/deliveryservices/xmlId/:xmlId/urlkeys")->over(
authenticated => 1, not_ldap => 1 )
->to( 'KeysUrlSig#view_by_xmlid', namespace =>
'API::DeliveryService' );
+ # -- DELIVERY SERVICE: VIEW URL SIG KEYS BY ID
+ $r->get("/api/$version/deliveryservices/:id/urlkeys")->over(
authenticated => 1, not_ldap => 1 )
--- End diff --
documentation has now been added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #790: [CDN-240] build ui for managing ...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/790 [CDN-240] build ui for managing url sig keys, this also adds a view by id route for url sig keys and adds auditing to the copy keys api route You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol url-sig-key-ui Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/790.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #790 commit 28aeeb62adf09a97e2e9db59da978f9c33865e7f Author: Dylan Volz Date: 2017-08-04T16:35:17Z [CDN-240] build ui for managing url sig keys, this also adds a view by id route for url sig keys and adds auditing to the copy keys api route --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #360: [TC-187] fix HTTPs bugs
Github user DylanVolz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/360#discussion_r131963435
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -846,8 +842,11 @@ sub update {
$hash{http_bypass_fqdn} =
$self->param('ds.http_bypass_fqdn');
}
+ my $upd_ssl = 0;
#print Dumper( \%hash );
my $update = $self->db->resultset('Deliveryservice')->find( {
id => $id } );
+ $upd_ssl = 1 if $update->xml_id ne $hash{xml_id};
--- End diff --
This line is may be unnecessary now that [TC-402] was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #779: switch json_is asserts that reli...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/779 switch json_is asserts that relied on ordering to content_like asserts in server.t You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol remove-server-test-flaps Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/779.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #779 commit 3b1bcf8a9b106b80f0d86863e305951bc4d1f4f4 Author: Dylan Volz Date: 2017-08-04T21:53:33Z switch json_is asserts that relied on ordering to content_like asserts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #733: Add ability to copy url sig keys and fi...
Github user DylanVolz commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/733 I have reverted the UI changes, and this PR is ready to be evaluated as an API change only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #763: refactor logic to check for duplicate r...
Github user DylanVolz commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/763 WIP - Enhancing testing as the conflicting regex check was never tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #763: refactor logic to check for dupl...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/763 refactor logic to check for duplicate regexes in a cdn to reduce db IO time DS updates were taking around 25 seconds and failing if they had a second host regex added. With a large number of DSes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol fix-ds-update-regex-check Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/763.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #763 commit 77a81c3572632d0bd917a47e092845e0ea436e53 Author: Dylan Volz Date: 2017-07-27T22:28:09Z this refactors the logic to check for duplicate regexes in a cdn to drop db IO time from ~20 secs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...
Github user DylanVolz commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 I hadn't known about that table, added now. Does this mean that portal users would get the ds-write capability and is that what we want? Wouldn't they then be able to hit the other endpoints and make breaking changes etc, I am wondering if the more granular approach of a "safe" capability is needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/740 add safe (limited field) update endpoint to delivery service crud You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol safe-self-service Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #740 commit 2c6b737db4d28f99daa0abeb08625a1ae7ff9736 Author: Dylan Volz Date: 2017-07-11T15:23:34Z add safe (limited field) update endpoint to delivery service crud --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #733: Add ability to copy url sig keys...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/733 Add ability to copy url sig keys and fix view url sig keys fixes https://ccp.sys.comcast.net/browse/SCDN-41 fixes https://ccp.sys.comcast.net/browse/SCDN-42 You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol copy-url-sig-keys Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #733 commit 1c2ff586540b98f388615c1c44c34a020a022b2b Author: Dylan Volz Date: 2017-06-29T19:38:55Z add a route to copy url sig keys from one delivery service to another commit 6e422bcfdcc22b47bc45cec21f8a8f17e4cec7c4 Author: Dylan Volz Date: 2017-07-13T20:20:46Z add riak error message logging commit afb39aa4f136b754a2d3a07bd1d79328aee7d03a Author: Dylan Volz Date: 2017-07-13T20:50:15Z enhance testing to validate the url sig keys were copied commit 81336c498c33c68e0a6a2013202c64e52dae2763 Author: Dylan Volz Date: 2017-07-14T15:58:20Z update copy url sig keys endpoint url format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #721: fix use of hash as reference err...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/721 fix use of hash as reference error in email blacklist lookup You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol fix-validation-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #721 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol pull request #614: remove moneyTrace reference from...
GitHub user DylanVolz opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/614 remove moneyTrace reference from LogFormat.Format select statement the LogFormat.Format parameter is inserted, properly, without the X-MoneyTrace header expression, but when selecting the id of the parameter the select statement expected the X-MoneyTrace header expression causing it fail. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DylanVolz/incubator-trafficcontrol fixLogFormatSqlStatement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafficcontrol/pull/614.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #614 commit b8210a9749ee50651bb85e6f9ffef57729356581 Author: Dylan Volz Date: 2017-05-25T15:59:41Z remove moneyTrace log expression from LogFormat.format parameter select statement in edge profile sql --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
